From: Songjun Wu songjun...@atmel.com
When unloading the module 'g_hid.ko', the urb request will be dequeued and the
completion routine will be excuted. If there is no urb packet, the urb request
will not be added to the endpoint queue and the completion routine pointer in
urb request is NULL.
Hi Greg
Only one patch to solve the retry issue with reading device descriptors.
Hopefully fixes Linus needing to re-plug his usb keyboard to make it work.
Same fix solves some extra device resets done at resume.
-Mathias
Mathias Nyman (1):
xhci: Check if slot is already in default state
Solves xhci error cases with debug messages:
xhci_hcd :00:14.0: Setup ERROR: setup context command for slot 1.
usb 1-6: hub failed to enable device, error -22
xhci will give a context state error if we try to set a slot in default
state to the same default state with a special address device
Some parameters are not used by functions in xhci-mem.c, just
remove it.
Changes compared to v1:
- Rebase to the latest usb-next branch
Signed-off-by: Lin Wang lin.x.w...@intel.com
---
drivers/usb/host/xhci-dbg.c |2 +-
drivers/usb/host/xhci-mem.c | 21 +
-Original Message-
From: Dinh Nguyen [mailto:dingu...@opensource.altera.com]
Sent: Thursday, January 8, 2015 5:34 PM
To: Kaukab, Yousaf; 'Paul Zimmerman'; 'linux-usb@vger.kernel.org';
'ba...@ti.com'
Cc: Herrero, Gregory; 'sergei.shtyl...@cogentembedded.com';
'r.bald...@samsung.com'
W dniu 08.01.2015 o 18:09, Felipe Balbi pisze:
Hi,
On Thu, Jan 08, 2015 at 09:05:24AM -0800, Chris McClimans wrote:
I'm trying to get the g_hid module working with the Intel Edison.
I tried just compiling intel's patch(1) to 3.10.17 with
CONFIG_USB_GADGETFS=m CONFIG_USB_G_HID=m but I get an
Hi,
-Original Message-
From: Sergei Shtylyov [mailto:sergei.shtyl...@cogentembedded.com]
Sent: Friday, January 2, 2015 6:09 PM
To: Kaukab, Yousaf; linux-usb@vger.kernel.org; ba...@ti.com
Cc: Herrero, Gregory; pa...@synopsys.com; r.bald...@samsung.com
Subject: Re: [PATCH v2 03/30]
Hi Chris
On 2015-01-08 at 17:38:07 +0100, Chris McClimans ch...@hippiehacker.org wrote:
I found your email in the commits for gadget_hid.txt and thought one of you
might might be able to point me in the right direction. I'm trying to get
the g_hid module working with the Intel Edison.
Please
On Wed, Dec 31, 2014 at 09:10:32PM +, Thomas Eriksson wrote:
Sorry, was a bit hasty there. Should have tested properly.
The US_FL_NO_ATA_1X flag does not fix this problem, but the US_FL_IGNORE_UAS
flag does.
The patch should be
*** unusual_uas.h.orig2014-12-18
On Fri, Dec 05, 2014 at 02:48:19PM +, Mark Knibbs wrote:
I recently posted a patch (storage: Add quirk for another SCM-based
USB-SCSI converter) to add a quirk for the converter with ID 04E6:000F,
which is listed along with 04E6:000B in the Windows INF file for the
Startech ICUSBSCSI2 as
On Fri, 9 Jan 2015, Peter Chen wrote:
For chipidea, its resume sequence is not-EHCI compatible, see
below description for FPR at portsc. So in order to send SoF in
time for remote wakeup sequence(within 3ms), the RUN/STOP bit must
be set before the resume signal is ended, but the usb resume
On Mon, Dec 29, 2014 at 06:02:45PM +0200, Dmitry Nezhevenko wrote:
It looks like FUA support is broken on JMicron 152d:2566 bridge:
[223159.885704] sd 7:0:0:0: [sdc] Write Protect is off
[223159.885706] sd 7:0:0:0: [sdc] Mode Sense: 47 00 10 08
[223159.885942] sd 7:0:0:0: [sdc] Write cache:
Hi,
On Tue, Dec 30, 2014 at 01:49:28PM +0200, Laurent Pinchart wrote:
Hello,
This patch set adds UDC support to the isp1760 driver, to be used with the
ISP1761 dual-role USB controller.
The first 17 patches rework the isp1760 driver to prepare it for UDC support.
In particular they
Hi,
On Fri, Jan 09, 2015 at 11:30:31AM -0600, Felipe Balbi wrote:
This patch set adds UDC support to the isp1760 driver, to be used with the
ISP1761 dual-role USB controller.
The first 17 patches rework the isp1760 driver to prepare it for UDC
support.
In particular they removes the
CCing more of the Samsung folks and linux-kernel.
Robert, Marek, can you test this series on your platform, please? If
I don't hear from you soon, I'll just ack it and we can deal with any
breakage later.
--
Paul
From: Mian Yousaf Kaukab [mailto:yousaf.kau...@intel.com]
Sent: Friday, January
On Tue, Jan 06, 2015 at 01:50:15PM +0100, Andreas Herrmann wrote:
ehci-octeon driver used a 64-bit dma_mask. With removal of ehci-octeon
and usage of ehci-platform ehci dma_mask is now limited to 32 bits
(coerced in ehci_platform_probe).
Provide a flag in ehci platform data to allow use of
Commit e4c7f259c5be (USB: kaweth.c: use GFP_ATOMIC under spin_lock)
makes sure that kaweth_internal_control_msg() allocates memory with GFP_ATOMIC,
but kaweth_internal_control_msg() also calls usb_start_wait_urb()
that still allocates memory with GFP_NOIO.
The patch fixes usb_start_wait_urb() as
On Fri, 2015-01-09 at 13:32 +0800, Peter Chen wrote:
Two reasons together cause this problem
- Special mouse which will disconnect (pulldown dm) if there is no
host IN
token within limited time (60s has observed at one microsoft mouse)
- The rootfs has not opened mouse, it causes the host
On Fri, 2015-01-09 at 13:32 +0800, Peter Chen wrote:
Two reasons together cause this problem
- Special mouse which will disconnect (pulldown dm) if there is no
host IN token within limited time (60s has observed at one microsoft
mouse)
- The rootfs has not opened mouse, it causes the
Hi Greg
These xhci patches for usb-next are all minor cleanups, debug fixes
etc.
-Mathias
Julia Lawall (2):
xhci: Use setup_timer
xhci-mem: Use setup_timer
Lin Wang (3):
xhci: Clean up work to xhci_add_endpoint().
xhci: remove unused parameter 'xhci' in function xhci_handshake().
From: Lin Wang lin.x.w...@intel.com
Parameter 'xhci' is no longer be used in function xhci_handshake(),
just remove it.
Signed-off-by: Lin Wang lin.x.w...@intel.com
Signed-off-by: Mathias Nyman mathias.ny...@linux.intel.com
---
drivers/usb/host/xhci-ring.c | 2 +-
drivers/usb/host/xhci.c
From: Julia Lawall julia.law...@lip6.fr
Convert a call to init_timer and accompanying intializations of
the timer's data and function fields to a call to setup_timer.
A simplified version of the semantic match that fixes this problem is as
follows: (http://coccinelle.lip6.fr/)
// smpl
@@
From: Julia Lawall julia.law...@lip6.fr
Convert a call to init_timer and accompanying intializations of
the timer's data and function fields to a call to setup_timer.
A simplified version of the semantic match that fixes this problem is as
follows: (http://coccinelle.lip6.fr/)
// smpl
@@
Helps debugging to know the unhandled event type.
Also make the debug message grepable
Signed-off-by: Mathias Nyman mathias.ny...@linux.intel.com
---
drivers/usb/host/xhci-ring.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/host/xhci-ring.c
From: Lin Wang lin.x.w...@intel.com
Some parameters are not used by functions in xhci-mem.c, just
remove it.
Changes compared to v1:
- Rebase to the latest usb-next branch
Signed-off-by: Lin Wang lin.x.w...@intel.com
Signed-off-by: Mathias Nyman mathias.ny...@linux.intel.com
---
From: Lin Wang lin.x.w...@intel.com
This patch removes unused variable out_ctx and avoid multiple calls
to function xhci_get_endpoint_flag().
Signed-off-by: Lin Wang lin.x.w...@intel.com
Signed-off-by: Mathias Nyman mathias.ny...@linux.intel.com
---
drivers/usb/host/xhci.c | 9 +++--
1 file
Hello Laurent Pinchart,
The patch cdda479f15cd: USB gadget: video class function driver
from May 2, 2010, leads to the following static checker warning:
drivers/usb/gadget/function/f_uvc.c:223 uvc_function_ep0_complete()
error: overflow detected. memcpy() 'uvc_event-data.data'
These members are only occupying space.
Signed-off-by: Mian Yousaf Kaukab yousaf.kau...@intel.com
---
drivers/usb/dwc2/core.h | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/usb/dwc2/core.h b/drivers/usb/dwc2/core.h
index df6a64f..db5348c 100644
--- a/drivers/usb/dwc2/core.h
+++
The warning is probably good but it has false positives in both dma and non-dma
cases. So its not very helpful in either.
Signed-off-by: Mian Yousaf Kaukab yousaf.kau...@intel.com
---
drivers/usb/dwc2/gadget.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
kill_all_requests() can flush the fifo. Call it after disabling the
endpoint.
Signed-off-by: Mian Yousaf Kaukab yousaf.kau...@intel.com
---
drivers/usb/dwc2/gadget.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c
Manage ep0 state in software to add handling of status OUT stage.
Just toggling hsotg-setup in s3c_hsotg_handle_outdone leaves it in
wrong state in 2-stage control transfers.
Moreover, ensure that for setup-packet s3c_hsotg_handle_outdone is
called either from SetupDone or OutDone but not both.
Current algorithm picks the first fifo which is equal to or greater
than the required size. This can result in bigger fifos assigned to
endpoints with smaller maxps. Change the algorithm to pick the
smallest fifo which is greater than or equal to the required size.
Moreover, only use signed
When matching tx fifo to endpoint, consider all fifos instead of
hard limiting to 8
Moreover, print error in case no fifo could be found.
Signed-off-by: Mian Yousaf Kaukab yousaf.kau...@intel.com
---
drivers/usb/dwc2/gadget.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff
If usb bus is reset without a physical disconnection, all endpoints
will remain open. Call s3c_hsotg_disconnect() from reset handler to
report a disconnect to gadget framework. hsotg-connected is checked
in s3c_hsotg_disconnect() before processing disconnect.
In some cases, USBRst is seen before
According to programming guide, zero length packet should be
programmed on its own and should not be counted in DIEPTSIZ.PktCnt
with other packets.
For ep0, this is the zlp for DATA IN stage (if required) and not for
the STATUS stage.
Signed-off-by: Gregory Herrero gregory.herr...@intel.com
When selecting different alt setting, s3c_hsotg_ep_enable can be
called with fifo already allocated. Allocate fifo again only if
required and after deallocating the previous fifo.
Signed-off-by: Mian Yousaf Kaukab yousaf.kau...@intel.com
---
drivers/usb/dwc2/gadget.c | 13 -
1 file
From: Gregory Herrero gregory.herr...@intel.com
Can't stay in the loop forever. Break it after timeout.
Signed-off-by: Gregory Herrero gregory.herr...@intel.com
---
drivers/usb/dwc2/gadget.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/dwc2/gadget.c
From: Gregory Herrero gregory.herr...@intel.com
Enable phy driver to report vbus session. This allows us to remove
D+ pullup when vbus is not present.
Signed-off-by: Gregory Herrero gregory.herr...@intel.com
Signed-off-by: Mian Yousaf Kaukab yousaf.kau...@intel.com
---
drivers/usb/dwc2/gadget.c
From: Gregory Herrero gregory.herr...@intel.com
As fifo size can vary between SOCs, add possibility to configure
them from device tree. Fifo sizes used by the legacy driver will
be used If they are not provided by the device tree.
Signed-off-by: Gregory Herrero gregory.herr...@intel.com
From: Gregory Herrero gregory.herr...@intel.com
After all endpoints are disabled, fifo_map should have reached 0.
Its a bug if if didn't, so warn about it and reset it to 0 so that
driver can continue using all the fifos.
Signed-off-by: Gregory Herrero gregory.herr...@intel.com
Signed-off-by:
Current code does not check endpoint 15 interrupt. Use number
of endpoint configured in hardware instead of the hardcoded value.
Signed-off-by: Mian Yousaf Kaukab yousaf.kau...@intel.com
---
drivers/usb/dwc2/gadget.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git
From: Gregory Herrero gregory.herr...@intel.com
Signed-off-by: Gregory Herrero gregory.herr...@intel.com
---
Documentation/devicetree/bindings/usb/dwc2.txt | 3 +++
1 file changed, 3 insertions(+)
diff --git a/Documentation/devicetree/bindings/usb/dwc2.txt
15 check doesn't show debug information for endpoint 15.
It is possible to have less than 15 endpoints so use limit
provided by hardware configuration.
Signed-off-by: Mian Yousaf Kaukab yousaf.kau...@intel.com
---
drivers/usb/dwc2/gadget.c | 8
1 file changed, 4 insertions(+), 4
This flag is set before sending the zlp. So use present tense instead
of the past tense.
Signed-off-by: Mian Yousaf Kaukab yousaf.kau...@intel.com
---
drivers/usb/dwc2/core.h | 4 ++--
drivers/usb/dwc2/gadget.c | 8
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git
From: Gregory Herrero gregory.herr...@intel.com
Gadget must be informed about disconnection when pullup is
removed.
Signed-off-by: Gregory Herrero gregory.herr...@intel.com
---
drivers/usb/dwc2/gadget.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/dwc2/gadget.c
From: Gregory Herrero gregory.herr...@intel.com
This callback informs the driver about the total amount of current it
is allowed to draw. Share this information with the phy so that
current limits can be set for charging for example.
Signed-off-by: Gregory Herrero gregory.herr...@intel.com
---
From: Gregory Herrero gregory.herr...@intel.com
When booting with id pin grounded, dwc2 default to host mode.
Thus, force device mode prior initializing gadget part.
Else fifo init will fail since fifo values are not correct
in host mode.
Signed-off-by: Gregory Herrero gregory.herr...@intel.com
From: Gregory Herrero gregory.herr...@intel.com
Do a read-modify-write instead of only setting DMAEn bit.
Signed-off-by: Gregory Herrero gregory.herr...@intel.com
---
drivers/usb/dwc2/gadget.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/dwc2/gadget.c
From: Gregory Herrero gregory.herr...@intel.com
Indicate if gadget driver must use dma for usb transfers.
Signed-off-by: Gregory Herrero gregory.herr...@intel.com
---
Documentation/devicetree/bindings/usb/dwc2.txt | 1 +
1 file changed, 1 insertion(+)
diff --git
Hi,
This patchset consists of various bug fixes and feature enhancements for the
dwc2 gadget driver. All the patches are verified on dwc2 v3.0a with dedicated
fifos. Main focus of testing was with dma enabled. Although basic testing
without dma was also done.
It is based on testing/next branch in
When using DMA, data of the previous setup packet can be read back
from cache because ep0 and ctrl buffers are embedded in struct s3c_hsotg.
Allocate buffers instead of embedding them.
Signed-off-by: Mian Yousaf Kaukab yousaf.kau...@intel.com
Reviewed-by: Robert Baldyga r.bald...@samsung.com
---
From: Gregory Herrero gregory.herr...@intel.com
Bind peripheral controller to the phy on udc_start. Unbind on
udc_stop.
Signed-off-by: Gregory Herrero gregory.herr...@intel.com
Signed-off-by: Mian Yousaf Kaukab yousaf.kau...@intel.com
---
drivers/usb/dwc2/gadget.c | 4
1 file changed, 4
Only process DOEPINT.XferCompl on data packet as DOEPINTn.SetUp can
occur with or without DOEPINT.XferCompl. When DOEPINT.SetUp occurs
with DOEPINT.XferCompl, only DOEPINT.SetUp needs to be handled.
Moreover, ignore DOEPINT.XferCompl when it occurs with
DOEPINT.StupPktRcvd as driver needs to wait
When using DMA, keep fifo empty interrupt disabled. Otherwise
core is flooded by interrupts.
Signed-off-by: Gregory Herrero gregory.herr...@intel.com
Signed-off-by: Mian Yousaf Kaukab yousaf.kau...@intel.com
---
drivers/usb/dwc2/gadget.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
In the error path, s3c_hsotg_phy_disable should be called after a
call to s3c_hsotg_phy_enable is made.
Signed-off-by: Mian Yousaf Kaukab yousaf.kau...@intel.com
---
drivers/usb/dwc2/gadget.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/dwc2/gadget.c
From: Gregory Herrero gregory.herr...@intel.com
HBstLen is GAHBCFG[4:1]. Use GAHBCFG_HBSTLEN_SHIFT to write burst-
length at correct position.
Signed-off-by: Gregory Herrero gregory.herr...@intel.com
---
drivers/usb/dwc2/gadget.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
From: Gregory Herrero gregory.herr...@intel.com
* Add an of specific function to parse device node properties.
* Enable dma usage only if device tree property 'g_use_dma' is present.
Signed-off-by: Gregory Herrero gregory.herr...@intel.com
---
drivers/usb/dwc2/core.h | 2 ++
GHWCFG1 provides hardware configuration of each endpoint. Use
it to configure the endpoints instead of assuming all even
endpoint are OUT and all odd endpoints are IN.
Signed-off-by: Mian Yousaf Kaukab yousaf.kau...@intel.com
---
drivers/usb/dwc2/core.h | 3 +-
drivers/usb/dwc2/gadget.c |
To help debugging xhci problems.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/host/xhci.c | 4
drivers/usb/host/xhci.h | 2 ++
2 files changed, 6 insertions(+)
diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c
index 01fcbb5..bb3e328 100644
---
When re-applying the configuration after a successful usb device reset,
xhci_discover_or_reset_device has already dropped the endpoints, and free-ed
the rings.
The endpoints already being dropped is expected, and should not lead to
warnings. Use the fact that the rings are also free-ed in this
Hi Mathias,
These 2 patches which have been sitting in my personal tree for a while now
seem to have fallen through the cracks, hence this resend.
If you're simply just not interested in them let me know and I'll drop them.
Regards,
Hans
--
To unsubscribe from this list: send the line
61 matches
Mail list logo
