Re: [PATCHv.2] USB:OHCI: Proper handling of ed_rm_list to handle race condition between usb_kill_urb() and finish_unlinks()

2015-07-09 Thread Alan Stern
On Thu, 9 Jul 2015, AMAN DEEP wrote: There is a race condition between finish_unlinks-finish_urb() function and usb_kill_urb() in ohci controller case. The finish_urb calls spin_unlock(ohci-lock) before usb_hcd_giveback_urb() function call, then if during this time, usb_kill_urb is

[PATCH] xhci: Workaround to get D3 working in Intel xHCI

2015-07-09 Thread rajmohan . mani
From: Rajmohan Mani rajmohan.m...@intel.com The xHCI in Intel CherryView / Braswell Platform requires a driver workaround to get xHCI D3 working. Without this workaround, xHCI might not enter D3. Workaround is to configure SSIC PORT as unused before D3 entry and used after D3 exit. This is done

Re: [PATCH v2 1/5] dt-bindings: Add usb3.0 phy binding for MT65xx SoCs

2015-07-09 Thread Sascha Hauer
On Wed, Jul 08, 2015 at 05:41:03PM +0800, Chunfeng Yun wrote: add a DT binding documentation of usb3.0 phy for MT65xx SoCs from Mediatek. Signed-off-by: Chunfeng Yun chunfeng@mediatek.com --- .../devicetree/bindings/usb/mt65xx-u3phy.txt | 34 ++ 1 file

Re: Cannot use the logitech k520 (046d:c52b) to unlock my luks disk at boot time

2015-07-09 Thread Glasswall Information Point
Ok so the bug originates form the fact that the driver is not in initrd? I'm far from a kernel developper, so what could my next step be? -Do you have enough information for now, (ergo, I do nothing)? -Should I re-file this bug with the initrd guys? -Should I file a bug that the kernel Makefile

Re: [PATCH] USB: serial: Destroy serial_minors IDR on module exit

2015-07-09 Thread Johan Hovold
On Wed, Jul 08, 2015 at 05:26:37PM +0200, Johannes Thumshirn wrote: Destroy serial_minors IDR on module exit, reclaiming the allocated memory. This was detected by the following semantic patch (written by Luis Rodriguez mcg...@suse.com) SmPL @ defines_module_init @ declarer name

Re: [PATCH] cdc-acm: Destroy acm_minors IDR on module exit

2015-07-09 Thread Oliver Neukum
On Wed, 2015-07-08 at 17:25 +0200, Johannes Thumshirn wrote: Destroy acm_minors IDR on module exit, reclaiming the allocated memory. This was detected by the following semantic patch (written by Luis Rodriguez mcg...@suse.com) SmPL @ defines_module_init @ declarer name module_init,

[PATCH v7 01/23] usb: add usb_otg20_descriptor for OTG 2.0 and above

2015-07-09 Thread Li Jun
From: Macpaul Lin macp...@gmail.com OTG 2.0 introduces bcdOTG in otg descriptor to identify the OTG and EH supplement release number with which the OTG device is compliant, this patch adds structure usb_otg20_descriptor for OTG 2.0 and above. Signed-off-by: Macpaul Lin macp...@gmail.com

[PATCH v7 08/23] usb: chipidea: set usb otg capabilities

2015-07-09 Thread Li Jun
Init and update otg capabilities by DT, set gadget's otg capabilities accordingly. Signed-off-by: Li Jun jun...@freescale.com --- drivers/usb/chipidea/core.c | 15 +++ drivers/usb/chipidea/udc.c | 7 ++- include/linux/usb/chipidea.h | 1 + 3 files changed, 22 insertions(+),

[PATCH v7 00/23] usb gadget update for OTG 2.0

2015-07-09 Thread Li Jun
Change for v7: - Free otg descriptor when failure of bind in patch 21, 22, 23. add Roger's Reviewed-by for patch 10~20. - Choose the lesser otg-rev if otg-rev has been set before update by DT, remove 0x0300 in supported otg-rev list, and add code comments in case otg-rev is not passed in DT

[PATCH v7 06/23] doc: dt-binding: usb: add otg related properties

2015-07-09 Thread Li Jun
Add otg version, srp, hnp and adp support for usb OTG port, then those OTG features don't have to be decided by usb gadget drivers. Signed-off-by: Li Jun jun...@freescale.com Reviewed-by: Roger Quadros rog...@ti.com --- Documentation/devicetree/bindings/usb/generic.txt | 15 +++ 1

[PATCH v7 04/23] usb: add usb_otg_caps to usb_gadget structure.

2015-07-09 Thread Li Jun
From: Macpaul Lin macp...@gmail.com Add usb_otg_caps pointer to usb_gadget structure to indicate its otg capabilities. Signed-off-by: Macpaul Lin macp...@gmail.com Signed-off-by: Li Jun jun...@freescale.com Reviewed-by: Roger Quadros rog...@ti.com --- include/linux/usb/gadget.h | 2 ++ 1 file

[PATCH v7 02/23] usb: add USB_OTG_ADP definition

2015-07-09 Thread Li Jun
From: Macpaul Lin macp...@gmail.com Add USB_OTG_ADP definition for usb_otg_descriptor.bmAttributes. Signed-off-by: Macpaul Lin macp...@gmail.com Signed-off-by: Li Jun jun...@freescale.com Acked-by: Peter Chen peter.c...@freescale.com --- include/uapi/linux/usb/ch9.h | 1 + 1 file changed, 1

[PATCH v7 05/23] usb: gadget: composite: add USB_DT_OTG request handling

2015-07-09 Thread Li Jun
From: Macpaul Lin macp...@gmail.com Copy usb_otg_descriptor from config's descriptor if host requests USB_DT_OTG. Signed-off-by: Macpaul Lin macp...@gmail.com Signed-off-by: Li Jun jun...@freescale.com Reviewed-by: Roger Quadros rog...@ti.com --- drivers/usb/gadget/composite.c | 27

[PATCH v7 03/23] usb: otg: add usb_otg_caps structure for otg capabilities

2015-07-09 Thread Li Jun
This patch adds a structure usb_otg_caps to cover all otg related capabilities of the device, including otg revision, and if hnp/srp/adp is supported. Signed-off-by: Li Jun jun...@freescale.com Reviewed-by: Roger Quadros rog...@ti.com --- include/linux/usb/otg.h | 15 +++ 1 file

[PATCH v7 09/23] usb: chipidea: update ci_otg_is_fsm_mode conditions

2015-07-09 Thread Li Jun
After introduce usb otg properties, update ci_otg_is_fsm_mode conditions to be depending on both usb hardware properties and usb driver config, also resolve a compile issue in debug.c after the API change. Signed-off-by: Li Jun jun...@freescale.com --- drivers/usb/chipidea/ci.h| 5 -

[PATCH v7 10/23] usb: gadget: add usb otg descriptor allocate and init interface

2015-07-09 Thread Li Jun
Allocate usb otg descriptor and initialize it according to gadget's otg capabilities, if usb_otg_caps is not set, keep settings as current gadget drivers. With this 2 new interfaces, gadget can use usb_otg_descriptor for OTG 1.x, and usb_otg20_descriptor for OTG 2.0 or above, and otg features can

[PATCH v7 16/23] usb: gadget: g_ffs: allocate and init otg descriptor by otg capabilities

2015-07-09 Thread Li Jun
Allocate and initialize usb otg descriptor according to gadget otg capabilities, add it for each usb configurations. If otg capability is not defined, keep its original otg descriptor unchanged. Signed-off-by: Li Jun jun...@freescale.com Reviewed-by: Roger Quadros rog...@ti.com ---

[PATCH v7 20/23] usb: gadget: ncm: allocate and init otg descriptor by otg capabilities

2015-07-09 Thread Li Jun
Allocate and initialize usb otg descriptor according to gadget otg capabilities, add it for each usb configurations. If otg capability is not defined, keep its original otg descriptor unchanged. Signed-off-by: Li Jun jun...@freescale.com Reviewed-by: Roger Quadros rog...@ti.com ---

[PATCH v7 11/23] usb: gadget: configfs: allocate and init otg descriptor by otg capabilities

2015-07-09 Thread Li Jun
Allocate and initialize usb otg descriptor according to gadget otg capabilities, add it for each usb configurations, free it while composite unbind. If otg capability is not defined, keep its otg descriptor unchanged. Signed-off-by: Li Jun jun...@freescale.com Reviewed-by: Roger Quadros

[PATCH v7 17/23] usb: gadget: hid: allocate and init otg descriptor by otg capabilities

2015-07-09 Thread Li Jun
Allocate and initialize usb otg descriptor according to gadget otg capabilities, add it for each usb configurations. If otg capability is not defined, keep its original otg descriptor unchanged. Signed-off-by: Li Jun jun...@freescale.com Reviewed-by: Roger Quadros rog...@ti.com ---

[PATCH v7 23/23] usb: gadget: zero: allocate and init otg descriptor by otg capabilities

2015-07-09 Thread Li Jun
Allocate and initialize usb otg descriptor according to gadget otg capabilities, add it for each usb configurations. If otg capability is not defined, keep its original otg descriptor unchanged. Signed-off-by: Li Jun jun...@freescale.com --- drivers/usb/gadget/legacy/zero.c | 41

[PATCH v7 18/23] usb: gadget: mass_storage: allocate and init otg descriptor by otg capabilities

2015-07-09 Thread Li Jun
Allocate and initialize usb otg descriptor according to gadget otg capabilities, add it for each usb configurations. If otg capability is not defined, keep its original otg descriptor unchanged. Signed-off-by: Li Jun jun...@freescale.com Reviewed-by: Roger Quadros rog...@ti.com ---

[PATCH v7 07/23] usb: common: add API to update usb otg capabilities by device tree

2015-07-09 Thread Li Jun
Check property of usb hardware to update otg version and disable SRP, HNP and ADP if its disable flag is present. Signed-off-by: Li Jun jun...@freescale.com --- drivers/usb/common/common.c | 56 + include/linux/usb/of.h | 7 ++ 2 files

[PATCH v7 12/23] usb: gadget: ether: allocate and init otg descriptor by otg capabilities

2015-07-09 Thread Li Jun
Allocate and initialize usb otg descriptor according to gadget otg capabilities, add it for each usb configurations, free it while ether unbind. If otg capability is not defined, keep its otg descriptor unchanged. Signed-off-by: Li Jun jun...@freescale.com Reviewed-by: Roger Quadros rog...@ti.com

[PATCH v7 19/23] usb: gadget: multi: allocate and init otg descriptor by otg capabilities

2015-07-09 Thread Li Jun
Allocate and initialize usb otg descriptor according to gadget otg capabilities, add it for each usb configurations. If otg capability is not defined, keep its original otg descriptor unchanged. Signed-off-by: Li Jun jun...@freescale.com Reviewed-by: Roger Quadros rog...@ti.com ---

[PATCH v7 13/23] usb: gadget: acm_ms: allocate and init otg descriptor by otg capabilities

2015-07-09 Thread Li Jun
Allocate and initialize usb otg descriptor according to gadget otg capabilities, add it for each usb configurations. If otg capability is not defined, keep its original otg descriptor unchanged. Signed-off-by: Li Jun jun...@freescale.com Reviewed-by: Roger Quadros rog...@ti.com ---

[PATCH v7 14/23] usb: gadget: audio: allocate and init otg descriptor by otg capabilities

2015-07-09 Thread Li Jun
Allocate and initialize usb otg descriptor according to gadget otg capabilities, add it for each usb configurations. If otg capability is not defined, keep its original otg descriptor unchanged. Signed-off-by: Li Jun jun...@freescale.com Reviewed-by: Roger Quadros rog...@ti.com ---

[PATCH v7 15/23] usb: gadget: cdc2: allocate and init otg descriptor by otg capabilities

2015-07-09 Thread Li Jun
Allocate and initialize usb otg descriptor according to gadget otg capabilities, add it for each usb configurations. If otg capability is not defined, keep its original otg descriptor unchanged. Signed-off-by: Li Jun jun...@freescale.com Reviewed-by: Roger Quadros rog...@ti.com ---

[PATCH v7 22/23] usb: gadget: serial: allocate and init otg descriptor by otg capabilities

2015-07-09 Thread Li Jun
Allocate and initialize usb otg descriptor according to gadget otg capabilities, add it for each usb configurations. If otg capability is not defined, keep its original otg descriptor unchanged. Signed-off-by: Li Jun jun...@freescale.com --- drivers/usb/gadget/legacy/serial.c | 37

[PATCH v7 21/23] usb: gadget: printer: allocate and init otg descriptor by otg capabilities

2015-07-09 Thread Li Jun
Allocate and initialize usb otg descriptor according to gadget otg capabilities, add it for each usb configurations. If otg capability is not defined, keep its original otg descriptor unchanged. Signed-off-by: Li Jun jun...@freescale.com --- drivers/usb/gadget/legacy/printer.c | 49

[PATCHv.2] USB:OHCI: Proper handling of ed_rm_list to handle race condition between usb_kill_urb() and finish_unlinks()

2015-07-09 Thread AMAN DEEP
There is a race condition between finish_unlinks-finish_urb() function and usb_kill_urb() in ohci controller case. The finish_urb calls spin_unlock(ohci-lock) before usb_hcd_giveback_urb() function call, then if during this time, usb_kill_urb is called for another endpoint, then new ed will

Re: [PATCH v7 07/23] usb: common: add API to update usb otg capabilities by device tree

2015-07-09 Thread Roger Quadros
On 09/07/15 10:18, Li Jun wrote: Check property of usb hardware to update otg version and disable SRP, HNP and ADP if its disable flag is present. Signed-off-by: Li Jun jun...@freescale.com Reviewed-by: Roger Quadros rog...@ti.com cheers, -roger --- drivers/usb/common/common.c | 56

Re: [PATCH v7 22/23] usb: gadget: serial: allocate and init otg descriptor by otg capabilities

2015-07-09 Thread Roger Quadros
On 09/07/15 10:18, Li Jun wrote: Allocate and initialize usb otg descriptor according to gadget otg capabilities, add it for each usb configurations. If otg capability is not defined, keep its original otg descriptor unchanged. Signed-off-by: Li Jun jun...@freescale.com Reviewed-by: Roger

Re: [PATCH v7 21/23] usb: gadget: printer: allocate and init otg descriptor by otg capabilities

2015-07-09 Thread Roger Quadros
On 09/07/15 10:18, Li Jun wrote: Allocate and initialize usb otg descriptor according to gadget otg capabilities, add it for each usb configurations. If otg capability is not defined, keep its original otg descriptor unchanged. Signed-off-by: Li Jun jun...@freescale.com Reviewed-by: Roger

Re: [PATCH v7 08/23] usb: chipidea: set usb otg capabilities

2015-07-09 Thread Roger Quadros
On 09/07/15 10:18, Li Jun wrote: Init and update otg capabilities by DT, set gadget's otg capabilities accordingly. Signed-off-by: Li Jun jun...@freescale.com Reviewed-by: Roger Quadros rog...@ti.com cheers, -roger --- drivers/usb/chipidea/core.c | 15 +++

Re: [PATCH v7 23/23] usb: gadget: zero: allocate and init otg descriptor by otg capabilities

2015-07-09 Thread Roger Quadros
On 09/07/15 10:19, Li Jun wrote: Allocate and initialize usb otg descriptor according to gadget otg capabilities, add it for each usb configurations. If otg capability is not defined, keep its original otg descriptor unchanged. Signed-off-by: Li Jun jun...@freescale.com Reviewed-by: Roger

Re: [PATCH] cdc-acm: Destroy acm_minors IDR on module exit

2015-07-09 Thread Johan Hovold
On Wed, Jul 08, 2015 at 05:25:42PM +0200, Johannes Thumshirn wrote: Destroy acm_minors IDR on module exit, reclaiming the allocated memory. Signed-off-by: Johannes Thumshirn jthumsh...@suse.de --- drivers/usb/class/cdc-acm.c | 1 + 1 file changed, 1 insertion(+) diff --git

Re: [PATCH v7 08/23] usb: chipidea: set usb otg capabilities

2015-07-09 Thread Roger Quadros
Hi, On 09/07/15 10:18, Li Jun wrote: Init and update otg capabilities by DT, set gadget's otg capabilities accordingly. Signed-off-by: Li Jun jun...@freescale.com --- drivers/usb/chipidea/core.c | 15 +++ drivers/usb/chipidea/udc.c | 7 ++-

Re: Cannot use the logitech k520 (046d:c52b) to unlock my luks disk at boot time

2015-07-09 Thread Glasswall Information Point
I can hereby acknowledge that the driver not being in initramfs is the problem. After manually inserting the module hid-logitech-hidpp the keyboard works ar boot time for entering encryption password. I do however want to leave the remark that in my opion this driver shoudl be included by

Re: [RFC PATCH 1/1] Add a usbredir kernel module to remotely connect USB devices over IP.

2015-07-09 Thread Alex Elsayed
Alan Stern wrote: On Mon, 6 Jul 2015, Jeremy White wrote: Anything else fundamental to usbip that should inform the design of a usbredir driver? usbip appears to be based off a 2004 vintage of dummy_hcd. I'll look thoughtfully at the current dummy_hcd; please let me know if there is

Re: Cannot use the logitech k520 (046d:c52b) to unlock my luks disk at boot time

2015-07-09 Thread Glasswall Information Point
Nope, it is not in the initramfs unless you force it to I had to force it in by adding it to /etc/initramfs-tools/modules and rebuilding the linux boot images but this should be automatic using MODULES=most in initramfs.conf since Initramfs declares that : most - Add most filesystem and all

[PATCH V3] cdc_ncm: Add support for moving NDP to end of NCM frame

2015-07-09 Thread chrono
Ahoy everyone, more on the Telekom Speedstick LTE V (Huawei 3372s) from here: http://www.amazon.de/dp/B00NLJE3O6 I've tested Enricos latest patch on MIPS (3.18.17) and x86_64 (3.18.11) and had a little bit of trouble applying it to latest trunk, so here's the latest tested patch from a diff

Re: Cannot use the logitech k520 (046d:c52b) to unlock my luks disk at boot time

2015-07-09 Thread Jiri Kosina
On Thu, 9 Jul 2015, Glasswall Information Point wrote: Nope, it is not in the initramfs unless you force it to I had to force it in by adding it to /etc/initramfs-tools/modules and rebuilding the linux boot images but this should be automatic using MODULES=most in initramfs.conf since

[PATCH v4 1/2] phy: add lpc18xx usb otg phy driver

2015-07-09 Thread Joachim Eastwood
Add PHY driver for the internal USB OTG PHY found on NXP LPC18xx and LPC43xx devices. This driver takes care of enabling the PHY in CREG (syscon) and setting the required clock frequency. Signed-off-by: Joachim Eastwood manab...@gmail.com --- drivers/phy/Kconfig | 11 +++

[PATCH v4 2/2] phy: dt bindings: add NXP LPC18xx/43xx USB OTG PHY bindings

2015-07-09 Thread Joachim Eastwood
Add binding documentation for NXP LPC18xx/43xx USB OTG PHY. This PHY can found on NXP LPC18xx and LPC43xx devices with USB support. Signed-off-by: Joachim Eastwood manab...@gmail.com --- .../bindings/phy/phy-lpc18xx-usb-otg.txt | 26 ++ 1 file changed, 26

[PATCH v4 0/2] USB OTG PHY driver for NXP LPC18xx family

2015-07-09 Thread Joachim Eastwood
This patch set adds support for the internal USB OTG PHY found on NXP LPC18xx and LPC43xx devices. Driver takes care of enabling the PHY and setting the clock rate which is need for USB0 support on this platform. This version address moves the dt node under the creg syscon and rebases the patch

Re: [PATCH v7 08/23] usb: chipidea: set usb otg capabilities

2015-07-09 Thread Li Jun
On Thu, Jul 09, 2015 at 11:57:39AM +0300, Roger Quadros wrote: Hi, On 09/07/15 10:18, Li Jun wrote: Init and update otg capabilities by DT, set gadget's otg capabilities accordingly. Signed-off-by: Li Jun jun...@freescale.com --- drivers/usb/chipidea/core.c | 15 +++

Re: [PATCH V3] cdc_ncm: Add support for moving NDP to end of NCM frame

2015-07-09 Thread David Miller
From: Enrico Mioso mrkiko...@gmail.com Date: Wed, 8 Jul 2015 13:05:57 +0200 NCM specs are not actually mandating a specific position in the frame for the NDP (Network Datagram Pointer). However, some Huawei devices will ignore our aggregates if it is not placed after the datagrams it points