Re: [PATCH v6 03/15] IB/mthca: Replace PCI pool old API

On Sun, 2017-03-19 at 18:03 +0100, Romain Perier wrote: > The PCI pool API is deprecated. This commit replaces the PCI pool old > API by the appropriate function with the DMA pool API. > > Signed-off-by: Romain Perier > Acked-by: Peter Senna Tschudin

Re: [PATCH v6 06/15] mlx5: Replace PCI pool old API

On Mon, 2017-03-20 at 08:31 +0200, Leon Romanovsky wrote: > On Sun, Mar 19, 2017 at 06:03:55PM +0100, Romain Perier wrote: > > > > The PCI pool API is deprecated. This commit replaces the PCI pool > > old > > API by the appropriate function with the DMA pool API. > > > > Signed-off-by: Romain

[PATCH 3/7] usb: dwc3: core: change goto labels to meaningful names

Change goto labels to meaningful names. Signed-off-by: Shuah Khan --- drivers/usb/dwc3/core.c | 62 - 1 file changed, 31 insertions(+), 31 deletions(-) diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c index

[PATCH 1/7] usb: dwc3: core: fix dwc3_probe() to not do put_sync when get_sync fails

dwc3_probe() does pm_runtime_put_sync() in its err1 handling when pm_runtime_get_sync() fails. Move the pm_runtime_put_sync() under err2 instead as it is used in error paths after pm_runtime_get_sync() succeeds. Signed-off-by: Shuah Khan --- drivers/usb/dwc3/core.c | 2

[PATCH 6/7] usb: dwc3: gadget: change goto labels in this file to meaningful names

Change goto labels in this file to meaningful names. Signed-off-by: Shuah Khan --- drivers/usb/dwc3/gadget.c | 56 +++ 1 file changed, 28 insertions(+), 28 deletions(-) diff --git a/drivers/usb/dwc3/gadget.c

[PATCH 4/7] usb: dwc3: exynos: change goto labels in this file to meaningful names

Change goto labels in this file to meaningful names Signed-off-by: Shuah Khan --- drivers/usb/dwc3/dwc3-exynos.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/usb/dwc3/dwc3-exynos.c b/drivers/usb/dwc3/dwc3-exynos.c index

[PATCH 7/7] usb: dwc3: host: change goto labels in this file to meaningful names

Change goto labels in this file to meaningful names. Signed-off-by: Shuah Khan --- drivers/usb/dwc3/host.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/usb/dwc3/host.c b/drivers/usb/dwc3/host.c index 76f0b0d..eb264a9 100644 ---

[PATCH 5/7] usb: dwc3: omap: change goto labels in this file to meaningful names

Change goto labels in this file to meaningful names. Signed-off-by: Shuah Khan --- drivers/usb/dwc3/dwc3-omap.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/dwc3/dwc3-omap.c b/drivers/usb/dwc3/dwc3-omap.c index 55b12a9..ca0075a

[PATCH 2/7] usb: dwc3: dwc3-omap: fix dwc3_omap_probe() do put_sync when get_sync works

dwc3_omap_probe() does pm_runtime_put_sync() in its err1 handling when pm_runtime_get_sync() fails. Fix it to do put_sync only when get_sync succeeds. Signed-off-by: Shuah Khan --- drivers/usb/dwc3/dwc3-omap.c | 9 + 1 file changed, 5 insertions(+), 4

[PATCH 0/7] dwc3 - bug fixes and use meaningful goto labels

This patch series consists of two fixes and changes to goto labels to use meaningful names. While working on goto label changes, I noticed put_sync calls without successful get_sync in error legs. The first two patches are the fixes and the rest of the patches are goto label changes. Shuah

Re: Oops with dwc3 in device mode and functionfs

Hello Andy, Felipe, Sorry for the late reply. On Mon, Mar 20, 2017 at 6:23 PM, Felipe Balbi wrote: > Andy Shevchenko writes: >> Can you check my latest snapshot? I built your github eds branch as of cfa21022e (based on

Re: [PATCH v2 1/4] cdc-acm: reassemble fragmented notifications

Hi Oliver, thank you for your patience... :) I have a question to one of your comments (see below). Best regards, Tobias > Am Samstag, den 18.03.2017, 19:52 +0100 schrieb Tobias Herzog: > > > > USB devices may have very limitited endpoint packet sizes, so that > > notifications can not be

Re: [PATCH net] r8152: prevent the driver from transmitting packets with carrier off

From: Hayes Wang Date: Thu, 23 Mar 2017 19:14:19 +0800 > The linking status may be changed when autosuspend. And, after > autoresume, the driver may try to transmit packets when the device > is carrier off, because the interrupt transfer doesn't update the > linking

Re: [PATCH] usb-musb: keep VBUS on when device is disconnected

On Wed, Mar 15, 2017 at 09:08:01AM -0500, Moreno Bartalucci wrote: > With usb-musb port in host mode, when the device > is disconnected, either logically (because of a mode switch) or > physically (by pulling the cable), the USB port should keep > suppling VBUS, with no interruption, to prevent

Re: [PATCHv2] net: usbnet: support 64bit stats in qmi_wwan driver

On Fri, 24 Mar 2017 11:27:30 +1000 Greg Ungerer wrote: > +struct usbnet_stats64 { > + struct u64_stats_sync syncp; > + u64 rx_packets; > + u64 rx_bytes; > + u64 tx_packets; > + u64

Re: [PATCH] usb: musb: cppi_dma.c: use DIV_ROUND_UP macro in cppi_next_(r|t)x_segment()

On Wed, Feb 15, 2017 at 11:12:36AM +0300, Ivan Safonov wrote: > DIV_ROUND_UP is bit useful than series of "/" and "%" operations. > Replace "/%" sequence with DIV_ROUND_UP macro. > > Signed-off-by: Ivan Safonov > --- > drivers/usb/musb/cppi_dma.c | 10 -- > 1 file

Re: [PATCH 0/2] net: usb: qmi_wwan: add qmap mux protocol support

On 2017-03-24 07:22, Daniele Palmas wrote: This patch adds support for qmap mux protocol available in recent Qualcomm based modems. The qmap mux protocol can be used for multiplexing data packets in order to have multiple ip streams through the same physical device. Two new sysfs files are

[PATCH] USB: fix linked-list corruption in rh_call_control()

Using KASAN, Dmitry found a bug in the rh_call_control() routine: If buffer allocation fails, the routine returns immediately without unlinking its URB from the control endpoint, eventually leading to linked-list corruption. This patch fixes the problem by jumping to the end of the routine (where

Re: [RESEND PATCH v6 4/4] usb: musb: da8xx: Add a primary support of PM runtime

On 03/24/2017 09:36 AM, Alexandre Bailon wrote: > Currently, MUSB DA8xx glue driver doesn't have PM runtime support. > Because the CPPI 4.1 is using the same clock as MUSB DA8xx and > CPPI 4.1 is a child of MUSB DA8xx glue, add support of PM runtime > to the DA8xx glue driver in order to let the

Re: usb: use-after-free write in usb_hcd_link_urb_to_ep

On Fri, Mar 24, 2017 at 3:27 PM, Alan Stern wrote: > On Fri, 24 Mar 2017, Dmitry Vyukov wrote: > >> On Thu, Mar 23, 2017 at 4:22 PM, Dmitry Vyukov wrote: >> >> On Thu, 23 Mar 2017, Dmitry Vyukov wrote: >> >> >> >>> > Putting these together: >> >>> >

Re: [PATCH 2/2] Documentation: ABI: testing: sysfs-class-net-qmi: add new qmap mux files description

Hello! On 03/24/2017 04:22 PM, Daniele Palmas wrote: This patch updates the documentation related to the new files added for qmap mux support. Signed-off-by: Daniele Palmas --- Documentation/ABI/testing/sysfs-class-net-qmi | 27 +++ 1 file changed,

Re: Dell Inspiron 5558/0VNM2T hangs at resume from suspend when USB 3 is enabled

On Thu, Mar 23, 2017 at 2:12 PM, Diego Viola wrote: > On Thu, Mar 23, 2017 at 2:02 PM, Mathias Nyman > wrote: >> On 22.03.2017 19:51, Mathias Nyman wrote: >>> >>> On 22.03.2017 00:52, Diego Viola wrote: On Tue, Mar 21, 2017 at 12:29

[PATCH] USB: core: fix up kerneldoc comment

Make the kerneldoc comment for usb_find_common_endpoints_reverse() self-contained by adding a full description and removing the reference to usb_find_common_endpoints(). Reported-by: kbuild test robot Signed-off-by: Johan Hovold ---

Re: [usb:usb-testing 41/58] htmldocs: drivers/usb/core/usb.c:178: warning: No description found for parameter 'alt'

On Thu, Mar 23, 2017 at 09:33:06PM +0100, Greg Kroah-Hartman wrote: > On Thu, Mar 23, 2017 at 06:06:45PM +0100, Johan Hovold wrote: > > On Thu, Mar 23, 2017 at 10:57:05PM +0800, kbuild test robot wrote: > > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git > > > usb-testing

[RESEND PATCH v6 1/4] usb: musb: Use shared irq

In the DA8xx, USB and CPPI 4.1 are sharing the same interrupt line. Update the driver to request a shared irq. Signed-off-by: Alexandre Bailon --- drivers/usb/musb/musb_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/musb/musb_core.c

[RESEND PATCH v6 4/4] usb: musb: da8xx: Add a primary support of PM runtime

Currently, MUSB DA8xx glue driver doesn't have PM runtime support. Because the CPPI 4.1 is using the same clock as MUSB DA8xx and CPPI 4.1 is a child of MUSB DA8xx glue, add support of PM runtime to the DA8xx glue driver in order to let the CPPI 4.1 driver manage the clock by using PM runtime.

[RESEND PATCH v6 2/4] usb: musb: Add support of CPPI 4.1 DMA controller to DA8xx

Currently, only the PIO mode is supported. This add support of CPPI 4.1 to DA8xx. As the In DA8xx the CPPI 4.1 DMA is a part of the USB. Create the CPPI 4.1 device as a child of USB. Signed-off-by: Alexandre Bailon --- drivers/usb/musb/Kconfig | 4 ++--

[RESEND PATCH v6 3/4] usb: musb: musb_cppi41: Workaround DMA stall issue during teardown

The DMA may hang up if a teardown is initiated while an endpoint is still active (Advisory 2.3.27 of DA8xx errata). To workaround this issue, add a delay before to initiate the teardown. Signed-off-by: Alexandre Bailon --- drivers/usb/musb/da8xx.c | 2 +-

[RESEND PATCH v6 0/4] usb: musb: da8xx: Add DMA support

This series update MUSB driver to add DMA support to DA8xx. It should be applied on top of: "[PATCH v4 0/3] dmaengine: cppi41: Add dma support to da8xx" and "[PATCH v3] ARM: davinci: Make the usb20 clock available to PM runtime" Changes in v6: - Rebased on linux-next. Some patches were

Re: usb: use-after-free write in usb_hcd_link_urb_to_ep

On Fri, 24 Mar 2017, Dmitry Vyukov wrote: > On Thu, Mar 23, 2017 at 4:22 PM, Dmitry Vyukov wrote: > >> On Thu, 23 Mar 2017, Dmitry Vyukov wrote: > >> > >>> > Putting these together: > >>> > > >>> > The memory was allocated in usb_internal_control_msg() line 93. > >>>

Re: Musb error

On Fri, Mar 24, 2017 at 04:10:26AM -0500, Pordán Szabolcs wrote: > Hi guys! > > I've found your name on github in musb, I hope you can help me. I think I've > got a bug but not sure. > I have an arm board, called c.h.i.p. It has one normal usb and micro USB port. > The microUSB connector is used

Re: [PATCHv2] net: usbnet: support 64bit stats in qmi_wwan driver

On Fri, 2017-03-24 at 15:42 +1000, Greg Ungerer wrote: > The usbnet core is used by a number of drivers. This patch only > updates the qmi-wwan driver to use stats64. If you remove the > dev->stats.rx_* updates all those other driver users will have > no counts. I see. Then I guess the u64 stuff

Re: [PATCH v2] usb: gadget: dummy_hcd: Fix wrong power status bit clear/reset in dummy_hub_control()

On Fri, 24 Mar 2017, Yuyang Du wrote: > This fixes the commit: 1cd8fd2887e1 ("usb: gadget: dummy_hcd: add > SuperSpeed support"). > > In the case of ClearPortFeature and USB_PORT_FEAT_POWER, simply clear > the right bit regardless of what the wValue is. > > Signed-off-by: Yuyang Du

Re: xhci_hcd: ERROR Transfer event TRB DMA ptr not part of current TD ep_index 2 comp_code 13

On 24.03.2017 12:07, Grey Christoforo wrote: Dear kernel USB people, Could you please have a look at the bug report here? https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1667750 ERROR Transfer event TRB DMA ptr not part of current TD ep_index 2 comp_code 13 Looking for event-dma

[PATCH 0/2] net: usb: qmi_wwan: add qmap mux protocol support

This patch adds support for qmap mux protocol available in recent Qualcomm based modems. The qmap mux protocol can be used for multiplexing data packets in order to have multiple ip streams through the same physical device. Two new sysfs files are added for adding/removing the qmap mux based

[PATCH 1/2] net: usb: qmi_wwan: add qmap mux protocol support

This patch adds support for qmap mux protocol available in recent Qualcomm based modems. The qmap mux protocol can be used for multiplexing data packets in order to have multiple ip streams through the same physical device. Two new sysfs files are added for adding/removing the qmap mux based

[PATCH 2/2] Documentation: ABI: testing: sysfs-class-net-qmi: add new qmap mux files description

This patch updates the documentation related to the new files added for qmap mux support. Signed-off-by: Daniele Palmas --- Documentation/ABI/testing/sysfs-class-net-qmi | 27 +++ 1 file changed, 27 insertions(+) diff --git

[RFT PATCH] xhci: Manually give back cancelled URBs if queuing for cancel fails

Manually give back URB if we are not able to add it to cancel queue and stop the endpoint normally. This can happen if device just reset before URB timed out and dequeued, leading to missing endpoint ring. This caused a hang on Dell Inspiron 5558/0VNM2T at resume from suspend as urb was never

Re: [GIT PULL] usb fixes for v4.11-rc

Hi, Greg Kroah-Hartman writes: > On Thu, Mar 23, 2017 at 02:30:15PM +0200, Felipe Balbi wrote: >> >> Hi Greg, >> >> here's my second pull request for the current -rc cycle. Let me know if >> you want anything to be changed. >> >> cheers >> >> The following

Re: xhci_hcd: ERROR Transfer event TRB DMA ptr not part of current TD ep_index 2 comp_code 13

Hi, Grey Christoforo writes: > Dear kernel USB people, > > Could you please have a look at the bug report here? > bugs.launchpad.net/ubuntu/+source/linux/+bug/1667750 Send us a proper bug report to mailing list, not a link. Also, make sure you're testing against v4.10 or

xhci_hcd: ERROR Transfer event TRB DMA ptr not part of current TD ep_index 2 comp_code 13

Dear kernel USB people, Could you please have a look at the bug report here? bugs.launchpad.net/ubuntu/+source/linux/+bug/1667750 Regards, grey -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: usb: use-after-free write in usb_hcd_link_urb_to_ep

On Thu, Mar 23, 2017 at 4:22 PM, Dmitry Vyukov wrote: >> On Thu, 23 Mar 2017, Dmitry Vyukov wrote: >> >>> > Putting these together: >>> > >>> > The memory was allocated in usb_internal_control_msg() line 93. >>> > The later events occurred within the call in