[PATCH] phy: qcom-qmp: Add dependency on COMMON_CLK

The driver uses clock provider interface, and therefore it fails to build when enabled for COMPILE_TEST, since COMMON_CLK is not enabled at that time. So, make PHY_QCOM_QMP depend on COMMON_CLK as well. Cc: Fengguang Wu Cc: Kishon Vijay Abraham I

Re: [PATCH net-next] net: usbnet: Remove unused driver_name variable

From: Florian Fainelli Date: Tue, 4 Apr 2017 18:16:57 -0700 > With GCC 6.3, we can get the following warning: > > drivers/net/usb/usbnet.c:85:19: warning: 'driver_name' defined but not > used [-Wunused-const-variable=] > static const char driver_name [] = "usbnet"; >

Re: usb: musb: regression since 4.9 on omap4-panda-es (caused by d8e5f0eca1e8)

On Wed, Apr 05, 2017 at 08:29:55AM -0700, Tony Lindgren wrote: > * Tony Lindgren [170405 06:53]: > > * Peter Ujfalusi [170405 00:15]: > > > To be precise this is what I have tried: > > > - boot w/o cable connected > > > - boot w/ board connected to PC

Re: usb: musb: regression since 4.9 on omap4-panda-es (caused by d8e5f0eca1e8)

Tony, On 04/05/2017 06:29 PM, Tony Lindgren wrote: * Tony Lindgren [170405 06:53]: * Peter Ujfalusi [170405 00:15]: To be precise this is what I have tried: - boot w/o cable connected - boot w/ board connected to PC (device mode) - boot w/ OTG-A

Re: [PATCH v3 1/2] usb: dwc3: refactor gadget endpoint count calculation

On 06/04/17 09:59, Roger Quadros wrote: Hi, On 31/01/17 22:58, Bryan O'Donoghue wrote: - DWC_USB3_NUM indicates the number of Device mode single directional endpoints, including OUT and IN endpoint 0. - DWC_USB3_NUM_IN_EPS indicates the maximum number of Device mode IN endpoints active

Re: [PATCH V8 0/4] phy: USB and PCIe phy drivers for Qcom chipsets

On 04/06/2017 03:41 PM, Kishon Vijay Abraham I wrote: On Thursday 06 April 2017 11:21 AM, Vivek Gautam wrote: Hi Kishon, Here's the series with fixed checkpatch warnings/checks. Please pick it for phy/next. This patch series adds couple of PHY drivers for Qualcomm chipsets. a) qcom-qusb2

Re: [PATCH] usb: dwc3: make macros safe to expression arguments

Hi, Roger Quadros writes: > On 06/04/17 13:45, Felipe Balbi wrote: >> >> Hi, >> >> Sergei Shtylyov writes: >>> Hello. >>> >>> On 4/6/2017 1:17 PM, Felipe Balbi wrote: >>> From: Roger Quadros We must make sure

Re: [PATCH] usb: dwc3: make macros safe to expression arguments

On 06/04/17 13:45, Felipe Balbi wrote: > > Hi, > > Sergei Shtylyov writes: >> Hello. >> >> On 4/6/2017 1:17 PM, Felipe Balbi wrote: >> >>> From: Roger Quadros >>> >>> We must make sure that our macros are safe against expressions passed >>> as

Re: [PATCH v5 1/9] phy: phy-mt65xx-usb3: improve RX detection stable time

On Thu, 2017-04-06 at 15:58 +0530, Kishon Vijay Abraham I wrote: > > On Friday 31 March 2017 01:05 PM, Chunfeng Yun wrote: > > The default value of RX detection stable time is 10us, and this > > margin is too big for some critical cases which cause U3 link fail > > and link to U2(probability is

Re: [PATCH] usb: dwc3: make macros safe to expression arguments

Hi, Sergei Shtylyov writes: > Hello. > > On 4/6/2017 1:17 PM, Felipe Balbi wrote: > >> From: Roger Quadros >> >> We must make sure that our macros are safe against expressions passed >> as arguments. We have see one problem where GTXFIFOSIZ(n)

Re: [PATCH v5 1/9] phy: phy-mt65xx-usb3: improve RX detection stable time

On Friday 31 March 2017 01:05 PM, Chunfeng Yun wrote: > The default value of RX detection stable time is 10us, and this > margin is too big for some critical cases which cause U3 link fail > and link to U2(probability is about 1%). So change it to 5us. > merged all the phy patches in this

Re: [PATCH] usb: dwc3: make macros safe to expression arguments

+Bryan On 06/04/17 13:17, Felipe Balbi wrote: > From: Roger Quadros > > We must make sure that our macros are safe against expressions passed > as arguments. We have see one problem where GTXFIFOSIZ(n) was failling > when passed the expression (epnum >> 1) as argument. The

Re: [PATCH v3 1/2] usb: dwc3: refactor gadget endpoint count calculation

On 06/04/17 11:59, Roger Quadros wrote: > Hi, > > On 31/01/17 22:58, Bryan O'Donoghue wrote: >> - DWC_USB3_NUM indicates the number of Device mode single directional >> endpoints, including OUT and IN endpoint 0. >> >> - DWC_USB3_NUM_IN_EPS indicates the maximum number of Device mode IN >>

Re: [PATCH] usb: dwc3: make macros safe to expression arguments

Hello. On 4/6/2017 1:17 PM, Felipe Balbi wrote: From: Roger Quadros We must make sure that our macros are safe against expressions passed as arguments. We have see one problem where GTXFIFOSIZ(n) was failling "Seen" and "failing". when passed the expression (epnum >> 1)

[PATCH] usb: dwc3: make macros safe to expression arguments

From: Roger Quadros We must make sure that our macros are safe against expressions passed as arguments. We have see one problem where GTXFIFOSIZ(n) was failling when passed the expression (epnum >> 1) as argument. The problem was caused by operator precedence between >> and *. To

Re: [PATCH V8 0/4] phy: USB and PCIe phy drivers for Qcom chipsets

On Thursday 06 April 2017 11:21 AM, Vivek Gautam wrote: > Hi Kishon, > Here's the series with fixed checkpatch warnings/checks. > Please pick it for phy/next. > > This patch series adds couple of PHY drivers for Qualcomm chipsets. > a) qcom-qusb2 phy driver: that provides High Speed USB

Re: [PATCH v3 1/2] usb: dwc3: refactor gadget endpoint count calculation

Hi, Roger Quadros writes: >> - DWC_USB3_NUM indicates the number of Device mode single directional >> endpoints, including OUT and IN endpoint 0. >> >> - DWC_USB3_NUM_IN_EPS indicates the maximum number of Device mode IN >> endpoints active at any time, including control

Re: [PATCH v3 1/2] usb: dwc3: refactor gadget endpoint count calculation

Hi, On 31/01/17 22:58, Bryan O'Donoghue wrote: > - DWC_USB3_NUM indicates the number of Device mode single directional > endpoints, including OUT and IN endpoint 0. > > - DWC_USB3_NUM_IN_EPS indicates the maximum number of Device mode IN > endpoints active at any time, including control

Re: dwc2_hc_chhltd_intr_dma - ChHltd set errors?

On 4/6/2017 1:03 AM, John Stultz wrote: > > > On Wed, Apr 5, 2017 at 5:58 AM, Minas Harutyunyan > > > wrote: >> On 4/4/2017 11:03 PM, John Stultz wrote: >>> >>> I did notice when cating the regdump file, I saw: >>> dwc2

Re: [PATCH][linux-next] dmaengine: cppi41: Fix an Oops happening in cppi41_dma_probe()

On Wed, Apr 05, 2017 at 06:35:16PM +0200, Alexandre Bailon wrote: > This fix an Oops happening on all platforms using the old dt bindings > (all platforms but da8xx). > This update cppi41_dma_probe() to use the index variable which is > required to keep compatibility between old and new dt

[PATCH v3 0/6] usb: usbip: Fix ports and port status

The commit 0775a9cbc694e8c7 ("usbip: vhci extension: modifications to vhci driver") introduced several bugs relating to the number of ports amd the port status. In addition, a small improvement is made to the vhci_hcd module. v3: - Check both ends of the nports - Check the return of

[PATCH v3 3/6] usb: usbip tool: Check the return of get_nports()

If we get nonpositive number of ports, there is no sense to continue, then fail gracefully. In addition, the commit 0775a9cbc694e8c72 ("usbip: vhci extension: modifications to vhci driver") introduced configurable numbers of controllers and ports, but we have a static port number maximum,

[PATCH v3 2/6] usb: usbip tool: Fix get_nports()

The commit 0775a9cbc694e8c72 ("usbip: vhci extension: modifications to vhci driver") introduced multiple controllers, and nports as a sys file, and claimed to read the nports from it, but it didn't. In addition, the get_nports() has been so wrong that even with 8 port lines for instance, it gets

[PATCH v3 4/6] usb: usbip tool: Add ncontrollers in vhci_driver structure

A new field ncontrollers is added to the vhci_driver structure. And this field is stored by scanning the vhci_hcd* dirs in the platform udev. Suggested-by: Krzysztof Opasiak Signed-off-by: Yuyang Du --- tools/usb/usbip/libsrc/vhci_driver.c | 36

[PATCH v3 1/6] usb: usbip: Remove unnecessary get_vdev()

vhci_tx_urb() should be able to get the vhci_device from its caller vhci_urb_enqueue(), instead of brutal-force searching it. Reviewed-by: Krzysztof Opasiak Signed-off-by: Yuyang Du Acked-by: Shuah Khan ---

[PATCH v3 5/6] usb: usbip tool: Fix refresh_imported_device_list()

The commit 0775a9cbc694e8c7 ("usbip: vhci extension: modifications to vhci driver") introduced multiple controllers, but the status of the ports are only extracted from the first status file, fix it. Reviewed-by: Krzysztof Opasiak Signed-off-by: Yuyang Du

[PATCH v3 6/6] usb: usbip tool: Fix parse_status()

In parse_status(), all nports number of idev's are initiated to 0 by memset(), it is simply wrong, because parse_status() reads the status sys file one by one, therefore, it can only update the according vhci_driver->idev's for it to parse. Reviewed-by: Krzysztof Opasiak