[PATCH] usb: gadget: f_fs: Use config_ep_by_speed()

2018-01-24 Thread Jack Pham
In commit 2bfa0719ac2a ("usb: gadget: function: f_fs: pass companion descriptor along") there is a pointer arithmetic bug where the comp_desc is obtained as follows: comp_desc = (struct usb_ss_ep_comp_descriptor *)(ds + USB_DT_ENDPOINT_SIZE); Since ds is a pointer to

RE: MX25 USB timeout on ID 0951:1665 Kingston Technology Digital DataTraveler SE9 64GB

2018-01-24 Thread Peter Chen
> On Mon, Jan 15, 2018 at 2:35 PM, Michael Nazzareno Trimarchi > wrote: > > Hi Peter > > > > On Mon, Dec 25, 2017 at 1:56 AM, Peter Chen wrote: > >> > >>> > On Thu, Nov 16, 2017 at 10:20 AM, Peter Chen > wrote: > >>> >> >

Request to add new VID/PID to PL2303 driver

2018-01-24 Thread Chu . Mike [朱堅宜]
Dear Johan / Greg, We have a new customer who wants to add their VID/PID to the PL2303 driver source. Can you help me? Customer: Chilitag VID: 067B PID: AAA8 { USB_DEVICE(PL2303_VENDOR_ID, PL2303_PRODUCT_ID_CHILITAG) }, #define PL2303_VENDOR_ID0x067b #define PL2303_PRODUCT_ID_CHILITAG0xaaa8

Re: [RFC/RFT usb-next v1 1/6] usb: mtu3: remove custom USB PHY handling

2018-01-24 Thread Chunfeng Yun
Hi, On Thu, 2018-01-25 at 01:16 +0100, Martin Blumenstingl wrote: > The new PHY wrapper is now wired up in the core HCD code. This means > that PHYs are now controlled (initialized, enabled, disabled, exited) > without requiring any host-driver specific code. > Remove the custom USB PHY handling

Re: [PATCH 2/4] usb: dwc3: add dwc3 glue layer for UniPhier SoCs

2018-01-24 Thread Kunihiko Hayashi
Hello Felipe, On Wed, 24 Jan 2018 14:58:12 +0200 wrote: > > Hi, > > Kunihiko Hayashi writes: > > Hello Felipe, > > > > Thank you for your comments. > > > > On Tue, 23 Jan 2018 15:12:36 +0200 wrote: > > > >> > >> Hi, > >>

[RFC/RFT usb-next v1 5/6] usb: chipidea: do not set the "phy" field in struct usb_hcd

2018-01-24 Thread Martin Blumenstingl
Now that usb_add_hcd parses all generic PHYs anyways the code which skips initialization of a single PHY will go away. Remove the code which sets struct usb_hcd's phy field from the chipidea driver as this field will go away soon. Signed-off-by: Martin Blumenstingl

[RFC/RFT usb-next v1 6/6] usb: core: hcd: remove support for initializing a single PHY

2018-01-24 Thread Martin Blumenstingl
With the new PHY wrapper in place we can now handle multiple PHYs. Remove the code which handles only one generic PHY as this is now covered (with support for multiple PHYs as well as suspend/resume support) by the new PHY wrapper. Signed-off-by: Martin Blumenstingl

[RFC/RFT usb-next v1 4/6] usb: host: ohci-platform: remove custom USB PHY handling

2018-01-24 Thread Martin Blumenstingl
The new PHY wrapper is now wired up in the core HCD code. This means that PHYs are now controlled (initialized, enabled, disabled, exited) without requiring any host-driver specific code. Remove the custom USB PHY handling from the ohci-platform driver as the core HCD code now handles this.

[RFC/RFT usb-next v1 0/6] remove driver-specific "multiple PHY" handling

2018-01-24 Thread Martin Blumenstingl
(this is the follow-up to my "initialize (multiple) PHYs for a HCD" series from [0]) Various USB controller drivers parse the "phys" device-tree property and grab all listed PHYs. There is a lot of duplicate code around this in the various drivers: - parse the "phys" property during .probe and

[RFC/RFT usb-next v1 3/6] usb: host: ehci-platform: remove custom USB PHY handling

2018-01-24 Thread Martin Blumenstingl
The new PHY wrapper is now wired up in the core HCD code. This means that PHYs are now controlled (initialized, enabled, disabled, exited) without requiring any host-driver specific code. Remove the custom USB PHY handling from the ehci-platform driver as the core HCD code now handles this.

[RFC/RFT usb-next v1 1/6] usb: mtu3: remove custom USB PHY handling

2018-01-24 Thread Martin Blumenstingl
The new PHY wrapper is now wired up in the core HCD code. This means that PHYs are now controlled (initialized, enabled, disabled, exited) without requiring any host-driver specific code. Remove the custom USB PHY handling from the mtu3 driver as the core HCD code now handles this. Signed-off-by:

[RFC/RFT usb-next v1 2/6] usb: host: xhci-mtk: remove custom USB PHY handling

2018-01-24 Thread Martin Blumenstingl
The new PHY wrapper is now wired up in the core HCD code. This means that PHYs are now controlled (initialized, enabled, disabled, exited) without requiring any host-driver specific code. Remove the custom USB PHY handling from the xhci-mtk driver as the core HCD code now handles this.

[RFC usb-next v8 3/3] usb: core: hcd: integrate the PHY wrapper into the HCD core

2018-01-24 Thread Martin Blumenstingl
This integrates the PHY wrapper into the core hcd infrastructure. Multiple PHYs which are part of the HCD's device tree node are now managed (= powered on/off when needed), by the new usb_phy_roothub code. Suspend and resume is also supported, however not for runtime/auto-suspend (which is

[RFC usb-next v8 0/3] initialize (multiple) PHYs for a HCD

2018-01-24 Thread Martin Blumenstingl
The goal of this series is to initialize multiple PHYs on a USB host controller, which is needed on Amlogic Meson GXL and GXM SoCs. - Amlogic Meson GXL and GXM SoCs come with a dwc3 IP block which has two or three USB2 ports enabled on the internal root-hub. The SoCs also provide separate USB2

[RFC usb-next v8 1/3] dt-bindings: usb: add the documentation for USB HCDs

2018-01-24 Thread Martin Blumenstingl
A USB HCD may have several PHYs which need to be configured before the the HCD starts working. This adds the documentation for such a USB HCD as well as a reference to the new "usb-hcd.txt" from all bindings that implement a USB HCD which support one USB PHY per port. Signed-off-by: Martin

[RFC usb-next v8 2/3] usb: core: add a wrapper for the USB PHYs on the HCD

2018-01-24 Thread Martin Blumenstingl
Many SoC platforms have separate devices for the USB PHY which are registered through the generic PHY framework. These PHYs have to be enabled to make the USB controller actually work. They also have to be disabled again on shutdown/suspend. Currently (at least) the following HCI platform drivers

Re: [PATCH v3 2/2] usb/gadget: Add driver for Aspeed SoC virtual hub (fwd)

2018-01-24 Thread Benjamin Herrenschmidt
gt; help improve the system] > > url: > https://github.com/0day-ci/linux/commits/Benjamin-Herrenschmidt/usb-gadget-Add-an-EP-dispose-callback-for-EP-lifetime-tracking/20180124-065635 > base: https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git next > :: branch date

[PATCH 1/2] usb: chipidea: imx: Cleanup ci_hdrc_imx_platform_flag

2018-01-24 Thread Sebastian Reichel
Some trivial cleanups, that do not change functionality. Signed-off-by: Sebastian Reichel --- drivers/usb/chipidea/ci_hdrc_imx.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/usb/chipidea/ci_hdrc_imx.c

[PATCH 2/2] usb: chipidea: imx: Fix ULPI on imx53

2018-01-24 Thread Sebastian Reichel
Traditionally, PORTSC should be set before initializing ULPI phys. But setting PORTSC before powering on the phy results in a kernel freeze on imx53 based GE PPD. As a workaround this initializes the phy early in the imx platform code and disables phy power management from the core.

Re: [U-Boot] [PATCH] imx: mx25: Remove SION bit in all pin-mux

2018-01-24 Thread Benoît Thébaudeau
Hi, On 24/01/2018 at 17:17, Michael Nazzareno Trimarchi wrote: > On Wed, Jan 24, 2018 at 5:03 PM, Benoît Thébaudeau wrote: >> On 24/01/2018 at 16:43, Michael Nazzareno Trimarchi wrote: >>> On Wed, Jan 24, 2018 at 4:39 PM, Benoît Thébaudeau >>> wrote:

Re: [U-Boot] [PATCH] imx: mx25: Remove SION bit in all pin-mux

2018-01-24 Thread Michael Nazzareno Trimarchi
Hi Fabio On Wed, Jan 24, 2018 at 4:26 PM, Michael Nazzareno Trimarchi wrote: > Hi Fabio > > On Wed, Jan 24, 2018 at 4:14 PM, Fabio Estevam wrote: >> Hi Michael, >> Can you check where SION bit is mandatory for mx25? I have on IMX51 some PINMUX

Re: [U-Boot] [PATCH] imx: mx25: Remove SION bit in all pin-mux

2018-01-24 Thread Michael Nazzareno Trimarchi
Hi On Wed, Jan 24, 2018 at 5:03 PM, Benoît Thébaudeau wrote: > On 24/01/2018 at 16:43, Michael Nazzareno Trimarchi wrote: >> On Wed, Jan 24, 2018 at 4:39 PM, Benoît Thébaudeau >> wrote: >>> On 24/01/2018 at 16:34, Benoît Thébaudeau wrote: On

Re: [U-Boot] [PATCH] imx: mx25: Remove SION bit in all pin-mux

2018-01-24 Thread Benoît Thébaudeau
On 24/01/2018 at 16:43, Michael Nazzareno Trimarchi wrote: > On Wed, Jan 24, 2018 at 4:39 PM, Benoît Thébaudeau wrote: >> On 24/01/2018 at 16:34, Benoît Thébaudeau wrote: >>> On 24/01/2018 at 16:26, Michael Nazzareno Trimarchi wrote: On Wed, Jan 24, 2018 at 4:14 PM, Fabio

Re: [U-Boot] [PATCH] imx: mx25: Remove SION bit in all pin-mux

2018-01-24 Thread Benoît Thébaudeau
Hi Michael, On 24/01/2018 at 16:26, Michael Nazzareno Trimarchi wrote: > On Wed, Jan 24, 2018 at 4:14 PM, Fabio Estevam wrote: >> On Wed, Jan 24, 2018 at 12:56 PM, Michael Trimarchi >> wrote: >>> SION bit should be used in the situation that we

Re: [U-Boot] [PATCH] imx: mx25: Remove SION bit in all pin-mux

2018-01-24 Thread Benoît Thébaudeau
On 24/01/2018 at 16:34, Benoît Thébaudeau wrote: > On 24/01/2018 at 16:26, Michael Nazzareno Trimarchi wrote: >> On Wed, Jan 24, 2018 at 4:14 PM, Fabio Estevam wrote: >>> On Wed, Jan 24, 2018 at 12:56 PM, Michael Trimarchi >>> wrote: SION

Re: [U-Boot] [PATCH] imx: mx25: Remove SION bit in all pin-mux

2018-01-24 Thread Michael Nazzareno Trimarchi
Hi On Wed, Jan 24, 2018 at 4:39 PM, Benoît Thébaudeau wrote: > On 24/01/2018 at 16:34, Benoît Thébaudeau wrote: >> On 24/01/2018 at 16:26, Michael Nazzareno Trimarchi wrote: >>> On Wed, Jan 24, 2018 at 4:14 PM, Fabio Estevam wrote: On Wed, Jan 24,

Re: [U-Boot] [PATCH] imx: mx25: Remove SION bit in all pin-mux

2018-01-24 Thread Michael Nazzareno Trimarchi
Hi Fabio On Wed, Jan 24, 2018 at 4:14 PM, Fabio Estevam wrote: > Hi Michael, > > On Wed, Jan 24, 2018 at 12:56 PM, Michael Trimarchi > wrote: >> SION bit should be used in the situation that we need >> to read back the value of a pin and should

Re: [U-Boot] [PATCH] imx: mx25: Remove SION bit in all pin-mux

2018-01-24 Thread Fabio Estevam
Hi Michael, On Wed, Jan 24, 2018 at 12:56 PM, Michael Trimarchi wrote: > SION bit should be used in the situation that we need > to read back the value of a pin and should be set by > default. This can generate any kind of random malfunction > as described in this

[PATCH] imx: mx25: Remove SION bit in all pin-mux

2018-01-24 Thread Michael Trimarchi
SION bit should be used in the situation that we need to read back the value of a pin and should be set by default. This can generate any kind of random malfunction as described in this thread. According to this thread: https://www.spinics.net/lists/linux-usb/msg162574.html We consider this an

[PATCH 11/11] usb: dwc2: Enable LPM

2018-01-24 Thread Grigor Tovmasyan
From: John Youn Set 'lpm_capable' flag in the gadget structure so indicating that LPM is supported. Signed-off-by: Sevak Arakelyan Signed-off-by: Grigor Tovmasyan --- drivers/usb/dwc2/gadget.c | 4 1 file changed, 4

[PATCH 10/11] usb: dwc2: Add core state checking

2018-01-24 Thread Grigor Tovmasyan
Added core state checking in dwc2_hsotg_ep_queue() function to make sure that application will submit requests only in L0 state. Signed-off-by: Grigor Tovmasyan --- drivers/usb/dwc2/gadget.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 09/11] usb: dwc2: Add call_gadget() function call

2018-01-24 Thread Grigor Tovmasyan
Added call_gadget() function call when entering to L1 state to inform gadget that core is in L1 state. Did the same thing when exiting from L1 state to inform gadget that core is in L0 state. Signed-off-by: Grigor Tovmasyan --- drivers/usb/dwc2/core_intr.c | 6 ++ 1

[PATCH 08/11] usb: dwc2: gadget: Configure the core to enable LPM

2018-01-24 Thread Grigor Tovmasyan
From: Sevak Arakelyan Configure core in device mode to support LPM according to programming guide. Device will start giving valid responses for LPM tokens. After this patch device side LPM will start working. Signed-off-by: Sevak Arakelyan

[PATCH 07/11] usb: dwc2: Enable LPM Transaction Received interrupt

2018-01-24 Thread Grigor Tovmasyan
From: Sevak Arakelyan Enable "LPM Transaction Received" interrupt for receive an interrupt when host will send LPM token. Signed-off-by: Sevak Arakelyan Signed-off-by: Grigor Tovmasyan --- drivers/usb/dwc2/core_intr.c | 5 +++--

[PATCH 06/11] usb: dwc2: gadget: LPM interrupt handler

2018-01-24 Thread Grigor Tovmasyan
From: Sevak Arakelyan This interrupt indicates that an LPM transaction was received on the USB bus. After getting this interrupt we are going from L0 state to L1 state. Signed-off-by: Sevak Arakelyan Signed-off-by: Grigor Tovmasyan

[PATCH 05/11] usb: dwc2: gadget: Add functionality to exit from LPM L1 state

2018-01-24 Thread Grigor Tovmasyan
From: Sevak Arakelyan Add a function which will be called if device is in L1 sleep state and Resume/Remote Wakeup Detected interrupt is asserted. Signed-off-by: Sevak Arakelyan Signed-off-by: Grigor Tovmasyan ---

[PATCH 04/11] usb: dwc2: Add core parameters for LPM support

2018-01-24 Thread Grigor Tovmasyan
From: Sevak Arakelyan Add lpm, lpm_clock_gating, besl, hird_threshold_en and hird_threshold core parameters. These will indicate LPM and LPM Errata support as well as chosen L1 sleeping mode for the core and PHY. Signed-off-by: Sevak Arakelyan

[PATCH 03/11] usb: dwc2: Rename GLPMCFG... definitions

2018-01-24 Thread Grigor Tovmasyan
From: Sevak Arakelyan Make field names of GLPMCFG register in definitions to be the same with the databook. Signed-off-by: Sevak Arakelyan Signed-off-by: Grigor Tovmasyan --- drivers/usb/dwc2/hw.h | 38

[PATCH 02/11] usb: dwc2: Backup and restore PCGCCTL1 register

2018-01-24 Thread Grigor Tovmasyan
From: Razmik Karapetyan Backup PCGCCTL1 register when entering hibernation mode and restore it after exiting from hibernation, to keep active ACG feature. Signed-off-by: Razmik Karapetyan Signed-off-by: Grigor Tovmasyan ---

[PATCH 01/11] usb: dwc2: Add ACG support to the driver

2018-01-24 Thread Grigor Tovmasyan
From: Razmik Karapetyan Added function for supporting Active Clock Gating functionality in the driver. PCGCCTL1 (Power and Clock Control) register will be used for controlling the core`s active clock gating feature, and the previously reserved 12th bit in GHWCFG4 now

[PATCH 00/11] usb: dwc2: gadget: Add ACG and LPM support

2018-01-24 Thread Grigor Tovmasyan
This series contains patches which are already have been sent in "usb: dwc2: fixes, enhancements and new features" series. That patch series was too large, and based on community feedbacks decided to split that series into small pieces. This is a third part. In this series we included Active

Re: [PATCH 2/4] usb: dwc3: add dwc3 glue layer for UniPhier SoCs

2018-01-24 Thread Felipe Balbi
Hi, Kunihiko Hayashi writes: > Hello Felipe, > > Thank you for your comments. > > On Tue, 23 Jan 2018 15:12:36 +0200 wrote: > >> >> Hi, >> >> Kunihiko Hayashi writes: >> > Add a specific glue layer for

Re: [PATCH 2/4] usb: dwc3: add dwc3 glue layer for UniPhier SoCs

2018-01-24 Thread Kunihiko Hayashi
Hello Felipe, Thank you for your comments. On Tue, 23 Jan 2018 15:12:36 +0200 wrote: > > Hi, > > Kunihiko Hayashi writes: > > Add a specific glue layer for UniPhier SoC platform to support > > USB host mode. It manages hardware operating

Re: [PATCH 2/2] usb: dwc3: drd: Fix lock-up on ID change during system suspend/resume

2018-01-24 Thread Roger Quadros
On 23/01/18 14:41, Roger Quadros wrote: > Hi Manu, > > On 23/01/18 05:45, Manu Gautam wrote: >> Hi, >> >> >> On 1/22/2018 6:31 PM, Roger Quadros wrote: >>> Adding/removing host/gadget controller before .pm_complete() >>> causes a lock-up. Let's prevent any dual-role state change >>> between

Re: USB-C Devices only show up if connected at boot

2018-01-24 Thread Mike Lothian
On 24 January 2018 at 10:42, Oliver Neukum wrote: > Am Mittwoch, den 24.01.2018, 10:30 + schrieb Mike Lothian: > > echo "file $NAMEOFKERNELSOURCEFILEYOUWANT +mfp" > > /sys/kernel/debug/dynamic_debug/control > > HTH > Oliver > OK so I'm enabling

Re: [PATCH 1/6] USB: move many drivers to use DEVICE_ATTR_RW

2018-01-24 Thread Matthieu CASTET
Hi, Le Tue, 23 Jan 2018 11:24:05 +0100, Greg Kroah-Hartman a écrit : > Instead of "open coding" a DEVICE_ATTR() define, use the > DEVICE_ATTR_RW() macro instead, which does everything properly instead. > > This does require a few static functions to be renamed to

Re: USB-C Devices only show up if connected at boot

2018-01-24 Thread Oliver Neukum
Am Mittwoch, den 24.01.2018, 10:30 + schrieb Mike Lothian: > On 24 January 2018 at 10:04, Oliver Neukum wrote: > > > > Am Mittwoch, den 24.01.2018, 09:36 + schrieb Mike Lothian: > > > > > > > > > I've played around with this some more, if the device is connected > > >

Re: [PATCH v3 2/2] usb/gadget: Add driver for Aspeed SoC virtual hub (fwd)

2018-01-24 Thread Julia Lawall
help improve the system] url: https://github.com/0day-ci/linux/commits/Benjamin-Herrenschmidt/usb-gadget-Add-an-EP-dispose-callback-for-EP-lifetime-tracking/20180124-065635 base: https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git next :: branch date: 2 hours ago :: commit

Re: USB-C Devices only show up if connected at boot

2018-01-24 Thread Mike Lothian
On 24 January 2018 at 10:04, Oliver Neukum wrote: > Am Mittwoch, den 24.01.2018, 09:36 + schrieb Mike Lothian: >> >> I've played around with this some more, if the device is connected >> after boot nothing shows when it's plugged in >> >> I did however get more messages out

[no subject]

2018-01-24 Thread Davidson Sally
-- Guten Tag: Sind Sie in finanziellen Schwierigkeiten? Benötigen Sie ein Darlehen mit niedrigem Zinssatz? Wenn ja, kontaktieren Sie uns jetzt mit Ihr Name: Land: Darlehensbetrag: Telefonnummer: Darlehens Dauer: Staat: Sex: Beruf: Monatliches Einkommen: Alter: Privatadresse: -- To unsubscribe

Re: USB-C Devices only show up if connected at boot

2018-01-24 Thread Oliver Neukum
Am Mittwoch, den 24.01.2018, 09:36 + schrieb Mike Lothian: > > I've played around with this some more, if the device is connected > after boot nothing shows when it's plugged in > > I did however get more messages out when I disconnected the device > after booting with it (see attached) >

Re: USB-C Devices only show up if connected at boot

2018-01-24 Thread Mike Lothian
On Wed, 24 Jan 2018 at 08:46 Greg KH wrote: > > > > > Hi > > > > PCI Hotplug and ACPI Hotplug are disabled on my system due to bug > > https://bugzilla.kernel.org/show_bug.cgi?id=112121 where by my NVMe > > drive would disappear from the system after suspend making my

Re: [PATCH 4.9] usbip: Fix implicit fallthrough warning

2018-01-24 Thread Greg KH
On Tue, Jan 23, 2018 at 07:32:11PM -0700, Shuah Khan wrote: > From: Jonathan Dieter > > Upstream commit cfd6ed4537a9 ("usbip: Fix implicit fallthrough warning") > > GCC 7 now warns when switch statements fall through implicitly, and with > -Werror enabled in configure.ac,

Re: [PATCH 4.9] usbip: prevent vhci_hcd driver from leaking a socket pointer address

2018-01-24 Thread Greg KH
On Tue, Jan 23, 2018 at 07:30:06PM -0700, Shuah Khan wrote: > commit 2f2d0088eb93 ("usbip: prevent vhci_hcd driver from leaking a > socket pointer address") Now queued up for 4.4 and 4.9, thanks. greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a

Re: USB-C Devices only show up if connected at boot

2018-01-24 Thread Greg KH
On Wed, Jan 24, 2018 at 08:39:10AM +, Mike Lothian wrote: > On Wed, 24 Jan 2018 at 04:07 Greg KH wrote: > > > > On Tue, Jan 23, 2018 at 05:43:27PM +, Mike Lothian wrote: > > > On Tue, 23 Jan 2018 at 17:30 Greg KH wrote: > > > > > >

Re: [PATCH v6 05/99] xarray: Add definition of struct xarray

2018-01-24 Thread Paul Bolle
Mathhew, Just a minor question. On Wed, 2018-01-17 at 12:20 -0800, Matthew Wilcox wrote: > This is a direct replacement for struct radix_tree_root. Some of the > struct members have changed name; convert those, and use a #define so > that radix_tree users continue to work without change. > >

Re: USB-C Devices only show up if connected at boot

2018-01-24 Thread Mike Lothian
On Wed, 24 Jan 2018 at 04:07 Greg KH wrote: > > On Tue, Jan 23, 2018 at 05:43:27PM +, Mike Lothian wrote: > > On Tue, 23 Jan 2018 at 17:30 Greg KH wrote: > > > > > > On Tue, Jan 23, 2018 at 05:12:03PM +, Mike Lothian wrote: > > > >

[PATCH] usb: gadget: f_fs: Process all descriptors during bind

2018-01-24 Thread Jack Pham
During _ffs_func_bind(), the received descriptors are evaluated to prepare for binding with the gadget in order to allocate endpoints and optionally set up OS descriptors. However, the high- and super-speed descriptors are only parsed based on whether the gadget_is_dualspeed() and