Re: [PATCH v5 4/5] typec: tcpm: Represent source supply through power_supply

2018-03-21 Thread Guenter Roeck
On 03/20/2018 07:33 AM, Adam Thomson wrote: This commit adds a power_supply class instance to represent a PD source's voltage and current properties. This provides an interface for reading these properties from user-space or other drivers. For PPS enabled Sources, this also provides write

Re: [PATCH v5 3/5] power: supply: Add 'usb_type' property and supporting code

2018-03-21 Thread Guenter Roeck
On 03/20/2018 07:33 AM, Adam Thomson wrote: This commit adds the 'usb_type' property to represent USB supplies which can report a number of different types based on a connection event. Examples of this already exist in drivers whereby the existing 'type' property is updated, based on an event,

Re: [PATCH v5 1/5] typec: tcpm: Add core support for sink side PPS

2018-03-21 Thread Guenter Roeck
On 03/20/2018 07:33 AM, Adam Thomson wrote: This commit adds code to handle requesting of PPS APDOs. Switching between standard PDOs and APDOs, and re-requesting an APDO to modify operating voltage/current will be triggered by an external call into TCPM. Signed-off-by: Adam Thomson

Re: [PATCH v5 5/5] typec: tcpm: Add support for sink PPS related messages

2018-03-21 Thread Guenter Roeck
On 03/20/2018 07:33 AM, Adam Thomson wrote: This commit adds sink side support for Get_Status, Status, Get_PPS_Status and PPS_Status handling. As there's the potential for a partner to respond with Not_Supported, handling of this message is also added. Sending of Not_Supported is added to handle

[PATCH] usbip: tools: usbipd: exclude exported devices from exportable device list

2018-03-21 Thread Shuah Khan
usbipd includes exported devices in response to exportable device list. Exclude exported devices from exportable device list to avoid: - import requests for devices that are exported only to fail the request. - revealing devices that are imported by a client to another client. Signed-off-by:

RE: About patchwork for linux-usb

2018-03-21 Thread Peter Chen
> > > > At some situations, we may need to save reviewing patches from > > > > web, but I can't find linux-usb at > > > https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fp > > > atchwork.k > > > > ernel.org%2F=02%7C01%7Cpeter.chen%40nxp.com%7Cbef6ada7885641ed5 > > > >

Re: ASMedia SATA Bridge not enumerating without quirk

2018-03-21 Thread Menion
Well, still, my two cents here, is it really that if you have UAS in a module and you don't load it but connect an UAS capable device, this device is not enumerated rather than downgraded to usb-storage? 2018-03-21 19:10 GMT+01:00 Mike Lothian : > So this is a brown paper bag

[FaceCam 1000X]uvcvideo 3-2.3:1.0: Entity type for entity Processing 2 was not initialized!

2018-03-21 Thread Cristian
Hello, Open report in launchpad.net https://bugs.launchpad.net/bugs/1757509 Kernel Version: Ubuntu 4.15.0-13.14-generic 4.15.10 dmesg: [20147.228136] uvcvideo 3-2.3:1.0: Entity type for entity Processing 2 was not initialized! [20147.228146] uvcvideo 3-2.3:1.0: Entity type for entity Extension

Re: ASMedia SATA Bridge not enumerating without quirk

2018-03-21 Thread Mike Lothian
So this is a brown paper bag moment, I don't use usb-uas on my laptop, so the kernel always does the right thing (I've enabled it now I know about it) The router has usb-uas compiled as a module, but didn't have it installed, it's not one of the default ones it seems After installing

Re: ASMedia SATA Bridge not enumerating without quirk

2018-03-21 Thread Mike Lothian
Lastly here's the lsusb -v and dmesg from 4.9.87 on the router without the quirk added On 21 March 2018 at 17:50, Mike Lothian wrote: > Also here's the kernel config for the router, it's now 4.9.87 > > > > On 21 March 2018 at 17:23, Menion wrote: >> Yes

Re: ASMedia SATA Bridge not enumerating without quirk

2018-03-21 Thread Mike Lothian
Also here's the kernel config for the router, it's now 4.9.87 On 21 March 2018 at 17:23, Menion wrote: > Yes that was the point. > Curious that the device worked fine in 17.01.4 and not in snapshot, > but in 17.01.4 do you remember if it went in UAS or USB-STORAGE mode? > I

Re: ASMedia SATA Bridge not enumerating without quirk

2018-03-21 Thread Mike Lothian
OK here's what's on my laptop, running 4.16-rc1, I didn't need to enter a quirk On 21 March 2018 at 17:23, Menion wrote: > Yes that was the point. > Curious that the device worked fine in 17.01.4 and not in snapshot, > but in 17.01.4 do you remember if it went in UAS or

Re: linux-next: Tree for Mar 21 (usb/dwc3)

2018-03-21 Thread Randy Dunlap
On 03/21/2018 01:25 AM, Stephen Rothwell wrote: > Hi all, > > Changes since 20180320: > on i386: ERROR: "__tracepoint_dwc3_gadget_generic_cmd" [drivers/usb/dwc3/dwc3.ko] undefined! ERROR: "__tracepoint_dwc3_ep_queue" [drivers/usb/dwc3/dwc3.ko] undefined! ERROR:

Re: ASMedia SATA Bridge not enumerating without quirk

2018-03-21 Thread Menion
Yes that was the point. Curious that the device worked fine in 17.01.4 and not in snapshot, but in 17.01.4 do you remember if it went in UAS or USB-STORAGE mode? I cannot answer here, but I am wondering if it is possible that if the kernel is compiled without UAS support, then a device showing

Re: ASMedia SATA Bridge not enumerating without quirk

2018-03-21 Thread Mike Lothian
Sorry I'm not sure what you mean by that, would you like the output of lsusb -v before and after the quirk is added? And again from my laptop? I'd like to point the device worked fine when running a 4.4 kernel on LEDE 17.01.4 On 21 March 2018 at 17:10, Menion wrote: > Then it

Re: ASMedia SATA Bridge not enumerating without quirk

2018-03-21 Thread Menion
Then it is so strange, it is completely dead from USB host perspective in UASP mode What lsusb shows when it is attached in UASP mode? Can you test it with some "regular" host with USB 3.0, like a PC? 2018-03-21 18:07 GMT+01:00 Mike Lothian : > Sorry, yes that was me

Re: ASMedia SATA Bridge not enumerating without quirk

2018-03-21 Thread Mike Lothian
Sorry, yes that was me disconnecting the device and reconnecting it, just to confirm that it was the quirk that was fixing things (I might not have connected it into the same port) I am changing the quirks in the modules config and reattaching, modprobe on this device doesn't seem to let me

Re: ASMedia SATA Bridge not enumerating without quirk

2018-03-21 Thread Menion
I see a disconnect from port 4:1 of some un-enumerated device then connect to port 2:1 with UAS blacklist: [ 281.814757] usb 4-1: USB disconnect, device number 2 [ 283.418292] usb 2-1: new SuperSpeed USB device number 2 using xhci-hcd [ 482.153319] usb 2-1: USB disconnect, device number 2 [

Re: ASMedia SATA Bridge not enumerating without quirk

2018-03-21 Thread Mike Lothian
It had both, as did my follow up, the follow up should be more clear though On 21 March 2018 at 16:45, Menion wrote: > You sent the dmesg with quirks :u enabled > We need the one without quirks :u, when the device takes UAS driver > Bye > > 2018-03-21 17:41 GMT+01:00 Mike

Re: ASMedia SATA Bridge not enumerating without quirk

2018-03-21 Thread Mike Lothian
So I rebooted my router, and repeated without the other usb stick attached So you should have it with it booting without the quirk, reconnecting without the quirk, then reconnecting with the quirk, where the hard disk is enumerated On 21 March 2018 at 16:41, Mike Lothian

Re: ASMedia SATA Bridge not enumerating without quirk

2018-03-21 Thread Menion
You sent the dmesg with quirks :u enabled We need the one without quirks :u, when the device takes UAS driver Bye 2018-03-21 17:41 GMT+01:00 Mike Lothian : > Hi > > Please find attached my dmesg > > Cheers > > Mike > > On 21 March 2018 at 16:12, Oliver Neukum

Re: ASMedia SATA Bridge not enumerating without quirk

2018-03-21 Thread Mike Lothian
Hi Please find attached my dmesg Cheers Mike On 21 March 2018 at 16:12, Oliver Neukum wrote: > Am Mittwoch, den 21.03.2018, 17:09 +0100 schrieb Greg KH: >> > I'm guessing it doesn't quite match up with the rules already in place >> > in uas-detect.h >> >> That device has a

Re: ASMedia SATA Bridge not enumerating without quirk

2018-03-21 Thread Oliver Neukum
Am Mittwoch, den 21.03.2018, 17:09 +0100 schrieb Greg KH: > > I'm guessing it doesn't quite match up with the rules already in place > > in uas-detect.h > > That device has a quirk already as a "normal" usb-storage device. > Oliver added it back in 2013 with 32c37fc30c52 ("usb-storage: add quirk

Re: ASMedia SATA Bridge not enumerating without quirk

2018-03-21 Thread Menion
READ_CAPACITY_16 does not have anything to do in blacklisting via quirks the device to usb-storage I have checked it in 4.9.86 and it is not quirked to usb-storage: /* Reported by Oliver Neukum */ UNUSUAL_DEV( 0x174c, 0x55aa, 0x0100, 0x0100, "ASMedia", "AS2105", USB_SC_DEVICE,

Re: ASMedia SATA Bridge not enumerating without quirk

2018-03-21 Thread Greg KH
On Wed, Mar 21, 2018 at 03:39:06PM +, Mike Lothian wrote: > Hi > > I'm running kernel 4.9.86 on my router > > I have to: > > echo 174c:55aa:u > /sys/module/usb_storage/parameters/quirks > > To get it to work correctly > > I'm attaching the output of lsusb -v > > I'm guessing it doesn't

Re: ASMedia SATA Bridge not enumerating without quirk

2018-03-21 Thread Menion
Can you please attach dmesg output? 2018-03-21 16:39 GMT+01:00 Mike Lothian : > Hi > > I'm running kernel 4.9.86 on my router > > I have to: > > echo 174c:55aa:u > /sys/module/usb_storage/parameters/quirks > > To get it to work correctly > > I'm attaching the output of lsusb

ASMedia SATA Bridge not enumerating without quirk

2018-03-21 Thread Mike Lothian
Hi I'm running kernel 4.9.86 on my router I have to: echo 174c:55aa:u > /sys/module/usb_storage/parameters/quirks To get it to work correctly I'm attaching the output of lsusb -v I'm guessing it doesn't quite match up with the rules already in place in uas-detect.h Looks like it's an

Re: About patchwork for linux-usb

2018-03-21 Thread Greg Kroah-Hartman
On Mon, Mar 19, 2018 at 08:57:07AM +, Peter Chen wrote: > > > > > > At some situations, we may need to save reviewing patches from web, > > > but I can't find linux-usb at > > https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchwork.k > >

[PATCH] HID: usbhid: extend the polling interval configuration to keyboards

2018-03-21 Thread Filip Alac
For mouse and joystick devices user can change the polling interval via usbhid.mousepoll and usbhid.jspoll. Implement the same thing for keyboards, so user can reduce(or increase) input latency this way. This has been tested with a Cooler Master Devastator with kbpoll=32, resulting in delay

[PATCH v5 2/2] usb/gadget/uvc-configfs Fix linked flag in a format not being set when format is linked into streaming header

2018-03-21 Thread Joel Pepper
While checks are in place to avoid attributes and children of a format being manipulated after the format is linked into the streaming header, the linked flag was never actually set, invalidating the protections. Signed-off-by: Joel Pepper ---

[PATCH v5 0/2] usb/gadget/uvc-configfs usb/gadget/uvc-configs Fix host unable to negotiate framesizes other than first

2018-03-21 Thread Joel Pepper
This patchset is mostly concerned with fixing the driver setting incorrect bFrameIndexes which breaks frame descriptor negotiation, for details refer to the first patch. However this fix needed another bug relating to the "linked" flag not being set on formats to be fixed first. As this bug has

[PATCH v5 1/2] usb/gadget/uvc-configs Fix host unable to negotiate framesizes other than first

2018-03-21 Thread Joel Pepper
- Add bFrameIndex as a UVCG_FRAME_ATTR_RO for each frame size. - Automatically assign ascending bFrameIndex to each frame in a format. Before all "bFrameindex" attributes were set to "1" with no way to configure the gadget otherwise. This resulted in the host always negotiating for bFrameIndex 1

Re: [PATCH v4] usb/gadget/uvc-configs Fix host unable to negotiate framesizes other than first

2018-03-21 Thread Joel Pepper
Please disregard this version, I discovered a different bug which needs to be fixed before the -EBUSY behaviour can implemented, both will come in v5 On 21.03.2018 11:20, Joel Pepper wrote: > - Add bFrameIndex as a UVCG_FRAME_ATTR_RO for each frame size. > - Automatically assign ascending

Re: [usb-next PATCH] usb: xhci: skip phys initialization of shared hcd

2018-03-21 Thread Roger Quadros
On 21/03/18 13:50, Chunfeng Yun wrote: > Hi Roger, > > On Wed, 2018-03-21 at 11:05 +0200, Roger Quadros wrote: >> Hi Chunfeng, >> >> On 21/03/18 08:12, Chunfeng Yun wrote: >>> The phys has already been initialized when add primary hcd, >>> including usb2 phys and usb3 phys also if exist, so

Re: [PATCH 2/5] usb: typec: fusb302: remove max_snk_* for sink config

2018-03-21 Thread Hans de Goede
Hi, On 21-03-18 12:19, Jun Li wrote: -Original Message- From: Hans de Goede [mailto:hdego...@redhat.com] Sent: 2018年3月20日 20:29 To: Jun Li ; gre...@linuxfoundation.org; robh...@kernel.org; mark.rutl...@arm.com; heikki.kroge...@linux.intel.com; li...@roeck-us.net;

Re: [usb-next PATCH] usb: xhci: skip phys initialization of shared hcd

2018-03-21 Thread Chunfeng Yun
Hi Roger, On Wed, 2018-03-21 at 11:05 +0200, Roger Quadros wrote: > Hi Chunfeng, > > On 21/03/18 08:12, Chunfeng Yun wrote: > > The phys has already been initialized when add primary hcd, > > including usb2 phys and usb3 phys also if exist, so needn't > > re-parse "phys" property again. > > > >

Re: [PATCH usb-next v10 3/8] usb: core: add a wrapper for the USB PHYs on the HCD

2018-03-21 Thread Roger Quadros
Martin, On 21/03/18 00:01, Martin Blumenstingl wrote: > Hi Roger, Hi Chunfeng, > > On Tue, Mar 20, 2018 at 1:04 PM, Chunfeng Yun > wrote: >> Hi Martin & Roger: >> >> On Mon, 2018-03-19 at 17:12 +0100, Martin Blumenstingl wrote: >>> Hi Roger, >>> >>> On Mon, Mar 19,

RE: [PATCH 2/5] usb: typec: fusb302: remove max_snk_* for sink config

2018-03-21 Thread Jun Li
> -Original Message- > From: Hans de Goede [mailto:hdego...@redhat.com] > Sent: 2018年3月20日 20:29 > To: Jun Li ; gre...@linuxfoundation.org; > robh...@kernel.org; mark.rutl...@arm.com; > heikki.kroge...@linux.intel.com; li...@roeck-us.net; rmf...@gmail.com; >

RE: [PATCH 1/5] usb: typec: tcpm: source pdo selection update

2018-03-21 Thread Jun Li
Hi > -Original Message- > From: Hans de Goede [mailto:hdego...@redhat.com] > Sent: 2018年3月20日 20:27 > To: Jun Li ; gre...@linuxfoundation.org; > robh...@kernel.org; mark.rutl...@arm.com; > heikki.kroge...@linux.intel.com; li...@roeck-us.net; rmf...@gmail.com; >

RE: [PATCH v1 2/3] usb: dwc2: Change ISOC DDMA flow

2018-03-21 Thread Zengtao (B)
Hi Minas: >-Original Message- >From: Minas Harutyunyan [mailto:minas.harutyun...@synopsys.com] >Sent: Wednesday, March 21, 2018 4:08 PM >To: Zengtao (B) ; Minas Harutyunyan >; John Youn ; >Felipe Balbi

[PATCH v4] usb/gadget/uvc-configs Fix host unable to negotiate framesizes other than first

2018-03-21 Thread Joel Pepper
- Add bFrameIndex as a UVCG_FRAME_ATTR_RO for each frame size. - Automatically assign ascending bFrameIndex to each frame in a format. Before all "bFrameindex" attributes were set to "1" with no way to configure the gadget otherwise. This resulted in the host always negotiating for bFrameIndex 1

Re: [PATCH] usb/gadget/uvc-configs Fix host unable to negotiate framesizes other than first

2018-03-21 Thread Laurent Pinchart
Hi Joel, On Wednesday, 21 March 2018 11:53:45 EET Joel Pepper wrote: > Hi Laurent, > > Thanks for the heads up. I noticed the goof with Patch v3 right after > sending, but apparently I screwed up the commit amend too. I'm still > getting accustomed to kernel development. Sorry for wasting your

Re: [PATCH] usb/gadget/uvc-configs Fix host unable to negotiate framesizes other than first

2018-03-21 Thread Laurent Pinchart
Hi Joel, Thank you for the patch. On Tuesday, 20 March 2018 22:28:53 EET Joel Pepper wrote: > - Add bFrameIndex as a UVCG_FRAME_ATTR_RO for each frame size. > - Automatically assign ascending bFrameIndex to each frame in a format. > > Before all "bFrameindex" attributes were set to "1" with no

Re: [PATCHv2] usb/gadget/uvc-configs Fix host unable to negotiate framesizes other than first

2018-03-21 Thread Laurent Pinchart
Hi Joel, On Tuesday, 20 March 2018 12:30:00 EET Joel Pepper wrote: > On 20.03.2018 10:02, Laurent Pinchart wrote: > > Hi Joel, > > > > (CC'ing Paul Elder who is working on the UVC gadget driver) > > > > Thank you for the patch. > > > > On Monday, 19 March 2018 21:36:41 EET Joel Pepper wrote: >

Re: [PATCH v1 0/3] usb: dwc2: gadget: Update ISOC DDMA flow.

2018-03-21 Thread Minas Harutyunyan
Hi Filipe, On 3/17/2018 1:08 PM, Minas Harutyunyan wrote: > This series fully update existing ISOC DDMA flow which initially based on > 2 descriptor chains. Switching between desc chains performing based on BNA > interrupt. Because of BNA interrupt few packets can be lost. > > 1/3 patch unmask

Re: [usb-next PATCH] usb: xhci: skip phys initialization of shared hcd

2018-03-21 Thread Roger Quadros
Hi Chunfeng, On 21/03/18 08:12, Chunfeng Yun wrote: > The phys has already been initialized when add primary hcd, > including usb2 phys and usb3 phys also if exist, so needn't > re-parse "phys" property again. > > Signed-off-by: Chunfeng Yun > --- >

Re: [PATCH v1 2/3] usb: dwc2: Change ISOC DDMA flow

2018-03-21 Thread Minas Harutyunyan
Hi Zengtao, On 3/21/2018 6:17 AM, Zengtao (B) wrote: >> -Original Message- > >> From: linux-usb-ow...@vger.kernel.org > >> [mailto:linux-usb-ow...@vger.kernel.org] On Behalf Of Minas Harutyunyan > >> Sent: Tuesday, March 20, 2018 10:40 PM > >> To: Zengtao (B)

[usb-next PATCH] usb: xhci: skip phys initialization of shared hcd

2018-03-21 Thread Chunfeng Yun
The phys has already been initialized when add primary hcd, including usb2 phys and usb3 phys also if exist, so needn't re-parse "phys" property again. Signed-off-by: Chunfeng Yun --- drivers/usb/host/xhci-mtk.c | 1 + drivers/usb/host/xhci-plat.c | 1 + 2 files