RE: [PATCH v4 11/13] staging: typec: tcpci: keep the not connecting cc line open

2018-03-30 Thread Jun Li
Hi > -Original Message- > From: Guenter Roeck [mailto:groe...@gmail.com] On Behalf Of Guenter Roeck > Sent: 2018年3月30日 23:16 > To: Jun Li ; robh...@kernel.org; gre...@linuxfoundation.org; > heikki.kroge...@linux.intel.com > Cc: a.ha...@samsung.com; shufan_...@richtek.com;

RE: [PATCH v4 10/13] usb: typec: tcpm: set cc for drp toggling attach

2018-03-30 Thread Jun Li
> -Original Message- > From: Guenter Roeck [mailto:groe...@gmail.com] On Behalf Of Guenter Roeck > Sent: 2018年3月30日 6:49 > To: Jun Li > Cc: robh...@kernel.org; gre...@linuxfoundation.org; > heikki.kroge...@linux.intel.com; a.ha...@samsung.com; > shufan_...@richtek.com;

RE: [PATCH v4 10/13] usb: typec: tcpm: set cc for drp toggling attach

2018-03-30 Thread Jun Li
Hi > -Original Message- > From: Mats Karrman [mailto:mats.dev.l...@gmail.com] > Sent: 2018年3月30日 5:19 > To: Jun Li ; robh...@kernel.org; gre...@linuxfoundation.org; > heikki.kroge...@linux.intel.com; li...@roeck-us.net > Cc: a.ha...@samsung.com; shufan_...@richtek.com;

RE: [PATCH v4 01/13] dt-bindings: connector: add properties for typec

2018-03-30 Thread Jun Li
Hi > -Original Message- > From: Mats Karrman [mailto:mats.dev.l...@gmail.com] > Sent: 2018年3月30日 3:54 > To: Jun Li ; robh...@kernel.org; gre...@linuxfoundation.org; > heikki.kroge...@linux.intel.com; li...@roeck-us.net > Cc: a.ha...@samsung.com; shufan_...@richtek.com;

RE: [PATCH v4 04/13] usb: typec: add fwnode to tcpc

2018-03-30 Thread Jun Li
Hi > -Original Message- > From: Heikki Krogerus [mailto:heikki.kroge...@linux.intel.com] > Sent: 2018年3月29日 20:58 > To: Jun Li > Cc: robh...@kernel.org; gre...@linuxfoundation.org; li...@roeck-us.net; > a.ha...@samsung.com; shufan_...@richtek.com; Peter Chen >

RE: [PATCH v4 07/13] staging: typec: tcpci: register port before request irq

2018-03-30 Thread Jun Li
Hi > -Original Message- > From: Dan Carpenter [mailto:dan.carpen...@oracle.com] > Sent: 2018年3月29日 18:52 > To: Jun Li > Cc: robh...@kernel.org; gre...@linuxfoundation.org; > heikki.kroge...@linux.intel.com; li...@roeck-us.net; > de...@driverdev.osuosl.org;

[PATCH] usb: gadget: f_midi: Use refcount when freeing f_midi_opts

2018-03-30 Thread Jerry Zhang
Currently, the midi function is not freed until it is both removed from the config and released by the user. Since the user could take a long time to release the card, it's possible that the function could be unlinked and thus f_midi_opts would be null when freeing f_midi. Thus, refcount

[PATCH] usb: gadget: f_fs: Add compat_ioctl to epfiles

2018-03-30 Thread Jerry Zhang
This allows 32 bit owners of ffs endpoints to make ioctls into a 64 bit kernel. All of the current epfile ioctls can be handled with the same struct definitions as regular ioctl. Signed-off-by: Jerry Zhang --- drivers/usb/gadget/function/f_fs.c | 11 +++ 1 file

Re: [PATCH v4 11/13] staging: typec: tcpci: keep the not connecting cc line open

2018-03-30 Thread Guenter Roeck
On 03/28/2018 09:06 AM, Li Jun wrote: While set polarity, we should keep the not connecting cc line to be open. The more I look at this code, the more I am confused by it. The original code doesn't touch the CC lines. This function only sets the polarity. Is it really appropriate to touch

Re: r8152 livelocks during pm_runtime_suspend

2018-03-30 Thread Jiri Slaby
On 03/30/2018, 03:17 PM, Jiri Slaby wrote: > Hi, > > I have seen r8152 from my docking station to kill my box several times > in the last few days. The notebook is new, so I don't know if this is a > regression. Forgot to add, I am seeing this in dmesg: [ 13.353239] r8152 4-1.2:1.0 (unnamed

r8152 livelocks during pm_runtime_suspend

2018-03-30 Thread Jiri Slaby
Hi, I have seen r8152 from my docking station to kill my box several times in the last few days. The notebook is new, so I don't know if this is a regression. I have the NIC connected all the time. And when I return to the notebook after a while, the networking is dead. Looking at the stack

[usb:usb-next 76/100] ERROR: "usb_role_switch_get" [drivers/extcon/extcon-axp288.ko] undefined!

2018-03-30 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-next head: 5267c5e09c25e2ee6242b37833a9bdf9d97f54a2 commit: d54f063cdbe414590c97d990111ddff25c6f9593 [76/100] extcon: axp288: Set USB role where necessary config: i386-randconfig-b0-03301441 (attached as .config)

Re: [PATCH -next] usb: dwc2: pci: Fix error return code in dwc2_pci_probe()

2018-03-30 Thread Grigor Tovmasyan
On 3/28/2018 5:36 PM, Wei Yongjun wrote: > Fix to return error code -ENOMEM from the alloc fail error handling > case instead of 0, as done elsewhere in this function. > > Fixes: ecd29dabb2ba ("usb: dwc2: pci: Handle error cleanup in probe") > Signed-off-by: Wei Yongjun