[PATCH] usb: serial: option: add HP LT4220 support

2018-04-02 Thread Edward Chang
This patch adds support for HP LT4220. Signed-off-by: Edward Chang --- drivers/usb/serial/option.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c index 2d8d915..a8988d5 100644 ---

[PATCH] usbip: vhci_hcd: Fix usb device and sockfd leaks

2018-04-02 Thread Shuah Khan
vhci_hcd fails to do reset to put usb device and sockfd in the module remove/stop paths. Fix the leak. Signed-off-by: Shuah Khan --- drivers/usb/usbip/usbip_common.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/usbip/usbip_common.h

[PATCH] usbip: vhc_hcd: prevent module being removed while device are attached

2018-04-02 Thread Shuah Khan
vhci_hcd module can be removed even when devices are attached. Fix to prevent module removal when devices are still attached. Signed-off-by: Shuah Khan --- drivers/usb/usbip/vhci_sysfs.c | 25 + 1 file changed, 21 insertions(+), 4 deletions(-)

Re: [PATCH] usb: core: phy: Fix usb_phy_roothub_add_phy if GENERIC_PHY=n

2018-04-02 Thread Stefan Wahren
Hi Martin, > Martin Blumenstingl hat am 31. März 2018 > um 22:12 geschrieben: > > > Hello Stefan, > > On Sat, Mar 31, 2018 at 9:28 PM, Stefan Wahren wrote: > > If the generic PHY support is disabled the stub of

Re: [PATCH v3 2/2] net: usb: asix88179_178a: de-duplicate code

2018-04-02 Thread Marc Zyngier
On Mon, 2 Apr 2018 07:43:49 + Alexander Kurz wrote: > Remove the duplicated code for asix88179_178a bind and reset methods. > > Signed-off-by: Alexander Kurz > --- > drivers/net/usb/ax88179_178a.c | 137 > ++--- > 1 file

Re: [PATCH v3 2/2] net: usb: asix88179_178a: de-duplicate code

2018-04-02 Thread Marc Zyngier
[dropping Freddy as I'm getting bounces from asix.com.tw] On Mon, 2 Apr 2018 15:21:08 + Alexander Kurz wrote: Alexander, > Hi Marc, David, > with the v2 patch ("net: usb: asix88179_178a: de-duplicate code") > I made an embarrasly stupid mistake of removing the wrong

Re: dwc2: Confusing warnings in next-20180327 on Raspberry Pi

2018-04-02 Thread Stefan Wahren
Hi Grigor, > Grigor Tovmasyan hat am 2. April 2018 um > 18:00 geschrieben: > > > Hi Stefan, > > On 4/2/2018 7:47 PM, Stefan Wahren wrote: > > Hi Minas, > > > > in linux-next-20180327 i will get the following confusing warnings on the > > Raspberry Pi: > > >

Re: dwc2: Confusing warnings in next-20180327 on Raspberry Pi

2018-04-02 Thread Grigor Tovmasyan
Hi Stefan, On 4/2/2018 7:47 PM, Stefan Wahren wrote: > Hi Minas, > > in linux-next-20180327 i will get the following confusing warnings on the > Raspberry Pi: > > Linux raspberrypi 4.16.0-rc7-next-20180327+ #2 SMP PREEMPT Sat Mar 31 > 13:24:47 CEST 2018 armv6l GNU/Linux > > [6.809185]

dwc2: Confusing warnings in next-20180327 on Raspberry Pi

2018-04-02 Thread Stefan Wahren
Hi Minas, in linux-next-20180327 i will get the following confusing warnings on the Raspberry Pi: Linux raspberrypi 4.16.0-rc7-next-20180327+ #2 SMP PREEMPT Sat Mar 31 13:24:47 CEST 2018 armv6l GNU/Linux [6.809185] dwc2 2098.usb: dwc2_check_params: Invalid parameter lpm=1 [

Re: [PATCH v3 2/2] net: usb: asix88179_178a: de-duplicate code

2018-04-02 Thread Alexander Kurz
Hi Marc, David, with the v2 patch ("net: usb: asix88179_178a: de-duplicate code") I made an embarrasly stupid mistake of removing the wrong function. The v2 patch accidentially changed ax88179_link_reset() instead of ax88179_reset(). Hunk 6 of v2 ("net: usb: asix88179_178a: de-duplicate code")

Re: [PATCH v3 2/2] net: usb: asix88179_178a: de-duplicate code

2018-04-02 Thread David Miller
From: Marc Zyngier Date: Mon, 02 Apr 2018 10:45:40 +0100 > What has changed between this patch and the previous one? Having a bit > of a change-log would certainly help. Also, I would have appreciated a > reply to the questions I had on v2 before you posted a third version.

Re: [Question] MFD driver that handles clocks/resets and populates child nodes

2018-04-02 Thread Andrew Lunn
On Mon, Apr 02, 2018 at 10:21:01PM +0900, Masahiro Yamada wrote: > 2018-04-02 21:04 GMT+09:00 Andrew Lunn : > >> The maintainer of DWC3, Felipe Balbi, requested to > >> split the glue layer driver into small parts such as > >> reset, regulator, phy, etc. > > > > What exactly did

Re: [Question] MFD driver that handles clocks/resets and populates child nodes

2018-04-02 Thread Masahiro Yamada
2018-04-02 21:04 GMT+09:00 Andrew Lunn : >> The maintainer of DWC3, Felipe Balbi, requested to >> split the glue layer driver into small parts such as >> reset, regulator, phy, etc. > > What exactly did Felipe ask for? Did he ask that the patch be split > up, one patch per reset,

[PATCH 2/4] usb: gadget: udc: renesas_usb3: should remove debugfs

2018-04-02 Thread Yoshihiro Shimoda
This patch fixes an issue that this driver doesn't remove its debugfs. Fixes: 43ba968b00ea ("usb: gadget: udc: renesas_usb3: add debugfs to set the b-device mode") Cc: # v4.14+ Signed-off-by: Yoshihiro Shimoda ---

[PATCH 0/4] usb: gadget: udc: renesas_usb3: fix some major issues

2018-04-02 Thread Yoshihiro Shimoda
This patch set is based on v4.16. (I should have realized these issues in v4.16-rc cycle though...) Yoshihiro Shimoda (4): usb: gadget: udc: renesas_usb3: fix double phy_put() usb: gadget: udc: renesas_usb3: should remove debugfs usb: gadget: udc: renesas_usb3: should call

[PATCH 1/4] usb: gadget: udc: renesas_usb3: fix double phy_put()

2018-04-02 Thread Yoshihiro Shimoda
This patch fixes an issue that this driver cause double phy_put() calling. This driver must not call phy_put() in the remove because the driver calls devm_phy_get() in the probe. Fixes: 279d4bc64060 ("usb: gadget: udc: renesas_usb3: add support for generic phy") Cc: #

[PATCH 3/4] usb: gadget: udc: renesas_usb3: should call pm_runtime_enable() before add udc

2018-04-02 Thread Yoshihiro Shimoda
This patch fixes an issue that this driver causes panic if a gadget driver is already loaded because usb_add_gadget_udc() might call renesas_usb3_start() via .udc_start, and then pm_runtime_get_sync() in renesas_usb3_start() doesn't work correctly. Note that the usb3_to_dev() macro should not be

[PATCH 4/4] usb: gadget: udc: renesas_usb3: should call devm_phy_get() before add udc

2018-04-02 Thread Yoshihiro Shimoda
This patch fixes an issue that this driver cannot call phy_init() if a gadget driver is alreadly loaded because usb_add_gadget_udc() might call renesas_usb3_start() via .udc_start. Fixes: 279d4bc64060 ("usb: gadget: udc: renesas_usb3: add support for generic phy") Cc: #

Re: [Question] MFD driver that handles clocks/resets and populates child nodes

2018-04-02 Thread Andrew Lunn
> The maintainer of DWC3, Felipe Balbi, requested to > split the glue layer driver into small parts such as > reset, regulator, phy, etc. What exactly did Felipe ask for? Did he ask that the patch be split up, one patch per reset, regulator, phy etc? Are all these resources used just by the

Re: [PATCH v3 2/2] net: usb: asix88179_178a: de-duplicate code

2018-04-02 Thread Marc Zyngier
On Mon, 02 Apr 2018 08:43:49 +0100, Alexander Kurz wrote: Alexander, > > Remove the duplicated code for asix88179_178a bind and reset methods. > > Signed-off-by: Alexander Kurz > --- > drivers/net/usb/ax88179_178a.c | 137 > ++--- > 1 file

dwc2: Memory leak in dwc2_gadget_init

2018-04-02 Thread Stefan Wahren
Hi Minas, i noticed that in opposite to all allocations in dwc2_gadget_init() the function dwc2_hsotg_ep_alloc_request() uses kzalloc. So in case usb_add_gadget_udc() would fail, the memory of the USB request would be leaked: Linux raspberrypi 4.16.0-rc7-next-20180327+ #2 SMP PREEMPT Sat Mar

[PATCH v3 1/2] net: usb: asix88179_178a: set permanent address once only

2018-04-02 Thread Alexander Kurz
The permanent address of asix88179_178a devices is read at probe time and should not be overwritten later. Otherwise it may be overwritten unintentionally with a configured address. Signed-off-by: Alexander Kurz --- drivers/net/usb/ax88179_178a.c | 1 - 1 file changed, 1

[PATCH v3 2/2] net: usb: asix88179_178a: de-duplicate code

2018-04-02 Thread Alexander Kurz
Remove the duplicated code for asix88179_178a bind and reset methods. Signed-off-by: Alexander Kurz --- drivers/net/usb/ax88179_178a.c | 137 ++--- 1 file changed, 31 insertions(+), 106 deletions(-) diff --git a/drivers/net/usb/ax88179_178a.c

[Question] MFD driver that handles clocks/resets and populates child nodes

2018-04-02 Thread Masahiro Yamada
Hi. Some MFD drivers populate child nodes after some basic hardware setups. My question is, is it acceptable to upstream a MFD driver that handles only clocks/resets, then calls of_platform_populate. The probe function will look like follows: static int uniphier_usb3_glue_probe(struct