Re: [PATCH 07/12] usb: usbtmc: Add ioctl USBTMC488_IOCTL_WAIT_SRQ

2018-05-28 Thread Oliver Neukum
Am Montag, den 28.05.2018, 10:59 + schrieb guido@kiener- muenchen.de: > > No, the problem is that you will underflow io->mutex > > > > Don't worry. The function usbtmc488_ioctl_wait_srq is called by > usbtmc_ioctl which already locks the mutex. See >

Re: [PATCH 02/12] usb: usbtmc: Support Read Status Byte with SRQ per file handle

2018-05-28 Thread Oliver Neukum
Am Donnerstag, den 24.05.2018, 12:31 + schrieb guido@kiener- muenchen.de: > Zitat von Oliver Neukum : > > > Am Montag, den 21.05.2018, 21:00 + schrieb guido@kiener- > > muenchen.de: > > > > > > I looked for a race here, but I do not find a race between open and > > >

Re: Fwd: usb: uas: device reset most the time while enumeration- usb3.0

2018-05-28 Thread Oliver Neukum
Am Donnerstag, den 24.05.2018, 20:13 +0530 schrieb Tushar Nimkar: > We have built SCSI as module will it cause any problem to enable > CONFIG_SCSI_SCAN_ASYNC ? No, that should work. But the failure is bizzare. You say synchronous scanning fails, but async scan works? Regards

Re: [PATCH 2/2] usb: dwc3: of_simple: don't call pm_runtime_set_active()

2018-05-28 Thread Johan Hovold
On Mon, May 28, 2018 at 05:36:14PM +0300, Roger Quadros wrote: > Don't call pm_runtime_set_active() as it will prevent the device > from being activated in the next pm_runtime_get_sync() call. > > Also call pm_runtime_get_sync() before of_platform_populate(). This paragraph describes what you

[PATCH] usb: musb: remove an unused variable

2018-05-28 Thread Arnd Bergmann
After the only users of this variable got removed, we now get a warning about 'otg' being unused: drivers/usb/musb/da8xx.c: In function 'da8xx_musb_interrupt': drivers/usb/musb/da8xx.c:226:19: error: unused variable 'otg' [-Werror=unused-variable] Fixes: d2852f2d3e6d ("usb: musb: remove

[PATCH 2/2] usb: dwc3: of_simple: don't call pm_runtime_set_active()

2018-05-28 Thread Roger Quadros
Don't call pm_runtime_set_active() as it will prevent the device from being activated in the next pm_runtime_get_sync() call. Also call pm_runtime_get_sync() before of_platform_populate(). Signed-off-by: Roger Quadros --- drivers/usb/dwc3/dwc3-of-simple.c | 7 +++ 1 file

[PATCH 1/2] usb: dwc3: of-simple: Don't fail if no clock entries

2018-05-28 Thread Roger Quadros
of_count_phandle_with_args() returns -ENOENT (-2) if there are no clock entries. Don't fail in such a case. Signed-off-by: Roger Quadros --- drivers/usb/dwc3/dwc3-of-simple.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

Re: [PATCH v2 2/3] platform: x86: intel_cht_int33fe: Fix dependencies

2018-05-28 Thread Andy Shevchenko
On Wed, 2018-05-23 at 17:37 +0300, Heikki Krogerus wrote: > The driver will not probe unless bq24190 is loaded, so > making it a dependency. > Acked-by: Andy Shevchenko assuming it will go through some other tree. > Signed-off-by: Heikki Krogerus

Re: [PATCH v5] usb: gadget: udc: renesas_usb3: Add register of usb role switch

2018-05-28 Thread Heikki Krogerus
On Fri, May 25, 2018 at 04:12:56PM +0900, Yoshihiro Shimoda wrote: > @@ -2573,6 +2635,12 @@ static void renesas_usb3_init_ram(struct renesas_usb3 > *usb3, struct device *dev, > EXTCON_NONE, > }; > > +static struct usb_role_switch_desc renesas_usb3_role_switch_desc = { You can constify

Re: [PATCH v5] usb: gadget: udc: renesas_usb3: Add register of usb role switch

2018-05-28 Thread Andy Shevchenko
On Fri, May 25, 2018 at 10:12 AM, Yoshihiro Shimoda wrote: > -static void usb3_set_mode(struct renesas_usb3 *usb3, bool host) Wouldn't be better to choose another name for a new function? > + struct renesas_usb3 *usb3 = container_of(work, struct

Re: [PATCH 07/12] usb: usbtmc: Add ioctl USBTMC488_IOCTL_WAIT_SRQ

2018-05-28 Thread guido
Zitat von Oliver Neukum : Am Donnerstag, den 24.05.2018, 12:59 + schrieb guido@kiener- muenchen.de: Zitat von Oliver Neukum : > Am Donnerstag, den 17.05.2018, 19:03 +0200 schrieb Guido Kiener: > > +static int usbtmc488_ioctl_wait_srq(struct

Re: [PATCH v2 1/3] usb: gadget: ccid: add support for USB CCID Gadget Device

2018-05-28 Thread Andrzej Pietrasiewicz
W dniu 28.05.2018 o 11:32, Marcus Folkesson pisze: > Hi Andrzej, > > Thank you for reviewing. > > On Mon, May 28, 2018 at 11:12:27AM +0200, Andrzej Pietrasiewicz wrote: >> W dniu 28.05.2018 o 10:38, Marcus Folkesson pisze: >>> Hi Andrzej, >>> >>> On Mon, May 28, 2018 at 09:04:51AM +0200, Andrzej

Re: [PATCH v2 1/3] usb: gadget: ccid: add support for USB CCID Gadget Device

2018-05-28 Thread Marcus Folkesson
Hi Andrzej, Thank you for reviewing. On Mon, May 28, 2018 at 11:12:27AM +0200, Andrzej Pietrasiewicz wrote: > W dniu 28.05.2018 o 10:38, Marcus Folkesson pisze: > > Hi Andrzej, > > > > On Mon, May 28, 2018 at 09:04:51AM +0200, Andrzej Pietrasiewicz wrote: > >> Mi Marcus, > >> > >> W dniu

Re: [PATCH v2 1/3] usb: gadget: ccid: add support for USB CCID Gadget Device

2018-05-28 Thread Andrzej Pietrasiewicz
W dniu 28.05.2018 o 10:38, Marcus Folkesson pisze: > Hi Andrzej, > > On Mon, May 28, 2018 at 09:04:51AM +0200, Andrzej Pietrasiewicz wrote: >> Mi Marcus, >> >> W dniu 26.05.2018 o 23:19, Marcus Folkesson pisze: >>> Chip Card Interface Device (CCID) protocol is a USB protocol that >>> allows a

Re: [PATCH] net: qmi_wwan: Add Netgear Aircard 779S

2018-05-28 Thread Bjørn Mork
Josh Hill writes: > Add support for Netgear Aircard 779S > > Signed-off-by: Josh Hill Acked-by: Bjørn Mork Please queue this for stable too. Thanks. Bjørn -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in

Re: [PATCH v2 1/3] usb: gadget: ccid: add support for USB CCID Gadget Device

2018-05-28 Thread Marcus Folkesson
Hi Andrzej, On Mon, May 28, 2018 at 09:04:51AM +0200, Andrzej Pietrasiewicz wrote: > Mi Marcus, > > W dniu 26.05.2018 o 23:19, Marcus Folkesson pisze: > > Chip Card Interface Device (CCID) protocol is a USB protocol that > > allows a smartcard device to be connected to a computer via a card > >

Re: Serdev: USB device and sysdev probing ala i2c

2018-05-28 Thread Johan Hovold
On Fri, May 25, 2018 at 10:17:20AM -0500, Rob Herring wrote: > On Fri, May 25, 2018 at 7:08 AM, Johan Hovold wrote: > > On Thu, May 24, 2018 at 11:49:24AM -0500, Rob Herring wrote: > >> On Thu, May 24, 2018 at 7:18 AM, Ricardo Ribalda Delgado > >>

Re: 4.16 issue with mbim modem and ping with size > 14552 bytes

2018-05-28 Thread Greg KH
On Mon, May 28, 2018 at 09:58:01AM +0200, Daniele Palmas wrote: > 2018-05-25 0:54 GMT+02:00 Daniele Palmas : > > Hi Greg, > > > > 2018-05-24 17:53 GMT+02:00 Greg KH : > >> On Thu, May 24, 2018 at 05:04:49PM +0200, Daniele Palmas wrote: > >>> Hello, >

Re: 4.16 issue with mbim modem and ping with size > 14552 bytes

2018-05-28 Thread Daniele Palmas
2018-05-25 0:54 GMT+02:00 Daniele Palmas : > Hi Greg, > > 2018-05-24 17:53 GMT+02:00 Greg KH : >> On Thu, May 24, 2018 at 05:04:49PM +0200, Daniele Palmas wrote: >>> Hello, >>> >>> I have an issue with an USB mbim modem when trying to send with ping

Re: [PATCH v2 2/3] Documentation: usb: add documentation for USB CCID Gadget Device

2018-05-28 Thread Marcus Folkesson
Hi Randy, On Sun, May 27, 2018 at 04:36:24PM -0700, Randy Dunlap wrote: > Hi, > > I have a few documentation comments below... > > On 05/26/2018 02:19 PM, Marcus Folkesson wrote: > > Add documentation to give a brief description on how to use the > > CCID Gadget Device. > > This includes a

Re: [PATCH v2 1/3] usb: gadget: ccid: add support for USB CCID Gadget Device

2018-05-28 Thread Andrzej Pietrasiewicz
Mi Marcus, W dniu 26.05.2018 o 23:19, Marcus Folkesson pisze: > Chip Card Interface Device (CCID) protocol is a USB protocol that > allows a smartcard device to be connected to a computer via a card > reader using a standard USB interface, without the need for each manufacturer > of smartcards to

[PATCHv2 1/2] usb: hub: Per-port setting to use old enumeration scheme

2018-05-28 Thread Nicolas Boichat
The "old" enumeration scheme is considerably faster (it takes ~244ms instead of ~356ms to get the descriptor). It is currently only possible to use the old scheme globally (/sys/module/usbcore/parameters/old_scheme_first), which is not desirable as the new scheme was introduced to increase

[PATCH] usb: hub: Per-port setting to reduce TRSTRCY to 10 ms

2018-05-28 Thread Nicolas Boichat
Currently, the USB hub core waits for 50 ms after enumerating the device. This was added to help "some high speed devices" to enumerate (b789696af8 "[PATCH] USB: relax usbcore reset timings"). On some devices, the time-to-active is important, so we provide a per-port option to reduce the time to