Re: [PATCH v2] USB: chipidea: Do not hang when CONFIG_USB_CHIPIDEA_ULPI is not selected

2018-07-02 Thread Shawn Guo
On Mon, Jul 02, 2018 at 11:22:55PM -0300, Fabio Estevam wrote: > Hi Shawn, > > On Mon, Jul 2, 2018 at 11:06 PM, Shawn Guo wrote: > > > A second thought on this - shouldn't such dependency be solved by > > Kconfig select clause? > > I suspect we are not able to fix it via Kconfig as we really

Re: [PATCH v2] USB: chipidea: Do not hang when CONFIG_USB_CHIPIDEA_ULPI is not selected

2018-07-02 Thread Fabio Estevam
Hi Shawn, On Mon, Jul 2, 2018 at 11:06 PM, Shawn Guo wrote: > A second thought on this - shouldn't such dependency be solved by > Kconfig select clause? I suspect we are not able to fix it via Kconfig as we really don't know if a system uses ULPI interface or not via Kconfig perspective. If

Re: [PATCH v2] USB: chipidea: Do not hang when CONFIG_USB_CHIPIDEA_ULPI is not selected

2018-07-02 Thread Shawn Guo
On Mon, Jun 25, 2018 at 11:25:12AM -0300, Fabio Estevam wrote: > From: Fabio Estevam > > Since commit 03e6275ae381087bd8 ("usb: chipidea: Fix ULPI on imx51") the > kernel hangs on a imx51-babbage board, when using the ULPI interface with > the CONFIG_USB_CHIPIDEA_ULPI option unselected. > >

Re: [PATCH v2] USB: chipidea: Do not hang when CONFIG_USB_CHIPIDEA_ULPI is not selected

2018-07-02 Thread Fabio Estevam
On Mon, Jul 2, 2018 at 10:48 PM, Shawn Guo wrote: > I will make sure both defconfig patches go into 4.18-rc. Thanks, Shawn! Peter, Could you please then queue this chipidea patch for 4.18-rc? Thanks -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a

Re: [PATCH v2] USB: chipidea: Do not hang when CONFIG_USB_CHIPIDEA_ULPI is not selected

2018-07-02 Thread Shawn Guo
On Mon, Jul 02, 2018 at 08:52:34AM -0300, Fabio Estevam wrote: > Hi Peter, > > On Mon, Jul 2, 2018 at 12:08 AM, Peter Chen wrote: > > > Fabio, since this function has dependency with defconfig, is the defconfig > > change a fix for v4.18-rc > > or for v4.19-rc1? > > I have sent the defconfig

[PATCH 1/3] usb: gadget: configfs: Create control_config group

2018-07-02 Thread Jerry Zhang
Control_config is a group under gadget that acts as a normal config group, except it does not appear in cdev->configs. Functions that have exactly zero descriptors can be linked into control_config. These functions are bound and unbound with the rest of the gadget, but are never enabled. Also,

[PATCH 2/3] usb: gadget: f_fs: Add FUNCTIONFS_CONTROL_ONLY flag

2018-07-02 Thread Jerry Zhang
This flag allows users to directly specify when they want a ffs instance to be used for handling control requests only via the configfs control_config/ group. When the flag is set, user must set *none* of the speed descriptor flags and provide no speeds in the descriptor. This ensures that it

[PATCH 3/3] Documentation: usb: Add docs for configfs control requests

2018-07-02 Thread Jerry Zhang
Signed-off-by: Jerry Zhang --- Documentation/usb/gadget_configfs.txt | 34 +++ 1 file changed, 34 insertions(+) diff --git a/Documentation/usb/gadget_configfs.txt b/Documentation/usb/gadget_configfs.txt index b8cb38a98c19..64f69dd3f123 100644 ---

[PATCH 0/3] Handle custom control requests in userspace

2018-07-02 Thread Jerry Zhang
Vendor specific control requests are a significant category of USB communications. With the current framework, it is difficult for a composite gadget to handle these requests since any function could be active. This patchset/feature allows all unhandled control requests to be passed to a singular

Re: MUSB issue

2018-07-02 Thread Alan Stern
On Mon, 2 Jul 2018, Laurent Pinchart wrote: > Hi Alan, > > On Monday, 2 July 2018 18:13:27 EEST Alan Stern wrote: > > On Mon, 2 Jul 2018, Paul Elder wrote: > > > Hello Felipe, > > > > > > We have discovered an issue in MUSB gadget when receiving control OUT > > > transfers. I have specifically

[PATCH] usb: gadget: f_fs: Only return delayed status when len is 0

2018-07-02 Thread Jerry Zhang
Commit 1b9ba000 ("Allow function drivers to pause control transfers") states that USB_GADGET_DELAYED_STATUS is only supported if data phase is 0 bytes. It seems that when the length is not 0 bytes, there is no need to explicitly delay the data stage since the transfer is not completed until the

Re: MUSB issue

2018-07-02 Thread Laurent Pinchart
Hi Alan, On Monday, 2 July 2018 18:13:27 EEST Alan Stern wrote: > On Mon, 2 Jul 2018, Paul Elder wrote: > > Hello Felipe, > > > > We have discovered an issue in MUSB gadget when receiving control OUT > > transfers. I have specifically observed it very frequently on the second > > SET_CUR UVC

[PATCH] usb: quirks: add delay quirks for Corsair Strafe

2018-07-02 Thread Nico Sneck
Corsair Strafe appears to suffer from the same issues as the Corsair Strafe RGB. Apply the same quirks (control message delay and init delay) that the RGB version has to 1b1c:1b15. With these quirks in place the keyboard works correctly upon booting the system, and no longer requires reattaching

Re: [usb:usb-next 36/38] drivers/usb/typec/tcpci.c:549: undefined reference to `__devm_regmap_init_i2c'

2018-07-02 Thread Greg Kroah-Hartman
On Fri, Jun 29, 2018 at 03:42:02PM -0700, Guenter Roeck wrote: > On Fri, Jun 29, 2018 at 12:52:34PM +0800, kbuild test robot wrote: > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git > > usb-next > > head: aaf3f4e925dc2bdc4715142103660285632a245c > > commit:

Re: documenting that transfer_buffer can be NULL if transfer_buffer_length is 0

2018-07-02 Thread Alan Stern
On Mon, 2 Jul 2018, Oliver Neukum wrote: > Hi, > > I am getting coverity reports because usbnet checks for zero length > transfers before it allocates buffers. Is the assumption that no > buffer is needed actually correct for every HCD and should I document > this? What reason could there be

Re: MUSB issue

2018-07-02 Thread Alan Stern
On Mon, 2 Jul 2018, Paul Elder wrote: > Hello Felipe, > > We have discovered an issue in MUSB gadget when receiving control OUT > transfers. I have specifically observed it very frequently on the second > SET_CUR UVC request when trying to stream video with yavta from a UVC > gadget. > > What

[PATCH 1/1] usb: xhci: dbc: Don't decrement runtime PM counter if DBC is not started

2018-07-02 Thread Mathias Nyman
From: Kai-Heng Feng pm_runtime_put_sync() gets called everytime in xhci_dbc_stop(). If dbc is not started, this makes the runtime PM counter incorrectly becomes 0, and calls autosuspend function. Then we'll keep seeing this: [54664.762220] xhci_hcd :00:14.0: Root hub is not suspended So

Re: [PATCH 0/1] xhci fix for usb-linus

2018-07-02 Thread Greg KH
On Mon, Jul 02, 2018 at 04:14:10PM +0300, Mathias Nyman wrote: > Hi Greg > > A small fix for usb-linus making sure runtime PM get/put is balanced > > -Mathias > > Kai-Heng Feng (1): > usb: xhci: dbc: Don't decrement runtime PM counter if DBC is not > started > >

[PATCH 0/1] xhci fix for usb-linus

2018-07-02 Thread Mathias Nyman
Hi Greg A small fix for usb-linus making sure runtime PM get/put is balanced -Mathias Kai-Heng Feng (1): usb: xhci: dbc: Don't decrement runtime PM counter if DBC is not started drivers/usb/host/xhci-dbgcap.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) -- 2.7.4

Re: [PATCH v2] USB: chipidea: Do not hang when CONFIG_USB_CHIPIDEA_ULPI is not selected

2018-07-02 Thread Fabio Estevam
Hi Peter, On Mon, Jul 2, 2018 at 12:08 AM, Peter Chen wrote: > Fabio, since this function has dependency with defconfig, is the defconfig > change a fix for v4.18-rc > or for v4.19-rc1? I have sent the defconfig changes for imx_v6_v7_defconfig and imx_v4_v5_defconfig and hope that they could

RE: [PATCH 4.18 REGRESSION fix 2/2] i2c-cht-wc: Fix bq24190 supplier

2018-07-02 Thread Adam Thomson
On 02 July 2018 11:51, Hans de Goede wrote: > Hi, > > On 02-07-18 12:34, Adam Thomson wrote: > > On 01 July 2018 10:49, Hans de Goede wrote: > > > >> Commit f2a8aa053c17 ("typec: tcpm: Represent source supply through > >> power_supply") moved the code to register a power_supply representing > >>

Re: [PATCH 4.18 REGRESSION fix 2/2] i2c-cht-wc: Fix bq24190 supplier

2018-07-02 Thread Hans de Goede
Hi, On 02-07-18 12:34, Adam Thomson wrote: On 01 July 2018 10:49, Hans de Goede wrote: Commit f2a8aa053c17 ("typec: tcpm: Represent source supply through power_supply") moved the code to register a power_supply representing the device supplying power to the type-C connector, from the fusb302

Re: [PATCH 4.18 REGRESSION fix 1/2] typec: tcpm: Correctly report power_supply current and voltage for non pd supply

2018-07-02 Thread Hans de Goede
Hi, On 02-07-18 12:28, Adam Thomson wrote: On 01 July 2018 10:49, Hans de Goede wrote: Commit f2a8aa053c17 ("typec: tcpm: Represent source supply through power_supply") moved the code to register a power_supply representing the device supplying power to the type-C connector, from the fusb302

RE: [PATCH 4.18 REGRESSION fix 2/2] i2c-cht-wc: Fix bq24190 supplier

2018-07-02 Thread Adam Thomson
On 01 July 2018 10:49, Hans de Goede wrote: > Commit f2a8aa053c17 ("typec: tcpm: Represent source supply through > power_supply") moved the code to register a power_supply representing > the device supplying power to the type-C connector, from the fusb302 > code to the generic tcpm code. > >

RE: [PATCH 4.18 REGRESSION fix 1/2] typec: tcpm: Correctly report power_supply current and voltage for non pd supply

2018-07-02 Thread Adam Thomson
On 01 July 2018 10:49, Hans de Goede wrote: > Commit f2a8aa053c17 ("typec: tcpm: Represent source supply through > power_supply") moved the code to register a power_supply representing > the device supplying power to the type-C connector, from the fusb302 > code to the generic tcpm code so that

documenting that transfer_buffer can be NULL if transfer_buffer_length is 0

2018-07-02 Thread Oliver Neukum
Hi, I am getting coverity reports because usbnet checks for zero length transfers before it allocates buffers. Is the assumption that no buffer is needed actually correct for every HCD and should I document this? Regards Oliver -- To unsubscribe from this list: send the

MUSB issue

2018-07-02 Thread Paul Elder
Hello Felipe, We have discovered an issue in MUSB gadget when receiving control OUT transfers. I have specifically observed it very frequently on the second SET_CUR UVC request when trying to stream video with yavta from a UVC gadget. What happens is that in the DATA phase, the controller copies

Re: usb: dwc2: crash regression in commit 3bc04e28a030 (bisected)

2018-07-02 Thread Antti Seppälä
On 30 June 2018 at 02:57, Doug Anderson wrote: > Hi, > > On Fri, Jun 29, 2018 at 11:29 AM, Antti Seppälä wrote: >> Hi Doug, John and linux-usb. >> >> I'd like to report a regression in commit 3bc04e28a030 (usb: dwc2: >> host: Get aligned DMA in a more supported way) > > Seems unlikely, but any

Re: USB Gadget driver for USB screen?

2018-07-02 Thread Clemens Ladisch
Sebastian Nielsen wrote: > Does anyone know of a USB Gadget kernel driver for a USB screen? There is no standardized device class for USB-to-VGA devices. > So I can have a linux USB gadget emulate as a USB screen to the host PC, and > aquire it's picture as a picture stream? You could try