Re: wrong device idProduct?

2018-07-30 Thread Alan Stern
On Mon, 30 Jul 2018, Nick Desaulniers wrote: > Hello, > Today my usb keyboard stopped working: > > [513672.838235] usbhid 3-10.1:1.0: couldn't find an input interrupt endpoint > > I happen to have two models of the same keyboard (Das Keyboard > Ultimate 4C), from the working one: > [

wrong device idProduct?

2018-07-30 Thread Nick Desaulniers
Hello, Today my usb keyboard stopped working: [513672.838235] usbhid 3-10.1:1.0: couldn't find an input interrupt endpoint I happen to have two models of the same keyboard (Das Keyboard Ultimate 4C), from the working one: [ 37.865738] usb 1-1.1: New USB device found, idVendor=24f0,

Re: [PATCH v4 00/22] usb: usbtmc: Changes needed for compatible IVI/VISA library

2018-07-30 Thread guido
Zitat von Greg KH : On Mon, Jul 30, 2018 at 10:04:30AM +0200, Guido Kiener wrote: The working group "VISA for Linux" of the IVI Foundation www.ivifoundation.org specifies common rules, shared libraries and drivers to implement the specification of "VPP-4.3: The VISA Library" on Linux to be

Re: [PATCH v4 00/22] usb: usbtmc: Changes needed for compatible IVI/VISA library

2018-07-30 Thread Greg KH
On Mon, Jul 30, 2018 at 10:04:30AM +0200, Guido Kiener wrote: > The working group "VISA for Linux" of the IVI Foundation > www.ivifoundation.org specifies common rules, shared libraries and > drivers to implement the specification of "VPP-4.3: The VISA Library" > on Linux to be compatible with

broken TRIM support for JMS578 in uas mode

2018-07-30 Thread Mailing Lists
I cannot issue TRIM commands to SSD behind a JMS578-based sata to usb-c adapter. Tried with Fedora 28 kernel and with latest 4.18.0-0.rc6.git0.1.vanilla.knurd.1.fc28.x86_64 lsblk -D shows that discard is not enabled, but the SSD has this capability (see below) However Windows 10 successfully

Re: dwc2: scatter-gather support?

2018-07-30 Thread Minas Harutyunyan
Hi Stefan, On 7/29/2018 12:33 PM, Stefan Wahren wrote: > Hi, > > if i connect a UAS capable storage device to the Raspberry Pi, i'm getting > the following output on 4.18rc: > > The driver for the USB controller dwc2_hsotg does not support > scatter-gather which is > required

Re: [GIT PULL] USB changes for v4.19

2018-07-30 Thread Greg Kroah-Hartman
On Mon, Jul 30, 2018 at 10:53:52AM +0300, Felipe Balbi wrote: > > Hi Greg, > > here's my pull request for v4.19. It's not very large this time around > with only 37 commits. Patches have been soaking for a while without any > reported incidents. > > Let me know if you want anything to be

[PATCH] usb: renesas_usbhs: Kconfig: convert to SPDX identifiers

2018-07-30 Thread Kuninori Morimoto
From: Kuninori Morimoto By default all files without license information are under the default license of the kernel, which is GPL version 2. Signed-off-by: Kuninori Morimoto --- drivers/usb/renesas_usbhs/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git

[GIT PULL] USB changes for v4.19

2018-07-30 Thread Felipe Balbi
Hi Greg, here's my pull request for v4.19. It's not very large this time around with only 37 commits. Patches have been soaking for a while without any reported incidents. Let me know if you want anything to be changed. Cheers The following changes since commit

[PATCH v4 22/22] usb: usbtmc: Remove sysfs group TermChar and auto_abort

2018-07-30 Thread Guido Kiener
As all the properties of the usbtmc driver can now be controlled on a per file descriptor basis by ioctl functions the sysfs interface is of limited use. We are not aware about applications that are using the sysfs parameter TermChar, TermCharEnabled or auto_abort. Signed-off-by: Guido Kiener

[PATCH v4 18/22] usb: usbtmc: Update ioctl-number.txt

2018-07-30 Thread Guido Kiener
Reserve a suitable range of ioctl numbers for USBTMC driver. Signed-off-by: Guido Kiener Reviewed-by: Steve Bayless --- Documentation/ioctl/ioctl-number.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/ioctl/ioctl-number.txt

[PATCH v4 21/22] usb: usbtmc: Fix split quoted string in debug message

2018-07-30 Thread Guido Kiener
Signed-off-by: Guido Kiener Reviewed-by: Steve Bayless --- drivers/usb/class/usbtmc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/class/usbtmc.c b/drivers/usb/class/usbtmc.c index 785eee3a6b89..6aef3447adcc 100644 --- a/drivers/usb/class/usbtmc.c +++

[PATCH v4 13/22] usb: usbtmc: Fix ioctl USBTMC_IOCTL_CLEAR

2018-07-30 Thread Guido Kiener
Remove calculation of max_size (=wMaxPacketSize) and wrong condition (actual == max_size) in while loop. A device clear should always flush the complete Bulk-IN FIFO. Insert a sleep of 50 ms between subsequent CHECK_CLEAR_STATUS control requests to avoid stressing the instrument with repeated

[PATCH v4 16/22] usb: usbtmc: Replace USBTMC_TIMEOUT macros for control messages

2018-07-30 Thread Guido Kiener
Use common timeout macro USB_CTRL_GET_TIMEOUT (=5s) for all usb_control_msg() function calls. The macro USBTMC_TIMEOUT should only be used as default value for Bulk IN/OUT transfers. Signed-off-by: Guido Kiener Reviewed-by: Steve Bayless --- drivers/usb/class/usbtmc.c | 8 1 file

[PATCH v4 11/22] usb: usbtmc: Optimize usbtmc_write

2018-07-30 Thread Guido Kiener
Use new usbtmc_generic_write function to maximize bandwidth during long data transfer. The maximum output transfer size is limited to INT_MAX (=2GB). Signed-off-by: Guido Kiener Reviewed-by: Steve Bayless --- drivers/usb/class/usbtmc.c | 176 +++-- 1 file

[PATCH v4 19/22] usb: usbtmc: Remove redundant code

2018-07-30 Thread Guido Kiener
Remove redundant code and fix debug messages. Signed-off-by: Guido Kiener Reviewed-by: Steve Bayless --- drivers/usb/class/usbtmc.c | 25 - 1 file changed, 8 insertions(+), 17 deletions(-) diff --git a/drivers/usb/class/usbtmc.c b/drivers/usb/class/usbtmc.c index

[PATCH v4 15/22] usb: usbtmc: Fix ioctl USBTMC_IOCTL_ABORT_BULK_OUT

2018-07-30 Thread Guido Kiener
Add parameter 'tag' to function usbtmc_ioctl_abort_bulk_out_tag() for future versions. Use USBTMC_BUFSIZE (4k) instead of USBTMC_SIZE_IOBUFFER (2k). Using USBTMC_SIZE_IOBUFFER is deprecated. Insert a sleep of 50 ms between subsequent CHECK_ABORT_BULK_OUT_STATUS control requests to avoid

[PATCH v4 12/22] usb: usbtmc: Optimize usbtmc_read

2018-07-30 Thread Guido Kiener
Use new usbtmc_generic_read function to maximize bandwidth during long data transfer. Also fix reading of zero length packet (ZLP) or trailing short packet. The maximum input transfer size is limited to INT_MAX (=2GB). Also remove redundant return in send_request_dev_dep_msg_in(). Signed-off-by:

[PATCH v4 17/22] usb: usbtmc: Add ioctl USBTMC_IOCTL_API_VERSION

2018-07-30 Thread Guido Kiener
Add ioctl USBTMC_IOCTL_API_VERSION to get current API version of usbtmc driver. This is to allow an instrument library to determine whether the driver API is compatible with the implementation. The API may change in future versions. Therefore the macro USBTMC_API_VERSION should be incremented

[PATCH v4 20/22] usb: usbtmc: Remove redundant macro USBTMC_SIZE_IOBUFFER

2018-07-30 Thread Guido Kiener
Signed-off-by: Guido Kiener Reviewed-by: Steve Bayless --- drivers/usb/class/usbtmc.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/usb/class/usbtmc.c b/drivers/usb/class/usbtmc.c index 81144c0c4772..785eee3a6b89 100644 --- a/drivers/usb/class/usbtmc.c +++

[PATCH v4 14/22] usb: usbtmc: Fix ioctl USBTMC_IOCTL_ABORT_BULK_IN

2018-07-30 Thread Guido Kiener
Add parameter 'tag' to function usbtmc_ioctl_abort_bulk_in_tag() for future versions. Remove calculation of max_size (=wMaxPacketSize) and wrong condition (actual == max_size) in while loop. An abort operation should always flush the complete Bulk-IN until a short packet is received. Return

[PATCH v4 01/22] usb: usbtmc: Add ioctl for generic requests on control

2018-07-30 Thread Guido Kiener
Add USBTMC_IOCTL_CTRL_REQUEST to send arbitrary requests on the control pipe. Used by specific applications of IVI Foundation, Inc. to implement VISA API functions: viUsbControlIn/Out. The maximum length of control request is set to 4k. Signed-off-by: Guido Kiener Reviewed-by: Steve Bayless

[PATCH v4 10/22] usb: usbtmc: Add ioctl USBTMC_IOCTL_AUTO_ABORT

2018-07-30 Thread Guido Kiener
Add ioctl USBTMC_IOCTL_AUTO_ABORT to configure auto_abort for each specific file handle. Signed-off-by: Guido Kiener Reviewed-by: Steve Bayless --- drivers/usb/class/usbtmc.c | 23 --- include/uapi/linux/usb/tmc.h | 1 + 2 files changed, 17 insertions(+), 7 deletions(-)

[PATCH v4 02/22] usb: usbtmc: Add ioctl for vendor specific write

2018-07-30 Thread Guido Kiener
The new ioctl USBTMC_IOCTL_WRITE sends a generic message to bulk OUT. This ioctl is used for vendor specific or asynchronous I/O as well. The message is split into chunks of 4k (page size). Message size is aligned to 32 bit boundaries. With flag USBTMC_FLAG_ASYNC the ioctl is non blocking. With

[PATCH v4 08/22] usb: usbtmc: Add ioctl USBTMC488_IOCTL_WAIT_SRQ

2018-07-30 Thread Guido Kiener
Wait until an SRQ (service request) is received on the interrupt pipe or until the given period of time is expired. In contrast to the poll() function this ioctl does not return when other (a)synchronous I/O operations fail with EPOLLERR. Signed-off-by: Guido Kiener Reviewed-by: Steve Bayless

[PATCH v4 09/22] usb: usbtmc: add ioctl USBTMC_IOCTL_MSG_IN_ATTR

2018-07-30 Thread Guido Kiener
add ioctl USBTMC_IOCTL_MSG_IN_ATTR that returns the specific bmTransferAttributes field of the last DEV_DEP_MSG_IN Bulk-IN header. This header is received by the read() function. The meaning of the (u8) bitmap bmTransferAttributes is: Bit 0 = EOM flag is set when the last transfer of a USBTMC

[PATCH v4 03/22] usb: usbtmc: Add ioctl USBTMC_IOCTL_WRITE_RESULT

2018-07-30 Thread Guido Kiener
ioctl USBTMC_IOCTL_WRITE_RESULT copies current out_transfer_size to given __u32 pointer and returns current out_status of the last (asnynchronous) USBTMC_IOCTL_WRITE call. Signed-off-by: Guido Kiener Reviewed-by: Steve Bayless --- drivers/usb/class/usbtmc.c | 25 +

[PATCH v4 07/22] usb: usbtmc: Fix suspend/resume

2018-07-30 Thread Guido Kiener
Submitted urbs are not allowed when system is suspended. Thus the submitted urb waiting at interrupt pipe is killed during suspend callback and submitted again when system resumes. Signed-off-by: Guido Kiener Reviewed-by: Steve Bayless --- drivers/usb/class/usbtmc.c | 16 +++- 1

[PATCH v4 06/22] usb: usbtmc: Add ioctl USBTMC_IOCTL_CLEANUP_IO

2018-07-30 Thread Guido Kiener
The ioctl USBTMC_IOCTL_CLEANUP_IO kills all submitted urbs to OUT and IN bulk, and clears all received data from IN bulk. Internal transfer counters and error states are reset. An application should use this ioctl after an asnychronous transfer was canceled and/or error handling has finished.

[PATCH v4 04/22] usb: usbtmc: Add ioctl for vendor specific read

2018-07-30 Thread Guido Kiener
The USBTMC_IOCTL_READ call provides for generic synchronous and asynchronous reads on bulk IN to implement vendor specific library routines. Depending on transfer_size the function submits one or more urbs (up to 16) each with a size of up to 4kB. The flag USBTMC_FLAG_IGNORE_TRAILER can be used

[PATCH v4 00/22] usb: usbtmc: Changes needed for compatible IVI/VISA library

2018-07-30 Thread Guido Kiener
The working group "VISA for Linux" of the IVI Foundation www.ivifoundation.org specifies common rules, shared libraries and drivers to implement the specification of "VPP-4.3: The VISA Library" on Linux to be compatible with implementations on other operating systems. The USBTMC protocol is part

[PATCH v4 05/22] usb: usbtmc: Add ioctl USBTMC_IOCTL_CANCEL_IO

2018-07-30 Thread Guido Kiener
ioctl USBTMC_IOCTL_CANCEL_IO stops and kills all flying urbs of last USBTMC_IOCTL_READ and USBTMC_IOCTL_WRITE function calls. A subsequent call to USBTMC_IOCTL_READ or USBTMC_IOCTL_WRITE_RESULT returns -ECANCELED with information about current transferred data. Signed-off-by: Guido Kiener

Re: [PATCH 3/3] usb: dwc3: gadget: Return correct actual bytes written

2018-07-30 Thread Felipe Balbi
Hi, Thinh Nguyen writes: > For OUT transfers, the total size (total TRB buffer allocation) must be > a multiple of MaxPacketSize even if software is expecting a fixed > non-multiple of MaxPacketSize transfer from the host. this is the same for dwc3.0 and we already account for that. >

Re: [PATCH 2/3] usb: dwc3: gadget: Don't skip updating remaining data

2018-07-30 Thread Felipe Balbi
Hi, Thinh Nguyen writes: > DWC3 must check for the BUFSIZ and update the req->remaining > regardless of transfer alignment. Returning early from transfer OUT > unalignment will skip updating the req->remaining. > > Fixes: c6267a51639b ("usb: dwc3: gadget: align transfers to wMaxPacketSize") >