[PATCH] Add quirk to support DJI CineSSD

2018-08-09 Thread Tim Anderson
This device does not correctly handle the LPM operations. Also, the device cannot handle ATA pass-through commands and locks up when attempted while running in super speed. This patch adds the equivalent quirk logic as found in uas. Signed-off-by: Tim Anderson --- drivers/usb/core/quirks.c

Re: [PATCH] usbip: Fix misuse of strncpy()

2018-08-09 Thread Shuah Khan
On 07/26/2018 04:39 AM, Ben Hutchings wrote: > On Tue, 2018-07-24 at 11:04 -0600, Shuah Khan wrote: >> On 07/20/2018 08:12 PM, Ben Hutchings wrote: >>> gcc 8 reports: >>> >>> usbip_device_driver.c: In function ‘read_usb_vudc_device’: >>> usbip_device_driver.c:106:2: error: ‘strncpy’ specified

Re: [PATCH v2 1/2] usb storage: group dependent USB storage Kconfig entries together

2018-08-09 Thread Alan Stern
On Thu, 9 Aug 2018, Vladimir Zapolskiy wrote: > Instead of explicit setting of USB_STORAGE dependency for every > underlying build entries, exploit if USB_STORAGE / endif block. > > The change is a trivial non-functional cleanup, it shortens > the Kconfig file and it is expected to reduce zconf

[PATCH v2 1/2] usb storage: group dependent USB storage Kconfig entries together

2018-08-09 Thread Vladimir Zapolskiy
Instead of explicit setting of USB_STORAGE dependency for every underlying build entries, exploit if USB_STORAGE / endif block. The change is a trivial non-functional cleanup, it shortens the Kconfig file and it is expected to reduce zconf parser workload a little. Dependencies of USB_UAS build

[PATCH v2 2/2] usb storage: remove inherited SCSI dependency for USB_STORAGE_ENE_UB6250

2018-08-09 Thread Vladimir Zapolskiy
Because USB_STORAGE build symbol strictly depends on SCSI build symbol, there is no need to specify it again. In addition USB_STORAGE_ENE_UB6250 entry description repeats a note about SCSI dependency from the parent USB_STORAGE entry description, hence the change removes this duplication.

Re: [PATCH 1/2] usb storage: group dependent USB storage Kconfig entries together

2018-08-09 Thread Vladimir Zapolskiy
Hi Alan, thank you for review. On 08/09/2018 05:01 PM, Alan Stern wrote: > On Thu, 9 Aug 2018, Vladimir Zapolskiy wrote: > >> Instead of explicit setting of USB_STORAGE dependency for every >> underlying build entries, exploit if USB_STORAGE / endif block. >> >> Signed-off-by: Vladimir

linux-next build broken for renesas-usb3?

2018-08-09 Thread John Garry
Hi all, I am finding the following build error on today's next build: MODPOST 395 modules ERROR: "usb_of_get_companion_dev" [drivers/usb/gadget/udc/renesas_usb3.ko] undefined! make[1]: *** [__modpost] Error 1 make: *** [modules] Error 2 I was using arm64 defconfig, but disabled some

[PATCH] usb: uas: add support for more quirk flags

2018-08-09 Thread Oliver Neukum
The hope that UAS devices would be less broken than old style storage devices has turned out to be unfounded. Make UAS support more of the quirk flags of the old driver. Signed-off-by: Oliver Neukum --- drivers/usb/storage/uas.c | 21 + 1 file changed, 21 insertions(+) diff

Re: Should usb_gadget_disconnect() call driver's ->disconnect?

2018-08-09 Thread Alan Stern
On Thu, 9 Aug 2018, Felipe Balbi wrote: > > Hi, > > Alan Stern writes: > >> Alan Stern writes: > >> > Felipe: > >> > > >> > The documentation doesn't state whether a gadget driver's > >> > ->disconnect() callback will be invoked when usb_gadget_disconnect() > >> > runs. Probably the UDC

Re: [PATCH 1/2] usb storage: group dependent USB storage Kconfig entries together

2018-08-09 Thread Alan Stern
On Thu, 9 Aug 2018, Vladimir Zapolskiy wrote: > Instead of explicit setting of USB_STORAGE dependency for every > underlying build entries, exploit if USB_STORAGE / endif block. > > Signed-off-by: Vladimir Zapolskiy I think this is a worthwhile cleanup, although to make Greg happy you should

Re: broken TRIM support for JMS578 in uas mode

2018-08-09 Thread Oliver Neukum
On Mo, 2018-07-30 at 14:43 +0300, Mailing Lists wrote: > I cannot issue TRIM commands to SSD behind a JMS578-based sata to > usb-c adapter. Tried with Fedora 28 kernel and with latest > 4.18.0-0.rc6.git0.1.vanilla.knurd.1.fc28.x86_64 > lsblk -D shows that discard is not enabled, but the SSD has

Re: Should usb_gadget_disconnect() call driver's ->disconnect?

2018-08-09 Thread Felipe Balbi
Hi, Alan Stern writes: >> Alan Stern writes: >> > Felipe: >> > >> > The documentation doesn't state whether a gadget driver's >> > ->disconnect() callback will be invoked when usb_gadget_disconnect() >> > runs. Probably the UDC drivers' behavior has changed over the years. >> > >> > In any

Re: [PATCH] WORLDE Controller KS49 or Prodipe MIDI 49C USB controller

2018-08-09 Thread Maxence Duprès
Wonderful, I'm happy to make a little contribution. I have so much to learn on Linux. Thanks you! Le 09/08/2018 à 11:28, Greg KH a écrit : > On Wed, Aug 08, 2018 at 11:56:33PM +, Maxence Duprès wrote: >> WORLDE Controller KS49 or Prodipe MIDI 49C USB controller >> cause a -EPROTO error,

Re: [PATCH 2/2] usb storage: remove inherited SCSI dependency for USB_STORAGE subentries

2018-08-09 Thread Oliver Neukum
On Do, 2018-08-09 at 11:21 +0200, Greg Kroah-Hartman wrote: > On Thu, Aug 09, 2018 at 09:38:40AM +0200, Oliver Neukum wrote: > > On Do, 2018-08-09 at 01:01 +0300, Vladimir Zapolskiy wrote: > > > Because USB_STORAGE build symbol strictly depends on SCSI build > > > symbol, there is no need to

Re: [PATCH] WORLDE Controller KS49 or Prodipe MIDI 49C USB controller

2018-08-09 Thread Greg KH
On Wed, Aug 08, 2018 at 11:56:33PM +, Maxence Duprès wrote: > WORLDE Controller KS49 or Prodipe MIDI 49C USB controller > cause a -EPROTO error, a communication restart and loop again. > > This issue has already been fixed for KS25. > https://lore.kernel.org/patchwork/patch/753077/ > > I

Re: [PATCH 2/2] usb storage: remove inherited SCSI dependency for USB_STORAGE subentries

2018-08-09 Thread Greg Kroah-Hartman
On Thu, Aug 09, 2018 at 09:38:40AM +0200, Oliver Neukum wrote: > On Do, 2018-08-09 at 01:01 +0300, Vladimir Zapolskiy wrote: > > Because USB_STORAGE build symbol strictly depends on SCSI build > > symbol, there is no need to specify it again for USB_UAS and > > USB_STORAGE_ENE_UB6250 build

Re: [PATCH 1/2] usb storage: group dependent USB storage Kconfig entries together

2018-08-09 Thread Greg Kroah-Hartman
On Thu, Aug 09, 2018 at 01:01:54AM +0300, Vladimir Zapolskiy wrote: > Instead of explicit setting of USB_STORAGE dependency for every > underlying build entries, exploit if USB_STORAGE / endif block. Why change this? What benifit does this provide? thanks, greg k-h -- To unsubscribe from this

Re: [PATCH 2/2] usb storage: remove inherited SCSI dependency for USB_STORAGE subentries

2018-08-09 Thread Oliver Neukum
On Do, 2018-08-09 at 10:50 +0300, Vladimir Zapolskiy wrote: > Hi Oliver, > > On 08/09/2018 10:38 AM, Oliver Neukum wrote: > > On Do, 2018-08-09 at 01:01 +0300, Vladimir Zapolskiy wrote: > > > Because USB_STORAGE build symbol strictly depends on SCSI build > > > symbol, there is no need to specify

Re: [PATCH 2/2] usb storage: remove inherited SCSI dependency for USB_STORAGE subentries

2018-08-09 Thread Vladimir Zapolskiy
Hi Oliver, On 08/09/2018 10:38 AM, Oliver Neukum wrote: > On Do, 2018-08-09 at 01:01 +0300, Vladimir Zapolskiy wrote: >> Because USB_STORAGE build symbol strictly depends on SCSI build >> symbol, there is no need to specify it again for USB_UAS and >> USB_STORAGE_ENE_UB6250 build options. > >

Re: [PATCH 2/2] usb storage: remove inherited SCSI dependency for USB_STORAGE subentries

2018-08-09 Thread Oliver Neukum
On Do, 2018-08-09 at 01:01 +0300, Vladimir Zapolskiy wrote: > Because USB_STORAGE build symbol strictly depends on SCSI build > symbol, there is no need to specify it again for USB_UAS and > USB_STORAGE_ENE_UB6250 build options. [..] > config USB_UAS > tristate "USB Attached SCSI" > -