On Thu, Aug 16, 2018 at 01:28:54AM -0700, Patong Yang wrote:
> On Thu, Aug 16, 2018 at 08:34:47AM +0200, Greg KH wrote:
> > On Wed, Aug 15, 2018 at 10:56:47PM -0700, Patong Yang wrote:
> > > Greg,
> > >
> > > Please see my response inline below.
> > >
> > > Patong
> > >
> > > > But there is a
On Do, 2018-08-16 at 01:28 -0700, Patong Yang wrote:
> Features not supported by the cdc-acm driver are
> enabling/disabling flow control, enabling/disabling RS-485 mode,
> GPIOs and GPIO modes, etc. Support for these features had to be added in this
> new driver.
Hi,
I am afraid RS-485 in
On Thu, Aug 16, 2018 at 08:34:47AM +0200, Greg KH wrote:
> On Wed, Aug 15, 2018 at 10:56:47PM -0700, Patong Yang wrote:
> > Greg,
> >
> > Please see my response inline below.
> >
> > Patong
> >
> > > But there is a bigger problem here:
> > >
> > > > + xrusb_tty_driver =
On Thu, 2018-08-16 at 04:15 +0200, Jann Horn wrote:
> On Wed, Aug 15, 2018 at 10:44 PM Ben Hutchings
> wrote:
[...]
> > @@ -446,6 +446,7 @@ static ssize_t yurex_write(struct file *file, const
> > char __user *user_buffer,
> > retval = -EFAULT;
> > goto error;
> >
On Wed, Aug 15, 2018 at 10:56:47PM -0700, Patong Yang wrote:
> Greg,
>
> Please see my response inline below.
>
> Patong
>
> > But there is a bigger problem here:
> >
> > > + xrusb_tty_driver = alloc_tty_driver(XRUSB_TTY_MINORS);
> > > + if (!xrusb_tty_driver)
> > > + return -ENOMEM;
>
