Re: [PATCH 2/4] usb: dwc3: gadget: check if dep->frame_number is still valid

2018-08-20 Thread Thinh Nguyen
Hi Felipe, On 8/20/2018 3:34 AM, Felipe Balbi wrote: > Gadget driver may take an unbounded amount of time to queue requests > after XferNotReady. This is important for isochronous endpoints which > need to be started for a specific (micro-)frame. > > Before kicking the transfer, let's check if

Re: Question about a patch for Worlde controller

2018-08-20 Thread Greg KH
On Mon, Aug 20, 2018 at 12:03:47PM +, Maxence Duprès wrote: > Hello, > > I found nothing about this patch on git: > > Something gone wrong  with it ? No, it got caught in my system and didn't get pushed out fully, my fault. I have it in my queue again to apply once 4.19-rc1 is out and get

Re: [PATCH v3] USB: serial: ftdi_sio: Add support for CBUS GPIO

2018-08-20 Thread Johan Hovold
On Mon, Aug 20, 2018 at 05:19:40PM +0200, Loic Poulain wrote: > Hi Johan, > > On 4 August 2018 at 12:17, Loic Poulain wrote: > > Some FTDI devices like FTX or FT232R support CBUS Bit Bang mode on CBUS > > pins, allowing host to control them via simple USB control transfers. > > To make use of a

Re: [PATCH v3] USB: serial: ftdi_sio: Add support for CBUS GPIO

2018-08-20 Thread Loic Poulain
Hi Johan, On 4 August 2018 at 12:17, Loic Poulain wrote: > Some FTDI devices like FTX or FT232R support CBUS Bit Bang mode on CBUS > pins, allowing host to control them via simple USB control transfers. > To make use of a CBUS pin in Bit Bang mode, the pin must be configured > to I/O mode in the

ASM3142 controller ERROR Transfer event TRB DMA ptr not part of current TD

2018-08-20 Thread Igor Kuzmin
Hi! I'm experiencing an issue with combination of ASMedia ASM3142 controller (http://www.asmedia.com.tw/eng/e_show_products.php?cate_index=175=179) and specific USB3 device type - industrial camera. After few seconds from the start of image acquisition USB transfer hangs (device reports that

Re: cdc-acm linux kernel

2018-08-20 Thread Johan Hovold
A: No. Q: Should I include quotations after my reply? On Mon, Aug 20, 2018 at 05:57:57PM +0300, Алексей Болдырев wrote: > > Ok, and what makes you believe this chip exposes serial ports? Why > > did you think CDC-ACM would work in the first place? > > This chipset avaible from mobile phome

Re: cdc-acm linux kernel

2018-08-20 Thread Алексей Болдырев
>Ok, and what makes you believe this chip exposes serial ports? Why did you think CDC-ACM would work in the first place? This chipset avaible from mobile phome Mikromax x806. The phone is not android. https://market.yandex.ru/product--telefon-micromax-x806/13874918 20.08.2018, 17:27, "Johan

Re: cdc-acm linux kernel

2018-08-20 Thread Johan Hovold
A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? http://daringfireball.net/2007/07/on_top On Mon, Aug 20, 2018 at 04:57:23PM +0300, Алексей Болдырев wrote: > 20.08.2018, 16:54, "Johan Hovold" : > > [ Please respond inline instead of

Re: usb: gadget: f_mass_storage: detect eject

2018-08-20 Thread Alan Stern
On Sat, 18 Aug 2018, Nuno Gonçalves wrote: > Hi, > > I am trying to get some kind of notification when the host ejects a > f_mass_storage disk. > > When it happens, and the lun is removable, then the config > /sys/kernel/config/usb_gadget/*/functions/*/lun.*/file is cleared. > > I understand

Re: cdc-acm linux kernel

2018-08-20 Thread Алексей Болдырев
The device is mobile phone used chipset qualcomm snapdragon. 20.08.2018, 16:54, "Johan Hovold" : > [ Please respond inline instead of top-posting. ] > > On Mon, Aug 20, 2018 at 04:50:25PM +0300, Алексей Болдырев wrote: >>  20.08.2018, 16:46, "Johan Hovold" : >>  > [ Reshuffling your reply, and

Re: cdc-acm linux kernel

2018-08-20 Thread Johan Hovold
[ Please respond inline instead of top-posting. ] On Mon, Aug 20, 2018 at 04:50:25PM +0300, Алексей Болдырев wrote: > 20.08.2018, 16:46, "Johan Hovold" : > > [ Reshuffling your reply, and responding inline below ] > > > > On Mon, Aug 20, 2018 at 04:27:37PM +0300, Алексей Болдырев wrote: > >>  >

Re: cdc-acm linux kernel

2018-08-20 Thread Алексей Болдырев
I tried to do so, but for some reason I did not answer the serial port? 20.08.2018, 16:46, "Johan Hovold" : > [ Reshuffling your reply, and responding inline below ] > > On Mon, Aug 20, 2018 at 04:27:37PM +0300, Алексей Болдырев wrote: >>  > 20.08.2018, 11:42, "Johan Hovold" : >>  >> [ Adding

Re: cdc-acm linux kernel

2018-08-20 Thread Johan Hovold
[ Reshuffling your reply, and responding inline below ] On Mon, Aug 20, 2018 at 04:27:37PM +0300, Алексей Болдырев wrote: > > 20.08.2018, 11:42, "Johan Hovold" : > >> [ Adding linux-usb on CC. ] > >> > >> On Fri, Aug 17, 2018 at 10:41:20PM +0300, Алексей Болдырев wrote: > >>>  please add support

Re: cdc-acm linux kernel

2018-08-20 Thread Алексей Болдырев
Bus 004 Device 004: ID 1782:3d00 Spreadtrum Communications Inc. Couldn't open device, some information will be missing Device Descriptor: bLength18 bDescriptorType 1 bcdUSB 1.10 bDeviceClass0 (Defined at Interface level)

Re: Possible race condition in f_mass_storage gadget during deinitialization. Kernel warning issued

2018-08-20 Thread Adrian Ambrożewicz
In my current workspace the kernel used is 4.17.7 . Unfortunately I don't have the resources now to verify with newer version but I might look into that later if it's necessary. I've only compared source code between my worktree and mainline sources and verified that code around this area still

Re: [PATCH 3/4] usb: dwc3: trace: log ep commands in hex

2018-08-20 Thread Laurent Pinchart
Hi Andy, On Monday, 20 August 2018 15:06:31 EEST Andy Shevchenko wrote: > On Mon, Aug 20, 2018 at 2:25 PM, Laurent Pinchart wrote: > >> - TP_printk("%s: cmd '%s' [%d] params %08x %08x %08x --> status: %s", > >> + TP_printk("%s: cmd '%s' [%x] params %08x %08x %08x --> status: %s", > > > >

Re: [PATCH 3/4] usb: dwc3: trace: log ep commands in hex

2018-08-20 Thread Andy Shevchenko
On Mon, Aug 20, 2018 at 2:25 PM, Laurent Pinchart wrote: >> - TP_printk("%s: cmd '%s' [%d] params %08x %08x %08x --> status: %s", >> + TP_printk("%s: cmd '%s' [%x] params %08x %08x %08x --> status: %s", > > How about 0x%x ? Side note: # is one character less for the same. -- With Best

Question about a patch for Worlde controller

2018-08-20 Thread Maxence Duprès
Hello, I found nothing about this patch on git: Something gone wrong  with it ? This is a note to let you know that I've just added the patch titled     USB: add quirk for WORLDE Controller KS49 or Prodipe MIDI 49C USB to my usb git tree which can be found at    

Re: [PATCH 2/4] usb: dwc3: gadget: check if dep->frame_number is still valid

2018-08-20 Thread Laurent Pinchart
Hi Felipe, (CC'ing Kieran) Thank you for the patch. On Monday, 20 August 2018 13:29:59 EEST Felipe Balbi wrote: > Gadget driver may take an unbounded amount of time to queue requests > after XferNotReady. This is important for isochronous endpoints which > need to be started for a specific

Re: [PATCH 4/4] usb: dwc3: gadget: remove unnecessary dev_info()

2018-08-20 Thread Laurent Pinchart
Hi Felipe, Thank you for the patch. On Monday, 20 August 2018 13:30:01 EEST Felipe Balbi wrote: > Running out of requests on isochronous endpoints is part of normal > operation. We don't really need to know about it every time it > happens. > > Signed-off-by: Felipe Balbi Reviewed-by: Laurent

Re: [PATCH 3/4] usb: dwc3: trace: log ep commands in hex

2018-08-20 Thread Laurent Pinchart
Hi Felipe, Thank you for the patch. On Monday, 20 August 2018 13:30:00 EEST Felipe Balbi wrote: > They are much more useful in hexadecimal than in decimal. Moreover, > generic commands are already logged in hex. > > Signed-off-by: Felipe Balbi > --- > drivers/usb/dwc3/trace.h | 2 +- > 1 file

Re: [PATCH] usb: hide usb_of_get_companion_dev for CONFIG_USB=n

2018-08-20 Thread Arnd Bergmann
On Mon, Aug 20, 2018 at 5:22 AM Yoshihiro Shimoda wrote: > > From: Arnd Bergmann, Sent: Tuesday, August 14, 2018 11:27 PM > > > > On Tue, Aug 14, 2018 at 3:58 PM Alan Stern > > wrote: > > > On Mon, 13 Aug 2018, Arnd Bergmann wrote: > > > > diff --git a/drivers/usb/gadget/udc/Kconfig > > > >

Re: [PATCH 1/4] usb: dwc3: gadget: return errors from __dwc3_gadget_start_isoc()

2018-08-20 Thread Laurent Pinchart
Hi Felipe, Thank you for the patch. On Monday, 20 August 2018 13:29:58 EEST Felipe Balbi wrote: > Sometimes, errors happen when kicking transfers from > __dwc3_gadget_start_isoc(). In those cases, we need to pass along the > error so gadget driver can make informed decisions. > > Signed-off-by:

Re: Possible race condition in f_mass_storage gadget during deinitialization. Kernel warning issued

2018-08-20 Thread Felipe Balbi
Hi, Adrian Ambrożewicz writes: > Hello, > > I'm consistently observing kernel warnings related to Mass Storage USB > Gadget de-initialization flow. After investigation I believe that I've > found root cause of these warnings, however I'm unable to estimate the > impact. I would like to put the

Possible race condition in f_mass_storage gadget during deinitialization. Kernel warning issued

2018-08-20 Thread Adrian Ambrożewicz
Hello, I'm consistently observing kernel warnings related to Mass Storage USB Gadget de-initialization flow. After investigation I believe that I've found root cause of these warnings, however I'm unable to estimate the impact. I would like to put the issue into discussion about possible

[PATCH 1/4] usb: dwc3: gadget: return errors from __dwc3_gadget_start_isoc()

2018-08-20 Thread Felipe Balbi
Sometimes, errors happen when kicking transfers from __dwc3_gadget_start_isoc(). In those cases, we need to pass along the error so gadget driver can make informed decisions. Signed-off-by: Felipe Balbi --- drivers/usb/dwc3/gadget.c | 11 +-- 1 file changed, 5 insertions(+), 6

[PATCH 4/4] usb: dwc3: gadget: remove unnecessary dev_info()

2018-08-20 Thread Felipe Balbi
Running out of requests on isochronous endpoints is part of normal operation. We don't really need to know about it every time it happens. Signed-off-by: Felipe Balbi --- drivers/usb/dwc3/gadget.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/usb/dwc3/gadget.c

[PATCH 3/4] usb: dwc3: trace: log ep commands in hex

2018-08-20 Thread Felipe Balbi
They are much more useful in hexadecimal than in decimal. Moreover, generic commands are already logged in hex. Signed-off-by: Felipe Balbi --- drivers/usb/dwc3/trace.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/dwc3/trace.h b/drivers/usb/dwc3/trace.h index

[PATCH 2/4] usb: dwc3: gadget: check if dep->frame_number is still valid

2018-08-20 Thread Felipe Balbi
Gadget driver may take an unbounded amount of time to queue requests after XferNotReady. This is important for isochronous endpoints which need to be started for a specific (micro-)frame. Before kicking the transfer, let's check if current frame number is still less than our aligned frame number

Re: cdc-acm linux kernel

2018-08-20 Thread Johan Hovold
[ Adding linux-usb on CC. ] On Fri, Aug 17, 2018 at 10:41:20PM +0300, Алексей Болдырев wrote: > please add support to device from cdc-acm: > > Bus 004 Device 003: ID 1782:3d00 Spreadtrum Communications Inc. Can you please post the output of "lsusb -v" for this device? Thanks, Johan