From: Guido Kiener
Fix uninitialized symbol 'actual' in function usbtmc_ioctl_clear.
When symbol 'actual' is not initialized and usb_bulk_msg() fails,
the subsequent kernel debug message shows a random value.
Signed-off-by: Guido Kiener
Fixes: dfee02ac4bce ("usb: usbtmc: Fix ioctl
From: Guido Kiener
Kernel memory is allocated twice in new function
usbtmc_ioctl_request and creates a memory leak.
This fix removes the superfluous kmalloc().
Signed-off-by: Guido Kiener
Fixes: 658f24f4523e ("usb: usbtmc: Add ioctl for generic requests on control")
---
Fix memory leak and uninitialized symbol 'actual' in usbtmc driver of
patch series:
[v6,00/22] usb: usbtmc: Changes needed for compatible IVI/VISA library
https://patchwork.kernel.org/cover/10596935/
Two errors are reported by 0-day service (smatch tool) when testing
branch usb-testing:
1.
From: Guido Kiener
Fix uninitialized symbol 'actual' in function
usbtmc_ioctl_abort_bulk_in_tag().
When symbol 'actual' is not initialized and usb_bulk_msg() fails,
the subsequent kernel debug message shows invalid data.
Signed-off-by: Guido Kiener
Fixes: cbe743f1333b ("usb: usbtmc: Fix ioctl
From: Guido Kiener
Fix uninitialized symbol 'actual' in function usbtmc_read.
When symbol 'actual' is not initialized and usb_bulk_msg() fails,
the subsequent kernel debug message shows a random value.
Signed-off-by: Guido Kiener
Fixes: d7604ff0dc01 ("usb: usbtmc: Optimize usbtmc_read")
---
On Tue, Sep 18, 2018 at 03:32:43PM +0300, Laurent Pinchart wrote:
> Hello,
>
> This series addresses endianness and sign issues in the configfs support
> of the UVC gadget function driver.
>
> The first patch starts by fixing the endianness of various UVC
> descriptors to match the USB little
On Tue, Sep 18, 2018 at 01:35:30PM +0300, Laurent Pinchart wrote:
> USB requests for video data are queued from two different locations in
> the driver, with the same code block occurring twice. Factor it out to a
> function.
>
> Signed-off-by: Laurent Pinchart
For the whole series:
Looks good
Hi Peter,
On Fri, Sep 21, 2018 at 09:48:43AM +0800, Peter Chen wrote:
> Type-C-to-A cable, and the USB3 HCD has already been NULL at that time.
> The oops log like below:
>
> [681.782288] xhci-hcd xhci-hcd.1.auto: remove, state 1
> [681.787490] usb usb4: USB disconnect, device number 1
>
Hi Laurent,
On 18/09/18 13:25, Laurent Pinchart wrote:
> The function is never called, remove it.
It does seem that way :)
> Signed-off-by: Laurent Pinchart
Reviewed-by: Kieran Bingham
> ---
> drivers/usb/gadget/function/f_uvc.c | 6 --
> 1 file changed, 6 deletions(-)
>
> diff --git
Hi Kieran,
On Monday, 24 September 2018 15:50:45 EEST Kieran Bingham wrote:
> On 01/08/18 22:55, Laurent Pinchart wrote:
> > From: Joel Pepper
> >
> > While checks are in place to avoid attributes and children of a format
> > being manipulated after the format is linked into the streaming
Hi Laurent,
On 24/09/18 17:00, Laurent Pinchart wrote:
> Hi Kieran,
>
> On Monday, 24 September 2018 15:22:57 EEST Kieran Bingham wrote:
>> On 01/08/18 22:55, Laurent Pinchart wrote:
>>> From: Joel Pepper
>>>
>>> - Add bFrameIndex as a UVCG_FRAME_ATTR_RO for each frame size.
>>> - Automatically
Hi Kieran,
On Monday, 24 September 2018 15:22:57 EEST Kieran Bingham wrote:
> On 01/08/18 22:55, Laurent Pinchart wrote:
> > From: Joel Pepper
> >
> > - Add bFrameIndex as a UVCG_FRAME_ATTR_RO for each frame size.
> > - Automatically assign ascending bFrameIndex to each frame in a format.
> >
hi Alan:
> We don't _have_ to do it. It is a small optimization; an attempt to
> avoid schedule collisions between interrupt transactions and
> isochronous transactions. The effect of the "-" is that the code tries
> frames in backward order when it is scheduling isochronous URBs -- as
> opposed
On Sat, 22 Sep 2018, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/usb/core/driver.c: In function 'usb_driver_claim_interface':
> drivers/usb/core/driver.c:513:21: warning:
> variable 'udev' set but not used [-Wunused-but-set-variable]
>
> Signed-off-by:
Am Donnerstag, 2. August 2018, 15:01:30 CEST schrieb Heiko Stuebner:
> This is split out from the series adding the px30 support, due to
> the dwc2 binding change not having landed yet in a maintainer tree.
>
> The Acked binding change should go through some usb tree, while
> I'll pick up the dts
Add device-id for the Motorola Tetra radio MTP6550.
Bus 001 Device 004: ID 0cad:9012 Motorola CGISS
Device Descriptor:
bLength18
bDescriptorType 1
bcdUSB 2.00
bDeviceClass0 (Defined at Interface level)
bDeviceSubClass 0
On Mon, Sep 24, 2018 at 12:20:42PM +, gu...@kiener-muenchen.de wrote:
>
> Zitat von Oliver Neukum :
>
> > On Mo, 2018-09-24 at 10:56 +, gu...@kiener-muenchen.de wrote:
> > > Zitat von Greg Kroah-Hartman :
> > >
> > > > On Mon, Sep 24, 2018 at 11:24:10AM +0200, Oliver Neukum wrote:
> > >
Hi Laurent, Joel
On 01/08/18 22:55, Laurent Pinchart wrote:
> From: Joel Pepper
>
> - Add bFrameIndex as a UVCG_FRAME_ATTR_RO for each frame size.
> - Automatically assign ascending bFrameIndex to each frame in a format.
>
> Before all "bFrameindex" attributes were set to "1" with no way to
>
Hi Laurent, Joel,
On 01/08/18 22:55, Laurent Pinchart wrote:
> From: Joel Pepper
>
> While checks are in place to avoid attributes and children of a format
> being manipulated after the format is linked into the streaming header,
> the linked flag was never actually set, invalidating the
Zitat von Oliver Neukum :
On Mo, 2018-09-24 at 10:56 +, gu...@kiener-muenchen.de wrote:
Zitat von Greg Kroah-Hartman :
> On Mon, Sep 24, 2018 at 11:24:10AM +0200, Oliver Neukum wrote:
> > Hi,
> >
> > how should I mark fixes intended for the testing branch?
> > I got one for the usbtmc
Hi Laurent,
On 01/08/18 22:55, Laurent Pinchart wrote:
> The UVC format description are numbered using the descriptor's
> bFormatIndex field. The index is used in UVC requests, and is thus
> needed to handle requests in userspace. Make it dynamically discoverable
> by exposing it in a
Hi Laurent,
On 01/08/18 22:55, Laurent Pinchart wrote:
> The video control and video streaming interface numbers are needed in
> the UVC gadget userspace stack to reply to UVC requests. They are
> hardcoded to fixed values at the moment, preventing configurations with
> multiple functions.
>
>
Hi Laurent,
On 01/08/18 22:55, Laurent Pinchart wrote:
> The UVC configfs implementation creates all groups as global static
> variables. This prevents creation of multiple UVC function instances,
> as they would all require their own configfs group instances.
>
> Fix this by allocating all
Hi Laurent,
On 01/08/18 22:55, Laurent Pinchart wrote:
> Some of the .allow_link() and .drop_link() operations implementations
> call config_group_find_item() and then leak the reference to the
> returned item. Fix this by dropping those references where needed.
>
> Signed-off-by: Laurent
On Mo, 2018-09-24 at 10:56 +, gu...@kiener-muenchen.de wrote:
> Zitat von Greg Kroah-Hartman :
>
> > On Mon, Sep 24, 2018 at 11:24:10AM +0200, Oliver Neukum wrote:
> > > Hi,
> > >
> > > how should I mark fixes intended for the testing branch?
> > > I got one for the usbtmc driver.
> >
> >
Zitat von Greg Kroah-Hartman :
On Mon, Sep 24, 2018 at 11:24:10AM +0200, Oliver Neukum wrote:
Hi,
how should I mark fixes intended for the testing branch?
I got one for the usbtmc driver.
Just send it like normal. You can do a "Fixes:" tag with the sha1, that
should be fine. I need to
On Mon, Sep 24, 2018 at 11:24:10AM +0200, Oliver Neukum wrote:
> Hi,
>
> how should I mark fixes intended for the testing branch?
> I got one for the usbtmc driver.
Just send it like normal. You can do a "Fixes:" tag with the sha1, that
should be fine. I need to push out my testing branch now,
Hi,
how should I mark fixes intended for the testing branch?
I got one for the usbtmc driver.
Regards
Oliver
28 matches
Mail list logo
