[PATCH -next] usb: typec: remove set but not used variables 'snk_ma, flags'

2018-09-28 Thread YueHaibing
Fixes gcc '-Wunused-but-set-variable' warning: drivers/usb/typec/tcpm/tcpm.c: In function 'tcpm_pd_select_pps_apdo': drivers/usb/typec/tcpm/tcpm.c:2212:39: warning: variable 'snk_ma' set but not used [-Wunused-but-set-variable] drivers/usb/typec/tcpm/tcpm.c: In function

Re: [PATCH -next] USB: core: remove set but not used variable 'udev'

2018-09-28 Thread Alan Stern
On Fri, 28 Sep 2018, Greg Kroah-Hartman wrote: > On Sat, Sep 22, 2018 at 06:31:26AM +, YueHaibing wrote: > > Fixes gcc '-Wunused-but-set-variable' warning: > > > > drivers/usb/core/driver.c: In function 'usb_driver_claim_interface': > > drivers/usb/core/driver.c:513:21: warning: > >

Re: [RFT PATCH 1/2] xhci: Fix leaking USB3 shared_hcd at xhci removal

2018-09-28 Thread Jack Pham
On Thu, Sep 27, 2018 at 07:26:26PM +0300, Mathias Nyman wrote: > Ensure that the shared_hcd pointer is valid when calling usb_put_hcd() > > The shared_hcd is removed and freed in xhci by first calling > usb_remove_hcd(xhci->shared_hcd), and later > usb_put_hcd(xhci->shared_hcd) > > Afer commit

Re: [RFT PATCH 2/2] xhci: handle port status events for removed USB3 hcd

2018-09-28 Thread Jack Pham
Hi Mathias, On Fri, Sep 28, 2018 at 03:35:10AM +, Peter Chen wrote: > > > > Cc: > > > Reported-by: Peter Chen > > > Signed-off-by: Mathias Nyman > > > --- > > > drivers/usb/host/xhci-ring.c | 7 +++ > > > 1 file changed, 7 insertions(+) > > > > > > diff --git

Re: fixes for ioctl() of usbtmc in testing tree

2018-09-28 Thread Greg Kroah-Hartman
On Fri, Sep 28, 2018 at 08:30:41AM +, gu...@kiener-muenchen.de wrote: > > Zitat von Greg Kroah-Hartman : > > > On Mon, Sep 24, 2018 at 12:20:42PM +, gu...@kiener-muenchen.de wrote: > > > > > > Zitat von Oliver Neukum : > > > > > > > On Mo, 2018-09-24 at 10:56 +,

Re: [PATCH -next] USB: core: remove set but not used variable 'udev'

2018-09-28 Thread Greg Kroah-Hartman
On Sat, Sep 22, 2018 at 06:31:26AM +, YueHaibing wrote: > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/usb/core/driver.c: In function 'usb_driver_claim_interface': > drivers/usb/core/driver.c:513:21: warning: > variable 'udev' set but not used [-Wunused-but-set-variable] > >

Re: [PATCH v2 0/3] xhci fixes for usb-linus

2018-09-28 Thread Greg KH
On Thu, Sep 20, 2018 at 06:43:19PM +0300, Mathias Nyman wrote: > Hi Greg > > Second try, shuffling patches between for-usb-linus and for-usb-next > > A few patches that makes sure USB3 devices enumerate to correct speed > after resume on Mediatek hosts, enables role mux on Apollo lake platforms,

Re: [PATCH] usb: dwc2: disable power_down on rockchip devices

2018-09-28 Thread Minas Harutyunyan
On 9/28/2018 7:05 AM, Hal Emmerich wrote: > From 04fbf78e4e569bf872f1ffcb0a6f9b89569dc913 Mon Sep 17 00:00:00 2001 > From: Hal Emmerich > Date: Thu, 19 Jul 2018 21:48:08 -0500 > Subject: [PATCH] usb: dwc2: disable power_down on rockchip devices > >  The bug would let the usb controller enter

[PATCH v4] usb: export firmware port location in sysfs

2018-09-28 Thread Bjørn Mork
The platform firmware "location" data is used to find port peer relationships. But firmware is an unreliable source, and there are real world examples of errors leading to missing or wrong peer relationships. Debugging this is currently hard. Exporting the location attribute makes it easier to

Re: [PATCH v3] usb: export firmware port location in sysfs

2018-09-28 Thread Bjørn Mork
Alan Stern writes: >> diff --git a/Documentation/ABI/testing/sysfs-bus-usb >> b/Documentation/ABI/testing/sysfs-bus-usb >> index 08d456e07b53..8f394c976fee 100644 >> --- a/Documentation/ABI/testing/sysfs-bus-usb >> +++ b/Documentation/ABI/testing/sysfs-bus-usb >> @@ -173,14 +173,14 @@

Re: [PATCH v3] usb: export firmware port location in sysfs

2018-09-28 Thread Alan Stern
On Fri, 28 Sep 2018, Bjørn Mork wrote: > The platform firmware "location" data is used to find port peer > relationships. But firmware is an unreliable source, and there are > real world examples of errors leading to missing or wrong peer > relationships. Debugging this is currently hard. > >

[PATCH v3] usb: export firmware port location in sysfs

2018-09-28 Thread Bjørn Mork
The platform firmware "location" data is used to find port peer relationships. But firmware is an unreliable source, and there are real world examples of errors leading to missing or wrong peer relationships. Debugging this is currently hard. Exporting the location attribute makes it easier to

Re: [PATCH v2] usb: export firmware port location in sysfs

2018-09-28 Thread kbuild test robot
Hi Bjørn, I love your patch! Perhaps something to improve: [auto build test WARNING on peter.chen-usb/ci-for-usb-next] [also build test WARNING on v4.19-rc5 next-20180928] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https

[PATCH v2] usb: export firmware port location in sysfs

2018-09-28 Thread Bjørn Mork
The platform firmware "location" data is used to find port peer relationships. But firmware is an unreliable source, and there are real world examples of errors leading to missing or wrong peer relationships. Debugging this is currently hard. Exporting the location attribute makes it easier to

[PATCH] usb: export firmware port location in sysfs

2018-09-28 Thread Bjørn Mork
The platform firmware "location" data is used to find port peer relationships. But firmware is an unreliable source. Errors in ACPI tables can lead to missing or wrong peer relationships. Debugging this is currently hard. Exporting the location attribute makes it easier to spot mismatches

Re: fixes for ioctl() of usbtmc in testing tree

2018-09-28 Thread guido
Zitat von Greg Kroah-Hartman : On Mon, Sep 24, 2018 at 12:20:42PM +, gu...@kiener-muenchen.de wrote: Zitat von Oliver Neukum : > On Mo, 2018-09-24 at 10:56 +, gu...@kiener-muenchen.de wrote: > > Zitat von Greg Kroah-Hartman : > > > > > On Mon, Sep 24, 2018 at 11:24:10AM +0200,