RE: [PATCH v3 4/4] doc: usb: ci-hdrc-usb2: Add pinctrl properties for HSIC pin groups

2018-12-04 Thread PETER CHEN
> On 04.12.18 21:01, Fabio Estevam wrote: > > Hi Frieder, > > > > On Tue, Dec 4, 2018 at 12:31 PM Schrempf Frieder > > wrote: > > > >> There are many other optional properties for this driver and a lot of > >> them are not in the given example. Maybe we should just keep the > >> pinctrls for

Re: [PATCH v3 4/4] doc: usb: ci-hdrc-usb2: Add pinctrl properties for HSIC pin groups

2018-12-04 Thread Schrempf Frieder
Hi Fabio, On 04.12.18 21:01, Fabio Estevam wrote: > Hi Frieder, > > On Tue, Dec 4, 2018 at 12:31 PM Schrempf Frieder > wrote: > >> There are many other optional properties for this driver and a lot of >> them are not in the given example. Maybe we should just keep the >> pinctrls for HSIC-mode

Re: [PATCH] USB: qcaux: Add Motorola modem UARTs

2018-12-04 Thread Johan Hovold
On Sun, Dec 02, 2018 at 05:34:24PM -0800, Tony Lindgren wrote: > On Motorola Mapphone devices such as Droid 4 there are five USB ports > that do not use the same layout as Gobi 1K/2K/etc devices listed in > qcserial.c. So we should use qcaux.c or option.c as noted by > Dan Williams . > > The

[PATCH 2/3] usb: appledisplay: Set urb transfer_flags to URB_NO_TRANSFER_DMA_MAP

2018-12-04 Thread alex . theissen
From: Alexander Theissen The driver does allocate a DMA address with usb_alloc_coherent but did not set the appropriate flag to signal that transfer_dma is set to a valid value. Signed-off-by: Alexander Theissen --- drivers/usb/misc/appledisplay.c | 1 + 1 file changed, 1 insertion(+) diff

[PATCH 3/3] usb: appledisplay: Remove unnecessary spinlock

2018-12-04 Thread alex . theissen
From: Alexander Theissen The spinlock was inside the urb completion function which is only called once per display and is then resubmitted from this function. There was no other place where this lock was used. Signed-off-by: Alexander Theissen --- drivers/usb/misc/appledisplay.c | 7 ---

[PATCH 0/3] Small improvements to the appledisplay driver

2018-12-04 Thread alex . theissen
With the exception of the first patch I am not entirely sure if my changes are correct and justified. This is my first contribution and I am equally satisfied if someone could point out why my changes are not correct. The added display is my own and works well with the driver.

[PATCH 1/3] usb: appledisplay: Add 27" Apple Cinema Display

2018-12-04 Thread alex . theissen
From: Alexander Theissen Add another Apple Cinema Display to the list of supported displays. Signed-off-by: Alexander Theissen --- drivers/usb/misc/appledisplay.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/misc/appledisplay.c b/drivers/usb/misc/appledisplay.c index

Re: [PATCH v3 4/4] doc: usb: ci-hdrc-usb2: Add pinctrl properties for HSIC pin groups

2018-12-04 Thread Fabio Estevam
Hi Frieder, On Tue, Dec 4, 2018 at 12:31 PM Schrempf Frieder wrote: > There are many other optional properties for this driver and a lot of > them are not in the given example. Maybe we should just keep the > pinctrls for HSIC-mode out of the example, too? I am just trying to make life easier

dwc2 isochronous transfers issues

2018-12-04 Thread Andrzej Pietrasiewicz
Hi All, I have recently noticed a problem with dwc2 and audio gadget. The expected behavior: The uac2 function acts as a kind of a pass-through. For example to play audio from USB host on an Odroid U3 the following command is issued at the host: aplay -D plughw:CARD=Gadget,DEV=0

Re: pl2303 regression after v4.17. Bisected to 7041d9c3f01b

2018-12-04 Thread Johan Hovold
On Mon, Nov 26, 2018 at 02:29:53PM +0200, Jarkko Nikula wrote: > On 11/24/18 7:32 PM, Florian Zumbiehl wrote: > > Hi, > > > >> Requested baud setting looks odd to me. Maybe related to this > >> --keep-baud flag in "/sbin/agetty -o -p -- \u --keep-baud > >> 115200,38400,9600 ttyUSB0 vt220"? That

Re: USB driver resets

2018-12-04 Thread Mika Westerberg
On Tue, Dec 04, 2018 at 04:45:33PM +0200, Mathias Nyman wrote: > On 03.12.2018 12:36, Richard van der Hoff wrote: > > Does anybody have any suggestions as to how I could set about debugging > > this? I'm seeing the same symptoms on a 4.19 kernel. > > > > > > On 19/11/2018 15:27, Richard van der

Re: USB driver resets

2018-12-04 Thread Mathias Nyman
On 03.12.2018 12:36, Richard van der Hoff wrote: Does anybody have any suggestions as to how I could set about debugging this? I'm seeing the same symptoms on a 4.19 kernel. On 19/11/2018 15:27, Richard van der Hoff wrote: I have a USB-3.1 dock, which I use for video (via displayport alt

Re: [PATCH v3 4/4] doc: usb: ci-hdrc-usb2: Add pinctrl properties for HSIC pin groups

2018-12-04 Thread Schrempf Frieder
Hi Peter, hi Fabio, On 30.11.18 03:33, PETER CHEN wrote: > >> >> On Tue, Nov 27, 2018 at 7:31 AM PETER CHEN wrote: >>> >>> For USB HSIC, the data and strobe pin needs to be pulled down at >>> default, we consider it as "idle" state. When the USB host is ready to >>> be used, the strobe pin

Re: [PATCH v3 1/3] usb: chipidea: imx: support configuring for active low oc signal

2018-12-04 Thread Uwe Kleine-König
Hello, On Tue, Dec 04, 2018 at 12:43:21PM +0100, Stefan Wahren wrote: > Am 04.12.18 um 09:52 schrieb Uwe Kleine-König: > > But for the review you are right, I added the dt people to Cc for them > > to comment. In v2 Matthew also noted that he would prefer to handle the > > situation when both

FROM MISS DIANA HOLLAND

2018-12-04 Thread miss Diana
Attention, Good day to you, how are you? My name is Diana Holland. I am a U.S. Army Specialist, serving here in Afghanistan. I found a box containing the sum of $10,000,000.00 USD (Ten Million United States Dollars) due to my status as a U.S. Army Specialist, i can’t be able to transfer these

Re: [PATCH v3 1/3] usb: chipidea: imx: support configuring for active low oc signal

2018-12-04 Thread Stefan Wahren
Am 04.12.18 um 09:52 schrieb Uwe Kleine-König: > Hello Stefan, > > On Tue, Dec 04, 2018 at 09:40:26AM +0100, Stefan Wahren wrote: >> Am 04.12.18 um 09:31 schrieb Uwe Kleine-König: >>> The status quo on i.MX6 is that if "over-current-active-high" is >>> specified in the device tree this is

Re: [PATCH v3 1/3] usb: chipidea: imx: support configuring for active low oc signal

2018-12-04 Thread Uwe Kleine-König
Hello Stefan, On Tue, Dec 04, 2018 at 09:40:26AM +0100, Stefan Wahren wrote: > Am 04.12.18 um 09:31 schrieb Uwe Kleine-König: > > The status quo on i.MX6 is that if "over-current-active-high" is > > specified in the device tree this is configured as expected. If > > the property is missing

Re: [PATCH v3 1/3] usb: chipidea: imx: support configuring for active low oc signal

2018-12-04 Thread Stefan Wahren
Hi Uwe, Am 04.12.18 um 09:31 schrieb Uwe Kleine-König: > The status quo on i.MX6 is that if "over-current-active-high" is > specified in the device tree this is configured as expected. If > the property is missing polarity isn't changed and so the > polarity is kept as setup by the bootloader.

[PATCH v3 2/3] usb: chipidea: imx: Warn if oc polarity isn't specified

2018-12-04 Thread Uwe Kleine-König
The polarity of the over current detection pin isn't configured on i.MX6/7 if it's unspecified in the device tree. So the actual configuration depends on bootloader behavior which is bad. So encourage users to fix their device tree by issuing a warning in this case. Signed-off-by: Uwe

[PATCH v3 3/3] usb: chipidea: imx: allow to configure oc polarity on i.MX25

2018-12-04 Thread Uwe Kleine-König
Up to now the polarity of the over current pin was hard coded to active high. Use the already defined device tree properties to configure polarity on i.MX25, too. In difference to i.MX6/7 use active high behavior if the polarity is unspecified to keep compatibility to existing device trees.

[PATCH v3 1/3] usb: chipidea: imx: support configuring for active low oc signal

2018-12-04 Thread Uwe Kleine-König
The status quo on i.MX6 is that if "over-current-active-high" is specified in the device tree this is configured as expected. If the property is missing polarity isn't changed and so the polarity is kept as setup by the bootloader. Reset default is active high, so active low can only be used with

[PATCH v3 0/3] usb: chipidea: imx: improve oc handling

2018-12-04 Thread Uwe Kleine-König
Hello, compared to v2 (which starts with Message-Id: <20181202213325.26017-1-u.kleine-koe...@pengutronix.de>) I adapted patch 1 that the oc polarity is only determined if oc isn't disabled. This results in the warning that is introduced in patch 2 not to be emitted in this case. Best regards Uwe

Re: [PATCH v2 2/3] usb: chipidea: imx: Warn if oc polarity isn't specified

2018-12-04 Thread Uwe Kleine-König
Hello Peter, On Tue, Dec 04, 2018 at 06:19:11AM +, PETER CHEN wrote: > > diff --git a/drivers/usb/chipidea/ci_hdrc_imx.c > > b/drivers/usb/chipidea/ci_hdrc_imx.c > > index 80b4e4ef9b68..3dcfd0d97f94 100644 > > --- a/drivers/usb/chipidea/ci_hdrc_imx.c > > +++