Re: Queueing b0a688ddcc50 "usb: musb: cppi41: allow it to work again" for -stable

2015-10-02 Thread Ezequiel Garcia
On 2 October 2015 at 13:09, Felipe Balbi <ba...@ti.com> wrote: > On Fri, Oct 02, 2015 at 02:23:45AM -0300, Ezequiel Garcia wrote: >> Hello, >> >> Commit b0a688ddcc50 "usb: musb: cppi41: allow it to work again" seems >> to fix a regression. It applies cl

Queueing b0a688ddcc50 "usb: musb: cppi41: allow it to work again" for -stable

2015-10-01 Thread Ezequiel Garcia
Hello, Commit b0a688ddcc50 "usb: musb: cppi41: allow it to work again" seems to fix a regression. It applies cleanly on v4.1 and removes the "musb-hdrc musb-hdrc.1.auto: Need DT for the DMA engine." error. Any chance you can queue it for -stable? Thanks! -- Ezequiel García, VanguardiaSur

Re: [PATCH 0/9] usb: musb: several bugfixes for the musb driver

2014-07-21 Thread Ezequiel Garcia
On 21 Jul 10:11 AM, Felipe Balbi wrote: On Mon, Jul 21, 2014 at 09:34:30AM +0200, Lothar Waßmann wrote: Hi, Felipe Balbi wrote: Hi, On Fri, Jul 18, 2014 at 01:16:36PM -0300, Ezequiel Garcia wrote: Hi Lothar, On 18 Jul 11:31 AM, Lothar Waßmann wrote: The first

Re: [PATCH 0/9] usb: musb: several bugfixes for the musb driver

2014-07-18 Thread Ezequiel Garcia
-by: Ezequiel Garcia ezequ...@vanguardiasur.com.ar Tested on a beaglebone with a mass storage USB device, module load/unload works without issues. The module_get/put in the phy is now preventing the musb_am335x driver unload, which seems to be the real cause of the issue I reported. Thanks for providing

[PATCH] usb: musb: Fix panic upon musb_am335x module removal

2014-06-23 Thread Ezequiel Garcia
] (SyS_delete_module) from [c000e500] (ret_fast_syscall+0x0/0x48) Fixes: 97238b35d5bb (usb: musb: dsps: use proper child nodes) Cc: sta...@vger.kernel.org # v3.12+ Acked-by: George Cherian george.cher...@ti.com Signed-off-by: Ezequiel Garcia ezequ...@vanguardiasur.com.ar --- drivers/usb/musb/musb_am335x.c

Re: [RFC/PATCH] usb: musb: Prevent musb_am335x from being removed

2014-05-12 Thread Ezequiel Garcia
On 12 May 10:29 AM, George Cherian wrote: On 5/8/2014 10:57 PM, Ezequiel Garcia wrote: At probe time, the musb_am335x driver registers its childs by calling of_platform_populate(), which registers all childs in the devicetree hierarchy recursively. On the other side, the driver's remove

[RFC/PATCH] usb: musb: Prevent musb_am335x from being removed

2014-05-08 Thread Ezequiel Garcia
-by: Ezequiel Garcia ezequ...@vanguardiasur.com.ar --- Given I'm not 100% sure my analisys is correct, I've marked this as RFC and not Cced stable. Feel free to provide a better patch to fix this issue, instead of disabling the removal. drivers/usb/musb/musb_am335x.c | 23 ++- 1 file

Re: [PATCH v3 17/20] phy: Add support for USB cluster on the Armada 375 SoC

2014-05-06 Thread Ezequiel Garcia
Hi Greg, On 06 May 02:14 AM, Gregory CLEMENT wrote: + +#define USB2_PHY_CONFIG_ENABLE BIT(0) /* active low */ + I still think it's more readable to use USB2_PHY_CONFIG_DISABLE. It's just a nitpick, though. +static int armada375_usb_phy_probe(struct platform_device *pdev) +{ + struct

Re: [PATCH v2 14/18] ARM: mvebu: Add support for USB cluster on the Armada 375 SoC

2014-04-25 Thread Ezequiel Garcia
On Apr 25, Gregory CLEMENT wrote: The Armada 375 SoC comes with an USB2 host and device controller and an USB3 controller. The USB cluster control register allows to manage common features of both USB controllers. Signed-off-by: Gregory CLEMENT gregory.clem...@free-electrons.com ---

Re: [PATCH] USB: musb: dsps: move debugfs_remove_recursive()

2014-04-24 Thread Ezequiel Garcia
Felipe, On Apr 22, Greg KH wrote: On Tue, Apr 22, 2014 at 10:26:13AM -0500, Felipe Balbi wrote: On Tue, Apr 22, 2014 at 12:19:16PM -0300, Ezequiel Garcia wrote: That way silly grass-hoppers like me won't have to go through the find-bisect-fix bug cycle, only to discover someone else

Re: [PATCH] ARM: dts: am33xx: Move the cppi41dma node so it's probed early

2014-04-23 Thread Ezequiel Garcia
On Apr 23, Sebastian Andrzej Siewior wrote: On 04/22/2014 04:19 PM, Ezequiel Garcia wrote: The DMA controller is needed for the USB controller to be correctly registered. Therefore, if the DMA node is located at the end an unecessary probe deferral is produced systematically

[PATCH] ARM: dts: am33xx: Move the cppi41dma node so it's probed early

2014-04-22 Thread Ezequiel Garcia
-by: Ezequiel Garcia ezequ...@vanguardiasur.com.ar --- Felipe, Sebastian: I cannot see why the cppi41dma node must be placed inside the ti,am33xx-usb compatible node. Tried to move it out so it's probed just like the edma engine, but the USB doesn't work properly in that case. Can you enlighten me

Re: stk1160 / ehci-pci 0000:00:0a.0: DMA-API: device driver maps memory fromstack [addr=ffff88003d0b56bf]

2014-04-14 Thread Ezequiel Garcia
On Apr 13, Alan Stern wrote: On Sun, 13 Apr 2014, Sander Eikelenboom wrote: Hi, I'm hitting this warning on boot with a syntek usb video grabber, it's not clear to me if it's a driver issue of the stk1160 or a generic ehci issue. It is a bug in the stk1160 driver. Thanks for

Re: stk1160 / ehci-pci 0000:00:0a.0: DMA-API: device driver maps memory fromstack [addr=ffff88003d0b56bf]

2014-04-14 Thread Ezequiel Garcia
On Apr 13, Sander Eikelenboom wrote: I'm hitting this warning on boot with a syntek usb video grabber, it's not clear to me if it's a driver issue of the stk1160 or a generic ehci issue. Can't reproduce the same warning easily here. Could you test the following patch? diff --git

Re: AM335x USB DMA seems broken on ISOC URBs

2014-01-20 Thread Ezequiel Garcia
On Mon, Jan 20, 2014 at 12:15:40PM +0100, Daniel Mack wrote: On 01/18/2014 04:12 PM, Daniel Mack wrote: On 01/17/2014 05:27 PM, Ezequiel Garcia wrote: On Sun, Dec 22, 2013 at 02:59:45AM -0300, Ezequiel Garcia wrote: While doing some experiments with the stk1160 driver (for Easycap TV

Re: AM335x USB DMA seems broken on ISOC URBs

2014-01-20 Thread Ezequiel Garcia
Hi Daniel, On Sat, Jan 18, 2014 at 04:12:24PM +0100, Daniel Mack wrote: On 01/17/2014 05:27 PM, Ezequiel Garcia wrote: On Sun, Dec 22, 2013 at 02:59:45AM -0300, Ezequiel Garcia wrote: [..] Did you try this with a different type of peripheral hardware, a USB audio device for example

Re: AM335x USB DMA seems broken on ISOC URBs

2014-01-17 Thread Ezequiel Garcia
On Sun, Dec 22, 2013 at 02:59:45AM -0300, Ezequiel Garcia wrote: Hello, While doing some experiments with the stk1160 driver (for Easycap TV video capture devices), ran into problems using v3.13-rc4. The problem is that the stk1160 IRQ handler receives no URBs at all. When configuring

[PATCH 2/2] usb: musb: Rework USB and USB_GADGET dependency

2013-12-26 Thread Ezequiel Garcia
This USB controller can work in as host-only, gadget-only or dual-role modes. Rework the dependency on the USB and USB_GADGET configs in order to allow building the driver when !USB or !USG_GADGET. Signed-off-by: Ezequiel Garcia ezequiel.gar...@free-electrons.com --- This is just a resend

[PATCH 0/2] musb: Rework USB and USB_GADGET config

2013-12-26 Thread Ezequiel Garcia
. Hope it looks better now. Ezequiel Garcia (2): usb: musb: Remove usb_disable() check in module_init() usb: musb: Rework USB and USB_GADGET dependency drivers/usb/Kconfig | 4 ++-- drivers/usb/musb/Kconfig | 8 drivers/usb/musb/musb_core.c | 17 + 3 files

[PATCH 1/2] usb: musb: Remove usb_disable() check in module_init()

2013-12-26 Thread Ezequiel Garcia
Removing the check to usb_disable() before registering the platform driver allows to build this driver when !USB USB_GADGET, to be used in gadget-only mode. Also, use module_platform_driver() to register the platform driver. Signed-off-by: Ezequiel Garcia ezequiel.gar...@free-electrons.com

[PATCH v2] usb: musb: Rework USB and USB_GADGET dependency

2013-12-26 Thread Ezequiel Garcia
This USB controller can work in as host-only, gadget-only or dual-role modes. Rework the dependency on the USB and USB_GADGET configs in order to allow building the driver when !USB or !USG_GADGET. Signed-off-by: Ezequiel Garcia ezequiel.gar...@free-electrons.com --- Changes from v1: Remove

[PATCH v2] usb: musb: Rework USB and USB_GADGET dependency

2013-12-21 Thread Ezequiel Garcia
This USB controller can work in as host-only, gadget-only or dual-role modes. Rework the dependency on the USB and USB_GADGET configs in order to allow building the driver when !USB or !USG_GADGET. Signed-off-by: Ezequiel Garcia ezequiel.gar...@free-electrons.com --- Changes from v1: * Rework

AM335x USB DMA seems broken on ISOC URBs

2013-12-21 Thread Ezequiel Garcia
Hello, While doing some experiments with the stk1160 driver (for Easycap TV video capture devices), ran into problems using v3.13-rc4. The problem is that the stk1160 IRQ handler receives no URBs at all. When configuring with CONFIG_MUSB_PIO_ONLY this looks solved, but the bandwidth requirements

Re: [PATCH] usb: musb: Remove USB_GADGET driver dependency

2013-12-20 Thread Ezequiel Garcia
On Fri, Dec 20, 2013 at 09:49:58AM -0600, Felipe Balbi wrote: On Thu, Dec 19, 2013 at 10:20:48PM -0300, Ezequiel Garcia wrote: This USB controller is dual-role, but can also work in host-only mode. There's no reason to condition the entire driver to USB_GADGET. Fix this by removing

[PATCH] usb: musb: Remove USB_GADGET driver dependency

2013-12-19 Thread Ezequiel Garcia
This USB controller is dual-role, but can also work in host-only mode. There's no reason to condition the entire driver to USB_GADGET. Fix this by removing the dependency. Tested on a Beaglebone black (AM335x) using a regular USB mass storage device. Signed-off-by: Ezequiel Garcia ezequiel.gar

Re: [PATCH] usb: phy: am335x: Prevent GPIO reset line request

2013-12-06 Thread Ezequiel Garcia
On Fri, Dec 06, 2013 at 02:16:23PM -0600, Felipe Balbi wrote: On Sat, Nov 30, 2013 at 07:45:05PM -0300, Ezequiel Garcia wrote: On Thu, Nov 21, 2013 at 07:01:55AM -0600, Felipe Balbi wrote: On Thu, Nov 21, 2013 at 08:55:20AM -0300, Ezequiel Garcia wrote: On Thu, Nov 21, 2013 at 12:44:51PM

Re: [PATCH] usb: phy: am335x: Prevent GPIO reset line request

2013-11-30 Thread Ezequiel Garcia
On Thu, Nov 21, 2013 at 07:01:55AM -0600, Felipe Balbi wrote: On Thu, Nov 21, 2013 at 08:55:20AM -0300, Ezequiel Garcia wrote: On Thu, Nov 21, 2013 at 12:44:51PM +0100, Sebastian Andrzej Siewior wrote: On 11/21/2013 12:30 PM, Ezequiel Garcia wrote: Ah, good to know. That patch should

[PATCH] usb: phy: am335x: Prevent GPIO reset line request

2013-11-20 Thread Ezequiel Garcia
-by: Ezequiel Garcia ezequiel.gar...@free-electrons.com --- Commit bd27fa44e13830d2baa278d5702e766380659cb3 (usb: phy: generic: Don't use regulator framework for RESET line) introduced this. drivers/usb/phy/phy-am335x.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/usb/phy/phy-am335x.c b

Re: [PATCH] usb: phy: am335x: Prevent GPIO reset line request

2013-11-20 Thread Ezequiel Garcia
(Forgot to Cc OMAP people) On Wed, Nov 20, 2013 at 06:58:34PM -0300, Ezequiel Garcia wrote: The 'gpio_reset' field was implicitly set to zero, which is a valid GPIO line and results in the NOP PHY layer trying to request it. Instead, the AM335x SoC need special USB PHY reset handling so

Re: [PATCH v2 0/4] Add phy support for AM335X platform using Generic PHy framework

2013-08-10 Thread Ezequiel Garcia
On Fri, Jul 19, 2013 at 06:04:33PM +0530, George Cherian wrote: This patch series adds phy support for AM335X platform. This patch series is based on Generic PHY framework [1]. This series has - adds dual musb instances support for am335x platform - adds phy-am-usb

Re: musb: dsps: make it work with two instances

2013-07-17 Thread Ezequiel Garcia
Hi Sebastian, On Wed, Jul 17, 2013 at 07:12:29PM +0200, Sebastian Andrzej Siewior wrote: After some minor DT tweaking on the current patchset, I've managed to detect an USB mass storage device in the second instance (host / usb1) using a Beaglebone black board. Beaglebone black, that one

Re: [PATCH 0/5] Add phy support for AM335X platform using Generic PHy framework

2013-07-08 Thread Ezequiel Garcia
Hi, On Mon, Jul 08, 2013 at 09:44:33PM +0200, Sebastian Andrzej Siewior wrote: We need two nodes each one with a glue layer and a musb child node. The instances crap in kernel has to vanish. Also that means your phy nodes are wrong. This is not musb with two ports but two musb instances each

Re: musb: dsps: make it work with two instances

2013-07-06 Thread Ezequiel Garcia
Hi Sebastian, On Fri, Jul 5, 2013 at 10:32 AM, Sebastian Andrzej Siewior bige...@linutronix.de wrote: This enables the two musb instances on am335x to work. I like a lot the idea of splitting the DT representation of the two USB instances. The DT binding looks much better this way. After some

Re: [PATCH 2/2] USB: EHCI: make ehci-orion a separate driver

2013-02-16 Thread Ezequiel Garcia
Hi Arnd, On Fri, Feb 15, 2013 at 11:12:29PM +0100, Arnd Bergmann wrote: From: Manjunath Goudar manjunath.gou...@linaro.org With the multiplatform changes in arm-soc tree, it becomes possible to enable the mvebu platform (which uses ehci-orion) at the same time as other platforms that

Re: [V2 0/8] usb: ehci: more bus glues as separate modules

2013-02-15 Thread Ezequiel Garcia
Hi Manjunath, Nice job! On Fri, Feb 15, 2013 at 03:54:05PM +0530, Manjunath Goudar wrote: Separate the SOC On-Chip host controller driver from ehci-hcd host code into its own driver module V2: Modified the patches, based on the first version review comments If at all possible, I'd

Re: [PATCH 00/10] usb: ehci: more bus glues as separate modules

2013-02-07 Thread Ezequiel Garcia
Hi Manjunath, Nice work. On Thu, Feb 07, 2013 at 11:03:57PM +0530, manjunath.gou...@linaro.org wrote: From: Manjunath Goudar manjunath.gou...@linaro.org Separate the SOC On-Chip host controller driver from ehci-hcd host code into its own driver module. Perhaps you could add a few lines

Re: [PATCH v2 1/3] arm: mvebu: Add support for USB host controllers in Armada 370/XP

2013-01-29 Thread Ezequiel Garcia
Hi Jason, On Wed, Jan 23, 2013 at 2:40 PM, Jason Cooper ja...@lakedaemon.net wrote: On Wed, Jan 23, 2013 at 02:06:12PM -0300, Ezequiel Garcia wrote: Jason, On Wed, Jan 23, 2013 at 12:26 PM, Ezequiel Garcia ezequiel.gar...@free-electrons.com wrote: The Armada 370 and Armada XP SoC has

[PATCH v2 3/3] arm: mvebu: Update defconfig to select USB support

2013-01-23 Thread Ezequiel Garcia
Cc: Lior Amsalem al...@marvell.com Cc: Thomas Petazzoni thomas.petazz...@free-electrons.com Cc: Gregory CLEMENT gregory.clem...@free-electrons.com Tested-by: Nobuhiro Iwamatsu iwama...@nigauri.org Tested-by: Florian Fainelli flor...@openwrt.org Signed-off-by: Ezequiel Garcia ezequiel.gar...@free

[PATCH v2 2/3] arm: mvebu: Enable USB controllers on Armada 370/XP boards

2013-01-23 Thread Ezequiel Garcia
: Gregory CLEMENT gregory.clem...@free-electrons.com Tested-by: Nobuhiro Iwamatsu iwama...@nigauri.org Tested-by: Florian Fainelli flor...@openwrt.org Signed-off-by: Ezequiel Garcia ezequiel.gar...@free-electrons.com --- Changes from v1: * Squashed separate per-board patches into this one

Re: [PATCH v2 2/3] arm: mvebu: Enable USB controllers on Armada 370/XP boards

2013-01-23 Thread Ezequiel Garcia
Hi Nobuhiro, On Wed, Jan 23, 2013 at 12:26 PM, Ezequiel Garcia ezequiel.gar...@free-electrons.com wrote: This patch activates every USB port provided by each SoC. Except for Armada XP Openblocks AX3-4 board, where we enable only the first two USB ports until we have more information

Re: [PATCH v2 1/3] arm: mvebu: Add support for USB host controllers in Armada 370/XP

2013-01-23 Thread Ezequiel Garcia
Jason, On Wed, Jan 23, 2013 at 12:26 PM, Ezequiel Garcia ezequiel.gar...@free-electrons.com wrote: The Armada 370 and Armada XP SoC has an Orion EHCI USB controller. This patch adds support for this controller in Armada 370 and Armada XP SoC common device tree files. Cc: Lior Amsalem al

Re: [PATCH v2 2/3] arm: mvebu: Enable USB controllers on Armada 370/XP boards

2013-01-23 Thread Ezequiel Garcia
Hi Thomas, On Wed, Jan 23, 2013 at 3:03 PM, Thomas Petazzoni thomas.petazz...@free-electrons.com wrote: On Wed, 23 Jan 2013 14:04:42 -0300, Ezequiel Garcia wrote: from the OpenBlocks AX3-4 board dts file, since you mentioned this board uses that USB port for a PCIe connector -- if I

Re: [PATCH 5/6] arm: mvebu: Enable USB controllers on Armada XP OpenBlocks AX3-4 board

2013-01-16 Thread Ezequiel Garcia
Hi Nobuhiro, On Tue, Jan 15, 2013 at 9:01 PM, Nobuhiro Iwamatsu iwama...@nigauri.org wrote: Hi, On Tue, Jan 15, 2013 at 6:54 PM, Ezequiel Garcia ezequiel.gar...@free-electrons.com wrote: Cc: Lior Amsalem al...@marvell.com Cc: Thomas Petazzoni thomas.petazz...@free-electrons.com Cc

[PATCH 2/6] arm: mvebu: Enable USB controllers on Armada 370 evaluation board

2013-01-15 Thread Ezequiel Garcia
Cc: Lior Amsalem al...@marvell.com Cc: Thomas Petazzoni thomas.petazz...@free-electrons.com Cc: Gregory CLEMENT gregory.clem...@free-electrons.com Signed-off-by: Ezequiel Garcia ezequiel.gar...@free-electrons.com --- arch/arm/boot/dts/armada-370-db.dts |8 1 files changed, 8

[PATCH 4/6] arm: mvebu: Enable USB controllers on Armada XP evaluation board

2013-01-15 Thread Ezequiel Garcia
Cc: Lior Amsalem al...@marvell.com Cc: Thomas Petazzoni thomas.petazz...@free-electrons.com Cc: Gregory CLEMENT gregory.clem...@free-electrons.com Signed-off-by: Ezequiel Garcia ezequiel.gar...@free-electrons.com --- arch/arm/boot/dts/armada-xp-db.dts | 12 1 files changed, 12

[PATCH 5/6] arm: mvebu: Enable USB controllers on Armada XP OpenBlocks AX3-4 board

2013-01-15 Thread Ezequiel Garcia
Cc: Lior Amsalem al...@marvell.com Cc: Thomas Petazzoni thomas.petazz...@free-electrons.com Cc: Gregory CLEMENT gregory.clem...@free-electrons.com Signed-off-by: Ezequiel Garcia ezequiel.gar...@free-electrons.com --- arch/arm/boot/dts/armada-xp-openblocks-ax3-4.dts |9 + 1 files

[PATCH 1/6] arm: mvebu: Add support for USB host controllers in Armada 370/XP

2013-01-15 Thread Ezequiel Garcia
gregory.clem...@free-electrons.com Signed-off-by: Ezequiel Garcia ezequiel.gar...@free-electrons.com --- arch/arm/boot/dts/armada-370-xp.dtsi | 15 +++ arch/arm/boot/dts/armada-370.dtsi|9 + arch/arm/boot/dts/armada-xp.dtsi | 17 + arch/arm/mach-mvebu

[PATCH 6/6] arm: mvebu: Update defconfig to select USB support

2013-01-15 Thread Ezequiel Garcia
Cc: Lior Amsalem al...@marvell.com Cc: Thomas Petazzoni thomas.petazz...@free-electrons.com Cc: Gregory CLEMENT gregory.clem...@free-electrons.com Signed-off-by: Ezequiel Garcia ezequiel.gar...@free-electrons.com --- arch/arm/configs/mvebu_defconfig |5 - 1 files changed, 4 insertions

[PATCH 0/6] arm: mvebu: Add support for USB host controllers in Armada 370/XP

2013-01-15 Thread Ezequiel Garcia
Hi, This small patch set enables USB support on Armada 370 and Armada XP platforms. It's based on Jason Cooper's mvebu/dt branch. Any comments or feedback are welcome. Ezequiel Garcia (6): arm: mvebu: Add support for USB host controllers in Armada 370/XP arm: mvebu: Enable USB controllers

Re: [PATCH 1/6] arm: mvebu: Add support for USB host controllers in Armada 370/XP

2013-01-15 Thread Ezequiel Garcia
Hi Florian, On 01/15/2013 07:23 AM, Florian Fainelli wrote: Le 01/15/13 10:54, Ezequiel Garcia a écrit : diff --git a/arch/arm/mach-mvebu/Kconfig b/arch/arm/mach-mvebu/Kconfig index 440b13e..5e4fcde 100644 --- a/arch/arm/mach-mvebu/Kconfig +++ b/arch/arm/mach-mvebu/Kconfig @@ -24,6 +24,7

Re: [PATCH 2/6] arm: mvebu: Enable USB controllers on Armada 370 evaluation board

2013-01-15 Thread Ezequiel Garcia
Hi Arnd, On 01/15/2013 10:07 AM, Arnd Bergmann wrote: On Tuesday 15 January 2013, Ezequiel Garcia wrote: Cc: Lior Amsalem al...@marvell.com Cc: Thomas Petazzoni thomas.petazz...@free-electrons.com Cc: Gregory CLEMENT gregory.clem...@free-electrons.com Signed-off-by: Ezequiel Garcia