Re: cdc_ether 3-2:1.0 enx0c5b8f279a64: kevent 12 may have been dropped

2018-01-03 Thread Greg KH
On Wed, Jan 03, 2018 at 12:59:53PM -0300, Cristian wrote: > Hello, > > I am testing the development version: > 4.15.0-041500rc6-generic > > [ 116.907874] cdc_ether 3-2:1.0 enx0c5b8f279a64: kevent 12 may have > been dropped > [ 116.907892] cdc_ether 3-2:1.0 enx0c5b8f279a64: kevent 12 may have >

Re: 4.14.10-gentoo-r1 breaks Heimdall + cups functionality

2018-01-02 Thread Greg KH
A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing in e-mail? A: No. Q: Should I include quotations after my reply? http://daringfireball.net/2007/07/on_top On Tue, Jan 02, 2018 at

Re: Second Try, as you will not accept not text mails: 4.14.10-gentoo-r1 breaks cups functionality

2018-01-02 Thread Greg KH
text emails work great, it's html emails that do not :) On Mon, Jan 01, 2018 at 11:12:24PM +0100, Roman Gruber wrote: > I send you  my bug because kernel.org bugzilla pointed me here. >   >

[GIT PULL] USB/PHY driver fixes for 4.15-rc6

2017-12-31 Thread Greg KH
The following changes since commit 1291a0d5049dbc06baaaf66a9ff3f53db493b19b: Linux 4.15-rc4 (2017-12-17 18:59:59 -0800) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git/ tags/usb-4.15-rc6 for you to fetch changes up to

Re: [PATCH v3 03/49] usb: dwc2: Remove version check in GSNPSID

2017-12-30 Thread Greg KH
On Fri, Dec 29, 2017 at 07:56:18PM +, Minas Harutyunyan wrote: > Hi Greg, > > On 12/29/2017 8:59 PM, Greg KH wrote: > > On Tue, Dec 26, 2017 at 03:22:05PM +0400, Grigor Tovmasyan wrote: > >> From: Gevorg Sahakyan <sahak...@synopsys.com> > >> > &

Re: My wireless all-in-one (keyboard/mouse) requires a triple-tap to highlight a word

2017-12-29 Thread Greg KH
On Fri, Dec 29, 2017 at 09:22:40AM +1100, Xavion wrote: > Hi All, > > For the last couple of months or so, my Microsoft (wireless) > All-in-One Media Keyboard has required a triple-tap on the trackpad to > highlight a single word of text. It only used to need a double-tap > (as you'd expect), so

Re: [PATCH v3 03/49] usb: dwc2: Remove version check in GSNPSID

2017-12-29 Thread Greg KH
On Tue, Dec 26, 2017 at 03:22:05PM +0400, Grigor Tovmasyan wrote: > From: Gevorg Sahakyan > > Only check the ID portion of the GSNPSID register and don’t check > the version. This will allow the driver to work with version 4.00a > and later of the DWC_hsotg IP. > > Cc:

Re: cdc_ether 3-2:1.0 enx0c5b8f279a64: kevent 12 may have been dropped

2017-12-27 Thread Greg KH
On Wed, Dec 27, 2017 at 04:07:36PM -0300, Cristian wrote: > Hello, > > Report: > https://bugzilla.kernel.org/show_bug.cgi?id=198291 > > dmesg: > [ 5519.779175] cdc_ether 3-2:1.0 enx0c5b8f279a64: kevent 12 may have > been dropped > [ 5519.779186] cdc_ether 3-2:1.0 enx0c5b8f279a64: kevent 12 may

Re: usb: gadget: function: f_rndis:use dev_kfree_skb_irq instead of dev_kfree_skb

2017-12-22 Thread Greg KH
On Fri, Dec 22, 2017 at 04:44:48PM +0800, lpc.li wrote: > We can't use kfree_skb in irq disable context, because spin_lock_irqsave > make sure we are always in irq disable context, use dev_kfree_skb_irq > instead of kfree_skb is better than dev_kfree_skb_any. Ok, but your patch uses: > -

Re: [usb gadget]use dev_kfree_skb_irq instead of dev_kfree_skb

2017-12-21 Thread Greg KH
On Fri, Dec 22, 2017 at 03:43:15PM +0800, lpc.li wrote: > Hi, > Ethernet Gadget (with CDC Ethernet support) and RNDIS support, device > is Hisilicon asic and host is PC Windows. Howerver, it has one > warning. In the rndis_add_header of the file f_rndis.c, > dev_kfree_skb_irq replaces

Re: Configuring laptop as slave device over USB-C

2017-12-21 Thread Greg KH
On Thu, Dec 21, 2017 at 01:29:15PM -0800, Kerrick Staley wrote: > I'd like to configure my Dell Precision 5520 laptop as a USB slave > device via its USB-C port so that I can connect it to another computer > and transfer data between them. I'm doing this as a hobby project so I > can learn how to

Re: [PATCH] drivers: usb: host: Fix GFP_KERNEL in spinlock context

2017-12-21 Thread Greg KH
On Fri, Dec 22, 2017 at 11:19:24AM +0530, shrikant.mau...@techveda.org wrote: > From: Shrikant Maurya > > As reported by Jia-Ju Bai (https://lkml.org/lkml/2017/12/11/872): > API's are using GFP_KERNEL to allocate memory, which may sleep. > To ensure atomicity such

Re: [GIT PULL] usb: chipidea fix for v4.15-rc5

2017-12-19 Thread Greg KH
On Tue, Dec 19, 2017 at 05:01:39PM +0800, Peter Chen wrote: > The following changes since commit 72b663a99c074a8d073e7ecdae446cfb024ef551: > > usb: xhci: fix TDS for MTK xHCI1.1 (2017-12-08 18:26:34 +0100) > > are available in the git repository at: > >

Re: Mixer regression with usb soundcard

2017-12-18 Thread Greg KH
On Sun, Dec 17, 2017 at 06:56:05PM +, Mauro Santos wrote: > I believe this is the right place to report this problem, but if it > isn't please point me in the right direction. Adding the developer of that patch, and the sound maintainer and developers to the thread. > I have noticed that

Re: [BUG] Kernel 4.14.3-300 breaks Roccat mouse drivers

2017-12-16 Thread Greg KH
On Sat, Dec 16, 2017 at 04:15:33PM +, Gianfranco Cecconi wrote: > The issue was solved in kernel 4.14.5. Thanks to anybody who worked on this. No idea what fixed it :) > @gregkh, at the time I bought the mouse, the configurable keys did not work > without the drivers. I did not realise that

[GIT PULL] USB driver fixes for 4.15-rc4

2017-12-15 Thread Greg KH
The following changes since commit 50c4c4e268a2d7a3e58ebb698ac74da0de40ae36: Linux 4.15-rc3 (2017-12-10 17:56:26 -0800) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git/ tags/usb-4.15-rc4 for you to fetch changes up to

Re: [BUG] Kernel 4.14.3-300 breaks Roccat mouse drivers

2017-12-14 Thread Greg KH
On Thu, Dec 14, 2017 at 08:37:15AM +, Gianfranco Cecconi wrote: > Hi All, I was asked to send here a bug I originally posted at > https://bugzilla.kernel.org/show_bug.cgi?id=198155 . > > I've been using for a couple of years these Roccat drivers > https://sourceforge.net/projects/roccat/ with

Re: [PATCH 1/4] Staging: rtl8723bs: Replace true with x and false with !x

2017-12-13 Thread Greg KH
On Wed, Dec 13, 2017 at 05:25:42PM +0530, Shreeya Patel wrote: > Replace true and false keywords with "x" and "!x" > respectively to follow the kernel coding style. > > Signed-off-by: Shreeya Patel > --- > drivers/staging/rtl8723bs/hal/sdio_ops.c | 30

Re: [PATCH] USB: core: prevent malicious bNumInterfaces overflow

2017-12-13 Thread Greg KH
On Tue, Dec 12, 2017 at 02:25:13PM -0500, Alan Stern wrote: > A malicious USB device with crafted descriptors can cause the kernel > to access unallocated memory by setting the bNumInterfaces value too > high in a configuration descriptor. Although the value is adjusted > during parsing, this

Re: [PATCH] usbip: fix usbip bind writing random string after command in match_busid

2017-12-13 Thread Greg KH
On Wed, Dec 13, 2017 at 11:16:03AM +0100, Juan Zea wrote: > usbip bind writes commands followed by random string when writing to > match_busid attribute in sysfs, caused by using full variable size > instead of string length. > > Signed-off-by: Juan Zea > --- >

Re: [PATCH] USB: core: prevent malicious bNumInterfaces overflow

2017-12-12 Thread Greg KH
On Wed, Dec 13, 2017 at 09:27:42AM +0800, Peter Chen wrote: > On Tue, Dec 12, 2017 at 02:25:13PM -0500, Alan Stern wrote: > > A malicious USB device with crafted descriptors can cause the kernel > > to access unallocated memory by setting the bNumInterfaces value too > > high in a configuration

Re: Add your device DWM-222 to a proper driver

2017-12-12 Thread Greg KH
On Wed, Dec 13, 2017 at 08:18:41AM +0100, martin.er...@centrum.cz wrote: > Dear linux development, > > please to add device to a proper driver. I wrote this requirement according > log list message. > > My USB modem is D-link DWM-222 > > Vendor    3G Standard    Default     Id        Modem Id  

Re: minor bug in usbip tool

2017-12-12 Thread Greg KH
On Tue, Dec 12, 2017 at 04:04:27PM +0100, Juan Zea wrote: > Hi, > > I've being taking a deep look at the code in the usbip tool and found this > small bug at > https://github.com/torvalds/linux/blob/master/tools/usb/usbip/src/utils.c : > > 44 rc =

[PATCH] USB: core: only clean up what we allocated

2017-12-11 Thread Greg KH
From: Andrey Konovalov When cleaning up the configurations, make sure we only free the number of configurations and interfaces that we could have allocated. Reported-by: Andrey Konovalov Cc: stable Signed-off-by: Greg

Re: usb_storage stuck on an I/O error

2017-12-10 Thread Greg KH
On Sun, Dec 10, 2017 at 02:17:06AM +0100, Adam Borowski wrote: > Hi guys! > I have a μSD card that 100%-reproducibly causes the following when tested > with f3probe: > > [ 9241.126155] usb 2-1: new high-speed USB device number 3 using ehci-pci > [ 9241.287011] usb 2-1: New USB device found,

Re: [PATCH v2 09/14] usb: xhci: Add DbC support in xHCI driver

2017-12-08 Thread Greg KH
On Fri, Dec 08, 2017 at 07:44:49PM +0200, Mathias Nyman wrote: > From: Lu Baolu > > xHCI compatible USB host controllers(i.e. super-speed USB3 controllers) > can be implemented with the Debug Capability(DbC). It presents a debug > device which is fully compliant with

Re: [PATCH 09/14] usb: xhci: Add DbC support in xHCI driver

2017-12-08 Thread Greg KH
On Fri, Dec 08, 2017 at 05:59:10PM +0200, Mathias Nyman wrote: > From: Lu Baolu > > xHCI compatible USB host controllers(i.e. super-speed USB3 controllers) > can be implemented with the Debug Capability(DbC). It presents a debug > device which is fully compliant with

Re: [PATCH 0/4] USB over IP Secuurity fixes

2017-12-08 Thread Greg KH
f we should proceed with a coordinated disclosure. I'm > > not quite sure how many distros / downstreams actually use this > > functionality. > > I believe so. We have to get these into mainline and propagate them into > stables first which could take a couple of weeks. > >

Re: [PATCH v2 0/8] lsusb: Add initial support for USB Audio Class 3

2017-12-08 Thread Greg KH
On Fri, Dec 08, 2017 at 03:57:30PM +0100, Greg KH wrote: > On Fri, Dec 08, 2017 at 02:44:12PM +, Michael Drake wrote: > > On 08/12/17 14:27, Greg KH wrote: > > > On Fri, Dec 08, 2017 at 10:30:43AM +, Michael Drake wrote: > > > > On 07/12/17 20:04, Greg KH w

Re: [PATCH v2 0/8] lsusb: Add initial support for USB Audio Class 3

2017-12-08 Thread Greg KH
On Fri, Dec 08, 2017 at 02:44:12PM +, Michael Drake wrote: > On 08/12/17 14:27, Greg KH wrote: > > On Fri, Dec 08, 2017 at 10:30:43AM +, Michael Drake wrote: > > > On 07/12/17 20:04, Greg KH wrote: > > > > > --- lsusb-v.orig2017-12-07 21:01:26.

Re: [PATCH v2 0/8] lsusb: Add initial support for USB Audio Class 3

2017-12-08 Thread Greg KH
On Fri, Dec 08, 2017 at 10:30:43AM +, Michael Drake wrote: > On 07/12/17 20:04, Greg KH wrote: > > On Thu, Dec 07, 2017 at 07:24:35PM +, Michael Drake wrote: > > > On 07/12/17 17:26, Greg KH wrote: > > > > On Thu, Dec 07, 2017 at 05:14:10PM +, Michael Drak

Re: [PATCH v1 1/1] lsusb: Fix array entry count for variable sized entries.

2017-12-08 Thread Greg KH
On Fri, Dec 08, 2017 at 10:10:56AM +, Michael Drake wrote: > On 07/12/17 20:02, Greg KH wrote: > > On Thu, Dec 07, 2017 at 07:18:39PM +, Michael Drake wrote: > > > This fixes a divide by zero which happened when an array, > > > without an explicit entry count

Re: [PATCH 0/4] USB over IP Secuurity fixes

2017-12-07 Thread Greg KH
On Thu, Dec 07, 2017 at 02:16:46PM -0700, Shuah Khan wrote: > Jakub Jirasek from Secunia Research at Flexera reported security > vulnerabilities in the USB over IP driver. This patch series all > the 4 reported problems. Nice! These should also all go to the stable kernels, right? thanks, greg

Re: [PATCH v2 0/8] lsusb: Add initial support for USB Audio Class 3

2017-12-07 Thread Greg KH
On Thu, Dec 07, 2017 at 07:24:35PM +, Michael Drake wrote: > On 07/12/17 17:26, Greg KH wrote: > > On Thu, Dec 07, 2017 at 05:14:10PM +, Michael Drake wrote: > > > On 07/12/17 15:16, Greg KH wrote: > > > > On Thu, Dec 07, 2017 at 04:01:23PM +0100, Greg KH w

Re: [PATCH v1 1/1] lsusb: Fix array entry count for variable sized entries.

2017-12-07 Thread Greg KH
On Thu, Dec 07, 2017 at 07:18:39PM +, Michael Drake wrote: > This fixes a divide by zero which happened when an array, > without an explicit entry count (ultimately calculated from > the value in the descriptor data's bLength field) was used > on field with a variable size. > > The solultion

Re: [PATCH v2 0/8] lsusb: Add initial support for USB Audio Class 3

2017-12-07 Thread Greg KH
On Thu, Dec 07, 2017 at 06:26:30PM +0100, Greg KH wrote: > On Thu, Dec 07, 2017 at 05:14:10PM +, Michael Drake wrote: > > > > > > On 07/12/17 15:16, Greg KH wrote: > > > On Thu, Dec 07, 2017 at 04:01:23PM +0100, Greg KH wrote: > > > > On Thu, Dec 0

Re: [PATCH v2 0/8] lsusb: Add initial support for USB Audio Class 3

2017-12-07 Thread Greg KH
On Thu, Dec 07, 2017 at 05:14:10PM +, Michael Drake wrote: > > > On 07/12/17 15:16, Greg KH wrote: > > On Thu, Dec 07, 2017 at 04:01:23PM +0100, Greg KH wrote: > > > On Thu, Dec 07, 2017 at 04:00:36PM +0100, Greg KH wrote: > > > > On Thu, Dec 07, 2017 at 1

Re: [PATCH v2 0/8] lsusb: Add initial support for USB Audio Class 3

2017-12-07 Thread Greg KH
On Thu, Dec 07, 2017 at 05:11:58PM +, Michael Drake wrote: > > > On 07/12/17 15:00, Greg KH wrote: > > On Thu, Dec 07, 2017 at 10:26:21AM +, Michael Drake wrote: > > > This adds a new way of dumping descriptors, which splits the knowledge > > > of how

Re: [PATCH v1 0/2] lsusb: Squash warnings from UAC3 merge.

2017-12-07 Thread Greg KH
On Thu, Dec 07, 2017 at 05:07:17PM +, Michael Drake wrote: > This series is to fix some warnings reported by Greg. Thanks, all applied. greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH v2 0/8] lsusb: Add initial support for USB Audio Class 3

2017-12-07 Thread Greg KH
On Thu, Dec 07, 2017 at 04:01:23PM +0100, Greg KH wrote: > On Thu, Dec 07, 2017 at 04:00:36PM +0100, Greg KH wrote: > > On Thu, Dec 07, 2017 at 10:26:21AM +, Michael Drake wrote: > > > This adds a new way of dumping descriptors, which splits the knowledge > > > of

Re: [PATCH v2 0/8] lsusb: Add initial support for USB Audio Class 3

2017-12-07 Thread Greg KH
On Thu, Dec 07, 2017 at 04:00:36PM +0100, Greg KH wrote: > On Thu, Dec 07, 2017 at 10:26:21AM +, Michael Drake wrote: > > This adds a new way of dumping descriptors, which splits the knowledge > > of how to interpret descriptor data from the actual dumping. This has >

Re: [PATCH v2 0/8] lsusb: Add initial support for USB Audio Class 3

2017-12-07 Thread Greg KH
On Thu, Dec 07, 2017 at 10:26:21AM +, Michael Drake wrote: > This adds a new way of dumping descriptors, which splits the knowledge > of how to interpret descriptor data from the actual dumping. This has > two advantages: > > 1. It is easy to add support for new descriptors, since they are

Re: usb device implemented with functionfs - must app run as root?

2017-12-06 Thread Greg KH
On Wed, Dec 06, 2017 at 07:26:13PM +0100, Krzysztof Opasiak wrote: > > > On 12/06/2017 07:26 AM, Greg KH wrote: > > On Tue, Dec 05, 2017 at 10:09:35PM +, andy_purc...@keysight.com wrote: > > > I have implemented a USB device using functionfs. > > > A co

Re: [PATCH v1 5/8] lsusb: Add descriptor definitions for UAC3.

2017-12-06 Thread Greg KH
On Wed, Dec 06, 2017 at 04:52:37PM +, Michael Drake wrote: > > > On 05/12/17 16:39, Greg KH wrote: > > On Tue, Dec 05, 2017 at 04:14:28PM +, Michael Drake wrote: > > > --- > > > desc-defs.c | 277 > > > ++

Re: [PATCH v2] usb: core: Add "quirks" parameter for usbcore

2017-12-06 Thread Greg KH
On Wed, Dec 06, 2017 at 06:26:21PM +0800, Kai-Heng Feng wrote: > Trying quirks in usbcore needs to rebuild the driver or the entire > kernel if it's builtin. It can save a lot of time if usbcore has similar > ability like "usbhid.quirks=" and "usb-storage.quirks=". > > Rename the original quirk

Re: [PATCH] usb: core: Add "quirks" parameter for usbcore

2017-12-06 Thread Greg KH
On Wed, Dec 06, 2017 at 05:09:32PM +0800, Kai-Heng Feng wrote: > +/* Works only for digits and letters, but small and fast */ > +#define TOLOWER(x) ((x) | 0x20) What is wrong with the in-kernel version of tolower()? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe

Re: [PATCH] usb: remove msm_hsusb_hw.h

2017-12-06 Thread Greg KH
On Thu, Nov 02, 2017 at 05:21:41PM -0700, Jack Pham wrote: > The last two remaining drivers (ehci-msm.c and phy-msm-usb.c) that > needed this header were recently removed, so delete this now-unused > file. > > Signed-off-by: Jack Pham > --- >

Re: usb device implemented with functionfs - must app run as root?

2017-12-05 Thread Greg KH
On Tue, Dec 05, 2017 at 10:09:35PM +, andy_purc...@keysight.com wrote: > I have implemented a USB device using functionfs. > A colleague now says our app must run as a normal user, not as root. > > I tried it and it does not work. > The problem is this - the endpoint files created by the OS

Re: [PATCH v1 0/8] lsusb: Add initial support for USB Audio Class 3

2017-12-05 Thread Greg KH
On Tue, Dec 05, 2017 at 04:14:23PM +, Michael Drake wrote: > This adds a new way of dumping descriptors, which splits the knowledge > of how to interpret descriptor data from the actual dumping. This has > two advantages: > > 1. It is easy to add support for new descriptors, since they are

Re: [PATCH v1 8/8] lsusb: Dump USB3 BOS Configuration Summary Descriptor.

2017-12-05 Thread Greg KH
On Tue, Dec 05, 2017 at 04:14:31PM +, Michael Drake wrote: > --- > lsusb.c | 6 ++ > 1 file changed, 6 insertions(+) And here. > > diff --git a/lsusb.c b/lsusb.c > index c9d0d74..ddc19e0 100644 > --- a/lsusb.c > +++ b/lsusb.c > @@ -75,6 +75,7 @@ > #define USB_DC_PLATFORM

Re: [PATCH v1 7/8] lsusb: Add descriptor definition for USB3 BOS Configuration Summary.

2017-12-05 Thread Greg KH
On Tue, Dec 05, 2017 at 04:14:30PM +, Michael Drake wrote: > --- > desc-defs.c | 16 > desc-defs.h | 3 +++ > 2 files changed, 19 insertions(+) Same here, some text please. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to

Re: [PATCH v1 6/8] lsusb: Add initial support for UAC3.

2017-12-05 Thread Greg KH
On Tue, Dec 05, 2017 at 04:14:29PM +, Michael Drake wrote: > --- > lsusb.c | 52 ++-- > 1 file changed, 34 insertions(+), 18 deletions(-) Again, some changelog text please. -- To unsubscribe from this list: send the line "unsubscribe linux-usb"

Re: [PATCH v1 5/8] lsusb: Add descriptor definitions for UAC3.

2017-12-05 Thread Greg KH
On Tue, Dec 05, 2017 at 04:14:28PM +, Michael Drake wrote: > --- > desc-defs.c | 277 > > desc-defs.h | 3 + > desc-dump.c | 5 ++ > 3 files changed, 270 insertions(+), 15 deletions(-) We need some kind of changelog text here

Re: [PATCH v1 4/8] lsusb: Switch to descriptor-definition based dump for UAC1 and UAC2.

2017-12-05 Thread Greg KH
On Tue, Dec 05, 2017 at 04:14:27PM +, Michael Drake wrote: > This gives us more consistency in handling of incorrect descriptor > buffer lengths, and improves whitespace/alignment consistency. > --- > Makefile.am | 2 + > lsusb.c | 779 >

Re: [PATCH v1 3/8] lsusb: Add code to dump descriptor data using descriptor definition.

2017-12-05 Thread Greg KH
On Tue, Dec 05, 2017 at 04:14:26PM +, Michael Drake wrote: > This adds a new way of dumping descriptors. It takes the descriptor > data to be dumped, and a descriptor definition as input. > > The descriptor definition takes the form of a NULL terminated array > of descriptor field

Re: [PATCH v1 2/8] lsusb: Add declarative definitions for UAC1 and UAC2 descriptors.

2017-12-05 Thread Greg KH
On Tue, Dec 05, 2017 at 04:14:25PM +, Michael Drake wrote: > These descriptor definitions descibe how raw descriptor data > should be interpreted. > --- > desc-defs.c | 647 > > desc-defs.h | 153 ++ > 2 files changed,

Re: [PATCH v1 1/8] lsusb: Split subtype mapping out of AudioControl interface handling.

2017-12-05 Thread Greg KH
On Tue, Dec 05, 2017 at 04:14:24PM +, Michael Drake wrote: > UAC1 and UAC2 have different different meanings for the same subtype > value. This splits the subtype mapping out. > --- Minor nit, can you sign-off on your patches like kernel patches have? That way I know you are contributing

Re: [debian bug:883345] vhci-hcd: kernel oops when attaching a mass storage on client side of usbip

2017-12-05 Thread Greg KH
On Tue, Dec 05, 2017 at 10:17:08AM +0200, borissh1...@gmail.com wrote: > On Tuesday, 5 December 2017 9:39:33 IST Greg KH wrote: > > On Mon, Dec 04, 2017 at 10:05:45PM +0200, borissh1...@gmail.com wrote: > > > Hi , > > > > > > vhci-hcd kernel oops when

[GIT PULL] USB driver fixes for 4.15-rc3

2017-12-05 Thread Greg KH
The following changes since commit 4fbd8d194f06c8a3fd2af1ce560ddb31f7ec8323: Linux 4.15-rc1 (2017-11-26 16:01:47 -0800) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git/ tags/usb-4.15-rc3 for you to fetch changes up to

Re: Rectifying: xhci_hcd 0000:00:14.0: Timeout while waiting for setup device command

2017-12-05 Thread Greg KH
On Tue, Dec 05, 2017 at 01:38:02PM +0100, Luca Osvaldo Mastromatteo wrote: > Hi, I've reported some problems I'm having with this driver to the > linux kernel bugzilla and they gave me this mail, so I'm copying and > paste the issue I wrote in there. Thanks > > 'I've recently bought an USB 3.0

Re: [PATCH v9] xhci : AMD Promontory USB disable port support

2017-12-05 Thread Greg KH
On Tue, Dec 05, 2017 at 05:20:56PM +0800, Joe Lee wrote: > Dear Greg: > I am sorry if this has caused you any inconvenience. > I can't understand what is a good line-wrapping. > Can you check the line-wrapping for me? > > > For AMD Promontory xHCI host, > > although you can disable USB 2.0 ports

Re: [debian bug:883345] vhci-hcd: kernel oops when attaching a mass storage on client side of usbip

2017-12-04 Thread Greg KH
On Mon, Dec 04, 2017 at 10:05:45PM +0200, borissh1...@gmail.com wrote: > Hi , > > vhci-hcd kernel oops when attaching a mass storage on 4.13.13. > > When I try to attach a mass storage device to a vhci-hcd, it generates an > oops. no problem with other devices. > > A second user had also

Re: [PATCH v9] xhci : AMD Promontory USB disable port support

2017-12-04 Thread Greg KH
On Mon, Dec 04, 2017 at 04:49:33PM +0800, Joe Lee wrote: > For AMD Promontory xHCI host, > although you can disable USB 2.0 ports in BIOSsettings, > those ports will be enabled anyway after you remove a device on > that port and re-plug it in again. It's a known limitation of the chip. > As a

Re: [PATCH v8] xhci : AMD Promontory USB disable port support

2017-12-01 Thread Greg KH
A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing in e-mail? A: No. Q: Should I include quotations after my reply? http://daringfireball.net/2007/07/on_top On Fri, Dec 01, 2017 at

Re: [PATCH v8] xhci : AMD Promontory USB disable port support

2017-12-01 Thread Greg KH
On Fri, Dec 01, 2017 at 11:54:20AM +0800, Joe Lee wrote: > Signed-off-by: Joe Lee > --- I can't take patches without any changelog text at all. Please fix that up. Also always list what the difference between this and the previous versions below the --- line. How to do

Re: [PATCH] usbip: fix usbip attach to find a port that matches the requested speed

2017-11-30 Thread Greg KH
On Wed, Nov 29, 2017 at 03:24:22PM -0700, Shuah Khan wrote: > usbip attach fails to find a free port when the device on the first port > is a USB_SPEED_SUPER device and non-super speed device is being attached. > It keeps checking the first port and returns without a match getting stuck > in a

Re: drivers/net/usb/r8152.c USB net driver outdated

2017-11-28 Thread Greg KH
On Tue, Nov 28, 2017 at 07:51:06PM -0700, Cameron Seader wrote: > Greetings, > The upstream kernel seems to be outdated with version 1.09.9 of the > drivers/net/usb/r8152.c driver. There is newer hardware now which requires > the newer version where running with the old one becomes unstable. For >

Re: very slow USB security token access after switch from 2.6.13 to 4.4.52

2017-11-28 Thread Greg KH
On Sun, Nov 26, 2017 at 07:05:12PM +0100, Nikola Ciprich wrote: > Hello dear linux USB users and developers, > > I've got a bit desperate question, but maybe somebody will have > some idea on what to try.. > > we're migrating lots (thousands) of users from very old opensuse running > 2.6.13

Re: [PATCHv2] USB: usbfs: Filter flags passed in from user space

2017-11-28 Thread Greg KH
On Thu, Nov 23, 2017 at 10:53:13AM -0500, Alan Stern wrote: > On Thu, 23 Nov 2017, Oliver Neukum wrote: > > > USBDEVFS_URB_ISO_ASAP must be accepted only for ISO endpoints. > > Improve sanity checking. > > > > Reported-by: andreyk...@google.com > > This should be > > Reported-by: Andrey

Re: EHCI and MUSB do not discover devices without CONFIG_PM

2017-11-28 Thread Greg KH
On Tue, Nov 28, 2017 at 09:57:51AM +0100, Ladislav Michl wrote: > Hi Greg, > > On Tue, Nov 28, 2017 at 08:33:28AM +0100, Greg KH wrote: > > On Mon, Nov 27, 2017 at 11:08:33PM +0100, Ladislav Michl wrote: > > > Hi there, > > > > > > USB hosts do not di

Re: EHCI and MUSB do not discover devices without CONFIG_PM

2017-11-27 Thread Greg KH
On Mon, Nov 27, 2017 at 11:08:33PM +0100, Ladislav Michl wrote: > Hi there, > > USB hosts do not discover any connected device on OMAP3 based board > with CONFIG_PM=n. Just enabling this option is enough to restore working > behaviour. Nothing unusual in log. Tested 4.14.2 and 4.15-rc1. I know >

Re: Fwd: Performance regression in dwc3 ecm for linux 4.4.60

2017-11-27 Thread Greg KH
On Tue, Nov 28, 2017 at 09:48:57AM +0530, Arjav Parikh wrote: > Hi Team, > > Hope you all are doing good. > > Currently I am facing an bandwidth issue in dwc3 driver using ecm > gadget with linux kernel version 4.4. > > I will quickly brief through my problem and the troubleshooting steps >

Re: [PATCH] usbhid: add quirk for another PIXART OEM mouse used by HP

2017-11-27 Thread Greg KH
On Mon, Nov 27, 2017 at 09:16:31AM +0100, Benjamin Tissoires wrote: > On Nov 25 2017 or thereabouts, Dave Young wrote: > > This mouse keep disconnecting in runleve 3 like below, add it needs the > > quirk to mute the anoying messages. > > > > [ 111.230555] usb 2-2: USB disconnect, device number

Re: [PATCH] [stable only]USB: fix buffer overflows with parsing CDC headers

2017-11-24 Thread Greg KH
On Thu, Nov 23, 2017 at 04:20:05PM +0100, Oliver Neukum wrote: > Parsing CDC headers a buffer overflow cannot just be prevented > by checking that the remainder of the buffer is longer than minimum > length. The size of the fields to be parsed must be figured in, too. > > In newer kernels this

Re: [PATCH] r8152: disable rx checksum offload on Dell TB dock

2017-11-24 Thread Greg KH
On Fri, Nov 24, 2017 at 09:28:05AM +0100, Greg KH wrote: > On Fri, Nov 24, 2017 at 11:44:02AM +0800, Kai Heng Feng wrote: > > > > > > > On 23 Nov 2017, at 5:24 PM, Greg KH <gre...@linuxfoundation.org> wrote: > > > > > > On Thu, Nov 2

Re: [PATCH] r8152: disable rx checksum offload on Dell TB dock

2017-11-24 Thread Greg KH
On Fri, Nov 24, 2017 at 11:44:02AM +0800, Kai Heng Feng wrote: > > > > On 23 Nov 2017, at 5:24 PM, Greg KH <gre...@linuxfoundation.org> wrote: > > > > On Thu, Nov 23, 2017 at 04:53:41PM +0800, Kai Heng Feng wrote: > >> > >> What I want to do

usbutils 009 release

2017-11-23 Thread Greg KH
The 009 release of usbutils happened about a month ago, but I forgot to announce it anywhere, and also forgot to upload the tarball to kernel.org until today. So here's the belated announcement of the 009 release of usbutils. It's been a few years since the last release, sorry about that, didn't

Re: [PATCH] USB: usbfs: Filter flags passed in from user space

2017-11-23 Thread Greg KH
On Thu, Nov 23, 2017 at 04:06:28PM +0100, Oliver Neukum wrote: > Am Donnerstag, den 23.11.2017, 15:57 +0100 schrieb Greg KH: > > On Thu, Nov 23, 2017 at 03:28:34PM +0100, Oliver Neukum wrote: > > > > > > USBDEVFS_URB_ISO_ASAP must be accepted only for ISO endpoints. &g

Re: [PATCH] USB: usbfs: Filter flags passed in from user space

2017-11-23 Thread Greg KH
On Thu, Nov 23, 2017 at 03:28:34PM +0100, Oliver Neukum wrote: > USBDEVFS_URB_ISO_ASAP must be accepted only for ISO endpoints. > Improve sanity checking. > > Signed-off-by: Oliver Neukum > --- > drivers/usb/core/devio.c | 16 ++-- > 1 file changed, 10

Re: [PATCH] r8152: disable rx checksum offload on Dell TB dock

2017-11-23 Thread Greg KH
On Thu, Nov 23, 2017 at 04:53:41PM +0800, Kai Heng Feng wrote: > > > On 23 Nov 2017, at 3:58 PM, Greg KH <gre...@linuxfoundation.org> wrote: > > > > On Thu, Nov 23, 2017 at 01:38:38AM -0500, Kai-Heng Feng wrote: > >> r8153 on Dell TB dock corrupts r

Re: [PATCH] r8152: disable rx checksum offload on Dell TB dock

2017-11-22 Thread Greg KH
On Thu, Nov 23, 2017 at 01:38:38AM -0500, Kai-Heng Feng wrote: > r8153 on Dell TB dock corrupts rx packets. > > The root cause is not found yet, but disabling rx checksumming can > workaround the issue. We can use this connection to decide if it's > a Dell TB dock: > Realtek r8153 <-> SMSC hub

Re: [PATCH v7] xhci : AMD Promontory USB disable port support

2017-11-22 Thread Greg KH
On Wed, Nov 22, 2017 at 05:45:14PM +0800, Joe Lee wrote: > For AMD Promontory xHCI host, > although you can disable USB 2.0 ports in BIOSsettings, > those ports will be enabled anyway after you remove a device on > that port and re-plug it in again. It's a known limitation of the chip. > As a

Re: [PATCH] USB: option: add Quectel BG96 2c7c:0296

2017-11-19 Thread Greg KH
On Sun, Nov 19, 2017 at 08:40:28PM +0100, ssjoh...@mac.com wrote: > From: ssjoholm > > Signed-off-by: ssjoholm This goes at the bottom of the changelog text. And we need a real name, I doubt you use this to sign legal documents. > Quectel BG96 is an

Re: INFO: task gpartedbin:1832 blocked for more than 120 seconds.

2017-11-17 Thread Greg KH
On Fri, Nov 17, 2017 at 09:59:00AM -0300, Cristian wrote: > Hello, > > [ 243.044590] INFO: task gpartedbin:1832 blocked for more than 120 seconds. > [ 243.044603] Not tainted 4.14.0-041400-generic #201711122031 > [ 243.044606] "echo 0 > /proc/sys/kernel/hung_task_timeout_secs" > disables

Re: 8k interrupts/sec with USB hub

2017-11-15 Thread Greg KH
On Wed, Nov 15, 2017 at 02:58:00PM +, Billy Araujo wrote: > Hi Greg, > > 1. What kernel version are you using here? > > Sorry about the lack of info. The kernel is: SOCKit: Angstrom v2016.12 > - Kernel 4.1.22-ltsi-altera Oh wow that is old and obsolete. Please go get support from the

Re: 8k interrupts/sec with USB hub

2017-11-15 Thread Greg KH
On Wed, Nov 15, 2017 at 12:12:16PM +, Billy Araujo wrote: > Hi all, > > I built a kernel/rootfs for altera SoCkit amd uses the default SoCkit > device tree and I plug when in plug in a USB stick it uses the dwc2 > driver. What kernel version are you using here? > When doing cat

Re: [GIT PULL] USB/PHY driver changes for 4.15-rc1

2017-11-14 Thread Greg KH
On Tue, Nov 14, 2017 at 03:23:33PM +0200, Heikki Krogerus wrote: > On Mon, Nov 13, 2017 at 09:29:36PM -0800, Linus Torvalds wrote: > > On Mon, Nov 13, 2017 at 8:19 AM, Greg KH <gre...@linuxfoundation.org> wrote: > > > > > > Other major thing is the typ

Re: [GIT PULL] USB/PHY driver changes for 4.15-rc1

2017-11-14 Thread Greg KH
On Tue, Nov 14, 2017 at 08:10:10AM -0800, Guenter Roeck wrote: > On Tue, Nov 14, 2017 at 05:02:53PM +0200, Heikki Krogerus wrote: > > Hi Guenter, > > > > On Tue, Nov 14, 2017 at 06:48:21AM -0800, Guenter Roeck wrote: > > > On 11/14/2017 05:17 AM, Greg KH wrote: >

Re: [GIT PULL] USB/PHY driver changes for 4.15-rc1

2017-11-14 Thread Greg KH
On Mon, Nov 13, 2017 at 09:29:36PM -0800, Linus Torvalds wrote: > On Mon, Nov 13, 2017 at 8:19 AM, Greg KH <gre...@linuxfoundation.org> wrote: > > > > Other major thing is the typec code that moved out of staging and into > > the "real" part of the drivers/us

[GIT PULL] USB/PHY driver changes for 4.15-rc1

2017-11-13 Thread Greg KH
The following changes since commit bb176f67090ca54869fc1262c913aa69d2ede070: Linux 4.14-rc6 (2017-10-23 06:49:47 -0400) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git/ tags/usb-4.15-rc1 for you to fetch changes up to

Re: [PATCH] USB: fix buffer overflows with parsing CDC headers

2017-11-10 Thread Greg KH
On Wed, Nov 08, 2017 at 12:43:07PM +0100, Oliver Neukum wrote: > In newer kernels this issue has been fixed at a central location with > > commit 2e1c42391ff2556387b3cb6308b24f6f65619feb > Author: Greg Kroah-Hartman > Date: Thu Sep 21 16:58:48 2017 +0200 > >

Re: [PATCH] USB: core: Add type-specific length check of BOS descriptors

2017-11-09 Thread Greg KH
On Fri, Nov 10, 2017 at 01:25:50AM +0900, Masakazu Mokuno wrote: > > As most of BOS descriptors are longer in length than their header > 'struct usb_dev_cap_header', comparing solely with it is not sufficient > to avoid out-of-bounds access to BOS descriptors. > > This patch adds descriptor type

Re: next/master boot: 264 boots: 62 failed, 199 passed with 3 conflicts (next-20171109)

2017-11-09 Thread Greg KH
On Thu, Nov 09, 2017 at 01:47:13PM +, Mark Brown wrote: > On Thu, Nov 09, 2017 at 01:45:02PM +, Mark Brown wrote: > > On Thu, Nov 09, 2017 at 04:14:26AM -0800, kernelci.org bot wrote: > > > > Today's -next fails to boot a bcm2836-rpi-2-b on any config in kernelci, > > it was working

Re: [PATCH] usb: gadget: f_fs: Fix use-after-free in ffs_free_inst

2017-11-09 Thread Greg KH
On Wed, Nov 08, 2017 at 10:13:15AM -0700, Andrew Gabbasov wrote: > KASAN enabled configuration reports an error > > BUG: KASAN: use-after-free in ffs_free_inst+... [usb_f_fs] at addr ... > Write of size 8 by task ... > > This is observed after "ffs-test" is run and interrupted. If after that >

Re: WARNING in usb_submit_urb

2017-11-07 Thread Greg KH
On Tue, Nov 07, 2017 at 08:11:13AM -0800, syzbot wrote: > Hello, > > syzkaller hit the following crash on > 36ef71cae353f88fd6e095e2aaa3e5953af1685d > git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/master > compiler: gcc (GCC) 7.1.1 20170620 > .config is attached > Raw console

Re: [PATCH] usb: core: lower log level when device is not able to deal with string

2017-11-07 Thread Greg KH
On Tue, Nov 07, 2017 at 03:58:29AM -0500, Kai-Heng Feng wrote: > USB devices should work just fine when they don't support language id. They still work, but it's a "broken" device, and it should be fixed (I thought it was part of the spec, but I can't find it right now...) > Lower the log level

Re: [PATCH v2] usb:xhci fix panic in xhci_free_virt_devices_depth_first

2017-11-06 Thread Greg KH
On Mon, Nov 06, 2017 at 06:03:08PM +0800, Chen Yu wrote: > Hi, > > On 2017/11/6 16:31, Greg KH wrote: > > On Mon, Nov 06, 2017 at 04:20:23PM +0800, Yu Chen wrote: > >> From: Yu Chen <cheny...@huawei.com> > >> > >> Check vde

Re: [PATCH v2] usb:xhci fix panic in xhci_free_virt_devices_depth_first

2017-11-06 Thread Greg KH
On Mon, Nov 06, 2017 at 04:20:23PM +0800, Yu Chen wrote: > From: Yu Chen > > Check vdev->real_port 0 to avoid panic > [9.261347] [] > xhci_free_virt_devices_depth_first+0x58/0x108 > [9.261352] [] xhci_mem_cleanup+0x1bc/0x570 > [9.261355] [] xhci_stop+0x140/0x1c8

Re: [PATCH] usb:xhci fix panic in xhci_free_virt_devices_depth_first

2017-11-06 Thread Greg KH
On Mon, Nov 06, 2017 at 11:28:55AM +0800, Yu Chen wrote: > From: Yu Chen > > Check vdev->real_port 0 to avoid panic > [9.261347] [] > xhci_free_virt_devices_depth_first+0x58/0x108 > [9.261352] [] xhci_mem_cleanup+0x1bc/0x570 > [9.261355] [] xhci_stop+0x140/0x1c8

Re: Seagate Backup Plus UAS patch

2017-11-05 Thread Greg KH
On Sun, Nov 05, 2017 at 03:00:59PM +0300, Andrey Astafyev wrote: > Hello. Please, add Seagate Backup Plus entry to unusual devices list. > > > diff -ur linux-4.9.orig/drivers/usb/storage/unusual_uas.h > linux-4.9/drivers/usb/storage/unusual_uas.h > ---

<    1   2   3   4   5   6   7   8   9   10   >