Re: stopping and starting a functionfs USB-device causes panic

2017-11-04 Thread Greg KH
On Fri, Nov 03, 2017 at 10:13:17PM +, andy_purc...@keysight.com wrote: > Hello Felipe, > > > > > > > I have a second issue with a functionfs USB-device implementation. > > > > > > The scenario is this: > > > 1) USB-device app starts up, runs fine > > > 2) ssh to the device, kill the app with

Re: Linux and usb device drivers using functionfs

2017-11-02 Thread Greg KH
On Thu, Nov 02, 2017 at 08:43:04PM +, andy_purc...@keysight.com wrote: > Hello, > > > > > > And where is your swap? What happens if you just do not have swap at all? > Our system has no swap. Running 'top' says 0 total, 0 free, 0 used then your program can not get swapped out, so this

Re: Linux and usb device drivers using functionfs

2017-11-02 Thread Greg KH
On Thu, Nov 02, 2017 at 04:37:51PM +, andy_purc...@keysight.com wrote: > > What do you mean by "device app runs to completion"? What is the "device > > app"? Is it the functionfs application you're talking about? And by > > "completion" > > do you mean that it completely stops running or is

Re: xhci_hcd WARN Event TRB for slot ep with no TDs queued?

2017-11-02 Thread Greg KH
On Thu, Nov 02, 2017 at 03:28:19PM +0100, Juan Simón wrote: > Hi, > This is the trace output: https://pastebin.com/apt56yGe > > I'm going to ask in Arch forums to see how I can get the differences of the > xhci_hcd module in both versions of the kernel. The arch kernels are the same as the

Re: [PATCH 1/2 v3] typec: tcpm: Validate source and sink caps

2017-11-01 Thread Greg KH
On Wed, Oct 18, 2017 at 01:22:47PM -0700, Badhri Jagan Sridharan wrote: > The source and sink caps should follow the following rules. > This patch validates whether the src_caps/snk_caps adheres > to it. > > 6.4.1 Capabilities Message > A Capabilities message (Source Capabilities message or Sink

Re: [PATCH v3 0/2] max3421: add devicetree support

2017-11-01 Thread Greg KH
On Tue, Oct 24, 2017 at 01:08:41AM +0200, Jules Maselbas wrote: > Hi, > > This patchset adds devicetree support to the max3421 driver. > Theses modification are based on a previous (unapplied) patch > series by Alexander Amelkin [1]. I've already applied this series, right? If there were any

Re: [PATCH v3] usb: wusbcore: Use put_unaligned_le32

2017-11-01 Thread Greg KH
On Tue, Oct 31, 2017 at 11:41:45PM +0530, Himanshu Jha wrote: > On Tue, Oct 17, 2017 at 05:14:30PM +0530, Himanshu Jha wrote: > > Hi Greg, > > > Use put_unaligned_le32 rather than using byte ordering function and > > memcpy which makes code clear. > > Also, add the header file where it is

Re: Linux and usb device drivers using functionfs

2017-10-31 Thread Greg KH
On Mon, Oct 30, 2017 at 04:51:57PM +, andy_purc...@keysight.com wrote: > Hello, > > I have implemented a USB device function using Linux functionfs and now there > is a problem being reported. > I need to ask this group for advice. > > The problem is this: > 1) device boots > 2) some

Re: xhci_hcd WARN Event TRB for slot ep with no TDs queued?

2017-10-30 Thread Greg KH
On Mon, Oct 30, 2017 at 04:16:29PM +0100, Juan Simón wrote: > Hi, > I have read this thread > (https://marc.info/?l=linux-usb=150056183628924=2) and supposedly > the problem was solved in version 4.13.7 but in my case it's not like > that. > I use Arch Linux. I've tested several versions of kernel

Re: [PATCH 1/4] usb: xhci: Fix build warning

2017-10-26 Thread Greg KH
On Wed, Oct 25, 2017 at 06:32:26PM +, Corentin Labbe wrote: > This patch fix the following build warnings: > drivers/usb/host/xhci.c:3378:6: warning: variable 'last_freed_endpoint' set > but not used [-Wunused-but-set-variable] > > Signed-off-by: Corentin Labbe > --- >

[GIT PULL] USB/PHY driver fixes for 4.14-rc6

2017-10-23 Thread Greg KH
The following changes since commit 33d930e59a98fa10a0db9f56c7fa2f21a4aef9b9: Linux 4.14-rc5 (2017-10-15 21:01:12 -0400) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git/ tags/usb-4.14-rc6 for you to fetch changes up to

Re: [PATCH] usb: "USB Host halt failed, -110" error when rebooting system

2017-10-17 Thread Greg KH
On Tue, Oct 17, 2017 at 07:57:39PM -0500, wenxi...@linux.vnet.ibm.com wrote: > From: Wen Xiong > > > We saw "Host halt failed, -110" error when rebooting system/ > shutdowning system/kexec constantly. > > This patch called usb_disconnect() before calling

Re: [PATCH] usb: Kconfig: clarify use of USB_PCI

2017-10-17 Thread Greg KH
On Tue, Oct 17, 2017 at 12:52:29PM +0100, Chris Mayo wrote: > Signed-off-by: Chris Mayo I can't take patches without any changelog text, sorry. greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to

Re: [PATCH v2] usb: wusbcore: Use put_unaligned_le32

2017-10-17 Thread Greg KH
On Tue, Oct 17, 2017 at 05:20:29PM +0530, Himanshu Jha wrote: > On Tue, Oct 17, 2017 at 11:51:14AM +0200, Greg KH wrote: > > On Fri, Oct 06, 2017 at 08:38:07PM +0530, Himanshu Jha wrote: > > > Use put_unaligned_le32 rather than using byte ordering function and > > > me

Re: [PATCH v2 11/15] stm class: make config_item_type const

2017-10-17 Thread Greg KH
On Mon, Oct 16, 2017 at 05:18:50PM +0200, Bhumika Goyal wrote: > Make config_item_type structures const as they are either passed to a > function having the argument as const or used inside a if statement or > stored in the const "ci_type" field of a config_item structure. > > Done using

Re: [PATCH v2 01/15] configfs: make ci_type field, some pointers and function arguments const

2017-10-17 Thread Greg KH
On Mon, Oct 16, 2017 at 05:18:40PM +0200, Bhumika Goyal wrote: > The ci_type field of the config_item structure do not modify the fields > of the config_item_type structure it points to. And the other pointers > initialized with ci_type do not modify the fields as well. > So, make the ci_type

Re: [PATCH v2 00/15] make structure field, function arguments and structures const

2017-10-17 Thread Greg KH
On Tue, Oct 17, 2017 at 12:16:18PM +0200, Julia Lawall wrote: > > > On Tue, 17 Oct 2017, Greg KH wrote: > > > On Mon, Oct 16, 2017 at 05:18:39PM +0200, Bhumika Goyal wrote: > > > Make the ci_type field and some function arguments as const. After this > >

Re: [PATCH v2 00/15] make structure field, function arguments and structures const

2017-10-17 Thread Greg KH
On Mon, Oct 16, 2017 at 05:18:39PM +0200, Bhumika Goyal wrote: > Make the ci_type field and some function arguments as const. After this > change, make config_item_type structures as const. > > * Changes in v2- Combine all the followup patches and the constification > patches into a series. Who

Re: [PATCH v2] usb: wusbcore: Use put_unaligned_le32

2017-10-17 Thread Greg KH
On Fri, Oct 06, 2017 at 08:38:07PM +0530, Himanshu Jha wrote: > Use put_unaligned_le32 rather than using byte ordering function and > memcpy which makes code clear. > Also, add the header file where it is declared. > > Done using Coccinelle and semantic patch used is : > > @ rule1 @ > identifier

[GIT PULL] USB driver fixes for 4.14-rc5

2017-10-15 Thread Greg KH
The following changes since commit 8a5776a5f49812d29fe4b2d0a2d71675c3facf3f: Linux 4.14-rc4 (2017-10-08 20:53:29 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git/ tags/usb-4.14-rc5 for you to fetch changes up to

Re: [PATCH] USB: serial: drop unused core USB driver

2017-10-12 Thread Greg KH
On Thu, Oct 12, 2017 at 05:22:28PM +0200, Johan Hovold wrote: > Drop the usb-serial-core USB driver that was registered at module init > but then never used. > > This was a remnant dating back to 2004 (!) when this struct usb_driver > was used for the generic driver; see commit bbc53b7d7322

Re: [PATCH 3/3] USB: serial: metro-usb: add missing interrupt-out endpoint check

2017-10-12 Thread Greg KH
On Thu, Oct 12, 2017 at 10:54:23AM +0200, Johan Hovold wrote: > One class of "unidirectional" devices managed by this driver uses an > interrupt-out endpoint to send control messages at open and close. Due > to a missing endpoint sanity check, this could result in an interrupt > URB being

Re: [PATCH 2/3] USB: serial: metro-usb: simplify endpoint check

2017-10-12 Thread Greg KH
On Thu, Oct 12, 2017 at 10:54:22AM +0200, Johan Hovold wrote: > Let usb-serial core verify that the interrupt-in endpoint is present > when binding the interface instead of the driver verifying this at every > open. > > Signed-off-by: Johan Hovold Reviewed-by: Greg

Re: [PATCH 1/3] USB: serial: metro-usb: stop I/O after failed open

2017-10-12 Thread Greg KH
On Thu, Oct 12, 2017 at 10:54:21AM +0200, Johan Hovold wrote: > Make sure to kill the interrupt-in URB after a failed open request. > Apart from saving power (and avoiding stale input after a later > successful open), this also prevents a NULL-deref in the completion > handler if the port is

Re: [PATCH v2 0/9] sound: Add sanity checks for invalid EPs

2017-10-11 Thread Greg KH
On Wed, Oct 11, 2017 at 12:36:37PM +0200, Takashi Iwai wrote: > Hi, > > this is a revised patch set to cover the codes that may submit URBs > containing invalid EPs without validation, which result in the kernel > warning from the USB core. The first patch adds a new helper for > simplifying the

Re: [PATCH 5/5] USB: serial: garmin_gps: simplify init-session logic

2017-10-11 Thread Greg KH
On Wed, Oct 11, 2017 at 02:03:01PM +0200, Johan Hovold wrote: > Clean up the somewhat convoluted init-session logic to improve > readability. > > Signed-off-by: Johan Hovold Reviewed-by: Greg Kroah-Hartman -- To unsubscribe from this list: send the

Re: [PATCH 4/5] USB: serial: garmin_gps: clean up init-session messages

2017-10-11 Thread Greg KH
On Wed, Oct 11, 2017 at 02:03:00PM +0200, Johan Hovold wrote: > Use the port device for any init-session error and debug messages, > remove one redundant debug message and simplify one error message. > > Signed-off-by: Johan Hovold Reviewed-by: Greg Kroah-Hartman

Re: [PATCH 3/5] USB: serial: garmin_gps: drop unused timer initialisation

2017-10-11 Thread Greg KH
On Wed, Oct 11, 2017 at 02:02:59PM +0200, Johan Hovold wrote: > Drop out-commented timer expiry initialisation which would not even > compile anymore. > > Signed-off-by: Johan Hovold Reviewed-by: Greg Kroah-Hartman -- To unsubscribe from this list:

Re: [PATCH 2/5] USB: serial: garmin_gps: fix memory leak on probe errors

2017-10-11 Thread Greg KH
On Wed, Oct 11, 2017 at 02:02:58PM +0200, Johan Hovold wrote: > Make sure to free the port private data before returning after a failed > probe attempt. > > Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") > Cc: stable > Signed-off-by: Johan Hovold

Re: [PATCH 1/5] USB: serial: garmin_gps: fix I/O after failed probe and remove

2017-10-11 Thread Greg KH
On Wed, Oct 11, 2017 at 02:02:57PM +0200, Johan Hovold wrote: > Make sure to stop any submitted interrupt and bulk-out URBs before > returning after failed probe and when the port is being unbound to avoid > later NULL-pointer dereferences in the completion callbacks. > > Also fix up the related

Re: [PATCH 1/9] usb: core: Add a helper function to check the validity of EP type in URB

2017-10-10 Thread Greg KH
On Tue, Oct 10, 2017 at 03:38:11PM +0200, Takashi Iwai wrote: > This patch adds a new helper function to perform a sanity check of the > given URB to see whether it contains a valid endpoint. It's a light- > weight version of what usb_submit_urb() does, but without the kernel > warning followed

Re: linux-stable 4.11.y – xhci probe failed because of missing patches

2017-10-10 Thread Greg KH
On Tue, Oct 10, 2017 at 02:50:48PM +0700, Tung Vuong Nguyen wrote: > CONFIDENTIALITY NOTICE: This e-mail message, including any attachments, is > for the sole use of the intended recipient(s) and contains information that > is confidential and proprietary to Applied Micro Circuits Corporation or

Re: linux-stable 4.11.y – xhci probe failed because of missing patches

2017-10-10 Thread Greg KH
On Tue, Oct 10, 2017 at 02:50:48PM +0700, Tung Vuong Nguyen wrote: > Hi everyone, > > Since kernel 4.11, there are a list of patches from Sriram (refer > https://lkml.org/lkml/2016/11/10/51) that change the way DMA is > inherited from sysdev. They have been accepted and available in >

Re: Documentation for USB device interface for power consumption

2017-10-08 Thread Greg KH
On Mon, Oct 09, 2017 at 11:36:55AM +0800, Kai Hendry wrote: > Hi there, > > Can't see the /{proc,sys} interface documented in places I expect to be > like https://github.com/torvalds/linux/tree/master/drivers/usb It's documented under Documentation/ABI/ for most of the sysfs stuff, right? > And

Re: [PATCH] rndis_host: remove unnecessary space

2017-10-06 Thread Greg KH
On Fri, Oct 06, 2017 at 08:54:50PM +0300, Alex Briskin wrote: > Remove single space before tab. > --- > drivers/net/usb/rndis_host.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Always use checkpatch.pl so you don't get grumpy emails from a maintainer telling you to use

Re: the imfamous asix ax88179 iommu error

2017-10-05 Thread Greg KH
On Fri, Oct 06, 2017 at 11:29:19AM +1100, Will Trives wrote: > sorry, I mean this commit: > > commit469d417b68958a064c09e7875646c97c6e783dfc > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=469d417b68958a064c09e7875646c97c6e783dfc revert the revert?

Re: [PATCH 13/13] usb: host: xhci-plat: Use of_device_get_match_data() helper

2017-10-05 Thread Greg KH
On Thu, Oct 05, 2017 at 05:03:36PM +0300, Mathias Nyman wrote: > On 05.10.2017 16:59, Mathias Nyman wrote: > > On 05.10.2017 16:00, Geert Uytterhoeven wrote: > > > Hi Greg, > > > > > > On Thu, Oct 5, 2017 at 2:52 PM, Greg KH <gre...@linuxfoundation.org>

Re: [PATCH 13/13] usb: host: xhci-plat: Use of_device_get_match_data() helper

2017-10-05 Thread Greg KH
On Thu, Oct 05, 2017 at 11:21:49AM +0300, Mathias Nyman wrote: > From: Geert Uytterhoeven > > Use the of_device_get_match_data() helper instead of open coding. > > Signed-off-by: Geert Uytterhoeven > Signed-off-by: Mathias Nyman

Re: Random xHCI HC died on device disconnect

2017-10-05 Thread Greg KH
On Thu, Oct 05, 2017 at 01:50:35PM +0530, Manu Gautam wrote: > Hi Mathias, > > > On 10/4/2017 3:46 PM, Mathias Nyman wrote: > > On 03.10.2017 18:27, Kristian Evensen wrote: > >> On Tue, Oct 3, 2017 at 4:51 PM, Kristian Evensen > >> wrote: > > This is the

Re: [PATCH 2/2] USB: serial: console: fix use-after-free after failed setup

2017-10-04 Thread Greg KH
On Wed, Oct 04, 2017 at 11:01:13AM +0200, Johan Hovold wrote: > Make sure to reset the USB-console port pointer when console setup fails > in order to avoid having the struct usb_serial be prematurely freed by > the console code when the device is later disconnected. > > Fixes: 73e487fdb75f

Re: [PATCH 1/2] USB: serial: console: fix use-after-free on disconnect

2017-10-04 Thread Greg KH
On Wed, Oct 04, 2017 at 11:01:12AM +0200, Johan Hovold wrote: > A clean-up patch removing removing two redundant NULL-checks from the > console disconnect handler inadvertently also removed a third check. > This could lead to the struct usb_serial being prematurely freed by the > console code when

[GIT PULL] USB driver fixes for 4.14-rc4

2017-10-03 Thread Greg KH
The following changes since commit 2bd6bf03f4c1c59381d62c61d03f6cc3fe71f66e: Linux 4.14-rc1 (2017-09-16 15:47:51 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git/ tags/usb-4.14-rc4 for you to fetch changes up to

Re: [PATCH 00/18] use ARRAY_SIZE macro

2017-10-01 Thread Greg KH
On Sun, Oct 01, 2017 at 08:52:20PM -0400, Jérémy Lefaure wrote: > On Mon, 2 Oct 2017 09:01:31 +1100 > "Tobin C. Harding" wrote: > > > > In order to reduce the size of the To: and Cc: lines, each patch of the > > > series is sent only to the maintainers and lists concerned by the

Re: [PATCH] usb: renesas_usbhs: fix usbhsf_fifo_clear() behavior

2017-09-27 Thread Greg KH
On Wed, Sep 27, 2017 at 05:04:05PM +0900, Yoshihiro Shimoda wrote: > This patch fixes two issues: > - the usbhsf_fifo_clear() is possible to cause 10 msec delay if >the pipe is RX direction and empty because the FRDY bit will never >be set to 1 in such case. > - sets the BCLR of

Re: [PATCH] r8152: add Linksys USB3GIGV1 id

2017-09-26 Thread Greg KH
On Mon, Sep 25, 2017 at 01:17:32PM -0700, Grant Grundler wrote: > Correct. r8152 happens to claim the device before cdc_ether does - I > thought because cdc_ether is a class driver and only gets picked up > after vendor specific drivers are probed. Is that correct? Nope, there is not "priority"

Re: [PATCH 12/12] staging: typec: tcpci: move tcpci driver out of staging

2017-09-26 Thread Greg KH
On Tue, Sep 26, 2017 at 08:45:27AM +0800, Li Jun wrote: > Move TCPCI(Typec port controller interface) driver out of staging. > > Signed-off-by: Li Jun > --- > drivers/staging/Kconfig| 2 - > drivers/staging/Makefile | 1 - > drivers/staging/typec/Kconfig | 14

Re: Type-C port on the Asmedia ASM1142

2017-09-26 Thread Greg KH
On Tue, Sep 26, 2017 at 09:30:31AM +1000, Will Trives wrote: > On Mon, 25 Sep 2017 10:52:10 +0200 > Greg KH <gre...@linuxfoundation.org> wrote: > > > On Mon, Sep 25, 2017 at 05:29:10PM +1000, Will wrote: > > > Hello, > > > > > > Basically I'

Re: Type-C port on the Asmedia ASM1142

2017-09-25 Thread Greg KH
On Mon, Sep 25, 2017 at 05:29:10PM +1000, Will wrote: > Hello, > > Basically I'm just sending this to see if anyone can confirm whether > they can get SuperSpeed devices working properly through the Type-C port > on an Asmedia ASM1142 controller with Linux (i've tried even with latest > usb-next

Re: [PATCH 9/9 v2] usb: usb251xb: Use GPIO descriptor consumer interface

2017-09-22 Thread Greg KH
On Fri, Sep 22, 2017 at 06:26:54PM +0300, Serge Semin wrote: > On Thu, Sep 21, 2017 at 05:07:14PM +0200, Greg KH > <gre...@linuxfoundation.org> wrote: > > On Thu, Sep 21, 2017 at 05:51:29PM +0300, Serge Semin wrote: > > > On Thu, Sep 21, 2017 at 10:23:38AM

Re: [PATCH] USB: gadgetfs: Fix crash caused by inadequate synchronization

2017-09-22 Thread Greg KH
On Thu, Sep 21, 2017 at 01:23:58PM -0400, Alan Stern wrote: > The gadgetfs driver (drivers/usb/gadget/legacy/inode.c) was written > before the UDC and composite frameworks were adopted; it is a legacy > driver. As such, it expects that once bound to a UDC controller, it > will not be unbound

Re: [PATCH 9/9 v2] usb: usb251xb: Use GPIO descriptor consumer interface

2017-09-21 Thread Greg KH
On Thu, Sep 21, 2017 at 05:51:29PM +0300, Serge Semin wrote: > On Thu, Sep 21, 2017 at 10:23:38AM +0200, Greg KH > <gre...@linuxfoundation.org> wrote: > > On Sat, Sep 16, 2017 at 01:42:20PM +0300, Serge Semin wrote: > > > diff --git a/drivers/usb/misc/usb251xb.c b/

Re: [PATCH 9/9 v2] usb: usb251xb: Use GPIO descriptor consumer interface

2017-09-21 Thread Greg KH
On Sat, Sep 16, 2017 at 01:42:20PM +0300, Serge Semin wrote: > diff --git a/drivers/usb/misc/usb251xb.c b/drivers/usb/misc/usb251xb.c > index 71994b883..c2dd9742f 100644 > --- a/drivers/usb/misc/usb251xb.c > +++ b/drivers/usb/misc/usb251xb.c > @@ -3,6 +3,7 @@ > * Configuration via SMBus. > * >

Re: [PATCH v5] xhci : AMD Promontory USB disable port support

2017-09-19 Thread Greg KH
On Tue, Sep 19, 2017 at 05:40:04PM +0800, Joe Lee wrote: > From: asmtswfae Shouldn't the name here match the name up in your From: email line? > > For AMD Promontory xHCI host, although you can disable USB 2.0 ports in BIOS > settings, those ports will be enabled anyway

Re: how to instrument/debug module loading

2017-09-18 Thread Greg KH
On Mon, Sep 18, 2017 at 11:28:32AM -0400, Cliff Brake wrote: > On Thu, Sep 14, 2017 at 12:37 PM, Greg KH <gre...@linuxfoundation.org> wrote: > > On Thu, Sep 14, 2017 at 08:20:09AM -0400, Cliff Brake wrote: > >> Hi, > >> > >> I'm trying to better unde

Re: [PATCH v4 0/3] initialize (multiple) PHYs in xhci-plat

2017-09-18 Thread Greg KH
On Sun, Sep 17, 2017 at 10:51:31PM +0200, Martin Blumenstingl wrote: > Hello Mathias, Hello Greg, > > On Sun, Sep 3, 2017 at 11:38 PM, Martin Blumenstingl > wrote: > > This series is the outcome of a discussion with Felipe Balbi, > > see [0] and [1]. > > The

Re: Dell WD15 dock causes system freezes

2017-09-16 Thread Greg KH
On Sat, Sep 16, 2017 at 03:02:58PM +0200, Piotr Kołaczkowski wrote: > Hello! > > TL;DR: > I'm having troubles with Dell WD15 dock connected to USB-C of Dell > Precision 5520 laptop. > I'm seeing very frequent kernel freezes, sometimes panics, > particularly on logging into the desktop session. >

Re: [PATCH 5/5] usb: usb251xb: Add copyrights

2017-09-15 Thread Greg KH
On Sat, Sep 16, 2017 at 02:45:17AM +0300, Serge Semin wrote: > On Fri, Sep 15, 2017 at 04:40:28PM -0700, Greg KH > <gre...@linuxfoundation.org> wrote: > > On Sat, Sep 16, 2017 at 02:31:13AM +0300, Serge Semin wrote: > > > Signed-off-by: Serge Sem

Re: [PATCH 1/5] usb: usb251xb: Add USB2517/i hub support

2017-09-15 Thread Greg KH
On Sat, Sep 16, 2017 at 02:31:09AM +0300, Serge Semin wrote: > USB2517i hubs are very like USB251xb devices series. They have almost > the same configuration registers space except number of ports, led > configurations and lack of battery settings. All these peculiarities > are reflected in this

Re: [PATCH 5/5] usb: usb251xb: Add copyrights

2017-09-15 Thread Greg KH
On Fri, Sep 15, 2017 at 04:40:28PM -0700, Greg KH wrote: > On Sat, Sep 16, 2017 at 02:31:13AM +0300, Serge Semin wrote: > > Signed-off-by: Serge Semin <fancer.lan...@gmail.com> > > --- > > drivers/usb/misc/usb251xb.c | 1 + > > 1 file changed, 1 insertions(+)

Re: [PATCH 5/5] usb: usb251xb: Add copyrights

2017-09-15 Thread Greg KH
On Sat, Sep 16, 2017 at 02:31:13AM +0300, Serge Semin wrote: > Signed-off-by: Serge Semin > --- > drivers/usb/misc/usb251xb.c | 1 + > 1 file changed, 1 insertions(+), 0 deletion(-) I can't take patches without any changelog text, sorry. > > diff --git

Re: HP Thunderbolt 3 Dock (90W): USB does not work

2017-09-14 Thread Greg KH
On Wed, Sep 13, 2017 at 07:54:21AM +0200, Matthias Lohr wrote: > Hello, > > i'm using a Lenovo Carbon x1 (5th generation) with a HP Thunderbolt 3 > dock (90W version). All ports are working, except USB Ports - for ~30 > minutes. After ~30 minutes, also the USB ports get activated. > > While

Re: Interfacing a camera to UVC

2017-09-14 Thread Greg KH
On Thu, Sep 14, 2017 at 09:56:26AM -0700, Rail Shafigulin wrote: > On Thu, Sep 14, 2017 at 2:21 AM, Oliver Neukum wrote: > > Hi, > > > > either the camera (to be precise: an interface of it) advertises > > itself as UVC compliant and implements the UVC standard. If that > > is

Re: USB mouse

2017-09-14 Thread Greg KH
On Thu, Sep 14, 2017 at 09:58:11AM -0700, Bruce Korb wrote: > On Thu, Sep 14, 2017 at 9:33 AM, Greg KH <gre...@linuxfoundation.org> wrote: > > On Thu, Sep 14, 2017 at 07:54:08AM -0700, Bruce Korb wrote: > >> Folks at Plugable: FYI, the email thread, if you are interested

Re: how to instrument/debug module loading

2017-09-14 Thread Greg KH
On Thu, Sep 14, 2017 at 08:20:09AM -0400, Cliff Brake wrote: > Hi, > > I'm trying to better understand the kernel module loading mechanism > (for example when you plug in a USB device and a kernel module > autoloads). It appears that depmod creates a module.alias map that > maps USB info to

Re: USB mouse

2017-09-14 Thread Greg KH
On Thu, Sep 14, 2017 at 07:54:08AM -0700, Bruce Korb wrote: > Folks at Plugable: FYI, the email thread, if you are interested. > Neither your USB3 hub nor anybody else's works with a fairly > recent Linux kernel. Given that I have used two different hubs > with the same result, I am a bit

Re: Interfacing a camera to UVC

2017-09-13 Thread Greg KH
On Wed, Sep 13, 2017 at 01:57:49PM -0700, Rail Shafigulin wrote: > I'm a little unclear about USB Video Class (UVC). In order to use the > camera, does it need to have a Video4Linux driver that "talks" to a > UVC class or it is possible to have a camera that doesn't have a > Video4Linux driver and

Re: Bug 196559: xhci_hcd: kernel panic using thunderbolt dell dock TB16 on 4.12.4

2017-09-13 Thread Greg KH
On Wed, Sep 13, 2017 at 05:03:32PM +0300, Mathias Nyman wrote: > On 07.09.2017 18:16, Greg KH wrote: > > On Thu, Sep 07, 2017 at 09:12:53AM -0600, Jose Marino wrote: > > > I have tested Mathias' patch on top of v4.13 and it fixes the problem. I > > > was > > >

Re: USB: serial: option: add support for TP-Link LTE module

2017-09-11 Thread Greg KH
On Mon, Sep 11, 2017 at 03:44:03PM +0200, Henryk Heisig wrote: > commit 4b3dbf9093d8b5ced1a3c13cfa4113e897eb3b16 > Author: Henryk Heisig > Date:   Mon Sep 11 14:15:22 2017 +0200 > >     USB: serial: option: add support for TP-Link LTE module > >     This commit adds support for

Re: Add TI ICDI as a simple usb serial device

2017-09-11 Thread Greg KH
On Mon, Sep 11, 2017 at 12:22:57PM +, Dashi DS1 Cao wrote: > Sorry! Should have submitted the patch inline: > > --- > drivers/usb/serial/usb-serial-simple.c | 8 +++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/drivers/usb/serial/usb-serial-simple.c >

Re: T230 and T230C DVB-C broken on Linux 4.12>

2017-09-09 Thread Greg KH
On Sat, Sep 09, 2017 at 10:05:55AM +0200, François wrote: > Hi greg k-h, > > Thank you for your reply. > > I have tested older kernels (4.12> and 4.9 LTS) but unfortunately the > device is still unable to scan any channels. > It also has difficulties with getting a stable connection when using a

Re: T230 and T230C DVB-C broken on Linux 4.12>

2017-09-08 Thread Greg KH
On Fri, Sep 08, 2017 at 09:27:51PM +0200, François wrote: > The device isn't able to scan any DVB-C channel anymore, and the > following error appears: > usb 1-7: DVB: adapter 0 frontend 0 frequency 0 out of range > > The cable is fine (tried a few others as well), it just impossible to > get any

Re: [PATCH v5] usb: serial: add vid:pid for Cypress WICED dev board

2017-09-08 Thread Greg KH
On Fri, Sep 08, 2017 at 02:35:03PM +, Jeffrey Chu wrote: > Add CYPRESS_VID vid and CYPRESS_WICED_BT_USB and CYPRESS_WICED_WL_USB > device IDs to ftdi_sio driver > > Signed-off-by: Jeffrey Chu > --- > drivers/usb/serial/ftdi_sio.c | 2 ++ >

Re: [PATCH v4] usb: serial: add vid:pid for Cypress WICED dev board

2017-09-08 Thread Greg KH
On Fri, Sep 08, 2017 at 12:27:41PM +, Jeffrey Chu wrote: > Add CYPRESS_VID vid and CYPRESS_WICED_BT_USB and CYPRESS_WICED_WL_USB device > IDs to ftdi_sio driver Please wrap your changelog at the proper colums (72). > > Signed-off-by: Jeffrey Chu > --- >

Re: Bug 196559: xhci_hcd: kernel panic using thunderbolt dell dock TB16 on 4.12.4

2017-09-07 Thread Greg KH
On Thu, Sep 07, 2017 at 09:12:53AM -0600, Jose Marino wrote: > I have tested Mathias' patch on top of v4.13 and it fixes the problem. I was > able to suspend/resume a few times with no kernel panics. Yeah! Thanks for testing. Mathias, care to send me a "real" patch for this so I can get it to

Re: Bug 196559: xhci_hcd: kernel panic using thunderbolt dell dock TB16 on 4.12.4

2017-09-07 Thread Greg KH
On Wed, Sep 06, 2017 at 10:04:08AM -0600, Jose Marino wrote: > The bug is still present in kernel 4.13. The panic logs look pretty much the > same as with 4.12.4. I have attached the pstore and journald messages to the > bugzilla bug report just in case. > > I reverted commit 5cc9b698a494827 on

Re: Bug 196559: xhci_hcd: kernel panic using thunderbolt dell dock TB16 on 4.12.4

2017-09-06 Thread Greg KH
On Tue, Sep 05, 2017 at 03:11:40PM -0600, Jose Marino wrote: > Hi, > I found a way to reliably trigger this bug: > - Boot laptop > - Plug in dock (with external display connected to dock) > - Send output to external display > - Suspend > > I did a bisect between 4.12.3 and 4.12.4 and here is the

[GIT PULL] USB/PHY driver updates for 4.14-rc1

2017-09-04 Thread Greg KH
The following changes since commit ef954844c7ace62f773f4f23e28d2d915adc419f: Linux 4.13-rc5 (2017-08-13 16:01:32 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git/ tags/usb-4.14-rc1 for you to fetch changes up to

Re: arm64 crash in ffs on 4.9/4.12 - Internal error: Accessing user space memory with fs=KERNEL_DS

2017-08-30 Thread Greg KH
On Wed, Aug 30, 2017 at 01:27:32PM -0700, Jerry Zhang wrote: > Hi, > > I'm running into a kernel crash while using the functionfs driver on > 4.9 and 4.12 kernels. This is reproducible by using any of the aio > syscalls with functionfs on the above kernels. The code in question is > in

Re: [PATCH] USB: fix coding style issue

2017-08-30 Thread Greg KH
On Wed, Aug 30, 2017 at 09:37:26PM +0800, pierre kuo wrote: > hi Greg: > > 2017-08-16 23:46 GMT+08:00 Greg KH <gre...@linuxfoundation.org>: > > On Wed, Aug 16, 2017 at 11:01:20AM +0800, pierre Kuo wrote: > >> try to fix some codeing style issue, such as "space p

Re: [PATCH] Revert "xhci: Limit USB2 port wake support for AMD Promontory hosts"

2017-08-28 Thread Greg KH
On Tue, Aug 22, 2017 at 05:14:47PM +0800, Kai-Heng Feng wrote: > This reverts commit dec08194ffeccfa1cf085906b53d301930eae18f. > > Commit dec08194ffec ("xhci: Limit USB2 port wake support for AMD Promontory > hosts") makes all high speed USB ports on ASUS PRIME B350M-A cease to > function after

Re: [PATCH] USB: serial: ti_usb_3410_5052: Port uart_mode from io_ti.

2017-08-28 Thread Greg KH
On Fri, Aug 18, 2017 at 12:56:59PM +1000, Stuart Longland wrote: > This introduces the `uart_mode` sysfs attribute as seen in the `io_ti` > USB serial driver, allowing this USB serial interface to be switched > between RS-232, 2-wire RS-485 and 4-wire RS-485. > >

Re: ftdi_sio: timing issue while setting ASYNC_LOW_LATENCY from user space

2017-08-28 Thread Greg KH
On Mon, Aug 28, 2017 at 11:22:48AM +0300, Matwey V. Kornilov wrote: > Hi all, > > I have an issue with the following patch: > c6dce2626606 ("USB: serial: ftdi_sio: fix extreme low-latency setting") > > I really need sub 16-ms latency for my peripheral and while I have no > problems with idea of

Re: ASM1153 detected as ASM1051 and breaking UAS

2017-08-25 Thread Greg KH
On Fri, Aug 25, 2017 at 09:43:26AM +0200, Massimo Burcheri wrote: > On Thu, 2017-08-24 at 17:24 -0700, Greg KH wrote: > > > On Thu, Aug 24, 2017 at 02:05:22PM +0200, Massimo Burcheri wrote: > > > From lsusb -vv: > > > > > > Bus 004 Device 005: ID 174c:51

Re: [PATCH] cdc_ncm: flag the ublox TOBY-L4 as wwan

2017-08-25 Thread Greg KH
On Fri, Aug 25, 2017 at 02:59:46PM +0200, Aleksander Morgado wrote: > Signed-off-by: Aleksander Morgado > --- > drivers/net/usb/cdc_ncm.c | 7 +++ > 1 file changed, 7 insertions(+) Personally, I require patches to have changelog texts in them... -- To unsubscribe

Re: ASM1153 detected as ASM1051 and breaking UAS

2017-08-24 Thread Greg KH
On Thu, Aug 24, 2017 at 02:05:22PM +0200, Massimo Burcheri wrote: > Hello, > > as reported on > https://bugzilla.kernel.org/show_bug.cgi?id=196739 > > a Transcend 25M3 device with ASM1153 chipset is detected as ASM1051 and > breaking > UAS support as this one is blacklisted. But after

Re: [PATCH] usb:xhci:Fix regression when ATI chipsets detected

2017-08-23 Thread Greg KH
On Wed, Aug 23, 2017 at 04:26:00PM +0530, Sandeep Singh wrote: > From: Sandeep Singh > > The following commit cause a regression on ATI chipsets. > 'commit e788787ef4f9 ("usb:xhci:Add quirk for Certain > failing HP keyboard on reset after resume")' > > This causes

Re: Need help investigating not working NKRO over USB in Linux

2017-08-22 Thread Greg KH
On Sun, Aug 20, 2017 at 09:43:01PM +0300, IFo Hancroft wrote: > Hello Everyone, > > Greg Kroah-Hartman directed me to here. > > Here is what I am trying to do, what problems am I facing and what I've > tried so far: > > My keyboard is USB and it is supposed to have NKRO (the ability to >

Re: high irqs-off latency caused by USB serial driver

2017-08-22 Thread Greg KH
On Tue, Aug 22, 2017 at 02:44:20PM -0600, David Mosberger wrote: > Greg, > > On Tue, Aug 22, 2017 at 2:25 PM, Greg KH <gre...@linuxfoundation.org> wrote: > > > USB has always been a big problem with this, the IRQ patch is very long, > > an

Re: high irqs-off latency caused by USB serial driver

2017-08-22 Thread Greg KH
On Tue, Aug 22, 2017 at 12:42:33PM -0600, David Mosberger wrote: > Has anyone here looked into reducing the amount of time the USB serial > driver disables interrupts? On an ARM system, I'm seeing about 746 us > of latency for handling a USB interrupt, which seems rather excessive. > I attached a

Re: usb 1-2: 1:1: cannot set freq 44100 to ep 0x81 and potential fix

2017-08-18 Thread Greg KH
On Fri, Aug 18, 2017 at 12:40:47PM +, Joakim Tjernlund wrote: > I have two USB head sethead (Logitech Inc Logitech Stereo H650e and > Jabra Jabra UC VOICE 550a) who both causes lots of: > > usb 1-2: 1:1: cannot set freq 44100 to ep 0x81 > > errors when using them pin pidgin audio chats.

Re: usb 3-1: 1:1: cannot get freq at ep 0x81

2017-08-17 Thread Greg KH
On Thu, Aug 17, 2017 at 09:51:11AM -0300, Cristian wrote: > Hello, > > https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1708499/comments/6 You didn't read my last response :( -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to

Re: [PATCH 7/9] xhci: add port status tracing

2017-08-16 Thread Greg KH
On Wed, Aug 16, 2017 at 04:10:00PM +0300, Mathias Nyman wrote: > On 16.08.2017 14:45, Felipe Balbi wrote: > > > > Hi, > > > > Mathias Nyman writes: > > > Track the port status in a human readble way each time we get a > > > port status change event > > > > > >

Re: [PATCH v3] usb: serial: add vid:pid for Cypress WICED dev board

2017-08-16 Thread Greg KH
On Wed, Aug 16, 2017 at 05:07:26PM -0400, Jeffrey Chu wrote: > Add CYPRESS_VID vid and CYPRESS_WICED_BT_USB and CYPRESS_WICED_WL_USB > device IDs to ftdi_sio driver > > Signed-off-by: Jeffrey Chu > --- > drivers/usb/serial/ftdi_sio.c | 2 ++ >

Re: usb 3-1: 1:1: cannot get freq at ep 0x81

2017-08-16 Thread Greg KH
On Wed, Aug 16, 2017 at 01:40:48PM -0300, Cristian wrote: > Hello, > > Launchpad.net: > https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1711151 What are we supposed to do with a one line description and a pointer to some random distro bug site? Please, if you want our help, give us the

Re: [PATCH] USB: fix coding style issue

2017-08-16 Thread Greg KH
On Wed, Aug 16, 2017 at 11:01:20AM +0800, pierre Kuo wrote: > try to fix some codeing style issue, such as "space prohibited" and "not > initialise statics". Only do one type of thing in a single patch please. And no, "fix all coding style issues" is not a single thing. This needs to be

Re: [PATCH] usb: serial: add vid:pid for Cypress WICED dev board

2017-08-14 Thread Greg KH
On Mon, Aug 14, 2017 at 09:24:51PM +, Jeffrey Chu wrote: > Add CYPRESS_VID vid and CYPRESS_WICED_BT_USB and CYPRESS_WICED_WL_USB device > IDs to ftdi_sio driver. > Signed-off-by: Jeffrey Chu > --- > drivers/usb/serial/ftdi_sio.c | 2 ++ >

[GIT PULL] USB fixes for 4.13-rc5

2017-08-12 Thread Greg KH
The following changes since commit 16f73eb02d7e1765ccab3d2018e0bd98eb93d973: Linux 4.13-rc3 (2017-07-30 12:40:36 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git/ tags/usb-4.13-rc5 for you to fetch changes up to

Re: [PATCH] USB: serial: pl2303: add new ATEN device id

2017-08-09 Thread Greg KH
On Wed, Aug 09, 2017 at 10:28:00AM +0200, Johan Hovold wrote: > On Tue, Aug 08, 2017 at 12:58:51PM -0700, Greg Kroah-Hartman wrote: > > This adds a new ATEN device id for a new pl2303-based device. > > > > Reported-by: Peter Kuo > > Cc: stable > >

[PATCH] USB: serial: pl2303: add new ATEN device id

2017-08-08 Thread Greg KH
This adds a new ATEN device id for a new pl2303-based device. Reported-by: Peter Kuo Cc: stable Signed-off-by: Greg Kroah-Hartman --- Peter, can you test this patch and verify it works for you? Is there a better name

Re: BUG/PATCH: cp210x.c - reenable support for chips which don't report a partnum

2017-08-08 Thread Greg KH
On Tue, Aug 08, 2017 at 08:59:01PM +0200, Sebastian Frei wrote: > Hi, > > I own a data cable for Siemens mobile phones: > 10ab:10c5 USI Co., Ltd Sony-Ericsson / Samsung DataCable > > The cp210x chip of this cable seems to not give an answer to the > CP210X_GET_PARTNUM command. So since this

<    1   2   3   4   5   6   7   8   9   10   >