Re: [PATCH v2] usb: misc: add USB251xB/xBi Hi-Speed Hub Controller Driver

2017-02-04 Thread Greg KH
On Fri, Feb 03, 2017 at 11:55:24AM +0100, Richard Leitner wrote: > +/** > + * ascii2utf16le() - Helper routine for producing UTF-16LE string descriptors > + * @s: Null-terminated ASCII (actually ISO-8859-1) string > + * @buf: Buffer for UTF-16LE string > + * @len: Length (in bytes; may be odd) of

Re: [PATCH net 1/4] pegasus: Use heap buffers for all register access

2017-02-04 Thread Greg KH
On Sat, Feb 04, 2017 at 04:56:03PM +, Ben Hutchings wrote: > Allocating USB buffers on the stack is not portable, and no longer > works on x86_64 (with VMAP_STACK enabled as per default). It's never worked on other platforms, so these should go to the stable releases please. thanks, greg

Re: dvb-usb: recv bulk message failed

2017-02-04 Thread Greg KH
On Sat, Feb 04, 2017 at 11:25:29AM +0100, François M wrote: > Using Mygica T230 on Linux 4.9.7: > [ 1948.418802] usb 1-1: USB disconnect, device number 6 > [ 1948.455998] dvb-usb: Mygica T230 DVB-T/T2/C successfully > deinitialized and disconnected. > [ 1950.636574] usb 1-1: new high-speed USB

[GIT PULL] USB driver fixes for 4.10-rc7

2017-02-04 Thread Greg KH
The following changes since commit 7a308bb3016f57e5be11a677d15b821536419d36: Linux 4.10-rc5 (2017-01-22 12:54:15 -0800) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git/ tags/usb-4.10-rc7 for you to fetch changes up to

Re: [GIT PULL] usb: chipidea changes for v4.11-rc1

2017-02-04 Thread Greg KH
On Sat, Feb 04, 2017 at 02:12:46PM +0800, Peter Chen wrote: > The following changes since commit 7ce7d89f48834cefece7804d38fc5d85382edf77: > > Linux 4.10-rc1 (2016-12-25 16:13:08 -0800) > > are available in the git repository at: > >

Re: Delivery Status Notification (Failure)

2017-02-04 Thread Greg KH
On Fri, Feb 03, 2017 at 05:17:20PM -0800, Brandon Gee wrote: > Hi, > > I'm new to report issues so please ask for more information if needed. I > am running multiple cameras on a single USB3.0 port using USB2.0 (using a > micro-B connector) and get this backtrace after running a few times. Is

Re: [RFC PATCH] usb: misc: add USB251xB/xBi Hi-Speed Hub Controller Driver

2017-02-03 Thread Greg KH
On Fri, Feb 03, 2017 at 10:44:05AM +0100, Richard Leitner wrote: > Hi Greg, > > On 02/03/2017 10:03 AM, Greg KH wrote: > > On Thu, Feb 02, 2017 at 02:44:29PM +0100, Richard Leitner wrote: > >> This patch adds a driver for configuration of the Microchip USB251xB/xBi >

Re: [RFC PATCH] usb: misc: add USB251xB/xBi Hi-Speed Hub Controller Driver

2017-02-03 Thread Greg KH
On Thu, Feb 02, 2017 at 02:44:29PM +0100, Richard Leitner wrote: > This patch adds a driver for configuration of the Microchip USB251xB/xBi > USB 2.0 hub controller series with USB 2.0 upstream connectivity, SMBus > configuration interface and two to four USB 2.0 downstream ports. > > Furthermore

Re: Fwd: snd_usb_toneport stops working on Linux >=4.9 (Line6 POD Studio UX1)

2017-02-02 Thread Greg KH
On Thu, Feb 02, 2017 at 12:26:41PM +0200, Vitaly Tonkacheyev wrote: > I don't know how to do it. > ~/github $ git clone https://github.com/torvalds/linux.git > ~/github $ cd linux > ~/github/linux $ git bisect start > ~/github/linux $ git bisect bad v4.9 > ~/github/linux $ git bisect good v4.8 >

Re: [PATCH 1/2] fs: configfs: make qw_sign attribute symmetric

2017-02-01 Thread Greg KH
On Tue, Jan 31, 2017 at 06:19:16PM -0800, Stefan Agner wrote: > Currently qw_sign requires UTF-8 character to set, but returns UTF-16 > when read. This isn't obvious when simply using cat since the null > characters are not visible, but hexdump unveils the true string: > > # echo MSFT100 >

Re: [PATCH 2/2] fs: configfs: use hexadecimal values and new line

2017-02-01 Thread Greg KH
On Tue, Jan 31, 2017 at 06:19:17PM -0800, Stefan Agner wrote: > Other unsigned properties return hexadecimal values, follow this > convention when printing b_vendor_code too. Also add newlines to > the OS Descriptor support related properties, like other sysfs > files use. configfs is not sysfs,

Re: [PATCH 1/2] fs: configfs: make qw_sign attribute symmetric

2017-02-01 Thread Greg KH
On Tue, Jan 31, 2017 at 06:19:16PM -0800, Stefan Agner wrote: > Currently qw_sign requires UTF-8 character to set, but returns UTF-16 > when read. This isn't obvious when simply using cat since the null > characters are not visible, but hexdump unveils the true string: > > # echo MSFT100 >

Re: [PATCH 2/3] USB: serial: digi_acceleport: fix incomplete rx sanity check

2017-01-31 Thread Greg KH
On Tue, Jan 31, 2017 at 05:46:02PM +0100, Johan Hovold wrote: > On Tue, Jan 31, 2017 at 05:41:52PM +0100, Greg Kroah-Hartman wrote: > > On Tue, Jan 31, 2017 at 05:17:28PM +0100, Johan Hovold wrote: > > > Make sure the received data has the required headers before parsing it. > > > > > > Also drop

Re: [PATCH 1/3] USB: serial: digi_acceleport: fix OOB data sanity check

2017-01-31 Thread Greg KH
On Tue, Jan 31, 2017 at 05:42:39PM +0100, Johan Hovold wrote: > On Tue, Jan 31, 2017 at 05:38:58PM +0100, Greg Kroah-Hartman wrote: > > On Tue, Jan 31, 2017 at 05:17:27PM +0100, Johan Hovold wrote: > > > Make sure to check for short transfers to avoid underflow in a loop > > > condition when

Re: [PATCH 2/3] USB: serial: digi_acceleport: fix incomplete rx sanity check

2017-01-31 Thread Greg KH
On Tue, Jan 31, 2017 at 05:17:28PM +0100, Johan Hovold wrote: > Make sure the received data has the required headers before parsing it. > > Also drop the redundant urb-status check, which has already been handled > by the caller. > > Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") > Signed-off-by:

Re: [PATCH 3/3] USB: serial: keyspan_pda: fix receive sanity checks

2017-01-31 Thread Greg KH
On Tue, Jan 31, 2017 at 05:17:29PM +0100, Johan Hovold wrote: > Make sure to check for short transfers before parsing the receive buffer > to avoid acting on stale data. > > Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") > Signed-off-by: Johan Hovold > --- >

Re: [PATCH 1/3] USB: serial: digi_acceleport: fix OOB data sanity check

2017-01-31 Thread Greg KH
On Tue, Jan 31, 2017 at 05:17:27PM +0100, Johan Hovold wrote: > Make sure to check for short transfers to avoid underflow in a loop > condition when parsing the receive buffer. > > Also fix an off-by-one error in the incomplete sanity check which could > lead to invalid data being parsed. > >

Re: [PATCH 1/3] USB: serial: ark3116: fix endpoint-check return value

2017-01-31 Thread Greg KH
On Tue, Jan 31, 2017 at 11:51:07AM +0100, Johan Hovold wrote: > Return -ENODEV rather than -EINVAL on probe errors due to a missing > endpoint. > > Also clean up the endpoint sanity check somewhat and use the interface > device for logging a more compact error in case an expected endpoint is >

Re: [PATCH 2/3] USB: serial: ark3116: remove redundant interrupt-urb check

2017-01-31 Thread Greg KH
On Tue, Jan 31, 2017 at 11:51:08AM +0100, Johan Hovold wrote: > Remove redundant check of num_interrupt_in which has already been > verified in probe (killing a NULL-urb would also have been fine). > > Signed-off-by: Johan Hovold > --- > drivers/usb/serial/ark3116.c | 4 ++-- >

Re: [PATCH 3/3] USB: serial: ark3116: use port device for info and error messages

2017-01-31 Thread Greg KH
On Tue, Jan 31, 2017 at 11:51:09AM +0100, Johan Hovold wrote: > Use the port device rather than usb device in info and error messages. > > This makes sure that driver and tty port is included in the messages, > while also making them more uniform. > > Signed-off-by: Johan Hovold

Re: snd_usb_toneport stops working on Linux >=4.9 (Line6 POD Studio UX1)

2017-01-29 Thread Greg KH
On Sun, Jan 29, 2017 at 05:12:29PM +0200, Vitaly Tonkacheyev wrote: > Driver stops working after update kernel to 4.9 (tried 4.9.4-4.9.6). > On 4.8 it works fine. Any chance you can run 'git bisect' and track down the offending commit? thanks, greg k-h -- To unsubscribe from this list: send the

Re: Fwd: Regression: Line6 Toneport stops working on 4.10-rc5

2017-01-27 Thread Greg KH
On Fri, Jan 27, 2017 at 07:32:03PM +0300, Igor Zinovev wrote: > Wow, what an awesome book, thank you! I didn't know that compiling the > kernel was so easy and fun! > > But I ran into a problem, I found one good and one bad point, started > bisecting it, ran through a couple of steps and stumbled

Re: [PATCH 1/1] USB: usb-devices: Interface number can be a string

2017-01-27 Thread Greg KH
On Thu, Jan 26, 2017 at 07:53:22AM +, Grueninger, Tobias wrote: > At least with one new LTE Modem (Gemalto PLS8-E) I found > that the Interface Number can also be a character (a, b, c and d). This leads > to that the printf gives an error and the line is not displayed correctly > > Changing

Re: Fwd: Regression: Line6 Toneport stops working on 4.10-rc5

2017-01-26 Thread Greg KH
On Thu, Jan 26, 2017 at 11:24:23AM +0300, Igor Zinovev wrote: > Yes, I did unplug and plug it back in once, it didn't help. Sure, I'd > love to do a bisect, only I haven't compiled a kernel from source, is > there a good howto anywhere I could follow? I wrote a whole book about this topic, that's

Re: [PATCH 1/1] USB: usb-devices: Interface number can be a string

2017-01-26 Thread Greg KH
On Thu, Jan 26, 2017 at 07:53:22AM +, Grueninger, Tobias wrote: > At least with one new LTE Modem (Gemalto PLS8-E) I found > that the Interface Number can also be a character (a, b, c and d). This leads > to that the printf gives an error and the line is not displayed correctly > > Changing

Re: Fwd: Regression: Line6 Toneport stops working on 4.10-rc5

2017-01-25 Thread Greg KH
On Thu, Jan 26, 2017 at 10:35:25AM +0300, Igor Zinovev wrote: > Hello! This is essentially a replay of > https://bugzilla.kernel.org/show_bug.cgi?id=193221 but sent to this > mailing list as recommended by Greg Kroah-Hartman. Please let me know > if I have missed something in this report. > > So

Re: [PATCH] usb: musb: constify musb_hdrc_config structures

2017-01-25 Thread Greg KH
On Wed, Jan 25, 2017 at 10:58:15AM -0600, Bin Liu wrote: > On Wed, Jan 25, 2017 at 12:52:22AM +0530, Bhumika Goyal wrote: > > Declare musb_hdrc_config structures as const as they are only stored in > > the config field of a musb_hdrc_platform_data structure. This field is of > > type const, so

Re: [PATCH 2/2] USB: serial: drop unused ASYNC flags

2017-01-25 Thread Greg KH
On Wed, Jan 25, 2017 at 06:22:54PM +0100, Johan Hovold wrote: > Do not report ASYNC_SKIP_TEST or ASYNC_AUTO_IRQ as being set in > TIOCGSERIAL handlers as these flags are not supported and do not really > make any sense for USB serial devices in the first place. > > Signed-off-by: Johan Hovold

Re: [PATCH 1/2] USB: serial: ftdi_sio: clean up ioctl handler

2017-01-25 Thread Greg KH
On Wed, Jan 25, 2017 at 06:22:53PM +0100, Johan Hovold wrote: > Clean up the ioctl handler and make sure to pass an unsigned-int rather > than serial_struct pointer to the TIOCSERGETLSR helper as this it what > the user argument really is. > > Signed-off-by: Johan Hovold > ---

Re: [PATCH 1/2] usb: musb: Fix host mode error -71 regression

2017-01-25 Thread Greg KH
On Wed, Jan 25, 2017 at 06:59:47AM -0600, Bin Liu wrote: > On Wed, Jan 25, 2017 at 11:01:30AM +0100, Greg KH wrote: > > On Tue, Jan 24, 2017 at 09:18:57AM -0600, Bin Liu wrote: > > > From: Tony Lindgren <t...@atomide.com> > > > > > > Commit 467d5c98070

Re: [PATCH 1/2] usb: musb: Fix host mode error -71 regression

2017-01-25 Thread Greg KH
On Tue, Jan 24, 2017 at 09:18:57AM -0600, Bin Liu wrote: > From: Tony Lindgren > > Commit 467d5c980709 ("usb: musb: Implement session bit based runtime PM for > musb-core") started implementing musb generic runtime PM support by > introducing devctl register session bit based

Re: [RFC] usb: gadget: uvc: webcam gadget USB PID is using value from a different gadget

2017-01-23 Thread Greg KH
On Mon, Jan 23, 2017 at 12:47:31PM +0100, Petr Cvek wrote: > Dne 23.1.2017 v 12:32 Greg KH napsal(a): > >>>> I know it is only a cosmetic change on a legacy driver, but I assume > >>>> it would be better to have some default value for configfs API than to > >

Re: [RFC] usb: gadget: uvc: webcam gadget USB PID is using value from a different gadget

2017-01-23 Thread Greg KH
On Mon, Jan 23, 2017 at 01:27:59PM +0200, Felipe Balbi wrote: > > Hi, > > Greg KH <g...@kroah.com> writes: > > On Mon, Jan 23, 2017 at 11:30:01AM +0100, Petr Cvek wrote: > >> Hello, > >> > >> It seems the USB product ID for g_webcam usb devi

Re: [RFC] usb: gadget: uvc: webcam gadget USB PID is using value from a different gadget

2017-01-23 Thread Greg KH
On Mon, Jan 23, 2017 at 11:30:01AM +0100, Petr Cvek wrote: > Hello, > > It seems the USB product ID for g_webcam usb device gadget is incorrectly > used from EEM gadget "Ethernet Emulation Model". So "webcam" device has a > confusing description in lsusb: > > 1d6b:0102 Linux Foundation

[GIT PULL] USB driver fixes for 4.10-rc5

2017-01-21 Thread Greg KH
The following changes since commit 49def1853334396f948dcb4cedb9347abb318df5: Linux 4.10-rc4 (2017-01-15 16:21:59 -0800) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git/ tags/usb-4.10-rc5 for you to fetch changes up to

Re: [PATCH resend v5 0/4] xhci fixes for usb-linus

2017-01-20 Thread Greg KH
On Fri, Jan 20, 2017 at 02:08:50PM +0200, Felipe Balbi wrote: > > Hi, > > Greg KH <gre...@linuxfoundation.org> writes: > > On Fri, Jan 20, 2017 at 01:35:39PM +0200, Mathias Nyman wrote: > >> On 20.01.2017 12:22, Greg KH wrote: > >> > On Fri, Jan 20,

Re: [PATCH resend v5 0/4] xhci fixes for usb-linus

2017-01-20 Thread Greg KH
On Fri, Jan 20, 2017 at 01:35:39PM +0200, Mathias Nyman wrote: > On 20.01.2017 12:22, Greg KH wrote: > > On Fri, Jan 20, 2017 at 11:23:36AM +0200, Mathias Nyman wrote: > > > On 19.01.2017 20:48, Greg KH wrote: > > > > On Thu, Jan 19, 2017 at 02:21:26PM +0200, Mathias

Re: [PATCH resend v5 0/4] xhci fixes for usb-linus

2017-01-20 Thread Greg KH
On Fri, Jan 20, 2017 at 11:23:36AM +0200, Mathias Nyman wrote: > On 19.01.2017 20:48, Greg KH wrote: > > On Thu, Jan 19, 2017 at 02:21:26PM +0200, Mathias Nyman wrote: > > > Hi Greg > > > > > > This series by Arnd Bergmann was originally six patches, but last

Re: [PATCH resend v5 0/4] xhci fixes for usb-linus

2017-01-19 Thread Greg KH
On Thu, Jan 19, 2017 at 02:21:26PM +0200, Mathias Nyman wrote: > Hi Greg > > This series by Arnd Bergmann was originally six patches, but last two of > them were already taken to 4.10. Without the rest of them there will > be a regression in 4.10. Is it really a regression? I thought this had

Re: [PATCH] tools: usb usbip - update README USB/IP driver location

2017-01-19 Thread Greg KH
On Fri, Jan 13, 2017 at 04:38:32PM -0700, Shuah Khan wrote: > Update USB/IP driver location in README. > > Signed-off-by: Shuah Khan > Reviewed-by: Krzysztof Opasiak > --- > tools/usb/usbip/README | 2 +- > 1 file changed, 1 insertion(+), 1

Re: [PATCH v5 4/6] usb: xhci: use bus->sysdev for DMA configuration

2017-01-19 Thread Greg KH
On Wed, Jan 18, 2017 at 01:58:28PM +0200, Mathias Nyman wrote: > On 12.01.2017 10:38, Roger Quadros wrote: > > Mathias, > > > > On 11/01/17 17:08, Alan Stern wrote: > > > On Wed, 11 Jan 2017, Mathias Nyman wrote: > > > > > > > On 17.11.2016 13:43, Sriram Dash wrote: > > > > > From: Arnd Bergmann

Re: [PATCH] usb: musb: dsps: make dsps_musb_clear_ep_rxintr() static

2017-01-17 Thread Greg KH
On Tue, Jan 17, 2017 at 10:43:28AM -0600, Bin Liu wrote: > On Tue, Jan 17, 2017 at 05:23:48PM +0100, Greg KH wrote: > > On Tue, Jan 17, 2017 at 09:32:05AM -0600, Bin Liu wrote: > > > From: Wei Yongjun <weiyongj...@huawei.com> > > > > > > Fixes the foll

Re: [PATCH] usb: musb: dsps: make dsps_musb_clear_ep_rxintr() static

2017-01-17 Thread Greg KH
On Tue, Jan 17, 2017 at 09:32:05AM -0600, Bin Liu wrote: > From: Wei Yongjun > > Fixes the following sparse warning: > > drivers/usb/musb/musb_dsps.c:270:6: warning: > symbol 'dsps_musb_clear_ep_rxintr' was not declared. Should it be static? > > Signed-off-by: Wei

Re: [PATCH] usb: gadget: configfs: Fix KASAN use-after-free

2017-01-17 Thread Greg KH
On Tue, Jan 17, 2017 at 10:07:40AM +0200, Felipe Balbi wrote: > > Hi, > > Jim Lin writes: > > When gadget is disconnected, running sequence is like this. > > . android_work: sent uevent USB_STATE=DISCONNECTED > > I'm gonna have to ask you to try with actual mainline where

Re: [PATCHv15 2/3] usb: USB Type-C connector class

2017-01-16 Thread Greg KH
On Mon, Jan 16, 2017 at 05:56:13PM +0300, Heikki Krogerus wrote: > The purpose of USB Type-C connector class is to provide > unified interface for the user space to get the status and > basic information about USB Type-C connectors on a system, > control over data role swapping, and when the port

Re: Standard USB Descriptor question

2017-01-16 Thread Greg KH
On Sun, Jan 15, 2017 at 07:03:34PM -0800, bruce m beach wrote: > On 1/13/17, Greg KH <gre...@linuxfoundation.org> wrote: > > On Fri, Jan 13, 2017 at 07:24:10PM -0800, bruce m beach wrote: > >> Hello everybody > >> > >> I have been stu

[GIT PULL] USB driver fixes for 4.10-rc4

2017-01-15 Thread Greg KH
The following changes since commit a121103c922847ba5010819a3f250f1f7fc84ab8: Linux 4.10-rc3 (2017-01-08 14:18:17 -0800) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git/ tags/usb-4.10-rc4 for you to fetch changes up to

Re: [PATCH] Documentation: usb: fix wrong documentation paths

2017-01-15 Thread Greg KH
On Sun, Jan 15, 2017 at 01:04:56PM +0100, Yegor Yefremov wrote: > Signed-off-by: Yegor Yefremov I never take patches without any changelog text, and I doubt that other maintainers do either :( thanks, greg k-h -- To unsubscribe from this list: send the line

Re: functionfs on dwc3, xhci host: endpoint cannot be used in both directions ?

2017-01-15 Thread Greg KH
On Sun, Jan 15, 2017 at 10:06:52AM +, Vincent Pelletier wrote: > Hello, > > Using configfs and functionfs I configured a 3-endpoints gadget the > following way: > - OUT f_fs ep: 1 real ep: 1 | OUT (0x01) > - IN f_fs ep: 2 real ep: 1 | IN (0x81) > - IN f_fs ep: 3 real ep: 2 | IN (0x82) >

Re: Standard USB Descriptor question

2017-01-13 Thread Greg KH
On Fri, Jan 13, 2017 at 07:24:10PM -0800, bruce m beach wrote: > Hello everybody > > I have been stuck for ages trying to figure out something > in the Standard USB Descriptor during the enumeration. It > looks like it should should be quite simple but I am not > getting it because maybe some

Re: [PATCH] USB: serial: opticon: fix CTS retrieval at open

2017-01-13 Thread Greg KH
On Fri, Jan 13, 2017 at 01:21:08PM +0100, Johan Hovold wrote: > The opticon driver used a control request at open to trigger a CTS > status notification to be sent over the bulk-in pipe. When the driver > was converted to using the generic read implementation, an inverted test > prevented this

Re: linux 4.9 breaks pctv452e

2017-01-13 Thread Greg KH
On Fri, Jan 13, 2017 at 12:15:05PM +0100, Wolfgang Rohdewald wrote: > this OOPS always happens with 4.9. up to 4.9.3 > > all 4.8.x versions work fine. Ick. Any chance you can use 'git bisect' to determine which commit broke this for you? thanks, greg k-h -- To unsubscribe from this list: send

Re: USB ExpressCard makes kworker process utilise 72-75% CPU infinitely

2017-01-12 Thread Greg KH
On Thu, Jan 12, 2017 at 08:06:46PM +0100, Christoph Anton Mitterer wrote: > On Thu, 2017-01-12 at 18:24 +0100, Greg KH wrote: > > What kworker process causes this?  Does it have a name? > How do I find out? Or do you mean the /0:3 which is contained in the > top output below? Yes

Re: USB ExpressCard makes kworker process utilise 72-75% CPU infinitely

2017-01-12 Thread Greg KH
On Thu, Jan 12, 2017 at 02:33:36PM +0100, Christoph Anton Mitterer wrote: > Hi. > > This is basically from: > https://bugzilla.kernel.org/show_bug.cgi?id=108341 > respectively > https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=805903 > the later in which Ben Hutchings recommended me to ping this

Re: [PATCH 00/15] USB: serial: fix control-message error handling

2017-01-12 Thread Greg KH
On Thu, Jan 12, 2017 at 02:56:08PM +0100, Johan Hovold wrote: > Several USB serial drivers failed to detect short control transfers, > something which could lead to uninitialised data leaking to user space > or being treated as valid input. > > The two information-leak fixes are marked for

Re: [PATCH v5 1/2] USB: add switch to turn off padding of resume time delays

2017-01-12 Thread Greg KH
On Thu, Jan 12, 2017 at 12:44:53PM +0200, Felipe Balbi wrote: > > Hi, > > Greg KH <g...@kroah.com> writes: > > On Thu, Jan 12, 2017 at 11:16:25AM +0200, Felipe Balbi wrote: > >> > In addition, they are a much smaller group for which we can hope > &g

Re: [PATCH v5 1/2] USB: add switch to turn off padding of resume time delays

2017-01-12 Thread Greg KH
On Thu, Jan 12, 2017 at 11:16:25AM +0200, Felipe Balbi wrote: > > In addition, they are a much smaller group for which we can hope > > to get a reasonable testing coverage. A generic white list will always > > be a fraction of all possibilities. > > not true. The full list of certified devices

Re: [PATCH] usb: musb: fix runtime PM in debugfs

2017-01-10 Thread Greg KH
On Mon, Jan 09, 2017 at 02:59:39PM -0600, Bin Liu wrote: > MUSB driver now has runtime PM support, but the debugfs driver misses > the PM _get/_put() calls, which could cause MUSB register access > failure. > > Cc: sta...@vger.kernel.org # 4.9+ > Acked-by: Tony Lindgren >

Re: [PATCH 0/6] USB: serial: kl5kusb105: fixes and clean ups

2017-01-10 Thread Greg KH
On Tue, Jan 10, 2017 at 12:05:36PM +0100, Johan Hovold wrote: > This series fixes an information leak, and cleans up the driver > somewhat. All look good to me: Reviewed-by: Greg Kroah-Hartman -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in

Re: Fwd: Raw hid gadget

2017-01-09 Thread Greg KH
On Mon, Jan 09, 2017 at 10:24:42PM +0200, Rogan Dawes wrote: > Sigh! This got bounced because of HTML parts. > > Another question that arises, though: > > What sort of performance can I expect writing to and reading from a > RAW HID gadget, configured using that descriptor? > > My understanding

Re: [PATCH v2 6/7] usb: musb: fix runtime PM in debugfs

2017-01-09 Thread Greg KH
On Mon, Jan 09, 2017 at 07:21:03AM -0600, Bin Liu wrote: > Greg, > > On Thu, Jan 05, 2017 at 12:33:02PM -0600, Bin Liu wrote: > > On Thu, Jan 05, 2017 at 07:17:51PM +0100, Greg KH wrote: > > > On Tue, Jan 03, 2017 at 06:13:51PM -0600, Bin Liu wrote: > > > > MU

[GIT PULL] USB driver fixes for 4.10-rc3

2017-01-08 Thread Greg KH
The following changes since commit 0c744ea4f77d72b3dcebb7a8f2684633ec79be88: Linux 4.10-rc2 (2017-01-01 14:31:53 -0800) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git/ tags/usb-4.10-rc3 for you to fetch changes up to

Re: [PATCH v2 5/7] usb: musb: debugfs: allow forcing host mode together with speed in testmode

2017-01-05 Thread Greg KH
On Thu, Jan 05, 2017 at 12:29:21PM -0600, Bin Liu wrote: > On Thu, Jan 05, 2017 at 07:17:14PM +0100, Greg KH wrote: > > On Tue, Jan 03, 2017 at 06:13:50PM -0600, Bin Liu wrote: > > > From: Pali Rohár <pali.ro...@gmail.com> > > > > > > Based on the mu

Re: [PATCH v2 5/7] usb: musb: debugfs: allow forcing host mode together with speed in testmode

2017-01-05 Thread Greg KH
On Tue, Jan 03, 2017 at 06:13:50PM -0600, Bin Liu wrote: > From: Pali Rohár > > Based on the musb ug, force_host bit is allowed to be set along with > force_hs or force_fs bit. > > It could help to implement forced host mode via testmode on Nokia N900. > > Signed-off-by:

Re: [PATCH v2 6/7] usb: musb: fix runtime PM in debugfs

2017-01-05 Thread Greg KH
On Tue, Jan 03, 2017 at 06:13:51PM -0600, Bin Liu wrote: > MUSB driver now has runtime PM support, but the debugfs driver misses > the PM _get/_put() calls, which could cause MUSB register access > failure. > > Cc: sta...@vger.kernel.org # 4.9+ > Signed-off-by: Bin Liu > Acked-by:

Re: [PATCH v5 0/6] inherit dma configuration from parent dev

2017-01-05 Thread Greg KH
On Thu, Jan 05, 2017 at 05:21:09PM +0200, Roger Quadros wrote: > Hi, > > On 17/11/16 13:43, Sriram Dash wrote: > > For xhci-hcd platform device, all the DMA parameters are not > > configured properly, notably dma ops for dwc3 devices. > > > > The idea here is that you pass in the parent of_node

Re: [PATCHv14 2/3] usb: USB Type-C connector class

2017-01-05 Thread Greg KH
On Thu, Jan 05, 2017 at 05:54:02PM +0200, Mika Westerberg wrote: > > + > > + ret = device_register(>dev); > > + if (ret) { > > + int i; > > + > > + dev_err(parent, "failed to register alternate mode (%d)\n", > > + ret); > > + > > +

Re: Strange behaviour of U2F usb key

2017-01-05 Thread Greg KH
On Thu, Jan 05, 2017 at 11:46:27AM +0100, B Consultants wrote: > Hi, > > On 04/01/17 13:19, B Consultants wrote: > > Preparing a computer with kernels 4.8.15 and 4.9.0 (last available on > > Gentoo). > > Same erratic behaviour on 4.8.15 and 4.9.0. With the same symptom : when > the key is

Re: [PATCH 01/16] usb: musb: core: add clear_ep_rxintr() to musb_platform_ops

2017-01-03 Thread Greg KH
On Tue, Jan 03, 2017 at 12:43:19PM -0600, Bin Liu wrote: > On Tue, Jan 03, 2017 at 07:31:58PM +0100, Greg KH wrote: > > On Tue, Jan 03, 2017 at 11:54:31AM -0600, Bin Liu wrote: > > > On Tue, Jan 03, 2017 at 07:37:18PM +0200, Felipe Balbi wrote: > > > > IOW, since you

Re: [PATCH 01/16] usb: musb: core: add clear_ep_rxintr() to musb_platform_ops

2017-01-03 Thread Greg KH
On Tue, Jan 03, 2017 at 11:54:31AM -0600, Bin Liu wrote: > On Tue, Jan 03, 2017 at 07:37:18PM +0200, Felipe Balbi wrote: > > IOW, since you're Ccing stable, you consider this to be a > > regression. Then the question reads as: "Are you missing a 'Fixes: foo > > bar baz' in your commit log?" > > I

Re: [PATCH 01/16] usb: musb: core: add clear_ep_rxintr() to musb_platform_ops

2017-01-03 Thread Greg KH
On Tue, Jan 03, 2017 at 11:07:42AM -0600, Bin Liu wrote: > On Tue, Jan 03, 2017 at 05:28:22PM +0100, Greg KH wrote: > > On Tue, Jan 03, 2017 at 09:47:47AM -0600, Bin Liu wrote: > > > On Tue, Jan 03, 2017 at 04:34:48PM +0100, Greg KH wrote: > > > > On Tue, Jan 03, 201

Re: [PATCH 01/24] USB: serial: cyberjack: fix NULL-deref at open

2017-01-03 Thread Greg KH
On Tue, Jan 03, 2017 at 05:48:05PM +0100, Johan Hovold wrote: > On Tue, Jan 03, 2017 at 05:27:07PM +0100, Greg Kroah-Hartman wrote: > > On Tue, Jan 03, 2017 at 04:39:40PM +0100, Johan Hovold wrote: > > > Fix NULL-pointer dereference when clearing halt at open should the device > > > lack a

Re: [PATCH 00/16] musb fixes for v4.10-rc3

2017-01-03 Thread Greg KH
On Tue, Jan 03, 2017 at 10:50:52AM -0600, Bin Liu wrote: > On Tue, Jan 03, 2017 at 05:27:53PM +0100, Greg KH wrote: > > On Tue, Jan 03, 2017 at 10:01:43AM -0600, Bin Liu wrote: > > > On Tue, Jan 03, 2017 at 04:38:47PM +0100, Greg KH wrote: > > > > On Tue, Jan 03, 201

Re: [PATCH 04/16] usb: musb: remove musb_generic_disable function

2017-01-03 Thread Greg KH
On Tue, Jan 03, 2017 at 10:16:53AM -0600, Bin Liu wrote: > On Tue, Jan 03, 2017 at 04:36:44PM +0100, Greg KH wrote: > > On Tue, Jan 03, 2017 at 09:15:09AM -0600, Bin Liu wrote: > > > musb_generic_disable() only has two lines of code. So remove it and let > > > the call

Re: [PATCH 00/16] musb fixes for v4.10-rc3

2017-01-03 Thread Greg KH
On Tue, Jan 03, 2017 at 10:01:43AM -0600, Bin Liu wrote: > On Tue, Jan 03, 2017 at 04:38:47PM +0100, Greg KH wrote: > > On Tue, Jan 03, 2017 at 09:15:05AM -0600, Bin Liu wrote: > > > Hi Greg, > > > > > > These are musb fixes for v4.10-rc3, which fix the b

Re: [PATCH 01/24] USB: serial: cyberjack: fix NULL-deref at open

2017-01-03 Thread Greg KH
On Tue, Jan 03, 2017 at 04:39:40PM +0100, Johan Hovold wrote: > Fix NULL-pointer dereference when clearing halt at open should the device > lack a bulk-out endpoint. > > Unable to handle kernel NULL pointer dereference at virtual address 0030 > ... > PC is at cyberjack_open+0x40/0x9c

Re: [PATCH 01/16] usb: musb: core: add clear_ep_rxintr() to musb_platform_ops

2017-01-03 Thread Greg KH
On Tue, Jan 03, 2017 at 09:47:47AM -0600, Bin Liu wrote: > On Tue, Jan 03, 2017 at 04:34:48PM +0100, Greg KH wrote: > > On Tue, Jan 03, 2017 at 09:15:06AM -0600, Bin Liu wrote: > > > During dma teardown for dequque urb, musb might generate bogus rx ep > > > inte

Re: [PATCH 00/16] musb fixes for v4.10-rc3

2017-01-03 Thread Greg KH
On Tue, Jan 03, 2017 at 09:15:05AM -0600, Bin Liu wrote: > Hi Greg, > > These are musb fixes for v4.10-rc3, which fix the bugs in musb core and > some glue layers for some use cases, such as bogus interrupts while musb > in heavy load, WARINING while rmmod omap2430 glue, and a few fixes in PM, >

Re: [PATCH 02/16] usb: musb: dsps: implement clear_ep_rxintr() callback

2017-01-03 Thread Greg KH
On Tue, Jan 03, 2017 at 09:15:07AM -0600, Bin Liu wrote: > This is for avoiding rx ep bogus interrupt during CPPI channel teardown. This is one of the worse changelog texts ever... Hint, don't use "This" :) And the text doesn't seem to describe this very well... thanks, greg k-h -- To

Re: [PATCH 01/16] usb: musb: core: add clear_ep_rxintr() to musb_platform_ops

2017-01-03 Thread Greg KH
On Tue, Jan 03, 2017 at 09:15:06AM -0600, Bin Liu wrote: > During dma teardown for dequque urb, musb might generate bogus rx ep > interrupt even when the rx fifo is flushed. As mentioned in the current > inline comment, clearing ep interrupt in the teardown path avoids the > bogus interrupt. > >

Re: [PATCH 05/16] usb: musb: dsps: remove redundant code

2017-01-03 Thread Greg KH
On Tue, Jan 03, 2017 at 09:15:10AM -0600, Bin Liu wrote: > The session is cleared in the core whenever musb_platform_disable() is > called, so clearing it in the glue driver *_musb_disable() is redundant. redundant is not a regression. I'm stopping review of this series here, come on now, you

Re: [PATCH 04/16] usb: musb: remove musb_generic_disable function

2017-01-03 Thread Greg KH
On Tue, Jan 03, 2017 at 09:15:09AM -0600, Bin Liu wrote: > musb_generic_disable() only has two lines of code. So remove it and let > the callers directly call those two lines. > > Signed-off-by: Bin Liu > --- > drivers/usb/musb/musb_core.c | 26 ++ > 1 file

Re: [PATCH 11/16] usb: musb: da8xx: Add support of suspend / resume

2017-01-03 Thread Greg KH
On Tue, Jan 03, 2017 at 09:15:16AM -0600, Bin Liu wrote: > From: Alexandre Bailon > > Implement PM methods specifics for da8xx glue. > The only thing to do is to power off the phy. > As the registers are in retention during suspend, > there is no need to save them. > >

Re: [PATCH 03/16] usb: musb: Fix trying to free already-free IRQ 4

2017-01-03 Thread Greg KH
On Tue, Jan 03, 2017 at 09:15:08AM -0600, Bin Liu wrote: > From: Tony Lindgren > > When unloading omap2430, we can get the following splat: > > WARNING: CPU: 1 PID: 295 at kernel/irq/manage.c:1478 __free_irq+0xa8/0x2c8 > Trying to free already-free IRQ 4 > ... > [] (free_irq)

Re: [GIT PULL] USB: fixes for v4.10-rc3

2017-01-03 Thread Greg KH
On Tue, Jan 03, 2017 at 02:54:52PM +0200, Felipe Balbi wrote: > > Hi Greg, > > Here's the first set of fixes for this rc cycle. Let me know if you want > anything to be changed. > > cheers > > The following changes since commit 0c744ea4f77d72b3dcebb7a8f2684633ec79be88: > > Linux 4.10-rc2

Re: Strange behaviour of U2F usb key

2017-01-03 Thread Greg KH
On Mon, Jan 02, 2017 at 11:25:14PM +0100, B Consultants wrote: > Hello, > > Kernels 4.1.35 and 4.4.39, on Gentoo boxes. > > We are trying to set up Yubikey-compatible (made by Plugup) U2F usb keys > on our systems, and the keys seems to be randomly detected by the usbhid > driver. Since it's for

Re: MIDI keyboard doesn't work when USB 3.0 controller is enabled in BIOS

2017-01-02 Thread Greg KH
On Mon, Jan 02, 2017 at 03:38:40PM +0200, Karmo Rosental wrote: > I have tried kernels 4.8.0 and 4.9.0 from Ubuntu repositories. > Probably I don't have latest BIOS. Try updating it and see if that resolves this issue. thanks, greg k-h -- To unsubscribe from this list: send the line

Re: MIDI keyboard doesn't work when USB 3.0 controller is enabled in BIOS

2017-01-02 Thread Greg KH
On Mon, Jan 02, 2017 at 11:35:55AM +0200, Karmo Rosental wrote: > Hello, > > After switching to a newer laptop my USB MIDI keyboard didn't work > anymore. Other USB devices that I have (memory stick and mouse) work > well. > > 2 out of 3 USB ports couldn't keep keyboard turned on (keyboard turns

Re: Using multiple USB3380 PCIe cards on a single Linux system

2016-12-22 Thread Greg KH
On Thu, Dec 22, 2016 at 10:32:38AM -0600, Karthik Ramana Sankar wrote: > Another quick question: In case of multiple PCIe cards, while loading > the g_mass_storage driver how do you associate a particular instance > of the driver to a particular physical USB3 device PCIe card? The same way you do

Re: Using multiple USB3380 PCIe cards on a single Linux system

2016-12-22 Thread Greg KH
On Wed, Dec 21, 2016 at 05:34:52PM -0600, Karthik Ramana Sankar wrote: > Hi Linux-USB members, > > I currently have a Intel Xeon based Dell poweredge T320 server setup > running Ubuntu server 14.04. I would like to add multiple USB3 devices > (peripheral mode) to the system using multiple PLX

Re: [PATCH v2 1/1] Increase USB transfer limit

2016-12-21 Thread Greg KH
On Wed, Dec 21, 2016 at 08:44:30AM -0800, Mateusz Berezecki wrote: > Hi Greg, > > On 15 Dec 2016, at 11:07, Greg KH wrote: > > [..] > > > > > > > Sorry, I wasn't quite sure how handle this. > > > > Documentation/SubmittingPatches should describ

Re: [usb-audio] 4.4.38: Zoom H2n hangs xhci

2016-12-15 Thread Greg KH
On Thu, Dec 15, 2016 at 08:22:44PM +0200, Sami Farin wrote: > Sandybridge system on Asus P8Z68-V PRO GEN3 motherboard. > > H2n connected to HP ZR24w's hub. When H2n is used as microphone: > (H2n is now disconnected but it didn't make any diff.) Can you try 4.9 and see if you still have the same

Re: [PATCH v2 1/1] Increase USB transfer limit

2016-12-15 Thread Greg KH
On Thu, Dec 15, 2016 at 10:41:47AM -0800, Mateusz Berezecki wrote: > > > > Il giorno 15 dic 2016, alle ore 03:52, Greg KH <gre...@linuxfoundation.org> > > ha scritto: > > > >> On Wed, Dec 14, 2016 at 09:11:08PM -0800, Mateusz Berezecki wrote: >

Re: [PATCH v2 1/1] Increase USB transfer limit

2016-12-15 Thread Greg KH
On Wed, Dec 14, 2016 at 09:11:08PM -0800, Mateusz Berezecki wrote: > Promote a variable keeping track of USB transfer memory usage to a > wider data type and allow for higher bandwidth transfers from a large > number of USB devices connected to a single host. > > Signed-off-by: Mateusz Berezecki

Re: [RFC PATCH] usb: host: xhci: plat: add support for otg_set_host() call

2016-12-14 Thread Greg KH
On Thu, Dec 15, 2016 at 12:25:08AM +0530, Manish Narani wrote: > This patch will add support for OTG host initialization. This will > help OTG drivers to populate their host subsystem. > > Signed-off-by: Manish Narani > --- > drivers/usb/host/xhci-plat.c | 35

Re: Fwd: usb cellphone storage device disconnection causes my usb mouse to be disconnected

2016-12-13 Thread Greg KH
On Tue, Dec 13, 2016 at 08:20:56PM +0200, or dv wrote: > I have a nokia C2 cellphone. when I connect it with a micro usb cable, > and then try to move a file to the memory card that resides in my cellphone, > in the middle of the file transfer the device disconnects, > and then I can't move my

[GIT PULL] USB/PHY driver changes patches for 4.10-rc1

2016-12-13 Thread Greg KH
The following changes since commit e5517c2a5a49ed5e99047008629f1cd60246ea0e: Linux 4.9-rc7 (2016-11-27 13:08:04 -0800) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git/ tags/usb-4.10-rc1 for you to fetch changes up to

Re: add URB_ZERO_PACKET in transfer_flags for usb-skeleton.c

2016-12-13 Thread Greg KH
On Tue, Dec 13, 2016 at 02:03:08PM +0900, Kim Jaejoong wrote: > Hi Oliver and Greg > > 2016-12-12 19:45 GMT+09:00 Oliver Neukum <oneu...@suse.com>: > > On Thu, 2016-12-08 at 16:16 +0100, Greg KH wrote: > >> On Fri, Dec 09, 2016 at 12:09:46AM +0900, Jae Joong K

Re: [PATCH] wusbcore: Fix one more crypto-on-the-stack bug

2016-12-12 Thread Greg KH
On Mon, Dec 12, 2016 at 12:52:45PM -0800, Andy Lutomirski wrote: > The driver put a constant buffer of all zeros on the stack and > pointed a scatterlist entry at it. This doesn't work with virtual > stacks. Make the buffer static to fix it. > > Cc: sta...@vger.kernel.org # 4.9 only >

Re: add URB_ZERO_PACKET in transfer_flags for usb-skeleton.c

2016-12-08 Thread Greg KH
On Fri, Dec 09, 2016 at 12:09:46AM +0900, Jae Joong Kim wrote: > > Do you have a driver that was based on this skeleton that needed this > > flag to be added to work properly? Has it been updated in the kernel > > source tree properly for it? > > > > Yes, Based on the skeleton driver, I made a

<    3   4   5   6   7   8   9   10   11   12   >