Re: add URB_ZERO_PACKET in transfer_flags for usb-skeleton.c

2016-12-08 Thread Greg KH
On Thu, Dec 08, 2016 at 05:20:28PM +0900, Jae Joong Kim wrote: > Hi Greg > > I think 'urb->transfer_flags' also has URB_ZERO_PACKET flag to handle > the data is aligned to an endpoint packet boundary. > > How do you think this change? > > diff --git a/drivers/usb/usb-skeleton.c

Re: Re: [PATCH] usb: chipidea: use better pattern with WARN_ON()

2016-12-07 Thread Greg KH
On Wed, Dec 07, 2016 at 03:00:29PM +, Atul Raj wrote: > On 7 Dec 2016 18:56, "Greg KH" <gre...@linuxfoundation.org> wrote: > > > > On Wed, Dec 07, 2016 at 05:46:09PM +0530, Atul Raj wrote: > > > Instead of using: > > > if

Re: [PATCH] usb: misc: rio500: fix result type for error message

2016-12-07 Thread Greg KH
On Wed, Dec 07, 2016 at 08:12:10PM +0900, Kim Jae Joong wrote: > Fix variable type for dev_err about usb_bulk_msg() What was wrong with it before this change? What warning are you "changing"? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body

Re: [PATCH] usb: chipidea: use better pattern with WARN_ON()

2016-12-07 Thread Greg KH
On Wed, Dec 07, 2016 at 05:46:09PM +0530, Atul Raj wrote: > Instead of using: > if (cond) { >WARN_ON(1); >do_stuff(); > } > > Use a better pattern with WARN_ON() placed in if condition: > > if (WARN_ON(cond)) >do_stuff(); Why? What does this help with? And why are you sending

Re: [PATCH] add dlink dwm-158 to usb-serial-option

2016-12-06 Thread 'Greg KH'
On Tue, Dec 06, 2016 at 09:18:40PM +0100, Giuseppe Lippolis wrote: > > Any chance you can resend this in a format we can apply it in (tabs > properly > > used, no line-wrap, correct signed-off-by, good subject and changelog > text, > > etc.)? > > Adding registration for 3G modem DWM-158 in

Re: [PATCH] add dlink dwm-158 to usb-serial-option

2016-12-06 Thread Greg KH
On Tue, Dec 06, 2016 at 08:55:02PM +0100, Giuseppe Lippolis wrote: > I all, > This patch will add the 3G modem dwm-158 found inside the DWR-512 from > Dlink. > The modem have 2 cdc_ether interface and 4 usb-serial. > > I tested the patch in the current lede system and compiled on the latest >

Re: [PATCH 0/2] USB: resume time optimization by using spec minimums

2016-12-03 Thread Greg KH
On Fri, Dec 02, 2016 at 10:36:59PM -0800, Todd Brandt wrote: > The USB resume code in the kernel currently uses a set of hard coded > delay values that are defined in the USB 2.0 spec. Specifically these > three have the most effect on resume time: > > - tdrsmdn: resume signal time (20ms -

Re: [PATCH 2/2] USB: resume timing debug

2016-12-03 Thread Greg KH
On Fri, Dec 02, 2016 at 10:37:01PM -0800, Todd Brandt wrote: > Add debug support for experimenting with USB timing delay > values on the fly. This provides a debug interface through > /sys/kernel/usb where a user can tweak the values. The code > enforces the spec minimums so that a user can't set

Re: [PATCHv13 2/3] usb: USB Type-C connector class

2016-12-02 Thread Greg KH
On Fri, Dec 02, 2016 at 10:04:39AM -0800, Guenter Roeck wrote: > The driver interface is not my area of expertise. As such, my testing > and understanding of that part was limited to "it appears to work, > it must be ok". I very much relied on you to get this part right. > > That makes me feel

Re: [PATCH v2] usbip: vudc: fix: Clear already_seen flag also for ep0

2016-12-02 Thread Greg KH
On Fri, Dec 02, 2016 at 08:23:49AM -0700, Shuah Khan wrote: > On 12/01/2016 11:14 AM, Krzysztof Opasiak wrote: > > ep_list inside gadget structure doesn't contain ep0. > > It is stored separately in ep0 field. > > > > This causes an urb hang if gadget driver decides to > > delay setup handling.

Re: XHCI controller does not detect USB key insertion

2016-12-02 Thread Greg KH
On Fri, Dec 02, 2016 at 12:08:21PM +0100, Mason wrote: > On 02/12/2016 11:42, Greg KH wrote: > > > On Fri, Dec 02, 2016 at 11:24:05AM +0100, Mason wrote: > > > >> # lsusb -v > >> Bus 001 Device 001: ID 1d6b:0002 > >> Bus 002 Device 001: ID 1d6

Re: XHCI controller does not detect USB key insertion

2016-12-02 Thread Greg KH
On Fri, Dec 02, 2016 at 11:24:05AM +0100, Mason wrote: > >> # lsusb -v > >> Bus 001 Device 001: ID 1d6b:0002 > >> Bus 002 Device 001: ID 1d6b:0003 > > Isn't lsusb verbose supposed to print much more than that? Yes, if you are using the usbutils version of 'lsusb', odds are this is busybox,

Re: [PATCH] usb: gadget: uvc: fix UVC_ATTR macro for UVCG_OPTS_ATTR

2016-12-01 Thread Greg KH
On Fri, Dec 02, 2016 at 11:52:02AM +0530, Jassi Brar wrote: > From: Jassi Brar > > Typo in commit 76e0da34c7cec5a7d introduced a bug that prevents > creation of streaming_{interval,maxpacket,maxburst} nodes for > invalid 'aname' node. > > Signed-off-by: Jassi Brar

Re: [PATCH] usb: host: xhci: remove braces for single statement

2016-12-01 Thread Greg KH
On Thu, Dec 01, 2016 at 10:42:59PM +0530, Amit Kushwaha wrote: > This patch fixes checkpatch.pl warning: > braces {} are not necessary for single statement blocks > > Signed-off-by: Amit Kushwaha {sigh} Why are you now not using your samsung email address? Please

Re: [PATCHv13 2/3] usb: USB Type-C connector class

2016-11-29 Thread Greg KH
On Thu, Nov 24, 2016 at 02:21:43PM +0200, Heikki Krogerus wrote: > The purpose of USB Type-C connector class is to provide > unified interface for the user space to get the status and > basic information about USB Type-C connectors on a system, > control over data role swapping, and when the port

Re: XHCI's lock usage on hardirq handler

2016-11-29 Thread Greg KH
On Tue, Nov 29, 2016 at 03:58:57PM +0200, Felipe Balbi wrote: > > Hi, > > Greg KH <g...@kroah.com> writes: > > On Tue, Nov 29, 2016 at 01:48:59PM +0200, Felipe Balbi wrote: > >> > >> Hi folks, > >> > >> I've been staring at this par

Re: [PATCHv12 2/3] usb: USB Type-C connector class

2016-11-29 Thread Greg KH
On Tue, Nov 29, 2016 at 02:48:46PM +0100, Oliver Neukum wrote: > On Tue, 2016-11-29 at 14:20 +0100, Greg KH wrote: > > On Tue, Nov 29, 2016 at 02:59:58PM +0200, Heikki Krogerus wrote: > > > Hi Guenter, > > > > > > On Mon, Nov 28, 2016 at 12:11:43PM -0800, Guent

Re: [PATCHv12 2/3] usb: USB Type-C connector class

2016-11-29 Thread Greg KH
On Tue, Nov 29, 2016 at 02:59:58PM +0200, Heikki Krogerus wrote: > Hi Guenter, > > On Mon, Nov 28, 2016 at 12:11:43PM -0800, Guenter Roeck wrote: > > Personally I don't really care about a module parameter; as mentioned above, > > I would expect the preference, if it needs to be selectable, to be

Re: XHCI's lock usage on hardirq handler

2016-11-29 Thread Greg KH
On Tue, Nov 29, 2016 at 01:48:59PM +0200, Felipe Balbi wrote: > > Hi folks, > > I've been staring at this part of the code for a while. To make things > easier here's the part of XHCI I mean: > > > irqreturn_t xhci_irq(struct usb_hcd *hcd) > > { > > struct xhci_hcd *xhci = hcd_to_xhci(hcd);

Re: [PATCH] usb: xhci: apply XHCI_PME_STUCK_QUIRK to Intel Apollo Lake

2016-11-27 Thread Greg KH
On Mon, Nov 28, 2016 at 09:53:52AM +0800, wan.ahmad.zainie.wan.moha...@intel.com wrote: > From: Wan Ahmad Zainie > > Intel Apollo Lake also requires XHCI_PME_STUCK_QUIRK. > Adding its PCI ID to quirk. > > Signed-off-by: Wan Ahmad Zainie

Re: [PATCH v2] usb: xhci: Remove unuseful 'return' and 'break' statement

2016-11-27 Thread Greg KH
On Mon, Nov 28, 2016 at 02:29:25PM +0800, Baolin Wang wrote: > Hi Mathias, > > On 24 November 2016 at 19:16, Baolin Wang wrote: > > Since these 'return' statements are not generally useful in void > > function, remove them. Also remove one unuseful 'break' statement > >

Re: [PATCH net 1/2] r8152: fix the sw rx checksum is unavailable

2016-11-25 Thread Greg KH
On Fri, Nov 25, 2016 at 07:49:35AM -0500, Mark Lord wrote: > On 16-11-25 04:53 AM, Greg KH wrote: > > On Thu, Nov 24, 2016 at 10:49:33PM -0500, Mark Lord wrote: > >> There is no possibility for them to be used for anything other than > >> USB receive buffers, for

Re: [PATCH net 1/2] r8152: fix the sw rx checksum is unavailable

2016-11-25 Thread Greg KH
On Fri, Nov 25, 2016 at 07:41:42AM -0500, Mark Lord wrote: > On 16-11-25 07:34 AM, Mark Lord wrote: > > On 16-11-25 04:53 AM, Greg KH wrote: > >> Note, there are "cheap" USB monitors that can be quite handy and that work > >> on Linux: > >>h

Re: [PATCH net 1/2] r8152: fix the sw rx checksum is unavailable

2016-11-25 Thread Greg KH
On Thu, Nov 24, 2016 at 10:49:33PM -0500, Mark Lord wrote: > There is no possibility for them to be used for anything other than > USB receive buffers, for this driver only. Nothing in the driver > or kernel ever writes to those buffers after initial allocation, > and only the driver and USB host

Re: [PATCH net 1/2] r8152: fix the sw rx checksum is unavailable

2016-11-24 Thread Greg KH
On Thu, Nov 24, 2016 at 02:10:36PM -0500, Mark Lord wrote: > On 16-11-24 02:00 PM, Greg KH wrote: > > On Thu, Nov 24, 2016 at 01:34:08PM -0500, Mark Lord wrote: > >> One thought: bulk data streams are byte streams, not packets. > >> Scheduling on the USB bus can break

Re: [PATCH net 1/2] r8152: fix the sw rx checksum is unavailable

2016-11-24 Thread Greg KH
On Thu, Nov 24, 2016 at 01:34:08PM -0500, Mark Lord wrote: > One thought: bulk data streams are byte streams, not packets. > Scheduling on the USB bus can break up larger transfers across > multiple in-kernel buffers. A "real" URB buffer on USB2 is max 512 bytes. > The driver is providing

Re: [PATCH net 1/2] r8152: fix the sw rx checksum is unavailable

2016-11-24 Thread Greg KH
On Thu, Nov 24, 2016 at 11:43:53AM -0500, Mark Lord wrote: > On 16-11-24 11:21 AM, David Miller wrote: > > From: Hayes Wang > > Date: Thu, 24 Nov 2016 13:26:55 + > > > > > I don't think the garbage results from our driver or device. > > This is my impression with what

[GIT PULL] USB driver fixes for 4.9-rc7

2016-11-24 Thread Greg KH
The following changes since commit a25f0944ba9b1d8a6813fd6f1a86f1bd59ac25a6: Linux 4.9-rc5 (2016-11-13 10:32:32 -0800) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git/ tags/usb-4.9-rc7 for you to fetch changes up to

Re: Problem with USB driver using two devices

2016-11-23 Thread Greg KH
On Wed, Nov 23, 2016 at 05:17:35PM +0100, Wolfgang Wilhelm wrote: > Thankyou very much for the really fast answer. > > I don't get any error messages and I can communicate with > the driver for the second device via ioctrl and write functions, > i.e. write registers and read registers via the

Re: Problem with USB driver using two devices

2016-11-23 Thread Greg KH
On Wed, Nov 23, 2016 at 05:35:45PM +0100, Greg KH wrote: > On Wed, Nov 23, 2016 at 05:17:35PM +0100, Wolfgang Wilhelm wrote: > > Thankyou very much for the really fast answer. > > > > I don't get any error messages and I can communicate with > > the driver for t

Re: Problem with USB driver using two devices

2016-11-23 Thread Greg KH
On Wed, Nov 23, 2016 at 02:14:23PM +0100, Wolfgang Wilhelm wrote: > Dear Sir, Hi! and putting stable@ in bcc: as this has nothing to do with stable kernel releases.> > > we are a small company FAST ComTec GmbH > (www.fastcomtec.com) and produce multichannel analyzers > with Windows

Re: [PATCH v13 00/10] usbip: exporting devices

2016-11-23 Thread Greg KH
On Tue, Nov 22, 2016 at 03:48:09PM +0900, Nobuo Iwata wrote: > Dear all, > > This series of patches adds exporting device operation to USB/IP. I would _love_ it if some of the people who are listed as MAINTAINERS of this code could actually review these patch series. I don't think I've seen

Re: [PATCH v2 3/3] usb: ohci-da8xx: rename driver to ohci-da8xx

2016-11-23 Thread Greg KH
On Mon, Nov 21, 2016 at 06:10:50PM +0100, Axel Haslam wrote: > Hi Greg, > > On Thu, Nov 3, 2016 at 5:03 PM, Axel Haslam wrote: > > The davinci ohci driver name (currently "ohci") is too generic. > > To be consistent with other usb dirvers, append the "-da8xx" postfix > > to

Re: [PATCHv11 2/3] usb: USB Type-C connector class

2016-11-22 Thread Greg KH
On Tue, Nov 22, 2016 at 09:58:13AM +0200, Heikki Krogerus wrote: > Hi Greg, > > On Mon, Nov 21, 2016 at 03:46:08PM +0100, Greg KH wrote: > > > > > + > > > > > +config TYPEC > > > > > + tristate > > > > > > >

Re: Flood of hub_ext_port_status failed (err = -71) messages

2016-11-22 Thread Greg KH
On Mon, Nov 21, 2016 at 09:52:56PM +, Simon Arlott wrote: > I have a 5-port USB 2.0 hub attached to a USB 3.0 host by a long length > of Cat 5e cable (via a pair of cheap USB<->Cat5e adapters from eBay) > that only works at full speed and doesn't stay connected all the time. Sounds like some

Re: [PATCHv11 2/3] usb: USB Type-C connector class

2016-11-21 Thread Greg KH
On Mon, Nov 21, 2016 at 03:11:03PM +0200, Heikki Krogerus wrote: > Hi Greg, > > On Mon, Nov 21, 2016 at 11:35:28AM +0100, Greg KH wrote: > > > +static void typec_partner_release(struct device *dev) > > > +{ > > > + struct typec_po

Re: [PATCHv11 2/3] usb: USB Type-C connector class

2016-11-21 Thread Greg KH
On Mon, Nov 21, 2016 at 03:27:41PM +0200, Heikki Krogerus wrote: > On Mon, Nov 21, 2016 at 11:33:11AM +0100, Greg KH wrote: > > On Thu, Nov 17, 2016 at 12:50:35PM +0200, Heikki Krogerus wrote: > > > The purpose of USB Type-C connector class is to provide > > > unified i

Re: [PATCHv11 2/3] usb: USB Type-C connector class

2016-11-21 Thread Greg KH
On Thu, Nov 17, 2016 at 12:50:35PM +0200, Heikki Krogerus wrote: > The purpose of USB Type-C connector class is to provide > unified interface for the user space to get the status and > basic information about USB Type-C connectors on a system, > control over data role swapping, and when the port

Re: [PATCHv11 2/3] usb: USB Type-C connector class

2016-11-21 Thread Greg KH
On Thu, Nov 17, 2016 at 12:50:35PM +0200, Heikki Krogerus wrote: > The purpose of USB Type-C connector class is to provide > unified interface for the user space to get the status and > basic information about USB Type-C connectors on a system, > control over data role swapping, and when the port

Re: [PATCH v2 1/5] cdc-acm: reindent log messages

2016-11-19 Thread Greg KH
On Fri, Nov 18, 2016 at 11:14:03AM +0100, Oliver Neukum wrote: > On Thu, 2016-11-17 at 23:56 +0100, Ladislav Michl wrote: > > Use only one tab to indent dev_{(v)dbg,err} parameters. > > > > Signed-off-by: Ladislav Michl > Acked-by: Oliver Neukum > For

Re: Writing a Brand New Driver

2016-11-19 Thread Greg KH
On Fri, Nov 18, 2016 at 02:13:03PM -0500, Brian Chrzanowski wrote: > Hi linux-usb, > > Quite simply, I would like to get into kernel development. I figured that I > could jumpstart this by writing a driver for this device: > >

Re: [PATCH v2] usb: hcd.h: construct hub class request conastants from simpler constants

2016-11-18 Thread Greg KH
On Fri, Nov 18, 2016 at 01:18:19PM +0200, Tal Shorer wrote: > Currently, each hub class request constant is defined by a line like: > > The "magic" number for the high byte is one of 0x20, 0xa0, 0x23, 0xa3. > The 0x80 bit that changes inditace USB_DIR_IN, and the 0x03 that > pops up is the

Re: [PATCH v2] usb: hcd.h: construct hub class request conastants from simpler constants

2016-11-18 Thread Greg KH
On Fri, Nov 18, 2016 at 01:18:19PM +0200, Tal Shorer wrote: > Currently, each hub class request constant is defined by a line like: > > The "magic" number for the high byte is one of 0x20, 0xa0, 0x23, 0xa3. Again, shouldn't there be something after your ":"? -- To unsubscribe from this list:

Re: [PATCH v3 1/1] usb: hub: Fix auto-remount of safely removed or ejected USB-3 devices

2016-11-17 Thread Greg KH
On Thu, Nov 17, 2016 at 11:14:14AM +0200, Mathias Nyman wrote: > USB-3 does not have any link state that will avoid negotiating a connection > with a plugged-in cable but will signal the host when the cable is > unplugged. > > For USB-3 we used to first set the link to Disabled, then to RxDdetect

Re: [PATCH 0/6] musb-fixes for v4.9-rc6

2016-11-16 Thread Greg KH
On Wed, Nov 16, 2016 at 01:21:21PM -0600, Bin Liu wrote: > Hi Greg, > > Hope this is not too late for -rc6. This set fixes a long standing musb > regression introduced in v4.8. Please let me know if any change is needed. As these were bugs in 4.8 (i.e. not a regression due to changes in

Re: cdc_mbim: probe of 2-2:1.12 failed with error -22

2016-11-16 Thread Greg KH
On Wed, Nov 16, 2016 at 06:56:30PM +0800, Kai-Heng Feng wrote: > On Wed, Nov 16, 2016 at 6:47 PM, Greg KH <g...@kroah.com> wrote: > > On Wed, Nov 16, 2016 at 06:42:27PM +0800, Kai-Heng Feng wrote: > >> Originally I sent a not-working patch to the mailing list [1], turns &

Re: [PATHCv10 1/2] usb: USB Type-C connector class

2016-11-16 Thread Greg KH
On Wed, Nov 16, 2016 at 05:20:24PM +0200, Heikki Krogerus wrote: > Hi Greg, > > On Mon, Nov 14, 2016 at 10:51:48AM +0100, Greg KH wrote: > > > +static int sysfs_strmatch(const char * const *array, size_t n, const > > > char *str) > > > +{ > &g

Re: cdc_mbim: probe of 2-2:1.12 failed with error -22

2016-11-16 Thread Greg KH
On Wed, Nov 16, 2016 at 06:42:27PM +0800, Kai-Heng Feng wrote: > Originally I sent a not-working patch to the mailing list [1], turns > out the patch is far from correct. > > Bjørn Mork suggests that we can cover the USB3 pair diff pins with > tape to do some experiment, but the vendor told me

Re: [PATHCv10 1/2] usb: USB Type-C connector class

2016-11-16 Thread Greg KH
On Wed, Nov 16, 2016 at 11:30:35AM +0200, Heikki Krogerus wrote: > On Tue, Nov 15, 2016 at 04:19:10PM -0800, Badhri Jagan Sridharan wrote: > > Hi, > > > > At present I am using the uevent in the userspace to infer > > the Presence of a port on the remote end through the > > appearance of

Re: add usb option device

2016-11-15 Thread 'Greg KH'
On Tue, Nov 15, 2016 at 08:46:31PM +0100, Giuseppe Lippolis wrote: > Here it is: > > --- a/linux-4.4.23/drivers/usb/serial/option.c2016-09-30 > 10:20:43.0 +0200 > +++ b/linux-4.4.30/drivers/usb/serial/option.c 2016-11-14 > 21:01:15.738450136 +0100 > @@ -306,6 +306,9 @@

Re: add usb option device

2016-11-15 Thread Greg KH
On Tue, Nov 15, 2016 at 08:13:56PM +0100, Giuseppe Lippolis wrote: > Dear all, > I'm porting the Dlink DWR-512 device to LEDE (embedded linux). > This device embed a 3G modem connected through the usb bus . > The modem work properly with the option kernel module. > > I added these line in the >

Re: USB stops working if a malfunctioning USB device is connected

2016-11-15 Thread Greg KH
On Wed, Nov 16, 2016 at 12:12:53AM +0530, PrasannaKumar Muralidharan wrote: > >> scripts/kconfig/conf --silentoldconfig Kconfig > >> CHK include/config/kernel.release > >> Cannot use CONFIG_CC_STACKPROTECTOR_STRONG: -fstack-protector-strong > >> not supported by compiler > >> make: ***

Re: [PATCH v2 1/1] usb: chipidea: move the lock initialization to core file

2016-11-15 Thread Greg KH
On Tue, Nov 15, 2016 at 11:32:02AM +0200, Felipe Balbi wrote: > > Hi, > > Peter Chen <hzpeterc...@gmail.com> writes: > > On Tue, Nov 15, 2016 at 07:58:16AM +0100, Greg KH wrote: > >> On Tue, Nov 15, 2016 at 02:02:47PM +0800, Peter Chen wrote: > >&g

Re: [PATHCv10 1/2] usb: USB Type-C connector class

2016-11-14 Thread Greg KH
On Mon, Nov 14, 2016 at 12:46:50PM -0800, Guenter Roeck wrote: > On Mon, Nov 14, 2016 at 02:32:35PM +0200, Heikki Krogerus wrote: > > Hi Greg, > > > > On Mon, Nov 14, 2016 at 10:51:48AM +0100, Greg KH wrote: > > > On Mon, Sep 19, 2016 at 02:16:56P

Re: [GIT PULL] USB: chipidea fixes for v4.9

2016-11-14 Thread Greg KH
On Tue, Nov 15, 2016 at 02:05:49PM +0800, Peter Chen wrote: > On Mon, Nov 14, 2016 at 12:48:45PM +0100, Greg KH wrote: > > On Mon, Nov 14, 2016 at 10:01:53AM +0800, Peter Chen wrote: > > > The following changes since commit > > > 18266403f3fe507f0246faa1d5432333a2f139

Re: [PATCH v2 1/1] usb: chipidea: move the lock initialization to core file

2016-11-14 Thread Greg KH
On Tue, Nov 15, 2016 at 02:02:47PM +0800, Peter Chen wrote: > This can fix below dump when the lock is accessed at host > mode due to it is not initialized. > > [ 46.119638] INFO: trying to register non-static key. > [ 46.124643] the code is fine but needs lockdep annotation. > [ 46.130144]

Re: [PATHCv10 1/2] usb: USB Type-C connector class

2016-11-14 Thread Greg KH
On Mon, Nov 14, 2016 at 04:39:10PM +0200, Heikki Krogerus wrote: > On Mon, Nov 14, 2016 at 03:11:23PM +0100, Greg KH wrote: > > On Mon, Nov 14, 2016 at 02:32:35PM +0200, Heikki Krogerus wrote: > > > > > +static void __exit typec_exit(void) > > > > > +{

Re: [PATCH 1/1] usb: chipidea: move the lock initialization to core file

2016-11-14 Thread Greg KH
On Mon, Oct 31, 2016 at 09:55:40AM +0800, Peter Chen wrote: > This can fix below dump when the lock is accessed at host > mode due to it is not initialized. > > root@imx6qdlsolo:~# cat /sys/kernel/debug/ci_hdrc.1/port_test > [ 929.904518] INFO: trying to register non-static key. > [ 929.909536]

Re: [PATHCv10 1/2] usb: USB Type-C connector class

2016-11-14 Thread Greg KH
On Mon, Nov 14, 2016 at 02:32:35PM +0200, Heikki Krogerus wrote: > > > +static void __exit typec_exit(void) > > > +{ > > > + class_unregister(_class); > > > > You forgot to clean up your idr :( > > Sorry, what idr? The port ids get removed in typec_release(). You have a static idr structure in

Re: [GIT PULL] USB: chipidea fixes for v4.9

2016-11-14 Thread Greg KH
On Mon, Nov 14, 2016 at 10:01:53AM +0800, Peter Chen wrote: > The following changes since commit 18266403f3fe507f0246faa1d5432333a2f139ca: > > USB: cdc-acm: fix TIOCMIWAIT (2016-11-10 13:12:59 +0100) > > are available in the git repository at: > >

Re: [PATHCv10 1/2] usb: USB Type-C connector class

2016-11-14 Thread Greg KH
On Mon, Sep 19, 2016 at 02:16:56PM +0300, Heikki Krogerus wrote: > The purpose of USB Type-C connector class is to provide > unified interface for the user space to get the status and > basic information about USB Type-C connectors on a system, > control over data role swapping, and when the port

Re: [PATCH] usb: core: urb make use of usb_endpoint_maxp_mult

2016-11-14 Thread Greg KH
On Sun, Nov 13, 2016 at 01:31:16PM +0300, Mike Krinkin wrote: > Since usb_endpoint_maxp now returns only lower 11 bits mult > calculation here isn't correct anymore and that breaks webcam > for me. Patch make use of usb_endpoint_maxp_mult instead of > direct calculation. > > Fixes: abb621844f6a

Re: [PATCH 00/23] xhci features for usb-next

2016-11-14 Thread Greg KH
On Mon, Nov 14, 2016 at 10:58:18AM +0200, Mathias Nyman wrote: > On 14.11.2016 09:49, Greg KH wrote: > > On Fri, Nov 11, 2016 at 03:13:09PM +0200, Mathias Nyman wrote: > > > Hi Greg > > > > > > In addition to all the xhci cleanups, refactoring, and features for

Re: [PATCH 00/23] xhci features for usb-next

2016-11-13 Thread Greg KH
On Fri, Nov 11, 2016 at 03:13:09PM +0200, Mathias Nyman wrote: > Hi Greg > > In addition to all the xhci cleanups, refactoring, and features for > xhci, there's a patch for usb core hub driver that changes how usb3 > devices are disabled. > > It fixes a automatic re-mount issue seen when users

Re: [PATHCv10 0/2] USB Type-C Connector class

2016-11-13 Thread Greg KH
On Fri, Nov 11, 2016 at 01:04:24PM +0200, Heikki Krogerus wrote: > On Thu, Nov 10, 2016 at 01:36:09PM -0800, Guenter Roeck wrote: > > On Mon, Sep 19, 2016 at 02:16:55PM +0300, Heikki Krogerus wrote: > > > The USB Type-C class is meant to provide unified interface to the > > > userspace to present

[GIT PULL] USB driver fixes for 4.9-rc5

2016-11-13 Thread Greg KH
The following changes since commit a909d3e636995ba7c349e2ca5dbb528154d4ac30: Linux 4.9-rc3 (2016-10-29 13:52:02 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git/ tags/usb-4.9-rc5 for you to fetch changes up to

Re: [PATCH v12 3/9] usbip: exporting devices: new connect operation

2016-11-10 Thread Greg KH
On Thu, Oct 13, 2016 at 12:52:07PM +0900, Nobuo Iwata wrote: > New connect operation. Again, we need more text. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH v12 6/9] usbip: exporting devices: modifications to attach and detach

2016-11-10 Thread Greg KH
On Thu, Oct 13, 2016 at 12:52:10PM +0900, Nobuo Iwata wrote: > Refactoring to attach and detatch operation. Common parts to new > application(vhci)-side daemon are moved to libsrc/vhci_driver.c. why do this refactoring? please say so why here. thanks, greg k-h -- To unsubscribe from this

Re: [PATCH v12 8/9] usbip: exporting devices: change to usbip_list.c

2016-11-10 Thread Greg KH
On Thu, Oct 13, 2016 at 12:52:12PM +0900, Nobuo Iwata wrote: > Correction to wording inconsistency around import and export in > usbip_list.c. > > Please, see also cover letter about wording. there is no cover letter when the commits are merged, so please put it here as well. thanks, greg k-h

Re: [PATCH v12 5/9] usbip: exporting devices: modifications to daemon

2016-11-10 Thread Greg KH
On Thu, Oct 13, 2016 at 12:52:09PM +0900, Nobuo Iwata wrote: > Refactoring to the daemon. why? -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v12 7/9] usbip: exporting devices: new application-side daemon

2016-11-10 Thread Greg KH
On Thu, Oct 13, 2016 at 12:52:11PM +0900, Nobuo Iwata wrote: > New application(vhci)-side daemon. Again, more text here please. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH v12 4/9] usbip: exporting devices: new disconnect operation

2016-11-10 Thread Greg KH
On Thu, Oct 13, 2016 at 12:52:08PM +0900, Nobuo Iwata wrote: > New disconnect operation. We need a lot more text here than just this, as it does not explain why this patch is needed at all :( > > Signed-off-by: Nobuo Iwata > --- > tools/usb/usbip/src/Makefile.am

Re: [PATCH v12 2/9] usbip: exporting devices: modifications to host side libraries

2016-11-10 Thread Greg KH
On Thu, Oct 13, 2016 at 12:52:06PM +0900, Nobuo Iwata wrote: > usbip_get_device() method in usbip_host_driver_ops was not used. It is > modified as a function to find an exported device for new operations > 'connect' and 'disconnect'. > > bind and unbind function are exported for the new

Re: [PATCH v12 1/9] usbip: exporting devices: modifications to network header

2016-11-10 Thread Greg KH
On Thu, Oct 13, 2016 at 12:52:05PM +0900, Nobuo Iwata wrote: > Modification to export and un-export response in > tools/usb/usbip/src/usbip_network.h. It just changes return code type > from int to uint32_t as same as other responses. > > Added export and un-export request/response to >

Re: [PATCH v12 0/9] usbip: exporting devices

2016-11-10 Thread Greg KH
On Thu, Oct 13, 2016 at 12:52:04PM +0900, Nobuo Iwata wrote: > Dear all, > > This series of patches adds exporting device operation to USB/IP. What do you mean by "exporting"? You never really explain that, so again, I don't understand why this patchset is needed :( thanks, greg k-h -- To

Re: [PATCH v6 2/2] usbip: vhci extension: dynamic extension

2016-11-10 Thread Greg KH
On Fri, Sep 30, 2016 at 02:41:54PM +0900, Nobuo Iwata wrote: > Modification for dynamic device registration and unregistration. > > 1. kernel config > > Followings are added. > > USBIP_VHCI_HC_PORTS: Number of ports per USB/IP virtual host > controller. The default is 8 - same as current

Re: [PATCH v3 00/10] Add DT support for ohci-da8xx

2016-11-10 Thread Greg KH
On Tue, Nov 08, 2016 at 05:37:41PM +0100, Axel Haslam wrote: > Hi, > > On Mon, Nov 7, 2016 at 9:39 PM, Axel Haslam wrote: > > The purpose of this patch series is to add DT support for the davinci > > ohci driver. > > > > To make it easier to review. I will split the

Re: [PATCH v4] Net Driver: Add Cypress GX3 VID=04b4 PID=3610.

2016-11-07 Thread Greg KH
On Mon, Nov 07, 2016 at 04:44:20PM -0600, Chris Roth wrote: > From: Allan Chou > > Add support for Cypress GX3 SuperSpeed to Gigabit Ethernet > Bridge Controller (Vendor=04b4 ProdID=3610). > > Patch verified on x64 linux kernel 4.7.4, 4.8.6, 4.9-rc4 systems > with the

[PATCH] usb: storage: drop freezer.h usage

2016-10-31 Thread Greg KH
From: Greg Kroah-Hartman usb-storage does not use any freezer apis, so drop the inclusion of freezer.h from the drivers/usb/storage/usb.c file. Signed-off-by: Greg Kroah-Hartman diff --git a/drivers/usb/storage/usb.c

[GIT PULL] USB driver fixes for 4.9-rc3

2016-10-29 Thread Greg KH
The following changes since commit 1001354ca34179f3db924eb66672442a173147dc: Linux 4.9-rc1 (2016-10-15 12:17:50 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git/ tags/usb-4.9-rc3 for you to fetch changes up to

Re: [PATCH] Staging: wilc1000: Remove unused structure

2016-10-26 Thread Greg KH
On Wed, Oct 26, 2016 at 11:00:07PM +0300, Muraru Mihaela wrote: > On Tue, Oct 25, 2016 at 08:37:50AM +0200, Greg KH wrote: > > On Mon, Oct 24, 2016 at 10:56:45PM +0300, Mihaela Muraru wrote: > > > This is a parch to the emxx_udc.c file that remove the > > > 'usb_d

Re: [GIT PULL] usb: chipidea: fixes for v4.9

2016-10-26 Thread Greg KH
On Wed, Oct 26, 2016 at 11:03:20AM +0800, Peter Chen wrote: > The following changes since commit b76032396d7958f006bccf5fb2535beb5526837c: > > usb: renesas_usbhs: add wait after initialization for R-Car Gen3 > (2016-10-24 14:35:46 +0200) > > are available in the git repository at: > >

Re: [PATCH] usbip: checkpatch; fix bare use of unsigned

2016-10-25 Thread Greg KH
On Tue, Oct 25, 2016 at 02:01:30PM +0530, Jai Krishna wrote: > Signed-off-by: Jai Krishna > --- > drivers/usb/usbip/vudc_dev.c | 8 > drivers/usb/usbip/vudc_transfer.c | 6 +++--- > 2 files changed, 7 insertions(+), 7 deletions(-) I can't take patches with no

Re: [PATCH resend] usb: increase ohci watchdog delay to 275 msec

2016-10-25 Thread Greg KH
On Mon, Oct 24, 2016 at 08:40:35AM -0400, Bryan Paluch wrote: > I don't think this patch is needed anymore. There are fixes to the timer wheel > code that fix the issue properly. Timers were firing much earlier than 250 ms > and setting the timer to 275 must have changed the resolution from 4 ms

Re: [PATCH] staging: usbip: fix checkstyle warnings

2016-10-25 Thread Greg KH
On Mon, Oct 24, 2016 at 10:46:13AM +0530, Jai Krishna wrote: > Fixing checkstyle warnings except symbolic permission warnings > (e.g. for S_IWUSR etc.). The symbolic permission warnings seem > to be widespread; so not fixing those as Im likely missing > some context on why these are widespread. >

Re: [PATCH] Staging: wilc1000: Remove unused structure

2016-10-25 Thread Greg KH
On Mon, Oct 24, 2016 at 10:56:45PM +0300, Mihaela Muraru wrote: > This is a parch to the emxx_udc.c file that remove the > 'usb_device_descriptor' structure because it is not used in the current > file or in other one. > > Signed-off-by: Mihaela Muraru > --- >

Re: [PATCH resend] usb: increase ohci watchdog delay to 275 msec

2016-10-24 Thread Greg KH
On Mon, Oct 17, 2016 at 08:54:46AM -0400, Bryan Paluch wrote: > Increase ohci watchout delay to 275 ms. Previous delay was 250 ms > with 20 ms of slack, after removing slack time some ohci controllers don't > respond in time. Logs from systems with controllers that have the > issue would show

Re: [PATCH] USB: update intro of documentation

2016-10-24 Thread Greg KH
On Fri, Oct 21, 2016 at 03:17:14PM -0600, Jonathan Corbet wrote: > On Thu, 20 Oct 2016 15:15:00 +0200 > Oliver Neukum wrote: > > > It does no good to mention The 2.4 kernel series and neglect > > USB 3.x and XHCI. Also with type C and micro/mini USB we better > > not talk about

Re: [PATCH 2/2] USB: UHCI: report non-PME wakeup signalling for Intel hardware

2016-10-22 Thread Greg KH
On Fri, Oct 21, 2016 at 04:49:07PM -0400, Alan Stern wrote: > The UHCI controllers in Intel chipsets rely on a platform-specific > non-PME mechanism for wakeup signalling. They can generate wakeup > signals even though they don't support PME. > > We need to let the USB core know this so that it

Re: Interactive whiteboards

2016-10-21 Thread Greg KH
On Thu, Oct 20, 2016 at 10:46:11AM +0200, María Cano wrote: > >> HITACHI STARBOARD (DOESN’T WORK) > >> DIFF FOR cat /proc/bus/input/devices > >> > T: Bus=04 Lev=01 Prnt=01 Port=00 Cnt=01 Dev#= 12 Spd=12 MxCh= 0 > >> > D: Ver= 1.10 Cls=00(>ifc ) Sub=00 Prot=00 MxPS=64 #Cfgs= 1 > >> > P:

Re: Interactive whiteboards

2016-10-20 Thread Greg KH
On Thu, Oct 20, 2016 at 10:09:22AM +0200, María Cano wrote: > I have to visit other school where I work too, but here is a summary > of datas found related with the whiteboard we have. I have to say It > is a summary because we have several whiteboards that are apparently > made by the same

Re: All USB devices stop working. Their reconnect not helps

2016-10-19 Thread Greg KH
On Tue, Oct 18, 2016 at 01:54:30PM +0500, Михаил Гаврилов wrote: > Excuse me I don't see that my previous message appeared in mail > archive list. So I repeat my previous message. > > On 14 October 2016 at 19:13, Greg KH <gre...@linuxfoundation.org> wrote: > > xfs havi

Re: [PATCH] usb: increase ohci watchdog delay to 275 msec

2016-10-17 Thread Greg KH
On Sun, Oct 16, 2016 at 10:54:34AM -0400, Alan Stern wrote: > On Sat, 15 Oct 2016, Bryan Paluch wrote: > > > Increase ohci watchout delay to 275 ms. Previous delay was 250 ms > > with 20 ms of slack, after removing slack time some ohci controllers don't > > respond in time. Logs from systems with

Re: [PATCH] wusb: Stop using the stack for sg crypto scratch space

2016-10-17 Thread Greg KH
On Sun, Oct 16, 2016 at 10:17:53AM -0700, Andy Lutomirski wrote: > On Thu, Oct 6, 2016 at 10:25 AM, Andy Lutomirski wrote: > > Pointing an sg list at the stack is verboten and, with > > CONFIG_VMAP_STACK=y, will malfunction. Use kmalloc for the wusb > > crypto stack space

Re: All USB devices stop working. Their reconnect not helps

2016-10-14 Thread Greg KH
On Fri, Oct 14, 2016 at 06:53:29PM +0500, Михаил Гаврилов wrote: > [ 16.685607] xhci_hcd :00:14.0: Timeout while waiting for setup device > command > [ 16.893766] usb 2-5.4: Device not responding to setup address. > [ 17.098457] usb 2-5.4: device not accepting address 6, error -71 > [

Re: Interactive whiteboards

2016-10-13 Thread Greg KH
A: http://en.wikipedia.org/wiki/Top_post Q: Were do I find info about this thing called top-posting? A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing in e-mail? A: No. Q: Should I

Re: Interactive whiteboards

2016-10-13 Thread Greg KH
On Thu, Oct 13, 2016 at 10:24:38AM +0200, María Cano wrote: > Ok, I still have more IWB to investigate. I'll paste the new information soon. > We use a 3.10 kernel in our day-to-day (because is the kernel we have > fewer problems) but if you think it is advisable, I can use a newer > kernel (I

Re: Interactive whiteboards

2016-10-13 Thread Greg KH
A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing in e-mail? A: No. Q: Should I include quotations after my reply? http://daringfireball.net/2007/07/on_top On Thu, Oct 13, 2016 at

Re: Interactive whiteboards

2016-10-11 Thread Greg KH
On Mon, Oct 10, 2016 at 10:54:07PM +0200, María Cano wrote: > The Linux kernel supports many devices and each day more and more are > included, but there is a device that looks completely abandoned: > whiteboards. In my immediate environment a lot of interactive > whiteboards do not work under

Re: USB will randomly stop working

2016-10-08 Thread Greg KH
On Sat, Oct 08, 2016 at 12:13:35PM -0700, Ashton Holmes wrote: > Alright I sent out an email to everyone on the patch describing the > issue with the syslog attachment and the git bisect output. And cc: this list and lkml? I don't see it anywhere... -- To unsubscribe from this list: send the

<    4   5   6   7   8   9   10   11   12   13   >