Re: [PATCH 1/2] usb: mtu3: add a vbus debugfs interface

2017-08-03 Thread Greg Kroah-Hartman
On Thu, Aug 03, 2017 at 09:00:57AM -0700, Greg Kroah-Hartman wrote: > On Thu, Aug 03, 2017 at 04:37:18PM +0800, Chunfeng Yun wrote: > > +static ssize_t ssusb_vbus_write(struct file *file, > > + const char __user *ubuf, size_t count, loff_t *ppos) > > +{ > > +

Re: [PATCH] USB: hcd: Mark secondary HCD as dead if the primary one died

2017-07-30 Thread Greg Kroah-Hartman
On Wed, Jul 26, 2017 at 07:07:51PM +0200, Rafael J. Wysocki wrote: > On Wednesday, July 26, 2017 10:21:54 AM Alan Stern wrote: > > On Tue, 25 Jul 2017, Rafael J. Wysocki wrote: > > > > > From: Rafael J. Wysocki > > > > > > Make usb_hc_died() clear the

Re: [PATCH 6/9] USB: misc: remove unneeded MODULE_VERSION() usage

2017-07-19 Thread Greg Kroah-Hartman
On Wed, Jul 19, 2017 at 02:30:20PM +0200, Richard Leitner wrote: > On 07/19/2017 02:17 PM, Greg Kroah-Hartman wrote: > > MODULE_VERSION is useless for in-kernel drivers, so just remove all > > usage of it in the USB misc drivers. Along with this, some > > DRIVER_VERSIO

Re: [PATCH 7/9] USB: phy: remove unneeded MODULE_VERSION() usage

2017-07-19 Thread Greg Kroah-Hartman
On Wed, Jul 19, 2017 at 03:27:18PM +0300, Felipe Balbi wrote: > > Hi, > > Greg Kroah-Hartman <gre...@linuxfoundation.org> writes: > > MODULE_VERSION is useless for in-kernel drivers, so remove the > > use of it in the marvel phy driver, along with the DRIVER_

Re: [PATCH 4/9] USB: gadget: remove unneeded MODULE_VERSION() usage

2017-07-19 Thread Greg Kroah-Hartman
On Wed, Jul 19, 2017 at 03:26:22PM +0300, Felipe Balbi wrote: > > Hi, > > Greg Kroah-Hartman <gre...@linuxfoundation.org> writes: > > MODULE_VERSION is useless for in-kernel drivers, so just remove all > > usage of it in the USB gadget drivers. Along with this,

[PATCH 6/9] USB: misc: remove unneeded MODULE_VERSION() usage

2017-07-19 Thread Greg Kroah-Hartman
Cesar Miquel <miq...@df.uba.ar> Cc: Richard Leitner <richard.leit...@skidata.com> Signed-off-by: Greg Kroah-Hartman <gre...@linuxfoundation.org> --- drivers/usb/misc/adutux.c | 2 -- drivers/usb/misc/chaoskey.c | 2 -- drivers/usb/misc/cytherm.c| 1 - drivers

[PATCH 8/9] USB: realtek_cr: remove unneeded MODULE_VERSION() usage

2017-07-19 Thread Greg Kroah-Hartman
MODULE_VERSION is useless for in-kernel drivers, so remove the use of it in the Realtek USB card reader driver. Cc: Alan Stern <st...@rowland.harvard.edu> Signed-off-by: Greg Kroah-Hartman <gre...@linuxfoundation.org> --- drivers/usb/storage/realtek_cr.c | 1 - 1 file changed

[PATCH 7/9] USB: phy: remove unneeded MODULE_VERSION() usage

2017-07-19 Thread Greg Kroah-Hartman
MODULE_VERSION is useless for in-kernel drivers, so remove the use of it in the marvel phy driver, along with the DRIVER_VERSION define. Cc: Felipe Balbi <ba...@kernel.org> Signed-off-by: Greg Kroah-Hartman <gre...@linuxfoundation.org> --- drivers/usb/phy/phy-mv-usb.c | 2 -- 1 fil

[PATCH 5/9] USB: microtek: remove unneeded DRIVER_VERSION macro

2017-07-19 Thread Greg Kroah-Hartman
No one uses the DRIVER_VERSION define in this driver, so just delete it. Cc: Oliver Neukum <oneu...@suse.com> Signed-off-by: Greg Kroah-Hartman <gre...@linuxfoundation.org> --- drivers/usb/image/microtek.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/usb/image/

[PATCH 3/9] USB: cdc-wdm: remove unneeded DRIVER_VERSION define

2017-07-19 Thread Greg Kroah-Hartman
No one uses the DRIVER_VERSION define in this driver, so just delete it. Cc: Oliver Neukum <oneu...@suse.com> Cc: "Bjørn Mork" <bj...@mork.no> Signed-off-by: Greg Kroah-Hartman <gre...@linuxfoundation.org> --- drivers/usb/class/cdc-wdm.c | 4 1 file changed

[PATCH 1/9] USB: atm: remove unneeded MODULE_VERSION() usage

2017-07-19 Thread Greg Kroah-Hartman
MODULE_VERSION is useless for in-kernel drivers, so just remove all usage of it in the USB ATM drivers. Along with this, some DRIVER_VERSION macros were removed as they are also pointless. Cc: Duncan Sands <duncan.sa...@free.fr> Signed-off-by: Greg Kroah-Hartman <gre...@linuxfound

[PATCH 4/9] USB: gadget: remove unneeded MODULE_VERSION() usage

2017-07-19 Thread Greg Kroah-Hartman
; Signed-off-by: Greg Kroah-Hartman <gre...@linuxfoundation.org> --- drivers/usb/gadget/legacy/webcam.c | 1 - drivers/usb/gadget/udc/mv_udc_core.c | 2 -- drivers/usb/gadget/udc/s3c2410_udc.c | 4 +--- 3 files changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/usb/gadget/legacy/w

[PATCH 9/9] USB: usbip: remove unneeded MODULE_VERSION() usage

2017-07-19 Thread Greg Kroah-Hartman
: Valentina Manea <valentina.mane...@gmail.com> Cc: Shuah Khan <sh...@kernel.org> Signed-off-by: Greg Kroah-Hartman <gre...@linuxfoundation.org> --- drivers/usb/usbip/stub_main.c| 2 -- drivers/usb/usbip/usbip_common.c | 2 -- drivers/usb/usbip/usbip_common.h | 2 -- drivers/us

[PATCH 2/9] USB: chipidea: remove unneeded MODULE_VERSION() usage

2017-07-19 Thread Greg Kroah-Hartman
MODULE_VERSION is useless for in-kernel drivers, so remove the use of it in the chipidea CI13XXX driver. Cc: Peter Chen <peter.c...@nxp.com> Signed-off-by: Greg Kroah-Hartman <gre...@linuxfoundation.org> --- drivers/usb/chipidea/ci_hdrc_pci.c | 1 - 1 file changed, 1 deletion(-)

[PATCH 0/9] USB: remove MODULE_VERSION usage

2017-07-19 Thread Greg Kroah-Hartman
... thanks, greg k-h Greg Kroah-Hartman (9): USB: atm: remove unneeded MODULE_VERSION() usage USB: chipidea: remove unneeded MODULE_VERSION() usage USB: cdc-wdm: remove unneeded DRIVER_VERSION define USB: gadget: remove unneeded MODULE_VERSION() usage USB: microtek: remove unneeded

Re: [GIT PULL] USB Fixes for v4.13-rc2

2017-07-19 Thread Greg Kroah-Hartman
On Wed, Jul 19, 2017 at 01:57:26PM +0300, Felipe Balbi wrote: > > Hi Greg, > > here's my first set of fixes for the current -rc cycle. Let me know if > you want anything to be changed. > > cheers > > The following changes since commit 5771a8c08880cdca3bfb4a3fc6d309d6bba20877: > > Linux

Re: [PATCH 3/5 v4] usb: pci-quirks: Protect the I/O port pair of SB800

2017-07-14 Thread Greg Kroah-Hartman
On Fri, Jul 14, 2017 at 10:34:20AM +0200, Boszormenyi Zoltan wrote: > 2017-06-22 15:21 keltezéssel, Zoltán Böszörményi írta: > > This patch uses the previously introduced macro called > > request_declared_muxed_region() to synchronize access to > > the I/O port pair 0xcd6 / 0xcd7 on SB800. > > >

Re: [PATCH 0/2] Workaround for uPD72020x USB3 chips

2017-07-13 Thread Greg Kroah-Hartman
On Wed, Jul 12, 2017 at 10:12:34PM -0500, Bjorn Helgaas wrote: > On Mon, Jul 10, 2017 at 04:52:28PM +0100, Marc Zyngier wrote: > > Ard and myself have just spent quite some time lately trying to pin > > down an issue in the DMA code which was taking the form of a PCIe USB3 > > controller issuing a

Re: [PATCH v3 1/1] usb:host:xhci support option to disable the xHCI USB2 HW LPM

2017-07-09 Thread Greg Kroah-Hartman
On Sun, Jul 09, 2017 at 12:38:19PM +0700, Thang Q. Nguyen wrote: > On Fri, Jun 23, 2017 at 10:02 AM, Thang Q. Nguyen wrote: > > XHCI specification 1.1 does not require xHCI-compliant controllers > > to always enable hardware USB2 LPM. However, the current xHCI > > driver always

Re: [PATCH] USB: serial: cp210x: add ID for CEL EM3588 USB ZigBee stick

2017-06-28 Thread Greg Kroah-Hartman
On Wed, Jun 28, 2017 at 07:17:25PM +0200, Johan Hovold wrote: > On Wed, Jun 28, 2017 at 06:23:25PM +0200, Jeremie RAPIN wrote: > > From: Jeremie Rapin > > > > Added the USB serial device ID for the CEL ZigBee EM3588 > > radio stick. > > > > Signed-off-by: Jeremie Rapin

Re: [GIT PULL] USB-serial updates for v4.13-rc1

2017-06-28 Thread Greg Kroah-Hartman
On Wed, Jun 28, 2017 at 11:04:18AM +0200, Johan Hovold wrote: > The following changes since commit 5ed02dbb497422bf225783f46e6eadd237d23d6b: > > Linux 4.12-rc3 (2017-05-28 17:20:53 -0700) > > are available in the git repository at: > >

Re: [GIT PULL] usb: chipidea changes for v4.13-rc1

2017-06-27 Thread Greg Kroah-Hartman
On Wed, Jun 21, 2017 at 10:47:53AM +0800, Peter Chen wrote: > The following changes since commit 2ea659a9ef488125eb46da6eb571de5eae5c43f6: > > Linux 4.12-rc1 (2017-05-13 13:19:49 -0700) > > are available in the git repository at: > >

Re: [GIT PULL] USB changes for v4.13 merge window

2017-06-19 Thread Greg Kroah-Hartman
On Mon, Jun 19, 2017 at 09:41:31AM +0300, Felipe Balbi wrote: > > Hi Greg, > > here's my pull request for the current merge window. Patches have been > in linux-next for a while and there's time for them to soak a little > more. > > Note that you're gonna get a conflict when merging this on >

Re: [GIT PULL] USB-serial fixes for v4.12-rc6

2017-06-19 Thread Greg Kroah-Hartman
On Fri, Jun 16, 2017 at 02:44:19PM +0200, Johan Hovold wrote: > The following changes since commit 32c1431eea4881a6b17bd7c639315010aeefa452: > > Linux 4.12-rc5 (2017-06-11 16:48:20 -0700) > > are available in the git repository at: > >

Re: [GIT PULL] USB-serial fixes for v4.12-rc6

2017-06-17 Thread Greg Kroah-Hartman
On Fri, Jun 16, 2017 at 02:44:19PM +0200, Johan Hovold wrote: > The following changes since commit 32c1431eea4881a6b17bd7c639315010aeefa452: > > Linux 4.12-rc5 (2017-06-11 16:48:20 -0700) > > are available in the git repository at: > >

Re: [PATCH v3 1/2] usb: typec: Add support for UCSI interface

2017-06-14 Thread Greg Kroah-Hartman
On Wed, Jun 14, 2017 at 09:45:46AM +0300, Heikki Krogerus wrote: > Hi Guenter, > > Gentle ping. After less than 2 days? Relax please... -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH 8/9] tty: ircomm: remove dead and broken ioctl code

2017-06-13 Thread Greg Kroah-Hartman
On Tue, Jun 13, 2017 at 11:57:14AM +0200, Johan Hovold wrote: > On Tue, Jun 13, 2017 at 11:48:41AM +0200, Greg Kroah-Hartman wrote: > > On Tue, Jun 06, 2017 at 12:27:04PM +0100, Alan Cox wrote: > > > On Tue, 6 Jun 2017 12:54:40 +0200 > > > Johan Hovo

Re: [PATCH 0/9] tty: drop broken alt-speed handling

2017-06-13 Thread Greg Kroah-Hartman
On Tue, Jun 06, 2017 at 12:54:32PM +0200, Johan Hovold wrote: > Setting an alt-speed using TIOCSSERIAL and SPD flags has been deprecated > since v2.1.69 and has been broken for all tty drivers but serial-core > since v3.10 and commit 6865ff222cca ("TTY: do not warn about setting > speed via

Re: [PATCH 8/9] tty: ircomm: remove dead and broken ioctl code

2017-06-13 Thread Greg Kroah-Hartman
On Tue, Jun 06, 2017 at 12:27:04PM +0100, Alan Cox wrote: > On Tue, 6 Jun 2017 12:54:40 +0200 > Johan Hovold wrote: > > > Remove three ifdefed and broken implementations of TIOCSSERIAL and > > TIOCGICOUNT, and parity handling in set_termios which had suffered > > severe bit

Re: [PATCH 03/11] Creation of "usb_device_auth" LSM hook

2017-06-12 Thread Greg Kroah-Hartman
sb/devices/DEVICE/authorized". > Using this hook an LSM could provide an higher level of granularity > than the current authorization interface. > > Signed-off-by: Salvatore Mesoraca <s.mesorac...@gmail.com> > Cc: linux-usb@vger.kernel.org > Cc: Greg Kroah-Hartman &l

[PATCH 4.11 078/150] usb: chipidea: imx: Do not access CLKONOFF on i.MX51

2017-06-12 Thread Greg Kroah-Hartman
") Cc: cphe...@gmail.com Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> Cc: linux-usb@vger.kernel.org Cc: linux-ker...@vger.kernel.org Signed-off-by: Andrey Smirnov <andrew.smir...@gmail.com> Signed-off-by: Peter Chen <peter.c...@nxp.com> Signed-off-by: Greg Kroah-Hartman <gre.

Re: [PATCH v1] usb: misc: usbsevseg: Use __sysfs_match_string() helper

2017-06-11 Thread Greg Kroah-Hartman
On Fri, Jun 09, 2017 at 03:08:45PM +0300, Andy Shevchenko wrote: > Use __sysfs_match_string() helper instead of open coded variant. __ functions shouldn't be exported, are you _sure_ this is a function you should be using? If so, shouldn't the api be fixed up instead? And kbuild is having a

[PATCH 11/11] USB: usbip: convert to use DRIVER_ATTR_RW

2017-06-09 Thread Greg Kroah-Hartman
We are trying to get rid of DRIVER_ATTR(), and the usbip driver attribute can be trivially changed to use DRIVER_ATTR_RW(). Cc: Valentina Manea <valentina.mane...@gmail.com> Cc: Shuah Khan <sh...@kernel.org> Cc: <linux-usb@vger.kernel.org> Signed-off-by: Greg

Re: [PATCH v2 24/27] usb: gadget: u_uac1: Kill set_fs() usage

2017-06-01 Thread Greg Kroah-Hartman
On Thu, Jun 01, 2017 at 10:58:47PM +0200, Takashi Iwai wrote: > With the new API to perform the in-kernel buffer copy, we can get rid > of set_fs() usage in this driver, finally. > > Signed-off-by: Takashi Iwai <ti...@suse.de> > --- Acked-by: Greg Kroah-Hartman <gr

Re: [PATCHv4] usb: typec: Add a sysfs node to manage port type

2017-05-26 Thread Greg Kroah-Hartman
eturn immediately if the current port_type > is same as the new port_type as suggested by Geunter Roeck > > Changelog since v3: > - Moved as much as code outside port_type_lock as suggested by > Geunter Roeck > - Removed Change-Id line from commit message identified by >

Re: [PATCH 3/3] usb: max3421-hcd: Remove function name from dev_dbg calls

2017-05-26 Thread Greg Kroah-Hartman
On Fri, May 26, 2017 at 02:32:42PM +0300, Alexander Amelkin wrote: > NOTE: > Please don't use the plain text here as a patch because it most probably is > corrupted by my webmail client. > Attached is a copy of the following text guaranteed to have correct > tabs/spaces. Why is this here

Re: [GIT][PULL] Improvements to max3421-hcd driver

2017-05-26 Thread Greg Kroah-Hartman
On Fri, May 26, 2017 at 02:22:47PM +0300, Alexander Amelkin wrote: > The following changes since commit 08332893e37af6ae779367e78e444f8f9571511d: > > Linux 4.12-rc2 (2017-05-21 19:30:23 -0700) > > are available in the git repository at: > >

Re: [RFC PATCH] staging: typec: Intel WhiskeyCove PMIC USB Type-C PHY driver

2017-05-26 Thread Greg Kroah-Hartman
On Fri, May 26, 2017 at 03:53:49PM +0300, Heikki Krogerus wrote: > Hi, > > My two cents. > > On Thu, May 25, 2017 at 10:12:27AM -0700, Guenter Roeck wrote: > > > What is keeping this code in staging at the moment? Who isn't agreeing > > > on the existing apis we have there? > > > > > > > I

Re: [PATCHv3] usb: typec: Add a sysfs node to manage port type

2017-05-26 Thread Greg Kroah-Hartman
On Fri, May 26, 2017 at 10:45:59AM -0700, Badhri Jagan Sridharan wrote: > User space applications in some cases have the need to enforce a > specific port type(DFP/UFP/DRP). This change allows userspace to > attempt setting the desired port type. Low level drivers can > however reject the request

Re: [PATCH] usb: mtu3: cleanup with list_first_entry_or_null()

2017-05-25 Thread Greg Kroah-Hartman
On Mon, May 22, 2017 at 09:21:33AM +0800, Chunfeng Yun wrote: > Hi, > On Sat, 2017-05-20 at 21:19 +0200, Greg Kroah-Hartman wrote: > > On Sun, May 21, 2017 at 02:05:31AM +0900, Masahiro Yamada wrote: > > > The combo of list_empty() and list_first_en

Re: [RFC PATCH] staging: typec: Intel WhiskeyCove PMIC USB Type-C PHY driver

2017-05-25 Thread Greg Kroah-Hartman
On Thu, May 25, 2017 at 11:04:19AM +0300, Heikki Krogerus wrote: > On Wed, May 24, 2017 at 08:22:35AM -0700, Guenter Roeck wrote: > > On Wed, May 24, 2017 at 05:08:10PM +0200, Greg Kroah-Hartman wrote: > > > On Wed, May 24, 2017 at 03:54:23PM +0300, Heikki Krogerus wrote: >

Re: [RFC PATCH] staging: typec: Intel WhiskeyCove PMIC USB Type-C PHY driver

2017-05-24 Thread Greg Kroah-Hartman
On Wed, May 24, 2017 at 03:54:23PM +0300, Heikki Krogerus wrote: > Driver for USB Type-C PHY on Intel WhiskeyCove PMIC that > works with Type-C Port Controller Manager to provide USB > Power Delivery and USB Type-C functionalities > > Signed-off-by: Heikki Krogerus

Re: [PATCH 3/3] mfd: twl: move header file out of I2C realm

2017-05-22 Thread Greg Kroah-Hartman
mfd}/twl.h| 0 > sound/soc/codecs/twl4030.c | 2 +- > 25 files changed, 26 insertions(+), 26 deletions(-) > rename include/linux/{i2c => mfd}/twl.h (100%) Acked-by: Greg Kroah-Hartman <gre...@linuxfoundation.org> -- To unsubscribe from this list: send t

Re: [PATCH 2/3] mfd: tps65010: move header file out of I2C realm

2017-05-22 Thread Greg Kroah-Hartman
es changed, 12 insertions(+), 12 deletions(-) > rename include/linux/{i2c => mfd}/tps65010.h (99%) Acked-by: Greg Kroah-Hartman <gre...@linuxfoundation.org> -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] usb: mtu3: cleanup with list_first_entry_or_null()

2017-05-20 Thread Greg Kroah-Hartman
On Sun, May 21, 2017 at 02:05:31AM +0900, Masahiro Yamada wrote: > The combo of list_empty() and list_first_entry() can be replaced with > list_first_entry_or_null(). > > Signed-off-by: Masahiro Yamada > --- > > drivers/usb/mtu3/mtu3.h | 8 ++-- > 1 file

Re: [GIT PULL] USB-serial fixes for v4.12-rc2

2017-05-19 Thread Greg Kroah-Hartman
On Fri, May 19, 2017 at 09:52:23AM +0200, Johan Hovold wrote: > The following changes since commit 2ea659a9ef488125eb46da6eb571de5eae5c43f6: > > Linux 4.12-rc1 (2017-05-13 13:19:49 -0700) > > are available in the git repository at: > >

Re: [REGRESSION] Failed network caused by: xhci: switch to pci_alloc_irq_vectors

2017-05-18 Thread Greg Kroah-Hartman
On Thu, May 18, 2017 at 11:42:34PM -0400, Steven Rostedt wrote: > > One of my the configs I use to test ftrace with (configs that have > caused failures in the past), has lots of irq issues and fails to > initialize the network of my box. I bisected the problem down to a > single commit, and when

Re: [PATCH] usb: typec: Defer checking of valid power role swap to low level drivers

2017-05-17 Thread Greg Kroah-Hartman
On Wed, May 17, 2017 at 12:32:19AM -0700, Badhri Jagan Sridharan wrote: > With this CL the lower level drivers are reponsible to check and make sure > that the role swap can be performed. What is a "CL"? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in

Re: [PATCH 7/7] usb: dwc3: add ReST documentation

2017-05-09 Thread Greg Kroah-Hartman
On Tue, May 09, 2017 at 12:29:15PM +0300, Felipe Balbi wrote: > > Hi, > > Greg Kroah-Hartman <gre...@linuxfoundation.org> writes: > > On Tue, May 09, 2017 at 10:10:45AM +0300, Felipe Balbi wrote: > >> > >> Hi, > >> > >> Felipe Balbi

Re: [PATCH 7/7] usb: dwc3: add ReST documentation

2017-05-09 Thread Greg Kroah-Hartman
On Tue, May 09, 2017 at 10:10:45AM +0300, Felipe Balbi wrote: > > Hi, > > Felipe Balbi writes: > > Document a few details about DWC3 in order to help people report bugs > > and debug DWC3. > > > > Signed-off-by: Felipe Balbi > > --- >

Re: [PATCH] usb: otg_whitelist: add 3 different USB 3.0 hubs.

2017-05-04 Thread Greg Kroah-Hartman
On Thu, May 04, 2017 at 04:10:53PM +0800, Macpaul Lin wrote: > This patch add supporting for 3 different USB 3.0 hubs > with different bDeviceProtocol values. What type of hubs are these? > > Signed-off-by: Macpaul Lin > --- > drivers/usb/core/otg_whitelist.h | 3 +++ > 1

Re: [PATCH v7 1/3] staging: typec: USB Type-C Port Manager (tcpm)

2017-04-28 Thread Greg Kroah-Hartman
On Fri, Apr 28, 2017 at 06:14:44AM -0700, Guenter Roeck wrote: > On 04/28/2017 12:28 AM, Greg Kroah-Hartman wrote: > > On Thu, Apr 27, 2017 at 02:09:56PM -0700, Guenter Roeck wrote: > > > --- /dev/null > > > +++ b/drivers/staging/typec/pd.h > > > @@ -0,0 +1,

Re: [PATCH 9/9] [HSLPM] usb: dwc2: Enable LPM

2017-04-28 Thread Greg Kroah-Hartman
On Fri, Apr 28, 2017 at 12:56:42PM +0400, Sevak Arakelyan wrote: > From: John Youn > > Set 'lpm_capable' flag in the gadget structure so > indicating that LPM is supported. > > Signed-off-by: Sevak Arakelyan No signed-off-by from John? -- To

Re: [PATCH v7 1/3] staging: typec: USB Type-C Port Manager (tcpm)

2017-04-28 Thread Greg Kroah-Hartman
On Thu, Apr 27, 2017 at 02:09:56PM -0700, Guenter Roeck wrote: > --- /dev/null > +++ b/drivers/staging/typec/pd.h > @@ -0,0 +1,281 @@ > +/* > + * Copyright 2015-2017 Google, Inc > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU

Re: [PATCH v6 1/2] usb: typec: USB Type-C Port Manager (tcpm)

2017-04-27 Thread Greg Kroah-Hartman
On Wed, Apr 26, 2017 at 06:15:08PM -0700, Guenter Roeck wrote: > On Wed, Apr 26, 2017 at 03:26:11PM -0700, Guenter Roeck wrote: > > From: Guenter Roeck > > > > This driver implements the USB Type-C Power Delivery state machine > > for both source and sink ports. Alternate

Re: [PATCH] usb: host: xhci: remove #ifdef around PM functions

2017-04-26 Thread Greg Kroah-Hartman
On Fri, Apr 21, 2017 at 11:42:54PM +0200, Arnd Bergmann wrote: > The #ifdef is slightly wrong as it doesn't cover the xhci_priv_resume_quirk() > function, causing a harmless warning: > > drivers/usb/host/xhci-plat.c:58:12: error: 'xhci_priv_resume_quirk' defined > but not used

Re: [PATCH] usb: musb: don't mark of_dev_auxdata as initdata

2017-04-26 Thread Greg Kroah-Hartman
On Tue, Apr 25, 2017 at 10:04:53PM +0200, Arnd Bergmann wrote: > The probe function is not __init since it can be called for deferred > probing or when unbinding/rebinding the device, and therefore it must > not reference objects in __initdata, as pointed out by this link > time warning: > >

Re: [PATCH v3] usb: misc: legousbtower: Fix buffers on stack

2017-04-26 Thread Greg Kroah-Hartman
On Tue, Apr 25, 2017 at 10:49:21PM +0300, Maksim Salau wrote: > Allocate buffers on HEAP instead of STACK for local structures > that are to be received using usb_control_msg(). > > Signed-off-by: Maksim Salau > Tested-by: Alfredo Rafael Vicente Boix ;

Re: [PATCH v2] usb: misc: legousbtower: Fix buffers on stack

2017-04-26 Thread Greg Kroah-Hartman
On Tue, Apr 25, 2017 at 10:28:42PM +0300, Maksim Salau wrote: > On Tue, 25 Apr 2017 20:04:24 +0200 > Greg Kroah-Hartman <gre...@linuxfoundation.org> wrote: > > > On Sat, Apr 22, 2017 at 07:24:37PM +0300, Maksim Salau wrote: > > > Allocate buffers on HEAP instead

Re: [PATCH v2] usb: misc: legousbtower: Fix buffers on stack

2017-04-25 Thread Greg Kroah-Hartman
On Sat, Apr 22, 2017 at 07:24:37PM +0300, Maksim Salau wrote: > Allocate buffers on HEAP instead of STACK for local structures > that are to be received using usb_control_msg(). > > Signed-off-by: Maksim Salau > Tested-by: Alfredo Rafael Vicente Boix >

Re: typec: tcpm/tcpci drivers acceptable for drivers/staging in v4.12 ?

2017-04-25 Thread Greg Kroah-Hartman
On Tue, Apr 25, 2017 at 10:54:02AM -0700, Guenter Roeck wrote: > On Tue, Apr 25, 2017 at 07:37:42PM +0200, Greg Kroah-Hartman wrote: > > On Tue, Apr 25, 2017 at 09:50:31AM -0700, Guenter Roeck wrote: > > > Hi Greg, > > > > > > would you be open to acceptin

Re: typec: tcpm/tcpci drivers acceptable for drivers/staging in v4.12 ?

2017-04-25 Thread Greg Kroah-Hartman
On Tue, Apr 25, 2017 at 09:50:31AM -0700, Guenter Roeck wrote: > Hi Greg, > > would you be open to accepting the tcpm [1] and tcpci [2] drivers into > drivers/staging for v4.12 ? What's the rush? > The drivers are not ready for prime time, yet there is interest by others > to have them

Re: [PATCH v2] usb: core: Warn if an URB's transfer_buffer is on stack

2017-04-25 Thread Greg Kroah-Hartman
On Tue, Apr 25, 2017 at 01:35:33PM +0300, Maksim Salau wrote: > > + } else if (object_is_on_stack(urb->transfer_buffer)) { > > + WARN_ONCE(1, "transfer buffer is on stack\n"); > > + ret = -EAGAIN; > > } else

Re: [PATCH] usb: core: Warn if an URB's transfer_buffer is on stack

2017-04-23 Thread Greg Kroah-Hartman
On Sat, Apr 22, 2017 at 05:31:27PM -0400, Alan Stern wrote: > On Sat, 22 Apr 2017, Florian Fainelli wrote: > > > We see a large number of fixes to several drivers to remove the usage of > > on-stack buffers feeding into USB transfer functions. Make it easier to spot > > the offenders by adding a

Re: [PATCH] USB: legousbtower: Fix buffers on stack

2017-04-21 Thread Greg Kroah-Hartman
On Fri, Apr 21, 2017 at 10:48:48PM +0300, Maksim Salau wrote: > Allocate buffers on HEAP instead of STACK for local structures > that are to be received using usb_control_msg(). > > Signed-off-by: Maksim Salau > --- > > I took the liberty to fix the module if Greg don't

Re: [GIT PULL] USB-serial updates for v4.12-rc1

2017-04-20 Thread Greg Kroah-Hartman
On Thu, Apr 20, 2017 at 04:42:11PM +0200, Johan Hovold wrote: > The following changes since commit 4495c08e84729385774601b5146d51d9e5849f81: > > Linux 4.11-rc2 (2017-03-12 14:47:08 -0700) > > are available in the git repository at: > >

Re: [PATCH v4 4/6] usb.rst: move documentation from proc_usb_info.txt to USB ReST book

2017-04-18 Thread Greg Kroah-Hartman
.rst, adjusting it to point to > the right places. > > Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> Acked-by: Greg Kroah-Hartman <gre...@linuxfoundation.org> -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to

Re: [PATCH v4 2/6] usb: fix some references for /proc/bus/usb

2017-04-18 Thread Greg Kroah-Hartman
On Sun, Apr 16, 2017 at 09:51:07PM -0300, Mauro Carvalho Chehab wrote: > Since when we got rid of usbfs, the /proc/bus/usb is now > elsewhere. Fix references for it. > > Signed-off-by: Mauro Carvalho Chehab Oops, will take this one instead... -- To unsubscribe from

Re: [PATCH v3 2/3] usb: fix some references for /proc/bus/usb

2017-04-18 Thread Greg Kroah-Hartman
On Sun, Apr 16, 2017 at 01:40:04PM -0300, Mauro Carvalho Chehab wrote: > Since when we got rid of usbfs, the /proc/bus/usb is now > elsewhere. Fix references for it. > > Signed-off-by: Mauro Carvalho Chehab As this touches USB code, I'll take this in my tree. thanks,

Re: [PATCH v3 1/3] docs-rst: usb: update old usbfs-related documentation

2017-04-18 Thread Greg Kroah-Hartman
vices are > now placed. > > Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> Acked-by: Greg Kroah-Hartman <gre...@linuxfoundation.org> -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord..

Re: [PATCH v2 00/21] Convert USB documentation to ReST format

2017-04-11 Thread Greg Kroah-Hartman
On Tue, Apr 11, 2017 at 03:36:39PM -0300, Mauro Carvalho Chehab wrote: > Em Tue, 11 Apr 2017 16:58:40 +0200 > Greg Kroah-Hartman <gre...@linuxfoundation.org> escreveu: > > > On Sat, Apr 08, 2017 at 10:04:33PM +0200, Greg Kroah-Hartman wrote: > > > On Sat, Ap

Re: [PATCH v2 00/21] Convert USB documentation to ReST format

2017-04-11 Thread Greg Kroah-Hartman
On Sat, Apr 08, 2017 at 10:04:33PM +0200, Greg Kroah-Hartman wrote: > On Sat, Apr 08, 2017 at 11:23:28AM -0600, Jonathan Corbet wrote: > > On Wed, 5 Apr 2017 10:22:54 -0300 > > Mauro Carvalho Chehab <mche...@s-opensource.com> wrote: > > > > > Currently,

Re: [PATCH v2 00/21] Convert USB documentation to ReST format

2017-04-08 Thread Greg Kroah-Hartman
On Sat, Apr 08, 2017 at 11:23:28AM -0600, Jonathan Corbet wrote: > On Wed, 5 Apr 2017 10:22:54 -0300 > Mauro Carvalho Chehab wrote: > > > Currently, there are several USB core documents that are at either > > written in plain text or in DocBook format. Convert them to

Re: [PATCH] usb: misc: add missing continue and refactor code

2017-04-03 Thread Greg Kroah-Hartman
On Mon, Apr 03, 2017 at 09:39:53AM -0500, Gustavo A. R. Silva wrote: > -Code refactoring to make the flow easier to follow. > -Add missing 'continue' for case USB_ENDPOINT_XFER_INT. Don't do multiple things in the same patch, please make these multiple patches. And do the "add missing continue"

Re: [PATCH RFC] dwc2: Don't assume URB transfer_buffer are dword-aligned

2017-03-29 Thread Greg Kroah-Hartman
On Tue, Mar 28, 2017 at 06:48:02AM -0300, Mauro Carvalho Chehab wrote: > Em Fri, 17 Mar 2017 10:24:15 +0900 > Greg Kroah-Hartman <gre...@linuxfoundation.org> escreveu: > > > On Thu, Mar 16, 2017 at 09:08:40PM -0300, Mauro Carvalho Chehab wrote: > > > The dwc2 h

Re: [GIT PULL] USB-serial fixes for v4.11-rc4

2017-03-23 Thread Greg Kroah-Hartman
On Thu, Mar 23, 2017 at 05:57:42PM +0100, Johan Hovold wrote: > The following changes since commit 4495c08e84729385774601b5146d51d9e5849f81: > > Linux 4.11-rc2 (2017-03-12 14:47:08 -0700) > > are available in the git repository at: > >

Re: [GIT PULL] usb fixes for v4.11-rc

2017-03-23 Thread Greg Kroah-Hartman
On Thu, Mar 23, 2017 at 02:30:15PM +0200, Felipe Balbi wrote: > > Hi Greg, > > here's my second pull request for the current -rc cycle. Let me know if > you want anything to be changed. > > cheers > > The following changes since commit 97da3854c526d3a6ee05c849c96e48d21527606c: > > Linux

Re: [usb:usb-testing 41/58] htmldocs: drivers/usb/core/usb.c:178: warning: No description found for parameter 'alt'

2017-03-23 Thread Greg Kroah-Hartman
On Thu, Mar 23, 2017 at 06:06:45PM +0100, Johan Hovold wrote: > On Thu, Mar 23, 2017 at 10:57:05PM +0800, kbuild test robot wrote: > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git > > usb-testing > > head: 5370860a1f0e6b4197982dc1d323f988f7b1b11d > > commit:

Re: [PATCH v2 00/21] USB: refactor endpoint retrieval

2017-03-23 Thread Greg Kroah-Hartman
On Fri, Mar 17, 2017 at 11:35:29AM +0100, Johan Hovold wrote: > Many USB drivers iterate over the available endpoints to find required > endpoints of a specific type and direction. Typically the endpoints are > required for proper function and a missing endpoint should abort probe. > > To

Re: [PATCH v2 17/21] USB: usbtmc: refactor endpoint retrieval

2017-03-23 Thread Greg Kroah-Hartman
On Fri, Mar 17, 2017 at 11:35:46AM +0100, Johan Hovold wrote: > Use the new endpoint helpers to lookup the required bulk-in and bulk-out > endpoints, and the optional interrupt-in endpoint. > > Signed-off-by: Johan Hovold > --- > drivers/usb/class/usbtmc.c | 56 >

Re: [PATCH v2 13/21] USB: lvstest: tighten endpoint sanity check

2017-03-23 Thread Greg Kroah-Hartman
On Fri, Mar 17, 2017 at 11:35:42AM +0100, Johan Hovold wrote: > Use the new endpoint helpers to lookup the required interrupt-in > endpoint. > > Note that this in fact both loosens and tightens the endpoint sanity > check by accepting any interface with an interrupt-in endpoint rather > than

Re: [PATCH v8 0/5] usb: early: add support for early printk through USB3 debug port

2017-03-21 Thread Greg Kroah-Hartman
On Tue, Mar 21, 2017 at 12:33:28PM +0100, Ingo Molnar wrote: > > * Lu Baolu wrote: > > > xHCI debug capability (DbC) is an optional but standalone > > functionality provided by an xHCI host controller. With DbC > > hardware initialized, the system will present a debug

Re: [PATCH RFC] dwc2: Don't assume URB transfer_buffer are dword-aligned

2017-03-18 Thread Greg Kroah-Hartman
On Fri, Mar 17, 2017 at 04:25:21PM -0700, Michael Zoran wrote: > On Fri, 2017-03-17 at 10:24 +0900, Greg Kroah-Hartman wrote: > > On Thu, Mar 16, 2017 at 09:08:40PM -0300, Mauro Carvalho Chehab > > wrote: > > > The dwc2 hardware doesn't like to do DMA transfers without >

Re: [PATCH v4 1/2] usbip: Fix-format-overflow

2017-03-16 Thread Greg Kroah-Hartman
On Thu, Mar 16, 2017 at 09:04:54AM -0600, Shuah Khan wrote: > On 02/27/2017 01:31 AM, Jonathan Dieter wrote: > > The usbip userspace tools call sprintf()/snprintf() and don't check for > > the return value which can lead the paths to overflow, truncating the > > final file in the path. > > > >

Re: [PATCH RFC] dwc2: Don't assume URB transfer_buffer are dword-aligned

2017-03-16 Thread Greg Kroah-Hartman
On Thu, Mar 16, 2017 at 09:08:40PM -0300, Mauro Carvalho Chehab wrote: > The dwc2 hardware doesn't like to do DMA transfers without > aligning data in DWORD. The driver also assumes that, even > when there's no DMA, at dwc2_read_packet(). > > That cause buffer overflows, preventing some drivers

Re: [PATCH v4 1/3] usb: orion-echi: Add support for the Armada 3700

2017-03-10 Thread Greg Kroah-Hartman
On Fri, Mar 10, 2017 at 10:55:23AM +0100, Gregory CLEMENT wrote: > Hi Alan, > > On jeu., mars 09 2017, Alan Stern wrote: > > > On Thu, 9 Mar 2017, Gregory CLEMENT wrote: > > > >> From: Hua Jing > >> > >> - Add a new compatible string for the

Re: [GIT PULL] USB-serial fixes for v4.11-rc2

2017-03-09 Thread Greg Kroah-Hartman
On Thu, Mar 09, 2017 at 11:08:41AM +0100, Johan Hovold wrote: > The following changes since commit c1ae3cfa0e89fa1a7ecc4c99031f5e9ae99d9201: > > Linux 4.11-rc1 (2017-03-05 12:59:56 -0800) > > are available in the git repository at: > >

Re: [GIT PULL] USB fixes for v4.11-rc2

2017-03-09 Thread Greg Kroah-Hartman
On Thu, Mar 09, 2017 at 11:05:57AM +0200, Felipe Balbi wrote: > > Hi Greg, > > Here's my first set of fixes for this -rc cycle. Let me know if you want > anything to be changed ;-) Pulled and pushed out, thanks. greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb"

Re: [PATCH V3] usb: add CONFIG_USB_PCI for system have both PCI HW and non-PCI based USB HW

2017-03-06 Thread Greg Kroah-Hartman
On Mon, Mar 06, 2017 at 04:48:50PM +0200, Felipe Balbi wrote: > > Hi, > > yuan linyu writes: > > From: yuan linyu > > > > a lot of embeded system SOC (e.g. freescale T2080) have both > > PCI and USB modules. But USB module is controlled by

Re: [RFC v2 00/20] Replace PCI pool by DMA pool API

2017-02-18 Thread Greg Kroah-Hartman
On Sat, Feb 18, 2017 at 09:35:36AM +0100, Romain Perier wrote: > The current PCI pool API are simple macro functions direct expanded to > the appropriated dma pool functions. The prototypes are almost the same > and semantically, they are very similar. I propose to use the DMA pool > API directly

Re: [PATCH] Revert "usb: gadget: f_fs: Fix ExtCompat descriptor validation"

2017-02-17 Thread Greg Kroah-Hartman
On Fri, Feb 17, 2017 at 10:07:11AM +0200, Felipe Balbi wrote: > Janusz Dziedzic writes: > > This reverts commit ac670a3a650b899fc020b81f63e810d06015b865. > > > > This introduce bug we already fixed in > > commit 53642399aa71 ("usb: gadget: f_fs: Fix wrong check

Re: v4.10-rc8 (-rc6) boot regression on Intel desktop, does not boot after cold boots, boots after reboot

2017-02-16 Thread Greg Kroah-Hartman
On Thu, Feb 16, 2017 at 09:06:24PM +0100, Pavel Machek wrote: > On Thu 2017-02-16 20:34:45, Thomas Gleixner wrote: > > On Thu, 16 Feb 2017, Frederic Weisbecker wrote: > > > On Thu, Feb 16, 2017 at 10:20:14AM -0800, Linus Torvalds wrote: > > > > On Thu, Feb 16, 2017 at 10:13 AM, Frederic Weisbecker

Re: [GIT PULL] USB-serial updates for v4.11-rc1 part 2

2017-02-16 Thread Greg Kroah-Hartman
On Thu, Feb 16, 2017 at 03:14:18PM +0100, Johan Hovold wrote: > The following changes since commit 5182c2cf2a9bfb7f066ef0bdd2bb6330b94dd74e: > > USB: serial: mos7840: fix another NULL-deref at open (2017-02-09 13:15:07 > +0100) > > are available in the git repository at: > >

Re: [PATCH] usb: add CONFIG_USB_PCI to distinguish PCI/non-PCI based USB

2017-02-14 Thread Greg Kroah-Hartman
On Tue, Feb 14, 2017 at 10:41:06AM -0500, Alan Stern wrote: > On Tue, 14 Feb 2017, Greg Kroah-Hartman wrote: > > > On Tue, Feb 14, 2017 at 08:46:16PM +0800, yuan linyu wrote: > > > From: yuan linyu <linyu.y...@alcatel-sbell.com.cn> > > > > > > one us

Re: [PATCH 1/3 v2] usb: host: fotg2: add device tree probing

2017-02-10 Thread Greg Kroah-Hartman
On Thu, Feb 09, 2017 at 03:20:49PM +0100, Hans Ulli Kroll wrote: > > Add device tree probe for fotg2 driver > > v2: > fix in wrong MODULE_DEVICE_TABLE > > Signed-off-by: Hans Ulli Kroll > --- > drivers/usb/host/fotg210-hcd.c | 19 +++ > 1 file

Re: [GIT PULL] USB-serial updates for v4.11-rc1

2017-02-09 Thread Greg Kroah-Hartman
On Thu, Feb 09, 2017 at 01:36:10PM +0100, Johan Hovold wrote: > The following changes since commit 49def1853334396f948dcb4cedb9347abb318df5: > > Linux 4.10-rc4 (2017-01-15 16:21:59 -0800) > > are available in the git repository at: > >

Re: [PATCH v2 1/1] xhci: add USB2 test mode support

2017-02-08 Thread Greg Kroah-Hartman
On Wed, Feb 08, 2017 at 02:44:44PM +0100, Alexander Stein wrote: > This patch adds support for USB2 test mode (Test_J, Test_K, > Test_SE0_NAK and Test_Packet) per XHCI spec 4.19.6. > > USB2 test mode is a required hardware feature for system integrators > validating their hardware according to

Re: [PATCH 1/1] xhci: add USB2 test mode support

2017-02-08 Thread Greg Kroah-Hartman
On Wed, Feb 08, 2017 at 02:10:39PM +0100, Alexander Stein wrote: > On Wednesday 08 February 2017 13:53:30, Greg Kroah-Hartman wrote: > > On Wed, Feb 08, 2017 at 11:26:35AM +0100, Alexander Stein wrote: > > > This patch adds support for USB2 test mode (Test_J, Test_K,

Re: [PATCH 1/1] xhci: add USB2 test mode support

2017-02-08 Thread Greg Kroah-Hartman
On Wed, Feb 08, 2017 at 11:26:35AM +0100, Alexander Stein wrote: > This patch adds support for USB2 test mode (Test_J, Test_K, > Test_SE0_NAK and Test_Packet) per XHCI spec 4.19.6. What does that mean "in English"? In other words, why do we want this? What does it provide for a user? Why do we

Re: [GIT PULL] USB-serial fixes for v4.10-rc7

2017-02-03 Thread Greg Kroah-Hartman
On Fri, Feb 03, 2017 at 05:12:01PM +0100, Johan Hovold wrote: > The following changes since commit 5d03a2fd2292e71936c4235885c35ccc3c94695b: > > USB: serial: option: add device ID for HP lt2523 (Novatel E371) (2017-01-24 > 12:07:28 +0100) > > are available in the git repository at: > >

<    1   2   3   4   5   6   7   8   9   10   >