Re: net2280 Driver Bug

On Thu, Feb 02, 2017 at 12:50:02PM +, Raz Manor wrote: > I opened a pull request for this patch > https://github.com/torvalds/linux/pull/388 Linux development does not work with github pull requests, sorry. Please see Documentation/development_process/ for how we all work together. Please

Re: [PATCH 2/8] power: add power sequence library

On Wed, Feb 01, 2017 at 12:10:17AM +0100, Rafael J. Wysocki wrote: > On Tue, Jan 3, 2017 at 7:33 AM, Peter Chen wrote: > > We have an well-known problem that the device needs to do some power > > sequence before it can be recognized by related host, the typical > > example

Re: [PATCH] Usb: host - Fix possible NULL derefrence.

On Mon, Jan 30, 2017 at 08:03:23AM +0100, Thierry Reding wrote: > On Mon, Jan 30, 2017 at 07:45:21AM +0100, Greg Kroah-Hartman wrote: > > On Mon, Jan 30, 2017 at 10:36:29AM +0530, Shailendra Verma wrote: > > > of_device_get_match_data could return NULL, and so can cause &g

Re: [PATCH] Usb: host - Fix possible NULL derefrence.

On Mon, Jan 30, 2017 at 10:36:29AM +0530, Shailendra Verma wrote: > of_device_get_match_data could return NULL, and so can cause > a NULL pointer dereference later. > > Signed-off-by: Shailendra Verma > --- > drivers/usb/host/xhci-tegra.c |4 > 1 file changed,

Re: [GIT PULL] USB-serial fixes for v4.10-rc6

On Fri, Jan 27, 2017 at 03:48:39PM +0100, Johan Hovold wrote: > The following changes since commit 49def1853334396f948dcb4cedb9347abb318df5: > > Linux 4.10-rc4 (2017-01-15 16:21:59 -0800) > > are available in the git repository at: > >

Re: [GIT PULL] USB for v4.11

On Thu, Jan 26, 2017 at 04:23:00PM +0200, Felipe Balbi wrote: > > Hi Greg, > > here's my pull request for v4.11. Patches tested with Intel Joule, SKL > and KBL. > > Let me know if you want anything to be changed. > > cheers > > The following changes since commit

Re: [PATCH] USB: serial: ftdi_sio: fix extreme low-latency setting

On Wed, Jan 25, 2017 at 04:14:36PM +0100, Johan Hovold wrote: > On Wed, Jan 25, 2017 at 04:06:47PM +0100, Greg Kroah-Hartman wrote: > > On Wed, Jan 25, 2017 at 03:35:20PM +0100, Johan Hovold wrote: > > > Since commit 557aaa7ffab6 ("ft232: support the ASYNC_LOW_LATENCY >

Re: [PATCH] USB: serial: ftdi_sio: fix extreme low-latency setting

On Wed, Jan 25, 2017 at 03:35:20PM +0100, Johan Hovold wrote: > Since commit 557aaa7ffab6 ("ft232: support the ASYNC_LOW_LATENCY > flag") the FTDI driver has been using a receive latency-timer value of > 1 ms instead of the device default of 16 ms. > > The latency timer is used to periodically

Re: [RFC] usb: gadget: uvc: webcam gadget USB PID is using value from a different gadget

On Mon, Jan 23, 2017 at 12:20:03PM +0100, Greg Kroah-Hartman wrote: > On Mon, Jan 23, 2017 at 12:59:33PM +0200, Felipe Balbi wrote: > > > > Hi, > > > > Petr Cvek <petr.c...@tul.cz> writes: > > > It seems the USB product ID for g_webcam usb device gadget

Re: [RFC] usb: gadget: uvc: webcam gadget USB PID is using value from a different gadget

On Mon, Jan 23, 2017 at 12:59:33PM +0200, Felipe Balbi wrote: > > Hi, > > Petr Cvek writes: > > It seems the USB product ID for g_webcam usb device gadget is > > incorrectly used from EEM gadget "Ethernet Emulation Model". So > > "webcam" device has a confusing description in

Re: [PATCH] USB: Add quirk for WORLDE easykey.25 MIDI keyboard

On Fri, Jan 20, 2017 at 07:46:34PM +0100, Lukáš Lalinský wrote: > Add a quirk for WORLDE easykey.25 MIDI keyboard (idVendor=0218, > idProduct=0401). The device reports that it has config string > descriptor at index 3, but when the system selects the configuration > and tries to get the

Re: [PATCH 4/6] arm64: dts: mt8173: add reference clock for usb

On Wed, Jan 18, 2017 at 02:08:25PM +0800, Chunfeng Yun wrote: > add 26M reference clock for ssusb and xhci nodes > > Signed-off-by: Chunfeng Yun > --- > arch/arm64/boot/dts/mediatek/mt8173.dtsi |6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) This

Re: [PATCH v5 0/4] usb: early: add support for early printk through USB3 debug port

On Wed, Jan 18, 2017 at 02:20:30PM +0800, Lu Baolu wrote: > Hi Greg, > > This patch series has been there for 2 months without > further comments. Will you consider it for usb-next? I needed acks from the x86 maintainers before I could take those patches. Can you resend the series and hopefully

Re: [PATCH v6 03/25] usb: ulpi: Support device discovery via DT

ower sequencing for these > > registers we could put that into the ULPI bus layer and power up > > the device before reading the ID registers. Unfortunately this > > doesn't exist and the power sequence is usually device specific. > > By having the device matched up with

Re: [RFC v2 1/5] UDC: Split the driver into amd (pci) and Synopsys core driver

On Wed, Jan 18, 2017 at 10:45:39AM -0800, Florian Fainelli wrote: > On 01/17/2017 12:05 AM, Raviteja Garimella wrote: > > This patch splits the amd5536udc driver into two -- one that does > > pci device registration and the other file that does the rest of > > the driver tasks like the gadget/ep

Re: [GIT PULL] USB fixes for v4.10-rc

On Tue, Jan 17, 2017 at 11:06:05AM +0200, Felipe Balbi wrote: > > Hi Greg, > > here's another set of fixes for the -rc cycle. Let me know if you want > any changes > > cheers > > The following changes since commit a121103c922847ba5010819a3f250f1f7fc84ab8: > > Linux 4.10-rc3 (2017-01-08

Re: [GIT PULL] USB-serial fixes for v4.10-rc4

On Thu, Jan 12, 2017 at 03:54:01PM +0100, Johan Hovold wrote: > Hi Greg, > > Here are my fixes for -rc4. All have been in linux-next. Pulled and pushed out, thanks. greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to

Re: [PATCH] usb: dwc2: host: fix Wmaybe-uninitialized warning

On Thu, Jan 12, 2017 at 04:54:38PM +0100, Nicholas Mc Guire wrote: > Signed-off-by: Nicholas Mc Guire > --- > Problem reported by sparse > drivers/usb/dwc2/hcd.c: In function 'dwc2_dump_urb_info': > ./include/linux/dynamic_debug.h:134:3: warning: 'pipetype' may be used >

Re: [v4.4.40] patch backport error

On Wed, Jan 11, 2017 at 09:17:02PM +0100, Greg Kroah-Hartman wrote: > On Wed, Jan 11, 2017 at 07:13:30PM +0200, Felipe Balbi wrote: > > > > hi, > > > > Bin Liu <b-...@ti.com> writes: > > > I am unable to figure out what was happening, but there seems to

Re: [v4.4.40] patch backport error

On Wed, Jan 11, 2017 at 07:13:30PM +0200, Felipe Balbi wrote: > > hi, > > Bin Liu writes: > > I am unable to figure out what was happening, but there seems to be a > > patch backport error in v4.4.40. > > > > Commit c53af76d5de1 (usb: gadget: composite: always set ep->mult to a >

Re: XHCI regression on v4.10-rc1

On Mon, Jan 09, 2017 at 10:51:34AM +0100, Patrice Chotard wrote: > Hi Mathias, Greg > > I am working on ARM STi platform, since v4.10-rc1, when booting B2260 or > B2120 STi boards platform > with nothing plugged on USB3 connector, i observed the following kernel logs : > > > [

Re: XHCI regression on v4.10-rc1

On Mon, Jan 09, 2017 at 11:08:39AM +0100, Greg Kroah-Hartman wrote: > On Mon, Jan 09, 2017 at 10:51:34AM +0100, Patrice Chotard wrote: > > Hi Mathias, Greg > > > > I am working on ARM STi platform, since v4.10-rc1, when booting B2260 or > > B2120 STi boards platfor

Re: [PATCH] usb: storage: ene_ub6250: remove unused variable

On Sat, Jan 07, 2017 at 11:28:19PM +, Sudip Mukherjee wrote: > On Thursday 05 January 2017 06:36 PM, Greg Kroah-Hartman wrote: > > On Sun, Dec 18, 2016 at 10:34:31PM +, Sudip Mukherjee wrote: > > > The variable Newblk was only being assigned some value but was neve

Re: [PATCH] usb: storage: ene_ub6250: remove unused variable

On Sun, Dec 18, 2016 at 10:34:31PM +, Sudip Mukherjee wrote: > The variable Newblk was only being assigned some value but was never > used after that. > > Signed-off-by: Sudip Mukherjee > --- > drivers/usb/storage/ene_ub6250.c | 2 -- > 1 file changed, 2

Re: net2280 Driver Bug

On Tue, Dec 27, 2016 at 03:56:11PM +, Raz Manor wrote: > I'm not entirely sure either, that is why I wanted the specs. > Alan sent me the PLX NET2280 specs, but I'm using the USB3380/USB3381 - the > USB3 version of the device. > As it seems from the code, the HW interface is mostly the same,

Re: [GIT PULL] USB-serial fixes for v4.10-rc3

On Thu, Jan 05, 2017 at 03:52:34PM +0100, Johan Hovold wrote: > Hi Greg, > > Here are my fixes for 4.10-rc3. Details below. > > Thanks, > Johan > > > The following changes since commit 0c744ea4f77d72b3dcebb7a8f2684633ec79be88: > > Linux 4.10-rc2 (2017-01-01 14:31:53 -0800) > > are

Re: [PATCH] USB: ohci-omap: defer probe if PHY is missing

On Tue, Jan 03, 2017 at 08:50:31PM +0200, Aaro Koskinen wrote: > Hi, > > On Tue, Jan 03, 2017 at 05:51:43PM +0100, Greg Kroah-Hartman wrote: > > On Mon, Jan 02, 2017 at 10:53:55PM +0200, Aaro Koskinen wrote: > > > Defer probe if PHY is missing. E.g. on Nokia 7

Re: [PATCH] USB: ohci-omap: defer probe if PHY is missing

On Mon, Jan 02, 2017 at 10:53:55PM +0200, Aaro Koskinen wrote: > Defer probe if PHY is missing. E.g. on Nokia 770 several modules needs > to be loaded to get the PHY going and ohci-omap should wait for those. > > Signed-off-by: Aaro Koskinen Is this a new bug? The 770 has

Re: [PATCH v2 REGRESSION RESEND] usb: ohci-at91: use descriptor-based gpio APIs correctly

On Thu, Dec 22, 2016 at 09:38:08PM +0100, Peter Rosin wrote: > On 2016-12-22 18:27, Greg Kroah-Hartman wrote: > > On Thu, Dec 22, 2016 at 08:43:55AM +0100, Peter Rosin wrote: > >> The gpiod_get* function family does not want the -gpio suffix. > >> Use devm_gpiod

Re: [PATCH v2 REGRESSION RESEND] usb: ohci-at91: use descriptor-based gpio APIs correctly

On Thu, Dec 22, 2016 at 08:43:55AM +0100, Peter Rosin wrote: > The gpiod_get* function family does not want the -gpio suffix. > Use devm_gpiod_get_index_optional instead of devm_gpiod_get_optional. > The descriptor based APIs handle active high/low automatically. > The vbus-gpios are output,

Re: [PATCH] usb: musb: debugfs: allow forcing host mode together with speed in testmode

On Wed, Dec 14, 2016 at 03:47:57PM +0100, Pali Rohár wrote: > Signed-off-by: Pali Rohár > --- > drivers/usb/musb/musb_debugfs.c | 44 > +-- > 1 file changed, 28 insertions(+), 16 deletions(-) I don't accept patches without any

Re: usb/core: warning in usb_create_ep_devs/sysfs_create_dir_ns

On Mon, Dec 12, 2016 at 10:16:50PM +0100, Dmitry Vyukov wrote: > On Mon, Dec 12, 2016 at 10:05 PM, Alan Stern > wrote: > > On Mon, 12 Dec 2016, Andrey Konovalov wrote: > > > >> Hi! > >> > >> While running the syzkaller fuzzer I've got the following error report. > >> >

Re: [PATCH v2 2/2] USB: OHCI: pxa27x:fix code warnig and errors

pr_err(... to printk(KERN_ERR ... > ERROR: space prohibited after that open parenthesis '(' > ERROR: space prohibited before that close parenthesis ')' > > Signed-off-by: Manjunath Goudar <csmanjuvi...@gmail.com> > Cc: Alan Stern <st...@rowland.harvard.edu> > Cc: G

Re: [PATCH v2 1/2] USB: OHCI: pxa27x:fix code warnings

<csmanjuvi...@gmail.com> > Cc: Alan Stern <st...@rowland.harvard.edu> > Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> > Cc: linux-usb@vger.kernel.org > Cc: linux-ker...@vger.kernel.org > > --- > changelog V1->V2: > no changes. That's foolish, you

Re: [PATCH 2/2] USB: OHCI: pxa27x:fix code errors

ibited before that close parenthesis ')' > > Signed-off-by: Manjunath Goudar <csmanjuvi...@gmail.com> > Cc: Alan Stern <st...@rowland.harvard.edu> > Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> > Cc: linux-usb@vger.kernel.org > Cc: linux-ker...@vger.kernel.org > -

Re: [PATCH v2] USB: EHCI: spear: fix code warnings

On Thu, Dec 08, 2016 at 10:40:11PM +, csmanjuvi...@gmail.com wrote: > From: Manjunath Goudar > > This patch will fix the checkpatch.pl following warnings > WARNING: Block comments should align the * on each line > WARNING: space prohibited before semicolon I've said

Re: [GIT PULL] USB-serial fixes for v4.10-rc1

On Fri, Dec 09, 2016 at 11:00:27AM +0100, Johan Hovold wrote: > Hi Greg, > > Here are some more device ids that could go into v4.10-rc1 unless you > prefer I resend these after rc1 is out. Both commits have been in > linux-next for a couple of days. > > Thanks, > Johan > > > The following

Re: Emulating USB devices from userspace

On Fri, Dec 09, 2016 at 12:38:23AM +0100, Andrey Konovalov wrote: > Hi, > > I'm working on a way to extend syzkaller [1] to support fuzzing of the > USB subsystem. The idea is to be able to emulate various USB devices > and fuzz communication between the emulated device and the kernel. I'm >

Re: [PATCH v2] USB: OHCI: pxa27x:fix warnings and error

On Thu, Dec 08, 2016 at 10:30:35PM +, manju goudar wrote: > > > On Thu, Dec 8, 2016 at 4:49 PM, Greg Kroah-Hartman > <gre...@linuxfoundation.org> > wrote: > > On Wed, Dec 07, 2016 at 11:37:45PM +, csmanjuvi...@gmail.com wrote: > > From: Manjuna

Re: [PATCH v2] USB: OHCI: pxa27x:fix warnings and error

juvi...@gmail.com> > Cc: Alan Stern <st...@rowland.harvard.edu> > Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> > Cc: linux-usb@vger.kernel.org > Cc: linux-ker...@vger.kernel.org > --- > changelog V1->V2: > Warnings and error message is added to the patch discrition. >

Re: [BUG 4.9] New led trigger usbport gets the kernel to panic

On Thu, Dec 08, 2016 at 09:40:43AM +0100, Jacek Anaszewski wrote: > Hi Rafał, > > On 12/06/2016 06:29 PM, Rafał Miłecki wrote: > > On 6 December 2016 at 18:26, Pavel Machek wrote: > > > On Fri 2016-12-02 09:48:18, Ralph Sennhauser wrote: > > > > On Thu, 1 Dec 2016 17:56:07 +0100 >

Re: [PATCH 1/1] Fixed to checkpatch errors to usbtmc.c

On Tue, Dec 06, 2016 at 02:57:00PM +0200, Ozgur Karatas wrote: > Hello all, This isn't needed in a changelog text. > I will solve a checkpatch.pl script errors. > drivers/usb/class/usbtmc.c:719: ERROR: else should follow close brace '}' > drivers/usb/class/usbtmc.c:735: ERROR: space required

[PATCH] usb: gadgetfs: restrict upper bound on device configuration size

<andreyk...@google.com> Cc: stable <sta...@vger.kernel.org> Signed-off-by: Greg Kroah-Hartman <gre...@linuxfoundation.org> --- inode.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) Felipe, any objection for me to take this through my tree now? diff --git a/drivers

Re: [PATCH] USB: OHCI: pxa27x: fix warnings and errors

t;st...@rowland.harvard.edu> > Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> > Cc: linux-usb@vger.kernel.org > Cc: linux-ker...@vger.kernel.org > --- > drivers/usb/host/ohci-pxa27x.c | 28 +--- > 1 file changed, 13 insertions(+), 15 del

Re: [PATCH] USB: OHCI: pxa27x: fix warnings and errors

On Mon, Dec 05, 2016 at 10:18:58PM +, csmanjuvi...@gmail.com wrote: > From: Manjunath Goudar > > This patch will fix the checkpatch.pl warnings and errors. what warnings and errors? Please always be specific. And don't send a single patch to fix everything up,

Re: usb:xhci: support disable usb2 LPM Remote Wakeup

On Tue, Dec 06, 2016 at 01:59:00PM +0700, Thang Q. Nguyen wrote: > Hi, > Do you have any feedback on this? > > Thanks, > Thang Q. Nguyen > > On Sun, Dec 4, 2016 at 7:42 PM, Thang Q. Nguyen wrote: It has been 1 day, please relax, wait, and be patient. If after 2 weeks there

Re: [PATCH 3/3] USB: OHCI: nxp: remove useless extern declaration

On Sat, Dec 03, 2016 at 03:25:23AM +, csmanjuvi...@gmail.com wrote: > From: Manjunath Goudar > > Remove usb_disabled() extern declaration as it is already declared > as EXPORT_SYMBOL_GPL declaration. merge this with your first patch please, it belongs with it. -- To

Re: [PATCH 3/3] USB: OHCI: nxp: remove useless extern declaration

On Sat, Dec 03, 2016 at 03:25:23AM +, csmanjuvi...@gmail.com wrote: > From: Manjunath Goudar > > Remove usb_disabled() extern declaration as it is already declared > as EXPORT_SYMBOL_GPL declaration. And same thing again... -- To unsubscribe from this list: send the

Re: [PATCH 2/3] USB: OHCI: omap: remove useless extern declaration

On Sat, Dec 03, 2016 at 03:25:22AM +, csmanjuvi...@gmail.com wrote: > From: Manjunath Goudar > > Remove usb_disabled() and ocpi_enable() extern declaration > as it is already declared as EXPORT_SYMBOL_GPL declaration. Same here, EXPORT_SYMBOL* doesn't matter for

Re: [PATCH 1/3] USB: OHCI: at91: remove useless extern declaration

On Sat, Dec 03, 2016 at 03:25:21AM +, csmanjuvi...@gmail.com wrote: > From: Manjunath Goudar > > Remove usb_disabled() extern declaration as it is already declared > as EXPORT_SYMBOL_GPL declaration in drivers/usb/core/usb.c The EXPORT_SYMBOL_GPL() has nothing to do

Re: usb/gadget: GPF in usb_gadget_unregister_driver

On Sat, Dec 03, 2016 at 05:36:35PM +0100, Andrey Konovalov wrote: > Hi! > > I've got the following error report while running the syzkaller fuzzer. > > On commit 3c49de52d5647cda8b42c4255cf8a29d1e22eff5 (Dec 2). > > general protection fault: [#1] SMP KASAN > Dumping ftrace buffer: >

Re: usb: warning in vhci_hcd_probe/lockdep_init_map

On Fri, Dec 02, 2016 at 03:35:44PM +0100, Andrey Konovalov wrote: > Hi! > > I've got the following error report while booting the kernel with > various usb configs enabled. Any hint as to what these "various usb configs" are? > On commit 2caceb3294a78c389b462e7e236a4e744a53a474 (Dec 1). > >

Re: usb/gadget: warning in dev_config/memdup_user

On Fri, Dec 02, 2016 at 04:56:15PM +0100, Greg Kroah-Hartman wrote: > On Fri, Dec 02, 2016 at 04:07:38PM +0100, Andrey Konovalov wrote: > > Hi! > > > > I've got the following error report while running the syzkaller fuzzer. > > > > The length passed to memdup_us

Re: usb/gadget: warning in dev_config/memdup_user

On Fri, Dec 02, 2016 at 04:07:38PM +0100, Andrey Konovalov wrote: > Hi! > > I've got the following error report while running the syzkaller fuzzer. > > The length passed to memdup_user() directly without limitations. > > On commit 2caceb3294a78c389b462e7e236a4e744a53a474 (Dec 1). > > WARNING:

Re: [GIT PULL] USB-serial updates for v4.10-rc1

On Thu, Dec 01, 2016 at 12:18:49PM +0100, Johan Hovold wrote: > Hi Greg, > > Here are my updates for 4.10. Details below. > > Thanks, > Johan > > > The following changes since commit 07d9a380680d1c0eb51ef87ff2eab5c994949e69: > > Linux 4.9-rc2 (2016-10-23 17:10:14 -0700) > > are available

Re: [PATCH v2] USB: OHCI: ohci-pxa27x: remove useless functions

s why removed ohci_hcd_pxa27x_remove > function and renamed usb_hcd_pxa27x_remove to ohci_hcd_pxa27x_remove for > proper naming. > > Signed-off-by: Manjunath Goudar <csmanjuvi...@gmail.com> > Cc: Alan Stern <st...@rowland.harvard.edu> > Cc: Greg Kroah-Hartman <gre...

Re: [PATCH] USB: OHCI: use module_platform_driver macro

t; Signed-off-by: Manjunath Goudar <csmanjuvi...@gmail.com> > Cc: Arnd Bergmann <a...@arndb.de> > Cc: Vladimir Zapolskiy <v...@mleia.com> > Cc: Sylvain Lemieux <slemieux.t...@gmail.com> > Cc: Alan Stern <st...@rowland.harvard.edu> > Cc: Greg Kroah-Hartman

Re: [GIT PULL] usb: chipidea changes for v4.10-rc1

On Mon, Nov 28, 2016 at 10:16:33AM +0800, Peter Chen wrote: > The following changes since commit bb2d387c4d90f5b400b94a0fcb5aaef31dfc0789: > > USB: cdc-acm: use get_icount tty operation (2016-11-10 13:16:57 +0100) > > are available in the git repository at: > >

Re: [PATCH v6] USB hub_probe: rework ugly goto-into-compound-statement

On Sat, Nov 19, 2016 at 09:55:45AM +0300, Eugene Korenevsky wrote: > Rework smelling code (goto inside compound statement). Perhaps this is > legacy. Anyway such code is not appropriate for Linux kernel. > > Signed-off-by: Eugene Korenevsky > --- > Changes in v6: more

Re: [GIT PULL] USB patches for v4.10 merge window

On Fri, Nov 18, 2016 at 02:27:18PM +0200, Felipe Balbi wrote: > > Hi Greg, > > Here's the giant pull request for all things Gadget and the > like. Patches have been soaking in next for a while. I have tested them > for several days with a SKL box. > > Let me know if you want anything to be

Re: [GIT PULL] USB-serial fixes for v4.9-rc6

On Fri, Nov 18, 2016 at 03:22:13PM +0100, Johan Hovold wrote: > Hi Greg, > > Here are some more device ids that could go into 4.9-rc. > > Thanks, > Johan > > > The following changes since commit bc33b0ca11e3df46a4fa7639ba488c9d4911: > > Linux 4.9-rc4 (2016-11-05 16:23:36 -0700) > > are

Re: [GIT PULL] USB fixes for v4.9-rc6

On Fri, Nov 18, 2016 at 01:53:43PM +0200, Felipe Balbi wrote: > > Hi Greg, > > here's one important fix for v4.9-final on functionFS. It's small and > simple and all it does is make sure we check for ffs_func_req_match()'s > return code properly. > > let me know if you want me to change this

Re: [PATCH v5] USB hub_probe: rework ugly goto-into-compound-statement

On Sun, Nov 13, 2016 at 03:53:58PM +0300, Eugene Korenevsky wrote: > Rework smelling code (goto inside compound statement). Perhaps this is > legacy. Anyway such code is not appropriate for Linux kernel. > > Signed-off-by: Eugene Korenevsky > --- > Changes in v5: make

Re: [PATCH v5] USB hub_probe: rework ugly goto-into-compound-statement

On Sun, Nov 13, 2016 at 03:53:58PM +0300, Eugene Korenevsky wrote: > Rework smelling code (goto inside compound statement). Perhaps this is > legacy. Anyway such code is not appropriate for Linux kernel. > > Signed-off-by: Eugene Korenevsky > --- > Changes in v5: make

Re: [PATCH 0/2] mmc: allow mmc_alloc_host() and tmio_mmc_host_alloc()

On Fri, Nov 11, 2016 at 12:19:05PM +0900, Masahiro Yamada wrote: > 2016-11-10 22:35 GMT+09:00 Greg Kroah-Hartman <gre...@linuxfoundation.org>: > > On Thu, Nov 10, 2016 at 10:24:21PM +0900, Masahiro Yamada wrote: > >> > >> sdhci_alloc_host() retur

Re: [PATCH 0/2] mmc: allow mmc_alloc_host() and tmio_mmc_host_alloc()

On Thu, Nov 10, 2016 at 10:24:21PM +0900, Masahiro Yamada wrote: > > sdhci_alloc_host() returns an error pointer when it fails. > but mmc_alloc_host() cannot. > > This series allow to propagate a proper error code > when host-allocation fails. Why? What can we really do about the error except

Re: [PATCH v4] USB hub_probe: rework ugly goto-into-compound-statement

On Wed, Nov 09, 2016 at 06:35:21PM +0300, Eugene Korenevsky wrote: > Rework smelling code (goto inside compound statement). Perhaps this is > legacy. Anyway such code is not appropriate for Linux kernel. > > Changes since v3: fix typo > Changes since v2: extract the code to static function >

Re: [PATCH v3 2/2] USB hub_probe: put initialization before usage

On Mon, Nov 07, 2016 at 09:55:09PM +0300, Eugene Korenevsky wrote: > Minor optimization: move initialization immediately before usage. > This gives a chance for more accurate register allocation by the compiler. This is a probe function, a very slow path. Don't do micro optimizations where they

Re: [PATCH v3 1/2] USB hub_probe: rework ugly goto-into-compound-statement

On Mon, Nov 07, 2016 at 09:53:50PM +0300, Eugene Korenevsky wrote: > Rework smelling code (goto inside compound statement). Perhaps this is > legacy. Anyway such code is not appropriate for Linux kernel. > > Signed-off-by: Eugene Korenevsky > --- > drivers/usb/core/hub.c

Re: [PATCH v3 1/2] USB hub_probe: rework ugly goto-into-compound-statement

On Mon, Nov 07, 2016 at 09:53:50PM +0300, Eugene Korenevsky wrote: > Rework smelling code (goto inside compound statement). Perhaps this is > legacy. Anyway such code is not appropriate for Linux kernel. > > Signed-off-by: Eugene Korenevsky > --- > drivers/usb/core/hub.c

Re: [PATCH v2] USB hub_probe: remove ugly goto-into-compound-statement

On Wed, Nov 02, 2016 at 08:59:44PM +0300, Eugene Korenevsky wrote: > Rework smelling code (goto inside compound statement). Perhaps this is legacy. > Anyway such code is not appropriate for Linux kernel. > > Signed-off-by: Eugene Korenevsky > --- > drivers/usb/core/hub.c

Re: [GIT PULL] USB fixes for v4.9-rc4

On Tue, Nov 01, 2016 at 04:31:07PM +0200, Felipe Balbi wrote: > > Hi Greg, > > Here's another set of fixes for current -rc cycle. Let me know if you > want anything to be changed. Pulled and pushed out, thanks. greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in

[PATCH] USB: core: add missing license information to some files

Some of the USB core files were missing explicit license information. As all files in the kernel tree are implicitly licensed under the GPLv2-only, be explicit in case someone get confused looking at individual files by using the SPDX nomenclature. Signed-off-by: Greg Kroah-Hartman <

Re: question about drivers/usb/musb/musb_core.c

On Fri, Oct 28, 2016 at 10:33:19PM +0200, Julia Lawall wrote: > > > On Fri, 28 Oct 2016, Julia Lawall wrote: > > > The file drivers/usb/musb/musb_core.c contains the code: > > > > static DEVICE_ATTR(srp, 0644, NULL, musb_srp_store); > > > > Is it correct to have NULL in the third argument for

Re: [PATCH v7, 0/8] Add MediaTek USB3 DRD Driver

On Wed, Oct 19, 2016 at 10:28:19AM +0800, Chunfeng Yun wrote: > These patches introduce the MediaTek USB3 dual-role controller > driver. > > The driver can be configured as Dual-Role Device (DRD), > Peripheral Only and Host Only (xHCI) modes. It works well > with Mass Storage, RNDIS and g_zero on

Re: [RESEND PATCH v3 0/4] usb: early: add support for early printk through USB3 debug port

On Tue, Oct 25, 2016 at 12:32:41PM +0800, Lu Baolu wrote: > xHCI debug capability (DbC) is an optional but standalone > functionality provided by an xHCI host controller. With DbC > hardware initialized, the system will present a debug device > through the USB3 debug port (normally the first USB3

Re: [GIT PULL] USB-serial fixes for v4.9-rc2

On Fri, Oct 21, 2016 at 05:04:06PM +0200, Johan Hovold wrote: > Hi Greg, > > Here are some fixes for 4.9-rc2. Details below. > > Thanks, > Johan > > > The following changes since commit 1001354ca34179f3db924eb66672442a173147dc: > > Linux 4.9-rc1 (2016-10-15 12:17:50 -0700) > > are

Re: [PATCH] usb: ehci-platform: increase EHCI_MAX_RSTS to 4

On Mon, Oct 17, 2016 at 08:11:59PM +0900, Masahiro Yamada wrote: > Socionext LD11 SoC (arch/arm64/boot/dts/socionext/uniphier-ld11.dtsi) > needs to handle 4 reset lines for EHCI. Why? What makes it different from other EHCI implementations? thanks, greg k-h -- To unsubscribe from this list:

Re: [PATCH v6 1/3] usb: ohci-da8xx: Remove code that references mach

On Tue, Oct 04, 2016 at 12:30:58PM -0500, David Lechner wrote: > On 10/04/2016 08:38 AM, Greg Kroah-Hartman wrote: > > On Tue, Oct 04, 2016 at 11:18:03AM +0200, Kevin Hilman wrote: > > > Hi Greg, > > > > > > On Mon, Sep 5, 2016 at 10:00 PM, David Lechner

Re: [PATCH v6 1/3] usb: ohci-da8xx: Remove code that references mach

On Tue, Oct 04, 2016 at 11:18:03AM +0200, Kevin Hilman wrote: > Hi Greg, > > On Mon, Sep 5, 2016 at 10:00 PM, David Lechner wrote: > > Including mach/* is frowned upon in device drivers, so get rid of it. > > > > This replaces usb20_clk and code that pokes CFGCHIP2 with a

Re: [RFC/PATCH 33/45] usb: core: endpoint: remove unnecessary & operation

On Wed, Sep 28, 2016 at 04:05:42PM +0300, Felipe Balbi wrote: > Now that usb_endpoint_maxp() only returns the lowest > 11 bits from wMaxPacketSize, we can remove the & > operation from this driver. > > Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> > Signed-off

Re: [RFC/PATCH 32/45] usb: core: devices: remove unnecessary & operation

On Wed, Sep 28, 2016 at 04:05:41PM +0300, Felipe Balbi wrote: > Now that usb_endpoint_maxp() only returns the lowest > 11 bits from wMaxPacketSize, we can remove the & > operation from this driver. > > Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> > Cc: <linu

Re: usbtmc: vendor specific i/o

On Wed, Sep 28, 2016 at 05:25:42PM +0200, Dave Penkler wrote: > On Wed, Sep 28, 2016 at 12:29:35PM +0200, Ladislav Michl wrote: > > On Wed, Sep 28, 2016 at 11:45:02AM +0200, Greg Kroah-Hartman wrote: > > > If it is freed, why is a read even able to happen? Ah, ick, no prop

Re: usbtmc: vendor specific i/o

On Wed, Sep 28, 2016 at 12:29:35PM +0200, Ladislav Michl wrote: > On Wed, Sep 28, 2016 at 11:45:02AM +0200, Greg Kroah-Hartman wrote: > > If it is freed, why is a read even able to happen? Ah, ick, no proper > > reference counting is happening here :( > > > > Oh

Re: usbtmc: vendor specific i/o

On Wed, Sep 28, 2016 at 08:38:07AM +0200, Ladislav Michl wrote: > On Thu, Aug 04, 2016 at 10:15:33PM +0200, Ladislav Michl wrote: > > On Thu, Aug 04, 2016 at 06:59:30AM +0200, Greg Kroah-Hartman wrote: > > > On Wed, Aug 03, 2016 at 09:06:25AM +0200, Ladislav Michl wrote:

Re: [PATCH] usb: gadget: udc: atmel: fix endpoint name

On Fri, Sep 23, 2016 at 04:20:45PM +0200, Nicolas Ferre wrote: > Le 16/09/2016 à 10:36, Nicolas Ferre a écrit : > > Le 15/09/2016 à 17:07, Alexandre Belloni a écrit : > >> Since commit c32b5bcfa3c4 ("ARM: dts: at91: Fix USB endpoint nodes"), > >> atmel_usba_udc fails with: > >> > >> [

Re: [PATCH v2] musb: Export musb_root_disconnect for use in modules

On Thu, Sep 22, 2016 at 06:15:26PM +0100, Mark Brown wrote: > On Thu, Sep 22, 2016 at 08:30:16AM -0500, Bin Liu wrote: > > On Wed, Sep 21, 2016 at 03:51:33PM -0500, Bin Liu wrote: > > > > Applied. Thanks. > > > Removed it from my tree, since Greg already picked it. > > It's not showing in

Re: Gadget regression with u_ether in Linux next

On Mon, Sep 19, 2016 at 11:19:07AM +0300, Felipe Balbi wrote: > > Hi Greg, > > Tony Lindgren writes: > > Hi, > > > > Looks like commit c9ffc78745f8 ("usb: gadget: NCM: Protect dev->port_usb > > using dev->lock") causes hangs for me with Linux next. > > > > Reverting

Re: [PATCH] musb: Export musb_root_disconnect for use in modules

On Sat, Sep 17, 2016 at 12:12:04PM +0200, Hans de Goede wrote: > Hi, > > On 16-09-16 17:56, Greg Kroah-Hartman wrote: > > On Fri, Sep 16, 2016 at 04:53:17PM +0100, Mark Brown wrote: > > > On Fri, Sep 16, 2016 at 05:47:01PM +0200, Greg Kroah-Hartman wrote: > > >

Re: [PATCH] musb: Export musb_root_disconnect for use in modules

On Fri, Sep 16, 2016 at 04:53:17PM +0100, Mark Brown wrote: > On Fri, Sep 16, 2016 at 05:47:01PM +0200, Greg Kroah-Hartman wrote: > > On Fri, Sep 16, 2016 at 04:59:36PM +0200, Hans de Goede wrote: > > > > +EXPORT_SYMBOL_GPL(musb_root_disconnect); > > > Does this f

Re: [PATCH] musb: Export musb_root_disconnect for use in modules

On Fri, Sep 16, 2016 at 04:59:36PM +0200, Hans de Goede wrote: > Export musb_root_disconnect for use in modules, so that musb glue > code build as module can use it. > > Signed-off-by: Hans de Goede > --- > drivers/usb/musb/musb_virthub.c | 1 + > 1 file changed, 1

Re: [GIT PULL] USB-serial updates for v4.9-rc1

On Fri, Sep 16, 2016 at 05:12:05PM +0200, Johan Hovold wrote: > Hi Greg, > > Here's are my updates for 4.9. All have been in linux-next for quite > some time. > > Thanks, > Johan > > > The following changes since commit fa8410b355251fd30341662a40ac6b22d3e38468: > > Linux 4.8-rc3 (2016-08-21

Re: [GIT PULL] USB-serial fixes for v4.8-rc7

On Fri, Sep 16, 2016 at 05:03:00PM +0200, Johan Hovold wrote: > Hi Greg, > > Here's another device id for 4.8 unless you prefer holding off for 4.9. > > Has been in linux-next. > > Thanks, > Johan > > > The following changes since commit 9395452b4aab7bc2475ef8935b4a4fb99d778d70: > > Linux

Re: [PATCH 1/6] staging: lustre: Add space b/w concatenated strings

On Thu, Sep 15, 2016 at 01:34:48PM +0530, Rehas Sachdeva wrote: > Fixes checkpatch.pl warning: > CHECK: Concatenated strings should use spaces between elements > > Signed-off-by: Rehas Sachdeva > --- > drivers/staging/lustre/lustre/fid/fid_request.c | 8 >

Re: [GIT PULL] USB: fixes for v4.8-rc6

On Fri, Sep 09, 2016 at 03:30:46PM +0300, Felipe Balbi wrote: > Greg Kroah-Hartman <gre...@linuxfoundation.org> writes: > > > On Fri, Sep 09, 2016 at 03:17:57PM +0300, Felipe Balbi wrote: > >> > >> Hi Greg, > >> > >> Felipe Balbi

Re: [GIT PULL] USB: fixes for v4.8-rc6

On Fri, Sep 09, 2016 at 03:17:57PM +0300, Felipe Balbi wrote: > > Hi Greg, > > Felipe Balbi writes: > > Hi Greg, > > > > Here's what I'm hoping to be the last fixes for v4.8-rc cycle (unless we > > find a proper fix for g_mass_storage bug, but I can also send that

Re: [RESEND PATCH, v5 4/5] usb: Add MediaTek USB3 DRD Driver

On Fri, Aug 26, 2016 at 05:38:27PM +0800, chunfeng yun wrote: > Hi, > > On Thu, 2016-08-25 at 10:32 +0200, Oliver Neukum wrote: > > On Thu, 2016-08-25 at 11:05 +0800, Chunfeng Yun wrote: > > > This patch adds support for the MediaTek USB3 controller > > > integrated into MT8173. It can be

Re: [PATCH] USB: ohci-omap - avoid including mach/irqs.h

On Fri, Aug 26, 2016 at 07:05:19PM +0100, Russell King - ARM Linux wrote: > On Fri, Aug 26, 2016 at 01:20:53PM -0400, Alan Stern wrote: > > On Fri, 26 Aug 2016, Russell King - ARM Linux wrote: > > > > > On Mon, Aug 22, 2016 at 11:28:21AM -0400, Alan Stern wrote: > > > > On Fri, 19 Aug 2016,

Re: [GIT PULL] USB-serial fixes for v4.8-rc4

On Thu, Aug 25, 2016 at 05:53:55PM +0200, Johan Hovold wrote: > Hi Greg, > > Here's a second set of fixes for 4.8-rc. All have been in linux-next. > > Thanks, > Johan > > > The following changes since commit 647024a7df36014bbc4479d92d88e6b77c0afcf6: > > USB: serial: fix memleak in

Re: [GIT PULL] USB-serial fixes for v4.8-rc2

On Fri, Aug 12, 2016 at 10:00:21AM +0200, Johan Hovold wrote: > Hi Greg, > > Here's a first set of fixes and device ids for 4.8-rc. > > Thanks, > Johan > > > The following changes since commit 29b4817d4018df78086157ea3a55c1d9424a7cfc: > > Linux 4.8-rc1 (2016-08-07 18:18:00 -0700) > > are

<    1   2   3   4   5   6   7   8   9   10   >