Re: [GIT PULL] usb: fixes for v4.8-rc2

2016-08-11 Thread Greg Kroah-Hartman
On Thu, Aug 11, 2016 at 03:17:53PM +0300, Felipe Balbi wrote: > > Hi Greg, > > here's the first series of fixes for current -rc cycle. Patches have > been in mainling list for a while. I've tested important patches with > SKL and BXT devices. Let me know if you want anything to be changed.

Re: [PATCH V2] usb: ehci-platform: use helper variables in probe function

2016-08-09 Thread Greg Kroah-Hartman
On Fri, Jul 15, 2016 at 07:05:56AM +0200, Rafał Miłecki wrote: > Probing function was using >dev and dev->dev.of_node over 20 times > so I believe it made sense to use helper variables for both of them. > To avoid some uncommon variable name for struct device I first replaced > existing dev

Re: [PATCH] usb: ohci-platform: use helper variables in probe function

2016-08-09 Thread Greg Kroah-Hartman
On Fri, Jul 15, 2016 at 07:18:50AM +0200, Rafał Miłecki wrote: > Probing function was using >dev and dev->dev.of_node over 20 times > so I believe it made sense to use helper variables for both of them. > To avoid some uncommon variable name for struct device I first replaced > existing dev

Re: [PATCH 1/2] usb: core: add support for HCD providers

2016-08-09 Thread Greg Kroah-Hartman
On Tue, Jul 12, 2016 at 02:35:19PM +0200, Rafał Miłecki wrote: > When working with Device Tree we may need to reference controllers > (their nodes) and query for HCDs. This is useful for getting some > runtime info about host controllers like e.g. assigned bus number. > > Signed-off-by: Rafał

Re: [RFC] whci: Remove deprecated create_singlethread_workqueue

2016-08-09 Thread Greg Kroah-Hartman
On Wed, Jul 27, 2016 at 02:39:16PM +0530, Bhaktipriya Shridhar wrote: > alloc_ordered_workqueue replaces the deprecated > create_singlethread_workqueue. > > The workqueue "workqueue" has multiple workitems which may require > ordering. Hence, a dedicated ordered workqueue has been used. > Since

Re: [RESEND PATCH] usb: hub: change CLEAR_FEATURE to SET_FEATURE

2016-08-09 Thread Greg Kroah-Hartman
On Tue, Aug 09, 2016 at 04:07:56PM +0800, yonglong.wu wrote: > Hi, > On Tue, 2016-08-09 at 14:29 +0800, Peter Chen wrote: > > On Tue, Aug 9, 2016 at 11:31 AM, Yonglong Wu > wrote: > > From: Yonglong Wu > > > > According to

Re: [PATCH v3,4/5] usb: Add MediaTek USB3 DRD Driver

2016-08-08 Thread Greg Kroah-Hartman
On Fri, Jun 10, 2016 at 03:32:41PM +0800, Chunfeng Yun wrote: > --- /dev/null > +++ b/drivers/usb/mtu3/Makefile > @@ -0,0 +1,20 @@ > + > +#ifeq ($(CONFIG_USB_DEBUG),y) > + ccflags-y += -DDEBUG > +#endif There is no CONFIG_USB_DEBUG in the tree anymore, are you sure you tested this? :)

Re: [PATCH v3] cdc-wdm: fix "out-of-sync" due to missing notifications

2016-08-08 Thread Greg Kroah-Hartman
On Mon, Aug 08, 2016 at 02:12:06PM +0200, Bjørn Mork wrote: > Oliver Neukum writes: > > On Sun, 2016-07-10 at 17:45 +0200, Bjørn Mork wrote: > >> The workaround has been tested on a large number of different MBIM > >> and QMI devices, as well as the Ericsson F5521gw and H5321gw

Re: usbtmc: vendor specific i/o

2016-08-03 Thread Greg Kroah-Hartman
On Wed, Aug 03, 2016 at 09:06:25AM +0200, Ladislav Michl wrote: > On Wed, Aug 03, 2016 at 05:59:59AM +0200, Greg Kroah-Hartman wrote: > > But your patch was "one-way", once you switched to the other mode, the > > old one could not be used :( > > Yes, also

Re: usbtmc: vendor specific i/o

2016-08-02 Thread Greg Kroah-Hartman
On Tue, Aug 02, 2016 at 12:09:12PM +0200, Ladislav Michl wrote: > On Tue, Aug 02, 2016 at 11:25:22AM +0200, dave penkler wrote: > >For supportability I would recommend to set the commands depending on the > >recognised HW, not with aA ioctl. See rigol quirk. What are the device > >and

Re: usbtmc: vendor specific i/o

2016-08-01 Thread Greg Kroah-Hartman
On Mon, Aug 01, 2016 at 08:40:02PM +0200, Ladislav Michl wrote: > Hi, > > I need to ask usbtmc device for vendor specific data. What about adding ioctl > which switches MsgIDs to be vendor specific? Or are there other, better, > options? Patch bellow ilustrates changes to allow reading and

Re: [GIT PULL] USB-serial updates for v4.8-rc1

2016-07-26 Thread Greg Kroah-Hartman
On Mon, Jul 25, 2016 at 11:35:39AM +0200, Johan Hovold wrote: > Hi Greg, > > Here are my exceptionally late usb-serial updates for 4.8-rc1. Mostly > clean ups, so there's nothing here (except the device-id patch) which > cannot wait until 4.9 if you prefer to hold off on these instead of >

Re: [PATCH 1/2] usb: typec: Add USB Power Delivery sink port support

2016-07-15 Thread Greg Kroah-Hartman
On Fri, Jul 15, 2016 at 03:41:10PM -0700, Bin Gao wrote: > On Fri, Jul 15, 2016 at 02:21:48PM +0300, Felipe Balbi wrote: > > Greg Kroah-Hartman <gre...@linuxfoundation.org> writes: > > > On Fri, Jul 15, 2016 at 01:38:12PM +0300, Felipe Balbi wrote: > > >> &g

Re: [PATCH 1/2] usb: typec: Add USB Power Delivery sink port support

2016-07-15 Thread Greg Kroah-Hartman
On Fri, Jul 15, 2016 at 01:38:12PM +0300, Felipe Balbi wrote: > > Hi, > > Bin Gao writes: > > +static void print_message(int port, bool is_cmsg, u8 msg, bool recv) > > +{ > > + pr_info("sink port %d: %s message %s %s\n", port, > > + is_cmsg ?

Re: [GIT PULL] usb: chipidea changes for v4.8-rc1

2016-07-01 Thread Greg Kroah-Hartman
On Fri, Jul 01, 2016 at 10:11:26AM +0800, Peter Chen wrote: > The following changes since commit aa5e94a2e13377e374795de5400e346c978f46be: > > Revert "usb: ohci-at91: Forcibly suspend ports while USB suspend" > (2016-06-20 07:42:07 -0700) > > are available in the git repository at: > >

Re: [GIT PULL] usb patches for v4.8

2016-06-30 Thread Greg Kroah-Hartman
On Thu, Jun 30, 2016 at 02:00:40PM +0300, Roger Quadros wrote: > Greg, Felipe, > > On 30/06/16 13:45, Roger Quadros wrote: > > On 30/06/16 13:32, Felipe Balbi wrote: > >> > >> Hi, > >> > >> Roger Quadros writes: > >> here's the big pull request for gadget API and related UDC

Re: [GIT PULL] usb patches for v4.8

2016-06-29 Thread Greg Kroah-Hartman
On Wed, Jun 29, 2016 at 04:11:31PM +0300, Felipe Balbi wrote: > > Hi Greg, > > here's the big pull request for gadget API and related UDC drivers. > > Nothing really scary lately. Patches have been in linux-next for a while > without outstanding reports. > > Let me know if you want any

Re: [PATCH] usb: ohci-at91: make at91_dt_syscon_sfr static

2016-06-26 Thread Greg Kroah-Hartman
ld it be static? > > Signed-off-by: Ben Dooks <ben.do...@codethink.co.uk> > Acked-by: Nicolas Ferre <nicolas.fe...@atmel.com> > Acked-by: Alexandre Belloni <alexandre.bell...@free-electrons.com> > --- > Cc: Alan Stern <st...@rowland.harvard.edu> > Cc: Gre

Re: [PATCH v10 6/7] usb: pci-quirks: add Intel USB drcfg mux device

2016-06-17 Thread Greg Kroah-Hartman
On Thu, Jun 16, 2016 at 08:27:41AM +0800, Lu Baolu wrote: > Hi Greg, > > On 06/09/2016 10:39 AM, Lu Baolu wrote: > > Hi Greg, > > > > On 06/08/2016 11:45 PM, Greg Kroah-Hartman wrote: > >> On Wed, Jun 08, 2016 at 03:56:04PM +0800, Lu Baolu wrote: > >>

Re: [PATCH 2/2] usb: misc: remove outdated USB LED driver

2016-06-17 Thread Greg Kroah-Hartman
are supported by a new USB LED > > driver under drivers/hid utilizing the kernel LED subsystem. > > > > So let's remove the old USB LED driver. > > > > Signed-off-by: Heiner Kallweit <hkallwe...@gmail.com> > > Acked-by: Greg Kroah-Hartman &l

Re: [PATCH] usb: misc: remove outdated USB LED driver

2016-06-16 Thread Greg Kroah-Hartman
t; > So let's remove the USB LED driver. > > Signed-off-by: Heiner Kallweit <hkallwe...@gmail.com> Has the HID driver been merged yet? I'd like to have this go in as the 2nd patch in that series, so feel free to add my: Acked-by: Greg Kroah-Hartman <gre...@linuxfoundation.org>

Re: [PATCH v2] hid: migrate Riso Kagaku LED driver from USB misc to HID

2016-06-16 Thread Greg Kroah-Hartman
On Thu, Jun 16, 2016 at 07:45:35AM +0200, Heiner Kallweit wrote: > Am 15.06.2016 um 22:59 schrieb Heiner Kallweit: > > Am 15.06.2016 um 09:31 schrieb Benjamin Tissoires: > >> On Jun 15 2016 or thereabouts, Heiner Kallweit wrote: > >>> Am 14.06.2016 um 23:49 schrieb Benjamin Tissoires: > On

Re: Reset hanging Huawei USB-2.0 Internet stick

2016-06-15 Thread Greg Kroah-Hartman
On Wed, Jun 15, 2016 at 08:22:44AM +0200, Sedat Dilek wrote: > Hi Alan, > > I updated my usb-ids on my Ubuntu 12.04 LTS (AMD64). > Background was my ASMedia ASM-104x USB-3.0 controller/hub shows no > human-readable vendor-string etc. > > While checking parallelelly a new usbutils release, I saw

Re: [PATCH] USB: core: fix missing include

2016-06-13 Thread Greg Kroah-Hartman
On Tue, Jun 07, 2016 at 07:20:33PM +0100, Ben Dooks wrote: > The helper function usb_of_get_child_node() is defined in the > header but this was not included. Fix the warning > about usb_of_get_child_node() not being declared by adding the > right include. Fixes: > > drivers/usb/core/of.c:31:20:

Re: [PATCH v5 resend 1/2] ehci-platform: Add support for controllers with multiple reset lines

2016-06-08 Thread Greg Kroah-Hartman
On Wed, Jun 08, 2016 at 06:52:30PM +0200, Hans de Goede wrote: > Hi, > > On 08-06-16 07:22, Greg Kroah-Hartman wrote: > > On Thu, Jun 02, 2016 at 05:14:05PM +0200, Hans de Goede wrote: > > > From: Reinder de Haan <patches...@mveas.com> > > > > > >

Re: [PATCH v10 1/7] regulator: fixed: add support for ACPI interface

2016-06-08 Thread Greg Kroah-Hartman
On Wed, Jun 08, 2016 at 02:43:27PM +0100, Mark Brown wrote: > On Tue, Jun 07, 2016 at 09:42:48PM -0700, Greg Kroah-Hartman wrote: > > On Thu, Jun 02, 2016 at 09:37:23AM +0800, Lu Baolu wrote: > > > > Add support to retrieve fixed voltage configure information through

Re: [PATCH v5 resend 1/2] ehci-platform: Add support for controllers with multiple reset lines

2016-06-07 Thread Greg Kroah-Hartman
On Thu, Jun 02, 2016 at 05:14:05PM +0200, Hans de Goede wrote: > From: Reinder de Haan > > At least the EHCI/OHCI found on the Allwinnner H3 SoC needs multiple > reset lines, the controller will not initialize while the reset for > its companion is still asserted, which

Re: [PATCH v10 6/7] usb: pci-quirks: add Intel USB drcfg mux device

2016-06-07 Thread Greg Kroah-Hartman
On Thu, Jun 02, 2016 at 09:37:28AM +0800, Lu Baolu wrote: > In some Intel platforms, a single usb port is shared between USB host > and device controllers. The shared port is under control of a switch > which is defined in the Intel vendor defined extended capability for > xHCI. > > This patch

Re: [PATCH v10 1/7] regulator: fixed: add support for ACPI interface

2016-06-07 Thread Greg Kroah-Hartman
On Thu, Jun 02, 2016 at 09:37:23AM +0800, Lu Baolu wrote: > Add support to retrieve fixed voltage configure information through > ACPI interface. This is needed for Intel Bay Trail devices, where a > GPIO is used to control the USB vbus. > > Signed-off-by: Lu Baolu >

Re: Race condition in usbfs / libusb when using reap-after-disconnect

2016-06-06 Thread Greg Kroah-Hartman
On Mon, Jun 06, 2016 at 01:44:23PM +0200, Hans de Goede wrote: > Hi All, > > While looking at libusb today I ended up looking at the > reap-after-disconnect code. > > What stands out is that libusb expects to be able to > reap all outstanding urbs on a device on receiving > a POLL_ERR status

Re: [GIT PULL] usb fixes for v4.7-rc2

2016-06-01 Thread Greg Kroah-Hartman
On Wed, Jun 01, 2016 at 04:32:12PM +0300, Felipe Balbi wrote: > > Hi Greg, > > here's the first round of fixes for current -rc. Patches have been > tested with Intel platforms I have around. > > cheers > > The following changes since commit 1a695a905c18548062509178b98bc91e67510864: > >

Re: [PATCH] USB: xhci: Add broken streams quirk for Frescologic device id 1009

2016-06-01 Thread Greg Kroah-Hartman
On Wed, Jun 01, 2016 at 09:01:29PM +0200, Hans de Goede wrote: > I got one of these cards for testing uas with, it seems that with streams > it dma-s all over the place, corrupting memory. On my first tests it > managed to dma over the BIOS of the motherboard somehow and completely > bricked it.

[PATCH 4.4 18/86] asix: Fix offset calculation in asix_rx_fixup() causing slow transmissions

2016-05-30 Thread Greg Kroah-Hartman
er.kernel.org Reported-by: Yongqin Liu <yongqin....@linaro.org> Signed-off-by: John Stultz <john.stu...@linaro.org> Signed-off-by: David S. Miller <da...@davemloft.net> Signed-off-by: Greg Kroah-Hartman <gre...@linuxfoundation.org> --- drivers/net/usb/asix_common.c |2 +- 1 f

[PATCH 4.5 15/87] asix: Fix offset calculation in asix_rx_fixup() causing slow transmissions

2016-05-30 Thread Greg Kroah-Hartman
er.kernel.org Reported-by: Yongqin Liu <yongqin....@linaro.org> Signed-off-by: John Stultz <john.stu...@linaro.org> Signed-off-by: David S. Miller <da...@davemloft.net> Signed-off-by: Greg Kroah-Hartman <gre...@linuxfoundation.org> --- drivers/net/usb/asix_common.c |2 +- 1 f

[PATCH 4.6 014/100] asix: Fix offset calculation in asix_rx_fixup() causing slow transmissions

2016-05-30 Thread Greg Kroah-Hartman
er.kernel.org Reported-by: Yongqin Liu <yongqin....@linaro.org> Signed-off-by: John Stultz <john.stu...@linaro.org> Signed-off-by: David S. Miller <da...@davemloft.net> Signed-off-by: Greg Kroah-Hartman <gre...@linuxfoundation.org> --- drivers/net/usb/asix_common.c |2 +- 1 f

Re: [PATCH 1/1] usbip: don't call stub_device_reset() during stub_disconnect()

2016-05-27 Thread Greg Kroah-Hartman
On Fri, May 27, 2016 at 05:20:45PM +0300, Alexander Popov wrote: > Hello, > > Excuse me for disturbing, could I have a feedback? Nope, it's the middle of the merge window, I can't do anything with new patches until after 4.7-rc1 comes out. And even then, give me a week or so to catch up...

Re: [PATCH] - silence UBSAN complaint in ehci-hcd.

2016-05-19 Thread Greg Kroah-Hartman
On Thu, May 19, 2016 at 05:19:00PM -0400, Valdis Kletnieks wrote: > UBSAN throws a complaint: > > [2.418579] UBSAN: Undefined behaviour in > drivers/usb/host/ehci-hub.c:877:47 > [2.418582] index -1 is out of range for type 'u32 [1]' > > though it's only on the hostpc[] part, not on the

Re: UBSAN whinge in ihci-hub.c

2016-05-17 Thread Greg Kroah-Hartman
On Tue, May 17, 2016 at 05:52:40PM -0400, Valdis Kletnieks wrote: > So, not content in the amount of breakage I generate already, I > compiled with UBSAN enabled... > > The immediately relevant part: > > [2.418576] >

Re: [GIT PULL] USB-serial updates for v4.7-rc1

2016-05-14 Thread Greg Kroah-Hartman
On Fri, May 13, 2016 at 07:55:06PM +0200, Johan Hovold wrote: > Hi Greg, > > Here are my updates for 4.7-rc1. All have been in linux-next without any > reported issues. > > Thanks, > Johan > > > The following changes since commit 02da2d72174c61988eb4456b53f405e3ebdebce4: > > Linux 4.6-rc5

Re: [PATCH 3/3] USB: ohci-jz4740: Remove obsolete driver

2016-05-13 Thread Greg Kroah-Hartman
merge or do you want to funnel it > hrough your tree? I think it would be good to take this through the > MIPS tree together with the remainder of the series. Deleting code? Yes, I'm all for that :) Acked-by: Greg Kroah-Hartman <gre...@linuxfoundation.org> And yes, actu

Re: UBSAN: Undefined behaviour in drivers/usb/host/ehci-hub.c:877:47

2016-05-12 Thread Greg Kroah-Hartman
On Thu, May 12, 2016 at 07:38:00PM +0300, Meelis Roos wrote: > I am seeing it on multiple different PC-s. > > [7.837957] > > [7.837959] UBSAN: Undefined behaviour in > drivers/usb/host/ehci-hub.c:877:47

Re: [GIT PULL] USB-serial fixes for v4.6-rc7

2016-05-09 Thread Greg Kroah-Hartman
On Sun, May 08, 2016 at 08:09:53PM +0200, Johan Hovold wrote: > On Sat, May 07, 2016 at 07:46:14PM +0200, Greg Kroah-Hartman wrote: > > On Thu, May 05, 2016 at 12:13:11PM +0200, Johan Hovold wrote: > > > Hi Greg, > > > > > > Here are some new modem device ids f

Re: [GIT PULL] USB-serial fixes for v4.6-rc7

2016-05-07 Thread Greg Kroah-Hartman
On Thu, May 05, 2016 at 12:13:11PM +0200, Johan Hovold wrote: > Hi Greg, > > Here are some new modem device ids for the option driver. These have all > been in linux-next over night and could go into -rc7 unless you prefer > to hold them off for v4.7. I'd prefer to hold them off for 4.7, can I

Re: [PATCH v3 1/2] usb: host: ehci-tegra: Grab the correct UTMI pads reset

2016-05-04 Thread Greg Kroah-Hartman
On Wed, May 04, 2016 at 04:39:59PM +0200, Thierry Reding wrote: > From: Thierry Reding > > There are three EHCI controllers on Tegra SoCs, each with its own reset > line. However, the first controller contains a set of UTMI configuration > registers that are shared with its

Re: [patch] usb: dwc3: gadget: fix mask and shift order in DWC3_DCFG_NUMP()

2016-05-03 Thread Greg Kroah-Hartman
On Tue, May 03, 2016 at 10:53:05AM +0300, Felipe Balbi wrote: > > Hi, > > Dan Carpenter writes: > > In the original DWC3_DCFG_NUMP() was always zero. It looks like the > > intent was to shift first and then do the mask. > > > > Fixes: 2a58f9c12bb3 ('usb: dwc3: gadget:

Re: [PATCH] Revert "USB / PM: Allow USB devices to remain runtime-suspended when sleeping"

2016-05-02 Thread Greg Kroah-Hartman
On Mon, May 02, 2016 at 11:26:01AM -0400, Alan Stern wrote: > On Mon, 2 May 2016, Greg Kroah-Hartman wrote: > > > On Mon, May 02, 2016 at 11:13:10AM -0400, Alan Stern wrote: > > > On Mon, 2 May 2016, Johan Hovold wrote: > > > > > > > This reverts commi

Re: [PATCH] Revert "USB / PM: Allow USB devices to remain runtime-suspended when sleeping"

2016-05-02 Thread Greg Kroah-Hartman
On Mon, May 02, 2016 at 11:13:10AM -0400, Alan Stern wrote: > On Mon, 2 May 2016, Johan Hovold wrote: > > > This reverts commit e3345db85068ddb937fc0ba40dfc39c293dad977, which > > broke system resume for a large class of devices. > > > > Devices that after having been reset during resume need to

Re: [PATCHv3] usb: Add driver for UCSI

2016-04-29 Thread Greg Kroah-Hartman
On Fri, Apr 29, 2016 at 04:32:22PM +0300, Heikki Krogerus wrote: > Hi Greg, > > On Thu, Apr 28, 2016 at 12:53:24PM -0700, Greg Kroah-Hartman wrote: > > On Thu, Apr 21, 2016 at 03:43:40PM +0300, Heikki Krogerus wrote: > > > USB Type-C Connector System

Re: [GIT PULL] USB-serial fixes for v4.6-rc6

2016-04-29 Thread Greg Kroah-Hartman
On Fri, Apr 29, 2016 at 10:23:28AM +0200, Johan Hovold wrote: > Hi Greg, > > Here are some new device ids for rc6. These have been in next for a few > days now without any issues. > > Thanks, > Johan > > The following changes since commit c3b46c73264b03000d1e18b22f5caf63332547c9: > > Linux

Re: [PATCHv3] usb: Add driver for UCSI

2016-04-28 Thread Greg Kroah-Hartman
On Thu, Apr 21, 2016 at 03:43:40PM +0300, Heikki Krogerus wrote: > USB Type-C Connector System Software Interface (UCSI) is > specification that defines the registers and data structures > that can be used to control USB Type-C ports on a system. > UCSI is used on several Intel Broxton SoC based

Re: [PATCH 1/3] usbip: vudc: rename find_endpoint to vep_find_endpoint

2016-04-28 Thread Greg Kroah-Hartman
On Thu, Apr 28, 2016 at 09:01:01PM +0200, Krzysztof Opasiak wrote: > Duplicated. Already fixed yesterday: > > http://marc.info/?l=linux-usb=146178014931956=2 I just applied this one. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a

Re: [GIT PULL] USB: changes for v4.7 merge window

2016-04-28 Thread Greg Kroah-Hartman
On Thu, Apr 28, 2016 at 01:46:03PM +0300, Felipe Balbi wrote: > > Hi Greg, > > here's the gadget pull request for v4.7 merge window. It's mostly dwc3 > this time: > > $ git diff --dirstat v4.6-rc3 > 74.4% drivers/usb/dwc3/ > 13.9% drivers/usb/gadget/udc/ >5.2% drivers/usb/gadget/ >

Re: [PATCH] usb: core: buffer: avoid NULL pointer dereferrence

2016-04-26 Thread Greg Kroah-Hartman
On Fri, Apr 08, 2016 at 11:21:05AM -0400, Alan Stern wrote: > On Fri, 8 Apr 2016, Greg Kroah-Hartman wrote: > > > On Fri, Apr 08, 2016 at 05:08:03PM +0800, Chunfeng Yun wrote: > > > NULL pointer dereferrence will happen when class driver > > > wants to allocate zer

Re: [PATCH 0/7] usb: host: add support for threaded IRQs

2016-04-26 Thread Greg Kroah-Hartman
On Mon, Apr 11, 2016 at 04:35:37PM +0300, Felipe Balbi wrote: > Felipe Balbi writes: > > > Hi guys, > > > > this patchset introduces support for threaded IRQs > > for host controllers drivers to use. Right now, only > > XHCI has been converted, but more drivers

Re: ehci-dbg prints random memory (# CONFIG_DYNAMIC_DEBUG is not set)

2016-04-13 Thread Greg Kroah-Hartman
On Wed, Apr 13, 2016 at 08:44:25AM +0200, Rafał Miłecki wrote: > Hi, > > I'm trying to debug some EHCI issue so I enabled debugging by adding > ccflags-y := -DDEBUG > to the drivers/usb/host/Makefile > > Some of debugging lines contain random memory, e.g.: > ehci-platform ehci-platform.0:

Re: [PATCH 0/7] usb: host: add support for threaded IRQs

2016-04-11 Thread Greg Kroah-Hartman
On Mon, Apr 11, 2016 at 03:44:09PM +0300, Felipe Balbi wrote: > Hi guys, > > this patchset introduces support for threaded IRQs > for host controllers drivers to use. Right now, only > XHCI has been converted, but more drivers could > easily be converted as well. > > With this series we can,

Re: [GIT PULL] USB-serial fixes for v4.6-rc3

2016-04-08 Thread Greg Kroah-Hartman
On Fri, Apr 08, 2016 at 03:56:28PM +0200, Johan Hovold wrote: > Hi Greg, > > Here are some new device ids for -rc3. > > Thanks, > Johan > > The following changes since commit 9735a22799b9214d17d3c231fe377fc852f042e9: > > Linux 4.6-rc2 (2016-04-03 09:09:40 -0500) > > are available in the git

Re: [PATCH] usb: core: buffer: avoid NULL pointer dereferrence

2016-04-08 Thread Greg Kroah-Hartman
On Fri, Apr 08, 2016 at 05:08:03PM +0800, Chunfeng Yun wrote: > NULL pointer dereferrence will happen when class driver > wants to allocate zero length buffer and pool_max[0] > can't be used, so skip reserved pool in this case. Why would a driver want to allocate a 0 length buffer? What driver

Re: [GIT PULL] usb: fixes for v4.6-rc3

2016-04-07 Thread Greg Kroah-Hartman
On Thu, Apr 07, 2016 at 01:39:23PM +0300, Felipe Balbi wrote: > > Hi Greg, > > here's my second pull request for this -rc cycle. Patches have been > tested (where applicable) on 3 different Intel platforms (including the > one for which we're adding a new PCI ID - Broxton). > > Let me know if

Re: [PATCH v3 3/7] usb: mux: add common code for Intel dual role port mux

2016-04-06 Thread Greg Kroah-Hartman
On Wed, Apr 06, 2016 at 01:19:04PM +0300, Felipe Balbi wrote: > > What happened to getting internal help in designing this api? This > > shouldn't be my job :) > > I looked at this Baolu but, at least to me, it's unclear what you're > hinting here. Sure, the API is a bit odd in that we register

Re: [PATCH v3 3/7] usb: mux: add common code for Intel dual role port mux

2016-04-06 Thread Greg Kroah-Hartman
On Wed, Apr 06, 2016 at 01:58:52PM +0800, Lu Baolu wrote: > Hi, > > On 03/11/2016 07:57 AM, Greg Kroah-Hartman wrote: > > On Thu, Mar 10, 2016 at 01:39:43PM +0100, Oliver Neukum wrote: > >> On Tue, 2016-03-08 at 15:53 +0800, Lu Baolu wrote: > >> > >>>

Re: [PATCH v3 3/7] usb: mux: add common code for Intel dual role port mux

2016-04-06 Thread Greg Kroah-Hartman
On Wed, Apr 06, 2016 at 02:44:55PM +0800, Lu Baolu wrote: > Hi, > > On 03/14/2016 11:27 AM, Greg Kroah-Hartman wrote: > > On Mon, Mar 14, 2016 at 09:09:22AM +0800, Lu Baolu wrote: > >> On 03/11/2016 08:06 AM, Greg Kroah-Hartman wrote: > >>> On Tue, Mar 08, 2016

Re: [PATCH v10 8/9] usb: xhci: Add NVIDIA Tegra XUSB controller driver

2016-04-05 Thread Greg Kroah-Hartman
On Tue, Apr 05, 2016 at 03:17:51PM +0200, Thierry Reding wrote: > Hi Mathias, Greg, > > Due to the various dependencies within the series, I'd prefer this to go > via the Tegra tree. Would you be okay with providing your Acked-by? That's all up to Mathias, I'll defer to him here :) thanks,

Re: [PATCH 0/3] USB: serial: add missing endpoint checks

2016-03-31 Thread Greg Kroah-Hartman
On Thu, Mar 31, 2016 at 12:04:23PM -0400, Johan Hovold wrote: > Greg, > > These patches from Oliver add some sanity checks for missing endpoints > and should go into v4.6-rc2. > > Would you mind picking these up directly? I expect to process the rest > of my queue early next week. Now applied,

Re: [GIT PULL] USB fixes for v4.6-rc2

2016-03-30 Thread Greg Kroah-Hartman
On Wed, Mar 30, 2016 at 01:48:28PM +0300, Felipe Balbi wrote: > > Hi Greg, > > here's the first set of fixes for v4.6-rc cycle. Let me know if you want > anything to be changed ;-) > > The following changes since commit f55532a0c0b8bb6148f4e07853b876ef73bc69ca: > > Linux 4.6-rc1 (2016-03-26

Re: [PATCH v5 6/6] mfd: intel_vuport: Add Intel virtual USB port MFD Driver

2016-03-19 Thread Greg Kroah-Hartman
On Fri, Mar 18, 2016 at 04:43:21PM +0800, Lu Baolu wrote: > > > On 03/18/2016 04:09 PM, Lee Jones wrote: > > On Fri, 18 Mar 2016, Lu Baolu wrote: > > > >> Some Intel platforms have an USB port mux controlled by GPIOs. > >> There's a single ACPI platform device that provides both USB ID > >>

Re: [PATCH] USB: input: powermate: fix oops with malicious USB descriptors

2016-03-14 Thread Greg Kroah-Hartman
On Mon, Mar 14, 2016 at 12:46:26PM -0400, Josh Boyer wrote: > On Mon, Mar 14, 2016 at 12:15 PM, Greg Kroah-Hartman > <gre...@linuxfoundation.org> wrote: > > On Mon, Mar 14, 2016 at 10:12:53AM -0400, Josh Boyer wrote: > >> The powermate driver expects at least on

Re: [PATCH] USB: input: powermate: fix oops with malicious USB descriptors

2016-03-14 Thread Greg Kroah-Hartman
On Mon, Mar 14, 2016 at 10:12:53AM -0400, Josh Boyer wrote: > The powermate driver expects at least one valid USB endpoint in its > probe function. If given malicious descriptors that specify 0 for > the number of endpoints, it will crash. Validate the number of > endpoints on the interface

Re: [PATCH v3 3/7] usb: mux: add common code for Intel dual role port mux

2016-03-13 Thread Greg Kroah-Hartman
On Mon, Mar 14, 2016 at 09:09:22AM +0800, Lu Baolu wrote: > On 03/11/2016 08:06 AM, Greg Kroah-Hartman wrote: > > On Tue, Mar 08, 2016 at 03:53:44PM +0800, Lu Baolu wrote: > >> +struct intel_mux_dev { > >> + struct device *dev; > >> + char

Re: [PATCH v3 0/7] usb: add support for Intel dual role port mux

2016-03-10 Thread Greg Kroah-Hartman
On Fri, Mar 11, 2016 at 08:20:43AM +0800, Lu Baolu wrote: > > > On 03/11/2016 08:03 AM, Greg Kroah-Hartman wrote: > > On Tue, Mar 08, 2016 at 03:53:41PM +0800, Lu Baolu wrote: > >> Intel SOC chips are featured with USB dual role. The host role is > >> provided

Re: [PATCH v3 3/7] usb: mux: add common code for Intel dual role port mux

2016-03-10 Thread Greg Kroah-Hartman
On Tue, Mar 08, 2016 at 03:53:44PM +0800, Lu Baolu wrote: > Several Intel PCHs and SOCs have an internal mux that is used to > share one USB port between device controller and host controller. > > A usb port mux could be abstracted as the following elements: > 1) mux state: HOST or PERIPHERAL; >

Re: [PATCH v3 0/7] usb: add support for Intel dual role port mux

2016-03-10 Thread Greg Kroah-Hartman
On Tue, Mar 08, 2016 at 03:53:41PM +0800, Lu Baolu wrote: > Intel SOC chips are featured with USB dual role. The host role is > provided by Intel xHCI IP, and the gadget role is provided by IP > from designware. Tablet platform designs always share a single > port for both host and gadget

Re: [RFC 7/7] USB: usbatm: avoid fragile and inefficient snprintf use

2016-03-10 Thread Greg Kroah-Hartman
On Tue, Mar 08, 2016 at 01:01:09PM -0800, Joe Perches wrote: > On Tue, 2016-03-08 at 21:40 +0100, Rasmus Villemoes wrote: > > Passing overlapping source and destination is fragile, and in this > > case we can even simplify the code and avoid the huge stack buffer by > > using the %p extension for

Re: [PATCH v3 3/7] usb: mux: add common code for Intel dual role port mux

2016-03-10 Thread Greg Kroah-Hartman
On Thu, Mar 10, 2016 at 01:39:43PM +0100, Oliver Neukum wrote: > On Tue, 2016-03-08 at 15:53 +0800, Lu Baolu wrote: > > > diff --git a/Documentation/ABI/testing/sysfs-bus-platform > > b/Documentation/ABI/testing/sysfs-bus-platform > > index 5172a61..a2261cb 100644 > > ---

Re: [GIT PULL] USB-serial updates for v4.6-rc1

2016-03-08 Thread Greg Kroah-Hartman
On Tue, Mar 08, 2016 at 07:17:29PM +0100, Johan Hovold wrote: > Hi Greg, > > Here are the usb-serial updates for 4.6-rc1. > > These patches have all been in linux-next for a while now without any > reported issues. > > Thanks, > Johan > > > The following changes since commit

Re: [PATCH] usb: musb: jz4740: fix error check of usb_get_phy()

2016-03-08 Thread Greg Kroah-Hartman
On Wed, Mar 09, 2016 at 03:17:21AM +0200, Vladimir Zapolskiy wrote: > Hi Felipe, > > On 09.03.2016 02:57, Vladimir Zapolskiy wrote: > > The usb_get_phy() function returns either a valid pointer to phy or > > ERR_PTR() error, check for NULL always fails and may lead to oops on > > error path, fix

Re: Minor xhci issues (failed to peer) on Dell XPS 13 9350 (Skylake)

2016-03-07 Thread Greg Kroah-Hartman
s.ny...@linux.intel.com> wrote: > >> On 17.02.2016 07:19, Andy Lutomirski wrote: > >>> > >>> On Tue, Feb 16, 2016 at 6:33 PM, Greg Kroah-Hartman > >>> <gre...@linuxfoundation.org> wrote: > >>>> > >>>> On Tue, Feb 16, 2016

Re: [linux-sunxi] Re: [PATCH v4 1/2] ehci-platform: Add support for controllers with multiple reset lines

2016-03-05 Thread Greg Kroah-Hartman
On Fri, Mar 04, 2016 at 08:27:26AM +0100, Hans de Goede wrote: > Hi, > > On 04-03-16 05:35, Greg Kroah-Hartman wrote: > >On Sat, Feb 27, 2016 at 05:58:58PM +0100, Hans de Goede wrote: > >>From: Reinder de Haan <patches...@mveas.com> > >> > >>At le

Re: [GIT PULL] USB changes for v4.6

2016-03-04 Thread Greg Kroah-Hartman
On Fri, Mar 04, 2016 at 03:19:11PM +0200, Felipe Balbi wrote: > > Hi Greg, > > here's the gadget pull request for v4.6. This time I had to based it on > top of your greg/usb-next to avoid duplicated commits for the USB 3.1 > work which some dwc3 changes depended on. Another benefit of the rebase

Re: [PATCH v4 1/2] ehci-platform: Add support for controllers with multiple reset lines

2016-03-03 Thread Greg Kroah-Hartman
On Sat, Feb 27, 2016 at 05:58:58PM +0100, Hans de Goede wrote: > From: Reinder de Haan > > At least the EHCI/OHCI found on the Allwinnner H3 SoC needs multiple > reset lines, the controller will not initialize while the reset for > its companion is still asserted, which

Re: [PATCH 5/7] usb: misc: add driver for Intel drcfg controlled port mux

2016-03-03 Thread Greg Kroah-Hartman
On Fri, Mar 04, 2016 at 09:38:58AM +0800, Lu Baolu wrote: > > > On 03/04/2016 12:14 AM, Greg Kroah-Hartman wrote: > > On Thu, Mar 03, 2016 at 02:37:42PM +0800, Lu Baolu wrote: > >> Several Intel PCHs and SOCs have an internal mux that is used to > >> share one U

Re: [GIT PULL] USB-serial fixes for v4.5-rc7

2016-03-03 Thread Greg Kroah-Hartman
On Thu, Mar 03, 2016 at 05:34:11PM +0100, Johan Hovold wrote: > Hi Greg, > > Here's a final set of fixes for 4.5-rc. > > Thanks, > Johan > > > The following changes since commit fc77dbd34c5c99bce46d40a2491937c3bcbd10af: > > Linux 4.5-rc6 (2016-02-28 08:41:20 -0800) > > are available in the

Re: [PATCH 3/7] usb: misc: add common code for Intel dual role port mux

2016-03-03 Thread Greg Kroah-Hartman
On Thu, Mar 03, 2016 at 02:37:40PM +0800, Lu Baolu wrote: > +#if IS_ENABLED(CONFIG_USB_MUX) > +extern int usb_mux_register(struct usb_mux_dev *mux); > +extern int usb_mux_unregister(struct device *dev); > +extern struct usb_mux_dev *usb_mux_get_dev(struct device *dev); This api needs a lot of

Re: [PATCH 5/7] usb: misc: add driver for Intel drcfg controlled port mux

2016-03-03 Thread Greg Kroah-Hartman
On Thu, Mar 03, 2016 at 02:37:42PM +0800, Lu Baolu wrote: > Several Intel PCHs and SOCs have an internal mux that is used to > share one USB port between device controller and host controller. > The mux is handled through the Dual Role Configuration Register. > > Signed-off-by: Heikki Krogerus

Re: [PATCH 5/7] usb: misc: add driver for Intel drcfg controlled port mux

2016-03-03 Thread Greg Kroah-Hartman
On Thu, Mar 03, 2016 at 02:37:42PM +0800, Lu Baolu wrote: > Several Intel PCHs and SOCs have an internal mux that is used to > share one USB port between device controller and host controller. > The mux is handled through the Dual Role Configuration Register. > > Signed-off-by: Heikki Krogerus

Re: [PATCH 3/7] usb: misc: add common code for Intel dual role port mux

2016-03-03 Thread Greg Kroah-Hartman
On Thu, Mar 03, 2016 at 02:37:40PM +0800, Lu Baolu wrote: > Several Intel PCHs and SOCs have an internal mux that is used to > share one USB port between device controller and host controller. > > A usb port mux could be abstracted as the following elements: > 1) mux state: HOST or PERIPHERAL; >

Re: [GIT PULL] USB fixes for v4.5-rc6

2016-02-24 Thread Greg Kroah-Hartman
On Tue, Feb 23, 2016 at 09:04:55AM +0200, Felipe Balbi wrote: > > Hi Greg, > > here's what I hope to be the last pull request for current -rc > cycle. Let me know if you want any changes on the contents. > > cheers > > The following changes since commit

Re: [PATCH v2 1/3] usb: core: Allow compilation on platforms where NO_DMA=y

2016-02-21 Thread Greg Kroah-Hartman
On Sun, Feb 21, 2016 at 10:46:59PM +0100, Geert Uytterhoeven wrote: > Hi Greg, > > On Sun, Feb 21, 2016 at 5:23 AM, Greg Kroah-Hartman > <gre...@linuxfoundation.org> wrote: > > On Tue, Feb 16, 2016 at 04:10:57PM +0100, Geert Uytterhoeven wrote: > >> Some platfo

Re: commit 4b61b4f205eabfc9f863f805858aa5b32deb3de5 - usb: add HAS_IOMEM dependency to USB_APPLEDISPLAY

2016-02-20 Thread Greg Kroah-Hartman
On Sat, Feb 20, 2016 at 11:44:38PM +0100, Vegard Nossum wrote: > On 02/20/2016 11:22 PM, Greg Kroah-Hartman wrote: > >On Tue, Feb 16, 2016 at 05:43:32PM +0100, Oliver Neukum wrote: > >>On Tue, 2016-02-16 at 13:12 +0100, Vegard Nossum wrote: > >>>Alright, let's have a

Re: commit 4b61b4f205eabfc9f863f805858aa5b32deb3de5 - usb: add HAS_IOMEM dependency to USB_APPLEDISPLAY

2016-02-20 Thread Greg Kroah-Hartman
On Tue, Feb 16, 2016 at 05:43:32PM +0100, Oliver Neukum wrote: > On Tue, 2016-02-16 at 13:12 +0100, Vegard Nossum wrote: > > Alright, let's have a look. The warning I was fixing in this patch > > was: > > > > warning: (USB_APPLEDISPLAY) selects BACKLIGHT_LCD_SUPPORT which > > has > > unmet

Re: USB oops regression caused by -stable patch

2016-02-20 Thread Greg Kroah-Hartman
On Fri, Feb 19, 2016 at 09:39:57AM -0500, Tony Battersby wrote: > This upstream commit is causing an oops: > d8f00cd685f5 ("usb: hub: do not clear BOS field during reset device") > > This patch has already been included in several -stable kernels. Here > are the affected kernels: > 4.5.0-rc4

Re: [GIT PULL] USB-serial fixes for v4.5-rc5

2016-02-20 Thread Greg Kroah-Hartman
On Fri, Feb 19, 2016 at 09:23:25PM +0100, Johan Hovold wrote: > Hi Greg, > > Here are some new device ids for rc5. > > Thanks, > Johan > > > The following changes since commit 18558cae0272f8fd9647e69d3fec1565a7949865: > > Linux 4.5-rc4 (2016-02-14 13:05:20 -0800) > > are available in the

Re: [GIT PULL] USB Chipidea fixes for v4.5-rc5

2016-02-20 Thread Greg Kroah-Hartman
On Fri, Feb 19, 2016 at 02:30:35PM +0800, Peter Chen wrote: > The following changes since commit 18558cae0272f8fd9647e69d3fec1565a7949865: > > Linux 4.5-rc4 (2016-02-14 13:05:20 -0800) > > are available in the git repository at: > >

Re: [PATCH v2] usb: storage: use usb_store_dbg instead of US_DEBUGPX

2016-02-17 Thread Greg Kroah-Hartman
On Wed, Feb 17, 2016 at 10:42:37AM -0800, Victor Dodon wrote: > The US_DEBUGPX macro uses printk without specifying a kernel log level, so > the default kernel log level is used, which may not match LOGLEVEL_DEBUG > used in usb_stor_dbg. Remove the macro and use usb_store_dbg instead. > >

Re: Minor xhci issues (failed to peer) on Dell XPS 13 9350 (Skylake)

2016-02-16 Thread Greg Kroah-Hartman
On Tue, Feb 16, 2016 at 10:01:13AM -0800, Andy Lutomirski wrote: > I get some warnings at boot on all kernels I've tried. On 4.5-rc4, I see: > > [0.229429] usbcore: registered new interface driver usbfs > [0.229436] usbcore: registered new interface driver hub > [0.229451] usbcore:

Re: [PATCH] usb: storage: make US_DEBUGPX print with LOGLEVEL_DEBUG

2016-02-16 Thread Greg Kroah-Hartman
On Tue, Feb 16, 2016 at 03:45:39PM -0800, Victor Dodon wrote: > On Sun, Feb 14, 2016 at 05:20:21PM -0800, Greg Kroah-Hartman wrote: > > On Wed, Feb 10, 2016 at 04:13:43PM -0800, Victor Dodon wrote: > > > The US_DEBUGPX macro uses printk without specifying a kernel log level, so

Re: [PATCH] usb: storage: make US_DEBUGPX print with LOGLEVEL_DEBUG

2016-02-14 Thread Greg Kroah-Hartman
On Wed, Feb 10, 2016 at 04:13:43PM -0800, Victor Dodon wrote: > The US_DEBUGPX macro uses printk without specifying a kernel log level, so > the default kernel log level is used, which may not match LOGLEVEL_DEBUG > used in usb_stor_dbg. Use printk_emit with LOGLEVEL_DEBUG instead. > >

Re: [PATCH 20/21] usb: support building without CONFIG_HAS_DMA

2016-02-14 Thread Greg Kroah-Hartman
On Wed, Feb 10, 2016 at 03:29:55PM +0100, Vegard Nossum wrote: > Some platforms don't have DMA, but we should still be able to build > USB drivers for these platforms. They could still be used through > vhci_hcd, usbip_host, or maybe something like USB passthrough in UML > from a capable host. >

Re: [PATCH 02/21] usb: add HAS_IOMEM dependency to USB_NET2272

2016-02-10 Thread Greg Kroah-Hartman
On Wed, Feb 10, 2016 at 03:29:37PM +0100, Vegard Nossum wrote: > drivers/usb/gadget/udc/net2272.c: In function ‘net2272_remove’: > drivers/usb/gadget/udc/net2272.c:2232:2: error: implicit declaration of > function ‘iounmap’ [-Werror=implicit-function-declaration] > iounmap(dev->base_addr); >

Re: [RFC][PATCH] usb: gadget: u_ether: Add workqueue as bottom half handler for rx data path

2016-02-09 Thread Greg Kroah-Hartman
On Tue, Feb 09, 2016 at 10:17:46PM +0530, Amit Pundir wrote: > On 9 February 2016 at 04:50, Greg Kroah-Hartman > <gre...@linuxfoundation.org> wrote: > > On Tue, Feb 09, 2016 at 02:07:02AM +0530, Amit Pundir wrote: > >> Please ignore this one too. I should have

<    2   3   4   5   6   7   8   9   10   11   >