Re: [PATCH] HID: Add quirk for Primax PIXART OEM mice

2018-11-20 Thread Jiri Kosina
gt; CC: sta...@vger.kernel.org Applied, thanks. -- Jiri Kosina SUSE Labs

Re: [PATCH] HID: Add quirk for Microsoft PIXART OEM mouse

2018-11-08 Thread Jiri Kosina
CROSOFT, > USB_DEVICE_ID_MS_PIXART_MOUSE), HID_QUIRK_ALWAYS_POLL }, > { HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT, > USB_DEVICE_ID_MS_POWER_COVER), HID_QUIRK_NO_INIT_REPORTS }, > { HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT, > USB_DEVICE_ID_MS_SURFACE_PRO_2), HID_QUIRK_NO_INIT_REPORTS }, >

Re: [PATCH v2] HID: hiddev: fix potential Spectre v1

2018-10-26 Thread Jiri Kosina
t > to index field->usage (HIDIOCGCOLLECTIONINDEX) or field->value in > HIDIOC{G,S}USAGES arrays, thus, avoiding speculation in the first load. > > Signed-off-by: Breno Leitao > Cc: Applied, thanks. -- Jiri Kosina SUSE Labs

Re: [hid:for-4.20/microsoft 2/2] hid-microsoft.c:undefined reference to `input_ff_create_memless'

2018-09-05 Thread Jiri Kosina
gt; > All errors (new ones prefixed by >>): > >drivers/hid/hid-microsoft.o: In function `ms_probe': > >> hid-microsoft.c:(.text+0x2d7): undefined reference to > >> `input_ff_create_memless' Now fixed in the branch as below. Thanks! From: Jiri Kos

Re: [hid:for-4.20/multitouch 1/1] drivers/hid/hid-multitouch.c:1327:5: error: 'struct hid_input' has no member named 'application'

2018-09-04 Thread Jiri Kosina
HID_DG_STYLUS; > ^~ >drivers/hid/hid-multitouch.c: In function 'mt_input_configured': >drivers/hid/hid-multitouch.c:1527:12: error: 'struct hid_input' has no > member named 'application' > switch (hi->application) { >^~ That is my mismerge. I've fixed it now. Thanks for the report and sorry for the noise. -- Jiri Kosina SUSE Labs

Re: [PATCH] HID: usbhid: use irqsave() in USB's complete callback

2018-06-25 Thread Jiri Kosina
dler to disable the interrupts while acquiring the lock. > The callback may be invoked either in IRQ or BH context depending on the > USB host controller. > Use the _irqsave() variant of the locking primitives. Applied, thanks. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: se

Re: [hid:for-4.18/multitouch 7/7] drivers/hid/hid-multitouch.c:1209:9-10: WARNING: return of 0/1 in function 'mt_need_to_apply_feature' with return type bool

2018-05-16 Thread Jiri Kosina
_feature +1209 drivers/hid/hid-multitouch.c Thanks, I've fixed that up in the branch. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [hid:for-4.17/multitouch 1/3] drivers/hid/hid-multitouch.c:332:4: error: 'MT_QUIRK_WIN8_PTP_BUTTONS' undeclared here (not in a function); did you mean 'MT_QUIRK_IGNORE_DUPLICATES'?

2018-03-23 Thread Jiri Kosina
_PTP_BUTTONS' > >> undeclared here (not in a function); did you mean > >> 'MT_QUIRK_IGNORE_DUPLICATES'? >MT_QUIRK_WIN8_PTP_BUTTONS, >^ >MT_QUIRK_IGNORE_DUPLICATES Ah, that's my mismerge (the for-next branch is OK), I'll f

Re: [PATCH] HID: usbhid: extend the polling interval configuration to keyboards

2018-03-23 Thread Jiri Kosina
th a Cooler Master Devastator with > kbpoll=32, resulting in delay between events of 32 ms(values were taken > from evtest). > > Signed-off-by: Filip Alac <filipa...@gmail.com> Applied, thanks. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line

Re: [PATCH v2] HID: add quirk for another PIXART OEM mouse used by HP

2017-12-07 Thread Jiri Kosina
input: USB HID v1.11 Mouse > [PixArt HP USB Optical Mouse] on usb-:00:14.0-2/input0 Applied, thanks. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] HID: usbhid: Convert timers to use timer_setup()

2017-10-11 Thread Jiri Kosina
ch. Applied, thanks. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2] HID: usbhid: fix out-of-bounds bug

2017-10-11 Thread Jiri Kosina
> In addition, if bNumDescriptors of the hid descriptor have an incorrect > value, this can also cause out-of-bounds while approaching hdesc->desc[n]. > > So check the size of hid descriptor and bNumDescriptors. Applied to for-4.14/upstream-fixes. Thanks, -- Jiri Kosina SUSE Labs -- To un

Re: RH Bugzilla - Bug 1482649 - Logitech USB Unified Receiver+M570 need 'waking' up by click after kernel update

2017-09-08 Thread Jiri Kosina
device, but apparently only 4.12 actually does so. Could you please confirm that with usbmon traces? Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] HID: add multi-input quirk for IDC6680 touchscreen

2017-09-06 Thread Jiri Kosina
8191 instead of 65535). > > For reference, here are the full reports: I am all for verbose changelogs, but including the rdesc dump is probably a little bit too much :) So I've striped that and applied to for-4.14/upstream-fixes. Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this l

Re: [PATCH 0/2] constify hid usb_device_id and fix space before '[' error

2017-08-10 Thread Jiri Kosina
On Wed, 9 Aug 2017, Arvind Yadav wrote: > usb_device_id are not supposed to change at runtime. All functions > working with usb_device_id provided by work with > const usb_device_id. So mark the non-const structs as const. Applied to for-4.14/upstream. -- Jiri Kosina

Re: [PATCH] HID: add ALWAYS_POLL quirk for Logitech 0xc077

2017-07-31 Thread Jiri Kosina
out the ID number. Yeah, well, the symbolic names don't necessarily have to be used if the device doesn't have any real recognizable branding name ... -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] HID: add ALWAYS_POLL quirk for Logitech 0xc077

2017-07-31 Thread Jiri Kosina
f the original > USB_DEVICE_ID_LOGITECH_C077 define or in the value assigned to > it (0xc007). This is something for Oliver to figure out -- Oliver, that appeared through your commit a415457733b5f; are you able to still find out the details? Thanks, -- Jiri Kosina SUSE Labs -- To u

Re: v4.13-rc2: usb mouse stopped working?

2017-07-24 Thread Jiri Kosina
usb-:00:1d.0-1.1.1.1/input0 ... this is most likely caused by e399396a6b0, and fix for that is queued in hid.git as cf601774c9f ("HID: usbhid: fix "always poll" quirk"); I'm planning to send it to Linus' tomorrow, but if you can double-check that it does fix your issue as well,

Re: [PATCH] HID: usbhid: fix "always poll" quirk

2017-07-21 Thread Jiri Kosina
yesterday pull request, sorry for that. Applied now to for-4.13/upstream-fixes and will be sending upstream next week. Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] HID: let generic driver yield control iff specific driver has been enabled (was Re: Two regressions on BYT/T ASUS T100TA 4.12-rc: #2 Keyboard no longer works)

2017-06-15 Thread Jiri Kosina
On Tue, 13 Jun 2017, Benjamin Tissoires wrote: > BTW, the merge with your for-next branch is going to be tricky :( I've just pushed the for-next merge. Second/third pair of eyes (scripted eyes even better :) ) would be appreciated. Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe f

Re: [PATCH] HID: let generic driver yield control iff specific driver has been enabled (was Re: Two regressions on BYT/T ASUS T100TA 4.12-rc: #2 Keyboard no longer works)

2017-06-13 Thread Jiri Kosina
in > > 4.12-rc5, and you have 360 in your patch: > > - { HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, > > USB_DEVICE_ID_LOGITECH_G920_WHEEL) } > > is added twice (the one in CONFIG_HID_LOGITECH should be dropped IMO). > > Only this one is would require a change now. This

Re: [PATCH] HID: let generic driver yield control iff specific driver has been enabled (was Re: Two regressions on BYT/T ASUS T100TA 4.12-rc: #2 Keyboard no longer works)

2017-06-13 Thread Jiri Kosina
ching-fix' of hid.git, and if no more issues are discovered, I'll push that to Linus this week so that we finally get rid of this long-lasting PITA (while still heading towards 'automatic' proper matching -- Benjamin already had some proposals how to tackle this). Thanks, -- Jiri Ko

[PATCH] HID: let generic driver yield control iff specific driver has been enabled (was Re: Two regressions on BYT/T ASUS T100TA 4.12-rc: #2 Keyboard no longer works)

2017-06-09 Thread Jiri Kosina
On Fri, 9 Jun 2017, Jiri Kosina wrote: > This is something I've been wanting to fix for ages, but never really got > to it. So let's take this as the final impulse to do it. So I'd suggest to go with something like the below for 4.12-rc. Hmm? From: Jiri Kosina <jkos...@suse.cz

Re: Two regressions on BYT/T ASUS T100TA 4.12-rc: #2 Keyboard no longer works

2017-06-09 Thread Jiri Kosina
ial and let it attach as a 'last resort driver' if none of the specific driver picked the device up during probe. But I don't think our current driver model allows this easily ... or is there way I am not seeing? Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line &

Re: [PATCH] HID: Add quirk for Dell PIXART OEM mouse

2017-06-06 Thread Jiri Kosina
ed by Dell. Ah, so you didn't mean "device IDs" in the sense of VID/PID, but branding names. Queued in for-4.12/upstream-fixes branch. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majo

Re: [PATCH] HID: Add quirk for Dell PIXART OEM mouse

2017-06-06 Thread Jiri Kosina
On Tue, 6 Jun 2017, Sebastian Parschauer wrote: > This mouse is also known under other IDs. Do you know (some of the) other IDs? Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vg

Re: [PATCH] HID: usbhid: Add HID_QUIRK_NOGET for Aten CS-1758 KVM switch

2017-04-26 Thread Jiri Kosina
On Tue, 25 Apr 2017, Vasilis Liaskovitis wrote: > Like other switches, the Aten CS-1758 KVM switch needs a quirk to avoid > spewing errors: > > [12599018.071059] usb 5-2: input irq status -75 received > [12599018.079053] usb 5-2: input irq status -75 received Applied, thanks.

Re: [PATCH v2 0/2] HID: hiddev: move hiddev's minor number and refactoring

2017-03-21 Thread Jiri Kosina
On Fri, 3 Mar 2017, Jaejoong Kim wrote: > Jaejoong Kim (2): > HID: cp2112: use proper hidraw name with minor number > HID: hiddev: reallocate hiddev's minor number Applied to for-4.12/hiddev. Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line &qu

Re: [PATCH v2] HID: remove initial reading of reports at connect

2017-03-21 Thread Jiri Kosina
wacom) already > retrieves the features manually. Applied to for-4.12/nuke-no-init-reports-quirk. Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] HID: usbhid: extend polling interval configuration to joysticks

2017-03-06 Thread Jiri Kosina
=2, > resulting in a polling rate of 500Hz (verified with evhz). > > Signed-off-by: Tobias Jakobi <tjak...@math.uni-bielefeld.de> Applied to for-4.12/upstream. Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-usb&

Re: [PATCH] HID: usbhid: Use pr_ and remove unnecessary OOM messages

2017-03-06 Thread Jiri Kosina
escendent above a printk > > Signed-off-by: Joe Perches <j...@perches.com> Applied to for-4.12/upstream. Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More major

Re: [PATCH] HID: get rid of HID_QUIRK_NO_INIT_REPORTS

2017-03-06 Thread Jiri Kosina
iver vendor" in case the driver seems to assume initialized reports) at least for a few years. I think that either doing it at a connect time, or during first EVIOCGUSAGE ioctl() call is a must. Otherwise, I'd be super-happy to finally get rid of this giant PITA. Thanks!

Re: [PATCH] HID: usbhid: Quirk a AMI virtual mouse and keyboard with ALWAYS_POLL

2017-01-26 Thread Jiri Kosina
and when we have some > rapid open/closes on the mouse device. Applied, thanks. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] HID: get rid of HID_QUIRK_NO_INIT_REPORTS

2017-01-23 Thread Jiri Kosina
etty sure there are more. So we'd rather be careful not to break hiddev by default. I'll think about your RFC a little bit more. Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel

Re: [PATCH 0/2] HID: corsair: fix DMA to stack and info leaks

2017-01-13 Thread Jiri Kosina
On Thu, 12 Jan 2017, Johan Hovold wrote: > These patches fix DMA buffers on stack and information leaks in the > corsair HID driver. > > Note that this series has only been compile tested. Adding Clément to CC, and applying to for-4.10/upstream-fixes branch. Thanks! -- Jiri Kosi

Re: [PATCH] HID: remove use of DRIVER_LICENSE

2017-01-06 Thread Jiri Kosina
On Thu, 5 Jan 2017, Grant Grundler wrote: > Local "#define DRIVER_LICENSE" obfuscates which license is used > in MODULE_LICENSE(). "fgrep -R MODULE_LICENSE" is more informative > when the string is hard coded in MODULE_LICENSE. Applied to hid.git#for-4.11/upstream.

Re: [hid:for-4.10/i2c-hid 7/8] drivers/hid/i2c-hid/i2c-hid.c:772:19: error: 'struct i2c_hid' has no member named 'irq'

2016-12-12 Thread Jiri Kosina
On Sat, 10 Dec 2016, Benjamin Tissoires wrote: > Ouch. Sorry, I should have spotted this during review. > > Jiri, could you apply the following simple fix: Applied, thanks. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-us

Re: [PATCH 1/1 v2] input: usbhid: fix improper return value

2016-12-09 Thread Jiri Kosina
On Mon, 5 Dec 2016, Pan Bian wrote: > Function hid_post_reset() should return negative error codes on > failures. However, in its implementation, it incorrectly returns 1. > This patch fixes the bug, returning proper error codes on failures. Applied to for-4.10/upstream. Thanks, -- Ji

Re: [hid:for-4.10/i2c-hid 6/7] drivers/hid/i2c-hid/i2c-hid.c:1048:23: error: implicit declaration of function 'devm_regulator_get'

2016-12-09 Thread Jiri Kosina
lator_enable(ihid->pdata.supply); >^~~~ > >> drivers/hid/i2c-hid/i2c-hid.c:1139:2: error: implicit declaration of > >> function 'regulator_disable' [-Werror=implicit-function-declaration] > regulator_disable(ihid->pdata.supply); > ^~~~~~

Re: [PATCH] usbhid: add ATEN CS962 to list of quirky devices

2016-11-03 Thread Jiri Kosina
On Thu, 3 Nov 2016, Oliver Neukum wrote: > Like many similar devices it needs a quirk to work. > Issuing the request gets the device into an irrecoverable state. Applied to hid.git#for-4.9/upstream-fixes. Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send th

Re: [PATCH] Add HID quirks for Akai MIDImix.

2016-10-10 Thread Jiri Kosina
y. > > Signed-off-by: Steinar H. Gunderson <sgunder...@bigfoot.com> Applied for 4.9-rc. Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2] hid: hid-led: fix issue with transfer buffer not being dma capable

2016-10-10 Thread Jiri Kosina
On Mon, 3 Oct 2016, Heiner Kallweit wrote: > The hid-led driver works fine under 4.8.0, however with the next > kernel from today I get this: Queued in hid.git for 4.9-rc. Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-usb&q

Re: [PATCH] HID: usbkbd: return proper error code

2016-09-01 Thread Jiri Kosina
point of the change really. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] Validate num_values for HIDIOCGUSAGES, HIDIOCSUSAGES commands.

2016-06-24 Thread Jiri Kosina
ng to a heap overflow. Thanks for the fix. I've added Cc: stable, applied it to for-4.7/upstream-fixes branch, and will be including it in a pull request to Linus shortly. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body

RE: [PATCH] HID: fix noderef.cocci warnings

2016-06-20 Thread Jiri Kosina
; sizeof(u8)*U1_FEATURE_REPORT_LEN, > HID_FEATURE_REPORT, HID_REQ_SET_REPORT); I've already applied patch that fixes this (an one more callsite with the same issue); I CCed you on the patch earlier today. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list:

Re: [PATCH v2 1/2] hid: migrate USB LED driver from usb misc to hid

2016-06-17 Thread Jiri Kosina
help text as well, and applied. Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/2] usb: misc: remove outdated USB LED driver

2016-06-17 Thread Jiri Kosina
let's remove the old USB LED driver. > > Signed-off-by: Heiner Kallweit <hkallwe...@gmail.com> > Acked-by: Greg Kroah-Hartman <gre...@linuxfoundation.org> I am applying this to hid.git#for-4.8/hid-led so that it goes together with the addition of hid-led driver. Greg, if you have a

Re: [PATCH v2] hid: Fix boot delay for Creative SB Omni Surround 5.1 with quirk

2016-04-25 Thread Jiri Kosina
> No changes, just resubmission to ensure absence of undesired line breaks Line breaks are OK, but still your mailer converted tabs to space, which equally breaks the application process. I've fixed that up manually and applied, but please look into reconfiguring your MUA for any future subm

Re: [PATCH] hid: Fix boot delay for Creative SB Omni Surround 5.1 with quirk

2016-04-25 Thread Jiri Kosina
do. It'll save me from rather boring hand-editting of the patch, and we'll double-check whether your Thunderbird is now properly configured as a bonus :) Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the bo

Re: [Linux-v4.6-rc2] atkbd serio0: Unknown key pressed (translated set 2, code 0xa8 on isa0060/serio0).

2016-04-08 Thread Jiri Kosina
stream-fixes going to Linus then. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [Linux-v4.6-rc2] atkbd serio0: Unknown key pressed (translated set 2, code 0xa8 on isa0060/serio0).

2016-04-07 Thread Jiri Kosina
e of the recent patches in > for-4.6/upstream-fixes touches atkbd. I'd be very interested in which > one exactly causes this. Exactly, I don't see any possible relationship whatsoever. Sedat, for-4.6/upstream-fixes branch has only a couple of commits, so it should take just a very short while to b

Re: [Linux-v4.6-rc2] atkbd serio0: Unknown key pressed (translated set 2, code 0xa8 on isa0060/serio0).

2016-04-06 Thread Jiri Kosina
he issue go away. > > Unsure what is the cause. > > Hmm, this is quite curious, none of the recent patches in > for-4.6/upstream-fixes touches atkbd. I'd be very interested in which > one exactly causes this. It's indeed odd. Sedat, the kernel in question is compiled by gcc, rig

Re: [Linux-v4.6-rc2] atkbd serio0: Unknown key pressed (translated set 2, code 0xa8 on isa0060/serio0).

2016-04-06 Thread Jiri Kosina
away. Thanks for the useful report! > Unsure what is the cause. On the way, try to look this evening or > tommorrow into this. I don't seem to see the beginning of this thread anywhere. What hardware is this? -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] hid: thingm: change driver to use RGB LED core extension

2016-04-01 Thread Jiri Kosina
This patch clearly depends on some LED subsystem API that's not currently merged. Please let me know once this changes so that we could proceed with this patch. I'm putting it on hold for now. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linu

Re: [PATCH] USBHID: fix inconsistent reset/resume/reset-resume behavior

2016-03-24 Thread Jiri Kosina
nterrupt-IN endpoint is halted there's > no need to submit the input URB until the halt has been > cleared. In addition to this being an actual fix, it's a nice cleanup as well. Thanks a lot; queuing for 4.6. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send t

Re: "reset full-speed USB device number 6 using ehci-pci" with Dell Inspiron 15R 5537

2016-03-11 Thread Jiri Kosina
bandaids being added to the generic code, I haven't been able to come up with anything better. So the aproach is fine with me ... perhaps a short comment before testing HID_STARTED wouldn't hurt as well, as it has a potential of making code reader's head spin. Thanks, -- Jiri Kosina

Re: [PATCH] HID: usbhid: enable NO_INIT_REPORTS quirk for Semico USB Keykoard2

2016-03-10 Thread Jiri Kosina
re, and we'll probably apply the quirk to all devices from these guys that we identify to be of a keyboard type. Applied, thanks. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More

Re: [PATCH] usbhid: Fix lockdep unannotated irqs-off warning

2016-03-07 Thread Jiri Kosina
flags here at all. On Mon, 7 Mar 2016, Sedat Dilek wrote: > So, if Clang is producing wrong X86 code here, is it possible to turn > interrupts on/off manually? But, hmm that affects other places as well > in the Linux sources, so. This issue needs to be handled in the c

Re: [PATCH] usbhid: Fix lockdep unannotated irqs-off warning

2016-03-07 Thread Jiri Kosina
July/088780.html Seems like it has been reported already, but noone dared to fix it yet. This basically makes LLVM unusable for compiling the kernel. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.

Re: [PATCH] usbhid: Fix lockdep unannotated irqs-off warning

2016-03-02 Thread Jiri Kosina
; > might_sleep(); > > local_irq_disable(); > pool = get_work_pool(work); > if (!pool) { > local_irq_enable(); > return false; > } > > spin_lock(>lock); <--- XXX: spin_lock_irq() ??? No, this is fine. IR

Re: [PATCH v2] HID: quirks: Add no_init_reports for AKAI midi controller

2016-01-29 Thread Jiri Kosina
> Also, I did create and test a patch to use HID_QUIRK_IGNORE which I can > send if you feel strongly about it. Applied to for-4.5/upstream-fixes. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to

Re: [PATCH] HID: quirks: Add no_init_reports for AKAI midi controller

2016-01-27 Thread Jiri Kosina
B_DEVICE_ID_AKAI_MPKMINI2, > HID_QUIRK_NO_INIT_REPORTS }, If the (proclaimed) HID device is completely silent, wouldn't HID_QUIRK_IGNORE be more appropriate? -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] usbhid: Fix incorrect product id of old 4nes4snes

2016-01-25 Thread Jiri Kosina
On Sat, 23 Jan 2016, Raphael Assenat wrote: > The correct product ID for the old version of the raphnet 4nes4snes > device was 0x0a9d, not 0x0a8d. Applied, thanks. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the b

Re: [PATCH 0/2] Add a skeleton module to perform a basic initialization on certain USB devices

2016-01-25 Thread Jiri Kosina
So if we do this in userspace, I think usb_modeswitch is not a bad choice. Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2] hid: usbhid: hid-core: fix recursive deadlock

2016-01-21 Thread Jiri Kosina
is to -stable. As you guys seem to be the ones able to test it with your hardware, would you guys (Ioan-Adrian? Jason?) be willing to prepare the backport and submit it once it passes your testing? Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscr

Re: [PATCH 4/4] HID: usbhid: use to_usb_device

2015-12-28 Thread Jiri Kosina
of(hid_dev->dev.parent->parent, struct usb_device, dev) > + to_usb_device(hid_dev->dev.parent->parent) Applied to hid.git#for-4.5/upstream. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v5 2/2] USB: quirks: Apply ALWAYS_POLL to all ELAN devices

2015-12-01 Thread Jiri Kosina
.com> > Signed-off-by: Adrien Vergé <adrienve...@gmail.com> Reviewed-by: Benjamin Tissoires <benjamin.tissoi...@redhat.com> Reviewed-by: Jiri Kosina <jkos...@suse.cz> Greg, I guess it makes sense to take both 1/2 and 2/2 together as a whole. Would you mind adding the tag

Re: [PATCH v2] hid: usbhid: hid-core: fix recursive deadlock

2015-12-01 Thread Jiri Kosina
usbhid state, calling hid_input_report() > with the spinlock unlocked, allowing the device driver to grab the > lock first, finish and then grab the lock afterwards in hid_ctrl(). > > This patch implements the 2nd solution. > > Signed-off-by: Ioan-Adrian Ratiu <a...

Re: [PATCH] hid: usbhid: hid-core: fix recursive deadlock

2015-11-19 Thread Jiri Kosina
; I'll continue to research this more in depth, but progress is slow > because I don't have much time, I'm doing this in my spare time because > it's my girlfriend's tablet. Oh, now I understand the level of severity of this bug! :-) Thanks, -- Jiri Kosina SUSE Labs -- To unsubscr

Re: [PATCH] hid: usbhid: hid-core: fix recursive deadlock

2015-11-19 Thread Jiri Kosina
understand the problem rather than papering it over with more or less random fixes. First, have you tried to run your usecase on your system with lockdep enabled? Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] hid: usbhid: hid-core: fix recursive deadlock

2015-11-19 Thread Jiri Kosina
you have already done the full analysis that shows that usbhid->lock is indeed not needed, this absolutely needs to go into changelog as proper justification. Could you please reformulate the changelog in this respect and resubmit? Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from

Re: [PATCH] hid: usbhid: hid-core: fix recursive deadlock

2015-11-18 Thread Jiri Kosina
the lock > after the hid_input_report() call and the deadlock dissapears. I think the proper fix actually is to spin_lock_irqsave() in hid_ctrl(), isn't it? -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message

Re: [PATCH] HID: microsoft: Add support for Surface Pro 4 Type Cover

2015-10-30 Thread Jiri Kosina
into the kernel. > [1] https://github.com/neoreeps/surface-pro-3/blob/master/wily_surface.patch -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] HID: microsoft: Add support for Surface Pro 4 Type Cover

2015-10-30 Thread Jiri Kosina
On Tue, 27 Oct 2015, savoca wrote: > Adding support for device 0x07e8 (SP4 Type Cover) > > Signed-off-by: savoca <alex.de...@daqri.com> Thanks for the patch. The authorship and signoffs should same real names though. Could you please resend with that fixed? -- Jiri K

Re: [PATCH] HID: usbhid: Add a quirk for Xin-Mo Dual Arcade

2015-10-24 Thread Jiri Kosina
> + { USB_VENDOR_ID_XIN_MO, USB_DEVICE_ID_XIN_MO_DUAL_ARCADE, > HID_QUIRK_NOGET | HID_QUIRK_MULTI_INPUT }, > > { 0, 0 } > }; > -- > 2.5.0 > -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] HID: hiddev: fix returned errno code in hiddev_connect()

2015-10-05 Thread Jiri Kosina
at every 'return -1' occurence in the kernel and convert it to something else? That can keep you busy for quite some time: $ git grep 'return -1' | wc -l 9167 The only cleanup I'd imagine at least remotely possible in this case would be to convert the ->connect() callbac

Re: [PATCH] usbhid: Fix for the WiiU adapter from Mayflash

2015-10-04 Thread Jiri Kosina
com> I've fixed up the formatting and applied to hid.git#for-4.3/upstream-fixes (please note that this doesn't guarantee that this patch will not go to 4.3 still, because it alone is not going to be reason for pull request, but might eventually piggy-back on something that'll be needed for 4

Re: [PATCH] HID: hiddev: fix returned errno code in hiddev_connect()

2015-09-30 Thread Jiri Kosina
v->clamed flags accordingly. Could you please be more specific about the -EPERM mapping you are talking about? Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More m

Re: Problems with printk logs and my driver

2015-09-25 Thread Jiri Kosina
e getting confused again and again nevertheless. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: Problems with printk logs and my driver

2015-09-23 Thread Jiri Kosina
t accurate would of course be usbkbd-boot, but that might be equally confusing. The drawback I can see in renaming the driver is various embedded folks having he name hardcoded in their scripts. Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe l

Re: [PATCH RESEND] usbhid: Fix the check for HID_RESET_PENDING in hid_io_error

2015-08-18 Thread Jiri Kosina
. Signed-off-by: Don Zickus dzic...@redhat.com --- I mistyped the usb mailing list address, so this patch never made it there. Resending with the correct address. Sorry for the spam. Hmm, good catch. I've added Cc: stable and applied to for-4.3/upstream. Thanks, -- Jiri Kosina SUSE Labs

Re: Cannot use the logitech k520 (046d:c52b) to unlock my luks disk at boot time

2015-07-13 Thread Jiri Kosina
. Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: Cannot use the logitech k520 (046d:c52b) to unlock my luks disk at boot time

2015-07-09 Thread Jiri Kosina
Initramfs declares that : most - Add most filesystem and all harddrive drivers and it is a hardware driver, but not detected as such by initramfs harddrive and hardware is not the same though. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-usb

Re: [PATCH] usbhid: no flushing if device is already polled

2015-07-08 Thread Jiri Kosina
/upstream, thanks. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: Cannot use the logitech k520 (046d:c52b) to unlock my luks disk at boot time

2015-07-08 Thread Jiri Kosina
kernel a corded hid keyboard does work but this specific keyboard does not work anymore. The keybaord works fine after boot Do you have the driver (hid-logitech-hidpp) present in the initrd? It needs to be loaded at the time you are trying to use the keyboard. -- Jiri Kosina SUSE Labs

Re: Cannot use the logitech k520 (046d:c52b) to unlock my luks disk at boot time

2015-07-08 Thread Jiri Kosina
On Wed, 8 Jul 2015, Jiri Kosina wrote: Bug as submitted on: https://bugzilla.kernel.org/show_bug.cgi?id=100631 Mailing it to this mailing list on advice of greg k-h -- Cannot use the logitech

Re: [PATCH][RFC] usbhid: enable autosuspend for internal devices

2015-06-29 Thread Jiri Kosina
kernel can do about. I am not saying it doesn't bring the LEDs up to a proper state again once auto-resumed. But I hate the LEDs going off a few seconds after I stop typing (i.e. once the keyboard gets auto-suspended). -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line

Re: [PATCH][RFC] usbhid: enable autosuspend for internal devices

2015-06-29 Thread Jiri Kosina
-suspended). That is the point. Unless you give the option to override, they shouldn't autosuspend. Ah, you're right, I completely forgot about the logic we've put into hidinput_count_leds() quite some time ago. Sorry for the noise, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send

Re: [PATCH][RFC] usbhid: enable autosuspend for internal devices

2015-06-27 Thread Jiri Kosina
this any more, I am afraid we'll have to move the default into the kernel. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH TRIVIAL] drivers/usb/gadget/composite.c: i18n is not an acronym

2015-06-26 Thread Jiri Kosina
patch hasn't been lost, it's still in my trivial-todo inbox, and will eventually be processed. Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [PATCH 1/1] usb: Remove Vernier devices from lsusb and hid_ignore_list

2015-06-01 Thread Jiri Kosina
/labq2/ and the LoggerPro for Linux software shown at http://www.vernier.com/downloads/logger-pro-linux/. Signed-off-by: Dennis O'Brien dennis.obr...@eqware.net Acked-by: Greg Kroah-Hartman gre...@linuxfoundation.org Applied to hid.git#for-4.2/upstream. Thanks, -- Jiri Kosina SUSE Labs

Re: [hid:for-next 63/64] drivers/hid/hid-logitech-hidpp.c:1504:46: error: 'HIDPP_QUIRK_MULTI_INPUT' undeclared here (not in a function)

2015-06-01 Thread Jiri Kosina
, HID_GROUP_LOGITECH_DJ_DEVICE, :: The code at line 1504 was first introduced by commit :: 3a61e97563d78a2ca10752902449570d8433ce76 HID: logitech-hidpp: support combo keyboard touchpad TK820 :: TO: Benjamin Tissoires benjamin.tissoi...@redhat.com :: CC: Jiri Kosina jkos...@suse.cz Thanks

Re: [PATCH 1/1] usb: Remove Vernier devices from lsusb and hid_ignore_list

2015-05-29 Thread Jiri Kosina
On Thu, 28 May 2015, Greg KH wrote: On Thu, May 28, 2015 at 04:58:54PM +0200, Jiri Kosina wrote: On Thu, 21 May 2015, Dennis O'Brien wrote: From: Dennis O'Brien dennis.obr...@eqware.net Removes Vernier Software Technology devices from the ldusb driver and the hid_ignore_list

Re: [PATCH 1/1] usb: Remove Vernier devices from lsusb and hid_ignore_list

2015-05-28 Thread Jiri Kosina
it himself through his tree). Greg ... ? Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] HID: usbhid: add Chicony/Pixart usb optical mouse that needs QUIRK_ALWAYS_POLL

2015-05-25 Thread Jiri Kosina
(with Benjamin's nit taken into account). Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] hid: Add secondary vendor id for the marco, USB_DEVICE_ID_MS_TYPE_COVER_3_V2

2015-05-20 Thread Jiri Kosina
, HID_QUIRK_NO_INIT_REPORTS }, { USB_VENDOR_ID_MSI, USB_DEVICE_ID_MSI_GT683R_LED_PANEL, HID_QUIRK_NO_INIT_REPORTS }, { USB_VENDOR_ID_NEXIO, USB_DEVICE_ID_NEXIO_MULTITOUCH_PTI0750, HID_QUIRK_NO_INIT_REPORTS }, -- 2.1.4 -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line

Re: [PATCH,v2] usbhid: Add a quirk for raphnet multi-gamepad adapters

2015-04-27 Thread Jiri Kosina
device. With this patch each controller gets its own /dev/input/jsX device, which is more natural and less confusing than having all inputs going to the same place. Applied, thanks. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body

Re: [PATCH 1/2] usbhid: more mice with ALWAYS_POLL

2015-04-02 Thread Jiri Kosina
a frequently re-appearing topic, we'll have to come up with more generic aproach. Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Re: [PATCH 1/2] usbhid: more mice with ALWAYS_POLL

2015-03-30 Thread Jiri Kosina
, USB_DEVICE_ID_PRODIGE_CORDLESS, HID_QUIRK_NOGET }, { USB_VENDOR_ID_QUANTA, USB_DEVICE_ID_QUANTA_OPTICAL_TOUCH_3001, HID_QUIRK_NOGET }, { USB_VENDOR_ID_QUANTA, USB_DEVICE_ID_QUANTA_OPTICAL_TOUCH_3008, HID_QUIRK_NOGET }, -- 2.1.4 -- Jiri Kosina SUSE Labs -- To unsubscribe from

Re: [PATCH] hid: add quirk for PIXART OEM mouse used by HP

2015-03-25 Thread Jiri Kosina
, HID_QUIRK_ALWAYS_POLL }, { USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_LOGITECH_C077, HID_QUIRK_ALWAYS_POLL }, { USB_VENDOR_ID_MGE, USB_DEVICE_ID_MGE_UPS, HID_QUIRK_NOGET }, { USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_TYPE_COVER_3, HID_QUIRK_NO_INIT_REPORTS }, -- Jiri Kosina SUSE Labs

  1   2   3   >