On 03/30/2018, 03:17 PM, Jiri Slaby wrote:
> Hi,
>
> I have seen r8152 from my docking station to kill my box several times
> in the last few days. The notebook is new, so I don't know if this is a
> regression.
Forgot to add, I am seeing this in dmesg:
[ 13.353239] r8152 4-1
Hi,
I have seen r8152 from my docking station to kill my box several times
in the last few days. The notebook is new, so I don't know if this is a
regression.
I have the NIC connected all the time. And when I return to the notebook
after a while, the networking is dead. Looking at the stack
which was
intended to do in d705ff3818 but omitted.
Signed-off-by: Jiri Slaby <jsl...@suse.cz>
Fixes: d705ff3818 (tty: vt, cleanup and document con_scroll)
Cc: Thomas Winischhofer <tho...@winischhofer.net>
Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org>
Cc: linux-usb@vger.kerne
which was
intended to do in d705ff3818 but omitted.
Signed-off-by: Jiri Slaby <jsl...@suse.cz>
Fixes: d705ff3818 (tty: vt, cleanup and document con_scroll)
Cc: Thomas Winischhofer <tho...@winischhofer.net>
Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org>
Cc: linux-usb@vger
the "!lines" then-branch
immediatelly. This allows flushing the else-branch 1 level to the
left, obviously.
Few more new lines and comments were added too.
And do not forget to export the helper function given sisusb can be
built as module.
Signed-off-by: Jiri Slaby <jsl...@suse.c
Cc: proper lists.
ep->desc.bInterval seems to be 0 here.
On 08/21/2016, 12:42 PM, Vittorio Zecca wrote:
> I am not sure this is the right place so please bear with me...
> From Vittorio Zecca
>
> After compiling kernel 4.7.2 with ubsan I got the following messages
> at boot time:
>
>
bytes_written parameter of sisusb_copy_memory and sisusb_read_memory
is an out parameter, but its value is never used. So remove it and
pass a dummy variable down to sisusb_read_mem_bulk.
Signed-off-by: Jiri Slaby <jsl...@suse.cz>
Cc: Thomas Winischhofer <tho...@winischhofer.net>
C
* allow NULL consw->con_scrolldelta (some consoles define an empty
hook)
* => remove empty hooks now
* return value of consw->con_scrolldelta is never checked => make the
function void
* document consw->con_scrolldelta a bit
Signed-off-by: Jiri Slaby <jsl...@suse.cz>
Cc
* allow NULL consw->con_set_palette (some consoles define an empty
hook)
* => remove empty hooks now
* return value of consw->con_set_palette is never checked => make the
function void
* document consw->con_set_palette a bit
Signed-off-by: Jiri Slaby <jsl...@suse.cz>
Cc
It is never called since commit 81732c3b2fede (tty vt: Fix line
garbage in virtual console on command line edition) in 3.7. So remove
all the callbacks.
Signed-off-by: Jiri Slaby <jsl...@suse.cz>
Cc: Thomas Winischhofer <tho...@winischhofer.net>
Cc: linux-usb@vger.kernel.org
Cc: Jea
Namely convert:
* IS_FG -> con_is_fg
* DO_UPDATE -> con_should_update
* CON_IS_VISIBLE -> con_is_visible
DO_UPDATE was a weird name for a yes/no answer, so the new name is
con_should_update.
Signed-off-by: Jiri Slaby <jsl...@suse.cz>
Cc: Thomas Winischhofer <tho...@winischh
GFP_NOWARN. So do so.
The size could be also clipped by something like:
if (size >= (1 << (MAX_ORDER + PAGE_SHIFT - 1)))
return -ENOMEM;
But I think the overall limit of 16M (by usbfs_increase_memory_usage)
is enough, so that we only silence the warning here.
Signed
after
the lock.
Signed-off-by: Jiri Slaby <jsl...@suse.cz>
Cc: Pete Zaitcev <zait...@redhat.com>
Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org>
Fixes: 7f477358e2 ("usblp: Implement the ENOSPC convention")
---
drivers/usb/class/usblp.c | 2 +-
1 file changed, 1 inser
On 01/30/2015, 10:54 PM, Tim Chen wrote:
On Sat, 2015-01-31 at 00:03 +0300, Sergei Shtylyov wrote:
On 01/30/2015 10:54 PM, Tim Chen wrote:
return NULL;
}
+ /* round up to full page size */
+ size = (((size-1) PAGE_SHIFT) + 1) * PAGE_SIZE;
This is quite
On 09/07/2014, 10:27 PM, Vincent Stehlé wrote:
Commit 6a04d05acfb51355 (USB: OHCI: fix bugs in debug routines) has removed
the unused `verbose' argument of the debug function ohci_dump(); adapt
ohci-spear accordingly.
This fixes the following compilation error:
On 07/07/2014 05:42 PM, grantksupp...@operamail.com wrote:
Hi,
Can this USB3 fix be added to Kernel's stable branch so our distro(s)
can/will pick it up for packaging ?
What this USB3 fix? Do you have the git commit id of the patch in
Linus's tree? And what kernel version(s) do you want
On 06/25/2013 01:42 AM, Greg Kroah-Hartman wrote:
On Wed, Jun 19, 2013 at 08:50:08AM +0200, Jiri Slaby wrote:
On 06/18/2013 06:04 PM, Greg Kroah-Hartman wrote:
So currently I have what is attached... Comments?
Looks good to me, want me to queue it up through my char/misc driver
tree for 3.11
On 06/18/2013 06:04 PM, Greg Kroah-Hartman wrote:
So currently I have what is attached... Comments?
Looks good to me, want me to queue it up through my char/misc driver
tree for 3.11?
If there are no objections... Whoever picks that up, I would be happy 8-).
--
js
suse labs
--
To
On 06/19/2013 09:10 AM, Tomi Valkeinen wrote:
On 17/06/13 23:05, Jiri Slaby wrote:
The last point I inclined to the Greg's argument to remove the
EXPERT dependency.
So currently I have what is attached... Comments?
The patch looks a bit odd with the USB_CHIPIDEA_IMX parts. You're
On 06/18/2013 10:18 AM, Felipe Balbi wrote:
Hi,
On Tue, Jun 18, 2013 at 06:51:32AM +0200, Michal Marek wrote:
Dne 17.6.2013 22:05, Jiri Slaby napsal(a):
On 05/23/2013 05:09 AM, Jeff Mahoney wrote:
On 5/22/13 10:23 PM, Greg Kroah-Hartman wrote:
On Wed, May 22, 2013 at 11:18:46AM +0200, Jiri
On 06/18/2013 10:51 AM, Felipe Balbi wrote:
right, but my argument is that I rather not have either. Depend on
PCI if you us PCI, depend on EXTCON if you use extcon, but no
driver should have an ARCH dependency. Specially since it lets
people include mach/* and asm/* headers because it doesn't
On 05/23/2013 05:09 AM, Jeff Mahoney wrote:
On 5/22/13 10:23 PM, Greg Kroah-Hartman wrote:
On Wed, May 22, 2013 at 11:18:46AM +0200, Jiri Slaby wrote:
Some drivers can be built on more platforms than they run on. This
causes users and distributors packaging burden when they have to
manually
On 05/16/2013 11:36 AM, Alexander Shishkin wrote:
The benefit from compiling it on non-arm (or non-imx) architectures for
me is compilation testing. We don't have a whole lot of architectures
with CONFIG_OF so it's nice to give it a stretch.
Yes, the newly added COMPILE_TEST config option will
On 05/08/2013 11:07 AM, Alexander Shishkin wrote:
Jiri Slaby jsl...@suse.cz writes:
From: Jeff Mahoney je...@suse.com
The chipidea driver currently has needless ifneq rules in the makefile
for things that should be config options.
Please elaborate on the should be part.
This can
tty_port_tty_get might return a tty which is NULL. But it is
dereferenced unconditionally in edge_send. Stop dereferencing that by
sending usb_serial_port pointer around.
Signed-off-by: Jiri Slaby jsl...@suse.cz
Cc: Johan Hovold jhov...@gmail.com
Cc: linux-usb@vger.kernel.org
---
drivers/usb
On 03/05/2013 11:32 PM, Peter Hurley wrote:
So I'm thinking about
something like this:
if (port-tty)
set_bit(TTY_IO_ERROR, port-tty-flags);
tty = port-tty; === take a snapshot
spin_unlock_irqrestore(port-lock, flags);
tty_port_shutdown(port, tty); === use the snapshot
On 02/28/2013 09:57 PM, Peter Hurley wrote:
Hi Jiri,
Just wanted to make sure you saw this series.
Hi, thanks for letting me know. Johan, care to CC Alan Cox and me (or at
least LKML) when you're changing the TTY core next time?
I have a couple of questions for 2/4:
Move HUPCL handling to
On 03/05/2013 06:06 PM, Peter Hurley wrote:
@@ -225,15 +232,13 @@ void tty_port_hangup(struct tty_port *port)
spin_lock_irqsave(port-lock, flags);
port-count = 0;
port-flags = ~ASYNC_NORMAL_ACTIVE;
- if (port-tty) {
+ if (port-tty)
On 03/05/2013 11:02 PM, Peter Hurley wrote:
On Tue, 2013-03-05 at 22:56 +0100, Jiri Slaby wrote:
On 03/05/2013 06:06 PM, Peter Hurley wrote:
@@ -225,15 +232,13 @@ void tty_port_hangup(struct tty_port *port)
spin_lock_irqsave(port-lock, flags);
port-count = 0;
port
On 02/11/2013 07:40 AM, Yinghai Lu wrote:
Can you try attached debug patch?
FWIW this fixes it for me. No more 'derived' or 'nobody' in dmesg.
thanks,
--
js
suse labs
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
Hello,
I've just plugged+unplugged+plugged my USB audio card and the audio
subsystem got stuck:
INFO: task khubd:440 blocked for more than 120 seconds.
echo 0 /proc/sys/kernel/hung_task_timeout_secs disables this message.
khubd D 8801cbc92400 0 440 2 0x
On 11/13/2012 09:28 AM, Takashi Iwai wrote:
At Tue, 13 Nov 2012 09:26:17 +0100,
Jiri Slaby wrote:
Hello,
I've just plugged+unplugged+plugged my USB audio card and the audio
subsystem got stuck:
Which kernel? If it's older than 3.7-rc5, could you try 3.7-rc5?
Oh, forgot to mention
On 11/13/2012 09:45 AM, Takashi Iwai wrote:
At Tue, 13 Nov 2012 09:30:10 +0100,
Jiri Slaby wrote:
On 11/13/2012 09:28 AM, Takashi Iwai wrote:
At Tue, 13 Nov 2012 09:26:17 +0100,
Jiri Slaby wrote:
Hello,
I've just plugged+unplugged+plugged my USB audio card and the audio
subsystem got
On 09/19/2012 04:36 AM, Kevin Daughtridge wrote:
--- a/drivers/hid/hid-core.c
+++ b/drivers/hid/hid-core.c
@@ -775,12 +775,14 @@ int hid_open_report(struct hid_device *d
return -ENODEV;
size = device-dev_rsize;
+start = kmemdup(start, size, GFP_KERNEL);
+if (start
34 matches
Mail list logo
