[PATCH 15/21] USB: serial: omninet: simplify endpoint check

Simplify the endpoint sanity check by letting core verify that the required endpoints are present. Note that the driver uses the second bulk-out endpoint for writing. Signed-off-by: Johan Hovold <jo...@kernel.org> --- drivers/usb/serial/omninet.c | 14 +- 1 file changed, 1 ins

[PATCH 11/21] USB: serial: iuu_phoenix: simplify endpoint check

Simplify the endpoint sanity check by letting core verify that the required endpoints are present. Signed-off-by: Johan Hovold <jo...@kernel.org> --- drivers/usb/serial/iuu_phoenix.c | 13 ++--- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/drivers/usb/

[PATCH 08/21] USB: serial: cyberjack: simplify endpoint check

Simplify the endpoint sanity check by letting core verify that the required endpoints are present. Signed-off-by: Johan Hovold <jo...@kernel.org> --- drivers/usb/serial/cyberjack.c | 11 +-- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/drivers/usb/serial/cyberja

[PATCH 20/21] USB: serial: symbolserial: simplify endpoint check

Simplify the endpoint sanity check by letting core verify that the required endpoints are present. Signed-off-by: Johan Hovold <jo...@kernel.org> --- drivers/usb/serial/symbolserial.c | 12 +--- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/usb/

[PATCH 17/21] USB: serial: oti6858: simplify endpoint check

Simplify the endpoint sanity check by letting core verify that the required endpoints are present. Signed-off-by: Johan Hovold <jo...@kernel.org> --- drivers/usb/serial/oti6858.c | 19 +++ 1 file changed, 3 insertions(+), 16 deletions(-) diff --git a/drivers/usb/serial/oti

[PATCH 12/21] USB: serial: keyspan_pda: simplify endpoint check

Simplify the endpoint sanity check by letting core verify that the required endpoints are present. Signed-off-by: Johan Hovold <jo...@kernel.org> --- drivers/usb/serial/keyspan_pda.c | 16 ++-- 1 file changed, 2 insertions(+), 14 deletions(-) diff --git a/drivers/usb/

[PATCH] USB: serial: digi_acceleport: fix OOB-event processing

and is marked for stable, but should not be backported without this fix. Reported-by: Ben Hutchings <b...@decadent.org.uk> Fixes: 2d380889215f ("USB: serial: digi_acceleport: fix OOB data sanity check") Cc: stable <sta...@vger.kernel.org> # v2.6.30 Signed-off-by: Johan Ho

[GIT PULL] USB-serial updates for v4.11-rc1 part 2

upd78f0730 driver and three clean-up patches that are mostly moving some code around. All have been in linux-next with no reported issues. Signed-off-by: Johan Hovold <jo...@kernel.org> ---- Johan Hovold (3): USB: serial: upd78f0730

Re: [PATCH 2/2] USB: serial: keyspan: drop header file

On Wed, Feb 15, 2017 at 06:39:52AM -0800, Greg Kroah-Hartman wrote: > On Wed, Feb 15, 2017 at 11:09:51AM +0100, Johan Hovold wrote: > > Move all declarations and definitions in keyspan.h to keyspan.c, which > > is the only place were they are used. > > > > This sp

Re: Periodic reconnects of USB mouse on Dell PowerEdge R730

On Wed, Feb 15, 2017 at 03:31:28PM +0100, Oliver Neukum wrote: > Am Mittwoch, den 08.02.2017, 17:54 +0100 schrieb Johan Hovold: > > > Also, I am unable to reproduce this problem with the *same* mice on > > a  > > > laptop with a USB3 – it’s blue – port. > > &

[PATCH 1/2] USB: serial: io_edgeport: drop io-tables header file

Move the driver device-id tables and usb-serial driver definitions to the source file where they are expected to be found. Signed-off-by: Johan Hovold <jo...@kernel.org> --- drivers/usb/serial/io_edgeport.c | 217 +++- drivers/usb/serial/io_tables.h

[PATCH 2/2] USB: serial: keyspan: drop header file

and minor white-space issues (spaces instead of tabs and superfluous white space). Note that the information in the comment header of the removed header file is also present in the source file. Signed-off-by: Johan Hovold <jo...@kernel.org> --- drivers/usb/serial/keyspan.c

Re: [PATCH] USB: serial: upd78f0730: sort device ids

On Mon, Feb 13, 2017 at 05:44:17PM +0300, Maksim Salau wrote: > > Sort the device ids by vendor id. > > > > Signed-off-by: Johan Hovold <jo...@kernel.org> > > Thanks for taking care of that. I didn't bothered about order > before your comment about ftd_sio dr

[PATCH] USB: serial: upd78f0730: sort device ids

Sort the device ids by vendor id. Signed-off-by: Johan Hovold <jo...@kernel.org> --- drivers/usb/serial/upd78f0730.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/serial/upd78f0730.c b/drivers/usb/serial/upd78f0730.c index f1e6c07ffc81..a028dd2310c9

Re: [PATCH v2] USB: serial: upd78f0730: Add ID for EVAL-ADXL362Z

On Mon, Feb 13, 2017 at 03:14:34PM +0300, Maksim Salau wrote: > The adaptor on Analog Devices EVAL-ADXL362Z development board is used > to flash and debug firmware of on-board Renesas RL78/G13 MCU. > Also added support of the 153600 baud rate, since the stock firmware > uses it. > >

Re: [PATCH] USB: serial: upd78f0730: Add ID for EVAL-ADXL362Z

On Fri, Feb 10, 2017 at 02:53:42PM +0300, Maksim Salau wrote: > The adaptor on Analog Devices EVAL-ADXL362Z development board is used > to flash and debug firmware of on-board Renesas RL78/G13 MCU. > > Signed-off-by: Maksim Salau > --- > > I have no access to such board

Re: [PATCH] USB: serial: ftdi_sio: add device ID for Microsemi/Arrow SF2PLUS Dev Kit

the USB VID is registered to Actel according to Linux USB > VID database, but that was acquired by Microsemi. > > Signed-off-by: Marek Vasut <ma...@denx.de> > Cc: stable <sta...@vger.kernel.org> > Cc: Johan Hovold <jo...@kernel.org> > --- > drivers/usb/serial

Re: Periodic reconnects of USB mouse on Dell PowerEdge R730

On Fri, Feb 10, 2017 at 10:41:45AM +0100, Johan Hovold wrote: > On Thu, Feb 09, 2017 at 05:30:11PM +0100, Paul Menzel wrote: > > > Feb 09 17:24:59 centos7 kernel: usb 3-8: USB disconnect, device number 59 > > Feb 09 17:25:01 centos7 kernel: usb 3-8: new low-speed USB device nu

Re: Periodic reconnects of USB mouse on Dell PowerEdge R730

On Thu, Feb 09, 2017 at 05:30:11PM +0100, Paul Menzel wrote: > Feb 09 17:24:59 centos7 kernel: usb 3-8: USB disconnect, device number 59 > Feb 09 17:25:01 centos7 kernel: usb 3-8: new low-speed USB device number > 60 using xhci_hcd > Feb 09 17:25:01 centos7 kernel: usb 3-8: New USB device found,

[GIT PULL] USB-serial updates for v4.11-rc1

for various minor issues, as well as a couple of new device IDs that came in late. All but the final patch have been in linux-next with no reported issues. Signed-off-by: Johan Hovold <jo...@kernel.org> ---- Johan Hovold (44):

[PATCH] USB: serial: mos7840: fix another NULL-deref at open

river") Cc: stable <sta...@vger.kernel.org> # v2.6.19: 5c75633ef751 Signed-off-by: Johan Hovold <jo...@kernel.org> --- drivers/usb/serial/mos7840.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/usb/serial/mos7840.c b/drivers/usb/serial/mos784

Re: [PATCH 0/2] USB: serial: console: fix tty-lock regression

On Wed, Feb 08, 2017 at 09:16:02PM +0100, Greg Kroah-Hartman wrote: > On Wed, Feb 08, 2017 at 06:51:31PM +0100, Johan Hovold wrote: > > Testing a simple clean-up patch resulted in a lockdep splat, which > > turned out to be due to an uninitialised spin lock after a tty chang

Re: [PATCH 4/4] USB: serial: metro-usb: drop redundant URB reinitialisation

On Wed, Feb 08, 2017 at 07:05:50PM +0100, Greg Kroah-Hartman wrote: > On Wed, Feb 08, 2017 at 01:49:19PM +0100, Johan Hovold wrote: > > No need to reinitialise the interrupt-in URB with values that have not > > changed before (some) resubmissions. > > > > Thi

[PATCH 0/2] USB: serial: console: fix tty-lock regression

Testing a simple clean-up patch resulted in a lockdep splat, which turned out to be due to an uninitialised spin lock after a tty change that went into 4.6. Makes you wonder how many people actually use this code... Johan Johan Hovold (2): USB: serial: console: fix uninitialised spinlock

[PATCH 1/2] USB: serial: console: fix uninitialised spinlock

e sure to initialise the new lock also for the fake tty to address this regression. Yes, this code is a mess, but cleaning it up is left for another day. Fixes: 4a510969374a ("tty: Make tty_files_lock per-tty") Cc: stable <sta...@vger.kernel.org> # 4.6 Signed-off-by: Johan Hovold

[PATCH 2/2] USB: serial: console: clean up sanity checks

pointers are stored in an array that is a member of the serial struct so the address of the first member of the array (which the array name decays to) is never NULL either. Signed-off-by: Johan Hovold <jo...@kernel.org> --- drivers/usb/serial/console.c | 3 +-- 1 file changed, 1 insertion

Re: Periodic reconnects of USB mouse on Dell PowerEdge R730

On Wed, Feb 08, 2017 at 05:41:33PM +0100, Paul Menzel wrote: > On 02/08/17 16:50, Johan Hovold wrote: > > On Wed, Feb 08, 2017 at 04:15:02PM +0100, Paul Menzel wrote: > >> On 02/08/17 14:02, Greg KH wrote: > >>> On Wed, Feb 08, 2017 at 12:16:44PM +0100, Paul Menzel wr

Re: Periodic reconnects of USB mouse on Dell PowerEdge R730

On Wed, Feb 08, 2017 at 04:15:02PM +0100, Paul Menzel wrote: > On 02/08/17 14:02, Greg KH wrote: > > On Wed, Feb 08, 2017 at 12:16:44PM +0100, Paul Menzel wrote: > >> On the server Dell PowerEdge R730 with firmware 2.3.4, and Linux 4.9.2, the > >> connected USB mouse disconnects and connects again

[PATCH 2/4] USB: serial: metro-usb: drop redundant URB unlink

Drop redundant URB unlink as there's no need to unlink an URB which is about to be killed synchronously. Signed-off-by: Johan Hovold <jo...@kernel.org> --- drivers/usb/serial/metro-usb.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/serial/metro-usb.c b/drivers/usb/serial

[PATCH 1/4] USB: serial: metro-usb: drop unused interrupt-out callback

Drop the unused interrupt-out callback. Signed-off-by: Johan Hovold <jo...@kernel.org> --- drivers/usb/serial/metro-usb.c | 9 - 1 file changed, 9 deletions(-) diff --git a/drivers/usb/serial/metro-usb.c b/drivers/usb/serial/metro-usb.c index 39e683096e94..4f7cd30b5424

[PATCH 3/4] USB: serial: metro-usb: drop function-tracing debugging

Drop some unnecessary debug printks. Signed-off-by: Johan Hovold <jo...@kernel.org> --- drivers/usb/serial/metro-usb.c | 12 1 file changed, 12 deletions(-) diff --git a/drivers/usb/serial/metro-usb.c b/drivers/usb/serial/metro-usb.c index b0c7746438df..f220a470197a

[PATCH 4/4] USB: serial: metro-usb: drop redundant URB reinitialisation

No need to reinitialise the interrupt-in URB with values that have not changed before (some) resubmissions. This also allows the interrupt-in callback to have a single path for URB resubmission. Signed-off-by: Johan Hovold <jo...@kernel.org> --- drivers/usb/serial/metro-usb.

[PATCH 0/4] USB: serial: metro-usb: various clean ups

These patches clean up the metro-usb driver somewhat by removing redundant code and some unnecessary dev_dbgs. Johan Johan Hovold (4): USB: serial: metro-usb: drop unused interrupt-out callback USB: serial: metro-usb: drop redundant URB unlink USB: serial: metro-usb: drop function-tracing

Re: [PATCH] USB: serial: sierra: fix bogus alternate-setting assumption

On Mon, Feb 06, 2017 at 05:33:29PM +0100, Greg Kroah-Hartman wrote: > On Mon, Feb 06, 2017 at 04:28:14PM +0100, Johan Hovold wrote: > > Interface numbers do not change when enabling alternate settings as > > comment and code in this driver suggested. > > > > R

[PATCH] USB: serial: sierra: fix bogus alternate-setting assumption

river interface blacklisting") Signed-off-by: Johan Hovold <jo...@kernel.org> --- drivers/usb/serial/sierra.c | 28 +--- 1 file changed, 5 insertions(+), 23 deletions(-) diff --git a/drivers/usb/serial/sierra.c b/drivers/usb/serial/sierra.c index e1994e264cc0..465

Re: [PATCH net 1/4] pegasus: Use heap buffers for all register access

On Mon, Feb 06, 2017 at 02:32:23PM +0100, Johan Hovold wrote: > On Mon, Feb 06, 2017 at 02:21:24PM +0100, Johan Hovold wrote: > > On Mon, Feb 06, 2017 at 02:51:09PM +0200, Petko Manolov wrote: > > > On 17-02-06 09:28:22, Greg KH wrote: > > > > On Mon, Feb 06, 2

Re: [PATCH net 1/4] pegasus: Use heap buffers for all register access

On Mon, Feb 06, 2017 at 02:21:24PM +0100, Johan Hovold wrote: > On Mon, Feb 06, 2017 at 02:51:09PM +0200, Petko Manolov wrote: > > On 17-02-06 09:28:22, Greg KH wrote: > > > On Mon, Feb 06, 2017 at 10:14:44AM +0200, Petko Manolov wrote: > > > > > Random thought:

Re: [PATCH net 1/4] pegasus: Use heap buffers for all register access

On Mon, Feb 06, 2017 at 02:51:09PM +0200, Petko Manolov wrote: > On 17-02-06 09:28:22, Greg KH wrote: > > On Mon, Feb 06, 2017 at 10:14:44AM +0200, Petko Manolov wrote: > > > Random thought: isn't it better to add the alloc/free code in > > > usb_control_msg() and avoid code duplication all over

Re: [PATCH v2] USB: cp210x: add new IDs for GE Bx50v3 boards

On Sat, Feb 04, 2017 at 04:00:24AM +0800, Ken Lin wrote: > Add new USB IDs for cp2104/5 devices on Bx50v3 boards due to the design change > > Signed-off-by: Ken Lin > --- > Change in v2: > Fix the author (From) address doesn't match the SoB issue mentioned in the >

[GIT PULL] USB-serial fixes for v4.10-rc7

-by: Johan Hovold <jo...@kernel.org> Marcel J.E. Mol (1): USB: serial: pl2303: add ATEN device ID drivers/usb/serial/pl2303.c | 1 + drivers/usb/serial/pl2303.h | 1 + 2 files changed, 2 insertions(+) -- To unsubscrib

Re: [PATCH] USB: cp210x: add new IDs for GE Bx50v3 boards

On Fri, Feb 03, 2017 at 09:11:15AM +0800, Ken Lin wrote: > Add new USB IDs for cp2104/5 devices on Bx50v3 boards due to the design change > > Signed-off-by: Ken Lin Thanks for the patch. Looks good except that your author (From) address doesn't match your SoB. Please fix

Re: ftdi_sio: overrun errors

On Wed, Jun 29, 2016 at 11:59:06PM +0200, Michael Walle wrote: > Am 2016-05-27 20:02, schrieb Johan Hovold: > > On Fri, May 13, 2016 at 12:17:24PM +0200, mich...@walle.cc wrote: > >> Hi, > >> > >> if the internal buffer is full, a read() returns a steady

[PATCH] USB: serial: ftdi_sio: fix line-status over-reporting

le <sta...@vger.kernel.org> # v2.6.35 Signed-off-by: Johan Hovold <jo...@kernel.org> --- drivers/usb/serial/ftdi_sio.c | 23 ++- 1 file changed, 14 insertions(+), 9 deletions(-) diff --git a/drivers/usb/serial/ftdi_sio.c b/drivers/usb/serial/ftdi_sio.c index e82dbb3d0

Re: [PATCH 2/3] USB: serial: digi_acceleport: fix incomplete rx sanity check

On Tue, Jan 31, 2017 at 05:55:17PM +0100, Greg Kroah-Hartman wrote: > On Tue, Jan 31, 2017 at 05:46:02PM +0100, Johan Hovold wrote: > > On Tue, Jan 31, 2017 at 05:41:52PM +0100, Greg Kroah-Hartman wrote: > > > On Tue, Jan 31, 2017 at 05:17:28PM +0100, Johan Hovold wrote:

Re: [PATCH 2/3] USB: serial: digi_acceleport: fix incomplete rx sanity check

On Tue, Jan 31, 2017 at 05:41:52PM +0100, Greg Kroah-Hartman wrote: > On Tue, Jan 31, 2017 at 05:17:28PM +0100, Johan Hovold wrote: > > Make sure the received data has the required headers before parsing it. > > > > Also drop the redundant urb-status check, which has

Re: [PATCH 1/3] USB: serial: digi_acceleport: fix OOB data sanity check

On Tue, Jan 31, 2017 at 05:38:58PM +0100, Greg Kroah-Hartman wrote: > On Tue, Jan 31, 2017 at 05:17:27PM +0100, Johan Hovold wrote: > > Make sure to check for short transfers to avoid underflow in a loop > > condition when parsing the receive buffer. > > > > A

Re: [PATCH] Subject: usb/serial/pl2303 add ATEN device ID

On Mon, Jan 30, 2017 at 07:26:40PM +0100, Marcel J.E. Mol wrote: > > Seems that ATEN serial-to-usb devices using pl2303 exist with > different device ids. This patch adds a missing device ID so it > is recognised by the driver. > > Signed-off-by: Marcel J.E. Mol > --- Thanks

[PATCH 3/3] USB: serial: keyspan_pda: fix receive sanity checks

Make sure to check for short transfers before parsing the receive buffer to avoid acting on stale data. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Signed-off-by: Johan Hovold <jo...@kernel.org> --- drivers/usb/serial/keyspan_pda.c | 19 ++- 1 file changed, 14

[PATCH 1/3] USB: serial: digi_acceleport: fix OOB data sanity check

ot;) Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Cc: stable <sta...@vger.kernel.org> # v2.6.30 Signed-off-by: Johan Hovold <jo...@kernel.org> --- drivers/usb/serial/digi_acceleport.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/drivers

[PATCH 2/3] USB: serial: digi_acceleport: fix incomplete rx sanity check

Make sure the received data has the required headers before parsing it. Also drop the redundant urb-status check, which has already been handled by the caller. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Signed-off-by: Johan Hovold <jo...@kernel.org> --- drivers/usb/serial/digi_a

Re: [PATCH 1/3] USB: serial: ark3116: fix endpoint-check return value

On Tue, Jan 31, 2017 at 03:35:54PM +0100, Greg Kroah-Hartman wrote: > On Tue, Jan 31, 2017 at 11:51:07AM +0100, Johan Hovold wrote: > > Return -ENODEV rather than -EINVAL on probe errors due to a missing > > endpoint. > > > > Also clean up the endpoint sanity check som

[PATCH 1/3] USB: serial: ark3116: fix endpoint-check return value

Return -ENODEV rather than -EINVAL on probe errors due to a missing endpoint. Also clean up the endpoint sanity check somewhat and use the interface device for logging a more compact error in case an expected endpoint is missing. Signed-off-by: Johan Hovold <jo...@kernel.org> --- drive

[PATCH 2/3] USB: serial: ark3116: remove redundant interrupt-urb check

Remove redundant check of num_interrupt_in which has already been verified in probe (killing a NULL-urb would also have been fine). Signed-off-by: Johan Hovold <jo...@kernel.org> --- drivers/usb/serial/ark3116.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drive

[PATCH 3/3] USB: serial: ark3116: use port device for info and error messages

Use the port device rather than usb device in info and error messages. This makes sure that driver and tty port is included in the messages, while also making them more uniform. Signed-off-by: Johan Hovold <jo...@kernel.org> --- drivers/usb/serial/ark3116.c | 16 ++-- 1 file c

[GIT PULL] USB-serial fixes for v4.10-rc6

to 5d03a2fd2292e71936c4235885c35ccc3c94695b: USB: serial: option: add device ID for HP lt2523 (Novatel E371) (2017-01-24 12:07:28 +0100) USB-serial fixes for v4.10-rc6 Just a couple of new device ids. Signed-off-by: Johan Hovold <

Re: [PATCH v6] USB: serial: Add uPD78F0730 USB to Serial Adaptor Driver

On Wed, Jan 25, 2017 at 11:40:40PM +0300, Maksim Salau wrote: > The adaptor can be found on development boards for 78k, RL78 and V850 > microcontrollers produced by Renesas Electronics Corporation. > > This is not a full-featured USB to serial converter, however it allows > basic communication

Re: [PATCH 1/2] USB: serial: ftdi_sio: clean up ioctl handler

On Wed, Jan 25, 2017 at 10:21:59PM +0100, Greg Kroah-Hartman wrote: > On Wed, Jan 25, 2017 at 06:22:53PM +0100, Johan Hovold wrote: > > Clean up the ioctl handler and make sure to pass an unsigned-int rather > > than serial_struct pointer to the TIOCSERGETLSR helper as this it wh

[PATCH 1/2] USB: serial: ftdi_sio: clean up ioctl handler

Clean up the ioctl handler and make sure to pass an unsigned-int rather than serial_struct pointer to the TIOCSERGETLSR helper as this it what the user argument really is. Signed-off-by: Johan Hovold <jo...@kernel.org> --- drivers/usb/serial/ftdi_sio.c | 19 +++ 1 file chan

[PATCH 2/2] USB: serial: drop unused ASYNC flags

Do not report ASYNC_SKIP_TEST or ASYNC_AUTO_IRQ as being set in TIOCGSERIAL handlers as these flags are not supported and do not really make any sense for USB serial devices in the first place. Signed-off-by: Johan Hovold <jo...@kernel.org> --- drivers/usb/serial/io_edgeport.c | 1 - drive

[PATCH] USB: cdc-acm: fix TIOCGSERIAL flags

which removed the unconditional setting of the corresponding tty low_latency flag (something which had always been broken in itself). Since the driver does not have a low-latency mode, let's drop the flag. Signed-off-by: Johan Hovold <jo...@kernel.org> --- drivers/usb/class/cdc-acm.c | 1 - 1 file

Re: [PATCH] USB: serial: ftdi_sio: fix extreme low-latency setting

On Wed, Jan 25, 2017 at 04:42:01PM +0100, Greg Kroah-Hartman wrote: > On Wed, Jan 25, 2017 at 04:14:36PM +0100, Johan Hovold wrote: > > On Wed, Jan 25, 2017 at 04:06:47PM +0100, Greg Kroah-Hartman wrote: > > > On Wed, Jan 25, 2017 at 03:35:20PM +0100, Johan Hovold wrote: &g

Re: [PATCH] USB: serial: ftdi_sio: fix extreme low-latency setting

On Wed, Jan 25, 2017 at 04:06:47PM +0100, Greg Kroah-Hartman wrote: > On Wed, Jan 25, 2017 at 03:35:20PM +0100, Johan Hovold wrote: > > Since commit 557aaa7ffab6 ("ft232: support the ASYNC_LOW_LATENCY > > flag") the FTDI driver has been using a receive latency-timer

[PATCH] USB: serial: ftdi_sio: fix extreme low-latency setting

<sta...@vger.kernel.org> # v2.6.31 Signed-off-by: Johan Hovold <jo...@kernel.org> --- Greg, I've been aware of this overhead for a while, but never realised it was actually a regression introduced in 2009. Fixing something like this after such a long time obviously means

Re: [PATCH] USB: option: add device ID for HP lt2523 (Novatel E371)

On Tue, Jan 24, 2017 at 10:31:18AM +0100, Bjørn Mork wrote: > Yet another laptop vendor rebranded Novatel E371. > > Cc: sta...@vger.kernel.org > Signed-off-by: Bjørn Mork Applied, thanks. Johan -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body

Re: [PATCH v5] USB: Add uPD78F0730 USB to Serial Adaptor Driver

On Sun, Jan 22, 2017 at 12:32:16AM +0300, Maksim Salau wrote: > The adaptor can be found on development boards for 78k, RL78 and V850 > microcontrollers produced by Renesas Electronics Corporation. > > This is not a full-featured USB to serial converter, however it allows > basic communication

Re: [PATCH] USB: qcserial: add Dell DW5570 QDL

On Wed, Jan 18, 2017 at 09:31:31PM +0100, Aleksander Morgado wrote: > The Dell DW5570 is a re-branded Sierra Wireless MC8805 which will by > default boot with vid 0x413c and pid 0x81a3. When triggered QDL download > mode, the device switches to pid 0x81a6 and provides the standard TTY > used for

Re: [PATCH v3] USB: Add uPD78F0730 USB to Serial Adaptor Driver

On Tue, Jan 17, 2017 at 04:25:18PM +0300, Maksim Salau wrote: > Hi Johan, > > > I think it's right to keep them as in the current version of the patch > > (i.e. active high) which is accordance with the datasheet, but if > > possible you should verify the levels when using hardware flow control >

Re: [PATCH] USB: serial: opticon: fix CTS retrieval at open

On Fri, Jan 13, 2017 at 01:41:47PM +0100, Greg Kroah-Hartman wrote: > On Fri, Jan 13, 2017 at 01:21:08PM +0100, Johan Hovold wrote: > > The opticon driver used a control request at open to trigger a CTS > > status notification to be sent over the bulk-in pipe. When the driver &g

Re: USB: OHCI: high softirq load

[ +CC: linux-usb ] On Mon, Jan 16, 2017 at 12:14:03PM +0100, Boris Brezillon wrote: > On Mon, 16 Jan 2017 11:54:23 +0100 > Antoine Aubert wrote: > > > Also, I made a big misunderstanding > > > > With EHCI + OHCI = high level of softirq (USB2.0) > > Well, the number of

Re: [PATCH 6/6] USB: serial: kl5kusb105: fix port-settings error handling

On Tue, Jan 10, 2017 at 12:05:42PM +0100, Johan Hovold wrote: > Fix port-settings error handling in order to detect a short transfer. > > Note that this currently only implies that an error is logged. > > Signed-off-by: Johan Hovold <jo...@kernel.org> > > --- > d

Re: [PATCH v2 09/14] USB: serial: ch341: fix control-message error handling

On Wed, Jan 11, 2017 at 12:08:23PM +0100, Johan Hovold wrote: > On Fri, Jan 06, 2017 at 07:15:18PM +0100, Johan Hovold wrote: > > A short control transfer would currently fail to be detected, something > > which could lead to stale buffer data being used as valid input. > >

Re: [PATCH v2] USB: cypress_m8: remove unused variable

On Tue, Jan 03, 2017 at 09:01:10PM +, Sudip Mukherjee wrote: > From: Sudip Mukherjee > > The variable havedata was only being set but never used afterwards. > > Signed-off-by: Sudip Mukherjee > --- > > v2: changed the from

[PATCH] USB: serial: opticon: fix CTS retrieval at open

an incorrect CTS state. Reported-by: Dan Carpenter <dan.carpen...@oracle.com> Fixes: 7a6ee2b02751 ("USB: opticon: switch to generic read implementation") Cc: stable <sta...@vger.kernel.org> Signed-off-by: Johan Hovold <jo...@kernel.org> --- drivers/usb/serial/opticon

Re: [bug report] USB: opticon: switch to generic read implementation

On Thu, Jan 12, 2017 at 11:39:14PM +0300, Dan Carpenter wrote: > Hello Johan Hovold, > > The patch 7a6ee2b02751: "USB: opticon: switch to generic read > implementation" from Nov 18, 2012, leads to the following static > checker warning: > > drivers/usb/se

[PATCH 2/2] HID: corsair: fix control-transfer error handling

necessary. Fixes: 6f78193ee9ea ("HID: corsair: Add Corsair Vengeance K90 driver") Cc: stable <sta...@vger.kernel.org> Signed-off-by: Johan Hovold <jo...@kernel.org> --- drivers/hid/hid-corsair.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drive

Re: [PATCH 00/15] USB: serial: fix control-message error handling

On Thu, Jan 12, 2017 at 06:19:53PM +0100, Greg Kroah-Hartman wrote: > On Thu, Jan 12, 2017 at 02:56:08PM +0100, Johan Hovold wrote: > > Several USB serial drivers failed to detect short control transfers, > > something which could lead to uninitialised data leaking to user spa

[PATCH 0/2] HID: corsair: fix DMA to stack and info leaks

These patches fix DMA buffers on stack and information leaks in the corsair HID driver. Note that this series has only been compile tested. Johan Johan Hovold (2): HID: corsair: fix DMA buffers on stack HID: corsair: fix control-transfer error handling drivers/hid/hid-corsair.c | 60

[PATCH 1/2] HID: corsair: fix DMA buffers on stack

er.kernel.org> Signed-off-by: Johan Hovold <jo...@kernel.org> --- drivers/hid/hid-corsair.c | 54 --- 1 file changed, 42 insertions(+), 12 deletions(-) diff --git a/drivers/hid/hid-corsair.c b/drivers/hid/hid-corsair.c index 717704e9ae0

[GIT PULL] USB-serial fixes for v4.10-rc4

, but also prevented a certain class of CH340 devices from working with the driver. Included are also two fixes for two minor information leaks in kl5kusb105 and ch341 due to failures to detect short control transfers. Signed-off-by: Johan Hovold <jo...@kernel.

Re: [PATCH 06/13] USB: serial: ch341: fix initial line settings

On Mon, Jan 09, 2017 at 02:51:59PM +0100, Johan Hovold wrote: > On Tue, Dec 20, 2016 at 09:49:00PM +0100, Johan Hovold wrote: > > On Tue, Dec 20, 2016 at 12:09:55PM -0800, Russell Senior wrote: > > > On Tue, Dec 20, 2016 at 8:07 AM, Johan Hovold <jo...@kernel.org> wrote: &

[PATCH 01/15] USB: serial: ark3116: fix register-accessor error handling

: ark3116: Make existing functions 16450-aware and add close and release functions.") Cc: stable <sta...@vger.kernel.org> Signed-off-by: Johan Hovold <jo...@kernel.org> --- drivers/usb/serial/ark3116.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git

[PATCH 00/15] USB: serial: fix control-message error handling

removing an unnecessary allocation from iuu_phoenix. These are all intended for inclusion in 4.11. Johan Johan Hovold (15): USB: serial: ark3116: fix register-accessor error handling USB: serial: ark3116: fix open error handling USB: serial: ftdi_sio: fix modem-status error handling USB

[PATCH 03/15] USB: serial: ftdi_sio: fix modem-status error handling

er.kernel.org> Signed-off-by: Johan Hovold <jo...@kernel.org> --- drivers/usb/serial/ftdi_sio.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/usb/serial/ftdi_sio.c b/drivers/usb/serial/ftdi_sio.c index 23d14b98ae2a..6dee20fc7e45 100644 --- a/drivers/usb/s

[PATCH 12/15] USB: serial: quatech2: fix control-message error handling

lacked appropriate error handling. Fixes: f7a33e608d9a ("USB: serial: add quatech2 usb to serial driver") Signed-off-by: Johan Hovold <jo...@kernel.org> --- drivers/usb/serial/quatech2.c | 24 +--- 1 file changed, 13 insertions(+), 11 deletions(-) diff --g

[PATCH 02/15] USB: serial: ark3116: fix open error handling

submitted and the register updates have not been made. Fixes: f4c1e8d597d1 ("USB: ark3116: Make existing functions 16450-aware and add close and release functions.") Signed-off-by: Johan Hovold <jo...@kernel.org> --- drivers/usb/serial/ark3116.c | 25 +++-- 1

[PATCH 08/15] USB: serial: mct_u232: fix modem-status error handling

: 1da177e4c3f4 ("Linux-2.6.12-rc2") Signed-off-by: Johan Hovold <jo...@kernel.org> --- drivers/usb/serial/mct_u232.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/usb/serial/mct_u232.c b/drivers/usb/serial/mct_u232.c index 885655315de1..edbc81f205c2 1006

[PATCH 05/15] USB: serial: io_edgeport: fix epic-descriptor handling

Use a dedicated buffer for the DMA transfer and make sure to detect short transfers to avoid parsing a corrupt descriptor. Fixes: 6e8cf7751f9f ("USB: add EPIC support to the io_edgeport driver") Signed-off-by: Johan Hovold <jo...@kernel.org> --- drivers/usb/serial/io

[PATCH 10/15] USB: serial: mos7840: fix control-message error handling

Make sure to detect short transfers when reading a device register. The modem-status handling had sufficient error checks in place, but move handling of short transfers into the register accessor function itself for consistency. Signed-off-by: Johan Hovold <jo...@kernel.org> --- drive

[PATCH 11/15] USB: serial: pl2303: fix line-setting error handling

Make sure to return an error on zero-length transfers when retrieving the line settings even if the driver currently ignores the return value. Also remove a redundant check for short transfer when setting the line settings. Signed-off-by: Johan Hovold <jo...@kernel.org> --- drivers/usb/

[PATCH 06/15] USB: serial: io_edgeport: fix descriptor error handling

.6.12-rc2") Signed-off-by: Johan Hovold <jo...@kernel.org> --- drivers/usb/serial/io_edgeport.c | 24 +++- 1 file changed, 15 insertions(+), 9 deletions(-) diff --git a/drivers/usb/serial/io_edgeport.c b/drivers/usb/serial/io_edgeport.c index 993a36a3e557..8ab

[PATCH 07/15] USB: serial: iuu_phoenix: remove unused buffer from open

Remove code that allocated but never used a buffer during open. Signed-off-by: Johan Hovold <jo...@kernel.org> --- drivers/usb/serial/iuu_phoenix.c | 15 +-- 1 file changed, 1 insertion(+), 14 deletions(-) diff --git a/drivers/usb/serial/iuu_phoenix.c b/drivers/usb/

[PATCH 15/15] USB: serial: ti_usb_3410_5052: fix control-message error handling

Linux-2.6.12-rc2") Signed-off-by: Johan Hovold <jo...@kernel.org> --- drivers/usb/serial/ti_usb_3410_5052.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/usb/serial/ti_usb_3410_5052.c b/drivers/usb/serial/ti_usb_3410_5052.c index 64b85b8ded

[PATCH 09/15] USB: serial: mos7720: fix control-message error handling

Make sure to log an error on short transfers when reading a device register. Also clear the provided buffer (which if often an uninitialised automatic variable) on errors as the driver currently does not bother to check for errors. Signed-off-by: Johan Hovold <jo...@kernel.org> --- drive

[PATCH 04/15] USB: serial: ftdi_sio: fix latency-timer error handling

Make sure to detect short responses when reading the latency timer to avoid using stale buffer data. Note that no heap data would currently leak through sysfs as ASYNC_LOW_LATENCY is set by default. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Signed-off-by: Johan Hovold <jo.

[PATCH 14/15] USB: serial: ssu100: fix control-message error handling

Make sure to detect short control-message transfers rather than continue with zero-initialised data when retrieving modem status and during device initialisation. Fixes: 52af95459939 ("USB: add USB serial ssu100 driver") Signed-off-by: Johan Hovold <jo...@kernel.org> --- dr

[PATCH 13/15] USB: serial: spcp8x5: fix modem-status handling

bits from the stack on short transfers. This also fixes the carrier-detect implementation which since the above mentioned commit unconditionally has returned true. Fixes: e1ed212d8593 ("USB: spcp8x5: add proper modem-status support") Cc: stable <sta...@vger.kernel.org> Signe

Re: [PATCH v2 09/14] USB: serial: ch341: fix control-message error handling

On Fri, Jan 06, 2017 at 07:15:18PM +0100, Johan Hovold wrote: > A short control transfer would currently fail to be detected, something > which could lead to stale buffer data being used as valid input. > > Check for short transfers, and make sure to log any transfer errors

Re: [PATCH v3] USB: Add uPD78F0730 USB to Serial Adaptor Driver

On Wed, Jan 11, 2017 at 10:49:22AM +0300, Maksim Salau wrote: > Hi Johan, > > Thanks for feedback. > > > > * Dropped inversion of DTR and RTS signals > > > > Did you figure out whether this was needed or not, for example by > > comparing to the hardware flow control levels? > > The current

Re: [PATCH 0/6] USB: serial: kl5kusb105: fixes and clean ups

On Tue, Jan 10, 2017 at 04:42:25PM +0100, Greg Kroah-Hartman wrote: > On Tue, Jan 10, 2017 at 12:05:36PM +0100, Johan Hovold wrote: > > This series fixes an information leak, and cleans up the driver > > somewhat. > > All look good to me: > > Reviewed-

[PATCH 0/6] USB: serial: kl5kusb105: fixes and clean ups

This series fixes an information leak, and cleans up the driver somewhat. Johan Johan Hovold (6): USB: serial: kl5kusb105: fix line-state error handling USB: serial: kl5kusb105: make logging less verbose USB: serial: kl5kusb105: remove dead code USB: serial: kl5kusb105: clean up struct

<    3   4   5   6   7   8   9   10   11   12   >