Re: [PATCH v3 00/49] usb: dwc2: fixes, enhancements and new features

2018-01-09 Thread Razmik Karapetyan
On 1/9/2018 11:56 PM, Stefan Wahren wrote: Hi Stefan, > Hi Razmik, > >> Razmik Karapetyan <razmik.karapet...@synopsys.com> hat am 8. Januar 2018 um >> 13:40 geschrieben: >> >> >> On 12/31/2017 9:19 PM, Stefan Wahren wrote: >> >> Hi Ste

Re: [PATCH v3 00/49] usb: dwc2: fixes, enhancements and new features

2018-01-08 Thread Razmik Karapetyan
On 12/31/2017 9:19 PM, Stefan Wahren wrote: Hi Stefan, >> >> Razmik Karapetyan (10): >>usb: dwc2: Set AHB burst size to INCR > > The usage hsotg->params.ahbcfg instead of the defines is a unintended fix for > BCM2835. According to the BCM2835 datasheet

Re: [PATCH v2] usb: dwc2: Remove unnecessary debug prints

2017-12-07 Thread Razmik Karapetyan
On 12/7/2017 11:18 PM, Joe Perches wrote: > On Thu, 2017-12-07 at 11:17 -0800, Joe Perches wrote: >> On Wed, 2017-12-06 at 17:57 +0400, Razmik Karapetyan wrote: >>> Removed unnecessary debug prints about DMA mode for host side >>> from dwc2_gahbcfg_init() function. >

[PATCH v2] usb: dwc2: Remove unnecessary debug prints

2017-12-06 Thread Razmik Karapetyan
Removed unnecessary debug prints about DMA mode for host side from dwc2_gahbcfg_init() function. Signed-off-by: Razmik Karapetyan <raz...@synopsys.com> --- drivers/usb/dwc2/hcd.c | 16 ++-- 1 file changed, 2 insertions(+), 14 deletions(-) diff --git a/drivers/usb/dwc2/h

[PATCH v2] usb: dwc2: Rename function names

2017-12-06 Thread Razmik Karapetyan
Renamed __orr32 and __bic32 function names to more descriptive dwc2_set_bit and dwc2_clear_bit respectively. Signed-off-by: Razmik Karapetyan <raz...@synopsys.com> --- drivers/usb/dwc2/gadget.c | 44 ++-- 1 file changed, 22 insertions(+), 22 del

[PATCH v3 2/4] usb: dwc2: Define Active Clock Gating support bit in GHWCFG4

2017-05-10 Thread Razmik Karapetyan
The previously reserved 12th bit in GHWCFG4 now indicates that the controller supports the Dynamic Power Reduction (Active Clock Gating) during no traffic scenarios such as L0, idle, resume and suspend states. Signed-off-by: Razmik Karapetyan <raz...@synopsys.com> --- drivers/usb/dwc2/hw

[PATCH v3 4/4] usb: dwc2: Backup and restore PCGCCTL1 register

2017-05-10 Thread Razmik Karapetyan
Backup PCGCCTL1 register when entering hibernation mode and restore it after exiting from hibernation, to keep active ACG feature. Signed-off-by: Razmik Karapetyan <raz...@synopsys.com> --- drivers/usb/dwc2/core.c | 2 ++ drivers/usb/dwc2/core.h | 1 + 2 files changed, 3 insertions(+)

[PATCH v3 1/4] usb: dwc2: Define PCGCCTL1 register in hw.h

2017-05-10 Thread Razmik Karapetyan
PCGCCTL1 (Power and Clock Control) register will be used for controlling the core`s active clock gating feature. Signed-off-by: Razmik Karapetyan <raz...@synopsys.com> --- drivers/usb/dwc2/hw.h | 4 1 file changed, 4 insertions(+) diff --git a/drivers/usb/dwc2/hw.h b/drivers/usb/dwc

[PATCH v3 3/4] usb: dwc2: Add dwc2_enable_acg function

2017-05-10 Thread Razmik Karapetyan
. Signed-off-by: Razmik Karapetyan <raz...@synopsys.com> --- drivers/usb/dwc2/core.c | 16 drivers/usb/dwc2/core.h | 2 ++ drivers/usb/dwc2/gadget.c | 12 ++-- drivers/usb/dwc2/hcd.c| 5 + 4 files changed, 33 insertions(+), 2 deletions(-) diff --git a/d

[PATCH v3 0/4] ACG support for dwc2 driver

2017-05-10 Thread Razmik Karapetyan
In short this feature specifies, that controller supports Dynamic Power Reduction during no traffic scenarios. Changes in v3: -added commit for backup and restore of ACG support register Razmik Karapetyan (4): usb: dwc2: Define PCGCCTL1 register in hw.h usb: dwc2: Define Active Clock

[PATCH v2 0/3] Interrupt handler optimizations of dwc2 driver

2017-04-19 Thread Razmik Karapetyan
Changes in version 2: Added cover letter for patch set Done small,but significant changes in interrupt handlers, which will allow to minimize incomplete ISOC IN/OUT, GOUTNAKEFF interrupt handling. Razmik Karapetyan (3): usb: dwc2: Update dwc2_handle_incomplete_isoc_in() function usb

[PATCH v2 2/3] usb: dwc2: Update dwc2_handle_incomplete_isoc_out() function

2017-04-19 Thread Razmik Karapetyan
In 'for' loop skipped masked and non-ISOC EPs. Also breaked 'for' loop after setting SGOUTNAK in DCTL,when one enabled EP was detected. This will allow to minimize incomplete ISOC OUT interrupt handling. Signed-off-by: Razmik Karapetyan <raz...@synopsys.com> --- drivers/usb/dwc2/gadget.

[PATCH v2 1/3] usb: dwc2: Update dwc2_handle_incomplete_isoc_in() function

2017-04-19 Thread Razmik Karapetyan
Disabled only that ISOC endpoints,for which interrupt bit was set in the DAINTMSK register. This will allow to minimize incomplete ISOC IN interrupt handling. Signed-off-by: Razmik Karapetyan <raz...@synopsys.com> --- drivers/usb/dwc2/gadget.c | 9 - 1 file changed, 8 insertions

[PATCH v2 3/3] usb: dwc2: Update GINTSTS_GOUTNAKEFF interrupt handling

2017-04-19 Thread Razmik Karapetyan
Disabled only unmasked endpoints based on DAINTMSK register. This will allow to minimize GINTSTS_GOUTNAKEFF interrupt handling. Signed-off-by: Razmik Karapetyan <raz...@synopsys.com> --- drivers/usb/dwc2/gadget.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/d

[PATCH v2 3/3] usb: dwc2: Add dwc2_enable_acg function

2017-04-19 Thread Razmik Karapetyan
. Signed-off-by: Razmik Karapetyan <raz...@synopsys.com> --- drivers/usb/dwc2/core.c | 16 drivers/usb/dwc2/core.h | 2 ++ drivers/usb/dwc2/gadget.c | 12 ++-- drivers/usb/dwc2/hcd.c| 5 + 4 files changed, 33 insertions(+), 2 deletions(-) diff --git a/d

[PATCH v2 2/3] usb: dwc2: Define Active Clock Gating support bit in GHWCFG4

2017-04-19 Thread Razmik Karapetyan
The previously reserved 12th bit in GHWCFG4 now indicates that the controller supports the Dynamic Power Reduction (Active Clock Gating) during no traffic scenarios such as L0, idle, resume and suspend states. Signed-off-by: Razmik Karapetyan <raz...@synopsys.com> --- drivers/usb/dwc2/hw

[PATCH v2 1/3] usb: dwc2: Define PCGCCTL1 register in hw.h

2017-04-19 Thread Razmik Karapetyan
PCGCCTL1 (Power and Clock Control) register will be used for controlling the core`s active clock gating feature. Signed-off-by: Razmik Karapetyan <raz...@synopsys.com> --- drivers/usb/dwc2/hw.h | 4 1 file changed, 4 insertions(+) diff --git a/drivers/usb/dwc2/hw.h b/drivers/usb/dwc

[PATCH v2 0/3] ACG support for dwc2 driver

2017-04-19 Thread Razmik Karapetyan
Patches related to implementation of ACG functionality in dwc2 driver. In short this feature specifies, that controller supports Dynamic Power Reduction during no traffic scenarios. Razmik Karapetyan (3): usb: dwc2: Define PCGCCTL1 register in hw.h usb: dwc2: Define Active Clock Gating

[PATCH] usb: dwc2: Rename function names

2017-04-19 Thread Razmik Karapetyan
Renamed __orr32 and __bic32 function names to more descriptive dwc2_set_bit and dwc2_clear_bit respectively. Signed-off-by: Razmik Karapetyan <raz...@synopsys.com> --- drivers/usb/dwc2/gadget.c | 42 +- 1 file changed, 21 insertions(+), 21 del

[PATCH 1/2] usb: dwc2: Remove unnecessary debug prints

2017-04-19 Thread Razmik Karapetyan
Removed unnecessary debug prints about DMA mode for host side from dwc2_gahbcfg_init() function. Signed-off-by: Razmik Karapetyan <raz...@synopsys.com> --- drivers/usb/dwc2/hcd.c | 16 ++-- 1 file changed, 2 insertions(+), 14 deletions(-) diff --git a/drivers/usb/dwc2/h

[PATCH] usb: dwc2: Set AHB burst size to INCR

2017-04-19 Thread Razmik Karapetyan
Changed AHB burst size from INCR4 to INCR by default. With this value driver show excellent DMA performance. Signed-off-by: Razmik Karapetyan <raz...@synopsys.com> --- drivers/usb/dwc2/gadget.c | 2 +- drivers/usb/dwc2/params.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff

[PATCH 1/3] usb: dwc2: Update dwc2_handle_incomplete_isoc_in() function

2017-04-19 Thread Razmik Karapetyan
Disabled only that ISOC endpoints,for which interrupt bit was set in the DAINTMSK register. This will allow to minimize incomplete ISOC IN interrupt handling. Signed-off-by: Razmik Karapetyan <raz...@synopsys.com> --- drivers/usb/dwc2/gadget.c | 9 - 1 file changed, 8 insertions

[PATCH 2/3] usb: dwc2: Update dwc2_handle_incomplete_isoc_out() function

2017-04-19 Thread Razmik Karapetyan
In 'for' loop skipped masked and non-ISOC EPs. Also breaked 'for' loop after setting SGOUTNAK in DCTL,when one enabled EP was detected. This will allow to minimize incomplete ISOC OUT interrupt handling. Signed-off-by: Razmik Karapetyan <raz...@synopsys.com> --- drivers/usb/dwc2/gadget.

[PATCH 3/3] usb: dwc2: Update GINTSTS_GOUTNAKEFF interrupt handling

2017-04-19 Thread Razmik Karapetyan
Disabled only unmasked endpoints based on DAINTMSK register. This will allow to minimize GINTSTS_GOUTNAKEFF interrupt handling. Signed-off-by: Razmik Karapetyan <raz...@synopsys.com> --- drivers/usb/dwc2/gadget.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/d

[PATCH 2/3] usb: dwc2: Define Active Clock Gating support bit in GHWCFG4

2017-04-19 Thread Razmik Karapetyan
The previously reserved 12th bit in GHWCFG4 now indicates that the controller supports the Dynamic Power Reduction (Active Clock Gating) during no traffic scenarios such as L0, idle, resume and suspend states. Signed-off-by: Razmik Karapetyan <raz...@synopsys.com> --- drivers/usb/dwc2/hw

[PATCH 3/3] usb: dwc2: Add dwc2_enable_acg function

2017-04-19 Thread Razmik Karapetyan
. Signed-off-by: Razmik Karapetyan <raz...@synopsys.com> --- drivers/usb/dwc2/core.c | 16 drivers/usb/dwc2/core.h | 2 ++ drivers/usb/dwc2/gadget.c | 12 ++-- drivers/usb/dwc2/hcd.c| 5 + 4 files changed, 33 insertions(+), 2 deletions(-) diff --git a/d

[PATCH 1/3] usb: dwc2: Define PCGCCTL1 register in hw.h

2017-04-19 Thread Razmik Karapetyan
PCGCCTL1 (Power and Clock Control) register will be used for controlling the core`s active clock gating feature. Signed-off-by: Razmik Karapetyan <raz...@synopsys.com> --- drivers/usb/dwc2/hw.h | 4 1 file changed, 4 insertions(+) diff --git a/drivers/usb/dwc2/hw.h b/drivers/usb/dwc