[PATCH] USB: dummy-hcd: Adapt dummy_udc_set_speed()

The UDC core ensures that .udc_set_speed() is called with a speed that is a minimum of the max speeds supported by the gadget function driver and the UDC driver. We can now use the speed argument as is. Get rid of the debug print as that condition will never happen. Signed-off-by: Roger Quadros

Re: [PATCH v2][RESEND] usb: gadget: core: Fix ->udc_set_speed() speed handling

On 01/11/17 17:45, Alan Stern wrote: > On Wed, 1 Nov 2017, Roger Quadros wrote: > >>> Roger, would you like to send in a follow-up patch that removes the now >>> unnecessary code from dummy_udc_set_speed() in dummy_hcd.c? >>> >> >> Sure. I have a

Re: [PATCH v2][RESEND] usb: gadget: core: Fix ->udc_set_speed() speed handling

Hi Alan, On 01/11/17 16:24, Alan Stern wrote: > On Tue, 31 Oct 2017, Roger Quadros wrote: > >> Currently UDC core calls ->udc_set_speed() with the speed parameter >> containing the maximum speed supported by the gadget function >> driver. This might very well

Re: DWC3 Gadget backtrace

Dylan, On 31/10/17 17:42, Howey, Dylan wrote: > Roger, > > On 10/31/2017 10:23, Roger Quadros wrote: >> Hi Dylan, >> >> On 30/10/17 10:59, Felipe Balbi wrote: >>> >>> Hi, >>> >>> "Howey, Dylan" <dylan.ho...@tennantc

[PATCH v2][RESEND] usb: gadget: core: Fix ->udc_set_speed() speed handling

ver are operating within limits. This fixes PHY Erratic errors and 2 second enumeration delay on TI's AM437x platforms. Fixes: 6099eca796ae ("usb: gadget: core: introduce ->udc_set_speed() method") Cc: <sta...@vger.kernel.org> # v4.13+ Reported-by: Dylan Howey <dylan.ho...@tennantco.

Re: [PATCH v2] usb: dwc3: gadget: Fix .udc_set_speed()

Felipe, Forgot to update subject :P. Will resend. On 31/10/17 15:47, Roger Quadros wrote: > Currently UDC core calls ->udc_set_speed() with the speed parameter > containing the maximum speed supported by the gadget function > driver. This might very well be more than that supported

[PATCH v2] usb: dwc3: gadget: Fix .udc_set_speed()

ver are operating within limits. This fixes PHY Erratic errors and 2 second enumeration delay on TI's AM437x platforms. Fixes: 6099eca796ae ("usb: gadget: core: introduce ->udc_set_speed() method") Cc: <sta...@vger.kernel.org> # v4.13+ Reported-by: Dylan Howey <dylan.ho...@tennantco.

Re: [PATCH] usb: dwc3: gadget: Fix .udc_set_speed()

 Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki On 31/10/17 15:24, Felipe Balbi wrote: > Roger Quadros <rog...@ti.com> writes: > >> UDC core calls .udc_set_speed() with the speed parameter >>

[PATCH] ARM: dts: dra7: Disable USB metastability workaround for USB2

(0901): Erratic Error [U0] irq/90-dwc3-969 [000] d...52.560646: dwc3_event: event (0901): Erratic Error [U0] irq/90-dwc3-969 [000] d...52.798144: dwc3_event: event (0901): Erratic Error [U0] Signed-off-by: Roger Quadros <rog...@ti.com> --- arch/arm/boot/dts/dra

[PATCH] usb: dwc3: Allow disabling of metastability workaround

...52.323145: dwc3_event: event (0901): Erratic Error [U0] irq/90-dwc3-969 [000] d...52.560646: dwc3_event: event (0901): Erratic Error [U0] irq/90-dwc3-969 [000] d...52.798144: dwc3_event: event (0901): Erratic Error [U0] Signed-off-by: Roger Quadros <rog...@ti.

[PATCH] usb: dwc3: gadget: Fix .udc_set_speed()

PHY Erratic errors and 2 second enumeration delay on TI's AM437x platforms. Fixes: 7d8d0639565f ("usb: dwc3: gadget: implement ->udc_set_speed()") Cc: <sta...@vger.kernel.org> # v4.13+ Reported-by: Dylan Howey <dylan.ho...@tennantco.com> Signed-off-by: Roger Quadros <

Re: DWC3 Gadget backtrace

Felipe, On 31/10/17 12:24, Felipe Balbi wrote: > > Hi, > > Roger Quadros <rog...@ti.com> writes: > > > >>> Roger, your PHY is toast :-( >>> >>> irq/90-dwc3-969 [000] d...52.323145: dwc3_event: event >>> (0

Re: DWC3 Gadget backtrace

On 31/10/17 12:24, Felipe Balbi wrote: > > Hi, > > Roger Quadros <rog...@ti.com> writes: > > > >>> Roger, your PHY is toast :-( >>> >>> irq/90-dwc3-969 [000] d...52.323145: dwc3_event: event >>> (0901): Errati

Re: DWC3 Gadget backtrace

On 31/10/17 12:05, Felipe Balbi wrote: > > Hi, > > "Howey, Dylan" writes: >> Felipe, >> >> On 10/30/2017 15:28, Felipe Balbi wrote: >>> >>> Hi, >>> >>> "Howey, Dylan" writes: Felipe, It's also happening in v4.14-rc7. >>> >>>

Re: DWC3 Gadget backtrace

issue, and is there a workaround or a fix available? > > sorry, you need to ask help from TI. Either that, or test current > mainline (v4.14-rc7) and let me know if the same problem is there. > > BTW, latest v4.9 stable is v4.9.58, not v4.9.40. > > > Adding Roger Quadros her

Re: Logitech Racing Wheel Driver

Hi Pramod, On 27/10/17 14:19, Pramod Bhagwat wrote: > Hi, > > We are using Logitech GT 920 device on Ubuntu 16.04. Where we can find > the driver for the same? > > Following is the output from the dmesg: > > [ 1676.016108] usb 1-5: new full-speed USB device number 7 using xhci_hcd > [

Re: Gadget mode advice sought

 Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki On 16/09/17 19:36, g...@novadsp.com wrote: > Greetings, > > I'm trying to find the simplest way to develop a bulk mode gadget that > exposes a standard userland IO

[PATCH] usb: gadget: core: fix ->udc_set_speed() logic

ger.kernel.org> [v4.13+] Signed-off-by: Roger Quadros <rog...@ti.com> --- drivers/usb/gadget/udc/core.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/usb/gadget/udc/core.c b/drivers/usb/gadget/udc/core.c index 75c51ca..d41d07a 100644 --- a/drivers/usb/gadg

Re: xhci_hcd HC died; cleaning up with TUSB7340 and µPD720201

 Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki On 14/09/17 16:53, Chris Welch wrote: >> -Original Message- >> From: Roger Quadros [mailto:rog...@ti.com] >> Sent: Thursday, Septembe

Re: xhci_hcd HC died; cleaning up with TUSB7340 and µPD720201

Chris, Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki On 13/09/17 17:26, Chris Welch wrote: > We are developing a product based on the TI AM5728 EVM. The product utilizes > a TUSB7340 PCIe USB host for

Re: TI TUSB7340 xHCI Host Controllers lock up

f errata posted for the TUSB73x0 > host controllers: ( http://www.ti.com/lit/er/sllz076/sllz076.pdf ) and > I noticed that recently Roger Quadros added a patch to address one of > the issues. This patch didn't resolve my issue however. > > There appeared to be some discussion about other

Re: [PATCH v2 1/2] usb: dwc3: keystone: Add PM_RUNTIME Support to DWC3 Keystone USB driver

e, add PM runtime support. Remove > legacy clock api's calls since other users of this driver worked without > these clock apis calls. > > Signed-off-by: Franklin S Cooper Jr <fcoo...@ti.com> Acked-by: Roger Quadros <rog...@ti.com> > --- > d

Re: [PATCH] usb: gadget: f_uac2: calculate wMaxPacketSize before endpoint match

(FS) or 1024 > (HS). > > With this audio gadget can be used on TI's OMAP-L138 SoC > which has a MUSB HS controller with endpoints having max > packet size much less than 1023 or 1024. See mode_2_cfg in > drivers/usb/musb/musb_core.c > > Signed-off-by: Sekhar Nori <nsek...@ti

Re: [PATCH 1/3] usb: host: ohci-platform: Add basic runtime PM support

gt; > Cc: Rob Herring <r...@kernel.org> > Cc: Roger Quadros <rog...@ti.com> > Cc: Sebastian Reichel <sebastian.reic...@collabora.co.uk> > Cc: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com> > Signed-off-by: Tony Lindgren <t...@atomide.com> Acked-by: Roger Q

Re: [PATCH 1/3] usb: host: ohci-platform: Add basic runtime PM support

On 23/05/17 17:08, Tony Lindgren wrote: > * Roger Quadros <rog...@ti.com> [170523 00:14]: >> On 22/05/17 19:00, Tony Lindgren wrote: >>> --- a/drivers/usb/host/ohci-platform.c >>> +++ b/drivers/usb/host/ohci-platform.c >>> @@ -290,7 +294,14 @@ static int o

Re: [PATCH 1/3] usb: host: ohci-platform: Add basic runtime PM support

gt; > Cc: Rob Herring <r...@kernel.org> > Cc: Roger Quadros <rog...@ti.com> > Cc: Sebastian Reichel <sebastian.reic...@collabora.co.uk> > Cc: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com> > Signed-off-by: Tony Lindgren <t...@atomide.com> > --- >

Re: [PATCH 3/3] usb: host: ohci-omap3: Remove driver in favor of ohci-platform

ohci-platform. > > Cc: Roger Quadros <rog...@ti.com> > Cc: Sebastian Reichel <sebastian.reic...@collabora.co.uk> > Signed-off-by: Tony Lindgren <t...@atomide.com> Acked-by: Roger Quadros <rog...@ti.com> > --- > drivers/usb/host/Kconfig | 6 +- &

Re: [PATCH 4/4] ARM: dts: Add remote-wakeup-connected for omap OHCI

On 18/05/17 01:59, Tony Lindgren wrote: > Add remote-wakeup-connected for omap OHCI as that's needed by > ehci-platform driver. > > Cc: devicet...@vger.kernel.org > Cc: Hans de Goede <hdego...@redhat.com> > Cc: Rob Herring <r...@kernel.org> > Cc: Roger Quadro

Re: [PATCH 1/4] usb: host: ohci-platform: Add basic runtime PM support

gt; > Cc: Rob Herring <r...@kernel.org> > Cc: Roger Quadros <rog...@ti.com> > Cc: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com> > Signed-off-by: Tony Lindgren <t...@atomide.com> Acked-by: Roger Quadros <rog...@ti.com> > --- > drivers/usb/host/ohci-p

Re: [PATCH 2/4] usb: host: ohci-platform: Add support for omap3 and later

On 18/05/17 01:59, Tony Lindgren wrote: > With the runtime PM implemented for ohci-platform driver, we can > now support omap3 and later OHCI by adding one device tree > property. > > Cc: Hans de Goede <hdego...@redhat.com> > Cc: Rob Herring <r...@kernel.org> >

Re: [PATCH] usb: xhci: add quirk flag for broken stop command on AMD platforms

Hi, On 18/05/17 11:53, Shyam Sundar S K wrote: > on AMD platforms with SNPS 3.1 USB controller has an issue > if the stop EP command is issued when the controller is not > in running state. If issued, it is leading to a critical RTL bug > because of which controller goes into irrecoverable state.

Re: [PATCH] usb: dwc3: gadget: Fix ISO transfer performance

Hi Felipe, On 21/04/17 15:58, Roger Quadros wrote: > Commit 08a36b543803 ("usb: dwc3: gadget: simplify __dwc3_gadget_ep_queue()") > caused a small change in the way ISO transfer is handled in the case > when XferInProgress event happens on Isoc EP with an active tran

[PATCH] usb: dwc3: gadget: Fix ISO transfer performance

cam on DUT and luvcview on host the video frame rate dropped from 16fps to 8fps @high-speed. Make the ISO transfer handling equivalent to that prior to that commit to get back the original ISO performance numbers. Fixes: 08a36b543803 ("usb: dwc3: gadget: simplify __dwc3_gadget_ep_queue()")

Re: [PATCH] usb: dwc3: gadget: delay unmap of bounced requests

Hi Felipe, On 13/03/17 16:38, Felipe Balbi wrote: > From: Janusz Dziedzic > > In the case of bounced ep0 requests, we must delay DMA operation until > after ->complete() otherwise we might overwrite contents of req->buf. > > This caused problems with RNDIS gadget. >

Synopsis XHCI controller lock up

Hi, I'm using a Texas Instruments PCIe XHCI USB card on x86-64 machine running Linux v4.11-rc6 with Ubuntu. I can manage to get the XHCI controller in a unresponsive state with the following message on a device disconnect [ 242.817353] usb 9-3: USB disconnect, device number 9 [ 247.919845]

Re: [balbi-usb:testing/next 46/49] undefined reference to `extcon_get_edev_by_phandle'

On 09/04/17 03:28, Randy Dunlap wrote: > On 04/08/17 09:29, kbuild test robot wrote: >> tree: https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git >> testing/next >> head: 9653f750a746d5abc4bc054d818eb32d1351eae9 >> commit: d5a80bad699c94703a0306edd250f65cfd050580 [46/49] usb: dwc3:

Re: [PATCH] usb: dwc3: make macros safe to expression arguments

On 06/04/17 13:45, Felipe Balbi wrote: > > Hi, > > Sergei Shtylyov <sergei.shtyl...@cogentembedded.com> writes: >> Hello. >> >> On 4/6/2017 1:17 PM, Felipe Balbi wrote: >> >>> From: Roger Quadros <rog...@ti.com> >>> >>

Re: [PATCH] usb: dwc3: make macros safe to expression arguments

+Bryan On 06/04/17 13:17, Felipe Balbi wrote: > From: Roger Quadros <rog...@ti.com> > > We must make sure that our macros are safe against expressions passed > as arguments. We have see one problem where GTXFIFOSIZ(n) was failling > when passed the expression (ep

Re: [PATCH v3 1/2] usb: dwc3: refactor gadget endpoint count calculation

On 06/04/17 11:59, Roger Quadros wrote: > Hi, > > On 31/01/17 22:58, Bryan O'Donoghue wrote: >> - DWC_USB3_NUM indicates the number of Device mode single directional >> endpoints, including OUT and IN endpoint 0. >> >> - DWC_USB3_NUM_IN_EPS indicates

Re: [PATCH v3 1/2] usb: dwc3: refactor gadget endpoint count calculation

Hi, On 31/01/17 22:58, Bryan O'Donoghue wrote: > - DWC_USB3_NUM indicates the number of Device mode single directional > endpoints, including OUT and IN endpoint 0. > > - DWC_USB3_NUM_IN_EPS indicates the maximum number of Device mode IN > endpoints active at any time, including control

[PATCH v4 3/3] usb: dwc3: Add dual-role support

ransitions as the extcon notifier (dwc3_drd_notifier) is called in an atomic context by extcon_sync() and this doesn't go well with usb_del_gadget_udc() causing a lockdep and softirq warning. Signed-off-by: Roger Quadros <rog...@ti.com> --- v4: -fix build error if CONFIG_USB_DWC3_DUAL_ROLE is not set

Re: [PATCH v3 3/3] usb: dwc3: Add dual-role support

drop us a note to > help improve the system] > > url: > https://github.com/0day-ci/linux/commits/Roger-Quadros/usb-dwc3-dual-role-support/20170404-022401 > base: https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git next > config: i386-randconfig-x010-201714 (attac

[PATCH v3 0/3] usb: dwc3: dual-role support

OTG controller code, only rely on extcon. cheers, -roger Roger Quadros (3): usb: udc: allow adding and removing the same gadget device usb: dwc3: make role-switching work with debugfs/mode usb: dwc3: Add dual-role support drivers/usb/dwc3/Makefile | 4 + drivers/usb/dwc3/core.c

[PATCH v3 2/3] usb: dwc3: make role-switching work with debugfs/mode

rollers. Signed-off-by: Roger Quadros <rog...@ti.com> --- drivers/usb/dwc3/core.c| 21 +++- drivers/usb/dwc3/core.h| 3 +++ drivers/usb/dwc3/debugfs.c | 49 +++--- 3 files changed, 57 insertions(+), 16 deletions(-) diff --git

[PATCH v3 1/3] usb: udc: allow adding and removing the same gadget device

allow usb_del_gadget_udc() and usb add_gadget_udc() to be called repeatedly on the same gadget->dev structure. We need to clear the gadget->dev structure so that kobject_init() doesn't complain about already initialized object. Signed-off-by: Roger Quadros <rog...@ti.com> --- driver

[PATCH v3 3/3] usb: dwc3: Add dual-role support

ransitions as the extcon notifier (dwc3_drd_notifier) is called in an atomic context by extcon_sync() and this doesn't go well with usb_del_gadget_udc() causing a lockdep and softirq warning. Signed-off-by: Roger Quadros <rog...@ti.com> --- drivers/usb/dwc3/Makefile | 4 ++ drivers/usb/dwc

Re: [PATCH v2 4/4] usb: dwc3: Workaround for super-speed host on dra7 in dual-role mode

On 31/03/17 15:00, Felipe Balbi wrote: > > Hi, > > Roger Quadros <rog...@ti.com> writes: >>>>> Your first implementation could be just that. Refactoring what needs to >>>>> be refactored, then patching "mode" debugfs to work pro

Re: [PATCH v2 4/4] usb: dwc3: Workaround for super-speed host on dra7 in dual-role mode

+Mathias On 31/03/17 10:46, Felipe Balbi wrote: > > Hi, > > Roger Quadros <rog...@ti.com> writes: >>>>> Roger Quadros <rog...@ti.com> writes: >>>>>> dra7 OTG core limits the host controller to USB2.0 (high-speed) mode >>&

Re: [PATCH v2 4/4] usb: dwc3: Workaround for super-speed host on dra7 in dual-role mode

Hi, On 29/03/17 13:32, Felipe Balbi wrote: > > Hi, > > Roger Quadros <rog...@ti.com> writes: >>> Roger Quadros <rog...@ti.com> writes: >>>> dra7 OTG core limits the host controller to USB2.0 (high-speed) mode >>>> when we're opera

Re: [PATCH v3 1/2] usb: dwc3: use BIT() macro where possible

On 30/03/17 13:25, Felipe Balbi wrote: > > Hi, > > Roger Quadros <rog...@ti.com> writes: >> To avoid checkpatch warnings with new patches let's >> start using the BIT() macro wherever possible. >> >> Signed-off-by: Roger Quadros <rog...@ti.com>

Re: [PATCH v2 4/4] usb: dwc3: Workaround for super-speed host on dra7 in dual-role mode

On 30/03/17 12:32, Felipe Balbi wrote: > > Hi, > > Roger Quadros <rog...@ti.com> writes: >>>> 3) All this becomes even more complex for configfs based gadget driver. >>>> >>>> So using stop/start gadget is a much simpler solution really as U

[PATCH v3 0/2] usb: dwc3: trivial fixes.

Hi Felipe, Resending this series rebased on v4.11-rc4. Changelog: v3: -rebased on v4.11-rc4 v2: -include bitops.h header cheers, -roger Roger Quadros (2): usb: dwc3: use BIT() macro where possible usb: otg-fsm: Prevent build warning "VDBG" redefined drivers/usb/common/usb

[PATCH v3 2/2] usb: otg-fsm: Prevent build warning "VDBG" redefined

, from drivers/usb/dwc3/ep0.c:33: include/linux/usb/otg-fsm.h:30:1: warning: "VDBG" redefined In file included from drivers/usb/dwc3/ep0.c:31: include/linux/usb/composite.h:615:1: warning: this is the location of the previous definition Signed-off-by: Roger Quadros <rog...@ti.

[PATCH v3 1/2] usb: dwc3: use BIT() macro where possible

To avoid checkpatch warnings with new patches let's start using the BIT() macro wherever possible. Signed-off-by: Roger Quadros <rog...@ti.com> --- drivers/usb/dwc3/core.h | 193 ++- drivers/usb/dwc3/dwc3-omap.c | 48 +-- drivers/us

Re: [PATCH v2 3/4] usb: dwc3: add dual-role support

Hi, On 29/03/17 16:15, Felipe Balbi wrote: > > Hi, > > Roger Quadros <rog...@ti.com> writes: >>>> @@ -839,6 +841,505 @@ static int dwc3_core_get_phy(struct dwc3 *dwc) >>>>return 0; >>>> } >>>> >>>> +static

Re: [PATCH v2 4/4] usb: dwc3: Workaround for super-speed host on dra7 in dual-role mode

On 29/03/17 16:21, Felipe Balbi wrote: > > Hi, > > Roger Quadros <rog...@ti.com> writes: >>> Roger Quadros <rog...@ti.com> writes: >>>>> Roger Quadros <rog...@ti.com> writes: >>>>>> dra7 OTG core limits the host control

Re: [PATCH v2 4/4] usb: dwc3: Workaround for super-speed host on dra7 in dual-role mode

On 29/03/17 13:32, Felipe Balbi wrote: > > Hi, > > Roger Quadros <rog...@ti.com> writes: >>> Roger Quadros <rog...@ti.com> writes: >>>> dra7 OTG core limits the host controller to USB2.0 (high-speed) mode >>>> when we're operating in d

Re: [PATCH v2 3/4] usb: dwc3: add dual-role support

Hi, On 28/03/17 14:07, Felipe Balbi wrote: > > Hi, > > Roger Quadros <rog...@ti.com> writes: >> If dr_mode is "otg" then support dual role mode of operation. >> >> Get ID and VBUS information from the OTG controller >> and put the controller i

Re: [PATCH v2 4/4] usb: dwc3: Workaround for super-speed host on dra7 in dual-role mode

On 28/03/17 14:10, Felipe Balbi wrote: > > Hi, > > Roger Quadros <rog...@ti.com> writes: >> dra7 OTG core limits the host controller to USB2.0 (high-speed) mode >> when we're operating in dual-role. > > yeah, that's not a quirk. DRA7 supports OTGv2, not O

Re: [PATCH v2 0/4] usb: dwc3: dual-role support

Hi, On 28/03/17 13:27, Felipe Balbi wrote: > Roger Quadros <rog...@ti.com> writes: > >> Hi, >> >> We rely on the OTG controller block or Extcon to provide us with >> VBUS and ID line status via an interrupt. >> >> This is then used to switch the

[PATCH v3] usb: xhci: bInterval quirk for TI TUSB73x0

. Workaround this issue by limiting the bInterval to 7 (i.e. interval to 6) for High-speed or faster periodic endpoints. [1] - http://www.ti.com/lit/er/sllz076/sllz076.pdf Signed-off-by: Roger Quadros <rog...@ti.com> --- v3: -fixed some more typos in commit message v2: -fixed typo in commit me

Re: [PATCH v2 0/4] usb: dwc3: dual-role support

Felipe, On 16/02/17 15:06, Roger Quadros wrote: > Hi, > > We rely on the OTG controller block or Extcon to provide us with > VBUS and ID line status via an interrupt. > > This is then used to switch the controller between host, peripheral > and idle roles based o

[PATCH v2] usb: xhci: bInterval quirk for TI TUSB73x0

. Workaround this issue by limiting the bInterval to 7 (i.e. interval to 6) for High-speed or faster periodic endpoints. [1] - http://www.ti.com/lit/er/sllz076/sllz076.pdf Signed-off-by: Roger Quadros <rog...@ti.com> --- v2: -fixed typo in commit message drivers/usb/host/xhci-mem.c | 11 +

Re: [PATCH] usb: xhci: bInterval quirk for TI TUSB73x0

On 09/03/17 11:44, Sergei Shtylyov wrote: > Hello! > > On 3/9/2017 11:47 AM, Roger Quadros wrote: > >> As per [1] issue #4, >> "The periodic EP scheduler always tries to schedule the EPs >> that have large intervals (interval equal to or greater than

Re: [PATCH 1/2] usb: gadget: f_uvc: Fix SuperSpeed companion descriptor's wBytesPerInterval

Felipe, On 08/03/17 16:05, Roger Quadros wrote: > The streaming_maxburst module parameter is 0 offset (0..15) > so we must add 1 while using it for wBytesPerInterval > calculation for the SuperSpeed companion descriptor. > > Without this host uvcvideo driver will alway

[PATCH] usb: xhci: bInterval quirk for TI TUSB73x0

. Workaround this issue by limiting the bInterval to 7 (i.e. interval to 6) for High-speed or faster periodic endpoints. [1] - http://www.ti.com/lit/er/sllz076/sllz076.pdf Signed-off-by: Roger Quadros <rog...@ti.com> --- drivers/usb/host/xhci-mem.c | 11 +++ drivers/usb/host/xhci-pci.c |

Re: [PATCH 1/3] usb: dwc3-omap: Fix missing break in dwc3_omap_set_mailbox()

Felipe, On 15/02/17 13:38, Roger Quadros wrote: > We need to break from all cases if we want to treat > each one of them separately. > > Reported-by: Gustavo A. R. Silva <garsi...@embeddedor.com> > Fixes: d2728fb3e01f ("usb: dwc3: omap: Pass VBUS and ID events

[PATCH 2/2] usb: gadget: f_uvc: Sanity check wMaxPacketSize for SuperSpeed

As per USB3.0 Specification "Table 9-20. Standard Endpoint Descriptor", for interrupt and isochronous endpoints, wMaxPacketSize must be set to 1024 if the endpoint defines bMaxBurst to be greater than zero. Signed-off-by: Roger Quadros <rog...@ti.com> --- drivers/usb/gadget/func

[PATCH 0/2] usb: gadget: f_uvc: SuperSpeed fixes

Hi Laurent & Felipe, These are some fixes for SuperSpeed case. -- cheers, -roger Roger Quadros (2): usb: gadget: f_uvc: Fix SuperSpeed companion descriptor's wBytesPerInterval usb: gadget: f_uvc: Sanity check wMaxPacketSize for SuperSpeed drivers/usb/gadget/function/f_uvc.c

[PATCH 1/2] usb: gadget: f_uvc: Fix SuperSpeed companion descriptor's wBytesPerInterval

a suitable video interface endpoint. e.g. for streaming_maxburst = 0 case it will always fail as wBytePerInterval was evaluating to 0. Cc: sta...@vger.kernel.org Signed-off-by: Roger Quadros <rog...@ti.com> --- drivers/usb/gadget/function/f_uvc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: usb: gadget: webcam broken?

-- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] uvc-gadget: Fix Set Interface (alternate setting) response behaviour

Laurent, On 06/03/17 22:50, Laurent Pinchart wrote: > Hi Roger, > > Thank you for the patch. > > On Friday 03 Mar 2017 13:17:15 Roger Quadros wrote: >> On alternate setting change, webcam gadget sends us a UVC_EVENT_STREAMON >> or UVC_EVENT_STREAMOFF event. It expe

Re: usb: gadget: webcam broken?

Petr, On 02/03/17 06:57, Petr Cvek wrote: > Dne 2.3.2017 v 00:22 Laurent Pinchart napsal(a): >> Hi Roger, >> >> On Wednesday 01 Mar 2017 17:09:51 Roger Quadros wrote: >>> Hi, >>> >>> I'm no longer able to use g_webcam with uvc-gadget [1] sinc

[PATCH] uvc-gadget: Fix Set Interface (alternate setting) response behaviour

<<< No Message Collected >>> -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH] Revert "usb: gadget: uvc: Add missing call for additional setup data"

. The bad commit was causing a duplicate response to be sent with incorrect response data thus causing UVC probe to fail at the host and broken control transfer endpoint at the gadget. [1] - git://git.ideasonboard.org/uvc-gadget.git Cc: <sta...@vger.kernel.org> # v4.9+ Signed-off-by: Roger Quadro

usb: dwc3: Bus Expiry on ISO transfers

Hi Felipe, I'm running g_webcam with uvc-gadget [1] on the DUT on v4.10 with commit 4fbac5206afd reverted. The first time I plug the DUT to host and run luvcview I can see the video test pattern so all OK. If I close luvcview and restart it without disconnecting the DUT then I don't see the

usb: gadget: webcam broken?

Hi, I'm no longer able to use g_webcam with uvc-gadget [1] since v4.9. Logs at the end. It looks like we're goofing up on the control endpoint. If I revert the following commit everything works fine. commit 4fbac5206afd01b717d4bdc58793d471f3391b4b Author: Petr Cvek Date:

Re: [PATCH v2 4/4] usb: dwc3: Workaround for super-speed host on dra7 in dual-role mode

On 25/02/17 05:35, Chanwoo Choi wrote: > Hi Roger, > > [snip] > >> /* dwc->lock must be held */ >> static void dwc3_otg_core_exit(struct dwc3 *dwc) >> { >> + if (dwc->edev) >> + return; >> + >> /* disable all otg irqs */ >> dwc3_otg_disable_events(dwc,

Re: [PATCH v2 4/4] usb: dwc3: Workaround for super-speed host on dra7 in dual-role mode

+Chanwoo Hi Vivek, On 23/02/17 10:34, Vivek Gautam wrote: > > > On 02/16/2017 06:36 PM, Roger Quadros wrote: >> dra7 OTG core limits the host controller to USB2.0 (high-speed) mode >> when we're operating in dual-role. >> >> We work around that by b

[PATCH v2 1/4] usb: dwc3: core.h: add some register definitions

Add OTG and GHWPARAMS6 register definitions Signed-off-by: Roger Quadros <rog...@ti.com> --- drivers/usb/dwc3/core.h | 82 + 1 file changed, 82 insertions(+) diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h index d514dca..f

[PATCH v2 4/4] usb: dwc3: Workaround for super-speed host on dra7 in dual-role mode

dra7 OTG core limits the host controller to USB2.0 (high-speed) mode when we're operating in dual-role. We work around that by bypassing the OTG core and reading the extcon framework directly for ID/VBUS events. Signed-off-by: Roger Quadros <rog...@ti.com> --- Documentation/devicetree/bi

[PATCH v2 0/4] usb: dwc3: dual-role support

if extcon phandle is present. - Fix bugs during system suspend/resume. cheers, -roger Roger Quadros (4): usb: dwc3: core.h: add some register definitions usb: dwc3: omap: don't miss events during suspend/resume usb: dwc3: add dual-role support usb: dwc3: Workaround for super-speed host

[PATCH v2 3/4] usb: dwc3: add dual-role support

OST - Host controller active 1 0 B_IDLE - Both Host and Gadget controllers inactive 1 1 B_PERIPHERAL - Gadget controller active Calling dwc3_otg_fsm_sync() directly from dwc3_complete() can lock up the system at xHCI add/remove so we use a work queue for it. Signed-off-by: Rog

[PATCH v2 2/4] usb: dwc3: omap: don't miss events during suspend/resume

The USB cable state can change during suspend/resume so be sure to check and update the extcon state. Signed-off-by: Roger Quadros <rog...@ti.com> --- drivers/usb/dwc3/dwc3-omap.c | 16 1 file changed, 16 insertions(+) diff --git a/drivers/usb/dwc3/dwc3-omap.c b/drive

[PATCH v2 2/3] usb: dwc3: use BIT() macro where possible

To avoid checkpatch warnings with new patches let's start using the BIT() macro wherever possible. Signed-off-by: Roger Quadros <rog...@ti.com> --- v2: -include bitops.h drivers/usb/dwc3/core.h | 193 ++- drivers/usb/dwc3/dwc3-omap.c

Re: [PATCH 2/3] usb: dwc3: use BIT() macro where possible

On 16/02/17 10:54, Felipe Balbi wrote: > > Hi, > > Roger Quadros <rog...@ti.com> writes: >> On 15/02/17 13:44, Felipe Balbi wrote: >>> >>> Hi, >>> >>> Roger Quadros <rog...@ti.com> writes: >>>> To avoid checkpatch warn

Re: [PATCH 2/3] usb: dwc3: use BIT() macro where possible

On 15/02/17 13:44, Felipe Balbi wrote: > > Hi, > > Roger Quadros <rog...@ti.com> writes: >> To avoid checkpatch warnings with new patches let's >> start using the BIT() macro wherever possible. >> >> Signed-off-by: Roger Quadros <rog...@ti.com&g

[PATCH] usb: dwc3: gadget: Fix system suspend/resume on TI platforms

) [ 141.998641] [] (kthread) from [] (ret_from_fork+0x14/0x24) [ 142.006213] ---[ end trace b4ecfe9f175b9a9c ]--- Signed-off-by: Roger Quadros <rog...@ti.com> --- drivers/usb/dwc3/gadget.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/usb/dwc3/gadget.c b/drivers/us

[PATCH 3/3] usb: otg-fsm: Prevent build warning "VDBG" redefined

, from drivers/usb/dwc3/ep0.c:33: include/linux/usb/otg-fsm.h:30:1: warning: "VDBG" redefined In file included from drivers/usb/dwc3/ep0.c:31: include/linux/usb/composite.h:615:1: warning: this is the location of the previous definition Signed-off-by: Roger Quadros <rog...@ti.

[PATCH 1/3] usb: dwc3-omap: Fix missing break in dwc3_omap_set_mailbox()

We need to break from all cases if we want to treat each one of them separately. Reported-by: Gustavo A. R. Silva <garsi...@embeddedor.com> Fixes: d2728fb3e01f ("usb: dwc3: omap: Pass VBUS and ID events transparently") Cc: <sta...@vger.kernel.org> #v4.8+ Signed-off-

[PATCH 2/3] usb: dwc3: use BIT() macro where possible

To avoid checkpatch warnings with new patches let's start using the BIT() macro wherever possible. Signed-off-by: Roger Quadros <rog...@ti.com> --- drivers/usb/dwc3/core.h | 192 +-- drivers/usb/dwc3/dwc3-omap.c | 48 +-- drivers/us

[PATCH 0/3] usb: dwc3: trivial fixes.

Hi Felipe, These are some trivial fixes. First patch is tagged for stable. You might want to pick it up for v4.11. Thanks. cheers, -roger Roger Quadros (3): usb: dwc3-omap: Fix missing break in dwc3_omap_set_mailbox() usb: dwc3: use BIT() macro where possible usb: otg-fsm: Prevent build

Re: [PATCH v13 06/12] usb: xhci: use bus->sysdev for DMA configuration

+Felipe, On 15/02/17 10:51, Peter Chen wrote: > On Wed, Feb 15, 2017 at 10:18:03AM +0200, Roger Quadros wrote: >> Peter, >> >> On 15/02/17 03:35, Peter Chen wrote: >>> On Tue, Feb 14, 2017 at 01:58:40PM +0100, Arnd Bergmann wrote: >>>> On Tue, Feb 14, 201

Re: [PATCH v13 06/12] usb: xhci: use bus->sysdev for DMA configuration

Peter, On 15/02/17 03:35, Peter Chen wrote: > On Tue, Feb 14, 2017 at 01:58:40PM +0100, Arnd Bergmann wrote: >> On Tue, Feb 14, 2017 at 1:26 PM, Roger Quadros <rog...@ti.com> wrote: >>> On 14/02/17 13:44, Arnd Bergmann wrote: >>>> On Tue, Feb 14, 2017 at 11

Re: [PATCH v13 06/12] usb: xhci: use bus->sysdev for DMA configuration

On 14/02/17 13:44, Arnd Bergmann wrote: > On Tue, Feb 14, 2017 at 11:36 AM, Roger Quadros <rog...@ti.com> wrote: >> On 11/02/17 03:27, Peter Chen wrote: >>> From: Arnd Bergmann <a...@arndb.de> >>> >>> For xhci-hcd platform device, all the DMA paramet

Re: [PATCH v13 06/12] usb: xhci: use bus->sysdev for DMA configuration

Hi, On 11/02/17 03:27, Peter Chen wrote: > From: Arnd Bergmann > > For xhci-hcd platform device, all the DMA parameters are not > configured properly, notably dma ops for dwc3 devices. So, set > the dma for xhci from sysdev. sysdev is pointing to device that > is known to the

Re: [PATCH v13 00/12] power: add power sequence library

Peter, On 11/02/17 03:27, Peter Chen wrote: > Hi all, > > This is a follow-up for my last power sequence framework patch set [1]. > According to Rob Herring and Ulf Hansson's comments[2]. The kinds of > power sequence instances will be added at postcore_initcall, the match > criteria is

Re: [PATCH 0/8] usb: dwc3: add dual-role support

Vivek, On 09/02/17 08:42, Vivek Gautam wrote: > Hi Roger, > > On Mon, Jan 23, 2017 at 4:49 PM, Roger Quadros <rog...@ti.com> wrote: >> Hi, >> >> We rely on the OTG controller block to provide us with >> VBUS and ID line status via an interrupt. >>

Re: [PATCH v12 6/9] usb: xhci: use bus->sysdev for DMA configuration

On 09/02/17 13:53, Roger Quadros wrote: > > > On 08/02/17 22:43, Jack Pham wrote: >> Hi Peter, Sriram, Arnd, >> >> On Mon, Feb 06, 2017 at 05:13:38PM +0800, Peter Chen wrote: >>> From: Arnd Bergmann <a...@arndb.de> >>> >&

Re: [PATCH v12 6/9] usb: xhci: use bus->sysdev for DMA configuration

On 08/02/17 22:43, Jack Pham wrote: > Hi Peter, Sriram, Arnd, > > On Mon, Feb 06, 2017 at 05:13:38PM +0800, Peter Chen wrote: >> From: Arnd Bergmann >> >> For xhci-hcd platform device, all the DMA parameters are not >> configured properly, notably dma ops for dwc3 devices. So,

<    1   2   3   4   5   6   7   8   9   10   >