Peter,
On 20/05/16 04:39, Peter Chen wrote:
> On Wed, May 18, 2016 at 03:45:11PM +0300, Roger Quadros wrote:
>> On 18/05/16 06:18, Peter Chen wrote:
>>> On Mon, May 16, 2016 at 12:51:53PM +0300, Roger Quadros wrote:
>>>> On 16/05/16 12:23, Peter Chen wrote:
>&
On 18/05/16 17:46, Jun Li wrote:
>
>
I didn't want to have complex Kconfig so decided to have otg as
built-in only.
What do you want me to change in existing code? and why?
>>>
>>> Remove those stuff which only for pass diff driver config Like every
>>> controller driver need
On 18/05/16 16:12, Jun Li wrote:
> Hi
>
>> -Original Message-----
>> From: Roger Quadros [mailto:rog...@ti.com]
>> Sent: Wednesday, May 18, 2016 8:43 PM
>> To: Jun Li <jun...@nxp.com>; Peter Chen <hzpeterc...@gmail.com>
>> Cc: peter.c...@f
Hi Peter,
On 18/05/16 10:45, Peter Chen wrote:
>
>
> On Mon, May 16, 2016 at 5:00 PM, Roger Quadros <rog...@ti.com
> <mailto:rog...@ti.com>> wrote:
>
> On 13/05/16 13:03, Roger Quadros wrote:
> > It provides APIs for the following tasks
> &
On 18/05/16 06:18, Peter Chen wrote:
> On Mon, May 16, 2016 at 12:51:53PM +0300, Roger Quadros wrote:
>> On 16/05/16 12:23, Peter Chen wrote:
>>> On Mon, May 16, 2016 at 11:26:57AM +0300, Roger Quadros wrote:
>>>> Hi,
>>>>
>>>> On 16/05/16 10:
On 17/05/16 11:28, Jun Li wrote:
> Hi Roger,
>
>> -Original Message-----
>> From: Roger Quadros [mailto:rog...@ti.com]
>> Sent: Tuesday, May 17, 2016 4:09 PM
>> To: Jun Li <jun...@nxp.com>; Peter Chen <hzpeterc...@gmail.com>
>> Cc: peter.c...@f
On 17/05/16 10:38, Jun Li wrote:
> Hi
>
>> -Original Message-----
>> From: Roger Quadros [mailto:rog...@ti.com]
>> Sent: Monday, May 16, 2016 5:52 PM
>> To: Peter Chen <hzpeterc...@gmail.com>
>> Cc: peter.c...@freescale.com; ba...@kernel.org; t...@
On 16/05/16 12:23, Peter Chen wrote:
> On Mon, May 16, 2016 at 11:26:57AM +0300, Roger Quadros wrote:
>> Hi,
>>
>> On 16/05/16 10:02, Peter Chen wrote:
>>> On Fri, May 13, 2016 at 01:03:27PM +0300, Roger Quadros wrote:
>>>> +
>>>> +static in
On 13/05/16 13:03, Roger Quadros wrote:
> It provides APIs for the following tasks
>
> - Registering an OTG/dual-role capable controller
> - Registering Host and Gadget controllers to OTG core
> - Providing inputs to and kicking the OTG state machine
>
> Provide a dual-ro
On 16/05/16 11:13, Peter Chen wrote:
> On Mon, May 16, 2016 at 11:01:27AM +0300, Roger Quadros wrote:
>> On 16/05/16 05:13, Peter Chen wrote:
>>> On Thu, May 12, 2016 at 03:13:48PM +0300, Roger Quadros wrote:
>>>> Hi,
>>>>
>>>>
Hi,
On 16/05/16 10:02, Peter Chen wrote:
> On Fri, May 13, 2016 at 01:03:27PM +0300, Roger Quadros wrote:
>> +
>> +static int usb_gadget_connect_control(struct usb_gadget *gadget, bool
>> connect)
>> +{
>> +struct usb_udc *udc;
>> +
>> +mutex
On 13/05/16 21:13, Rob Herring wrote:
> On Fri, May 13, 2016 at 5:03 AM, Roger Quadros <rog...@ti.com> wrote:
>> From: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com>
>>
>> Since some host controller (e.g. EHCI) needs a companion host controlle
On 16/05/16 05:13, Peter Chen wrote:
> On Thu, May 12, 2016 at 03:13:48PM +0300, Roger Quadros wrote:
>> Hi,
>>
>> On 12/05/16 13:31, Yoshihiro Shimoda wrote:
>>> Hi,
>>>
>>>> From: Roger Quadros
>>>> Sent: Thursday, May 12, 2016 6
5:c005cb64 r4:ee429940
[ 91.759209] handlers:
[ 91.759255] [] usb_hcd_irq [usbcore]
[ 91.759260] Disabling IRQ #254
Signed-off-by: Roger Quadros <rog...@ti.com>
Reviewed-by: Peter Chen <peter.c...@nxp.com>
---
drivers/usb/core/hcd.c | 1 +
1 file changed, 1 insertion(+)
diff --git a
o OTG. Here we don't support fancy
OTG features like HNP, SRP, on the fly role-swap. The mode of operation
is determined based on ID pin (cable type) and the role doesn't change
till the cable type changes.
--
cheers,
-roger
Roger Quadros (13):
usb: hcd: Initialize hcd->flags to 0
usb: otg-fsm
;
Signed-off-by: Roger Quadros <rog...@ti.com>
Acked-by: Peter Chen <peter.c...@nxp.com>
---
Documentation/devicetree/bindings/usb/generic.txt | 3 +++
drivers/usb/common/usb-otg.c | 32 ---
include/linux/usb/otg.h | 7 ++
,
from drivers/usb/dwc3/ep0.c:33:
include/linux/usb/otg-fsm.h:30:1: warning: "VDBG" redefined
In file included from drivers/usb/dwc3/ep0.c:31:
include/linux/usb/composite.h:615:1: warning: this is the location
of the previous definition
Signed-off-by: Roger Quadros <rog...@
The OTG core will use struct otg_hcd_ops to interface
with the HCD controller.
The main purpose of this interface is to avoid directly
calling HCD APIs from the OTG core as they
wouldn't be defined in the built-in symbol table if
CONFIG_USB is m.
Signed-off-by: Roger Quadros <rog...@ti.
This is to prevent missing symbol build error if OTG is
enabled (built-in) and HCD core (CONFIG_USB) is module.
Signed-off-by: Roger Quadros <rog...@ti.com>
Acked-by: Peter Chen <peter.c...@nxp.com>
---
drivers/usb/chipidea/otg_fsm.c | 7 +++
drivers/usb/common/usb-ot
Move otg_fsm into usb_otg and use usb_otg wherever possible
in the usb_otg APIs.
Signed-off-by: Roger Quadros <rog...@ti.com>
Acked-by: Peter Chen <peter.c...@nxp.com>
---
drivers/usb/chipidea/ci.h| 1 -
drivers/usb/chipidea/core.c | 14 +--
drivers/usb/chipidea/debug
Let's use CONFIG_USB_OTG as a single config option to enable
USB OTG and the OTG FSM. This makes things a lot less confusing.
Update all users of CONFIG_USB_OTG_FSM to CONFIG_USB_OTG.
Signed-off-by: Roger Quadros <rog...@ti.com>
Acked-by: Peter Chen <peter.c...@nxp.com>
---
Docum
The OTG core will use struct otg_gadget_ops to
start/stop the gadget controller.
The main purpose of this interface is to avoid directly
calling usb_gadget_start/stop() from the OTG core as they
wouldn't be defined in the built-in symbol table if
CONFIG_USB_GADGET is m.
Signed-off-by: Roger
and a different
cable type is inserted.
As we don't need most of the complex OTG states and OTG timers
we implement a lean DRD state machine in usb-otg.c.
The DRD state machine is only interested in 2 hardware inputs
'id' and 'b_sess_vld'.
Signed-off-by: Roger Quadros <rog...@ti.com>
---
drivers/usb/
The OTG controller and the USB controller can be linked via the
'otg-controller' property in the USB controller's device node.
of_usb_get_otg() can be used to get the OTG controller device
from the USB controller's device node.
Signed-off-by: Roger Quadros <rog...@ti.com>
Acked-by: Pete
Now that we have a device reference in struct usb_otg
let's use dev_dbg() for debug messages.
Signed-off-by: Roger Quadros <rog...@ti.com>
Acked-by: Peter Chen <peter.c...@nxp.com>
---
drivers/usb/common/usb-otg-fsm.c | 19 +++
1 file changed, 7 insertions(+),
.
Signed-off-by: Roger Quadros <rog...@ti.com>
Acked-by: Peter Chen <peter.c...@nxp.com>
---
drivers/usb/core/hcd.c | 55 +
include/linux/usb/hcd.h | 4
2 files changed, 59 insertions(+)
diff --git a/drivers/usb/core/hcd.c b/driv
a circular
locking dependency.
Ignore softconnect sysfs control when we're in OTG
mode as OTG FSM takes care of gadget softconnect using
the b_bus_req mechanism.
Signed-off-by: Roger Quadros <rog...@ti.com>
---
drivers/usb/gadget/udc/udc-core.c | 194 --
i
Host controllers that are part of an OTG/dual-role instance
need to somehow pass the OTG controller device information
to the HCD core.
We use platform data to pass the OTG controller device.
Signed-off-by: Roger Quadros <rog...@ti.com>
Reviewed-by: Peter Chen <peter.c...@nxp.com>
Hi,
On 12/05/16 13:31, Yoshihiro Shimoda wrote:
> Hi,
>
>> From: Roger Quadros
>> Sent: Thursday, May 12, 2016 6:32 PM
>>
>> Hi,
>>
>> On 12/05/16 11:34, Roger Quadros wrote:
>>> On 12/05/16 07:00, Yoshihiro Shimoda wrote:
>>>> Hi,
Hi,
On 12/05/16 11:34, Roger Quadros wrote:
> On 12/05/16 07:00, Yoshihiro Shimoda wrote:
>> Hi,
>>
>>> From: Alan Stern
>>> Sent: Wednesday, May 11, 2016 11:47 PM
>>>
>>> On Wed, 11 May 2016, Roger Quadros wrote:
>>>
>>
On 12/05/16 07:00, Yoshihiro Shimoda wrote:
> Hi,
>
>> From: Alan Stern
>> Sent: Wednesday, May 11, 2016 11:47 PM
>>
>> On Wed, 11 May 2016, Roger Quadros wrote:
>>
>>>> What I mean is if you have 2 EHCI controllers with 2 companion
>>>&
On 12/05/16 11:18, Peter Chen wrote:
> On Wed, May 11, 2016 at 03:32:30PM +0300, Roger Quadros wrote:
>> Peter,
>>
>> On 11/05/16 14:02, Roger Quadros wrote:
>>> On 11/05/16 09:10, Peter Chen wrote:
>>>> On Mon, May 02, 2016 at 03:18:48PM +0300, Rog
.
NOTE: OTG IRQ handler is yet to be added. This is a preparatory step.
Signed-off-by: Roger Quadros <rog...@ti.com>
---
drivers/usb/dwc3/dwc3-omap.c | 32 ++--
1 file changed, 26 insertions(+), 6 deletions(-)
diff --git a/drivers/usb/dwc3/dwc3-omap.c b/drivers/us
map and core.c for shared otg interrupt.
v5: Internal revision. Not sent to mailing list.
v4: first version that was reviewed.
cheers,
-roger
Roger Quadros (5):
usb: dwc3: omap: use request_threaded_irq()
usb: dwc3: omap: Mark the interrupt handler as shared
usb: dwc3: omap: Don't set POWERPRES
compatibility for a single named
interrupt for all 3 interrupts (e.g. for dwc3-pci) and
single unnamed interrupt for all 3 interrupts (e.g. old DT).
Signed-off-by: Roger Quadros <rog...@ti.com>
---
drivers/usb/dwc3/core.c | 10 --
drivers/usb/dwc3/core.h | 3 +++
drivers/usb/dwc3/gadget.
ields in the same register."
Signed-off-by: Roger Quadros <rog...@ti.com>
---
drivers/usb/dwc3/dwc3-omap.c | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/usb/dwc3/dwc3-omap.c b/drivers/usb/dwc3/dwc3-omap.c
index b58546c..dd55e08 100644
--- a/drive
On OMAPs, OTG events come on the same IRQ so we need to share
this IRQ with the OTG device driver.
Signed-off-by: Roger Quadros <rog...@ti.com>
---
drivers/usb/dwc3/dwc3-omap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/dwc3/dwc3-omap.c b/drivers/us
Don't make any decisions regarding VBUS session based on ID
status. That is best left to the OTG core.
Pass ID and VBUS events independent of each other so that OTG
core knows exactly what to do.
This makes dual-role with extcon work with OTG irq on OMAP platforms.
Signed-off-by: Roger Quadros
On 11/05/16 16:54, Rob Herring wrote:
> On Wed, May 04, 2016 at 04:47:18PM +0300, Roger Quadros wrote:
>> On 04/05/16 16:17, Rob Herring wrote:
>>> On Mon, May 02, 2016 at 03:18:53PM +0300, Roger Quadros wrote:
>>>> From: Yoshihiro Shimoda <yoshihiro.shimoda...@
On 11/05/16 15:39, Felipe Balbi wrote:
>
> Hi,
>
> Roger Quadros <rog...@ti.com> writes:
>>>>> static irqreturn_t dwc3_omap_threaded_interrupt(int irq, void *_omap)
>>>>> {
>>>>> struct dwc3_omap *omap = _omap;
>>>&
Peter,
On 11/05/16 14:02, Roger Quadros wrote:
> On 11/05/16 09:10, Peter Chen wrote:
>> On Mon, May 02, 2016 at 03:18:48PM +0300, Roger Quadros wrote:
>>> This is to prevent missing symbol build error if OTG is
>>> enabled (built-in) and HCD core (CONFIG_USB) is
On 11/05/16 12:47, Felipe Balbi wrote:
>
> Hi,
>
> Roger Quadros <rog...@ti.com> writes:
>>> Roger Quadros <rog...@ti.com> writes:
>>>>>> @@ -497,8 +503,8 @@ static int dwc3_omap_probe(struct platform_device
>>>>>>
On 11/05/16 11:36, Peter Chen wrote:
> On Mon, May 02, 2016 at 03:18:43PM +0300, Roger Quadros wrote:
>> Hi,
>>
>> This series centralizes OTG/Dual-role functionality in the kernel.
>> As of now I've got Dual-role functionality working pretty reliably on
>> dra7-
On 11/05/16 11:40, Peter Chen wrote:
> On Mon, May 02, 2016 at 03:18:52PM +0300, Roger Quadros wrote:
>> The OTG controller and the USB controller an be linked via the
>
> Typo?
Will fix.
cheers,
-roger
>
> Others are ok for me.
>
> Acked-by: Peter Chen <
On 11/05/16 11:34, Peter Chen wrote:
> On Mon, May 02, 2016 at 03:18:51PM +0300, Roger Quadros wrote:
>> +
>> +if (config->otg_work) /* custom otg_work ? */
>> +INIT_WORK(>work, config->otg_work);
>> +else
>> +INIT_WORK(
On 11/05/16 09:10, Peter Chen wrote:
> On Mon, May 02, 2016 at 03:18:48PM +0300, Roger Quadros wrote:
>> This is to prevent missing symbol build error if OTG is
>> enabled (built-in) and HCD core (CONFIG_USB) is module.
>>
>> Signed-off-by: Roger Quadros <rog...@t
Felipe,
On 10/05/16 13:12, Felipe Balbi wrote:
>
> Hi,
>
> Roger Quadros <rog...@ti.com> writes:
>>>> @@ -497,8 +503,8 @@ static int dwc3_omap_probe(struct platform_device
>>>> *pdev)
>>>>/* check the DMA Status */
>&g
On 10/05/16 13:14, Felipe Balbi wrote:
>
> Hi,
>
> Roger Quadros <rog...@ti.com> writes:
>>>> diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h
>>>> index 186a886..2e20892 100644
>>>> --- a/drivers/usb/dwc3/core.h
>>>
On 10/05/16 13:04, Felipe Balbi wrote:
>
> Hi,
>
> Roger Quadros <rog...@ti.com> writes:
>> On 10/05/16 12:54, Felipe Balbi wrote:
>>>
>>> Hi,
>>>
>>> Roger Quadros <rog...@ti.com> writes:
>>>> TRM [1] recommends
On 10/05/16 13:04, Felipe Balbi wrote:
>
> Hi,
>
> Roger Quadros <rog...@ti.com> writes:
>> On 10/05/16 12:54, Felipe Balbi wrote:
>>>
>>> Hi,
>>>
>>> Roger Quadros <rog...@ti.com> writes:
>>>> TRM [1] recommends
On 10/05/16 13:12, Felipe Balbi wrote:
>
> Hi,
>
> Roger Quadros <rog...@ti.com> writes:
>>>> @@ -497,8 +503,8 @@ static int dwc3_omap_probe(struct platform_device
>>>> *pdev)
>>>>/* check the DMA Status */
>>>>reg = d
On 10/05/16 13:05, Felipe Balbi wrote:
>
> Hi,
>
> Roger Quadros <rog...@ti.com> writes:
>> On 10/05/16 12:55, Felipe Balbi wrote:
>>>
>>> Hi,
>>>
>>> Roger Quadros <rog...@ti.com> writes:
>>>> Don't make any decision
On 10/05/16 13:03, Felipe Balbi wrote:
>
> Hi,
>
> Roger Quadros <rog...@ti.com> writes:
>> Implementations might use different IRQs for
>> host, gadget and OTG so use named interrupt resources
>> to allow Device tree to specify the 3 interrupts.
>
On 10/05/16 12:58, Felipe Balbi wrote:
>
> Hi,
>
> Roger Quadros <rog...@ti.com> writes:
>> We intend to share this interrupt with the OTG driver an to ensure
>> that irqflags match for the shared interrupt handlers we use
>> request_threaded_irq()
>&
On 10/05/16 12:55, Felipe Balbi wrote:
>
> Hi,
>
> Roger Quadros <rog...@ti.com> writes:
>> Don't make any decisions regarding VBUS session based on ID
>> status. That is best left to the OTG core.
>>
>> Pass ID and VBUS events independent of each ot
On 10/05/16 12:54, Felipe Balbi wrote:
>
> Hi,
>
> Roger Quadros <rog...@ti.com> writes:
>> TRM [1] recommends that POWERPRESENT bit must not be
>> set and left at it's default value of 0.
>>
>> [1] OMAP542x TRM - http://www.ti.com/lit/pdf/swpu
.
NOTE: OTG IRQ handler is yet to be added. This is a preparatory step.
Signed-off-by: Roger Quadros <rog...@ti.com>
---
drivers/usb/dwc3/dwc3-omap.c | 12 +---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/dwc3/dwc3-omap.c b/drivers/usb/dwc3/dwc3-omap.c
On OMAPs, OTG events come on the same IRQ so we need to share
this IRQ with the OTG device driver.
Signed-off-by: Roger Quadros <rog...@ti.com>
---
drivers/usb/dwc3/dwc3-omap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/dwc3/dwc3-omap.c b/drivers/us
compatibility for a single named
interrupt for all 3 interrupts (e.g. for dwc3-pci) and
single unnamed interrupt for all 3 interrupts (e.g. old DT).
Signed-off-by: Roger Quadros <rog...@ti.com>
---
drivers/usb/dwc3/core.c | 26 --
drivers/usb/dwc3/core.h | 5 +
drive
.
- use tracepoints instead of dev_dbg().
- match IRQ flags in dwc3_omap and core.c for shared otg interrupt.
v5: Internal revision. Not sent to mailing list.
v4: first version that was reviewed.
cheers,
-roger
Roger Quadros (5):
usb: dwc3: omap: use request_threaded_irq()
usb: dwc3: omap: Mark
Don't make any decisions regarding VBUS session based on ID
status. That is best left to the OTG core.
Pass ID and VBUS events independent of each other so that OTG
core knows exactly what to do.
This makes dual-role with extcon work with OTG irq on OMAP platforms.
Signed-off-by: Roger Quadros
ields in the same register."
Signed-off-by: Roger Quadros <rog...@ti.com>
---
drivers/usb/dwc3/dwc3-omap.c | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/usb/dwc3/dwc3-omap.c b/drivers/usb/dwc3/dwc3-omap.c
index a30944d..1f7259d 100644
--- a/drive
On 10/05/16 11:03, Jun Li wrote:
> Hi
>
>> -Original Message-----
>> From: Roger Quadros [mailto:rog...@ti.com]
>> Sent: Tuesday, May 10, 2016 3:35 PM
>> To: Peter Chen <hzpeterc...@gmail.com>
>> Cc: peter.c...@freescale.com; st...@row
On 10/05/16 11:12, Felipe Balbi wrote:
>
> Hi,
>
> Roger Quadros <rog...@ti.com> writes:
>> On 10/05/16 06:14, Peter Chen wrote:
>>> On Mon, May 09, 2016 at 12:45:38PM +0300, Roger Quadros wrote:
>>>> On 06/05/16 12:41, Peter Chen wrote:
>>
On 10/05/16 06:14, Peter Chen wrote:
> On Mon, May 09, 2016 at 12:45:38PM +0300, Roger Quadros wrote:
>> On 06/05/16 12:41, Peter Chen wrote:
>>> On Mon, May 02, 2016 at 03:18:46PM +0300, Roger Quadros wrote:
>>>> The OTG core will use struct otg_hcd_ops to interfac
On 06/05/16 12:04, Peter Chen wrote:
> On Mon, May 02, 2016 at 03:18:54PM +0300, Roger Quadros wrote:
>> Now that we have a device reference in struct usb_otg
>> let's use dev_dbg() for debug messages.
>>
>> Signed-off-by: Roger Quadros <rog...@ti.com>
>> -
On 06/05/16 12:41, Peter Chen wrote:
> On Mon, May 02, 2016 at 03:18:46PM +0300, Roger Quadros wrote:
>> The OTG core will use struct otg_hcd_ops to interface
>> with the HCD controller.
>>
>> The main purpose of this interface is to avoid directly
>> c
On 04/05/16 16:17, Rob Herring wrote:
> On Mon, May 02, 2016 at 03:18:53PM +0300, Roger Quadros wrote:
>> From: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com>
>>
>> Since some host controller (e.g. EHCI) needs a companion host controller
>> (e.g. OHCI), thi
On 04/05/16 11:03, Jun Li wrote:
> Hi
>
>> -Original Message-----
>> From: Roger Quadros [mailto:rog...@ti.com]
>> Sent: Wednesday, May 04, 2016 2:37 PM
>> To: Peter Chen <hzpeterc...@gmail.com>
>> Cc: Jun Li <jun...@nxp.com>; st.
Peter,
On 04/05/16 06:35, Peter Chen wrote:
> On Tue, May 03, 2016 at 06:44:46PM +0300, Roger Quadros wrote:
>> Hi,
>>
>> On 03/05/16 10:06, Jun Li wrote:
>>> Hi
>>>
>>>>>>>>>>> /**
>>>>>>&g
Hi,
On 03/05/16 10:06, Jun Li wrote:
> Hi
>
> /**
> + * usb_gadget_start - start the usb gadget controller and
> +connect to bus
> + * @gadget: the gadget device to start
> + *
> + * This is external API for use by OTG core.
> + *
ble type changes.
--
cheers,
-roger
Roger Quadros (13):
usb: hcd: Initialize hcd->flags to 0
usb: otg-fsm: Prevent build warning "VDBG" redefined
usb: hcd.h: Add OTG to HCD interface
usb: otg-fsm: use usb_otg wherever possible
usb: otg-fsm: move host controller operations into usb
Let's use CONFIG_USB_OTG as a single config option to enable
USB OTG and the OTG FSM. This makes things a lot less confusing.
Update all users of CONFIG_USB_OTG_FSM to CONFIG_USB_OTG.
Signed-off-by: Roger Quadros <rog...@ti.com>
---
Documentation/usb/chipidea.txt | 2 +-
drivers/usb/ch
;
Signed-off-by: Roger Quadros <rog...@ti.com>
---
Documentation/devicetree/bindings/usb/generic.txt | 3 +++
drivers/usb/common/usb-otg.c | 32 ---
include/linux/usb/otg.h | 7 -
3 files changed, 32 insertions(+), 10 deleti
The OTG controller and the USB controller an be linked via the
'otg-controller' property in the USB controller's device node.
of_usb_get_otg() can be used to get the OTG controller device
from the USB controller's device node.
Signed-off-by: Roger Quadros <rog...@ti.com>
---
Documen
5:c005cb64 r4:ee429940
[ 91.759209] handlers:
[ 91.759255] [] usb_hcd_irq [usbcore]
[ 91.759260] Disabling IRQ #254
Signed-off-by: Roger Quadros <rog...@ti.com>
---
drivers/usb/core/hcd.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c
ind
.
Signed-off-by: Roger Quadros <rog...@ti.com>
---
drivers/usb/core/hcd.c | 55 +
include/linux/usb/hcd.h | 4
2 files changed, 59 insertions(+)
diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c
index 9484539..cfc8232
The OTG core will use struct otg_hcd_ops to interface
with the HCD controller.
The main purpose of this interface is to avoid directly
calling HCD APIs from the OTG core as they
wouldn't be defined in the built-in symbol table if
CONFIG_USB is m.
Signed-off-by: Roger Quadros <rog...@ti.
and a different
cable type is inserted.
As we don't need most of the complex OTG states and OTG timers
we implement a lean DRD state machine in usb-otg.c.
The DRD state machine is only interested in 2 hardware inputs
'id' and 'b_sess_vld'.
Signed-off-by: Roger Quadros <rog...@ti.com>
---
drivers/usb/
Host controllers that are part of an OTG/dual-role instance
need to somehow pass the OTG controller device information
to the HCD core.
We use platform data to pass the OTG controller device.
Signed-off-by: Roger Quadros <rog...@ti.com>
---
drivers/usb/host/xhci-plat.c
Now that we have a device reference in struct usb_otg
let's use dev_dbg() for debug messages.
Signed-off-by: Roger Quadros <rog...@ti.com>
---
drivers/usb/common/usb-otg-fsm.c | 19 +++
1 file changed, 7 insertions(+), 12 deletions(-)
diff --git a/drivers/usb/common/u
in OTG
mode as OTG FSM takes care of gadget softconnect using
the b_bus_req mechanism.
Signed-off-by: Roger Quadros <rog...@ti.com>
---
drivers/usb/gadget/udc/udc-core.c | 161 +++---
include/linux/usb/gadget.h| 4 +
2 files changed, 156 insertions
Move otg_fsm into usb_otg and use usb_otg wherever possible
in the usb_otg APIs.
Signed-off-by: Roger Quadros <rog...@ti.com>
Acked-by: Peter Chen <peter.c...@nxp.com>
---
drivers/usb/chipidea/ci.h| 1 -
drivers/usb/chipidea/core.c | 14 +--
drivers/usb/chipidea/debug
,
from drivers/usb/dwc3/ep0.c:33:
include/linux/usb/otg-fsm.h:30:1: warning: "VDBG" redefined
In file included from drivers/usb/dwc3/ep0.c:31:
include/linux/usb/composite.h:615:1: warning: this is the location
of the previous definition
Signed-off-by: Roger Quadros <
The OTG core will use struct otg_gadget_ops to
start/stop the gadget controller.
The main purpose of this interface is to avoid directly
calling usb_gadget_start/stop() from the OTG core as they
wouldn't be defined in the built-in symbol table if
CONFIG_USB_GADGET is m.
Signed-off-by: Roger
This is to prevent missing symbol build error if OTG is
enabled (built-in) and HCD core (CONFIG_USB) is module.
Signed-off-by: Roger Quadros <rog...@ti.com>
Acked-by: Peter Chen <peter.c...@nxp.com>
---
drivers/usb/chipidea/otg_fsm.c | 7 +++
drivers/usb/common/usb-ot
I assumed that only tristate choice-values can have visibility 'm',
> which was wrong: tristate dependencies can result in 'm'
> visibility.
>
> So, add an explicit test if a symbol is of type tristate.
>
> I am a bit unsure how to handle Tested-By credits when patch
On 28/04/16 13:23, Jun Li wrote:
> Hi
>
>> -Original Message-----
>> From: Roger Quadros [mailto:rog...@ti.com]
>> Sent: Thursday, April 28, 2016 5:55 PM
>> To: Jun Li <jun...@nxp.com>; st...@rowland.harvard.edu; ba...@kernel.org;
>> gre...@lin
Hi,
On 27/04/16 14:22, Roger Quadros wrote:
> On 26/04/16 03:07, Jun Li wrote:
>> Hi
>>
>>> -Original Message-
>>> From: Roger Quadros [mailto:rog...@ti.com]
>>> Sent: Monday, April 25, 2016 10:04 PM
>>> To: Jun Li <jun...@nxp.com&
0] c0619510 unbind_store+0x120/0x150
> [c00efe47bc20] c06183c4 drv_attr_store+0x64/0xa0
> [c00efe47bc60] c039f1d0 sysfs_kf_write+0x80/0xb0
> [c00efe47bca0] c039e14c kernfs_fop_write+0x18c/0x1f0
> [c00efe47bcf0] c02e962c __vfs_write+0x6c/0x190
> [c0
Hi Joe,
On 27/04/16 23:41, Joe Lawrence wrote:
> Hello Mathias, Roger, Gabriel
>
> I've been chasing strange MSI / legacy IRQ behavior from xHCI for a
> couple days and wanted to report a few things that may be effected by
> Gabriel's recent "xhci: Cleanup only when releasing primary hcd" patch
On 28/04/16 04:54, Peter Chen wrote:
> On Wed, Apr 27, 2016 at 01:59:44PM +0300, Roger Quadros wrote:
>> Hi,
>>
>> On 27/04/16 06:15, Peter Chen wrote:
>>> On Tue, Apr 26, 2016 at 04:21:07PM +0800, Peter Chen wrote:
>>>> On Tue, Apr 26, 2016 a
On 18/04/16 10:08, Peter Chen wrote:
> On Tue, Apr 05, 2016 at 05:05:16PM +0300, Roger Quadros wrote:
>> This is the a_set_b_hnp_enable flag in the OTG state machine
>> diagram and must be set when the A-Host has successfully set
>> the b_hnp_enable feature of the OTG-
Felipe,
On 11/04/16 17:18, Roger Quadros wrote:
> dma_status bit flag is set but never really used
> so get rid of it.
>
> Reported-by: Felipe Balbi <ba...@kernel.org>
> Signed-off-by: Roger Quadros <rog...@ti.com>
Gentle ping on this one for -next. Thanks.
cheers,
-
On 26/04/16 03:07, Jun Li wrote:
> Hi
>
>> -Original Message-----
>> From: Roger Quadros [mailto:rog...@ti.com]
>> Sent: Monday, April 25, 2016 10:04 PM
>> To: Jun Li <jun...@nxp.com>; st...@rowland.harvard.edu; ba...@kernel.org;
>> gre...@linuxfoun
Hi Jun,
On 26/04/16 05:07, Jun Li wrote:
> Hi Roger
>
>> -Original Message-----
>> From: Roger Quadros [mailto:rog...@ti.com]
>> Sent: Tuesday, April 05, 2016 10:05 PM
>> To: st...@rowland.harvard.edu; ba...@kernel.org;
>> gre...@linuxfoundation
On 27/04/16 14:00, Roger Quadros wrote:
> On 27/04/16 13:16, Jun Li wrote:
>> Hi
>>
>>>
>>> +
>>> +static struct otg_hcd_ops otg_hcd_intf = {
>>> + .add = usb_add_hcd,
>>> + .remove = usb_remove_hcd,
>>> + .usb_bus
On 27/04/16 13:16, Jun Li wrote:
> Hi
>
>>
>> +
>> +static struct otg_hcd_ops otg_hcd_intf = {
>> +.add = usb_add_hcd,
>> +.remove = usb_remove_hcd,
>> +.usb_bus_start_enum = usb_bus_start_enum,
>
> Build break if CONFIG_USB_OTG is not enabled:
>
>
@gmail.com]
>>>> Sent: Tuesday, April 26, 2016 2:28 PM
>>>> To: Jun Li <jun...@nxp.com>
>>>> Cc: Roger Quadros <rog...@ti.com>; st...@rowland.harvard.edu;
>>>> ba...@kernel.org; gre...@linuxfoundation.org; peter.c...@freescale.com;
>
Peter,
On 21/04/16 09:52, Peter Chen wrote:
> On Tue, Apr 05, 2016 at 05:05:12PM +0300, Roger Quadros wrote:
>> It provides APIs for the following tasks
>>
>> - Registering an OTG/dual-role capable controller
>> - Registering Host and Gadget controllers to OTG
401 - 500 of 2024 matches
Mail list logo
