Re: [PATCH v2] USB: chipidea: Do not hang when CONFIG_USB_CHIPIDEA_ULPI is not selected

On Tue, Jul 03, 2018 at 07:52:07AM -0300, Fabio Estevam wrote: > Hi Shawn, > > On Tue, Jul 3, 2018 at 12:40 AM, Shawn Guo wrote: > > > We can have the options in defconfig, but they can still be turned off > > for whatever reason and we get the hang. Really, missi

Re: [PATCH v2] USB: chipidea: Do not hang when CONFIG_USB_CHIPIDEA_ULPI is not selected

On Mon, Jul 02, 2018 at 11:22:55PM -0300, Fabio Estevam wrote: > Hi Shawn, > > On Mon, Jul 2, 2018 at 11:06 PM, Shawn Guo wrote: > > > A second thought on this - shouldn't such dependency be solved by > > Kconfig select clause? > > I suspect we are not able to f

Re: [PATCH v2] USB: chipidea: Do not hang when CONFIG_USB_CHIPIDEA_ULPI is not selected

On Mon, Jun 25, 2018 at 11:25:12AM -0300, Fabio Estevam wrote: > From: Fabio Estevam > > Since commit 03e6275ae381087bd8 ("usb: chipidea: Fix ULPI on imx51") the > kernel hangs on a imx51-babbage board, when using the ULPI interface with > the CONFIG_USB_CHIPIDEA_ULPI option unselected. > >

Re: [PATCH v2] USB: chipidea: Do not hang when CONFIG_USB_CHIPIDEA_ULPI is not selected

On Mon, Jul 02, 2018 at 08:52:34AM -0300, Fabio Estevam wrote: > Hi Peter, > > On Mon, Jul 2, 2018 at 12:08 AM, Peter Chen wrote: > > > Fabio, since this function has dependency with defconfig, is the defconfig > > change a fix for v4.18-rc > > or for v4.19-rc1? > > I have sent the defconfig

Re: [PATCH v5 2/3] USB3/DWC3: Add property "snps, incr-burst-type-adjustment" for INCR burst type

On Tue, Mar 06, 2018 at 04:59:10PM +0800, Ran Wang wrote: > Property "snps,incr-burst-type-adjustment = , ..." for USB3.0 DWC3. > When only one value means INCRx mode with fix burst type. > When more than one value, means undefined length burst mode, USB controller > can use the length less than

Re: [PATCH v2 3/3] arm64: dts: qcom: Collapse usb support into one node

Hi Stephen, On Fri, Jul 14, 2017 at 02:40:05PM -0700, Stephen Boyd wrote: > We currently have three device nodes for the same USB hardware > block, as evident by the reuse of the same reg address multiple > times. Now that the chipidea driver fully supports OTG with the > MSM wrapper we can

[PATCH] usb: dwc3: of-simple: remove include of clk-provider.h

From: Shawn Guo <shawn@linaro.org> The header clk-provider.h is there for clock drivers (providers) to include, not client drivers (consumers). That said, of_clk_get_parent_count() is a helper function for clock providers, not a clk API for consumers. Let's replace of_clk_get_parent

[PATCH] arm64: dts: hi6220: improve g-tx-fifo-size setting for usb device

From: Shawn Guo <shawn@linaro.org> The current usb device g-tx-fifo-size setting in DT causes two problems for kernel driver. 1. On hi6220, there are 15 tx_fifo dedicated for all EPs except EP0, while DT only provides tx_fifo settings for 6 EPs. It results in the following an

Re: [PATCH] ARM: imx25: set default phy_type and dr_mode for usbotg port

On Thu, Feb 16, 2017 at 10:18:58PM +0100, Uwe Kleine-König wrote: > All currently supported i.MX25-based machines use phy_type = "utmi" and > dr_mode = "otg". So this seems to be a sensible default. > > This also doesn't hurt out-of-tree machines because up to now they had > to specify these two

Re: [PATCH 0/3] Add dis_rxdet_inp3_quirk property to USB3 node

On Fri, Jun 10, 2016 at 11:53:43AM +0530, Rajesh Bhagat wrote: > Adds dis_rxdet_inp3_quirk property to USB3 nodes of ls1021a, ls2080a > and ls1043a platform. > > Rajesh Bhagat (3): > arm: dts: ls1021a: Add dis_rxdet_inp3_quirk property to USB3 node > arm: dts: ls2080a: Add

Re: [PATCH] ARM: dts: ls2080a: Add quirk for Erratum A009116

On Tue, Feb 09, 2016 at 05:08:07PM -0600, Lijun Pan wrote: > Add "snps,quirk-frame-length-adjustment" property to > USB3 node for erratum A009116. This property provides > value of GFLADJ_30MHZ for post silicon frame length > adjustment. > > Signed-off-by: Lijun Pan >

Re: [PATCH] ARM: dts: ls1043a: Add quirk for Erratum A009116

On Wed, Feb 10, 2016 at 10:39:47AM +0530, Rajesh Bhagat wrote: > Add "snps,quirk-frame-length-adjustment" property to USB3 node for erratum > A009116. > This property provides value of GFLADJ_30MHZ for post silicon frame length > adjustment. The commit log should be generally wrapped around

Re: [PATCH] ARM: dts: ls2080a: Add quirk for Erratum A009116

On Tue, Feb 09, 2016 at 05:08:07PM -0600, Lijun Pan wrote: > Add "snps,quirk-frame-length-adjustment" property to > USB3 node for erratum A009116. This property provides > value of GFLADJ_30MHZ for post silicon frame length > adjustment. > > Signed-off-by: Lijun Pan

Re: [PATCH] arm: dts: ls1021a: Add quirk for Erratum A009116

On Wed, Oct 14, 2015 at 11:04:12AM +0530, Rajesh Bhagat wrote: > Add "snps,quirk-frame-length-adjustment" property to > USB3 node for erratum A009116. This property provides > value of GFLADJ_30MHZ for post silicon frame length > adjustment. > > Signed-off-by: Nikhil Badola

Re: [PATCH 1/3][v4] Documentation: dt: dwc3: Add snps,quirk-frame-length-adjustment property

On Mon, Oct 05, 2015 at 05:37:02AM +, RAJESH BHAGAT wrote: > Hi Shawn, > > Regarding below patch, Felipe has suggested to talk to you: > > > [PATCH 3/3][v4] arm: dts: ls1021a: Add quirk for Erratum A009116 > > talk to you ARM-SoC maintainer. > > https://lkml.org/lkml/2015/9/4/7 > > Please

Re: [PATCH v3 0/5] usb: change clock information for chipidea

; > Hi Shawn, > > Would you please help to queue dts changes (2/5, 3/5, 4/5)? Please send them to Shawn Guo <shawn...@kernel.org>. Shawn -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 00/10] USB: chipidea misc patches

On Mon, Aug 03, 2015 at 12:47:08PM +0800, Peter Chen wrote: Hi all, In this series, I add several new interfaces for chipidea driver, they are mainly for system configuration adjustment. The USB performance may be improved with these configuration changing, but each vendor driver owner

Re: [PATCH RESEND v2 7/7] ARM: dts: vf610-twr: Add USB support

On Tue, Aug 19, 2014 at 12:24:37AM +0400, Sergei Shtylyov wrote: Hello. On 08/19/2014 12:07 AM, Stefan Agner wrote: Add USB support for Freescale Vybrid tower. The USB hosts over-current protection signal is not connected is not connected to the PHY's over- Yes, we all understood

Re: [PATCH RESEND v2 0/7] vf610: Add USB support

On Mon, Aug 18, 2014 at 10:07:10PM +0200, Stefan Agner wrote: Stefan Agner (7): ARM: dts: vf610: Add USB PHY and controller ARM: imx: clk-vf610: Add USBPHY clocks ... ARM: dts: vf610: Add usbmisc for non-core registers ... ARM: dts: vf610-colibri: Add USB support ARM: dts:

Re: [RFC] usb issue on imx27: 3 clocks are needed

On Mon, Aug 18, 2014 at 05:00:59PM +0800, Peter Chen wrote: On Sat, Aug 16, 2014 at 05:38:30PM +0200, Philippe Reynes wrote: Hi all, i.MX27's usb needs three clocks (usb_ipg_gate, usb_ahb_gate and usb_div) but the current chipidea driver implementation, and devicetree, provides only

Re: [RFC] usb issue on imx27: 3 clocks are needed

On Mon, Aug 18, 2014 at 06:35:53PM +0800, Chen Peter-B29397 wrote: On Mon, Aug 18, 2014 at 05:00:59PM +0800, Peter Chen wrote: On Sat, Aug 16, 2014 at 05:38:30PM +0200, Philippe Reynes wrote: Hi all, i.MX27's usb needs three clocks (usb_ipg_gate, usb_ahb_gate and usb_div)

Re: [PATCH 1/6] ARM: dts: vf610: add USB PHY and controller

On Tue, Jul 22, 2014 at 11:57:31AM +0200, Stefan Agner wrote: Am 2014-07-22 04:22, schrieb Shawn Guo: On Fri, Jul 18, 2014 at 07:01:37PM +0200, Stefan Agner wrote: This adds USB PHY and USB controller nodes. Vybrid SoCs have two independent USB cores which each supports DR (dual role

Re: [PATCH 5/6] usb: phy: mxs: Add VF610 USB PHY support

On Fri, Jul 18, 2014 at 07:01:41PM +0200, Stefan Agner wrote: This adds support for the USB PHY in Vybrid VF610. We assume that the disconnection without VBUS is also needed for Vybrid. For all other flags, the presumption of innocence applies. Signed-off-by: Stefan Agner ste...@agner.ch

Re: [PATCH 1/6] ARM: dts: vf610: add USB PHY and controller

On Fri, Jul 18, 2014 at 07:01:37PM +0200, Stefan Agner wrote: This adds USB PHY and USB controller nodes. Vybrid SoCs have two independent USB cores which each supports DR (dual role). However, real OTG is not supported since the OTG ID pin is not available. The PHYs are located within the

Re: [PATCH 2/6] ARM: imx: clk-vf610: add USBPHY clocks

On Fri, Jul 18, 2014 at 07:01:38PM +0200, Stefan Agner wrote: This commit adds PLL7 which is required for USBPHY1. It also adds the USB PHY and USB Controller clocks and the gates to enable them. Signed-off-by: Stefan Agner ste...@agner.ch Jingchang, Does the patch look good to you? Shawn

Re: [PATCH 4/6] chipidea: usbmisc_imx: Add USB support for VF610 SoCs

On Fri, Jul 18, 2014 at 07:01:40PM +0200, Stefan Agner wrote: @@ -283,6 +307,10 @@ static const struct of_device_id usbmisc_imx_dt_ids[] = { .compatible = fsl,imx6q-usbmisc, .data = imx6q_usbmisc_ops, }, + { + .compatible = fsl,vf610-usbmisc,

Re: i.MX6 USB OTG support is broken on linux-next

On Mon, May 12, 2014 at 09:22:33AM +0800, Chen Peter-B29397 wrote: So when the board is OTG EH (CONFIG_USB_OTG is set), it should have TPL according to spec. In fact, even the CONFIG_USB_OTG_WHITELIST is not set, the non-TPL devices have not worked well, eg, it will not be

Re: i.MX6 USB OTG support is broken on linux-next

On Tue, May 13, 2014 at 08:25:18AM +0800, Chen Peter-B29397 wrote: In your case, you should not set CONFIG_USB_OTG no matter at defconfig and at menuconfig. Hmm, at least in my testing (USB mouse/keyboard connected to OTG port), it works as before even I enable

Re: i.MX6 USB OTG support is broken on linux-next

On Tue, May 13, 2014 at 09:10:36AM +0800, Li Jun wrote: Firstly, w/o USB_OTG and USB_OTG_FSM, your OTG port will work well as before (i.e. it can be host or can be gadget as you want, so it's enough for you if connect normal usb device or PC host), I assume you are not wanting more here, this

Re: i.MX6 USB OTG support is broken on linux-next

+ Robin and David, On Sat, May 10, 2014 at 07:10:05PM +0800, Peter Chen wrote: On Fri, May 09, 2014 at 09:00:47PM +0800, Shawn Guo wrote: I'm running next-20140508 kernel on imx6q-sabresd board with USB mouse/keyboard connected to OTG port. It works well on 3.15-rc but is broken

Re: i.MX6 USB OTG support is broken on linux-next

On Sat, May 10, 2014 at 09:57:39PM +0800, Li Jun wrote: As Peter suggested, do not enable OTG_FSM in defconfig since there are very few HNPSRP capable device in market. With OTG_FSM enabled, even USB_OTG_WHITELIST is not selected, the OTG port still can't work the same as before if you

Re: i.MX6 USB OTG support is broken on linux-next

On Sun, May 11, 2014 at 08:40:25AM +0800, Chen Peter-B29397 wrote: As I explained before: OTG devices and Embedded Hosts both have Targeted Host functionality, and each Targeted Host has its TPL (Targeted Peripheral List), only the devices are at TPL are supported by Targeted Host. So

i.MX6 USB OTG support is broken on linux-next

I'm running next-20140508 kernel on imx6q-sabresd board with USB mouse/keyboard connected to OTG port. It works well on 3.15-rc but is broken on recent linux-next kernel with the message like below. ... usb 1-1: device v413c p2107 is not supported hub 1-0:1.0: unable to enumerate USB device on

Re: [PATCH v4][ 1/8] ARM: dts: mx25: USB block requires only one clock

On Thu, Mar 13, 2014 at 10:18:39AM +0100, Denis Carikli wrote: From: Fabio Estevam fabio.este...@freescale.com Like other imx SoCs only one USB clock is needed on mx25. Signed-off-by: Fabio Estevam fabio.este...@freescale.com Applied all except the driver one which has been applied by

Re: [PATCH 6/9] ARM: dts: i.MX35: Add USB support.

On Fri, Mar 07, 2014 at 06:04:20PM +0100, Denis Carikli wrote: Signed-off-by: Denis Carikli de...@eukrea.com --- arch/arm/boot/dts/imx35.dtsi | 11 +++ 1 file changed, 11 insertions(+) diff --git a/arch/arm/boot/dts/imx35.dtsi b/arch/arm/boot/dts/imx35.dtsi index

Re: [PATCH v9 01/12] usb: doc: phy-mxs: Add more compatible strings

On Tue, Feb 18, 2014 at 10:49:24AM -0600, Felipe Balbi wrote: On Fri, Dec 27, 2013 at 10:38:30AM +0800, Peter Chen wrote: Add fsl,imx6q-usbphy for imx6dq and imx6dl, add fsl,imx6sl-usbphy for imx6sl. Signed-off-by: Peter Chen peter.c...@freescale.com anybody from DT to give me an

Re: [PATCH v9 01/12] usb: doc: phy-mxs: Add more compatible strings

On Wed, Feb 19, 2014 at 08:44:12AM +0800, Peter Chen wrote: On Tue, Feb 18, 2014 at 07:24:19PM -0600, Felipe Balbi wrote: On Wed, Feb 19, 2014 at 09:12:49AM +0800, Shawn Guo wrote: On Tue, Feb 18, 2014 at 10:49:24AM -0600, Felipe Balbi wrote: On Fri, Dec 27, 2013 at 10:38:30AM +0800

Re: [PATCH] ARM-i.MX6Q-dts : Added USB_OTG Support

On Fri, Jan 24, 2014 at 11:50:05AM +, Mark Rutland wrote: @@ -18,6 +18,19 @@ memory { reg = 0x1000 0x8000; }; + + regulators { + compatible = simple-bus; This is _not_ a simple bus. It doesn't have the required ranges property. Maybe

Re: [PATCH v7 06/14] usb: phy-mxs: Add anatop regmap

On Tue, Dec 24, 2013 at 09:20:11AM +0800, Peter Chen wrote: @@ -226,6 +235,16 @@ static int mxs_phy_probe(struct platform_device *pdev) platform_set_drvdata(pdev, mxs_phy); + if (mxs_phy-data-flags MXS_PHY_HAS_ANATOP) { + mxs_phy-regmap_anatop =

Re: [PATCH v7 10/14] usb: phy-mxs: add controller id

On Fri, Dec 20, 2013 at 03:52:06PM +0800, Peter Chen wrote: It is used to access un-regulator registers according to different controllers. Signed-off-by: Peter Chen peter.c...@freescale.com --- drivers/usb/phy/phy-mxs-usb.c |8 1 files changed, 8 insertions(+), 0

Re: [PATCH v7 10/14] usb: phy-mxs: add controller id

On Tue, Dec 24, 2013 at 09:34:47AM +0800, Peter Chen wrote: On Tue, Dec 24, 2013 at 10:08:28AM +0800, Shawn Guo wrote: On Fri, Dec 20, 2013 at 03:52:06PM +0800, Peter Chen wrote: It is used to access un-regulator registers according to different controllers. Signed-off-by: Peter

Re: [PATCH v7 10/14] usb: phy-mxs: add controller id

On Tue, Dec 24, 2013 at 10:09:17AM +0800, Peter Chen wrote: Yes. And with the DTS change being optional to kernel driver, the DTS and driver changes can be merged independently through two trees. So I just applied those two DTS patches. Including doc update or not? No. The binding

Re: [PATCH 2/2] ARM: dts: imx6q-udoo: Add USB host support

On Mon, Dec 02, 2013 at 11:53:03AM +, Mark Rutland wrote: On Thu, Nov 14, 2013 at 02:09:47AM +, Fabio Estevam wrote: From: Fabio Estevam fabio.este...@freescale.com Udoo board has USBH1 port connected to a USB2514 hub. Add support for it. Signed-off-by: Fabio Estevam

Re: [PATCH v2 2/2] usb: chipidea: usbmisc: Add support for i.MX51 CPU

On Tue, Nov 26, 2013 at 07:36:50PM +0400, Alexander Shiyan wrote: This adds i.MX51 as the next user of the usbmisc driver. Functionality is similar to i.MX53, so at this stage simply reuse existing i.MX53 calls. Signed-off-by: Alexander Shiyan shc_w...@mail.ru ---

Re: [PATCH v3] chipidea: ci_hdrc_imx: Allow handling the clock for an external USB hub

On Fri, Nov 15, 2013 at 02:21:36AM +, Peter Chen wrote: If on the board file I just do this: +usbh1 { + vbus-supply = reg_usb_h1_vbus; + clocks = clks 201; /* USB2514 clock comes from mx6 clko2 pin */ + status = okay; +}; + without touching any

Re: [PATCH 1/2] chipidea: ci_hdrc_imx: Allow handling the clock for an USB phy/hub

This should be sent to USB folks. Copy Peter and Alex. Shawn On Thu, Nov 14, 2013 at 12:09:46AM -0200, Fabio Estevam wrote: From: Fabio Estevam fabio.este...@freescale.com When using external USB PHY or USB hub, it is common that they require a clock input. Add a 'clk_phy' clock, so

Re: [PATCH] usb: phy: phy-mxs-usb: set the correct platform drvdata

-by: Shawn Guo shawn@linaro.org Change-Id should be dropped though. Shawn --- drivers/usb/phy/phy-mxs-usb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/phy/phy-mxs-usb.c b/drivers/usb/phy/phy-mxs-usb.c index fdd33b4..545844b 100644 --- a/drivers/usb/phy

Re: [PATCH v3 01/11] usb: phy-mxs: Add platform judgement code

On Tue, Nov 05, 2013 at 09:49:33AM +0800, Peter Chen wrote: The mxs-phy has several bugs and features at different versions, the driver code can get it through of_device_id.data. Signed-off-by: Peter Chen peter.c...@freescale.com --- drivers/usb/phy/phy-mxs-usb.c | 59

Re: [PATCH v3 03/11] usb: doc: phy-mxs: update binding for adding anatop phandle

On Tue, Nov 05, 2013 at 09:49:35AM +0800, Peter Chen wrote: Add anatop phandle which is used to access anatop registers to control PHY's power and other USB operations. Signed-off-by: Peter Chen peter.c...@freescale.com --- Documentation/devicetree/bindings/usb/mxs-phy.txt |2 ++ 1

Re: [PATCH v3 04/11] ARM: dts: imx6: add anatop phandle for usbphy

On Tue, Nov 05, 2013 at 09:49:36AM +0800, Peter Chen wrote: Add anatop phandle for usbphy Signed-off-by: Peter Chen peter.c...@freescale.com --- arch/arm/boot/dts/imx6qdl.dtsi |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) Does imx6sl.dtsi need the same update? Shawn

Re: [PATCH v3 05/11] usb: phy-mxs: Add anatop regmap

On Tue, Nov 05, 2013 at 09:49:37AM +0800, Peter Chen wrote: It is needed by imx6 SoC serial, but not for imx23 and imx28. s/serial/series Should we have another MXS_PHY_XXX flag for this, so that we can explicitly check when anatop must be there? Shawn Signed-off-by: Peter Chen

Re: [PATCH v3 11/11] usb: phy-mxs: Add system suspend/resume API

On Tue, Nov 05, 2013 at 09:49:43AM +0800, Peter Chen wrote: We need this to keep PHY's power on or off during the system suspend mode. If we need to enable USB wakeup, then we must keep PHY's power being on during the system suspend mode. Otherwise, we need to keep PHY's power being off to

Re: [PATCH v3 03/11] usb: doc: phy-mxs: update binding for adding anatop phandle

On Tue, Nov 05, 2013 at 10:50:02AM +0800, Peter Chen wrote: On Tue, Nov 05, 2013 at 10:34:06AM +0800, Shawn Guo wrote: On Tue, Nov 05, 2013 at 09:49:35AM +0800, Peter Chen wrote: Add anatop phandle which is used to access anatop registers to control PHY's power and other USB operations

Re: [PATCH v3 04/11] ARM: dts: imx6: add anatop phandle for usbphy

On Tue, Nov 05, 2013 at 10:53:08AM +0800, Peter Chen wrote: On Tue, Nov 05, 2013 at 10:41:33AM +0800, Shawn Guo wrote: On Tue, Nov 05, 2013 at 09:49:36AM +0800, Peter Chen wrote: Add anatop phandle for usbphy Signed-off-by: Peter Chen peter.c...@freescale.com --- arch/arm/boot

Re: [PATCH v3 11/11] usb: phy-mxs: Add system suspend/resume API

On Tue, Nov 05, 2013 at 10:59:17AM +0800, Peter Chen wrote: @@ -83,6 +90,15 @@ */ #define MXS_PHY_SENDING_SOF_TOO_FAST BIT(2) +/* imx23 style PHY */ +#define MXS_PHY_IMX23BIT(3) + +/* imx6q style PHY */ +#define MXS_PHY_IMX6Q

Re: [PATCH v3 3/5] usb: chipidea: imx: set CI_HDRC_IMX28_WRITE_FIX for imx28

On Sun, Oct 27, 2013 at 05:25:36PM +0100, Marek Vasut wrote: +static const struct of_device_id ci_hdrc_imx_dt_ids[] = { + { .compatible = fsl,imx28-usb, .data = imx28_usb_data}, + { .compatible = fsl,imx27-usb, .data = imx27_usb_data}, Just a nit-pick, but the order here is wrong ;-)

Re: [PATCH v3 5/5] ARM: dts: imx28: changing usb compatible string as only fsl,imx28-usb

On Mon, Oct 28, 2013 at 09:59:27AM +0800, Peter Chen wrote: hmm, before of_match_device gets improved or it is well documented, how user knows to organize device_id table. Just like you, you found it after you saw that of_match_device() does not return you the expected device :) Since the

Re: [PATCH v3 5/5] ARM: dts: imx28: changing usb compatible string as only fsl,imx28-usb

On Fri, Oct 25, 2013 at 02:02:23PM +0800, Peter Chen wrote: Due to imx28 usb has special write request, it is not compatible with other imx27 sytle usb controllers. Signed-off-by: Peter Chen peter.c...@freescale.com --- arch/arm/boot/dts/imx28.dtsi |4 ++-- 1 files changed, 2

Re: [PATCH v3 5/5] ARM: dts: imx28: changing usb compatible string as only fsl,imx28-usb

On Fri, Oct 25, 2013 at 04:14:30PM +0800, Peter Chen wrote: @@ -1041,7 +1041,7 @@ ranges; usb0: usb@8008 { - compatible = fsl,imx28-usb, fsl,imx27-usb; + compatible = fsl,imx28-usb; You shouldn't need the change as

Re: [Patch v2 02/14] usb: phy-mxs: Add platform judgement code

On Tue, Oct 22, 2013 at 01:58:36PM +0800, Peter Chen wrote: The mxs-phy has three versions until now, each versions have some differences among PHY operations. the 1st version is for mx23/mx28 SoC, The 2nd version is for mx6q and mx6dl, the 3rd version is for mx6sl and later mx6 platform.

Re: [Patch v2 10/14] usb: doc: phy-mxs: update binding for adding disconnect line property

On Tue, Oct 22, 2013 at 01:58:44PM +0800, Peter Chen wrote: This property is used to disconnect line between USB PHY and USB controller. Signed-off-by: Peter Chen peter.c...@freescale.com --- Documentation/devicetree/bindings/usb/mxs-phy.txt |4 1 files changed, 4 insertions(+),

Re: [Patch v2 13/14] usb: phy-mxs: Add implementation of set_wakeup

On Tue, Oct 22, 2013 at 01:58:47PM +0800, Peter Chen wrote: When we need the PHY can be waken up by external signals, we can call this API. Besides, we call mxs_phy_disconnect_line at this API to close the connection between USB PHY and controller, after that, the line state from controller is

Re: [Patch v2 10/14] usb: doc: phy-mxs: update binding for adding disconnect line property

On Wed, Oct 23, 2013 at 03:08:25PM +0800, Peter Chen wrote: One more thing: it is a SoC feature, so I can delete it from DT, and using compatible string (or of_device_id.data) to judge if it is needed at driver, do you think so? That's exactly my point - it's not a thing belonging to device

Re: [Patch v2 02/14] usb: phy-mxs: Add platform judgement code

On Wed, Oct 23, 2013 at 02:46:04PM +0800, Peter Chen wrote: How about compare compatible string directly at probe? if (of_device_is_compatible(np, fsl,imx6q-usbphy)) mxs_phy-devtype = IMX6Q_USB_PHY; else if ((of_device_is_compatible(np, fsl,imx6sl-usbphy))

Re: [Patch v2 01/14] usb: doc: phy-mxs: Add more compatible strings

On Tue, Oct 22, 2013 at 01:58:35PM +0800, Peter Chen wrote: Since there are three mxs PHY versions, using three compatible strings for them. Signed-off-by: Peter Chen peter.c...@freescale.com --- Documentation/devicetree/bindings/usb/mxs-phy.txt |6 +- 1 files changed, 5

Re: [Patch v2 01/14] usb: doc: phy-mxs: Add more compatible strings

On Tue, Oct 22, 2013 at 01:58:35PM +0800, Peter Chen wrote: Since there are three mxs PHY versions, using three compatible strings for them. Signed-off-by: Peter Chen peter.c...@freescale.com --- Documentation/devicetree/bindings/usb/mxs-phy.txt |6 +- 1 files changed, 5

Re: [PATCH 02/12] usb: phy-mxs: Enable IC fixes for mx6 SoC serial

On Sat, Oct 12, 2013 at 05:09:36PM +0800, Peter Chen wrote: After adding IC fixes bits, some PHY bugs are fixed by IC logic. Signed-off-by: Peter Chen peter.c...@freescale.com --- drivers/usb/phy/phy-mxs-usb.c | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff

Re: [PATCH 09/12] usb: phy-mxs: update binding for adding anatop phandle

On Sat, Oct 12, 2013 at 05:09:43PM +0800, Peter Chen wrote: Add anatop phandle which is used to access anatop registers to control PHY's power and other USB operations. Signed-off-by: Peter Chen peter.c...@freescale.com --- Documentation/devicetree/bindings/usb/mxs-phy.txt |2 ++ 1

Re: [PATCH 02/12] usb: phy-mxs: Enable IC fixes for mx6 SoC serial

On Mon, Oct 14, 2013 at 05:09:56PM +0800, Peter Chen wrote: Oh, sorry. I forget to put below one to this serial. Will do at v2 http://marc.info/?l=linux-usbm=137871552016298w=2 Remember to document the new compatible strings in bindings doc. Shawn -- To unsubscribe from this list: send the

Re: [PATCH] usb: phy: phy-mxs-usb: Check the return value from stmp_reset_block()

On Wed, Jul 03, 2013 at 04:34:13PM -0300, Fabio Estevam wrote: From: Fabio Estevam fabio.este...@freescale.com stmp_reset_block() may fail, so let's check its return value and propagate it in the case of error. Signed-off-by: Fabio Estevam fabio.este...@freescale.com Acked-by: Shawn Guo

Re: Chipidea usb otg support for IMX/MXS (device functionality)

On Mon, Jun 24, 2013 at 01:37:59AM +, Chen Peter-B29397 wrote: Add shawn. Marek, have you tried mx23 evk? Shawn, marek reported the udc function at mx23 works abnormal, but it works good at mx28. Have you tried mx23 udc recently? Sorry, I never tried usb on my imx23-evk due to some

Re: [PATCH 2/4] chipidea: ci13xxx_imx: Remove reg_vbus

On Mon, May 27, 2013 at 09:51:28AM -0300, Fabio Estevam wrote: There is no need to keep a 'reg_vbus' indirection, so get rid of it. The motivation for doing this change is that in the case of error, the current code only sets the local reg_vbus to NULL instead of updating the private

Re: [PATCH] usb: chipidea: usbmisc_imx: Staticize usbmisc_imx_drv_init/exit

/usbmisc_imx.c:252:6: warning: symbol 'usbmisc_imx_drv_exit' was not declared. Should it be static? Acked-by: Shawn Guo shawn@linaro.org Since we are at it, we may want to add __init/__exit for the functions as well. Shawn Signed-off-by: Fabio Estevam fabio.este...@freescale.com

Re: [PATCH] usb: chipidea: ci13xxx_imx: Use dev_dbg for pinctrl message

On Fri, Apr 26, 2013 at 03:36:42PM +0300, Alexander Shishkin wrote: In author's words, some controllers don't need it, so it's ok if it fails. Printing warning in that case is not a good idea, so I agree with Fabio. I'll apply it soon unless I hear from people involved with chipidea on imx.

Re: [PATCH 1/2] ARM: imx_v6_v7_defconfig: add CONFIG_USB_PHY

On Tue, Apr 02, 2013 at 11:07:06AM +0300, Felipe Balbi wrote: On Sun, Mar 24, 2013 at 10:06:04PM +0800, Shawn Guo wrote: Commit edc7cb2 (usb: phy: make it a menuconfig) makes USB_MXS_PHY be a sub-item of menuconfig symbol USB_PHY. This change gets the selection of CONFIG_USB_MXS_PHY

Re: [PATCH 1/2] ARM: imx_v6_v7_defconfig: add CONFIG_USB_PHY

On Tue, Apr 02, 2013 at 03:44:07PM +0300, Felipe Balbi wrote: alright, in that case can you rebase on next branch ? patch 2 didn't apply. Have you tried git am -3? Shawn -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org

[PATCH 1/2] ARM: imx_v6_v7_defconfig: add CONFIG_USB_PHY

.0: EHCI Host Controller ci_hdrc ci_hdrc.0: new USB bus registered, assigned bus number 1 Add CONFIG_USB_PHY to have the CONFIG_USB_MXS_PHY selection back to work. Signed-off-by: Shawn Guo shawn@linaro.org --- arch/arm/configs/imx_v6_v7_defconfig |1 + 1 file changed, 1 insertion

Re: [PATCH 13/15] USB: ehci: make orion and mxc bus glues coexist

have my ACK with the changes below rolled into your patch. Acked-by: Shawn Guo shawn@linaro.org ---8 diff --git a/drivers/usb/host/ehci-mxc.c b/drivers/usb/host/ehci-mxc.c index 177b354..a685945 100644 --- a/drivers/usb/host/ehci-mxc.c +++ b/drivers/usb/host/ehci-mxc.c @@ -37,7 +37,7

Re: [PATCH 13/15] USB: ehci: make orion and mxc bus glues coexist

On Tue, Jan 22, 2013 at 02:11:18PM +0800, Shawn Guo wrote: Alan, Thanks for the patch. I just gave it try. The USB Host port still works for me with a couple of fixes on your changes integrated (one for compiling and the other for probing). So you have my ACK with the changes below

Re: [PATCH v6 3/3] ARM: i.MX clock: Change the connection-id for fsl-usb2-udc

peter.c...@freescale.com do I get Acked-by for this one ? Acked-by: Shawn Guo shawn@linaro.org -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v4 1/1] ARM i.MX6: change mxs usbphy clock usage

On Fri, Jan 18, 2013 at 10:38:05AM +0800, Peter Chen wrote: This mxs usbphy is only needs to be on after system boots up, and software never needs to control it anymore. Meanwhile, usbphy's parent needs to be notified if usb is suspend or not. So we design below mxs usbphy usage: -

Re: [PATCH v3 1/3] ARM i.MX6: change mxs usbphy clock usage

On Wed, Jan 16, 2013 at 04:59:03PM +0800, Peter Chen wrote: This mxs usbphy is only needs to be on after system boots up, and software never needs to control it anymore. Meanwhile, usbphy's parent needs to be notified if usb is suspend or not. So we design below mxs usbphy usage: -

Re: [PATCH v2 1/4] ARM i.MX6: use reserved bit for mxs phy clock gate

On Tue, Jan 15, 2013 at 02:08:34PM +0800, Peter Chen wrote: For mxs-phy user i.mx6q, the PHY's clock is controlled by hardware automatically, the software only needs to enable it at probe, disable it at remove. During the runtime, we don't need to control it. So for the usbphy clk policy: -

Re: [PATCH v2 1/4] ARM i.MX6: use reserved bit for mxs phy clock gate

On Wed, Jan 16, 2013 at 09:18:46AM +0800, Peter Chen wrote: On Tue, Jan 15, 2013 at 07:33:16PM +0800, Shawn Guo wrote: On Tue, Jan 15, 2013 at 02:08:34PM +0800, Peter Chen wrote: For mxs-phy user i.mx6q, the PHY's clock is controlled by hardware automatically, the software only needs

Re: [PATCH 1/1] usb: fsl-mxc-udc: fix build error due to mach/hardware.h

Balbi, On Fri, Jan 11, 2013 at 02:50:59PM +0200, Felipe Balbi wrote: As I said before, this patch is too big for -rc and is unnecessary considering patch I wrote above. Note that there is no problems in checking if ULPI PHY clk is 60MHz on all arches and, for the workaround, you already have

Re: [PATCH 1/1] usb: fsl-mxc-udc: fix build error due to mach/hardware.h

On Fri, Jan 11, 2013 at 12:56:51PM +0200, Felipe Balbi wrote: Hi, On Fri, Jan 11, 2013 at 05:56:28PM +0800, Peter Chen wrote: It changes the driver to use platform_device_id rather than cpu_is_xxx to determine the SoC type, and updates the platform code accordingly. Compile ok at

Re: [PATCH 1/4] ARM: dts: mxs-phy: Change mxs phy clock usage

On Thu, Jan 10, 2013 at 04:35:51PM +0800, Peter Chen wrote: For mxs-phy user i.mx6q, the PHY's clock is controlled by hardware automatically, the software only needs to enable it at probe, this clock should be used like below: - Enable at mxs-phy's probe, and disable at mxs-phy's remove, so

Re: [alsa-devel] [PATCH v2 00/34] i.MX multi-platform support

On Sat, Sep 22, 2012 at 01:09:27AM -0700, Olof Johansson wrote: I've pulled this in now as staging/imx-multiplatform. As you mention, it might or might not make sense to send this up. It also accrued a few more merge conflicts with other branches in arm-soc, so we'll see how things play

Re: [alsa-devel] [PATCH v2 00/34] i.MX multi-platform support

Hi Olof, On Fri, Sep 21, 2012 at 01:26:43AM -0700, Olof Johansson wrote: I'll take a look at merging it tomorrow after I've dealt with smp_ops; if it looks reasonably conflict-free I'll pull it in. We need the sound dependency sorted out (or agreed upon) first though. I just published the

[PATCH v2 00/34] i.MX multi-platform support

-data arm-soc/multiplatform/smp_ops arm-soc/imx/cleanup arm-soc/imx/dt sound/for-3.7 Subsystem maintainers, I plan to send the whole series for 3.7 via arm-soc tree. Please let me know if you have problem with that. Thanks. Shawn --- Shawn Guo (34): ARM: imx: include board headers

[PATCH v2 16/34] usb: ehci-mxc: remove unneeded mach/hardware.h inclusion

The inclusion of mach/hardware.h is not used by the driver at all. Remove it. Signed-off-by: Shawn Guo shawn@linaro.org Acked-by: Sascha Hauer s.ha...@pengutronix.de Acked-by: Arnd Bergmann a...@arndb.de Acked-by: Greg Kroah-Hartman gre...@linuxfoundation.org Cc: linux-usb@vger.kernel.org

Re: [PATCH v2 00/34] i.MX multi-platform support

On Thu, Sep 20, 2012 at 07:41:50AM -0400, Mark Brown wrote: It's usually pretty early but Takashi will be on holiday this time so I'm not sure if things might be different (he was going to send the pull request from holiday). I also didn't guarantee that it'll be stable yet, can someone

Re: [PATCH v2 00/34] i.MX multi-platform support

On Thu, Sep 20, 2012 at 08:47:10AM -0400, Mark Brown wrote: On Thu, Sep 20, 2012 at 07:52:15PM +0800, Shawn Guo wrote: On Thu, Sep 20, 2012 at 07:41:50AM -0400, Mark Brown wrote: It's usually pretty early but Takashi will be on holiday this time so I'm not sure if things might

Re: [PATCH v2 00/34] i.MX multi-platform support

On Thu, Sep 20, 2012 at 07:39:34AM +, Arnd Bergmann wrote: The first five branches are scheduled to go through the arm-soc tree, so I'm fine with that. For the sound/for-3.7 branch, I'd like to know when to expect that hitting mainline. If it always gets in very early during the merge

Re: [alsa-devel] [PATCH 00/34] i.MX multi-platform support

On Tue, Sep 18, 2012 at 09:52:13AM +0200, Sascha Hauer wrote: I just had a look at the remaining initcalls in arch-imx. Most of them are protected with a cpu_is_*, but this one should be fixed before i.MX is enabled for multi platform:

Re: [PATCH 00/34] i.MX multi-platform support

On Mon, Sep 17, 2012 at 09:51:38AM +0200, Sascha Hauer wrote: I gave it a test on i.MX1, i.MX27, i.MX31 and i.MX35. All run fine, but the last patch breaks the imx_v4_v5_defconfig: Somehow it now defaults to ARMv7 based machines. I haven't looked into it, just reenabled ARMv4/ARMv5 and the

[PATCH 00/34] i.MX multi-platform support

are good. Thanks. Shawn Guo (34): ARM: imx: include board headers in the same folder ASoC: mx27vis: retrieve gpio numbers from platform_data ARM: imx: move iomux drivers and headers into mach-imx ARM: imx: remove unnecessary inclusion from device-imx*.h ARM: imx: move platform device code

[PATCH 17/34] usb: ehci-mxc: remove unneeded mach/hardware.h inclusion

The inclusion of mach/hardware.h is not used by the driver at all. Remove it. Signed-off-by: Shawn Guo shawn@linaro.org Cc: Greg Kroah-Hartman gre...@linuxfoundation.org Cc: linux-usb@vger.kernel.org --- drivers/usb/host/ehci-mxc.c |1 - 1 file changed, 1 deletion(-) diff --git

Re: [PATCH v6 1/3] USB: chipidea: add imx usbmisc support

On Tue, Sep 11, 2012 at 01:42:01PM +0300, Alexander Shishkin wrote: What about the other two patches? I guess they can go through arm tree so we don't have to send it through Greg, right? Right, those two will go via arm-soc tree once the first one gets applied on usb tree. -- Regards, Shawn

Re: [PATCH v3 2/3] ARM: dts: imx6q-sabrelite: add usbmisc device

The patch is doing a little bit more than what patch subject says. Please either come up with a better subject and commit message or split the patch to have it match the subject. On Thu, Jul 26, 2012 at 06:35:15PM +0800, Richard Zhao wrote: Signed-off-by: Richard Zhao richard.z...@freescale.com

  1   2   >