usb: gadget: f_fs: Add support for CCID descriptors.

2018-10-09 Thread Vincent Pelletier
Nothing to remap, only check length. Define a minimal structure for CCID descriptor only used to check length. As this descriptor shares the same value as HID descriptors, keep track and compare current interface's class to expected HID and CCID standard values. Signed-off-by: Vincent Pelletier

Re: usb: gadget: ffs: Fix BUG when userland exits with submitted AIO transfers

2018-09-25 Thread Vincent Pelletier
Hello, On Thu, 2 Aug 2018 14:23:51 +, Vincent Pelletier wrote: > On Thu, 2 Aug 2018 00:45:14 +, "He, Bo" wrote: > > Your patch fix the issue BUG: scheduling while atomic: > > Yes, although from my understanding of Felipe's answer, the actual bug > is the

Re: usb: gadget: ffs: Fix BUG when userland exits with submitted AIO transfers

2018-08-02 Thread Vincent Pelletier
o my patch addresses, still if my understanding is correct, the wrong half of the problem, and even introduced the regression you identified. Hence my uncertainty... -- Vincent Pelletier -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to ma

Re: usb: gadget: ffs: Fix BUG when userland exits with submitted AIO transfers

2018-08-01 Thread Vincent Pelletier
tual root cause. Should my patch be reverted ? It adds complexity which, I believe, becomes superfluous if dequeue does not sleep anywhere. Or maybe non-sleeping dequeue is not there yet, and a solution right now (later revertable) is better, in which case my change would be worth fixing ? --

Re: Regarding usb: gadget: ffs: Fix BUG when userland exits with submitted AIO transfers

2018-06-13 Thread Vincent Pelletier
of other tests until your mail. I reapplied my patch over Torvalds' master, cleaned the commit message and added a sign-off. I CC'ed you on the patch submission in case you want to add "tested-by". Regards, -- Vincent Pelletier -- To unsubscribe from this list: send the line "unsubscr

usb: gadget: ffs: Fix BUG when userland exits with submitted AIO transfers

2018-06-13 Thread Vincent Pelletier
00 GS: 0033 SS: 007b [ 382.232281] softirq: huh, entered softirq 9 RCU c10b4d90 with preempt_count 0100, exited with 0000? Signed-off-by: Vincent Pelletier --- drivers/usb/gadget/function/f_fs.c | 26 ++ 1 file changed, 18 insertions(+), 8 deletions(-) diff --git

Re: [RFC] Re: usb: gadget: ffs: Fix BUG when userland exits with submitted AIO transfers

2018-03-01 Thread Vincent Pelletier
Hello, On Sun, 7 Jan 2018 12:48:35 +, Vincent Pelletier <plr.vinc...@gmail.com> wrote: > Some update: this patch looks good on DWC3: both unplugging and > unbinding the UDC while AOI transfers are queued works fine. > > What I intended to do is to also test it on

Re: [RFC] Re: usb: gadget: ffs: Fix BUG when userland exits with submitted AIO transfers

2018-01-07 Thread Vincent Pelletier
On Fri, 1 Dec 2017 00:14:52 +, Vincent Pelletier <plr.vinc...@gmail.com> wrote: > I'll play some more with a kernel with this patch > to see if it breaks, and will resubmit if it looks fine. Some update: this patch looks good on DWC3: both unplugging and unbinding the UDC while A

Re: linux-next: Tree for Dec 14 (usb/dwc3)

2017-12-15 Thread Vincent Pelletier
is you need it. > > please do. write/readl tracepoints haven't changed in ages :-) Could it be related to this patch ? https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git/commit/?h=next=204ec1af6257a52fb80f43317f949b345040f9d1 It does touch dwc3_writel & dwc3_readl. -- Vincent

usb: dwc3: Make sparse a bit happier.

2017-11-30 Thread Vincent Pelletier
. Signed-off-by: Vincent Pelletier <plr.vinc...@gmail.com> --- drivers/usb/dwc3/trace.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/dwc3/trace.h b/drivers/usb/dwc3/trace.h index 6504b116da04..22f56fd3d6ce 100644 --- a/drivers/usb/dwc3/trace.h +++ b/drivers/us

Re: [RFC] Re: usb: gadget: ffs: Fix BUG when userland exits with submitted AIO transfers

2017-11-30 Thread Vincent Pelletier
ransfer. Actually, this is how I understood it. Sorry for not providing enough to make that clear (...and sorry for the terrible typos in that mail). Thanks for checking. I'll play some more with a kernel with this patch to see if it breaks, and will resubmit if it looks fine. Regards, --

[RFC] Re: usb: gadget: ffs: Fix BUG when userland exits with submitted AIO transfers

2017-11-30 Thread Vincent Pelletier
(tagging subject more ostensibly as RFC) On Tue, 28 Nov 2017 16:18:36 +, Vincent Pelletier <plr.vinc...@gmail.com> wrote: > - This change should have no effect on existing cancel/complete race > condition, which I expect is already handled in AIO. If not, then it's >

usb: dwc3: gadget: Wait longer for controller to end command processing

2017-11-30 Thread Vincent Pelletier
d 605 times [ 1222.024986] dwc3_send_gadget_ep_cmd(cmd=331016, params={0, 0, 0}) iterated 580 times [ 1317.590452] dwc3_send_gadget_ep_cmd(cmd=331016, params={0, 0, 0}) iterated 598 times [ 1453.218314] dwc3_send_gadget_ep_cmd(cmd=331016, params={0, 0, 0}) iterated 594 times Signed-off-by: V

[PATCH v2] usb: dwc3: gadget: Wait longer for controller to end command processing

2017-11-30 Thread Vincent Pelletier
Changes: - Added Signed-off-by. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

usb: dwc3: gadget: Wait longer for controller to end command processing

2017-11-30 Thread Vincent Pelletier
DWC3_DEPCMD_ENDTRANSFER has been witnessed to require around 600 iterations before controller would become idle again after unplugging the USB cable with AIO reads submitted. Bump timeout from 500 iterations to 1000 so dwc3_stop_active_transfer does not receive -ETIMEDOUT and does not WARN: [

Re: 4.14 dwc3 gadget mode WARNING on unplug

2017-11-29 Thread Vincent Pelletier
On Tue, 28 Nov 2017 16:31:48 +, Vincent Pelletier <plr.vinc...@gmail.com> wrote: > [ 81.326172] dwc3_send_gadget_ep_cmd -> -110 I increased "timeout" to 1000 and added this line: printk( "dwc3_send_gadget_ep_cmd(cmd=%i, params={%i, %i, %i}) iterated %i

4.14 dwc3 gadget mode WARNING on unplug

2017-11-28 Thread Vincent Pelletier
wc3.1.auto: request f5abd960 was not queued to ep2out [ 81.598618] ffs_aio_cancel_worker: -22 Regards, -- Vincent Pelletier -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at htt

usb: gadget: ffs: Fix BUG when userland exits with submitted AIO transfers

2017-11-28 Thread Vincent Pelletier
!! This is an RFC patch - hence sign-off absence !! This bug happens only when the UDC needs to sleep during usb_ep_dequeue, as is the case for (at least) dwc3. RFC: - I do not understand what eps_lock is supposed to protect in original ffs_aio_cancel implementation, especially once one

usb: gadget: ffs: Make sparse happier

2017-11-28 Thread Vincent Pelletier
' - different lock contexts for basic block Also, add an "unlocks spinlock" comment for consistency with existing ones. No behaviour change is intended. Signed-off-by: Vincent Pelletier <plr.vinc...@gmail.com> --- drivers/usb/gadget/function/f_fs.c | 9 ++--- 1 file changed, 6

Re: 4.14 dwc3 gadget mode panic

2017-11-27 Thread Vincent Pelletier
amp; io_data->ep && io_data->req)) { + INIT_WORK(_data->work, ffs_aio_cancel_worker); + queue_work(ffs->io_completion_wq, _data->work); + value = -EINPROGRESS; + } else value = -EINVAL; - spin_unlock_ir

Re: 4.14 dwc3 gadget mode panic

2017-11-26 Thread Vincent Pelletier
On Sat, 25 Nov 2017 16:39:52 +, Vincent Pelletier <plr.vinc...@gmail.com> wrote: > To my surprise, the error symptom do not seem to change: Having read some more on kernel debugging and especially critical sections, I realise that while the general issue is still there, the symptom d

usb: gadget: ffs: Forbid usb_ep_alloc_request from sleeping

2017-11-25 Thread Vincent Pelletier
0.868961] ESI: b7fbb660 EDI: b7aab000 EBP: bfb6c658 ESP: bfb6c638 [ 100.868973] DS: 007b ES: 007b FS: GS: 0033 SS: 007b Signed-off-by: Vincent Pelletier <plr.vinc...@gmail.com> --- drivers/usb/gadget/function/f_fs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/

Re: 4.14 dwc3 gadget mode panic

2017-11-25 Thread Vincent Pelletier
On Fri, 24 Nov 2017 14:04:35 +, Vincent Pelletier <plr.vinc...@gmail.com> wrote: > What seem to be the relevant pieces are: > - at least one AIO transfers submitted for reading from EP2OUT > - upon receiving data from stdin, a synchronous write happens on EP2IN, > which

Re: 4.14 dwc3 gadget mode panic

2017-11-24 Thread Vincent Pelletier
On Fri, 24 Nov 2017 15:55:02 +, Vincent Pelletier <plr.vinc...@gmail.com> wrote: > write(6, "bla\n", 4)= -1 EINTR (Interrupted system call) > --- SIGQUIT {si_signo=SIGQUIT, si_code=SI_USER, si_pid=1931, si_uid=1000} --- I discovered this

Re: 4.14 dwc3 gadget mode panic

2017-11-24 Thread Vincent Pelletier
On Fri, 24 Nov 2017 15:10:55 +, Vincent Pelletier <plr.vinc...@gmail.com> wrote: > It sadly does not help, though it does something: now serial output > stops early (tried twice, happened twice): > > [ 103.274725] BUG: scheduling while atomic: swapper/1/0/0x0100 > [

Re: 4.14 dwc3 gadget mode panic

2017-11-24 Thread Vincent Pelletier
s_callbacks+0x260/0x440 [ 103.281053] #1: (rcu_read_lock_sched){}, at: [] percpu_ref_switch_to_atomic_rcu+0xb0/0x130 [ 103.281097] #2: (&(>ctx_lock)->rlock){}, at: [] free_ioctx_us So I do not get dropped to kdb... -- Vincent Pelletier -- To unsubscribe from thi

Re: 4.14 dwc3 gadget mode panic

2017-11-24 Thread Vincent Pelletier
_lock_irqsave call early in the function. Regards, -- Vincent Pelletier -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

4.14 dwc3 gadget mode panic

2017-11-24 Thread Vincent Pelletier
2: 0001 CR3: 34c85000 CR4: 001006d0 Call Trace: ? __lock_acquire.isra.25+0x69a/0x840 ? rcu_cbs_completed+0x24/0x50 ? cpu_needs_another_gp+0x5c/0x70 ? rcu_process_callbacks+0x1c5/0x440 ? __softirqentry_text_start+0x8/0x8 ? do_softirq_own_stack+0x22/0x30 Code: Bad EIP value. Regards,

Re: [PATCH 23/24] USB: gadget: function: Remove redundant license text

2017-11-06 Thread Vincent Pelletier
license-description text was removed. > > Cc: Felipe Balbi <ba...@kernel.org> > Cc: Laurent Pinchart <laurent.pinch...@ideasonboard.com> > Cc: Oliver Neukum <oneu...@suse.com> > Cc: Johan Hovold <jo...@kernel.org> > Cc: Michal Nazarewicz <min...@mina86.

Re: Oops with dwc3 in device mode and functionfs

2017-03-26 Thread Vincent Pelletier
Hello, On Sun, Mar 26, 2017 at 9:20 PM, Andy Shevchenko <andriy.shevche...@linux.intel.com> wrote: > On Sat, 2017-03-25 at 08:06 +0900, Vincent Pelletier wrote: >> FWIW, at home enumeration happens much more reliably behind a hub than >> directly on a host (both being xHCI).

Re: Oops with dwc3 in device mode and functionfs

2017-03-24 Thread Vincent Pelletier
ctly on a host (both being xHCI). Maybe my edison board has some electrical issue a hub would tolerate better ? Regards, -- Vincent Pelletier -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

usb: gadget: f_fs: Fix ExtCompat documentation in uapi header

2017-02-17 Thread Vincent Pelletier
The code was fixed in commit 53642399aa71 ("usb: gadget: f_fs: Fix wrong check on reserved1 wof OS_DESC_EXT_COMPAT") but the in-header documentation kept referencing 0 as the expected value. Reference 1 instead as per original commit message. Signed-off-by: Vincent Pelletier

Re: [PATCH] Revert "usb: gadget: f_fs: Fix ExtCompat descriptor validation"

2017-02-16 Thread Vincent Pelletier
| * | 18 | Reserved | U8[6]| 0 | Regards, -- Vincent Pelletier -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: functionfs on dwc3, xhci host: endpoint cannot be used in both directions ?

2017-01-24 Thread Vincent Pelletier
gt; 8) Neither a bug nor new, but I thought I should mention it. Regards, -- Vincent Pelletier pgptUQkJbqZpi.pgp Description: Signature digitale OpenPGP

Re: functionfs on dwc3, xhci host: endpoint cannot be used in both directions ?

2017-01-24 Thread Vincent Pelletier
o userspace ? Actually, thinking a bit more about it I think epautoconf should only alter wMaxPacketSize when caller is probing the max supported value, and in such case provide the minimum between speed-dependent limit and controller limit. And I would remove the hardcoded 64B limit on non-SS bulk d

Re: functionfs on dwc3, xhci host: endpoint cannot be used in both directions ?

2017-01-23 Thread Vincent Pelletier
d it be possible to host the companion outside the edison module ? I have no idea how it is supposed to interract with the dwc3 and USB 2 phy). Regards, -- Vincent Pelletier -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kerne

Re: functionfs on dwc3, xhci host: endpoint cannot be used in both directions ?

2017-01-23 Thread Vincent Pelletier
= 0x001f0007 OCTL = 0x0040 OEVT = 0x8002 OSTS = 0x201f This is with the 30-endpoints function enabled and idling. Regards, -- Vincent Pelletier pgpwwD_oSMBpT.pgp Description: Signature digitale OpenPGP

Re: functionfs on dwc3, xhci host: endpoint cannot be used in both directions ?

2017-01-23 Thread Vincent Pelletier
Changes since try 1: - impove commit message a bit - #declare array size to avoid duplication -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

usb: gadget: f_fs: Accept up to 30 endpoints.

2017-01-23 Thread Vincent Pelletier
addresses, ignoring direction), because the first eps_addrmap entry is unused (it is a placeholder for endpoint zero). So increase eps_addrmap length by one to 31. Signed-off-by: Vincent Pelletier <plr.vinc...@gmail.com> --- drivers/usb/gadget/function/f_fs.c | 2 +- drivers/usb/gadget/function/

Re: functionfs on dwc3, xhci host: endpoint cannot be used in both directions ?

2017-01-23 Thread Vincent Pelletier
= 0x10420089 Regards, -- Vincent Pelletier pgp9ZJv9GNzfE.pgp Description: Signature digitale OpenPGP

Re: functionfs on dwc3, xhci host: endpoint cannot be used in both directions ?

2017-01-23 Thread Vincent Pelletier
. I also noticed your commit about dwc3 having problems when clearing halt of an already non-halted endpoint (and reciprocally), and I do clear halts in the device test program. I tried commenting that out in my program and merging your testing/next branch in my working copy, without any improvement.

Re: functionfs on dwc3, xhci host: endpoint cannot be used in both directions ?

2017-01-17 Thread Vincent Pelletier
On Mon, 16 Jan 2017 14:48:31 +, Vincent Pelletier <plr.vinc...@gmail.com> wrote: > 3) I declared 4 endpoints (2 IN, 2 OUT). And I went one level deeper >down the rabbit hole: now enumeration fails with this message on >host: Aaand... I dug this part of the hole myself.

usb: gadger: f_fs: Do not copy past descriptor end.

2017-01-17 Thread Vincent Pelletier
Endpoint descriptors come in 2 sizes, struct usb_endpoint_descriptor being the largest. Use bLength to stop on endpoint descriptor boundary, and not 2 bytes too far. Signed-off-by: Vincent Pelletier <plr.vinc...@gmail.com> --- drivers/usb/gadget/function/f_fs.c | 2 +- 1 file chan

[try2] usb: gadger: f_fs: Do not copy past descriptor end.

2017-01-17 Thread Vincent Pelletier
Changes since try1: - do not involve sizeof(*desc) in copy length. - remove explicit cast to size_t, which was needed to compare bLength to sizeof(). -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info

Re: functionfs on dwc3, xhci host: endpoint cannot be used in both directions ?

2017-01-16 Thread Vincent Pelletier
a while to figure several weeks ago. If that API allowed passing descriptor's speed around it would be possible, but that's way over my head at the moment - and not a blocker anyway. -- Vincent Pelletier -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the

Re: usb: gadger: f_fs: Do not copy past descriptor end.

2017-01-16 Thread Vincent Pelletier
size (the one declared as part of the ioctl code). But if it is fine for you I'll remove it. Regards, -- Vincent Pelletier pgp7Q1Q3jUjvQ.pgp Description: Signature digitale OpenPGP

usb: gadger: f_fs: Do not copy past descriptor end.

2017-01-16 Thread Vincent Pelletier
Endpoint descriptors come in 2 sizes, struct usb_endpoint_descriptor being the largest. Take bLength into account to not copy past the endpoint descriptor end, which could be the next descriptor or past interface descriptor (by 2 bytes). Signed-off-by: Vincent Pelletier <plr.vinc...@gmail.

Re: functionfs on dwc3, xhci host: endpoint cannot be used in both directions ?

2017-01-15 Thread Vincent Pelletier
On Mon, 16 Jan 2017 00:07:27 +, Vincent Pelletier <plr.vinc...@gmail.com> wrote: > Sometimes, ep0 just gets stuck during SET_CONFIGURATION, but then does > work for test's part which involves it. EP1 & above do not work. I should mention that re-trying SET_CONFIGURATION from h

Re: functionfs on dwc3, xhci host: endpoint cannot be used in both directions ?

2017-01-15 Thread Vincent Pelletier
xhci-cleanup branch from my usb.org tree > (see MAINTAINERS file for the URL. Hint, it's on git.kernel.org) and run > it on your xHCI side and *also* capture tracepoints from xHCI? Given that the USB analyser does see traffic on the bus and it's the device which NAKs, I think I can skip this - unless you think there is more to see there. Regards, -- Vincent Pelletier dwc3-trace.txt.gz Description: application/gzip

Re: functionfs on dwc3, xhci host: endpoint cannot be used in both directions ?

2017-01-15 Thread Vincent Pelletier
upport bidirectional-ish endpoints (same 4 LSb, different 1 MSb). Would this limitation be a hardware one ? - or the UDC endpoint auto-allocation mechanism must skip an endpoint when it is already used in the other direction Regards, -- Vincent Pelletier -- To unsubscribe from this list: s

functionfs on dwc3, xhci host: endpoint cannot be used in both directions ?

2017-01-15 Thread Vincent Pelletier
11-1 (2016-12-02) x86_64 GNU/Linux 00:14.0 USB controller: Intel Corporation Sunrise Point-H USB 3.0 xHCI Controller (rev 31) Subsystem: ASRock Incorporation Sunrise Point-H USB 3.0 xHCI Controller Kernel driver in use: xhci_hcd Kernel modules: xhci_pci Regards, -

usb: gadget: f_fs: Fix iterations on endpoints.

2017-01-09 Thread Vincent Pelletier
When zero endpoints are declared for a function, there is no endpoint to disable, enable or free, so replace do...while loops with while loops. Change pre-decrement to post-decrement to iterate the same number of times when there are endpoints to process. Signed-off-by: Vincent Pelletier

[try2] usb: gadget: f_fs: Fix iterations on endpoints.

2017-01-09 Thread Vincent Pelletier
Changes since first submission: - use my personal address for author & sign-off (no code change) -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

usb: gadget: f_fs: Fix iterations on endpoints.

2017-01-07 Thread Vincent Pelletier
From: Vincent Pelletier <vinc...@nexedi.com> When zero endpoints are declared for a function, there is no endpoint to disable, enable or free, so replace do...while loops with while loops. Change pre-decrement to post-decrement to iterate the same number of times when there are end

Re: Oops with dwc3 in device mode and functionfs

2017-01-06 Thread Vincent Pelletier
On Fri, 6 Jan 2017 15:21:17 +, Vincent Pelletier <plr.vinc...@gmail.com> wrote: > The next issue is that often (>9 times out of 10) the dwc3 fails to > respond to the SET_CONFIGURATION standard request. As a result, only > EP0 works. I captured a successful enumerati

Re: Oops with dwc3 in device mode and functionfs

2017-01-06 Thread Vincent Pelletier
On Tue, 3 Jan 2017 18:18:02 +0100, Vincent Pelletier <plr.vinc...@gmail.com> wrote: > Sadly, this fix alone is not enough to get a functional device. I did > not investigate much yet, and need to get some sleep. I investigated more. The next issue is that often (>9 times out

Re: Oops with dwc3 in device mode and functionfs

2017-01-03 Thread Vincent Pelletier
no endpoint is declared, which leads to an integer underflow and exceeding eps array end. - a function enabling/disabling endpoint 0 does not make sense to me (they are only supposed to care about their own descriptor, don't they ?) On Tue, Jan 3, 2017 at 3:49 PM, Vincent Pelletier <plr.vinc...@g

Oops with dwc3 in device mode and functionfs

2017-01-03 Thread Vincent Pelletier
ce this issue ? [1] https://github.com/andy-shev/linux/commits/eds [2] https://github.com/vpelletier/python-functionfs Regards, -- Vincent Pelletier -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More ma

Re: dwc3 gadget broken on 4.10-rc1 + Andy's Edison patches

2016-12-30 Thread Vincent Pelletier
...and I should have checked balbi/usb.git:testing/fixes, which already has a fix for it: https://git.kernel.org/cgit/linux/kernel/git/balbi/usb.git/commit/?h=testing/fixes=a3543b33edc746870a540d40bda2916a1d107185 Sorry for the noise. -- Vincent Pelletier -- To unsubscribe from this list

dwc3 gadget broken on 4.10-rc1 + Andy's Edison patches

2016-12-30 Thread Vincent Pelletier
nux/tree/eds as of 3cfd6f93b96355542e044240f2daf11840dda0b2 Regards, -- Vincent Pelletier -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[2/2] usb: gadget: f_fs: Fix ExtCompat descriptor validation

2016-12-15 Thread Vincent Pelletier
Reserved1 is documented as expected to be set to 0, but this test fails when it it set to 0. Reverse the condition. Signed-off-by: Vincent Pelletier <plr.vinc...@gmail.com> --- drivers/usb/gadget/function/f_fs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drive

[1/2] usb: gadget: f_fs: Document eventfd effect on descriptor format.

2016-12-15 Thread Vincent Pelletier
paragraph "9.6.7 String", and also checked to still be current in USB 3.0 spec paragraph "9.6.9 String". Signed-off-by: Vincent Pelletier <plr.vinc...@gmail.com> --- drivers/usb/gadget/function/f_fs.c | 4 ++-- include/uapi/linux/usb/functionfs.h | 1 + 2 files changed, 3

Re: [PATCH 2/3 v3] xhci: Fix race related to abort operation

2016-12-04 Thread Vincent Pelletier
a test, I tried to get the xhci driver to give up on initialise the controller (the bug I reported originally on 4.1.4) I failed to reproduce this bug, despite having applied the following revert: commit 4cfad5b7601a46b8f3c5b267abe52a9cbf77bdaf Author: Vincent Pelletier <plr.vinc...@gmail.com>

Re: [PATCH 2/3 v3] xhci: Fix race related to abort operation

2016-11-28 Thread Vincent Pelletier
without your patches, to compare boot failure rate. For reference, the I pushed the source I built in https://github.com/vpelletier/linux/tree/ts651_4.9-rc7 Please do check I did not do mistakes when resolving conflicts (the 2 last commits). Regards, -- Vincent Pelletier -- To unsubscribe from

Re: [PATCH 2/3 v3] xhci: Fix race related to abort operation

2016-11-28 Thread Vincent Pelletier
0-13) 6.2.0 20161109 Build command line: $ make deb-pkg Regards, -- Vincent Pelletier -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/3 v3] xhci: Fix race related to abort operation

2016-11-23 Thread Vincent Pelletier
ome stack protection feature error when being probed in gcc...). I should have time to try again this week-end, but please do not wait for me. Regards, -- Vincent Pelletier -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel

Re: [PATCH] xhci: give command abortion one more chance before killing xhci

2015-08-27 Thread Vincent Pelletier
...@linux.intel.com Tested-by: Vincent Pelletier plr.vinc...@gmail.com Regards, -- Vincent Pelletier -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [TESTPATCH] xhci: custom debug patch for command mismatch

2015-08-26 Thread Vincent Pelletier
suppose everything worked fine after this? Exactly. Just because that line happens more often than the HC dead - although I learned it does not happen systematically either. Should I try to trigger HC dead with your printk xhci patch ? Regards, -- Vincent Pelletier -- To unsubscribe from this list

Re: [TESTPATCH] xhci: custom debug patch for command mismatch

2015-08-25 Thread Vincent Pelletier
On Tue, 25 Aug 2015 14:51:56 +0300, Mathias Nyman mathias.ny...@linux.intel.com wrote: Add extra command ring, event ring and command queue debugging to get more info on command mismatch error triggered by Vincent Pelletier on BayTrail Thanks, applied, built and loaded on target. will blurt

Re: [TESTPATCH] xhci: custom debug patch for command mismatch

2015-08-25 Thread Vincent Pelletier
On Tue, 25 Aug 2015 21:09:20 +0200, Vincent Pelletier plr.vinc...@gmail.com wrote: I'm not sure how I'll get this (I have a lot to learn about kernel debugging). Answering to myself: log_buf_len kernel parameter. I sent you my dmesg off-list (335KB raw, 46KB gzipped). FWIW, I gave a try

Re: v4.1.4 xhci: 50%~66% chance of HC died; cleaning up on boot

2015-08-24 Thread Vincent Pelletier
connect Port 5: .0100 power Port 6: .0100 power Device Status: 0x0001 Self Powered -- Vincent Pelletier -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: v4.1.4 xhci: 50%~66% chance of HC died; cleaning up on boot

2015-08-24 Thread Vincent Pelletier
device. -- Vincent Pelletier -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v3] usb: dwc2: add support for big-endian Lantiq SoCs

2015-08-24 Thread Vincent Pelletier
reviewed and merged? I think it would be easier to redo this series than the other way around. sure thing, dropping from my queue for now. Thanks Antti for refreshing this patch ! Regards, -- Vincent Pelletier -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body

v4.1.4 xhci: 50%~66% chance of HC died; cleaning up on boot

2015-08-23 Thread Vincent Pelletier
dies so I can at least get the full logs written to disk ? (at a glance, I do not see one in the source) Regards, -- Vincent Pelletier -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH 1/2] usb: dwc2: Use platform endianness when accessing registers

2015-03-10 Thread Vincent Pelletier
below these, right ? Nice catch, thanks. Regards, -- Vincent Pelletier -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [RFC PATCH] usb: dwc2: Use platform endianness when accessing registers

2015-01-23 Thread Vincent Pelletier
it be better to wrap __raw_readl in a macro and call that everywhere rather than calling __raw_readl itself ? Regards, -- Vincent Pelletier -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: Suspected (out of tree) HCI issue

2015-01-18 Thread Vincent Pelletier
not functional. Is there some work in progress on this topic ? Or any idea on how it should be done ? Regards, -- Vincent Pelletier From 38b036a3854935a8a2b948ed02d3ec6ead732cba Mon Sep 17 00:00:00 2001 Message-Id: 38b036a3854935a8a2b948ed02d3ec6ead732cba.1421618396.git.plr.vinc...@gmail.com From

Suspected (out of tree) HCI issue

2014-11-26 Thread Vincent Pelletier
[usb_wwan] [1] http://wiki.openwrt.org/toh/tp-link/td-w8970 Regards, -- Vincent Pelletier -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: Suspected (out of tree) HCI issue

2014-11-26 Thread Vincent Pelletier
On Wed, 26 Nov 2014 21:18:55 +0100, Vincent Pelletier plr.vinc...@gmail.com wrote: with the only visible improvement of not getting errors when unplugging the modem on stuck process. ...actually, not even, I was expecting errors on the wrong terminal: they are still present. Just

Re: Suspected (out of tree) HCI issue

2014-11-26 Thread Vincent Pelletier
-specific (ex: 551 lines for ehci-terga.c). Such length should be in my reach, but the 6k lines of some non-[eo]hci are very likely not. I'll try to understand how this controller would fit in. Thanks a lot for your answers, -- Vincent Pelletier -- To unsubscribe from this list: send the line

Re: Device configuration fails on superspeed, succeeds on highspeed

2012-12-18 Thread Vincent Pelletier
. Regards, -- Vincent Pelletier -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: Device configuration fails on superspeed, succeeds on highspeed

2012-12-18 Thread Vincent Pelletier
checked my mail now. (sending test result threaded with patch) Regards, -- Vincent Pelletier -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] xhci: Handle HS bulk/ctrl endpoints that don't NAK.

2012-12-18 Thread Vincent Pelletier
the patch further ? I have several USB2 devices and a single USB3 HDD, but never paid attention at their bInterval. This was tested on (otherwise clean) kernel.org 3.6.10 . Regards, -- Vincent Pelletier -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message

Device configuration fails on superspeed, succeeds on highspeed

2012-12-16 Thread Vincent Pelletier
, -- Vincent Pelletier -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: Device configuration fails on superspeed, succeeds on highspeed

2012-12-16 Thread Vincent Pelletier
Le dimanche 16 décembre 2012 20:46:38, Vincent Pelletier a écrit : I checked the specs, and the warnings about wMaxPacketSize seem justified (although it's unclear to me wether wMaxPacketSize is restricted to exactly 512B in HS, or only upper-bound at 512B). Another reply to myself: Tested USB