[PATCH] net: qmi_wwan: Add Netgear Aircard 779S

2018-05-27 Thread Josh Hill
Add support for Netgear Aircard 779S Signed-off-by: Josh Hill <j...@joshuajhill.com> --- drivers/net/usb/qmi_wwan.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c index 42565dd..0946808 100644 --- a/drivers/net/usb/qmi_wwan.c

Re: 4879b7ae05 ("Merge tag 'dmaengine-4.12-rc1' of .."): WARNING: kernel stack regs at bd92bc2e in 01-cpu-hotplug:3811 has bad 'bp' value 000001be

2017-10-03 Thread Josh Poimboeuf
On Tue, Oct 03, 2017 at 11:45:38AM +0800, Fengguang Wu wrote: > Hi Josh, > > On Mon, Oct 02, 2017 at 04:31:09PM -0500, Josh Poimboeuf wrote: > > On Mon, Oct 02, 2017 at 04:26:54PM -0500, Josh Poimboeuf wrote: > > > Fengguang, assuming it's reliably recreatable, any chance

Re: 4879b7ae05 ("Merge tag 'dmaengine-4.12-rc1' of .."): WARNING: kernel stack regs at bd92bc2e in 01-cpu-hotplug:3811 has bad 'bp' value 000001be

2017-10-02 Thread Josh Poimboeuf
On Mon, Oct 02, 2017 at 02:58:08PM -0700, Linus Torvalds wrote: > On Mon, Oct 2, 2017 at 2:26 PM, Josh Poimboeuf <jpoim...@redhat.com> wrote: > > > > The bisect is pointing to a commit which is almost 5 months old, so this > > is pre-ORC. Kallsyms *is* enabled, but th

Re: 4879b7ae05 ("Merge tag 'dmaengine-4.12-rc1' of .."): WARNING: kernel stack regs at bd92bc2e in 01-cpu-hotplug:3811 has bad 'bp' value 000001be

2017-10-02 Thread Josh Poimboeuf
On Mon, Oct 02, 2017 at 04:26:54PM -0500, Josh Poimboeuf wrote: > Fengguang, assuming it's reliably recreatable, any chance you could > recreate with the following patch? Sorry, here's a version which actually compiles. diff --git a/arch/x86/kernel/unwind_frame.c b/arch/x86/kernel/unwind_f

Re: 4879b7ae05 ("Merge tag 'dmaengine-4.12-rc1' of .."): WARNING: kernel stack regs at bd92bc2e in 01-cpu-hotplug:3811 has bad 'bp' value 000001be

2017-10-02 Thread Josh Poimboeuf
On Mon, Oct 02, 2017 at 01:09:31PM -0700, Linus Torvalds wrote: > Bringing in Josh on this, because the merge commit gets fingered > because it seems to be an interaction between the new code from the > merge and the ORC unwinder changes. It's probably some almost trivial > cod

Re: Attaching multiple USB gadget devices per peripheral controller

2017-06-30 Thread Josh Litherland
! On Fri, Jun 30, 2017 at 10:43 AM, Alan Stern <st...@rowland.harvard.edu> wrote: > On Thu, 29 Jun 2017, Josh Litherland wrote: > >> I've been tinkering with developing a USB touchscreen gadget device on >> a board using a Mentor USB peripheral controller (driver musb-

Attaching multiple USB gadget devices per peripheral controller

2017-06-29 Thread Josh Litherland
using this controller, do I have that correct? Is there a peripheral controller out there that allows attachment of multiple gadgets (and is supported in Linux)? Thanks! -- Josh Litherland (j...@temp123.org) -- To unsubscribe from this list: send the line "unsubscribe linux-usb" i

Re: [PATCH] USB: serial: ftdi_sio: Add support for ICP DAS I-756xU devices

2016-03-19 Thread Josh Boyer
On Thu, Mar 10, 2016 at 9:48 AM, Josh Boyer <jwbo...@fedoraproject.org> wrote: > A Fedora user reports that the ftdi_sio driver works properly for the > ICP DAS I-7561U device. Further, the user manual for these devices > instructs users to load the driver and add the ids

Re: [PATCH] USB: input: powermate: fix oops with malicious USB descriptors

2016-03-14 Thread Josh Boyer
On Mon, Mar 14, 2016 at 12:15 PM, Greg Kroah-Hartman <gre...@linuxfoundation.org> wrote: > On Mon, Mar 14, 2016 at 10:12:53AM -0400, Josh Boyer wrote: >> The powermate driver expects at least one valid USB endpoint in its >> probe function. If given malicious descr

[PATCH] USB: iowarrior: fix oops with malicious USB descriptors

2016-03-14 Thread Josh Boyer
://seclists.org/bugtraq/2016/Mar/87 Reported-by: Ralf Spenneberg <r...@spenneberg.net> Cc: stable <sta...@vger.kernel.org> Signed-off-by: Josh Boyer <jwbo...@fedoraproject.org> --- drivers/usb/misc/iowarrior.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/usb/

[PATCH] USB: input: powermate: fix oops with malicious USB descriptors

2016-03-14 Thread Josh Boyer
: http://seclists.org/bugtraq/2016/Mar/85 Reported-by: Ralf Spenneberg <r...@spenneberg.net> Cc: stable <sta...@vger.kernel.org> Signed-off-by: Josh Boyer <jwbo...@fedoraproject.org> --- drivers/input/misc/powermate.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/

[PATCH] USB: serial: ftdi_sio: Add support for ICP DAS I-756xU devices

2016-03-10 Thread Josh Boyer
of the box instead of needing manual configuration. Reported-by: <thesou...@mail.ru> CC: stable <sta...@vger.kernel.org> Signed-off-by: Josh Boyer <jwbo...@fedoraproject.org> --- drivers/usb/serial/ftdi_sio.c | 4 drivers/usb/serial/ftdi_sio_ids.h | 8 2 files chan

Re: USB TrackPoint mouse non-functional with dock; works if direct

2015-12-08 Thread Josh Triplett
On Tue, Dec 08, 2015 at 11:04:00AM -0500, Alan Stern wrote: > On Mon, 7 Dec 2015, Josh Triplett wrote: > > > > You're looking at the wrong files. The files to monitor are the ones > > > in /sys/devices/pci:00/:00:14.0/usb2/2-3/2-3.1/2-3.1.2/power > > >

USB TrackPoint mouse non-functional with dock; works if direct

2015-12-07 Thread Josh Triplett
/2-3.1.2\:1.1/supports_autosuspend did say "1". However, the device didn't actually appear to have autosuspend *enabled*. I'd appreciate any suggestions for how to debug this issue. - Josh Triplett -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in t

Re: USB TrackPoint mouse non-functional with dock; works if direct

2015-12-07 Thread Josh Triplett
On Mon, Dec 07, 2015 at 02:29:39PM -0600, Felipe Balbi wrote: > > Hi, > > Josh Triplett <j...@joshtriplett.org> writes: > > I have a USB Lenovo ThinkPad Keyboard with TrackPoint (vendor:product > > 17ef:6009), and a ThinkPad Yoga 12 (Broadwell version) with O

Re: USB TrackPoint mouse non-functional with dock; works if direct

2015-12-07 Thread Josh Triplett
On Mon, Dec 07, 2015 at 03:03:40PM -0600, Felipe Balbi wrote: > Josh Triplett <j...@joshtriplett.org> writes: > >> > Looking at the sysfs path for the input device as shown in dmesg, > >> > /sys/devices/pci\:00/\:00\:14.0/usb2/2-3/2-3.1/2-3.1.2/2-3.1.2\:1.

Re: USB TrackPoint mouse non-functional with dock; works if direct

2015-12-07 Thread Josh Triplett
On Mon, Dec 07, 2015 at 03:45:23PM -0600, Felipe Balbi wrote: > > Hi, > > Josh Triplett <j...@joshtriplett.org> writes: > > On Mon, Dec 07, 2015 at 03:03:40PM -0600, Felipe Balbi wrote: > >> Josh Triplett <j...@joshtriplett.org> writes: > >> >

Re: USB TrackPoint mouse non-functional with dock; works if direct

2015-12-07 Thread Josh Triplett
On Mon, Dec 07, 2015 at 05:02:34PM -0500, Alan Stern wrote: > On Mon, 7 Dec 2015, Josh Triplett wrote: > > > The following files appear under the power directory when plugged in via > > the dock: > > > > ~$ head > > /sys/devices/pci:00/:00:14.0/usb2

Re: [PATCH] usb: interface: allow drivers declare number of endpoints they need

2015-12-01 Thread Josh Boyer
15+ years? >>> >>> We are less trusting now. Before we/some of the drivers believed that >>> if device has VID/PID that they recognize the rest of descriptors will >>> have the data we expect, but we can't rely on this anymore. >> >> There's lots of things we can't "rely on", and we have never been able >> to rely on, but this is going to require we touch every USB driver to >> make those changes, this one change isn't going to really do all that >> much to help out with that. >> >> Every USB driver _should_ be having a loop over all endpoints to find >> what they need/expect, and if it isn't there, then it needs to abort. >> Just checking the number of endpoints isn't ok, so I really think this >> isn't going to help all that much in the end... > > OK, fair enough. Maybe what is missing is something like: > > ep = usb_locate_endpoint(altsetting, type, direction); > if (!ep) { > ... > return -EINVAL; > } > > that would loop through endpoints so that drivers do not have to > open-code the loop and we indeed need to fix the drivers that blindly > grab endpoints at fixed offsets and expect them to be there and have > correct types. > > Let's consider this patch dropped. Since you're dropping this patch, are you going to take the patch Vladis originally sent for the aiptek driver? I'm not objecting to fixing this in a broader sense, but it might be good to get existing fixes in before the whole rework is done. josh -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] hid: usbhid: hid-core: fix recursive deadlock

2015-11-18 Thread Josh Cartwright
deadlock still happens with interrupts > disabled. It is very weird, I know. I think your best course of action is to figure out why this is the case, instead of continuing with trying to solve the symptoms. Do you have actual callstacks showing the cases where you hit? That might be useful to share (your lockdep picture cuts out the callstacks). Also, have you tried without the PREEMPT_RT patch in the picture at all? Josh signature.asc Description: PGP signature

Re: First kernel patch (optimization)

2015-09-16 Thread Josh Boyer
e meantime, actually being encouraging and helpful to a new contributor might pay off more in the long run. You guys might seriously want to consider doing that recruitment topic at kernel summit. josh -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/2] Bluetooth: Add reset_resume function

2015-06-02 Thread Josh Boyer
be using the uapi mechanism? I'm confused how they're exposed today, given that they aren't installed via 'make headers_install'. Is this manually synced with some other .h file in a userspace package? josh -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body

Re: 3.18 regression: Error while assigning device slot ID, USB3 devices not detected

2015-01-19 Thread Josh Boyer
On Mon, Jan 19, 2015 at 8:33 AM, Greg KH gre...@linuxfoundation.org wrote: On Mon, Jan 19, 2015 at 08:28:19AM -0500, Josh Boyer wrote: On Sun, Jan 18, 2015 at 1:25 AM, Greg KH gre...@linuxfoundation.org wrote: On Sun, Jan 18, 2015 at 12:08:18AM -0600, Robert Hancock wrote: I've got an Intel

Re: 3.18 regression: Error while assigning device slot ID, USB3 devices not detected

2015-01-19 Thread Josh Boyer
On Mon, Jan 19, 2015 at 9:57 AM, Mathias Nyman mathias.ny...@linux.intel.com wrote: On 19.01.2015 15:47, Josh Boyer wrote: On Mon, Jan 19, 2015 at 8:33 AM, Greg KH gre...@linuxfoundation.org wrote: On Mon, Jan 19, 2015 at 08:28:19AM -0500, Josh Boyer wrote: On Sun, Jan 18, 2015 at 1:25 AM

Re: [PATCH v8 3/3] phy: Add Qualcomm DWC3 HS/SS PHY driver

2014-09-12 Thread Josh Cartwright
Hey Andy- Mostly cosmetic things below: On Fri, Sep 12, 2014 at 12:29:46PM -0500, Andy Gross wrote: This patch adds a new driver for the Qualcomm USB 3.0 PHY that exists on some Qualcomm platforms. This driver uses the generic PHY framework and will interact with the DWC3 controller.

[PATCH 0/3] introduce assign_if() macros in attempt to reduce ifdeffery

2014-02-24 Thread Josh Cartwright
. This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. Josh Cartwright (3): typecheck: introduce assign_if() and assign_if_enabled() PM: define new ASSIGN_*_PM_OPS macros based

[PATCH 3/3] usb: phy: msm: use ASSIGN_*_PM_OPS variants

2014-02-24 Thread Josh Cartwright
Use ASSIGN_SYSTEM_SLEEP_PM_OPS and ASSIGN_RUNTIME_PM_OPS in the initializer for msm_otg_dev_pm_ops. Doing so allows us to eliminate preprocessor conditionals around the specified callbacks. Signed-off-by: Josh Cartwright jo...@codeaurora.org --- drivers/usb/phy/phy-msm-usb.c | 13

Re: [PATCH v2] usb: phy: msm: fix compilation errors when !CONFIG_PM_SLEEP

2014-02-18 Thread Josh Cartwright
On Tue, Feb 18, 2014 at 10:24:16AM -0600, Felipe Balbi wrote: On Fri, Jan 17, 2014 at 12:26:50PM -0600, Josh Cartwright wrote: On Fri, Jan 17, 2014 at 11:58:51AM -0600, Josh Cartwright wrote: Both the PM_RUNTIME and PM_SLEEP callbacks call into the common msm_otg_{suspend,resume} routines

[PATCH RESEND v3] usb: phy: msm: fix compilation errors when !CONFIG_PM_SLEEP

2014-02-18 Thread Josh Cartwright
'msm_otg_resume' Cc: Ivan T. Ivanov iiva...@mm-sol.com Reported-by: Russell King rmk+ker...@arm.linux.org.uk Signed-off-by: Josh Cartwright jo...@codeaurora.org --- drivers/usb/phy/phy-msm-usb.c | 57 --- 1 file changed, 26 insertions(+), 31 deletions

Re: USB Device stops working after 200001 interrupts

2014-02-03 Thread Josh Bendavid
Alan Stern stern@... writes: On Mon, 3 Feb 2014, Josh Bendavid wrote: The output you're in fact looking for is attached below (ending with the nobody cared error). [ 1121.572119] ohci-pci :00:06.0: IRQ 199900 status 24 enable 805a [ 1121.588793] ohci-pci :00:06.0: IRQ

Re: USB Device stops working after 200001 interrupts

2014-02-03 Thread Josh Bendavid
Alan Stern stern@... writes: The dmesg output is normal. And yes, lack of any error does indicate that something is wrong with your controller. I don't think this problem can be fixed by a simple workaround. I've been considering adding an I/O watchdog to ohci-hcd, because it ought

Re: USB Device stops working after 200001 interrupts

2014-02-03 Thread Josh Bendavid
If the problem was indeed caused by software, there's a good chance you can track it down by doing a bisection search. That's a time-consuming procedure but it doesn't require much intellectual effort. Have you verified that the controller still works okay under a 3.5 kernel (to rule out

Re: USB Device stops working after 200001 interrupts

2014-02-02 Thread Josh Bendavid
Alan Stern stern@... writes: On Thu, 23 Jan 2014, Josh Bendavid wrote: Hi Alan, Is it understood why/how this always happens when the interrupt counter for this device reaches exactly 21? I would have assumed that this was a software counter in the kernel, in which case I don't

Re: USB Device stops working after 200001 interrupts

2014-02-02 Thread Josh Bendavid
These messages have no connection with the patch. What you should see, just once not long after you boot up or start using the device, is about 200 messages mentioning IRQ counts and register values (from the ohci_info call in the patch). Did the nobody cared error occur while you were

[PATCH v3] usb: phy: move some error messages to debug

2014-01-28 Thread Josh Boyer
to debugging only and we also add a PHY prefix or use dev_dbg so we know where they're coming from. Reported-by: Josh Boyer jwbo...@fedoraproject.org Signed-off-by: Felipe Balbi ba...@ti.com Signed-off-by: Josh Boyer jwbo...@fedoraproject.org --- v3: Use a prefix+pr_debug where dev_dbg won't easily

[PATCH v2] usb: phy: move some error messages to dev_dbg

2014-01-27 Thread Josh Boyer
to dev_dbg for debugging only and so we know where they're coming from. Reported-by: Josh Boyer jwbo...@fedoraproject.org Signed-off-by: Felipe Balbi ba...@ti.com Signed-off-by: Josh Boyer jwbo...@fedoraproject.org --- v2: Switch to using dev_dbg drivers/usb/phy/phy.c | 8 +++- 1 file changed, 3

Re: [PATCH v2] usb: phy: move some error messages to dev_dbg

2014-01-27 Thread Josh Boyer
On Mon, Jan 27, 2014 at 3:44 PM, Sergei Shtylyov sergei.shtyl...@cogentembedded.com wrote: Hello. On 01/27/2014 10:23 PM, Josh Boyer wrote: the PHY layer is supposed to be optional, considering some PHY have no control bus for SW to poke around. After commit 1ae5799 (usb: hcd

Re: [PATCH] usb: phy: move some error messages to debug

2014-01-27 Thread Josh Boyer
annoying error messages. In this patch we're decreasing those messages to debugging only and we also add a PHY prefix so we know where they're coming from. Reported-by: Josh Boyer jwbo...@fedoraproject.org Signed-off-by: Felipe Balbi ba...@ti.com Tested-by: Josh Boyer jwbo...@fedoraproject.org

Re: [PATCH v2] usb: phy: move some error messages to dev_dbg

2014-01-27 Thread Josh Boyer
On Mon, Jan 27, 2014 at 3:27 PM, Alan Stern st...@rowland.harvard.edu wrote: On Mon, 27 Jan 2014, Josh Boyer wrote: On Mon, Jan 27, 2014 at 3:44 PM, Sergei Shtylyov sergei.shtyl...@cogentembedded.com wrote: Hello. On 01/27/2014 10:23 PM, Josh Boyer wrote: the PHY layer is supposed

[PATCH] usb: phy: Quiet unable to find transceiver message

2014-01-25 Thread Josh Boyer
. Drop the severity of this message to pr_debug. Signed-off-by: Josh Boyer jwbo...@fedoraproject.org --- drivers/usb/phy/phy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/phy/phy.c b/drivers/usb/phy/phy.c index e6f61e4..c7fe880 100644 --- a/drivers/usb/phy/phy.c

Re: [PATCH] usb: phy: Quiet unable to find transceiver message

2014-01-25 Thread Josh Boyer
On Sat, Jan 25, 2014 at 10:37 AM, Alan Stern st...@rowland.harvard.edu wrote: On Sat, 25 Jan 2014, Josh Boyer wrote: commit 1ae5799ef6317 (usb: hcd: Initialize USB phy if needed) allows the USB layer to initialize external PHYs if needed. However, a PHY is not needed in all cases

Odd 'unable to find transceiver' messages from USB with v3.13-3260-g03d11a0 and later

2014-01-24 Thread Josh Boyer
is confusing. Thoughts? [1] https://bugzilla.redhat.com/show_bug.cgi?id=1057529 josh [1.683368] ehci_hcd: USB 2.0 'Enhanced' Host Controller (EHCI) Driver [1.683386] ehci-pci: EHCI PCI platform driver [1.684765] unable to find transceiver [1.684993] ehci-pci :00:1a.0: EHCI Host

Re: Odd 'unable to find transceiver' messages from USB with v3.13-3260-g03d11a0 and later

2014-01-24 Thread Josh Boyer
On Fri, Jan 24, 2014 at 2:08 PM, Felipe Balbi ba...@ti.com wrote: Hi, On Fri, Jan 24, 2014 at 08:47:07AM -0500, Josh Boyer wrote: We've had a report [1] of the USB layer throwing out 'unable to find transceiver' messages during boot with the 3.14 merge window kernels. I've seen this on my

Re: USB Device stops working after 200001 interrupts

2014-01-23 Thread Josh Bendavid
Alan Stern stern@... writes: On Thu, 23 Jan 2014, Josh Bendavid wrote: Hi Alan, Requested output below. For the trace at the bottom, most of the output just corresponds to me pressing buttons on the IR remote before it dies. I don't think there was any particular additional

USB Device stops working after 200001 interrupts

2014-01-22 Thread Josh Bendavid
I have a usb infrared remote receiver (Windows media center variety) which works correctly at boot, but stops working sometime later. Kernel gives: [ 1101.490321] irq 21: nobody cared (try booting with the irqpoll option) [ 1101.490328] CPU: 0 PID: 0 Comm: swapper/0 Tainted: P O 3.13.0-rc8 #1 [

[PATCH] usb: phy: msm: fix compilation errors when !CONFIG_PM_SLEEP

2014-01-17 Thread Josh Cartwright
'msm_otg_resume' Cc: Ivan T. Ivanov iiva...@mm-sol.com Reported-by: Russell King rmk+ker...@arm.linux.org.uk Signed-off-by: Josh Cartwright jo...@codeaurora.org --- drivers/usb/phy/phy-msm-usb.c | 57 --- 1 file changed, 26 insertions(+), 31 deletions

[PATCH v2] usb: phy: msm: fix compilation errors when !CONFIG_PM_SLEEP

2014-01-17 Thread Josh Cartwright
'msm_otg_resume' Cc: Ivan T. Ivanov iiva...@mm-sol.com Reported-by: Russell King rmk+ker...@arm.linux.org.uk Signed-off-by: Josh Cartwright jo...@codeaurora.org --- v1-v2: Change conditional to simply CONFIG_PM (thanks ccov and khilman!) drivers/usb/phy/phy-msm-usb.c | 57

Re: [PATCH v2] usb: phy: msm: fix compilation errors when !CONFIG_PM_SLEEP

2014-01-17 Thread Josh Cartwright
On Fri, Jan 17, 2014 at 11:58:51AM -0600, Josh Cartwright wrote: Both the PM_RUNTIME and PM_SLEEP callbacks call into the common msm_otg_{suspend,resume} routines, however these routines are only being built when CONFIG_PM_SLEEP. In addition, msm_otg_{suspend,resume} also depends

Re: [PATCH] drivers: dwc2: Mark function as static in core.c

2013-12-21 Thread Josh Triplett
for ‘dwc2_set_param_uframe_sched’ [-Wmissing-prototypes] Signed-off-by: Rashika Kheria rashika.khe...@gmail.com Reviewed-by: Josh Triplett j...@joshtriplett.org drivers/staging/dwc2/core.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/dwc2/core.c b

Re: [PATCH 4/7] drivers: usb: Include appropriate header file in pci-quirks.c

2013-12-19 Thread josh
-pci to want to know about the quirks of various PCI-based controllers, but it's not reasonable for pci-quirks.c to need to know about the details of HCDs. Sounds reasonable. - Josh Triplett -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord

Re: [PATCH 3/7] drivers: usb: Include appropriate header file in hcd.h

2013-12-19 Thread josh
in the source file. That has the advantage of not including any unnecessary headers if the dependencies shrink, and not requiring changes to multiple source files if the dependencies grow. Any particular objection to making the headers self-contained? - Josh Triplett -- To unsubscribe from

Re: [PATCH 3/7] drivers: usb: Include appropriate header file in hcd.h

2013-12-19 Thread josh
the preprocessor symbols that might change what a header defines. I'd argue for a best-effort policy, together with fixing headers whenever someone notices that they're *not* self-contained (in other words, they include a .h file to get a definition they need, and get a compile error). - Josh

Re: [PATCH 1/7] drivers: usb: Include appropriate header file in hcd.c

2013-12-19 Thread Josh Triplett
with 'sparse' or just a normal build, then that might be worth fixing up. Code that generates warnings with gcc -Wmissing-prototypes will also generate warnings with Sparse's (on by default) -Wdecl. (-Wdecl also warns about data, which gcc doesn't.) - Josh Triplett -- To unsubscribe from

Re: [PATCH 1/7] drivers: usb: Include appropriate header file in hcd.c

2013-12-19 Thread Josh Triplett
that don't really separate their internal headers from their external ones. There's a benefit to doing so, though: it ensures that the prototypes in the header stay in sync with the definition. - Josh Triplett -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body

Re: [3.8-rc3 - 3.8-rc4 regression] Re: [PATCH] module, async: async_synchronize_full() on module init iff async is used

2013-12-04 Thread Josh Hunt
On Tue, Dec 3, 2013 at 9:19 AM, Tejun Heo t...@kernel.org wrote: Hello, On Tue, Dec 03, 2013 at 08:28:43AM -0600, Josh Hunt wrote: You're right. Thanks for pointing this out. I did not realize there was a bug in the init script. The version of initramfs-tools I was using had the following

Re: [3.8-rc3 - 3.8-rc4 regression] Re: [PATCH] module, async: async_synchronize_full() on module init iff async is used

2013-12-03 Thread Josh Hunt
On Tue, Nov 26, 2013 at 4:29 PM, Tejun Heo t...@kernel.org wrote: Hello, On Tue, Nov 26, 2013 at 04:12:41PM -0600, Josh Hunt wrote: I should have clarified that I'm not using dm/md in my setup. I know the modules are getting loaded in the log I attached, but root is not a md/dm device. Can

Re: [3.8-rc3 - 3.8-rc4 regression] Re: [PATCH] module, async: async_synchronize_full() on module init iff async is used

2013-11-26 Thread Josh Hunt
-- Josh seriallog Description: Binary data

Re: [3.8-rc3 - 3.8-rc4 regression] Re: [PATCH] module, async: async_synchronize_full() on module init iff async is used

2013-11-26 Thread Josh Hunt
On Tue, Nov 26, 2013 at 3:53 PM, Linus Torvalds torva...@linux-foundation.org wrote: On Tue, Nov 26, 2013 at 1:29 PM, Josh Hunt joshhun...@gmail.com wrote: Both ahci and sata_svw call ata_host_activate(), which call ata_host_register() and async_schedule(async_port_probe, ap). Well

Re: [PATCH] usb: usb_phy_gen: refine conditional declaration of usb_nop_xceiv_register

2013-10-17 Thread Josh Boyer
the problem by reverting to the old conditional. Cc: Josh Boyer jwbo...@redhat.com Signed-off-by: Guenter Roeck li...@roeck-us.net I'm not entirely sure why I was CC'd on this one, but the patch looks good to me. I do wonder how many other uses of IS_ENABLED aren't taking this into account though

Re: [PATCH] usb: usb_phy_gen: refine conditional declaration of usb_nop_xceiv_register

2013-10-17 Thread Josh Boyer
On Thu, Oct 17, 2013 at 01:31:47PM -0700, Guenter Roeck wrote: On Thu, Oct 17, 2013 at 01:25:48PM -0400, Josh Boyer wrote: On Wed, Oct 16, 2013 at 07:18:41PM -0700, Guenter Roeck wrote: Commit 3fa4d734 (usb: phy: rename nop_usb_xceiv = usb_phy_gen_xceiv) changed the conditional around

Re: [PATCH v3 2/3] usb: phy: Add Qualcomm SS-USB and HS-USB drivers for DWC3 core

2013-08-14 Thread Josh Cartwright
On Wed, Aug 14, 2013 at 03:59:42PM +0300, Ivan T. Ivanov wrote: From: Ivan T. Ivanov iiva...@mm-sol.com These drivers handles control and configuration of the HS and SS USB PHY transceivers. They are part of the driver which manage Synopsys DesignWare USB3 controller stack inside Qualcomm

[PATCH] HID: usbhid: quirk for Realtek Multi-card reader

2013-03-18 Thread Josh Boyer
This device has an odd HID entry and causes a 10 second delay in boot. Add this device to the quirks list with HID_QUIRK_NO_INIT_REPORTS. This fixes Red Hat bugzilla https://bugzilla.redhat.com/show_bug.cgi?id=806587 Signed-off-by: Josh Boyer jwbo...@redhat.com --- drivers/hid/hid-ids.h

[PATCH] HID: usbhid: quirk for MSI GX680R led panel

2013-03-18 Thread Josh Boyer
This keyboard backlight device causes a 10 second delay to boot. Add it to the quirk list with HID_QUIRK_NO_INIT_REPORTS. This fixes Red Hat bugzilla https://bugzilla.redhat.com/show_bug.cgi?id=907221 Signed-off-by: Josh Boyer jwbo...@redhat.com --- drivers/hid/hid-ids.h | 3

Re: [PATCH] HID: usbhid: quirk for Realtek Multi-card reader

2013-03-18 Thread Josh Boyer
On Mon, Mar 18, 2013 at 02:52:32PM +0100, Jiri Kosina wrote: On Mon, 18 Mar 2013, Josh Boyer wrote: This device has an odd HID entry I can't really say I understand this portion of the changelog. I just took it from what Hans said in the bug. I believe I might have misunderstood. I

Re: [PATCH] HID: usbhid: quirk for MSI GX680R led panel

2013-03-18 Thread Josh Boyer
On Mon, Mar 18, 2013 at 02:54:58PM +0100, Jiri Kosina wrote: On Mon, 18 Mar 2013, Josh Boyer wrote: This keyboard backlight device causes a 10 second delay to boot. Add it to the quirk list with HID_QUIRK_NO_INIT_REPORTS. Applied, thanks. Ugh. Typo in this patch that prevents it from

[PATCH v2] HID: usbhid: quirk for MSI GX680R led panel

2013-03-18 Thread Josh Boyer
This keyboard backlight device causes a 10 second delay to boot. Add it to the quirk list with HID_QUIRK_NO_INIT_REPORTS. This fixes Red Hat bugzilla https://bugzilla.redhat.com/show_bug.cgi?id=907221 Signed-off-by: Josh Boyer jwbo...@redhat.com --- v2: Fix typo in vendor define drivers/hid

[PATCH] USB: usb-storage: unusual_devs update for Super TOP SATA bridge

2013-02-14 Thread Josh Boyer
bcdDevice as 2.20. Limit the UNUSUAL_DEV entry to devices less than 2.20. This fixes https://bugzilla.redhat.com/show_bug.cgi?id=909591 Reported-by: Carsten S. carste...@yahoo.com Tested-by: Carsten S. carste...@yahoo.com CC: sta...@vger.kernel.org Signed-off-by: Josh Boyer jwbo...@redhat.com

Re: USB autosuspend vs. URB submission

2013-01-08 Thread Josh Boyer
On Tue, Jan 08, 2013 at 10:51:20AM -0500, Alan Stern wrote: On Mon, 7 Jan 2013, Josh Boyer wrote: Hi, We've had a few reports in Fedora of users hitting the WARN_ONCE in drivers/usb/core/urb.c that prints a warning about a usb_submit_urb being called on an active URB. One of them[1

Re: USB keyboard backlight powering down.

2012-10-17 Thread Josh Boyer
pause to compose your thoughts, the first couple letters you type gets dropped. I know we fixed that bug for F17, F18, and rawhide. I did it myself. I don't think this is udev related, but we'll double check the version. Gerry, are you using udev-182-3.fc17 or newer on your F17 install? josh

Re: USB keyboard backlight powering down.

2012-10-17 Thread Josh Boyer
. Gerry, are you using udev-182-3.fc17 or newer on your F17 install? josh Installed Packages udev.x86_64182-1.fc17 @anaconda-0 There is an update available to 182-3 but I haven't installed