Re: [PATCH v4 1/2] usb: dwc2: alloc dma aligned buffer for isoc split in

Dear Doug, 在 2018年05月11日 05:01, Doug Anderson 写道: Hi, On Wed, May 9, 2018 at 3:11 AM, William Wu wrote: The commit 3bc04e28a030 ("usb: dwc2: host: Get aligned DMA in a more supported way") rips out a lot of code to simply the allocation of aligned DMA. However, it

Re: [PATCH v3 1/2] usb: dwc2: alloc dma aligned buffer for isoc split in

Dear Doug, 在 2018年05月11日 04:59, Doug Anderson 写道: Hi, On Wed, May 9, 2018 at 1:55 AM, wlf <w...@rock-chips.com> wrote: + } else if (hsotg->params.host_dma) { Are you sure this is "else if"? Can't you have descriptor DMA enabled in the controller and still need

Re: [PATCH v3 1/2] usb: dwc2: alloc dma aligned buffer for isoc split in

Dear Doug, 在 2018年05月08日 23:29, Doug Anderson 写道: Hi, On Tue, May 8, 2018 at 12:43 AM, wlf <w...@rock-chips.com> wrote: Dear Doug, 在 2018年05月08日 13:11, Doug Anderson 写道: Hi, On Mon, May 7, 2018 at 8:07 PM, William Wu <william...@rock-chips.com> wrote:

Re: [PATCH v3 1/2] usb: dwc2: alloc dma aligned buffer for isoc split in

Dear Doug, 在 2018年05月08日 13:11, Doug Anderson 写道: Hi, On Mon, May 7, 2018 at 8:07 PM, William Wu wrote: +static int dwc2_alloc_split_dma_aligned_buf(struct dwc2_hsotg *hsotg, + struct dwc2_qh *qh, +

Re: [PATCH v3 2/2] usb: dwc2: fix isoc split in transfer with no data

Dear Doug, 在 2018年05月08日 13:13, Doug Anderson 写道: Hi, On Mon, May 7, 2018 at 8:07 PM, William Wu wrote: If isoc split in transfer with no data (the length of DATA0 packet is zero), we can't simply return immediately. Because the DATA0 can be the first transaction

Re: [PATCH v2 1/2] usb: dwc2: alloc dma aligned buffer for isoc split in

Dear Doug, 在 2018年05月07日 15:19, Allen Hsu (許嘉銘) 写道: Add more: Best regards, BU4 EE Allen Hsu QCI 886-3-327-2345 ext 15410 -Original Message- From: Doug Anderson [mailto:diand...@google.com] Sent: Friday, May 4, 2018 11:58 PM To: wlf <w...@rock-chips.com> Cc: William Wu &l

Re: [PATCH v2 2/2] usb: dwc2: fix isoc split in transfer with no data

Dear Doug, 在 2018年05月02日 13:02, Doug Anderson 写道: Hi, On Tue, May 1, 2018 at 8:04 PM, William Wu wrote: If isoc split in transfer with no data (the length of DATA0 packet is zero), we can't simply return immediately. Because the DATA0 can be the first transaction

Re: [PATCH v2 1/2] usb: dwc2: alloc dma aligned buffer for isoc split in

Dear Doug, 在 2018年05月02日 12:33, Doug Anderson 写道: Hi, On Tue, May 1, 2018 at 8:04 PM, William Wu wrote: The commit 3bc04e28a030 ("usb: dwc2: host: Get aligned DMA in a more supported way") rips out a lot of code to simply the allocation of aligned DMA. However, it

Re: [PATCH 2/2] usb: dwc2: fix isoc split in transfer with no data

Dear Sergei, 在 2018年04月24日 16:27, Sergei Shtylyov 写道: Hello! On 4/24/2018 5:43 AM, William Wu wrote: If isoc split in transfer with no data (the length of DATA0 packet is 0), we can't simply return immediately. Because the DATA0 can be the first transaction or the second transaction for the

Re: [PATCH] usb: gadget: f_fs: get the correct address of comp_desc

Hi Jack, 在 2018年02月06日 02:17, Jack Pham 写道: Hi William, On Mon, Feb 05, 2018 at 07:33:38PM +0800, William Wu wrote: Refer to the USB 3.0 spec '9.6.7 SuperSpeed Endpoint Companion', the companion descriptor follows the standard endpoint descriptor. This descriptor is only defined for

Re: [PATCH] usb: dwc2: host: fix isoc urb actual length

Hi Alan, 在 2017年11月07日 23:18, Alan Stern 写道: On Tue, 7 Nov 2017, wlf wrote: That sounds like a good idea. Minas, does the following patch fix your problem? In theory we could do this calculation for every isochronous URB, not just those coming from usbfs. But I don't think there's any

Re: [PATCH] usb: dwc2: host: fix isoc urb actual length

Hi Alan, 在 2017年11月07日 03:17, Alan Stern 写道: On Mon, 6 Nov 2017, wlf wrote: Hi Minas, 在 2017年11月06日 17:28, Minas Harutyunyan 写道: Hi, On 11/6/2017 12:46 PM, William Wu wrote: The actual_length in dwc2_hcd_urb structure is used to indicate the total data length transferred so far

Re: [PATCH] usb: dwc2: host: fix isoc urb actual length

Hi Minas, 在 2017年11月06日 17:28, Minas Harutyunyan 写道: Hi, On 11/6/2017 12:46 PM, William Wu wrote: The actual_length in dwc2_hcd_urb structure is used to indicate the total data length transferred so far, but in dwc2_update_isoc_urb_state(), it just updates the actual_length of isoc frame, and

Re: [PATCH v2] usb: dwc3: add disable u2mac linestate check quirk

Dear Guenter， 在 2017年04月19日 13:15, Guenter Roeck 写道: On Tue, Apr 18, 2017 at 8:59 PM, wlf <w...@rock-chips.com> wrote: Dear Guenter, 在 2017年04月18日 21:18, Guenter Roeck 写道: On Mon, Apr 17, 2017 at 10:17 PM, William Wu <william...@rock-chips.com> wrote: This patch adds a quir

Re: [PATCH v2] usb: dwc3: add disable u2mac linestate check quirk

Dear Guenter, 在 2017年04月18日 21:18, Guenter Roeck 写道: On Mon, Apr 17, 2017 at 10:17 PM, William Wu wrote: This patch adds a quirk to disable USB 2.0 MAC linestate check during HS transmit. Refer the dwc3 databook, we can use it for some special platforms if the

Re: [PATCH] usb: host: xhci: plat: check hcc_params after add hcd

Hi Roger, 在 2017年01月13日 19:02, Roger Quadros 写道: Hi, On 13/01/17 05:18, William Wu wrote: From: William wu The commit 4ac53087d6d4 ("usb: xhci: plat: Create both HCDs before adding them") move add hcd to the end of probe, this cause hcc_params uninitiated, because

Re: [PATCH] usb: hcd: initialize hcd->flags to 0 when rm hcd

Hi Roger， 在 2017年01月12日 23:38, Roger Quadros 写道: On 12/01/17 17:33, Alan Stern wrote: On Thu, 12 Jan 2017, Roger Quadros wrote: William, On 12/01/17 14:03, William Wu wrote: From: William wu On some platforms(e.g. rk3399 board), we can call hcd_add/remove