Re: [PATCH] USB: change dev_WARN to dev_err triggerable from user space

2018-09-05 Thread Oliver Neukum
On Di, 2018-09-04 at 15:18 -0400, Alan Stern wrote: > On Tue, 4 Sep 2018, Johan Hovold wrote: > > > On Tue, Sep 04, 2018 at 12:21:09PM +0200, Oliver Neukum wrote: > > > On Di, 2018-09-04 at 11:31 +0200, Johan Hovold wrote: > > > > On Tue, Sep 04, 2018 at 10:44:41AM +0200, Oliver Neukum wrote: > >

Re: [PATCH] USB: change dev_WARN to dev_err triggerable from user space

2018-09-04 Thread Alan Stern
On Tue, 4 Sep 2018, Johan Hovold wrote: > On Tue, Sep 04, 2018 at 12:21:09PM +0200, Oliver Neukum wrote: > > On Di, 2018-09-04 at 11:31 +0200, Johan Hovold wrote: > > > On Tue, Sep 04, 2018 at 10:44:41AM +0200, Oliver Neukum wrote: > > > > For those people who run with panic_on_warn a WARN()

Re: [PATCH] USB: change dev_WARN to dev_err triggerable from user space

2018-09-04 Thread Johan Hovold
On Tue, Sep 04, 2018 at 12:21:09PM +0200, Oliver Neukum wrote: > On Di, 2018-09-04 at 11:31 +0200, Johan Hovold wrote: > > On Tue, Sep 04, 2018 at 10:44:41AM +0200, Oliver Neukum wrote: > > > For those people who run with panic_on_warn a WARN() triggered > > > from user space is a DOS. It is worth

Re: [PATCH] USB: change dev_WARN to dev_err triggerable from user space

2018-09-04 Thread Oliver Neukum
On Di, 2018-09-04 at 11:31 +0200, Johan Hovold wrote: > On Tue, Sep 04, 2018 at 10:44:41AM +0200, Oliver Neukum wrote: > > For those people who run with panic_on_warn a WARN() triggered > > from user space is a DOS. It is worth returning to dev_err() > > I think this should be dev_warn() unless

Re: [PATCH] USB: change dev_WARN to dev_err triggerable from user space

2018-09-04 Thread Johan Hovold
On Tue, Sep 04, 2018 at 10:44:41AM +0200, Oliver Neukum wrote: > For those people who run with panic_on_warn a WARN() triggered > from user space is a DOS. It is worth returning to dev_err() I think this should be dev_warn() unless you want to bring back the returning of errors on these

[PATCH] USB: change dev_WARN to dev_err triggerable from user space

2018-09-04 Thread Oliver Neukum
For those people who run with panic_on_warn a WARN() triggered from user space is a DOS. It is worth returning to dev_err() Signed-off-by: Oliver Neukum Fixes: 0cb54a3e47cb4baf0bc7463f0a64cfeae5e35697 Reported-by: syzbot+843efa30c8821bd69...@syzkaller.appspotmail.com --- drivers/usb/core/urb.c