Re: [PATCH] USB: ftdi_sio: add GPIO support

2015-07-16 Thread Linus Walleij
On Sat, Jul 4, 2015 at 12:13 AM, Grant Likely grant.lik...@secretlab.ca wrote: On Tue, Jun 2, 2015 at 2:18 PM, Linus Walleij linus.wall...@linaro.org wrote: On Sat, May 30, 2015 at 10:29 PM, Grant Likely grant.lik...@secretlab.ca wrote: On Mon, Jul 7, 2014 at 6:31 PM, Greg Kroah-Hartman

Re: [PATCH] USB: ftdi_sio: add GPIO support

2015-07-03 Thread Grant Likely
On Tue, Jun 2, 2015 at 2:18 PM, Linus Walleij linus.wall...@linaro.org wrote: On Sat, May 30, 2015 at 10:29 PM, Grant Likely grant.lik...@secretlab.ca wrote: On Mon, Jul 7, 2014 at 6:31 PM, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: However is the MFD cell approach acceptable?

Re: [PATCH] USB: ftdi_sio: add GPIO support

2015-06-02 Thread Linus Walleij
On Sat, May 30, 2015 at 10:29 PM, Grant Likely grant.lik...@secretlab.ca wrote: On Mon, Jul 7, 2014 at 6:31 PM, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: However is the MFD cell approach acceptable? Yes it is. Going back to this old conversation... Actually, I disagree. There is

Re: [PATCH] USB: ftdi_sio: add GPIO support

2015-05-30 Thread Grant Likely
On Mon, Jul 7, 2014 at 6:31 PM, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: On Mon, Jul 07, 2014 at 12:44:28PM +0200, Linus Walleij wrote: On Fri, Jun 13, 2014 at 8:31 PM, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: On Fri, Jun 13, 2014 at 09:25:07AM +0200, Linus Walleij

Re: [PATCH] USB: ftdi_sio: add GPIO support

2014-07-07 Thread Linus Walleij
On Fri, Jun 13, 2014 at 8:31 PM, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: On Fri, Jun 13, 2014 at 09:25:07AM +0200, Linus Walleij wrote: But I also want to bring the device model into question: normally when a mother device spawns children across different subsystems we model them

Re: [PATCH] USB: ftdi_sio: add GPIO support

2014-07-07 Thread Greg Kroah-Hartman
On Mon, Jul 07, 2014 at 12:44:28PM +0200, Linus Walleij wrote: On Fri, Jun 13, 2014 at 8:31 PM, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: On Fri, Jun 13, 2014 at 09:25:07AM +0200, Linus Walleij wrote: But I also want to bring the device model into question: normally when a

Re: [PATCH] USB: ftdi_sio: add GPIO support

2014-06-16 Thread Philipp Hachtmann
Hi, Would this patch interfere with adding support for using the CBUS pins as GPIOs while operating in normal UART mode? Most interesting question! Care was taken to prevent using GPIOs if the serial device is in use and vice versa. What about CBUS GPIO support? Ok, so we're not

Re: [PATCH] USB: ftdi_sio: add GPIO support

2014-06-13 Thread Linus Walleij
On Mon, Jun 9, 2014 at 3:21 PM, Sascha Silbe x-li...@infra-silbe.de wrote: The chips can operate either in regular or in bitbang mode. Care was taken to prevent using GPIOs if the serial device is in use and vice versa. Very interesting patch! I've seen USB-based GPIO things before but never

Re: [PATCH] USB: ftdi_sio: add GPIO support

2014-06-13 Thread Greg Kroah-Hartman
On Fri, Jun 13, 2014 at 09:25:07AM +0200, Linus Walleij wrote: On Mon, Jun 9, 2014 at 3:21 PM, Sascha Silbe x-li...@infra-silbe.de wrote: The chips can operate either in regular or in bitbang mode. Care was taken to prevent using GPIOs if the serial device is in use and vice versa.

Re: [PATCH] USB: ftdi_sio: add GPIO support

2014-06-10 Thread Johan Hovold
On Mon, Jun 09, 2014 at 03:21:55PM +0200, Sascha Silbe wrote: Most FTDI USB serial / parallel adapter chips support an asynchronous bitbang mode. Make this functionality available as a GPIO controller so they can be used with the Linux GPIO API instead of requiring special user space software

Re: [PATCH] USB: ftdi_sio: add GPIO support

2014-06-09 Thread One Thousand Gnomes
#include linux/kernel.h #include linux/errno.h +#ifdef CONFIG_GPIOLIB +#include linux/gpio.h +#endif Please create a new struct, a new file and put all the GPIO stuff in there rather than #if bombing the driver. You can then declare blank methods for the gpio stuff if GPIO is not

Re: [PATCH] USB: ftdi_sio: add GPIO support

2014-06-09 Thread Sergei Shtylyov
Hello. On 06/09/2014 06:23 PM, One Thousand Gnomes wrote: #include linux/kernel.h #include linux/errno.h +#ifdef CONFIG_GPIOLIB +#include linux/gpio.h +#endif Please create a new struct, a new file and put all the GPIO stuff in there rather than #if bombing the driver. You can then