Re: [PATCH] USB: serial: cp210x: Adding tx_empty() to avoid cp2108 failure

On Thu, Oct 15, 2015 at 05:07:08PM -0500, Konstantin Shkolnyy wrote: > Occasionally, writing data and immediately closing the port makes cp2108 > stop responding. The device had to be unplugged to clear the error. > The failure is induced by shutting down the device while its Tx queue still > has

Re: [PATCH] USB: serial: cp210x: Adding tx_empty() to avoid cp2108 failure

Hello. On 10/16/2015 1:07 AM, Konstantin Shkolnyy wrote: Occasionally, writing data and immediately closing the port makes cp2108 stop responding. The device had to be unplugged to clear the error. The failure is induced by shutting down the device while its Tx queue still has unsent data.

Re: [PATCH] USB: serial: cp210x: Adding tx_empty() to avoid cp2108 failure

Hello, On Fri, Oct 16, 2015 at 6:19 AM, Sergei Shtylyov wrote: [...] >> >> @@ -249,6 +251,16 @@ static struct usb_serial_driver * const >> serial_drivers[] = { >> #define CP210X_GET_CHARS 0x0E >> #define CP210X_GET_PROPS 0x0F >> #define

Re: [PATCH] USB: serial: cp210x: Adding tx_empty() to avoid cp2108 failure

On Fri, Oct 16, 2015 at 07:35:02AM -0500, Konstantin Shkolnyy wrote: > Hello, > > On Fri, Oct 16, 2015 at 6:19 AM, Sergei Shtylyov > wrote: > [...] > >> > >> @@ -249,6 +251,16 @@ static struct usb_serial_driver * const > >> serial_drivers[] = { > >> #define

Re: [PATCH] USB: serial: cp210x: Adding tx_empty() to avoid cp2108 failure

On Fri, Oct 16, 2015 at 7:55 AM, Johan Hovold wrote: > On Thu, Oct 15, 2015 at 05:07:08PM -0500, Konstantin Shkolnyy wrote: >> Occasionally, writing data and immediately closing the port makes cp2108 >> stop responding. The device had to be unplugged to clear the error. >> The

Re: [PATCH] USB: serial: cp210x: Adding tx_empty() to avoid cp2108 failure

On Fri, Oct 16, 2015 at 08:48:39AM -0500, Konstantin Shkolnyy wrote: > On Fri, Oct 16, 2015 at 7:55 AM, Johan Hovold wrote: > > On Thu, Oct 15, 2015 at 05:07:08PM -0500, Konstantin Shkolnyy wrote: > >> Occasionally, writing data and immediately closing the port makes cp2108 > >>

[PATCH] USB: serial: cp210x: Adding tx_empty() to avoid cp2108 failure

Occasionally, writing data and immediately closing the port makes cp2108 stop responding. The device had to be unplugged to clear the error. The failure is induced by shutting down the device while its Tx queue still has unsent data. Reporting the correct amount of those data avoids the problem.

[PATCH] USB: serial: cp210x: Adding tx_empty() to avoid cp2108 failure

Occasionally, writing data and immediately closing the port makes cp2108 stop responding. The device had to be unplugged to clear the error. The failure is induced by shutting down the device while its Tx queue still has unsent data. Reporting the correct amount of those data avoids the problem.