t; How do we know that it's safe for the other thread to drop the lock?
> >
> > There should at least be a long comment in front of the code explaining
> > why it's safe to steal the lock like this.
>
> Please review patch version 2: "[PATCH v2] usb: dwc2: Disable all
should at least be a long comment in front of the code explaining
> why it's safe to steal the lock like this.
Please review patch version 2: "[PATCH v2] usb: dwc2: Disable all EP's
on disconnect"
Thanks,
Minas
Hi Minas,
url:
https://github.com/0day-ci/linux/commits/Minas-Harutyunyan/usb-dwc2-Disable-all-EP-s-on-disconnect/20180919-104259
base: https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git next
smatch warnings:
drivers/usb/dwc2/gadget.c:4024 dwc2_hsotg_ep_disable() error: double
Hi Minas,
I love your patch! Perhaps something to improve:
[auto build test WARNING on balbi-usb/next]
[also build test WARNING on v4.19-rc4 next-20180918]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
Disabling all EP's allow to reset EP's to initial state.
On disconnect disable all EP's instead of just killing
all requests. Because of some platform didn't catch
disconnect event, same stuff added to
dwc2_hsotg_core_init_disconnected() function when USB
reset detected on the bus.
In