Re: [PATCH 07/12] usb: usbtmc: Add ioctl USBTMC488_IOCTL_WAIT_SRQ

Am Montag, den 28.05.2018, 10:59 + schrieb guido@kiener- muenchen.de: > > No, the problem is that you will underflow io->mutex > > > > Don't worry. The function usbtmc488_ioctl_wait_srq is called by > usbtmc_ioctl which already locks the mutex. See >

Re: [PATCH 07/12] usb: usbtmc: Add ioctl USBTMC488_IOCTL_WAIT_SRQ

Zitat von Oliver Neukum : Am Donnerstag, den 24.05.2018, 12:59 + schrieb guido@kiener- muenchen.de: Zitat von Oliver Neukum : > Am Donnerstag, den 17.05.2018, 19:03 +0200 schrieb Guido Kiener: > > +static int usbtmc488_ioctl_wait_srq(struct

Re: [PATCH 07/12] usb: usbtmc: Add ioctl USBTMC488_IOCTL_WAIT_SRQ

Am Donnerstag, den 24.05.2018, 12:59 + schrieb guido@kiener- muenchen.de: > Zitat von Oliver Neukum : > > > Am Donnerstag, den 17.05.2018, 19:03 +0200 schrieb Guido Kiener: > > > +static int usbtmc488_ioctl_wait_srq(struct usbtmc_file_data *file_data, > > > + 

Re: [PATCH 07/12] usb: usbtmc: Add ioctl USBTMC488_IOCTL_WAIT_SRQ

Zitat von Oliver Neukum : Am Donnerstag, den 17.05.2018, 19:03 +0200 schrieb Guido Kiener: +static int usbtmc488_ioctl_wait_srq(struct usbtmc_file_data *file_data, +   unsigned int __user *arg) +{ +   struct usbtmc_device_data *data =

Re: [PATCH 07/12] usb: usbtmc: Add ioctl USBTMC488_IOCTL_WAIT_SRQ

On Wed, May 23, 2018 at 02:08:27PM +0200, Oliver Neukum wrote: > Am Donnerstag, den 17.05.2018, 19:03 +0200 schrieb Guido Kiener: > > +static int usbtmc488_ioctl_wait_srq(struct usbtmc_file_data *file_data, > > +   unsigned int __user *arg) > > +{ > > +   struct

Re: [PATCH 07/12] usb: usbtmc: Add ioctl USBTMC488_IOCTL_WAIT_SRQ

Am Donnerstag, den 17.05.2018, 19:03 +0200 schrieb Guido Kiener: > +static int usbtmc488_ioctl_wait_srq(struct usbtmc_file_data *file_data, > +   unsigned int __user *arg) > +{ > +   struct usbtmc_device_data *data = file_data->data; > +   struct device *dev

Re: [PATCH 07/12] usb: usbtmc: Add ioctl USBTMC488_IOCTL_WAIT_SRQ

Zitat von Greg KH : On Fri, May 18, 2018 at 03:02:10PM +, gu...@kiener-muenchen.de wrote: Zitat von Greg KH : > On Thu, May 17, 2018 at 07:03:31PM +0200, Guido Kiener wrote: > > @@ -2420,8 +2476,8 @@ static int usbtmc_probe(struct

Re: [PATCH 07/12] usb: usbtmc: Add ioctl USBTMC488_IOCTL_WAIT_SRQ

On Fri, May 18, 2018 at 03:02:10PM +, gu...@kiener-muenchen.de wrote: > > Zitat von Greg KH : > > > On Thu, May 17, 2018 at 07:03:31PM +0200, Guido Kiener wrote: > > > @@ -2420,8 +2476,8 @@ static int usbtmc_probe(struct usb_interface *intf, > > > > > > retcode

Re: [PATCH 07/12] usb: usbtmc: Add ioctl USBTMC488_IOCTL_WAIT_SRQ

Zitat von Greg KH : On Thu, May 17, 2018 at 07:03:31PM +0200, Guido Kiener wrote: @@ -2420,8 +2476,8 @@ static int usbtmc_probe(struct usb_interface *intf, retcode = usb_register_dev(intf, _class); if (retcode) { - dev_err(>dev, "Not

Re: [PATCH 07/12] usb: usbtmc: Add ioctl USBTMC488_IOCTL_WAIT_SRQ

On Thu, May 17, 2018 at 07:03:31PM +0200, Guido Kiener wrote: > @@ -2420,8 +2476,8 @@ static int usbtmc_probe(struct usb_interface *intf, > > retcode = usb_register_dev(intf, _class); > if (retcode) { > - dev_err(>dev, "Not able to get a minor" > - "

[PATCH 07/12] usb: usbtmc: Add ioctl USBTMC488_IOCTL_WAIT_SRQ

Wait until an SRQ (service request) is received on the interrupt pipe or until the given period of time is expired. In contrast to the poll() function this ioctl does not return when other (a)synchronous I/O operations fail with EPOLLERR. Signed-off-by: Guido Kiener