Re: [PATCH 1/2] usb storage: group dependent USB storage Kconfig entries together

2018-08-09 Thread Vladimir Zapolskiy
Hi Alan, thank you for review. On 08/09/2018 05:01 PM, Alan Stern wrote: > On Thu, 9 Aug 2018, Vladimir Zapolskiy wrote: > >> Instead of explicit setting of USB_STORAGE dependency for every >> underlying build entries, exploit if USB_STORAGE / endif block. >> >> Signed-off-by: Vladimir

Re: [PATCH 1/2] usb storage: group dependent USB storage Kconfig entries together

2018-08-09 Thread Alan Stern
On Thu, 9 Aug 2018, Vladimir Zapolskiy wrote: > Instead of explicit setting of USB_STORAGE dependency for every > underlying build entries, exploit if USB_STORAGE / endif block. > > Signed-off-by: Vladimir Zapolskiy I think this is a worthwhile cleanup, although to make Greg happy you should

Re: [PATCH 1/2] usb storage: group dependent USB storage Kconfig entries together

2018-08-09 Thread Greg Kroah-Hartman
On Thu, Aug 09, 2018 at 01:01:54AM +0300, Vladimir Zapolskiy wrote: > Instead of explicit setting of USB_STORAGE dependency for every > underlying build entries, exploit if USB_STORAGE / endif block. Why change this? What benifit does this provide? thanks, greg k-h -- To unsubscribe from this

[PATCH 1/2] usb storage: group dependent USB storage Kconfig entries together

2018-08-08 Thread Vladimir Zapolskiy
Instead of explicit setting of USB_STORAGE dependency for every underlying build entries, exploit if USB_STORAGE / endif block. Signed-off-by: Vladimir Zapolskiy --- drivers/usb/storage/Kconfig | 20 +--- 1 file changed, 5 insertions(+), 15 deletions(-) diff --git