RE: [PATCH 2/4] usb: chipidea: imx: add HSIC support

2018-10-17 Thread Peter Chen
> > +static int ci_hdrc_imx_notify_event(struct ci_hdrc *ci, unsigned int > > +event) { > > + struct device *dev = ci->dev->parent; > > + struct ci_hdrc_imx_data *data = dev_get_drvdata(dev); > > + int ret = 0; > > + > > + switch (event) { > > + case CI_HDRC_IMX_HSIC_ACTIVE_EVENT: >

Re: [PATCH 2/4] usb: chipidea: imx: add HSIC support

2018-10-17 Thread Frieder Schrempf
Hi Peter, please see my comments below. For reference I also pushed the changes here: https://github.com/fschrempf/linux/commits/usb-hsic-test On 16.10.18 07:01, Peter Chen wrote: To support imx HSIC, there are some special requirement: - The HSIC pad is 1.2v, it may need to supply from

RE: [PATCH 2/4] usb: chipidea: imx: add HSIC support

2018-10-16 Thread Peter Chen
> Hi Peter, > > I love your patch! Yet something to improve: > > [auto build test ERROR on peter.chen-usb/ci-for-usb-next] [also build test > ERROR > on v4.19-rc8 next-20181012] [if your patch is applied to the wrong git tree, > please > drop us a note to help improve the system] > > url: >

Re: [PATCH 2/4] usb: chipidea: imx: add HSIC support

2018-10-15 Thread kbuild test robot
Hi Peter, I love your patch! Yet something to improve: [auto build test ERROR on peter.chen-usb/ci-for-usb-next] [also build test ERROR on v4.19-rc8 next-20181012] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

[PATCH 2/4] usb: chipidea: imx: add HSIC support

2018-10-15 Thread Peter Chen
To support imx HSIC, there are some special requirement: - The HSIC pad is 1.2v, it may need to supply from external - The data/strobe pin needs to be pulled down first, and after host mode is initialized, the strobe pin needs to be pulled up - During the USB suspend/resume, special setting is