Re: [PATCH 4/9] usb: phy: add the Berlin USB PHY driver

2014-06-19 Thread Felipe Balbi
On Fri, Jun 06, 2014 at 04:32:03PM +0530, Vivek Gautam wrote: Hi, On Fri, Jun 6, 2014 at 12:41 PM, Antoine Ténart antoine.ten...@free-electrons.com wrote: Hi, On Fri, Jun 06, 2014 at 12:09:06PM +0530, Vivek Gautam wrote: On Thu, Jun 5, 2014 at 9:18 PM, Antoine Ténart

Re: [PATCH 4/9] usb: phy: add the Berlin USB PHY driver

2014-06-09 Thread Jisheng Zhang
Dear Sebastian and Antoine, On Fri, 6 Jun 2014 03:54:06 -0700 Sebastian Hesselbarth sebastian.hesselba...@gmail.com wrote: + +#define to_berlin_phy_priv(p) container_of((p), struct berlin_phy_priv, phy) + +struct berlin_phy_priv { + void __iomem*base; + struct

Re: [PATCH 4/9] usb: phy: add the Berlin USB PHY driver

2014-06-09 Thread Sebastian Hesselbarth
On 06/09/2014 10:26 AM, Jisheng Zhang wrote: Dear Sebastian and Antoine, On Fri, 6 Jun 2014 03:54:06 -0700 Sebastian Hesselbarth sebastian.hesselba...@gmail.com wrote: + +#define to_berlin_phy_priv(p) container_of((p), struct berlin_phy_priv, phy) + +struct berlin_phy_priv { +

Re: [PATCH 4/9] usb: phy: add the Berlin USB PHY driver

2014-06-09 Thread Alexandre Belloni
On 09/06/2014 at 12:11:57 +0200, Sebastian Hesselbarth wrote : Some BG2Q boards hardwired the vbus to be always powered on, we should continue the probe if vbus gpio is missing. Yeah, the same applies for regulators. But with the comments above, it should move to the controller stub

Re: [PATCH 4/9] usb: phy: add the Berlin USB PHY driver

2014-06-06 Thread Vivek Gautam
+ Kishon. Hi, On Thu, Jun 5, 2014 at 9:18 PM, Antoine Ténart antoine.ten...@free-electrons.com wrote: Add the driver driving the Marvell Berlin USB PHY. This allows to initialize the PHY and to use it from the USB driver later. Just out of curiosity, going forward we would like to have phy

Re: [PATCH 4/9] usb: phy: add the Berlin USB PHY driver

2014-06-06 Thread Antoine Ténart
Hi, On Fri, Jun 06, 2014 at 12:09:06PM +0530, Vivek Gautam wrote: On Thu, Jun 5, 2014 at 9:18 PM, Antoine Ténart antoine.ten...@free-electrons.com wrote: Add the driver driving the Marvell Berlin USB PHY. This allows to initialize the PHY and to use it from the USB driver later. Just out

Re: [PATCH 4/9] usb: phy: add the Berlin USB PHY driver

2014-06-06 Thread Sebastian Hesselbarth
On 06/05/2014 05:48 PM, Antoine Ténart wrote: Add the driver driving the Marvell Berlin USB PHY. This allows to initialize the PHY and to use it from the USB driver later. Signed-off-by: Antoine Ténart antoine.ten...@free-electrons.com --- drivers/usb/phy/Kconfig | 9 ++

Re: [PATCH 4/9] usb: phy: add the Berlin USB PHY driver

2014-06-06 Thread Vivek Gautam
Hi, On Fri, Jun 6, 2014 at 12:41 PM, Antoine Ténart antoine.ten...@free-electrons.com wrote: Hi, On Fri, Jun 06, 2014 at 12:09:06PM +0530, Vivek Gautam wrote: On Thu, Jun 5, 2014 at 9:18 PM, Antoine Ténart antoine.ten...@free-electrons.com wrote: Add the driver driving the Marvell Berlin

Re: [PATCH 4/9] usb: phy: add the Berlin USB PHY driver

2014-06-06 Thread Antoine Ténart
Sebastian, On Fri, Jun 06, 2014 at 12:54:06PM +0200, Sebastian Hesselbarth wrote: On 06/05/2014 05:48 PM, Antoine Ténart wrote: + +#include linux/gpio.h +#include linux/io.h +#include linux/module.h +#include linux/of_gpio.h +#include linux/usb/phy.h +#include linux/platform_device.h

[PATCH 4/9] usb: phy: add the Berlin USB PHY driver

2014-06-05 Thread Antoine Ténart
Add the driver driving the Marvell Berlin USB PHY. This allows to initialize the PHY and to use it from the USB driver later. Signed-off-by: Antoine Ténart antoine.ten...@free-electrons.com --- drivers/usb/phy/Kconfig | 9 ++ drivers/usb/phy/Makefile | 1 +