Re: [PATCH RFC] ehci-omap: simple suspend implementation

2018-02-26 Thread Roger Quadros
Andreas, On 26/02/18 09:04, Andreas Kemnade wrote: > Hi, > > On Mon, 19 Feb 2018 11:41:36 +0200 > Roger Quadros wrote: > >> Andreas, >> >> On 16/02/18 20:35, Andreas Kemnade wrote: >>> On Fri, 16 Feb 2018 13:13:11 -0500 (EST) >>> Alan Stern wrote: >>>

Re: [PATCH RFC] ehci-omap: simple suspend implementation

2018-02-25 Thread Andreas Kemnade
Hi, On Mon, 19 Feb 2018 11:41:36 +0200 Roger Quadros wrote: > Andreas, > > On 16/02/18 20:35, Andreas Kemnade wrote: > > On Fri, 16 Feb 2018 13:13:11 -0500 (EST) > > Alan Stern wrote: > > > >> On Fri, 16 Feb 2018, Andreas Kemnade wrote: > >> >

Re: [PATCH RFC] ehci-omap: simple suspend implementation

2018-02-20 Thread Andreas Kemnade
On Mon, 19 Feb 2018 11:41:36 +0200 Roger Quadros wrote: [...] > If the Hardware SAR (Save and restore) functionality is enabled then > everything will be restored by hardware after a sleep to wake transition. > > But you will need this patch to enable SAR for the USB power

Re: [PATCH RFC] ehci-omap: simple suspend implementation

2018-02-19 Thread Roger Quadros
Andreas, On 16/02/18 20:35, Andreas Kemnade wrote: > On Fri, 16 Feb 2018 13:13:11 -0500 (EST) > Alan Stern wrote: > >> On Fri, 16 Feb 2018, Andreas Kemnade wrote: >> >>> This powers down the phy and on a gta04 it reduces >>> suspend current by 13 mA. >>> For unknown

Re: [PATCH RFC] ehci-omap: simple suspend implementation

2018-02-16 Thread Alan Stern
On Fri, 16 Feb 2018, Andreas Kemnade wrote: > On Fri, 16 Feb 2018 13:13:11 -0500 (EST) > Alan Stern wrote: > > > On Fri, 16 Feb 2018, Andreas Kemnade wrote: > > > > > This powers down the phy and on a gta04 it reduces > > > suspend current by 13 mA. > > > For unknown

Re: [PATCH RFC] ehci-omap: simple suspend implementation

2018-02-16 Thread Andreas Kemnade
On Fri, 16 Feb 2018 13:13:11 -0500 (EST) Alan Stern wrote: > On Fri, 16 Feb 2018, Andreas Kemnade wrote: > > > This powers down the phy and on a gta04 it reduces > > suspend current by 13 mA. > > For unknown reasons usb does not power on properly. > > Also calling

Re: [PATCH RFC] ehci-omap: simple suspend implementation

2018-02-16 Thread Alan Stern
On Fri, 16 Feb 2018, Andreas Kemnade wrote: > This powers down the phy and on a gta04 it reduces > suspend current by 13 mA. > For unknown reasons usb does not power on properly. > Also calling usb_phy_shutdown() here feels wrong > apparently the reset line has to be activated. >

[PATCH RFC] ehci-omap: simple suspend implementation

2018-02-16 Thread Andreas Kemnade
This powers down the phy and on a gta04 it reduces suspend current by 13 mA. For unknown reasons usb does not power on properly. Also calling usb_phy_shutdown() here feels wrong apparently the reset line has to be activated. usb_phy_set_suspend is not enough here. The power consumption still stays