Re: [PATCH v12 1/2] i2c: buses: add i2c bus driver for NVIDIA GPU

2018-10-24 Thread Greg KH
On Wed, Oct 24, 2018 at 05:46:22PM +, Ajay Gupta wrote: > Hi Wolfram, > > > I don't think SMBus is an option in this case since the intended > > > client (Cypress something in patch 2/2) does xfers that would need > > > 16-bit commands and I think they are always 8-bit in SMBus, no? > > > >

RE: [PATCH v12 1/2] i2c: buses: add i2c bus driver for NVIDIA GPU

2018-10-24 Thread Ajay Gupta
Hi Wolfram, > > I don't think SMBus is an option in this case since the intended > > client (Cypress something in patch 2/2) does xfers that would need > > 16-bit commands and I think they are always 8-bit in SMBus, no? > > Yes. Command is 8 bit, data can be 16. Thanks for the heads up! Please

Re: [PATCH v12 1/2] i2c: buses: add i2c bus driver for NVIDIA GPU

2018-10-16 Thread Wolfram Sang
> I don't think SMBus is an option in this case since the intended client > (Cypress > something in patch 2/2) does xfers that would need 16-bit commands and I think > they are always 8-bit in SMBus, no? Yes. Command is 8 bit, data can be 16. Thanks for the heads up! signature.asc

Re: [PATCH v12 1/2] i2c: buses: add i2c bus driver for NVIDIA GPU

2018-10-16 Thread Peter Rosin
On 2018-10-02 09:27, Wolfram Sang wrote: > Hi, > We got confirmation from HW team about 4 byte read limitation. There has to be a STOP after every single read cycle. One read cycle supports maximum of 4 byte burst. I will update the patches with a comment on this. >>> >>>

RE: [PATCH v12 1/2] i2c: buses: add i2c bus driver for NVIDIA GPU

2018-10-02 Thread Ajay Gupta
Hi Wolfram, > > > > We got confirmation from HW team about 4 byte read limitation. > > > > There has to be a STOP after every single read cycle. One read > > > > cycle supports maximum of > > > > 4 byte burst. I will update the patches with a comment on this. > > > > > > Could it be that this is

Re: [PATCH v12 1/2] i2c: buses: add i2c bus driver for NVIDIA GPU

2018-10-02 Thread Wolfram Sang
Hi, > > > We got confirmation from HW team about 4 byte read limitation. There > > > has to be a STOP after every single read cycle. One read cycle > > > supports maximum of > > > 4 byte burst. I will update the patches with a comment on this. > > > > Could it be that this is more an SMBus

RE: [PATCH v12 1/2] i2c: buses: add i2c bus driver for NVIDIA GPU

2018-10-01 Thread Ajay Gupta
Hi Wolfram, > > > > > > Can we get the working set in while the issues is being debugged? > > > > > > > > > > I'm not the one making the decision, and I don't even know if > > > > > this is going through the i2c or the usb tree? If it's going > > > > > through the i2c tree you need a tag from the

RE: [PATCH v12 1/2] i2c: buses: add i2c bus driver for NVIDIA GPU

2018-10-01 Thread Ajay Gupta
Hi Peter, > I'm not the one making the decision, and I don't even know if this > is going through the i2c or the usb tree? If it's going through the > i2c tree you need a tag from the usb people (Greg?) on patch 2/2, > and if it's going through the usb tree, you need a tag

Re: [PATCH v12 1/2] i2c: buses: add i2c bus driver for NVIDIA GPU

2018-10-01 Thread Peter Rosin
On 2018-10-01 21:33, Ajay Gupta wrote: > Hi Heikki and Peter, > > Can we get the working set in while the issues is being debugged? I'm not the one making the decision, and I don't even know if this is going through the i2c or the usb tree? If it's going through the i2c

Re: [PATCH v12 1/2] i2c: buses: add i2c bus driver for NVIDIA GPU

2018-10-01 Thread Wolfram Sang
On Mon, Oct 01, 2018 at 07:33:02PM +, Ajay Gupta wrote: > Hi Heikki and Peter, > > > > > > Can we get the working set in while the issues is being debugged? > > > > > > > > I'm not the one making the decision, and I don't even know if this > > > > is going through the i2c or the usb tree? If

RE: [PATCH v12 1/2] i2c: buses: add i2c bus driver for NVIDIA GPU

2018-10-01 Thread Ajay Gupta
Hi Heikki and Peter, > > > > Can we get the working set in while the issues is being debugged? > > > > > > I'm not the one making the decision, and I don't even know if this > > > is going through the i2c or the usb tree? If it's going through the > > > i2c tree you need a tag from the usb people

RE: [PATCH v12 1/2] i2c: buses: add i2c bus driver for NVIDIA GPU

2018-09-13 Thread Ajay Gupta
Hi Heikki and Peter, > > > Can we get the working set in while the issues is being debugged? > > > > I'm not the one making the decision, and I don't even know if this is > > going through the i2c or the usb tree? If it's going through the i2c > > tree you need a tag from the usb people (Greg?)

Re: [PATCH v12 1/2] i2c: buses: add i2c bus driver for NVIDIA GPU

2018-09-13 Thread Heikki Krogerus
Hi, On Thu, Sep 13, 2018 at 09:36:58AM +0200, Peter Rosin wrote: > On 2018-09-13 00:22, Ajay Gupta wrote: > > Hi Peter, > > Can we get the working set in while the issues is being debugged? > > I'm not the one making the decision, and I don't even know if this > is going through the i2c or the

Re: [PATCH v12 1/2] i2c: buses: add i2c bus driver for NVIDIA GPU

2018-09-13 Thread Peter Rosin
On 2018-09-13 00:22, Ajay Gupta wrote: > Hi Peter, > Can we get the working set in while the issues is being debugged? I'm not the one making the decision, and I don't even know if this is going through the i2c or the usb tree? If it's going through the i2c tree you need a tag from the usb people

RE: [PATCH v12 1/2] i2c: buses: add i2c bus driver for NVIDIA GPU

2018-09-12 Thread Ajay Gupta
Hi Peter, > >>> This driver adds I2C bus driver to communicate with Type-C controller. > >>> I2C client driver will be part of USB Type-C UCSI driver. > >>> > >>> Signed-off-by: Ajay Gupta > >>> Reviewed-by: Andy Shevchenko > >>> Reviewed-by: Heikki Krogerus > >>> --- > >>> Changes from v1 ->

Re: [PATCH v12 1/2] i2c: buses: add i2c bus driver for NVIDIA GPU

2018-09-12 Thread Peter Rosin
On 2018-09-12 20:02, Ajay Gupta wrote: > Hi Peter, > >>> This driver adds I2C bus driver to communicate with Type-C controller. >>> I2C client driver will be part of USB Type-C UCSI driver. >>> >>> Signed-off-by: Ajay Gupta >>> Reviewed-by: Andy Shevchenko >>> Reviewed-by: Heikki Krogerus >>>

RE: [PATCH v12 1/2] i2c: buses: add i2c bus driver for NVIDIA GPU

2018-09-12 Thread Ajay Gupta
Hi Peter, > > This driver adds I2C bus driver to communicate with Type-C controller. > > I2C client driver will be part of USB Type-C UCSI driver. > > > > Signed-off-by: Ajay Gupta > > Reviewed-by: Andy Shevchenko > > Reviewed-by: Heikki Krogerus > > --- > > Changes from v1 -> v2 > > None

Re: [PATCH v12 1/2] i2c: buses: add i2c bus driver for NVIDIA GPU

2018-09-12 Thread Peter Rosin
On 2018-09-11 19:45, Ajay Gupta wrote: > Latest NVIDIA GPU card has USB Type-C interface. There is a > Type-C controller which can be accessed over I2C. > > This driver adds I2C bus driver to communicate with Type-C controller. > I2C client driver will be part of USB Type-C UCSI driver. > >

Re: [PATCH v12 1/2] i2c: buses: add i2c bus driver for NVIDIA GPU

2018-09-12 Thread Peter Rosin
On 2018-09-12 00:48, Ajay Gupta wrote: >> If it doesn't work, maybe you can tweak something in gpu_i2c_read_byte to >> make it work? > I tried a few tweaks but it didn't work that way. I think it may take time to > get > this part working. > > Can we update this part later when we have it

RE: [PATCH v12 1/2] i2c: buses: add i2c bus driver for NVIDIA GPU

2018-09-11 Thread Ajay Gupta
Hi Peter, > > Latest NVIDIA GPU card has USB Type-C interface. There is a Type-C > > controller which can be accessed over I2C. > > > > This driver adds I2C bus driver to communicate with Type-C controller. > > I2C client driver will be part of USB Type-C UCSI driver. > > > > Signed-off-by: Ajay

Re: [PATCH v12 1/2] i2c: buses: add i2c bus driver for NVIDIA GPU

2018-09-11 Thread Peter Rosin
On 2018-09-11 19:45, Ajay Gupta wrote: > Latest NVIDIA GPU card has USB Type-C interface. There is a > Type-C controller which can be accessed over I2C. > > This driver adds I2C bus driver to communicate with Type-C controller. > I2C client driver will be part of USB Type-C UCSI driver. > >

[PATCH v12 1/2] i2c: buses: add i2c bus driver for NVIDIA GPU

2018-09-11 Thread Ajay Gupta
Latest NVIDIA GPU card has USB Type-C interface. There is a Type-C controller which can be accessed over I2C. This driver adds I2C bus driver to communicate with Type-C controller. I2C client driver will be part of USB Type-C UCSI driver. Signed-off-by: Ajay Gupta Reviewed-by: Andy Shevchenko