Re: [PATCH v3 02/23] usb: usbtmc: Add ioctl for generic requests on control

2018-07-24 Thread guido
Zitat von Greg KH : On Tue, Jul 24, 2018 at 11:05:29AM +0200, Guido Kiener wrote: +struct usbtmc_ctrlrequest { + struct usbtmc_request req; + __u64 data; /* pointer to user space */ +} __attribute__ ((packed)); Hint, this structure could just be: struct

Re: [PATCH v3 02/23] usb: usbtmc: Add ioctl for generic requests on control

2018-07-24 Thread guido
Zitat von Greg KH : On Tue, Jul 24, 2018 at 11:05:29AM +0200, Guido Kiener wrote: Add USBTMC_IOCTL_CTRL_REQUEST to send arbitrary requests on the control pipe. Used by specific applications of IVI Foundation, Inc. to implement VISA API functions: viUsbControlIn/Out. The maximum length of

Re: [PATCH v3 02/23] usb: usbtmc: Add ioctl for generic requests on control

2018-07-24 Thread Greg KH
On Tue, Jul 24, 2018 at 11:05:29AM +0200, Guido Kiener wrote: > +struct usbtmc_ctrlrequest { > + struct usbtmc_request req; > + __u64 data; /* pointer to user space */ > +} __attribute__ ((packed)); Hint, this structure could just be: struct usbtmc_ctrlreqest {

Re: [PATCH v3 02/23] usb: usbtmc: Add ioctl for generic requests on control

2018-07-24 Thread Greg KH
On Tue, Jul 24, 2018 at 11:05:29AM +0200, Guido Kiener wrote: > Add USBTMC_IOCTL_CTRL_REQUEST to send arbitrary requests on the > control pipe. Used by specific applications of IVI Foundation, > Inc. to implement VISA API functions: viUsbControlIn/Out. > > The maximum length of control request

[PATCH v3 02/23] usb: usbtmc: Add ioctl for generic requests on control

2018-07-24 Thread Guido Kiener
Add USBTMC_IOCTL_CTRL_REQUEST to send arbitrary requests on the control pipe. Used by specific applications of IVI Foundation, Inc. to implement VISA API functions: viUsbControlIn/Out. The maximum length of control request is set to 4k. Signed-off-by: Guido Kiener Reviewed-by: Steve Bayless