Re: [PATCH v4 3/7] usb: mux: add common code for Intel dual role port mux

2016-03-19 Thread Lu Baolu
Hi Chanwoo, On 03/17/2016 02:07 PM, Chanwoo Choi wrote: > Hi Lu, > > To handle extcon (external connector), I implemented the unique id > for each external connector on patch[1] instead of using the ambiguous string > type. > [1] 2a9de9c0f08d6 (extcon: Use the unique id for external connector

Re: [PATCH v4 3/7] usb: mux: add common code for Intel dual role port mux

2016-03-19 Thread Chanwoo Choi
Hi Lu, To handle extcon (external connector), I implemented the unique id for each external connector on patch[1] instead of using the ambiguous string type. [1] 2a9de9c0f08d6 (extcon: Use the unique id for external connector instead of string) So I recommend that you should use the unique id

Re: [PATCH v4 3/7] usb: mux: add common code for Intel dual role port mux

2016-03-19 Thread Chanwoo Choi
Hi Lu, On 2016년 03월 17일 16:16, Lu Baolu wrote: > Hi Chanwoo, > > On 03/17/2016 02:07 PM, Chanwoo Choi wrote: >> Hi Lu, >> >> To handle extcon (external connector), I implemented the unique id >> for each external connector on patch[1] instead of using the ambiguous >> string type. >> [1]

Re: [PATCH v4 3/7] usb: mux: add common code for Intel dual role port mux

2016-03-18 Thread Lu Baolu
On 03/17/2016 03:27 PM, Chanwoo Choi wrote: > Hi Lu, > > On 2016년 03월 17일 16:16, Lu Baolu wrote: >> Hi Chanwoo, >> >> On 03/17/2016 02:07 PM, Chanwoo Choi wrote: >>> Hi Lu, >>> >>> To handle extcon (external connector), I implemented the unique id >>> for each external connector on patch[1]

[PATCH v4 3/7] usb: mux: add common code for Intel dual role port mux

2016-03-18 Thread Lu Baolu
Several Intel PCHs and SOCs have an internal mux that is used to share one USB port between device controller and host controller. A usb port mux could be abstracted as the following elements: 1) mux state: HOST or PERIPHERAL; 2) an extcon cable which triggers the change of mux state between