Re: [PATCHv4 1/2] usb: USB Type-C connector class

2016-07-05 Thread Heikki Krogerus
On Mon, Jul 04, 2016 at 10:45:02AM -0700, Guenter Roeck wrote: > On 07/04/2016 10:11 AM, Heikki Krogerus wrote: > [ ... ] > > > > > We should not forget also that the userspace can never rely on those > > > > details because of the fact that they simply will not always be > > > > available. > > >

Re: [PATCHv4 1/2] usb: USB Type-C connector class

2016-07-04 Thread Guenter Roeck
On 07/04/2016 10:11 AM, Heikki Krogerus wrote: [ ... ] We should not forget also that the userspace can never rely on those details because of the fact that they simply will not always be available. On the other side, not being able to rely on a well defined ABI makes the ABI much less

Re: [PATCHv4 1/2] usb: USB Type-C connector class

2016-07-04 Thread Heikki Krogerus
Hi Guenter, On Sun, Jul 03, 2016 at 02:28:44PM -0700, Guenter Roeck wrote: > On 07/03/2016 12:38 PM, Heikki Krogerus wrote: > > On Fri, Jul 01, 2016 at 07:33:12AM -0700, Guenter Roeck wrote: > > > On Fri, Jul 01, 2016 at 03:05:35PM +0300, Heikki Krogerus wrote: > > > > I've updated my github

Re: [PATCHv4 1/2] usb: USB Type-C connector class

2016-07-03 Thread Guenter Roeck
On 07/03/2016 12:38 PM, Heikki Krogerus wrote: On Fri, Jul 01, 2016 at 07:33:12AM -0700, Guenter Roeck wrote: On Fri, Jul 01, 2016 at 03:05:35PM +0300, Heikki Krogerus wrote: I've updated my github branch with a commit where both of these issues should be fixed. Can you give it a try? This

Re: [PATCHv4 1/2] usb: USB Type-C connector class

2016-07-03 Thread Heikki Krogerus
On Fri, Jul 01, 2016 at 07:33:12AM -0700, Guenter Roeck wrote: > On Fri, Jul 01, 2016 at 03:05:35PM +0300, Heikki Krogerus wrote: > > I've updated my github branch with a commit where both of these issues > > should be fixed. Can you give it a try? > > > > This is going to be very difficult. So

Re: [PATCHv4 1/2] usb: USB Type-C connector class

2016-07-01 Thread Guenter Roeck
On Fri, Jul 01, 2016 at 10:38:03AM +0300, Heikki Krogerus wrote: > On Thu, Jun 30, 2016 at 10:10:25AM -0700, Guenter Roeck wrote: > > On Wed, Jun 29, 2016 at 04:38:37PM +0300, Heikki Krogerus wrote: > > > The purpose of USB Type-C connector class is to provide > > > unified interface for the user

Re: [PATCHv4 1/2] usb: USB Type-C connector class

2016-07-01 Thread Guenter Roeck
On Fri, Jul 01, 2016 at 03:05:35PM +0300, Heikki Krogerus wrote: > On Fri, Jul 01, 2016 at 10:13:48AM +0300, Heikki Krogerus wrote: > > Hi Guenter, > > > > On Thu, Jun 30, 2016 at 03:02:20PM -0700, Guenter Roeck wrote: > > > > +static ssize_t > > > > +preferred_role_store(struct device *dev,

Re: [PATCHv4 1/2] usb: USB Type-C connector class

2016-07-01 Thread Heikki Krogerus
On Fri, Jul 01, 2016 at 10:13:48AM +0300, Heikki Krogerus wrote: > Hi Guenter, > > On Thu, Jun 30, 2016 at 03:02:20PM -0700, Guenter Roeck wrote: > > > +static ssize_t > > > +preferred_role_store(struct device *dev, struct device_attribute *attr, > > > + const char *buf, size_t size)

Re: [PATCHv4 1/2] usb: USB Type-C connector class

2016-07-01 Thread Heikki Krogerus
On Thu, Jun 30, 2016 at 10:10:25AM -0700, Guenter Roeck wrote: > On Wed, Jun 29, 2016 at 04:38:37PM +0300, Heikki Krogerus wrote: > > The purpose of USB Type-C connector class is to provide > > unified interface for the user space to get the status and > > basic information about USB Type-C

Re: [PATCHv4 1/2] usb: USB Type-C connector class

2016-07-01 Thread Heikki Krogerus
Hi Guenter, On Thu, Jun 30, 2016 at 03:02:20PM -0700, Guenter Roeck wrote: > > +static ssize_t > > +preferred_role_store(struct device *dev, struct device_attribute *attr, > > +const char *buf, size_t size) > > +{ > > + struct typec_port *port = to_typec_port(dev); > > + enum

Re: [PATCHv4 1/2] usb: USB Type-C connector class

2016-06-30 Thread Guenter Roeck
On Wed, Jun 29, 2016 at 04:38:37PM +0300, Heikki Krogerus wrote: > The purpose of USB Type-C connector class is to provide > unified interface for the user space to get the status and > basic information about USB Type-C connectors on a system, > control over data role swapping, and when the port

Re: [PATCHv4 1/2] usb: USB Type-C connector class

2016-06-30 Thread Guenter Roeck
On Wed, Jun 29, 2016 at 04:38:37PM +0300, Heikki Krogerus wrote: > The purpose of USB Type-C connector class is to provide > unified interface for the user space to get the status and > basic information about USB Type-C connectors on a system, > control over data role swapping, and when the port

[PATCHv4 1/2] usb: USB Type-C connector class

2016-06-29 Thread Heikki Krogerus
The purpose of USB Type-C connector class is to provide unified interface for the user space to get the status and basic information about USB Type-C connectors on a system, control over data role swapping, and when the port supports USB Power Delivery, also control over power role swapping and