Re: [PATCH] Revert "usb: chipidea: usbmisc_imx: delete clock information"

Hi Maciej, On Tue, Dec 15, 2015 at 6:19 PM, Maciej S. Szmigiero wrote: > Can we now use this change for repairing the USB support on UDOO board? > > This seems to work fine if not 100% correct: > --- a/arch/arm/boot/dts/imx6qdl-udoo.dtsi > +++

Re: [PATCH] Revert "usb: chipidea: usbmisc_imx: delete clock information"

Hi Peter, On 16.09.2015 05:05, Peter Chen wrote: >> On Mon, Sep 14, 2015 at 11:32 PM, Fabio Estevam >> wrote: >> >>> This did not help. >>> >>> It is getting late here, so I will be able to try more things tomorrow. >> >> I was able to fix it. Your initial patch had a missing

Re: [PATCH] Revert "usb: chipidea: usbmisc_imx: delete clock information"

On Tue, Dec 15, 2015 at 09:19:39PM +0100, Maciej S. Szmigiero wrote: > Hi Peter, > > On 16.09.2015 05:05, Peter Chen wrote: > >> On Mon, Sep 14, 2015 at 11:32 PM, Fabio Estevam > >> wrote: > >> > >>> This did not help. > >>> > >>> It is getting late here, so I will be able to

RE: [PATCH] Revert "usb: chipidea: usbmisc_imx: delete clock information"

> > On Mon, Sep 14, 2015 at 11:32 PM, Fabio Estevam > wrote: > > > This did not help. > > > > It is getting late here, so I will be able to try more things tomorrow. > > I was able to fix it. Your initial patch had a missing 'return 0' in > imx_prepare_enable_clks(),

Re: [PATCH] Revert "usb: chipidea: usbmisc_imx: delete clock information"

Hi Peter, On Mon, Sep 14, 2015 at 11:32 PM, Fabio Estevam wrote: > This did not help. > > It is getting late here, so I will be able to try more things tomorrow. I was able to fix it. Your initial patch had a missing 'return 0' in imx_prepare_enable_clks(), causing:

Re: [PATCH] Revert "usb: chipidea: usbmisc_imx: delete clock information"

On Mon, Sep 14, 2015 at 1:54 AM, Peter Chen wrote: > On Fri, Sep 11, 2015 at 10:17:20AM -0300, Fabio Estevam wrote: > Sorry, a bug at former patch, it the clk_ahb has been override. > Mind to try below one? Applied the patch and still see the issue: Booting Linux on

Re: [PATCH] Revert "usb: chipidea: usbmisc_imx: delete clock information"

On Mon, Sep 14, 2015 at 09:22:37AM -0300, Fabio Estevam wrote: > On Mon, Sep 14, 2015 at 1:54 AM, Peter Chen wrote: > > On Fri, Sep 11, 2015 at 10:17:20AM -0300, Fabio Estevam wrote: > > > Sorry, a bug at former patch, it the clk_ahb has been override. > > Mind to try

Re: [PATCH] Revert "usb: chipidea: usbmisc_imx: delete clock information"

On Mon, Sep 14, 2015 at 10:03 PM, Peter Chen wrote: > Would you try to insert udelay(100) at every clk_prepare_enable at > imx_prepare_enable_clks at ci_hdrc_imx.c? This did not help. It is getting late here, so I will be able to try more things tomorrow. Regards,

RE: [PATCH] Revert "usb: chipidea: usbmisc_imx: delete clock information"

> On Mon, Sep 14, 2015 at 10:03 PM, Peter Chen > wrote: > > > Would you try to insert udelay(100) at every clk_prepare_enable at > > imx_prepare_enable_clks at ci_hdrc_imx.c? > > This did not help. > > It is getting late here, so I will be able to try more things

Re: [PATCH] Revert "usb: chipidea: usbmisc_imx: delete clock information"

On Mon, Sep 14, 2015 at 10:59:29PM -0300, Fabio Estevam wrote: > On Mon, Sep 14, 2015 at 9:19 PM, Peter Chen wrote: > > > That's so strange, do we need to enable clk_ahb before than clk_ipg? > > Would you please try below diff based on my patch? > > Same kernel crash

Re: [PATCH] Revert "usb: chipidea: usbmisc_imx: delete clock information"

On Mon, Sep 14, 2015 at 09:22:37AM -0300, Fabio Estevam wrote: > On Mon, Sep 14, 2015 at 1:54 AM, Peter Chen wrote: > > On Fri, Sep 11, 2015 at 10:17:20AM -0300, Fabio Estevam wrote: > > > Sorry, a bug at former patch, it the clk_ahb has been override. > > Mind to try

Re: [PATCH] Revert "usb: chipidea: usbmisc_imx: delete clock information"

On Mon, Sep 14, 2015 at 9:19 PM, Peter Chen wrote: > That's so strange, do we need to enable clk_ahb before than clk_ipg? > Would you please try below diff based on my patch? Same kernel crash with this one applied on top of the previous one. > > Meanwhile, you may

Re: [PATCH] Revert "usb: chipidea: usbmisc_imx: delete clock information"

On Mon, Sep 14, 2015 at 9:50 PM, Peter Chen wrote: > > Would you try below? > > diff --git a/drivers/usb/chipidea/Makefile b/drivers/usb/chipidea/Makefile > index 4decb12..34e9f6e 100644 > --- a/drivers/usb/chipidea/Makefile > +++ b/drivers/usb/chipidea/Makefile > @@

Re: [PATCH] Revert "usb: chipidea: usbmisc_imx: delete clock information"

On Fri, Sep 11, 2015 at 10:17:20AM -0300, Fabio Estevam wrote: > On Fri, Sep 11, 2015 at 4:52 AM, Peter Chen wrote: > > > Hi Fabio, > > > > Would you please help to test build patches for this issue? > > Tested the patch on a mx27pdk running 4.2 and I got the same

Re: [PATCH] Revert "usb: chipidea: usbmisc_imx: delete clock information"

On Thu, Sep 10, 2015 at 10:25:49AM -0300, Fabio Estevam wrote: > Hi Peter, > > On Thu, Sep 10, 2015 at 4:21 AM, Peter Chen wrote: > > > Hi Fabio, > > > > I am back for this patch, but the dts is wrong for mx25/mx27, it should > > include three clocks for controller, I

Re: [PATCH] Revert "usb: chipidea: usbmisc_imx: delete clock information"

On Fri, Sep 11, 2015 at 4:52 AM, Peter Chen wrote: > Hi Fabio, > > Would you please help to test build patches for this issue? Tested the patch on a mx27pdk running 4.2 and I got the same crash: usbcore: registered new interface driver usb-storage Unhandled fault:

Re: [PATCH] Revert "usb: chipidea: usbmisc_imx: delete clock information"

On Wed, Jul 01, 2015 at 12:06:19PM -0300, Fabio Estevam wrote: > From: Fabio Estevam > > This reverts commit 73dea4a912b2bfe955305de4891018f9e71e399d. > > Since commit 73dea4a912b2("usb: chipidea: usbmisc_imx: delete clock > information") it is not possible to boot

Re: [PATCH] Revert "usb: chipidea: usbmisc_imx: delete clock information"

Hi Peter, On Thu, Sep 10, 2015 at 4:21 AM, Peter Chen wrote: > Hi Fabio, > > I am back for this patch, but the dts is wrong for mx25/mx27, it should > include three clocks for controller, I can change the driver, but > how to cover the old incorrect dts? For the

Re: [PATCH] Revert usb: chipidea: usbmisc_imx: delete clock information

On Thu, Jul 2, 2015 at 5:40 AM, Peter Chen peter.c...@freescale.com wrote: Sorry, I can't accept it, and it will remain the clock on, and break runtime pm feature. In fact, the core and non-core use the same clocks, and at imx27, it may need two or three clocks to let the controller work for

Re: [PATCH] Revert usb: chipidea: usbmisc_imx: delete clock information

On Mon, Aug 10, 2015 at 9:39 PM, Peter Chen peter.c...@freescale.com wrote: I would like to have an API like is_need_three_clks to distinguish one clk vs three clk cases, I will have a patch for it, would you help to test when the patch is ready? Sure, I will be glad to test it on my mx27pdk.

Re: [PATCH] Revert usb: chipidea: usbmisc_imx: delete clock information

On Mon, Aug 10, 2015 at 06:08:16PM -0300, Fabio Estevam wrote: On Thu, Jul 2, 2015 at 5:40 AM, Peter Chen peter.c...@freescale.com wrote: Sorry, I can't accept it, and it will remain the clock on, and break runtime pm feature. In fact, the core and non-core use the same clocks, and at

Re: [PATCH] Revert usb: chipidea: usbmisc_imx: delete clock information

On Wed, Jul 01, 2015 at 12:06:19PM -0300, Fabio Estevam wrote: From: Fabio Estevam fabio.este...@freescale.com This reverts commit 73dea4a912b2bfe955305de4891018f9e71e399d. Since commit 73dea4a912b2(usb: chipidea: usbmisc_imx: delete clock information) it is not possible to boot a kernel

Re: [PATCH] Revert usb: chipidea: usbmisc_imx: delete clock information

On 02.07.2015 10:40, Peter Chen wrote: On Wed, Jul 01, 2015 at 12:06:19PM -0300, Fabio Estevam wrote: From: Fabio Estevam fabio.este...@freescale.com This reverts commit 73dea4a912b2bfe955305de4891018f9e71e399d. Since commit 73dea4a912b2(usb: chipidea: usbmisc_imx: delete clock information)