Re: [PATCH 3/7] drivers: usb: Include appropriate header file in hcd.h

2013-12-19 Thread Alan Stern
On Thu, 19 Dec 2013, Rashika Kheria wrote: Include header file include/linux/usb.h in include/linux/usb/hcd.h because structures usb_device, usb_host_config and usb_interface have their definitions in include/linux/usb.h. This eliminates the following warning in include/linux/usb/hcd.h:

Re: [PATCH 3/7] drivers: usb: Include appropriate header file in hcd.h

2013-12-19 Thread Sergei Shtylyov
Hello. On 12/19/2013 06:45 PM, Alan Stern wrote: Include header file include/linux/usb.h in include/linux/usb/hcd.h because structures usb_device, usb_host_config and usb_interface have their definitions in include/linux/usb.h. This eliminates the following warning in

RE: [PATCH 3/7] drivers: usb: Include appropriate header file in hcd.h

2013-12-19 Thread David Laight
From: Rashika Kheria Include header file include/linux/usb.h in include/linux/usb/hcd.h because structures usb_device, usb_host_config and usb_interface have their definitions in include/linux/usb.h. This eliminates the following warning in include/linux/usb/hcd.h:

Re: [PATCH 3/7] drivers: usb: Include appropriate header file in hcd.h

2013-12-19 Thread josh
On Thu, Dec 19, 2013 at 10:45:42AM -0500, Alan Stern wrote: On Thu, 19 Dec 2013, Rashika Kheria wrote: Include header file include/linux/usb.h in include/linux/usb/hcd.h because structures usb_device, usb_host_config and usb_interface have their definitions in include/linux/usb.h.

Re: [PATCH 3/7] drivers: usb: Include appropriate header file in hcd.h

2013-12-19 Thread Alan Stern
On Thu, 19 Dec 2013, Sergei Shtylyov wrote: Hello. On 12/19/2013 06:45 PM, Alan Stern wrote: Include header file include/linux/usb.h in include/linux/usb/hcd.h because structures usb_device, usb_host_config and usb_interface have their definitions in include/linux/usb.h. This

Re: [PATCH 3/7] drivers: usb: Include appropriate header file in hcd.h

2013-12-19 Thread Alan Stern
On Thu, 19 Dec 2013 j...@joshtriplett.org wrote: Of course, people have varying opinions on this issue. As far as I know, there is no fixed policy in the kernel about nested includes. True. I personally prefer the policy of making all headers self-contained, and then only including

Re: [PATCH 3/7] drivers: usb: Include appropriate header file in hcd.h

2013-12-19 Thread Sergei Shtylyov
Hello. On 12/19/2013 07:38 PM, Alan Stern wrote: Include header file include/linux/usb.h in include/linux/usb/hcd.h because structures usb_device, usb_host_config and usb_interface have their definitions in include/linux/usb.h. This eliminates the following warning in

Re: [PATCH 3/7] drivers: usb: Include appropriate header file in hcd.h

2013-12-19 Thread josh
On Thu, Dec 19, 2013 at 11:48:15AM -0500, Alan Stern wrote: On Thu, 19 Dec 2013 j...@joshtriplett.org wrote: Of course, people have varying opinions on this issue. As far as I know, there is no fixed policy in the kernel about nested includes. True. I personally prefer the policy

Re: [PATCH 3/7] drivers: usb: Include appropriate header file in hcd.h

2013-12-19 Thread Sergei Shtylyov
Hello. On 12/19/2013 07:48 PM, Alan Stern wrote: Of course, people have varying opinions on this issue. As far as I know, there is no fixed policy in the kernel about nested includes. True. I personally prefer the policy of making all headers self-contained, and then only including

Re: [PATCH 3/7] drivers: usb: Include appropriate header file in hcd.h

2013-12-19 Thread Alan Stern
On Thu, 19 Dec 2013, Sergei Shtylyov wrote: I don't really see how C language design can justify header files that once included, require each .c file to #include other headers ahead of them, each time such header is used. In my opinion, it's just crazy. Okay, you've convinced me. In